[Freeciv-Dev] [bug #20738] Windows Vista/7/8 file locations

2016-01-18 Thread Marko Lindqvist 
Follow-up Comment #5, bug #20738 (project freeciv):

Are the stderr.txt and stdout.txt, in addition to *.RPT files, created by
exchndl.dll?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24320] Music- and soundspec issues

2016-01-18 Thread Frank 
Follow-up Comment #5, bug #24320 (project freeciv):

~/.freeciv/test and really wanting "+Freeciv-soundspec-Devel-2014.Mar.13" also
in dunnoob.soundspec if that also exists.

Otherwise it creates only "C:UserssysopAppDataLocalVirtualStoreProgram Files
(x86)Freeciv-2.5.99-alpha+r31157-gtk2stderr.txt", cf.
http://gna.org/bugs/?20738   

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20738] Windows Vista/7/8 file locations

2016-01-18 Thread Frank 
Follow-up Comment #4, bug #20738 (project freeciv):

Discussion continued in http://gna.org/patch/?6818

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6816] default.lua namespace

2016-01-18 Thread Marko Lindqvist 
Update of patch #6816 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6822] Hexemplio rivers.png update

2016-01-18 Thread Marko Lindqvist 
URL:
  

 Summary: Hexemplio rivers.png update
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 18 Jan 2016 02:58:51 PM EET
Category: art
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Update hexemplio rivers.png to a version provided by GriffonSpade on forums:
http://forum.freeciv.org/f/viewtopic.php?f=12=532=9

This also fixes a problem that our version still has 128 pixel wide sprites
(unlike other hexemplio terrains). Specfile change to use the new 126 pixel
wider sprite attached.

The new graphics contain some currently unused river mouth sprites needed once
patch #6351 has been resolved.



___

File Attachments:


---
Date: Mon 18 Jan 2016 02:58:51 PM EET  Name: Rivers126.patch  Size: 355B   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24321] Obsolete or insecure libraries

2016-01-18 Thread Frank 
Follow-up Comment #2, bug #24321 (project freeciv):

No, I'm not sure, I haven't used a compiler for years. But
http://www.libpng.org/pub/png/src/libpng-1.6.21-README.txt appears to be the
latest and greatest (2016-01-15). No new security issues, 1.6.20 could be also
good enough.

For OpenSSL see https://www.openssl.org/news/secadv/20151203.txt
Or in other words, if what you have is fresher than 2015-12-04 it's the best
you can do (as of today) for libssl/libeay.  



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24320] Music- and soundspec issues

2016-01-18 Thread Frank 
Follow-up Comment #3, bug #24320 (project freeciv):

I tested this in ~/.freeciv/2.6/dunnoob.musicspec

[musicspec]
; Format and options of this spec file:
options = "+Freeciv-musicspec-Devel-2014.Mar.13"

[info]
artists = "
"

[files]
music_menu = "dunnoob/freecol.ogg"
;music_victory = ""
...


When that failed (2.5.99 offered no dunnoob.musicspec in its "client options")
I copied it to ~/.freeciv/2.5/dunnoob.musicspec. Still no effect, I copied it
to ./data. That was visible, but apparently I didn't find
~/.freeciv/2.[56]/dunnoob/freecol.ogg, therefore I replaced
s,dunnoob/freecol.ogg,stdmusic/freecol.ogg, with freecol.ogg in
./data/stdmusic instead of ~/.freeciv/2.[56]/dunnoob (that worked). 

The new "client options" button in 2.5.99 gtk2 is nice. Or will be nice :-P
 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6518] foggedborders option(s) to always know own borders

2016-01-18 Thread Marko Lindqvist 
Follow-up Comment #1, patch #6518 (project freeciv):

>> [cazfi] You mean also those tiles that are not actually seen 
>> by the shared vision giver, but for which borders are known 
>> regardless? Why? I don't think there's even implementation 
>> cleanliness argument for this.

Here I probably were worried about potential timestamp/age related issues.
When one receives shared vision or map, merging to existing information would
no longer be of tile granularity, but it would be possible that one player has
more recent (but not necessarily current) information about border, and the
other more recent information about terrain etc.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24320] Music- and soundspec issues

2016-01-18 Thread Frank 
Follow-up Comment #4, bug #24320 (project freeciv):

~/.freciv/test instead of ~/.freeciv/2.6 for the alpha test, or is the test
directory at ./data/../test (well, that should b all plausible places, I'll
figure it out.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6820] Configure checks about functions needed for IPv6 support to work on crosser builds

2016-01-18 Thread Marko Lindqvist 
URL:
  

 Summary: Configure checks about functions needed for IPv6
support to work on crosser builds
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 18 Jan 2016 10:22:57 AM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: (2.5.3), 2.6.0, 3.0.0

___

Details:

This is the final patch to make configure of crosser based builds to pass so
that IPV6_SUPPORT gets set, and build then success (I've not yet been able to
test if the build also works on target evnironment) I assume that this is step
to right direction for other Windows building methods too.



___

File Attachments:


---
Date: Mon 18 Jan 2016 10:22:57 AM EET  Name: IPv6WinChecks.patch  Size: 1kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24132] Negative gold from unit removal collateral damage

2016-01-18 Thread Marko Lindqvist 
Follow-up Comment #3, bug #24132 (project freeciv):

Was this bug strictly caused by TRUNK development, or is it possibly present
in older branches in another form?

LT people report unit gold upkeep balance issues from S2_5...


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6793] Generate help entries for resources

2016-01-18 Thread Marko Lindqvist 
Update of patch #6793 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7963] Tracking release 2.6.0-beta1

2016-01-18 Thread Marko Lindqvist 
Update of task #7963 (project freeciv):

  Depends on: => patch #6818


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6818] Make Vista the minimum requirement for Windows Installer builds

2016-01-18 Thread Marko Lindqvist 
Follow-up Comment #3, patch #6818 (project freeciv):

Made this an dependency to "2.6.0-beta1" release as we don't want to increase
minimum requirements in the branch once first beta has been released.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24323] Server runs always with debug=3 when called from client

2016-01-18 Thread Christian Knoke 
URL:
  

 Summary: Server runs always with debug=3 when called from
client
 Project: Freeciv
Submitted by: chrisk
Submitted on: Mo 18 Jan 2016 19:29:51 CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1+r31482
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.5.2

___

Details:


Using SVN, compiled with options:
--enable-svnrev
--enable-gitrev
--enable-xml-registry
--with-followtag
--with-readline
--enable-freeciv-manual=html
--enable-sdl-mixer
--with-missinglist

i.e --enable-debug=some (default), starting

freeciv-gtk3 --log logfile

will call freeciv-server always with options --debug 3 and --log logfile. The
presence and value [1..3] of --debug option has no effect.

A missing --log option will call freeciv-server always without --debug and
--log, no matter what debug option was given to the client.

freeciv-gtk3 called with --debug 1 --log logfile will make run the server with
debug=3 and can (and probaly does on my system) slow down the server
significantly.

As mentioned elsewhere (by me), use of --enable-debug=yes has no effect in
this matter and the server is still called with debug=3.

Christian





___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6821] Do not run dev savegame compaitibility for 2.91.99 savegames

2016-01-18 Thread Marko Lindqvist 
URL:
  

 Summary: Do not run dev savegame compaitibility for 2.91.99
savegames
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 18 Jan 2016 01:33:30 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

If version of the development version savegame is at least 2.91.00, skip part
meant to convert older savegames. 



___

File Attachments:


---
Date: Mon 18 Jan 2016 01:33:30 PM EET  Name: SC291.patch  Size: 13kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24312] Include "turns idle" in the .sav

2016-01-18 Thread Marko Lindqvist 
Update of bug #24312 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24315] Scenario europe-200x100-v2 not in S2_6 format

2016-01-18 Thread Marko Lindqvist 
Update of bug #24315 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

Fix

(file #26366, file #26367)
___

Additional Item Attachment:

File name: Europe200x100S2_6Format.patch.bz2 Size:5 KB
File name: Europe200x100S2_6Format-S2_6.patch.bz2 Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20738] Windows Vista/7/8 file locations

2016-01-18 Thread Marko Lindqvist 
Follow-up Comment #6, bug #20738 (project freeciv):

While not providing actual usable solution for us, here's something confirming
that such a problem exist with exchndl.dll:

http://blog.toonormal.com/2012/12/02/how-to-actually-compile-and-use-exchndl-dll-drmingw/

"Relative the executable is alright for debugging, but once your game/app is
installed by a user you no longer have permission to write relative your
executable (unless you get elevated privileges)."

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24325] New terrain types in a ruleset can mess terrident map usage on loading of old savegame

2016-01-18 Thread Marko Lindqvist 
URL:
  

 Summary: New terrain types in a ruleset can mess terrident
map usage on loading of old savegame
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 18 Jan 2016 09:31:06 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

Terrain identifiers are required to be unique within a version of a ruleset.
Terrident map in a savegame lists mapping for those terrain types that existed
at the time of savegame creation.

Currently savegame loading code completes terrident mapping by using current
identifiers for the rest of the terrains. This can lead to a duplicate
identifier when a new terrain has been added to the ruleset since the savegame
creation and identifiers are rearranged so that this new terrain now has
identifier that was used for some terrain in savegame creation time.
For one terrain the identifier would be read from the savegame, and the new
one, not present in the savegame at all, would get it from the current ruleset
version.

Attached fix is as simple as not completing the terrident mapping for new
terrains. There should be no references to them in a savegame that was created
when they were not available in the ruleset at all.



___

File Attachments:


---
Date: Mon 18 Jan 2016 09:31:06 PM EET  Name: IdLoadForAllExisting.patch  Size:
2kB   By: cazfi


---
Date: Mon 18 Jan 2016 09:31:06 PM EET  Name: IdLoadForAllExisting-S2_6.patch 
Size: 850B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6824] act sel dlg: "Home City" button

2016-01-18 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: act sel dlg: "Home City" button
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 18 Jan 2016 11:26:59 PM UTC
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

A button in the action selection dialog communicates the uncertainty if a rule
depends on information the player doesn't have.



___

File Attachments:


---
Date: Mon 18 Jan 2016 11:26:59 PM UTC  Name:
0001-act-sel-dlg-list-Home-City.patch  Size: 9kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24309] Spaceship part auto placement failure causes server to use max cpu

2016-01-18 Thread Jacob Nevins 
Follow-up Comment #17, bug #24309 (project freeciv):

> (Jacob: let me know if you think it is to big so near the 2.5.2 
> release)
It's fine by me.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24319] No way to save scenario without random seeds

2016-01-18 Thread Marko Lindqvist 
Update of bug #24319 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #4:

Patch that keeps value of the settings separate from the actually used seeds
attached.

Is there something we want & can to do for S2_5?

(file #26381, file #26382)
___

Additional Item Attachment:

File name: SeedSettings.patch Size:5 KB
File name: SeedSettings-S2_6.patchSize:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6825] Ai to not to even consider treaties with someone with whom diplomacy is impossible

2016-01-18 Thread Marko Lindqvist 
Update of patch #6825 (project freeciv):

 Planned Release:2.6.0, 3.0.0 => 2.5.3, 2.6.0, 3.0.0

___

Follow-up Comment #1:

Also S2_5 version

(file #26385)
___

Additional Item Attachment:

File name: AiDiplomacyDontTryIllegal-S2_5.patch Size:13 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6825] Ai to not to even consider treaties with someone with whom diplomacy is impossible

2016-01-18 Thread Marko Lindqvist 
URL:
  

 Summary: Ai to not to even consider treaties with someone
with whom diplomacy is impossible
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 19 Jan 2016 07:40:50 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Size of the patch is mostly due to indentation change. The only thing really
changing is the addition of:

 if (get_player_bonus(aplayer, EFT_NO_DIPLOMACY) <= 0
 && diplomacy_possible(pplayer, aplayer)) {

and this block ending "}"




___

File Attachments:


---
Date: Tue 19 Jan 2016 07:40:51 AM EET  Name: AiDiplomacyDontTryIllegal.patch 
Size: 14kB   By: cazfi


---
Date: Tue 19 Jan 2016 07:40:51 AM EET  Name:
AiDiplomacyDontTryIllegal-S2_6.patch  Size: 14kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24328] A number of text buffers have insufficient size

2016-01-18 Thread Konstantin Vedeneev 
Follow-up Comment #2, bug #24328 (project freeciv):

Marko, thank you for the fast reply.

Test passed, file #26379 just summarize patches I've already tested on 2.5 and
2.6 (@svn).

With the current state of translations the bug is specific only to the Russian
locale, so there're no urgent need to postpone 2.5.2 release again.

I know Jacob hurry to issue release to push it into debian sid to have
ubuntu's net pulled Freeciv 2.5.2 before their package frozing. So there're no
need of brokenly patching 2.5 branch.

But 2.6 (and trunk too) have to be patched before first beta will be issued.

As I said in pps., there're can be buffers with insufficient size not related
to the bitwise settings. AFAIR, there was similar issue with city state in the
cities table, but I've just shortened the translation.

So, please leave this bug opened — I'll attach issues found after more deep
tests.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24328] A number of text buffers have insufficient size

2016-01-18 Thread Marko Lindqvist 
Update of bug #24328 (project freeciv):

Severity:   2 - Minor => 3 - Normal 
  Status:None => In Progress
 Assigned to:None => cazfi  
 Planned Release: => 2.5.3, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20738] Windows Vista/7/8 file locations

2016-01-18 Thread Marko Lindqvist 
Follow-up Comment #7, bug #20738 (project freeciv):

Does this failure to write files cause any other ill effects in addition to
failing itself?
In a way the "right thing to do" here would be just to drop the freeciv-side
support for creating these files as exchndl.dll & Windows do not support such
functionality. This could be as easy as not including exchndl.dll in freeciv
installer package so that freeciv would not load it (its presence is checked,
and there should be no error if it's not available, just lack of related
functionality). However, if it does not cause any harm, I think it's worth
keeping for those cases where it does work.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24132] Negative gold from unit removal collateral damage

2016-01-18 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #4, bug #24132 (project freeciv):

> is it possibly present in older branches in another form?
It is possible. If a unit can disappear between the paying of its upkeep and
the balancing of the treasury (that would result in the unit being disbanded
and its upkeep being payed back).

> LT people report unit gold upkeep balance issues from S2_5...
It could also be a *similar* bug.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24328] A number of text buffers have insufficient size

2016-01-18 Thread Konstantin Vedeneev 
URL:
  

 Summary: A number of text buffers have insufficient size
 Project: Freeciv
Submitted by: konved
Submitted on: Пн 18 янв 2016 21:27:11
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.x, 2.6, 3.0
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

The issue is related to the Russian i18n, but would be actual for other
languages with non-latin script (for ex: Hebrew, Arabic, Bulgarian, Ukrainian,
etc.), of course if their translators suddenly appear :).


23:35 konved@lark: ~/freeciv25 $ ./freeciv-server
Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8
Это сервер игры Freeciv версии 2.5.1+ (modified r31484)
[...]
> set airliftingstyle FROM_ALLIES|TO_ALLIES|SRC_UNLIMITED|DEST_UNLIMITED
Invalid string conversion from UTF-8 to UTF-8: Неверный или
неполный мультибайтный или широкий
символ.
Консоль: значение параметра 'airliftingstyle' было
изменено на "Переброска по воздуху из
союзных �, "Переброска по воздуху в
союзные г�, "Неограниченное число из
пункта от и "Неограниченное число в пункт
н�.
> show airliftingstyle 
--
В столбце '##' показана возможность
изменения значения параметра:
 — знак '!' означает, что изменение
параметра заблокировано набором правил.
 — знак '+' означает, что Вы можете изменить
значение параметра.
 — знак '=' означает, что параметр
установлен в значение по умолчанию.
--
Параметр  ## значение (мин, макс)
--
airliftingstyle   +  "Переброска по воздуху
Invalid string conversion from UTF-8 to UTF-8: Неверный или
неполный мультибайтный или широкий
символ.
 из союзных �,
 "Переброска по воздуху
Invalid string conversion from UTF-8 to UTF-8: Неверный или
неполный мультибайтный или широкий
символ.
 в союзные г�,
 "Неограниченное число
 из пункта от и
 "Неограниченное число
 в пункт назн

(FROM_ALLIES|TO_ALLIES|SRC_UNLIMITED|DEST_UNLIMITED)
--
Справка по каждому параметру доступна при
помощи команды 'help <параметр>'.
--
>

You can see that some lines are incorrectly cut.

Reference: Russian error text "Неверный или неполный
мультибайтный или широкий символ." came from
libc's i18n and means "Invalid or incomplete multibyte or wide character".

Reference 2: With Russian locale the nowadays string Q_("Allows units to be
airlifted from allied cities") have only 32 characters but is 75 (!) bytes
long in UTF-8 encoding (as strlen() reports).

The 'revealmap' setting have the same issue (/set revealmap DEAD).

Okay, let's start patching from setting_bitwise_to_str():

--- server/settings.c   (revision 31484)
+++ server/settings.c   (working copy)
@@ -3234,7 +3234,7 @@
   int bit;
 
   if (pretty) {
-char buf2[64];
+char buf2[128];


And we can see (I've dropped head of table):

> set airliftingstyle FROM_ALLIES|TO_ALLIES|SRC_UNLIMITED|DEST_UNLIMITED
Консоль: значение параметра 'airliftingstyle' было
изменено на "Переброска по воздуху из
союзных городов", "Переброска по воздуху в
союзные города", "Неограниченное число из
пункта отправления" и "Неогран.
> show airliftingstyle 
--
airliftingstyle   +  "Переброска по воздуху
 из союзных городов",
 "Переброска по воздуху
 в союзные города",
 "Неограниченное число
 из пункта отправления"
 и "Неограниченное
 число в пункт
 назначения"
 [](FROM_ALLIE|
--


Well, parts of and-list are no longer truncated but the entire list doesn't
fit into another buffer now.

_[some gdb poking skipped]_

Catched show_settings_one(). Patching...

--- server/console.h(revision 31484)
+++ server/console.h(working copy)
@@ -15,7 +15,7 @@
 
 #include "support.h"/* bool type and fc__attribute */
 
-#define MAX_LEN_CONSOLE_LINE 512

[Freeciv-Dev] [patch #6749] savegame3.c city field types

2016-01-18 Thread Marko Lindqvist 
Update of patch #6749 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

- Handle also compatibility conversion

(file #26378)
___

Additional Item Attachment:

File name: Sg3CityBools-2.patch   Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24328] A number of text buffers have insufficient size

2016-01-18 Thread Marko Lindqvist 
Update of bug #24328 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Fix

Since these are not regressions since 2.5.1 I would not postpone 2.5.2 release
any more for this. However, if release does not happen in 48 hours for other
reasons, I'm still about to commit this without then waiting until the
release. This is important, but low-risk, enough to get in that way.

(file #26379)
___

Additional Item Attachment:

File name: RussianBuffers.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6823] Gettext-0.19.7 bootstrap files

2016-01-18 Thread Marko Lindqvist 
URL:
  

 Summary: Gettext-0.19.7 bootstrap files
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 18 Jan 2016 10:08:33 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Update bootstrap files from gettext upstream to match gettext-0.19.7.



___

File Attachments:


---
Date: Mon 18 Jan 2016 10:08:33 PM EET  Name: GT0197.patch  Size: 13kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev