[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Update of bug #13891 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #17, bug #13891 (project freeciv): Done. (file #6543) ___ Additional Item Attachment: File name: client_implementation4.diffSize:13 KB ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Update of bug #13891 (project freeciv): Planned Release:None = 2.2.0 ___ Follow-up Comment #16: featured_text5.diff has been committed. Remaining minor nitpick about client-implementation3.diff is that all functions we are adding should have function header. Some of your static functions lack it. ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #14, bug #13891 (project freeciv): For translating unit name in server side, shouldn't it put translated name in unit_link() and text_tag_replace_text() to always use that name? Like you answered in the previous message, it depends of the local of the emitter. If the emitter is the server, there is no problem. If it's a client (with foreigner local), the server and the other clients might not translate it after... ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #13, bug #13891 (project freeciv): Actually this translation thing depends where message originates from. I plan to commit this patch as it is and to leave imrpovements to future tickets. ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #12, bug #13891 (project freeciv): For translating unit name in server side, shouldn't it put translated name in unit_link() and text_tag_replace_text() to always use that name? ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #10, bug #13891 (project freeciv): maybe it would try to translate the link name to the local language in text_tag_replace_text() Yes, that sounds like right thing to do. Just realized that rest of the message is translated at the server side. Link name also should be translated server side to make translation at least consistent, if not one translated for client's local language. This is how things currently (before your patch) work anyway. ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #11, bug #13891 (project freeciv): Just realized that rest of the message is translated at the server side. Link name also should be translated server side to make translation at least consistent, if not one translated for client's local language. This is how things currently (before your patch) work anyway. I was actually mainly thinking about chat. But you are totally right. Anyway, in the chat case, people are supposed to chat in the same language than the server, so it's not a problem if the server translate the unit links. (file #6303) ___ Additional Item Attachment: File name: featured_text5.diffSize:38 KB ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #7, bug #13891 (project freeciv): featured_text4.diff: * Fixed link id initialization. client_implementation3.diff: * Parse colors only once. * Links are clickable. The colors used are the traditionnal warclient ones. The graphical implementation is not done yet. (file #6266, file #6267) ___ Additional Item Attachment: File name: featured_text4.diffSize:38 KB File name: client_implementation3.diffSize:13 KB ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #8, bug #13891 (project freeciv): (I'm not sure about the usage client_info packet instead of server_join_req). server_join_req itself contains capability information. Capabilities cannot be checked before it is sent. I rather avoid making incompatible versions of server_join_req packet. Patches in this ticket can go in first. Sending plain text to clients without featured text capabilities should be next step (or at least before server sends any featured text) ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #9, bug #13891 (project freeciv): Patches in this ticket can go in first. Sending plain text to clients without featured text capabilities should be next step (or at least before server sends any featured text) My patch for this is nearly ready, but I have some problems to make the patch without the previous applied. ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #4, bug #13891 (project freeciv): text_tag_replace_text() actually looks for unit or city id and then determines city/unit name based on that like you said. But in the case the unit/city is not known by a client, it's replaced by the name granted with the link (ptag-link.name). About the unit name translation there is some problem. When the unit is known by the client, it replaces the text with the translation. Else, I don't think we can set the name translation set by users, because the users can have different language support. In a such case, maybe it would try to translate the link name to the local language in text_tag_replace_text() ? ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #5, bug #13891 (project freeciv): maybe it would try to translate the link name to the local language in text_tag_replace_text() Yes, that sounds like right thing to do. Will it be possible, and feasible, in future ticket, to make server send plain text only to those clients that have no support for featured text? There is client_info packet in trunk that could be used to send info to server whether client supports featured text or not. Possible protocol change (addition to client_info packet) should be done before branching S2_2. ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #6, bug #13891 (project freeciv): maybe it would try to translate the link name to the local language in text_tag_replace_text() Yes, that sounds like right thing to do. New patch attached. Will it be possible, and feasible, in future ticket, to make server send plain text only to those clients that have no support for featured text? There is client_info packet in trunk that could be used to send info to server whether client supports featured text or not. Possible protocol change (addition to client_info packet) should be done before branching S2_2. Yes, this could be a solution (I'm not sure about the usage client_info packet instead of server_join_req). For an implementation in S2_1, it would also need an extra capability. (file #6265) ___ Additional Item Attachment: File name: featured_text3.diffSize:38 KB ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #3, bug #13891 (project freeciv): text_tag_replace_text() looks for unit or city id and then determines city/unit name based on that. This means no name is shown when city/unit is not known by client. This is a problem. Server should be allowed to send messages about any city/unit without modifying message (selecting between plain text and link) based on each client's knowledge. Think about wonder started messages. city_link() and unit_link() do insert city/unit name to link tag. It's just not used. Note that unit name is not translated in current implementation as it should be if it's used in client end. ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #2, bug #13891 (project freeciv): Some fixes... featured_text2.diff: * When there are two escape sequences for foreground color without a end sequence, really change the foreground color. client_implementation2.diff: * Do not get gtk warnings when a color name is not valid. * Tags on multi-bytes characters strings are correctly displayed. (file #6165, file #6166) ___ Additional Item Attachment: File name: featured_text2.diffSize:38 KB File name: client_implementation.diff2.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
URL: http://gna.org/bugs/?13891 Summary: [Patch] Chat colors and other improvements Project: Freeciv Submitted by: pepeto Submitted on: Tuesday 07/07/2009 at 06:40 Category: general Severity: 1 - Wish Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: The attached patch grants the function needed to obtain what I begin to describe in my wikia user page (http://freeciv.wikia.com/wiki/User:Pepeto/Chat_improvements_ideas). ___ File Attachments: --- Date: Tuesday 07/07/2009 at 06:40 Name: featured_text.diff Size: 38kB By: pepeto http://gna.org/bugs/download.php?file_id=6157 ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
