[Freeciv-Dev] [bug #15024] beta civserver crashes at startup
Update of bug #15024 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15024 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15024] beta civserver crashes at startup
Follow-up Comment #4, bug #15024 (project freeciv): PowerPC likes to pass the first eight function arguments (excepting floating-point) through the general purpose registers %r3 through %r10. Two const char * arguments might look like foreground in %r7 and background in %r8. A struct counts as one argument, with a pointer to the struct in the register; a struct ft_color might look like a pointer in %r7, with foreground in 0(%r7) and background in 4(%r7). Thank you for the detailed technological analysis. I didn't know so far... Your fix also changed some comments, but forgot to fix the comment at line 370 above the text_tag_initv() function in featured_text.c. Thank you. I fixed it in the new attached patch. Now I can play and enjoy the freeciv beta, and hopefully not find any other bugs! You will probably... ;) (file #7567) ___ Additional Item Attachment: File name: trunk_S2_2_ft_color_initv2.diff Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?15024 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15024] beta civserver crashes at startup
Update of bug #15024 (project freeciv): Category:None = general Severity: 3 - Normal = 5 - Blocker Priority: 5 - Normal = 7 - High Assigned to:None = pepeto Planned Release: = 2.2.0 ___ Follow-up Comment #1: This is probably my mistake. text_tag_initv() reads two arguments of type _const char *_, but it seems some function pass a ft_color structure. It works well on my machine, but it could cause wrong memory access on other systems. ___ Reply to this item at: http://gna.org/bugs/?15024 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15024] beta civserver crashes at startup
Update of bug #15024 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #2: Quick fix attached. Unfortunately, as I never got this crash, I cannot really test. Could someone check if it really corrects the problem? (file #7562) ___ Additional Item Attachment: File name: trunk_S2_2_ft_color_initv.diff Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?15024 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15024] beta civserver crashes at startup
Follow-up Comment #3, bug #15024 (project freeciv): Yes, your fix (file #7562) works for me. I applied the patch to 2.2.0-beta1. Thank you! Now I can play local game instead of needing a public server. PowerPC likes to pass the first eight function arguments (excepting floating-point) through the general purpose registers %r3 through %r10. Two const char * arguments might look like _foreground_ in %r7 and _background_ in %r8. A struct counts as one argument, with a pointer to the struct in the register; a struct ft_color might look like a pointer in %r7, with _foreground_ in 0(%r7) and _background_ in 4(%r7). Your fix also changed some comments, but forgot to fix the comment at line 370 above the text_tag_initv() function in featured_text.c. Now I can play and enjoy the freeciv beta, and hopefully not find any other bugs! ___ Reply to this item at: http://gna.org/bugs/?15024 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
