[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting hack access
Update of bug #17354 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed Planned Release: = 2.3.5, 2.4.0, 2.5.0 ___ Reply to this item at: http://gna.org/bugs/?17354 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting hack access
Update of bug #17354 (project freeciv): Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/bugs/?17354 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting hack access
Follow-up Comment #7, bug #17354 (project freeciv): It happens when you are too fast to push the load button. I guess same thing can happen on scenario. However, the page takes longer to be displayed, I cannot reproduce with it. ___ Reply to this item at: http://gna.org/bugs/?17354 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting hack access
Update of bug #17354 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #8: The patch I attach fix the problem for me. But it also delays for a while the apparition of the load or scenario page. It actually wait for the server to process the last packet (JOIN_REQ or maybe preferred settings) before actually switching to the page. Note that the load or the scenario page doesn't appear at all if we fails to start the server. This is not the current behaviour, but I guess this is what the users expect. (file #17264) ___ Additional Item Attachment: File name: client_start_server_and_set_page.diff Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?17354 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting hack access
Follow-up Comment #6, bug #17354 (project freeciv): See also bug #17216 ___ Reply to this item at: http://gna.org/bugs/?17354 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting hack access
Follow-up Comment #5, bug #17354 (project freeciv): I'm chiming in now as i don't believe i saw it when it was new. I used to have to wait a bit between selecting the save file and clicking OK, but i no longer remember exactly what error i got if i didn't. Further, i can't currently make it go wrong; perhaps the fix was a newer/faster computer? ___ Reply to this item at: http://gna.org/bugs/?17354 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting hack access
Update of bug #17354 (project freeciv): Planned Release: 2.4.0 = Summary: error messages at game load from the client = Client tries to load game in spawned server before requesting hack access ___ Follow-up Comment #4: After some time looking, I suspect there may not be anything actually preventing the client sending a /load command if the user is incredibly quick off the mark -- clicking the Load Saved Game button on the front page causes the client to send JOIN_REQ and then switch page to PAGE_LOAD, and I suspect there's nothing interlocking the GUI callbacks that end up sending /load. The server would accept it because it would be after the JOIN_REQ. Once the client has processed JOIN_REPLY, it immediately sends SINGLE_WANT_HACK_REQ, and I see no way for the /load to jump the queue. Since this is a local server and Matthias reproduced it readily, I find the scenario above unlikely, unless there's something slowing down client/server communication such that the round trip JOIN_REQ/JOIN_REPLY takes place on human timescales. (Perhaps the server preparing all the ruleset data to send to the client -- I think it might batch it up?) For a similar report, see bug #18467 (not the original symptom of that bug, but comment 4). Anyway. Not a frequent report, so I'm unhooking it from 2.4.0. ___ Reply to this item at: http://gna.org/bugs/?17354 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
