[Freeciv-Dev] [bug #17986] allied victory may not happen

2012-04-12 Thread Marko Lindqvist
Update of bug #17986 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?17986

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17986] allied victory may not happen

2012-04-01 Thread Jacob Nevins
Update of bug #17986 (project freeciv):

 Planned Release: = 2.3.3,2.4.0,2.5.0  


___

Reply to this item at:

  http://gna.org/bugs/?17986

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17986] allied victory may not happen

2012-03-29 Thread Marko Lindqvist
Update of bug #17986 (project freeciv):

  Status:None = Ready For Test 

___

Follow-up Comment #1:

Code seems to first check that all alive players are allied. If yes, it does
*second* round of checking to find if there's non-allied players alive, and
does it so that if not (and it never can be after the first check) allied
victory is cancelled. Sigh.

Attached untested patch just removes the broken and unneeded second checking
round.

(file #15459)
___

Additional Item Attachment:

File name: AlliedVictory.diff Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?17986

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17986] allied victory may not happen

2011-04-02 Thread Brandon J. Van Every

URL:
  http://gna.org/bugs/?17986

 Summary: allied victory may not happen
 Project: Freeciv
Submitted by: bvanevery
Submitted on: Sun 03 Apr 2011 03:21:20 AM GMT
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.0-beta3
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

I played a 5 player game with default settings.  alliedvictory is enabled
by default, and I verified that it was set by typing /help alliedvictory. 
Let's say I'm the 1st civilization.  I destroyed a 2nd civ using legions from
hut popping.  I nearly destroyed a 3rd civ in the same way, but the 4th civ
destroyed the last unit of the 3rd civ.  I made peace with the 4th civ and
later allied with it.  Upon contacting the 5th civ, I had a couple of cease
fires eventually leading to peace.  Eventually I made an alliance with the 5th
civ as well.  At this point, 2 civs are dead, and I've allied with the 2 civs
that remain.  It should be a victory; however, the game continues
indefinitely.

I bet it has something to do with the remaining civs having Never Met the
dead civs.  Alternately, it could be because I didn't personally kill the 2nd
civ.  I notice from reading the bug tracker that check_for_game_over() was
modified as recently as November 2010.





___

File Attachments:


---
Date: Sun 03 Apr 2011 03:21:20 AM GMT  Name: noalliedvictory.sav.gz  Size:
53kB   By: bvanevery

http://gna.org/bugs/download.php?file_id=12774

___

Reply to this item at:

  http://gna.org/bugs/?17986

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev