[Freeciv-Dev] [bug #19852] Multiplayer ruleset: can get free techs from Darwin's Voyage multiple times
Update of bug #19852 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19852 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19852] Multiplayer ruleset: can get free techs from Darwin's Voyage multiple times
Update of bug #19852 (project freeciv): Category:None = general Status:None = Ready For Test Planned Release: = 2.3.3, 2.4.0, 2.5.0 ___ Follow-up Comment #2: That scripting expects nil return value from give_technology() if player already has it. That's what our external documentation say. However function header says that it returns pointer to A_NONE. That's beginning of the techs array, not NULL. Implementation is according to that function header. I just decided that from the conflicting documentation the interpretation that it should return NULL is correct, and current implementation is a bug. Attached patch changes it to return NULL. It's rather unlikely that any script out there could depend on old behavior. (file #16655, file #16656) ___ Additional Item Attachment: File name: DarwinFix.patchSize:0 KB File name: DarwinFix-S2_3.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19852 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19852] Multiplayer ruleset: can get free techs from Darwin's Voyage multiple times
Follow-up Comment #1, bug #19852 (project freeciv): Otherwise, could we keep the state that the Lua script uses as a simple script variable, rather than a tech? Script variables are saved with the game. Shouldn't we do that in any case? Using tech for that was just a hack mbook had to use back when script variable saving was not yet working. ___ Reply to this item at: http://gna.org/bugs/?19852 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19852] Multiplayer ruleset: can get free techs from Darwin's Voyage multiple times
URL: http://gna.org/bugs/?19852 Summary: Multiplayer ruleset: can get free techs from Darwin's Voyage multiple times Project: Freeciv Submitted by: jtn Submitted on: Sun Jun 24 21:41:17 2012 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: In the multiplayer ruleset, Darwin's Voyage is implemented as a small wonder. There's some Lua scripting involving an otherwise-unreachable tech called Theory of Evolution that's supposed to stop you getting techs from it more than once by rebuilding it (which would otherwise be possible, unlike great wonders). In bug #18394 (comment 8), I observed that this didn't seem to be working, but I don't seem to have raised a ticket, so here it is. I haven't re-tested this or gone into the details again. Random thoughts that might not be relevant: * Perhaps the small wonders surviving requirements on S2_4 (bug #17463) can help? (might require code change) * Otherwise, could we keep the state that the Lua script uses as a simple script variable, rather than a tech? Script variables are saved with the game. ___ Reply to this item at: http://gna.org/bugs/?19852 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
