[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Jacob Nevins]

Update of patch #7243 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Jacob Nevins]

Update of patch #7243 (project freeciv):

  Status:Done => Ready For Test 
  Depends on: => patch #7431

___

Follow-up Comment #7:

Attached patch modifies behaviour around unit_default_orientation:
* Random unit orientation is removed completely. Tileset must either set
unit_default_orientation, or provide unoriented 'icon' sprites for all unit
types.
* Restriction that unit_default_orientation must be valid for the tileset is
lifted.
* README.graphics updated with a summary of how oriented units work. (Although
it's still hideously out of date in many other regards)

(file #27873)
___

Additional Item Attachment:

File name: trunk-tileset-unit-default-orientation-pt2.patch Size:14 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Marko Lindqvist]

Follow-up Comment #6, patch #7243 (project freeciv):

> I guess the most natural way to do that would be to add a "u.settlers_type"
alongside "u.settlers_nw" etc.

Hmm... so they already have it. By defining unit "icon" sprite that's to be
used in those places.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Jacob Nevins]

Follow-up Comment #5, patch #7243 (project freeciv):

> At some point I'd like to give tileset author per-unit-type control.
I guess the most natural way to do that would be to add a "u.settlers_type"
alongside "u.settlers_nw" etc. Assuming our sprite storage in memory is
sensible, this lets tileset authors express this in the same place as the
sprites, and also lets them give worklists etc a distinct sprite if they
really want to (...that could even be useful with non-oriented tilesets).

Probably we'd want to keep unit_default_orientation too, as a backstop or for
unfussy tilesets.

For now I'm inclined to make unit_default_orientation mandatory here, so I can
avoid porting bug #24771 to trunk without causing a regression.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Marko Lindqvist]

Follow-up Comment #4, patch #7243 (project freeciv):

> the need to remember a per-unit-type orientation.

At some point I'd like to give tileset author per-unit-type control. Infantry
may look better when facing toward user, naval units may look better from the
side.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Jacob Nevins]

Update of patch #7243 (project freeciv):

 Open/Closed:  Closed => Open   

___

Follow-up Comment #3:

> I think you would need to touch also some callers of the 
> get_unittype_sprite() to not use hardcoded direction (South)
Oops, missed that.

> You would also need to make the randomization case tileset 
> loading time and not within get_unittype_sprite() for keeping 
> direction consistent on those cases where it's currently 
> hardcoded for the very reason of needed consistency.
I think stable branches would benefit from that too, so I've split it to a
separate ticket: bug #24771.

(I've just noticed an outstanding problem of this kind on stable branches, but
the root cause is separate: bug #24772)

Back to this ticket, it's tempting to remove the random orientation feature
entirely, and make unit_default_orientation mandatory in tilesets with any
oriented units, and thus save the need to remember a per-unit-type
orientation. What do you think? Would any tileset actually want the random
orientation?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Marko Lindqvist]

Follow-up Comment #2, patch #7243 (project freeciv):

As we have already needed facing to be consistent in some dialogs (so that
refresh of the dialog does not randomly rotate units shown there), I think you
would need to touch also some callers of the get_unittype_sprite() to not use
hardcoded direction (South) but one from the ruleset. You would also need to
make the randomization case tileset loading time and not within
get_unittype_sprite() for keeping direction consistent on those cases where
it's currently hardcoded for the very reason of needed consistency.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Jacob Nevins]

Update of patch #7243 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7243] Add default orientation to tilesets for unit orientation in help, etc

[Jacob Nevins]

Update of patch #7243 (project freeciv):

 Summary: Add default_orientation to tilesets for unit
orientation in help, etc => Add default orientation to tilesets for unit
orientation in help, etc


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev