Re: [Freedreno] [pull] drm/msm: msm-next for 4.9

2016-09-20 Thread Rob Clark 
On Tue, Sep 20, 2016 at 10:39 AM, Jordan Crouse  wrote:
> So this isn't how I planned on announcing it, but hey, I'm back.
>
>> Rob Clark (5):
>>   drm/msm: extend the submit ioctl to pass in flags
>
> Renaming 'pipe' to 'flags' would break backwards compatibility - I'm not big
> fan of 'pipe' either but I would strongly recommend keeping it just to keep
> everybody happy. I know that you bump the API version a couple of changes
> later and we could use that as a stop gap but workarounds suck.

well.. it doesn't break *ABI* compat, and the upstream user (libdrm)
carries it's own copy of the header in sync with the name change.  As
far as I know this is all we care about.  Any other "hypothetical"
userspace should just carry it's own copy of the kernel header, IMHO.

>>   drm/msm: submit support for in-fences
>>   drm/msm: move fence allocation out of msm_gpu_submit()
>>   drm/msm: submit support for out-fences
>>   drm/msm: bump kernel api version for explicit fencing
>
> You misspelled ioctl in the comment. :)

oh, whoops.. well if dave hasn't merged my pull req yet I can fixup
the typo and resend the pr.  Unfortunately kbuild robot doesn't
include spellcheck ;-)

BR,
-R

> Regards,
> Jordan
>
> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [pull] drm/msm: msm-next for 4.9

2016-09-20 Thread Jordan Crouse 
So this isn't how I planned on announcing it, but hey, I'm back.

> Rob Clark (5):
>   drm/msm: extend the submit ioctl to pass in flags

Renaming 'pipe' to 'flags' would break backwards compatibility - I'm not big
fan of 'pipe' either but I would strongly recommend keeping it just to keep
everybody happy. I know that you bump the API version a couple of changes
later and we could use that as a stop gap but workarounds suck.

>   drm/msm: submit support for in-fences
>   drm/msm: move fence allocation out of msm_gpu_submit()
>   drm/msm: submit support for out-fences
>   drm/msm: bump kernel api version for explicit fencing

You misspelled ioctl in the comment. :)

Regards,
Jordan

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno