Re: [Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC
On 18/11/2022 15:29, Bryan O'Donoghue wrote: On 08/11/2022 12:46, Dmitry Baryshkov wrote: On 08/11/2022 02:56, Bryan O'Donoghue wrote: Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate documenting the clocks add the following compatible strings - qcom,mdss-dsi-ctrl-apq8064 Generic comment: I think we'd better follow the arm/qcom-soc.yaml and use qcom,soc-something as compat string. This would leave us with qcom,apq8064-dsi-ctrl I'm not sure if we want to follow the qcm2290 approach and encode the DSI ctrl revision here (6g vs v2). For qcm2290 I'm thinking qcm2290-dsi-ctrl - without the 6g piece. This sounds good too. a) Nobody is using the compat at the moment b) I'm not sure what - if any real information the silicon version number conveys here. + Loic, Shawn --- bod -- With best wishes Dmitry
Re: [Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC
On 08/11/2022 12:46, Dmitry Baryshkov wrote: On 08/11/2022 02:56, Bryan O'Donoghue wrote: Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate documenting the clocks add the following compatible strings - qcom,mdss-dsi-ctrl-apq8064 Generic comment: I think we'd better follow the arm/qcom-soc.yaml and use qcom,soc-something as compat string. This would leave us with qcom,apq8064-dsi-ctrl I'm not sure if we want to follow the qcm2290 approach and encode the DSI ctrl revision here (6g vs v2). For qcm2290 I'm thinking qcm2290-dsi-ctrl - without the 6g piece. a) Nobody is using the compat at the moment b) I'm not sure what - if any real information the silicon version number conveys here. + Loic, Shawn --- bod
Re: [Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC
On 08/11/2022 13:46, Dmitry Baryshkov wrote: > On 08/11/2022 02:56, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, the hardware does have some significant differences >> in the number of clocks. >> >> To facilitate documenting the clocks add the following compatible strings >> >> - qcom,mdss-dsi-ctrl-apq8064 > > Generic comment: I think we'd better follow the arm/qcom-soc.yaml and > use qcom,soc-something as compat string. This would leave us with > qcom,apq8064-dsi-ctrl That's a requirement. Only existing patterns are allowed to continue, but here all there is no such pattern. Best regards, Krzysztof
Re: [Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC
On 08/11/2022 02:56, Bryan O'Donoghue wrote: Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate documenting the clocks add the following compatible strings - qcom,mdss-dsi-ctrl-apq8064 Generic comment: I think we'd better follow the arm/qcom-soc.yaml and use qcom,soc-something as compat string. This would leave us with qcom,apq8064-dsi-ctrl I'm not sure if we want to follow the qcm2290 approach and encode the DSI ctrl revision here (6g vs v2). - qcom,mdss-dsi-ctrl-msm8916 - qcom,mdss-dsi-ctrl-msm8974 - qcom,mdss-dsi-ctrl-msm8996 - qcom,mdss-dsi-ctrl-sc7180 - qcom,mdss-dsi-ctrl-sc7280 - qcom,mdss-dsi-ctrl-sdm630 - qcom,mdss-dsi-ctrl-sdm660 - qcom,mdss-dsi-ctrl-sdm845 - qcom,mdss-dsi-ctrl-sm8250 Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: linux-arm-...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Bryan O'Donoghue --- .../bindings/display/msm/dsi-controller-main.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index b35130a77b43e..9db3e63acda3d 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -17,6 +17,16 @@ properties: enum: - qcom,dsi-ctrl-6g-qcm2290 - qcom,mdss-dsi-ctrl + - qcom,mdss-dsi-ctrl-apq8064 + - qcom,mdss-dsi-ctrl-msm8916 + - qcom,mdss-dsi-ctrl-msm8974 + - qcom,mdss-dsi-ctrl-msm8996 + - qcom,mdss-dsi-ctrl-sc7180 + - qcom,mdss-dsi-ctrl-sc7280 + - qcom,mdss-dsi-ctrl-sdm630 + - qcom,mdss-dsi-ctrl-sdm660 + - qcom,mdss-dsi-ctrl-sdm845 + - qcom,mdss-dsi-ctrl-sm8250 reg: maxItems: 1 -- With best wishes Dmitry
[Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC
Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate documenting the clocks add the following compatible strings - qcom,mdss-dsi-ctrl-apq8064 - qcom,mdss-dsi-ctrl-msm8916 - qcom,mdss-dsi-ctrl-msm8974 - qcom,mdss-dsi-ctrl-msm8996 - qcom,mdss-dsi-ctrl-sc7180 - qcom,mdss-dsi-ctrl-sc7280 - qcom,mdss-dsi-ctrl-sdm630 - qcom,mdss-dsi-ctrl-sdm660 - qcom,mdss-dsi-ctrl-sdm845 - qcom,mdss-dsi-ctrl-sm8250 Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: linux-arm-...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Bryan O'Donoghue --- .../bindings/display/msm/dsi-controller-main.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index b35130a77b43e..9db3e63acda3d 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -17,6 +17,16 @@ properties: enum: - qcom,dsi-ctrl-6g-qcm2290 - qcom,mdss-dsi-ctrl + - qcom,mdss-dsi-ctrl-apq8064 + - qcom,mdss-dsi-ctrl-msm8916 + - qcom,mdss-dsi-ctrl-msm8974 + - qcom,mdss-dsi-ctrl-msm8996 + - qcom,mdss-dsi-ctrl-sc7180 + - qcom,mdss-dsi-ctrl-sc7280 + - qcom,mdss-dsi-ctrl-sdm630 + - qcom,mdss-dsi-ctrl-sdm660 + - qcom,mdss-dsi-ctrl-sdm845 + - qcom,mdss-dsi-ctrl-sm8250 reg: maxItems: 1 -- 2.38.1
