Re: [Freedreno] [PATCH v3 05/12] dt-bindings: display/msm: Add SM6375 MDSS
On 7.05.2023 10:20, Krzysztof Kozlowski wrote:
> On 05/05/2023 23:40, Konrad Dybcio wrote:
>> Document the SM6375 MDSS.
>>
>> Signed-off-by: Konrad Dybcio
>> ---
>> .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216
>> +
>> 1 file changed, 216 insertions(+)
>>
>
> Thank you for your patch. There is something to discuss/improve.
>
>> +
>> +examples:
>> + - |
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +display-subsystem@5e0 {
>> +compatible = "qcom,sm6375-mdss";
>> +reg = <0x05e0 0x1000>;
>> +reg-names = "mdss";
>> +
>> +power-domains = < MDSS_GDSC>;
>> +
>> +clocks = < GCC_DISP_AHB_CLK>,
>> + < DISP_CC_MDSS_AHB_CLK>,
>> + < DISP_CC_MDSS_MDP_CLK>;
>> +clock-names = "iface", "ahb", "core";
>> +
>> +interrupts = ;
>> +interrupt-controller;
>> +#interrupt-cells = <1>;
>> +
>> +iommus = <_smmu 0x820 0x2>;
>> +#address-cells = <1>;
>> +#size-cells = <1>;
>> +ranges;
>> +
>> +display-controller@5e01000 {
>> +compatible = "qcom,sm6375-dpu";
>> +reg = <0x05e01000 0x8e030>,
>> + <0x05eb 0x2008>;
>> +reg-names = "mdp", "vbif";
>> +
>> +clocks = < DISP_CC_MDSS_AHB_CLK>,
>> + < GCC_DISP_HF_AXI_CLK>,
>> + < DISP_CC_MDSS_MDP_CLK>,
>> + < DISP_CC_MDSS_MDP_LUT_CLK>,
>> + < DISP_CC_MDSS_ROT_CLK>,
>> + < DISP_CC_MDSS_VSYNC_CLK>,
>> + < GCC_DISP_THROTTLE_CORE_CLK>;
>> +clock-names = "iface",
>> + "bus",
>> + "core",
>> + "lut",
>> + "rot",
>> + "vsync",
>> + "throttle";
>
> Are you sure you have clocks in correct order? I see warnings...
Right, testing *both* the DTs and bindings after making changes sounds
like a good thing to stop forgetting..
Konrad
>
> Best regards,
> Krzysztof
>
Re: [Freedreno] [PATCH v3 05/12] dt-bindings: display/msm: Add SM6375 MDSS
On 05/05/2023 23:40, Konrad Dybcio wrote:
> Document the SM6375 MDSS.
>
> Signed-off-by: Konrad Dybcio
> ---
> .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216
> +
> 1 file changed, 216 insertions(+)
>
Thank you for your patch. There is something to discuss/improve.
> +
> +examples:
> + - |
> +#include
> +#include
> +#include
> +#include
> +#include
> +
> +display-subsystem@5e0 {
> +compatible = "qcom,sm6375-mdss";
> +reg = <0x05e0 0x1000>;
> +reg-names = "mdss";
> +
> +power-domains = < MDSS_GDSC>;
> +
> +clocks = < GCC_DISP_AHB_CLK>,
> + < DISP_CC_MDSS_AHB_CLK>,
> + < DISP_CC_MDSS_MDP_CLK>;
> +clock-names = "iface", "ahb", "core";
> +
> +interrupts = ;
> +interrupt-controller;
> +#interrupt-cells = <1>;
> +
> +iommus = <_smmu 0x820 0x2>;
> +#address-cells = <1>;
> +#size-cells = <1>;
> +ranges;
> +
> +display-controller@5e01000 {
> +compatible = "qcom,sm6375-dpu";
> +reg = <0x05e01000 0x8e030>,
> + <0x05eb 0x2008>;
> +reg-names = "mdp", "vbif";
> +
> +clocks = < DISP_CC_MDSS_AHB_CLK>,
> + < GCC_DISP_HF_AXI_CLK>,
> + < DISP_CC_MDSS_MDP_CLK>,
> + < DISP_CC_MDSS_MDP_LUT_CLK>,
> + < DISP_CC_MDSS_ROT_CLK>,
> + < DISP_CC_MDSS_VSYNC_CLK>,
> + < GCC_DISP_THROTTLE_CORE_CLK>;
> +clock-names = "iface",
> + "bus",
> + "core",
> + "lut",
> + "rot",
> + "vsync",
> + "throttle";
Are you sure you have clocks in correct order? I see warnings...
Best regards,
Krzysztof
Re: [Freedreno] [PATCH v3 05/12] dt-bindings: display/msm: Add SM6375 MDSS
On Fri, 05 May 2023 23:40:31 +0200, Konrad Dybcio wrote:
> Document the SM6375 MDSS.
>
> Signed-off-by: Konrad Dybcio
> ---
> .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216
> +
> 1 file changed, 216 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.example.dtb:
dsi@5e94000: compatible: 'oneOf' conditional failed, one must be fixed:
'qcom,sm6375-dsi-ctrl' is not one of ['qcom,apq8064-dsi-ctrl',
'qcom,msm8916-dsi-ctrl', 'qcom,msm8953-dsi-ctrl', 'qcom,msm8974-dsi-ctrl',
'qcom,msm8996-dsi-ctrl', 'qcom,msm8998-dsi-ctrl', 'qcom,qcm2290-dsi-ctrl',
'qcom,sc7180-dsi-ctrl', 'qcom,sc7280-dsi-ctrl', 'qcom,sdm660-dsi-ctrl',
'qcom,sdm845-dsi-ctrl', 'qcom,sm8150-dsi-ctrl', 'qcom,sm8250-dsi-ctrl',
'qcom,sm8350-dsi-ctrl', 'qcom,sm8450-dsi-ctrl', 'qcom,sm8550-dsi-ctrl']
'qcom,sm6375-dsi-ctrl' is not one of ['dsi-ctrl-6g-qcm2290']
From schema:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.example.dtb:
dsi@5e94000: Unevaluated properties are not allowed ('compatible' was
unexpected)
From schema:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230411-topic-straitlagoon_mdss-v3-5-9837d6b35...@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
