Re: [Freeipa-devel] [PATCH] Test suite for ipa.js and entity.js.
Adam Young wrote: On 09/24/2010 07:49 PM, Adam Young wrote: On 09/24/2010 06:34 PM, Endi Sukma Dewata wrote: Hi, The patch has been modified based on Adam's feedback. Thanks! Test framework for Web UI has been created using qUnit. The test files are located in install/static/test. The main page is index.html which contains links to all test suites (xxx_tests.html). The test cases are stored in xxx_tests.js. All test suites can be executed at once using all_tests.html. The test data is stored in data folder. This patch includes test suites for ipa.js and entity.js. Some variables and functions in ipa.js have been modified to accomodate testing (e.g. JSON URL, error handler, synchronous operation). The sampledata has been moved to test/data. The develop.js and webui.js also have been modified accordingly. -- Endi S. Dewata - Endi Sukma Dewataedew...@redhat.com wrote: Hi, Please review the attached patch. It was created based on Adam's sample test files. More test cases will be added later. Thanks! Test suite for Web UI has been created in install/static/test using qUnit. The main page is index.html which contains links to the test pages (xxx_test.html). The test cases are stored in xxx_test.js. The test data is stored in data folder. Some variables and functions in ipa.js have been modified to accomodate unit testing. The develop.js and webui.js also have been modified accordingly. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Pushed to master Is there any documentation on how to run the tests? rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Test suite for ipa.js and entity.js.
On 09/27/2010 11:04 AM, Rob Crittenden wrote: Adam Young wrote: On 09/24/2010 07:49 PM, Adam Young wrote: On 09/24/2010 06:34 PM, Endi Sukma Dewata wrote: Hi, The patch has been modified based on Adam's feedback. Thanks! Test framework for Web UI has been created using qUnit. The test files are located in install/static/test. The main page is index.html which contains links to all test suites (xxx_tests.html). The test cases are stored in xxx_tests.js. All test suites can be executed at once using all_tests.html. The test data is stored in data folder. This patch includes test suites for ipa.js and entity.js. Some variables and functions in ipa.js have been modified to accomodate testing (e.g. JSON URL, error handler, synchronous operation). The sampledata has been moved to test/data. The develop.js and webui.js also have been modified accordingly. -- Endi S. Dewata - Endi Sukma Dewataedew...@redhat.com wrote: Hi, Please review the attached patch. It was created based on Adam's sample test files. More test cases will be added later. Thanks! Test suite for Web UI has been created in install/static/test using qUnit. The main page is index.html which contains links to the test pages (xxx_test.html). The test cases are stored in xxx_test.js. The test data is stored in data folder. Some variables and functions in ipa.js have been modified to accomodate unit testing. The develop.js and webui.js also have been modified accordingly. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Pushed to master Is there any documentation on how to run the tests? rob Not yet, but for now, just view the html pages in the browser, and you will se the test results as they are run. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Test suite for ipa.js and entity.js.
- Rob Crittenden rcrit...@redhat.com wrote: Is there any documentation on how to run the tests? You just need to open install/static/test/index.html in the browser and click the test you want to run. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Test suite for ipa.js and entity.js.
On 09/27/2010 11:33 AM, Rob Crittenden wrote: Adam Young wrote: On 09/27/2010 11:04 AM, Rob Crittenden wrote: Adam Young wrote: On 09/24/2010 07:49 PM, Adam Young wrote: On 09/24/2010 06:34 PM, Endi Sukma Dewata wrote: Hi, The patch has been modified based on Adam's feedback. Thanks! Test framework for Web UI has been created using qUnit. The test files are located in install/static/test. The main page is index.html which contains links to all test suites (xxx_tests.html). The test cases are stored in xxx_tests.js. All test suites can be executed at once using all_tests.html. The test data is stored in data folder. This patch includes test suites for ipa.js and entity.js. Some variables and functions in ipa.js have been modified to accomodate testing (e.g. JSON URL, error handler, synchronous operation). The sampledata has been moved to test/data. The develop.js and webui.js also have been modified accordingly. -- Endi S. Dewata - Endi Sukma Dewataedew...@redhat.com wrote: Hi, Please review the attached patch. It was created based on Adam's sample test files. More test cases will be added later. Thanks! Test suite for Web UI has been created in install/static/test using qUnit. The main page is index.html which contains links to the test pages (xxx_test.html). The test cases are stored in xxx_test.js. The test data is stored in data folder. Some variables and functions in ipa.js have been modified to accomodate unit testing. The develop.js and webui.js also have been modified accordingly. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Pushed to master Is there any documentation on how to run the tests? rob Not yet, but for now, just view the html pages in the browser, and you will se the test results as they are run. Ok, how will someone know what pages to visit, etc? There is a Testing page on the wiki now, it would be helpful to include a reference to this there. rob I figure we need to get a little bit of momentum with the tests themselves first. The framework is in place, but I'm not sure we want to advertise the few tests we have yet as being that significant. More valuable is to identify what aspects of the JS codebase are in most need of unit test coverage, and getting bugs in for those. That being said, I think that we want Qunit to be a significatn part of our extension strategy, and as such, we should have more than just a doc page, but guidelines for writing tests downstream . I'll post a ticket for the Test page update. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Adding SUDO Plugins and Test Suites
JR Aquino wrote: Attached are the plugins for creating: * IPA Sudo Commands * IPA Sudo Command Groups * IPA Sudo Rules Also included are the accompanying test suites, container pointers, and tests/test_xmlrpc/objectclasses.py definitions. A very good first try, just needs a little more work. You need to create the 3 containers in install/share/bootstrap-template.ldif so they get created when a server is installed. In sudocmd.py you need to: - remove imports for Flag, Bytes and base64 - Don't define a pre_callback if it isn't doing any work In sudocmdgroup.py you need to: - Fix the doc example at the top. It starts with sudocmdgroup examples then switches to group examples. - Drop the Int import In sudorule.py you need to: - Drop AccessTime and Password from imports - Should membercmd_sudocmd use the label Sudo Commands to be consistent with Sudo Group Commands? - I'm not entirely sure what you are doing with cn in the dn, can you add some documentation explaining what is going on? I haven't run the tests yet because I didn't create the container entries but a brief look-see and they look fine. I noted on the imports just because you'll already be in the files, they alone wouldn't be a reason to nack the patch. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0044-I18N-for-web.patch
Adam Young wrote: On 09/27/2010 12:45 PM, Adam Young wrote: On 09/27/2010 10:35 AM, Adam Young wrote: On 09/24/2010 09:43 PM, Adam Young wrote: I18N for web Performing I18N completely on the server, to leverage the existing gettext architecture. Also, the browser does not have access to the Language header. Added the additional po files for a set of required languages conflict with install/static/ipa.js was resolved. Note that the addition of the .po files in this patch is necessary. In order to get Transifex support, we need to update the LINGUAS file with the languages for which we want support. If we don't add the .po files in, they get automatically generated by the rpmbuild process. Our implementation of gettext has a bug in it (It might be F13 thing) where the the Plurals line is not getting correctly transformed, which causes a build failure. However, since the RPM would have the .po files anyway, we should revision control the ones we have, even if they are empty. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Returned the Bug reporting URL to its origianl value. Looks like another bug in the gettext mechanims. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Corrected 'Plurals' lines in regenerated PO files. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed in IRC by edewata and pushed to master This patch includes install/po/Makefile which is supposed to be an auto-generated file. Can you remove it? rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Adding SUDO Plugins and Test Suites
JR Aquino wrote: Let me know how it looks now. Ack, pushed to master. I made one minor change. You had duplicated adding the container for sudocmds to bootstrap-template.ldif but that was trivial enough to fix myself. Thanks for the huge contribution. I also added you to the Contributors file and pushed that under the 1-liner rule. rob On Sep 27, 2010, at 1:17 PM, Rob Crittenden wrote: A very good first try, just needs a little more work. You need to create the 3 containers in install/share/bootstrap-template.ldif so they get created when a server is installed. Done In sudocmd.py you need to: - remove imports for Flag, Bytes and base64 - Don't define a pre_callback if it isn't doing any work Done In sudocmdgroup.py you need to: - Fix the doc example at the top. It starts with sudocmdgroup examples then switches to group examples. - Drop the Int import Done In sudorule.py you need to: - Drop AccessTime and Password from imports Done - Should membercmd_sudocmd use the label Sudo Commands to be consistent with Sudo Group Commands? Done (yes, you are right) - I'm not entirely sure what you are doing with cn in the dn, can you add some documentation explaining what is going on? It was cruft and has been removed. Was originally there due to confusion about how the compat piece was going to work and wasn't sure if the dn would be defined by the cn or a different identifier. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
