[Freeipa-devel] [PATCH 0004] [Test] Test for caacl-add-service: incorrect error message when service does not exists
Hello!
Test for caacl-add-service: incorrect error message when service does not exists
https://fedorahosted.org/freeipa/ticket/6171
Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer
:From 837d85f0b3e8544a983e1ceeb770712807c0f0cf Mon Sep 17 00:00:00 2001
From: Ganna Kaihorodova <gkaih...@redhat.com>
Date: Thu, 18 Aug 2016 11:16:49 +0200
Subject: [PATCH] Test for caacl-add-service
Test for caacl-add-service: incorrect error message when service does not exists
https://fedorahosted.org/freeipa/ticket/6171
---
ipatests/test_integration/test_caal_message.py | 20
1 file changed, 20 insertions(+)
create mode 100644 ipatests/test_integration/test_caal_message.py
diff --git a/ipatests/test_integration/test_caal_message.py b/ipatests/test_integration/test_caal_message.py
new file mode 100644
index ..d9c5d4e5b74aeec87b6985ed94a69bcc9d9435ff
--- /dev/null
+++ b/ipatests/test_integration/test_caal_message.py
@@ -0,0 +1,20 @@
+from ipatests.test_integration.base import IntegrationTest
+
+
+class TestIncorrectErrorMessage(IntegrationTest):
+
+"https://fedorahosted.org/freeipa/ticket/6171;
+
+topology = 'star'
+num_replicas = 0
+caacl = 'test_caacl'
+
+def test_errormsg(self):
+master = self.master
+master.run_command("ipa caacl-add %s --desc \"test\"" % self.caacl)
+result = master.run_command(
+"ipa caacl-add-service %s --services"
+"svc/`hostname`" % self.caacl, raiseonerr=False
+)
+assert("no such entry" not in result.stderr_text), (
+"Wrong error message")
--
2.7.4
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts
Hello! I fixed typo in commit message. Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Ganna Kaihorodova" <gkaih...@redhat.com> To: "Petr Spacek" <pspa...@redhat.com> Cc: freeipa-devel@redhat.com Sent: Monday, August 15, 2016 10:55:08 AM Subject: Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts Hello, Petr! Yes, this is exactly what I meant. Martin Basti educated me with that. Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Petr Spacek" <pspa...@redhat.com> To: freeipa-devel@redhat.com Sent: Friday, August 12, 2016 6:58:54 PM Subject: Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts On 9.8.2016 16:55, Ganna Kaihorodova wrote: > Hello! > > Domain level 0 doesn't allow to create replica file on CA master, testcase > was skipped with Domain level 0 You mean on CA-less master, right? Petr^2 Spacek > https://fedorahosted.org/freeipa/ticket/6134 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code From 852040e1cfbdc7636f92ac509c08782d6c83347c Mon Sep 17 00:00:00 2001 From: Ganna Kaihorodova <gkaih...@redhat.com> Date: Fri, 12 Aug 2016 13:14:10 +0200 Subject: [PATCH] Fix for integration tests replication layouts Domain level 0 doesn't allow to create replica file on CA-less master, testcases were skipped with Domain level 0 [https://fedorahosted.org/freeipa/ticket/6134] --- ipatests/test_integration/test_replication_layouts.py | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ipatests/test_integration/test_replication_layouts.py b/ipatests/test_integration/test_replication_layouts.py index 9fd4ddca299ca99053aae17ae1d43d3c64650f40..c1788153032ffb9125bd9139e70adad78c78607e 100644 --- a/ipatests/test_integration/test_replication_layouts.py +++ b/ipatests/test_integration/test_replication_layouts.py @@ -3,10 +3,13 @@ # import time - +import pytest +from ipalib.constants import DOMAIN_LEVEL_0 +from ipatests.test_integration.env_config import get_global_config from ipatests.test_integration.base import IntegrationTest from ipatests.test_integration import tasks +config = get_global_config() class LayoutsBaseTest(IntegrationTest): @@ -27,6 +30,8 @@ class LayoutsBaseTest(IntegrationTest): r.run_command(['ipa', 'user-show', test_user]) +@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, +reason='does not work on DOMAIN_LEVEL_0 by design') class TestLineTopologyWithoutCA(LayoutsBaseTest): num_replicas = 3 @@ -87,6 +92,8 @@ class TestCompleteTopologyWithCA(LayoutsBaseTest): self.replication_is_working() +@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, +reason='does not work on DOMAIN_LEVEL_0 by design') class Test2ConnectedTopologyWithoutCA(LayoutsBaseTest): num_replicas = 33 @@ -105,6 +112,8 @@ class Test2ConnectedTopologyWithCA(LayoutsBaseTest): self.replication_is_working() +@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, +reason='does not work on DOMAIN_LEVEL_0 by design') class TestDoubleCircleTopologyWithoutCA(LayoutsBaseTest): num_replicas = 29 -- 2.7.4 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts
Hello, Petr! Yes, this is exactly what I meant. Martin Basti educated me with that. Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Petr Spacek" <pspa...@redhat.com> To: freeipa-devel@redhat.com Sent: Friday, August 12, 2016 6:58:54 PM Subject: Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts On 9.8.2016 16:55, Ganna Kaihorodova wrote: > Hello! > > Domain level 0 doesn't allow to create replica file on CA master, testcase > was skipped with Domain level 0 You mean on CA-less master, right? Petr^2 Spacek > https://fedorahosted.org/freeipa/ticket/6134 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts
Hello! Thank you for review Attached fixed patch Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Martin Basti" <mba...@redhat.com> To: "Ganna Kaihorodova" <gkaih...@redhat.com>, "freeipa-devel" <freeipa-devel@redhat.com> Sent: Thursday, August 11, 2016 11:00:21 AM Subject: Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts On 09.08.2016 16:55, Ganna Kaihorodova wrote: > Hello! > > Domain level 0 doesn't allow to create replica file on CA master, testcase > was skipped with Domain level 0 > > https://fedorahosted.org/freeipa/ticket/6134 > > Best regards, > Ganna Kaihorodova > Associate Software Quality Engineer > > > > Hello, Please fix PEP8 error you introduced. ./ipatests/test_integration/test_replication_layouts.py:32:1: E302 expected 2 blank lines, found 1 IMO this need skip on domain level 0 too * Test2ConnectedTopologyWithoutCA * TestDoubleCircleTopologyWithoutCA Martin^2 From 9548a1974c3f872d808ebe521359dca2ee40ce97 Mon Sep 17 00:00:00 2001 From: Ganna Kaihorodova <gkaih...@redhat.com> Date: Fri, 12 Aug 2016 13:14:10 +0200 Subject: [PATCH] Fix for integration tests replication layouts Domain level 0 doesn't allow to create replica file on CA master, testcases were skipped with Domain level 0 [https://fedorahosted.org/freeipa/ticket/6134] --- ipatests/test_integration/test_replication_layouts.py | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ipatests/test_integration/test_replication_layouts.py b/ipatests/test_integration/test_replication_layouts.py index 9fd4ddca299ca99053aae17ae1d43d3c64650f40..c1788153032ffb9125bd9139e70adad78c78607e 100644 --- a/ipatests/test_integration/test_replication_layouts.py +++ b/ipatests/test_integration/test_replication_layouts.py @@ -3,10 +3,13 @@ # import time - +import pytest +from ipalib.constants import DOMAIN_LEVEL_0 +from ipatests.test_integration.env_config import get_global_config from ipatests.test_integration.base import IntegrationTest from ipatests.test_integration import tasks +config = get_global_config() class LayoutsBaseTest(IntegrationTest): @@ -27,6 +30,8 @@ class LayoutsBaseTest(IntegrationTest): r.run_command(['ipa', 'user-show', test_user]) +@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, +reason='does not work on DOMAIN_LEVEL_0 by design') class TestLineTopologyWithoutCA(LayoutsBaseTest): num_replicas = 3 @@ -87,6 +92,8 @@ class TestCompleteTopologyWithCA(LayoutsBaseTest): self.replication_is_working() +@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, +reason='does not work on DOMAIN_LEVEL_0 by design') class Test2ConnectedTopologyWithoutCA(LayoutsBaseTest): num_replicas = 33 @@ -105,6 +112,8 @@ class Test2ConnectedTopologyWithCA(LayoutsBaseTest): self.replication_is_working() +@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, +reason='does not work on DOMAIN_LEVEL_0 by design') class TestDoubleCircleTopologyWithoutCA(LayoutsBaseTest): num_replicas = 29 -- 2.7.4 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts
Hello! Domain level 0 doesn't allow to create replica file on CA master, testcase was skipped with Domain level 0 https://fedorahosted.org/freeipa/ticket/6134 Best regards, Ganna Kaihorodova Associate Software Quality Engineer From 7a586aff4b3709d19ac503340b686ab161e6514a Mon Sep 17 00:00:00 2001 From: Ganna Kaihorodova <gkaih...@redhat.com> Date: Thu, 4 Aug 2016 15:10:45 +0200 Subject: [PATCH] Fix for integration tests replication layouts Domain level 0 doesn't allow to create replica file on CA master, testcase was skipped with Domain level 0 [https://fedorahosted.org/freeipa/ticket/6134] --- ipatests/test_integration/test_replication_layouts.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ipatests/test_integration/test_replication_layouts.py b/ipatests/test_integration/test_replication_layouts.py index 9fd4ddca299ca99053aae17ae1d43d3c64650f40..e3f703459234e7b9c0be15275d83d35763ac0fba 100644 --- a/ipatests/test_integration/test_replication_layouts.py +++ b/ipatests/test_integration/test_replication_layouts.py @@ -3,10 +3,13 @@ # import time - +import pytest +from ipalib.constants import DOMAIN_LEVEL_0 +from ipatests.test_integration.env_config import get_global_config from ipatests.test_integration.base import IntegrationTest from ipatests.test_integration import tasks +config = get_global_config() class LayoutsBaseTest(IntegrationTest): @@ -26,7 +29,8 @@ class LayoutsBaseTest(IntegrationTest): for r in self.replicas: r.run_command(['ipa', 'user-show', test_user]) - +@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, +reason='does not work on DOMAIN_LEVEL_0 by design') class TestLineTopologyWithoutCA(LayoutsBaseTest): num_replicas = 3 -- 2.7.4 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0030][Tests] Fix authentication indicators tests failing due to removal of has_keytab key from list of expected attributes of update command
Greetings! ACK Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Lenka Doudova" <ldoud...@redhat.com> To: "freeipa-devel" <freeipa-devel@redhat.com> Sent: Monday, August 1, 2016 8:20:05 AM Subject: [Freeipa-devel] [PATCH 0030][Tests] Fix authentication indicators tests failing due to removal of has_keytab key from list of expected attributes of update command Hi, solution for https://fedorahosted.org/freeipa/ticket/5281 has removed has_keytab attribute from list of expected keys of service-mod command. Attached patch provides a fix for tests that consequently started to fail. Lenka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0027][Tests] Fix failing automember tests in 4.3
Greetings! ACK Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Lenka Doudova" <ldoud...@redhat.com> To: "freeipa-devel" <freeipa-devel@redhat.com> Sent: Wednesday, July 13, 2016 3:21:25 PM Subject: [Freeipa-devel] [PATCH 0027][Tests] Fix failing automember tests in 4.3 Hi, providing patch to fix two failing automember tests in 4.3 branch. The reason of the failure was the output normalization (specifically manager attribute for user). The patch is intended for ipa-4-3 branch only. Lenka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests
Hello! Thank you! Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Martin Basti" <mba...@redhat.com> To: "Ganna Kaihorodova" <gkaih...@redhat.com> Cc: freeipa-devel@redhat.com Sent: Thursday, July 21, 2016 8:03:53 PM Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests On 20.07.2016 18:17, Ganna Kaihorodova wrote: > Hello! > > Thank you for review. > I attached patch with fixed commit message > > > Best regards, > Ganna Kaihorodova > Associate Software Quality Engineer > > > - Original Message - > From: "Martin Basti" <mba...@redhat.com> > To: "Ganna Kaihorodova" <gkaih...@redhat.com>, freeipa-devel@redhat.com > Sent: Wednesday, July 20, 2016 5:04:47 PM > Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin > tests > > > > On 20.07.2016 17:02, Ganna Kaihorodova wrote: >> Greetings! >> >> Fix for ipatests/test_xmlrpc/test_dns_plugin.py >> >> Fix conflict between “got” and “expected” values when testing >> "dnsconfig_mod: Update global DNS settings" >> >> Best regards, >> Ganna Kaihorodova >> Associate Software Quality Engineer >> >> >> >> > LGTM, but can you fix commit message? > > This looks very suspicious > > Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?= >=?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?= >=?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?= > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > > regards, > Martin^2 ACK I just replaced some fancy unicode quotation marks with ASCII in commit message before push Pushed to master: 359cfeb7c6798038f5638f9d0977dda351f21431 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0001][Tests] Fix for dns_plugin tests
Hello! Thank you for review and notes about patch format. I will keep it in mind. I agree that this is not the best way to fix it and I was about to bring up topic of strange behavior of named/bind-dyndb-ldap. Because without restart named service I have one number of failing tests and after restart different number. This is happening for me randomly, I never know when I need to restart service. > I really don't like using 'ipa-ca.' domain name as server name, > this is not right. Can you please, explain me why? So if it's not too much trouble for you, maybe you can give me some advice's how to investigate such kind of issues, at least some basic stuff, like what to check, where to look and etc. It can be a letter or in a format of 1 hour meeting or presentation (I think it will be good to all members of our team to understand better how our dns plugin works and how to troubleshoot it) And it seems like I will spend some time with tests for our dns-plugin, and It will be really great to know more about it. Thank you and have a nice day! Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Martin Basti" <mba...@redhat.com> To: "Ganna Kaihorodova" <gkaih...@redhat.com>, freeipa-devel@redhat.com Sent: Wednesday, July 20, 2016 4:11:08 PM Subject: Re: [Freeipa-devel] [PATCH 0001][Tests] Fix for dns_plugin tests Hello, On 19.07.2016 17:45, Ganna Kaihorodova wrote: > Greetings! > > Fix for ipatests/test_xmlrpc/test_dns_plugin.py > (test_forwardzone_delegation_warnings.test) > > You can't have a DNS zone with the authoritative nameserver that does not > have a A or record in the local DNS. Not true > Since in some test environments primary hostname of the master is managed > by an external DNS, this hostname can not be used as a NS-record for > IPA-managed zones. Therefore another existing fqdn corresponding to the > master's ip and managed by IPA DNS was used. I really don't like using 'ipa-ca.' domain name as server name, this is not right. I was digging deeper today to find what is the root case why it doesn't work, and it looks that after some tests, named is not able to resolve hostname, even if global forwarder is specified. So this looks like bug on named/bind-dyndb-ldap side, because when I restarted named-pkcs11 before the first test that is failing and all forwardzone tests passed. So I think this patch just hides the real issue and we should discard it. I and pspacek will be continue investigating this tomorrow. Notes to the patch format: Please split that huge text in commit message to: short summary (max 72 chars) empty line longer description empty line [ticket (if available)] regars Martin^2 > > > Best regards, > Ganna Kaihorodova > Associate Software Quality Engineer > > > > -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests
Greetings!
Fix for ipatests/test_xmlrpc/test_dns_plugin.py
Fix conflict between “got” and “expected” values when testing "dnsconfig_mod:
Update global DNS settings"
Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer
From 94899bbb538129384a7faa22be1228e2fcd453cf Mon Sep 17 00:00:00 2001
From: Ganna Kaihorodova <gkaih...@redhat.com>
Date: Mon, 18 Jul 2016 19:20:51 +0200
Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?=
=?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?=
=?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
ipatests/test_xmlrpc/test_dns_plugin.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index 038d17e9debc86a8e9afcadcea30e7cee29bbd05..fd32ef24beeaa245e829554fb7a6da173f6624bc 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -1781,6 +1781,7 @@ class test_dns(Declarative):
}},
),
'result': {
+'dns_server_server': [api.env.host],
'idnsforwarders': [fwd_ip],
},
},
@@ -1792,7 +1793,7 @@ class test_dns(Declarative):
expected={
'value': None,
'summary': u'Global DNS configuration is empty',
-'result': {},
+'result': {'dns_server_server': [api.env.host]},
},
),
--
2.7.4
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH 0001][Tests] Fix for dns_plugin tests
Greetings!
Fix for ipatests/test_xmlrpc/test_dns_plugin.py
(test_forwardzone_delegation_warnings.test)
You can't have a DNS zone with the authoritative nameserver that does not have
a A or record in the local DNS. Since in some test environments primary
hostname of the master is managed by an external DNS, this hostname can not be
used as a NS-record for IPA-managed zones. Therefore another existing fqdn
corresponding to the master's ip and managed by IPA DNS was used.
Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer
From 23104798f8350966bec3637396a85b528a47a9f4 Mon Sep 17 00:00:00 2001
From: Ganna Kaihorodova <gkaih...@redhat.com>
Date: Mon, 18 Jul 2016 19:10:17 +0200
Subject: [PATCH 1/2] You can't have a dns zone with the authoritative
nameserver that does not have a A or record in the local DNS. Since in
some test environments primary hostname of the master is managed by an
external DNS, this hostname can not be used as a ns-record for IPA-managed
zones. Therefore another existing fqdn corresponding to the master's ip and
managed by IPA DNS was used
---
ipatests/test_xmlrpc/test_dns_plugin.py | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index f3484166dd3c5986978d89ca64589960b3d12338..038d17e9debc86a8e9afcadcea30e7cee29bbd05 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -1,6 +1,6 @@
# Authors:
# Pavel Zuna <pz...@redhat.com>
-#
+# Ganna Kaihorodova <gkaih...@redhat.com>
# Copyright (C) 2010 Red Hat
# see file 'COPYING' for use and warranty information
#
@@ -39,6 +39,7 @@ else:
_dns_zone_record = DNSName(u'@')
# default value of idnssoamname is local DNS server
+self_server_ns_1 = normalize_zone("ipa-ca.%s" % api.env.domain)
self_server_ns = normalize_zone(api.env.host)
self_server_ns_dnsname = DNSName(self_server_ns)
@@ -5078,7 +5079,7 @@ class test_forwardzone_delegation_warnings(Declarative):
desc='Delegate zone %r from zone %r using NS record' % (
zone1_sub_fw, zone1_sub),
command=('dnsrecord_add', [zone1_sub, u'fw'],
- {'nsrecord': self_server_ns}),
+ {'nsrecord': self_server_ns_1}),
expected={
'value': DNSName(u'fw'),
'summary': None,
@@ -5086,7 +5087,7 @@ class test_forwardzone_delegation_warnings(Declarative):
'objectclass': objectclasses.dnsrecord,
'dn': DN(('idnsname', u'fw'), zone1_sub_dn),
'idnsname': [DNSName(u'fw')],
-'nsrecord': [self_server_ns],
+'nsrecord': [self_server_ns_1],
},
},
),
@@ -5206,7 +5207,7 @@ class test_forwardzone_delegation_warnings(Declarative):
desc='Delegate zone %r from zone %r using NS record' % (
zone1_sub2_fw, zone1_sub),
command=('dnsrecord_add', [zone1_sub, u'fw.sub2'],
- {'nsrecord': self_server_ns}),
+ {'nsrecord': self_server_ns_1}),
expected={
'value': DNSName(u'fw.sub2'),
'summary': None,
@@ -5214,7 +5215,7 @@ class test_forwardzone_delegation_warnings(Declarative):
'objectclass': objectclasses.dnsrecord,
'dn': DN(('idnsname', u'fw.sub2'), zone1_sub_dn),
'idnsname': [DNSName(u'fw.sub2')],
-'nsrecord': [self_server_ns],
+'nsrecord': [self_server_ns_1],
},
},
),
@@ -5291,7 +5292,7 @@ class test_forwardzone_delegation_warnings(Declarative):
desc='Delegate zone %r from zone %r using NS record' % (
zone1_sub2_fw, zone1),
command=('dnsrecord_add', [zone1, u'fw.sub2.sub'],
- {'nsrecord': self_server_ns}),
+ {'nsrecord': self_server_ns_1}),
expected={
'value': DNSName(u'fw.sub2.sub'),
'summary': None,
@@ -5299,7 +5300,7 @@ class test_forwardzone_delegation_warnings(Declarative):
'objectclass': objectclasses.dnsrecord,
'dn': DN(('idnsname', u'fw.sub2.sub'), zone1_dn),
'idnsname': [DNSName(u'fw.sub2.sub')],
-'nsrecord': [self_server_ns],
+'nsrecord': [self_server_ns_1],
},
},
),
--
2.7.4
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0023][Tests] Fix frontend tests - #5987
Hello! ACK Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Lenka Doudova" <ldoud...@redhat.com> To: "freeipa-devel" <freeipa-devel@redhat.com> Sent: Tuesday, June 28, 2016 6:34:33 AM Subject: [Freeipa-devel] [PATCH 0023][Tests] Fix frontend tests - #5987 Hi, I've made patch to fix for https://fedorahosted.org/freeipa/ticket/5987. Please note, that this patch must be applied on top on my patch no. 0018, which provides other fixes on the same file (and same test). Lenka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0018][Tests] Fix some of the failing tests in test_ipalib/test_frontend.py
Hello! ACK Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Lenka Doudova" <ldoud...@redhat.com> To: "freeipa-devel" <freeipa-devel@redhat.com> Sent: Tuesday, June 21, 2016 10:21:44 AM Subject: [Freeipa-devel] [PATCH 0018][Tests] Fix some of the failing tests in test_ipalib/test_frontend.py Hi, attaching patch with fix for a few failing tests in ipatests/test_ipalib/test_frontend.py. Lenka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher than 255 cannot be set
Hello!
Everything is ok, so ack
Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer
- Original Message -
From: "Lenka Doudova" <ldoud...@redhat.com>
To: "Ganna Kaihorodova" <gkaih...@redhat.com>
Cc: freeipa-devel@redhat.com
Sent: Thursday, May 19, 2016 12:42:34 PM
Subject: Re: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher
than 255 cannot be set
On 05/18/2016 01:51 PM, Ganna Kaihorodova wrote:
>
> - Original Message -
> From: "Lenka Doudova" <ldoud...@redhat.com>
> To: "Ganna Kaihorodova" <gkaih...@redhat.com>
> Sent: Wednesday, May 18, 2016 10:37:49 AM
> Subject: Fwd: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length
> higher than 255 cannot be set
>
>
>
> Forwarded Message
> Subject: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length
> higher than 255 cannot be set
> Date: Fri, 13 May 2016 13:08:29 +0200
> From: Lenka Doudova <ldoud...@redhat.com>
> To: freeipa-devel <freeipa-devel@redhat.com>
>
>
>
> Patch attached.
>
> Lenka
>
>
> Hello,
>
> sorry, nack, because:
> 1. Tests doesn't clean up after performing. Max user name isn't returned
> original value.
>
> 2. pep8 errors:
> ./ipatests/test_xmlrpc/test_config_plugin.py:167:21: E126 continuation line
> over-indented for hanging indent
> ./ipatests/test_xmlrpc/test_config_plugin.py:170:17: E121 continuation line
> under-indented for hanging indent
>
>
> Best regards,
> Ganna Kaihorodova
> Associate Software Quality Engineer
Hi,
thanks for review, fixed patch attached.
Lenka
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher than 255 cannot be set
- Original Message -
From: "Lenka Doudova" <ldoud...@redhat.com>
To: "Ganna Kaihorodova" <gkaih...@redhat.com>
Sent: Wednesday, May 18, 2016 10:37:49 AM
Subject: Fwd: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length
higher than 255 cannot be set
Forwarded Message
Subject:[Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length
higher than 255 cannot be set
Date: Fri, 13 May 2016 13:08:29 +0200
From: Lenka Doudova <ldoud...@redhat.com>
To: freeipa-devel <freeipa-devel@redhat.com>
Patch attached.
Lenka
Hello,
sorry, nack, because:
1. Tests doesn't clean up after performing. Max user name isn't returned
original value.
2. pep8 errors:
./ipatests/test_xmlrpc/test_config_plugin.py:167:21: E126 continuation line
over-indented for hanging indent
./ipatests/test_xmlrpc/test_config_plugin.py:170:17: E121 continuation line
under-indented for hanging indent
Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
