Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port

[Andreas Hansson]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/#review9081
---


Thanks for this. Some minor requests and style issues, then it's good to go.


util/tlm/sc_master_port.cc (line 74)


It would be good to add a comment explaining where the request is deleted.



util/tlm/sc_master_port.cc (line 232)


this is not a safe assumption

use SimClock::Int::ps for the "conversion"



util/tlm/sc_master_port.cc (line 289)


do things work even if this is not TLM_UPDATED?


- Andreas Hansson


On Nov. 7, 2016, 2:56 p.m., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/
> ---
> 
> (Updated Nov. 7, 2016, 2:56 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11707:cb37987f081e
> ---
> misc: add a TLM to Gem5 Master Port
> 
> The current TLM code only provides a Slave Port that allows the gem5 world to
> send requests to the the TLM world. This patch adds a Master Port that allows
> the TLM world to send requests to the gem5 world. Furthermore, the patch
> provides a simple example application based on a TLM traffic generator.
> 
> 
> Diffs
> -
> 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
>   util/tlm/examples/master_port/traffic_generator.hh PRE-CREATION 
>   util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/README b3d5f0e9e258 
>   util/tlm/examples/master_port/SConstruct PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3528/diff/
> 
> 
> Testing
> ---
> 
> A simple example application consisting of a TLM traffic generator and a gem5 
> memory is part of the patch.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port

[Christian Menard]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/
---

(Updated Nov. 7, 2016, 2:56 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11707:cb37987f081e
---
misc: add a TLM to Gem5 Master Port

The current TLM code only provides a Slave Port that allows the gem5 world to
send requests to the the TLM world. This patch adds a Master Port that allows
the TLM world to send requests to the gem5 world. Furthermore, the patch
provides a simple example application based on a TLM traffic generator.


Diffs (updated)
-

  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.hh PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/README b3d5f0e9e258 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 

Diff: http://reviews.gem5.org/r/3528/diff/


Testing
---

A simple example application consisting of a TLM traffic generator and a gem5 
memory is part of the patch.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port

[Christian Menard]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/
---

(Updated Nov. 7, 2016, 2:50 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11707:a9ccba85c073
---
misc: add a TLM to Gem5 Master Port

The current TLM code only provides a Slave Port that allows the gem5 world to
send requests to the the TLM world. This patch adds a Master Port that allows
the TLM world to send requests to the gem5 world. Furthermore, the patch
provides a simple example application based on a TLM traffic generator.


Diffs (updated)
-

  util/tlm/README b3d5f0e9e258 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.hh PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3528/diff/


Testing
---

A simple example application consisting of a TLM traffic generator and a gem5 
memory is part of the patch.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port

[Matthias Jung]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/#review9002
---



util/tlm/examples/master_port/main.cc (line 54)


This function is also in the target example, could we source out all 
doublicated functions to a common dir/file?



util/tlm/examples/master_port/main.cc (line 74)


Similar to the Target (the example TLM memory): put this sc_module in a 
seperated file...



util/tlm/examples/master_port/tlm.py (line 62)


remove it if you dont need it



util/tlm/sc_master_port.cc (line 99)


XXX flag?


- Matthias Jung


On Okt. 28, 2016, 4:42 nachm., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/
> ---
> 
> (Updated Okt. 28, 2016, 4:42 nachm.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11690:b9fc391b2477
> ---
> misc: add a TLM to Gem5 Master Port
> 
> The current TLM code only provides a Slave Port that allows the gem5 world to
> send requests to the the TLM world. This patch adds a Master Port that allows
> the TLM world to send requests to the gem5 world. Furthermore, the patch
> provides a simple example application based on a TLM traffic generator.
> 
> 
> Diffs
> -
> 
>   util/tlm/README b3d5f0e9e258 
>   util/tlm/examples/master_port/SConstruct PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3528/diff/
> 
> 
> Testing
> ---
> 
> A simple example application consisting of a TLM traffic generator and a gem5 
> memory is part of the patch.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port

[Christian Menard]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/
---

(Updated Oct. 28, 2016, 4:42 p.m.)


Review request for Default.


Summary (updated)
-

misc: add a TLM to Gem5 Master Port


Repository: gem5


Description (updated)
---

Changeset 11690:b9fc391b2477
---
misc: add a TLM to Gem5 Master Port

The current TLM code only provides a Slave Port that allows the gem5 world to
send requests to the the TLM world. This patch adds a Master Port that allows
the TLM world to send requests to the gem5 world. Furthermore, the patch
provides a simple example application based on a TLM traffic generator.


Diffs (updated)
-

  util/tlm/README b3d5f0e9e258 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3528/diff/


Testing
---

A simple example application consisting of a TLM traffic generator and a gem5 
memory is part of the patch.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Andreas Hansson]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/#review8989
---


Some of the files are not displaying ok. Did you post the review using hg 
postreview?


util/tlm/examples/master_port/Makefile (line 37)


Same as previous patch. This should use pkt-config.



util/tlm/examples/master_port/Makefile (line 40)


An assignment to a name would be good for these paths. GEM5_ROOT or similar



util/tlm/examples/master_port/main.cc (line 101)


gem5 has a random_mt that you should preferably use



util/tlm/examples/master_port/main.cc (line 187)


Same as the other patch. Why not use the response string size?



util/tlm/sc_master_port.hh (line 32)


Not convention



util/tlm/sc_master_port.hh (line 49)


Could you provide a bit more comments here around what is assumed, how it 
does what it does, what it doesn't do, etc



util/tlm/sc_master_port.cc (line 32)


Same as the header



util/tlm/sc_master_port.cc (line 73)


Is it assumed that the request is deleted elsewhere?



util/tlm/sc_master_port.cc (line 81)


comma on the line before

name,
other name



util/tlm/sc_master_port.cc (line 90)


Why the re-interpret cast?



util/tlm/sc_master_port.cc (line 98)


it is not a big problem, but technically gem5 can change mode during the 
simulation.

The API for this is involving calls to drain and drain resume etc. We don't 
have to fix it now, but it may be worth at least warning if any of these 
functions are called.



util/tlm/sc_master_port.cc (line 116)


could we base this on the response string rather to avoid buffer overflows? 
:-)



util/tlm/sc_master_port.cc (line 126)


odd indentation



util/tlm/sc_master_port.cc (line 138)


what is this checking?


- Andreas Hansson


On Oct. 26, 2016, 4:23 p.m., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/
> ---
> 
> (Updated Oct. 26, 2016, 4:23 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> The current TLM code only provides a Slave Port that allows the gem5 world to 
> send requests to the the TLM world. This patch adds a Master Port that allows 
> the TLM world to send requests to the gem5 world. Furthermore, the patch 
> provides a simple example application based on a TLM traffic generator.
> 
> 
> Diffs
> -
> 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sim_control.cc c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 
>   util/tlm/examples/master_port/Makefile PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/examples/slave_port/Makefile 
> c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/README c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 
> 
> Diff: http://reviews.gem5.org/r/3528/diff/
> 
> 
> Testing
> ---
> 
> A simple example application consisting of a TLM traffic generator and a gem5 
> memory is part of the patch.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Christian Menard]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/
---

(Updated Oct. 26, 2016, 4:23 p.m.)


Review request for Default.


Changes
---

Updated the diff: rebased on 11691 and generated with mq


Repository: gem5


Description
---

The current TLM code only provides a Slave Port that allows the gem5 world to 
send requests to the the TLM world. This patch adds a Master Port that allows 
the TLM world to send requests to the gem5 world. Furthermore, the patch 
provides a simple example application based on a TLM traffic generator.


Diffs (updated)
-

  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sim_control.cc c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 
  util/tlm/examples/master_port/Makefile PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/slave_port/Makefile 
c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/README c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 

Diff: http://reviews.gem5.org/r/3528/diff/


Testing
---

A simple example application consisting of a TLM traffic generator and a gem5 
memory is part of the patch.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Christian Menard]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/
---

(Updated July 13, 2016, 1:09 p.m.)


Review request for Default.


Changes
---

Bugfix: Before this fix the test eventually resulted in an "Missed an event" 
error. With this new patch version, the event loop gets notified whenever a 
gem5 event is scheduled from a function in the SystemC world.

The review board complains about the patch not applying cleanly. Sorry about 
this, I tried to fix the patch, but locally it works perfectly...


Repository: gem5


Description (updated)
---

The current TLM code only provides a Slave Port that allows the gem5 world to 
send requests to the the TLM world. This patch adds a Master Port that allows 
the TLM world to send requests to the gem5 world. Furthermore, the patch 
provides a simple example application based on a TLM traffic generator.


Diffs (updated)
-

  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/slave_port/Makefile 
704b0198f747b766b839c577614eb2924fd1dfee 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sim_control.cc 704b0198f747b766b839c577614eb2924fd1dfee 
  util/tlm/README 704b0198f747b766b839c577614eb2924fd1dfee 
  util/tlm/examples/master_port/Makefile PRE-CREATION 

Diff: http://reviews.gem5.org/r/3528/diff/


Testing (updated)
---

A simple example application consisting of a TLM traffic generator and a gem5 
memory is part of the patch.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Matthias Jung]

> On Juni 23, 2016, 7:09 nachm., Matthias Jung wrote:
> > Dear Christian,
> > 
> > thank you for this nice contribution. I will have a look on your patch and 
> > maybe I can help you fixing your issue.
> > 
> > Regards
> > Matthias
> 
> Andreas Hansson wrote:
> Christian, Matthias, is there any sensible way we could actually get some 
> of this functionality tested? Including SystemC in ext seems problematic due 
> to the non-BSD compatible license, but perhaps we should do something like we 
> do with protobuf, and check if the host HAS_SYSTEMC or similar, and if so 
> compile the extra bits, and run the extra tests etc.
> 
> This is tremendously useful functionality, and it feels like it is bolted 
> on rather than properly integrated at the moment (not because of the 
> functionality, but due to the non-default use). Any thoughts or suggestions?
> 
> Matthias Jung wrote:
> What about an automated shell script that downloads SystemC from 
> http://accellera.org/images/downloads/standards/systemc/systemc-2.3.1.tgz and 
> compiles it? Its maybe a little complicated but makes things easy for people 
> that don't have SystemC by default. Usually people install SystemC in 
> /opt/systemc so thats a place that could be checked for existance. 
> Christian? what do you think?
> 
> Andreas Hansson wrote:
> I don't like the idea of the download, and would rather suggest we should 
> rely on pkg-config. Supposedly SystemC 2.3.1 actually does support pkg-config 
> properly, with package names SystemC, TLM and TLM2. Could someone confirm? If 
> that is the case, we could use the same flow as for protobuf for the 
> determination of HAVE_SYSTEMC.
> 
> The next step would be to build in support if SystemC is present and look 
> in more detail at how we deal with "with python" and building of the gem5 
> lib. Perhaps we want to revisit this flow and not mandate going via the lib 
> for SystemC (and rather just use a different main.cc)?

```bash
find .  -iname *.pc
/opt/systemc/lib-macosx64/pkgconfig/systemc.pc
/opt/systemc/lib-macosx64/pkgconfig/tlm.pc
```

seems that pkg-config is used.


- Matthias


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/#review8436
---


On Juni 24, 2016, 10:20 vorm., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/
> ---
> 
> (Updated Juni 24, 2016, 10:20 vorm.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> The current TLM code only provides a Slave Port that allows the gem5 world to 
> send requests to the the TLM world. This patch adds a Master Port that allows 
> the TLM world to send requests to the gem5 world. Furthermore, the patch 
> provides a simple example application based on a TLM traffic generator.
> 
> As of now the example code does not run error free. It eventually results in 
> an erro "fatal: Missed an event at time ...". So for now I leave the patch 
> for discussion until the error is resolved.
> 
> 
> Diffs
> -
> 
>   util/tlm/README dd6dfd38b6c2 
>   util/tlm/examples/master_port/Makefile PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/examples/slave_port/Makefile PRE-CREATION 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3528/diff/
> 
> 
> Testing
> ---
> 
> A simple example application consisting of a TLM traffic generator and a gem5 
> memory. Currently the test fails.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Andreas Hansson]

> On June 23, 2016, 7:09 p.m., Matthias Jung wrote:
> > Dear Christian,
> > 
> > thank you for this nice contribution. I will have a look on your patch and 
> > maybe I can help you fixing your issue.
> > 
> > Regards
> > Matthias
> 
> Andreas Hansson wrote:
> Christian, Matthias, is there any sensible way we could actually get some 
> of this functionality tested? Including SystemC in ext seems problematic due 
> to the non-BSD compatible license, but perhaps we should do something like we 
> do with protobuf, and check if the host HAS_SYSTEMC or similar, and if so 
> compile the extra bits, and run the extra tests etc.
> 
> This is tremendously useful functionality, and it feels like it is bolted 
> on rather than properly integrated at the moment (not because of the 
> functionality, but due to the non-default use). Any thoughts or suggestions?
> 
> Matthias Jung wrote:
> What about an automated shell script that downloads SystemC from 
> http://accellera.org/images/downloads/standards/systemc/systemc-2.3.1.tgz and 
> compiles it? Its maybe a little complicated but makes things easy for people 
> that don't have SystemC by default. Usually people install SystemC in 
> /opt/systemc so thats a place that could be checked for existance. 
> Christian? what do you think?

I don't like the idea of the download, and would rather suggest we should rely 
on pkg-config. Supposedly SystemC 2.3.1 actually does support pkg-config 
properly, with package names SystemC, TLM and TLM2. Could someone confirm? If 
that is the case, we could use the same flow as for protobuf for the 
determination of HAVE_SYSTEMC.

The next step would be to build in support if SystemC is present and look in 
more detail at how we deal with "with python" and building of the gem5 lib. 
Perhaps we want to revisit this flow and not mandate going via the lib for 
SystemC (and rather just use a different main.cc)?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/#review8436
---


On June 24, 2016, 10:20 a.m., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/
> ---
> 
> (Updated June 24, 2016, 10:20 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> The current TLM code only provides a Slave Port that allows the gem5 world to 
> send requests to the the TLM world. This patch adds a Master Port that allows 
> the TLM world to send requests to the gem5 world. Furthermore, the patch 
> provides a simple example application based on a TLM traffic generator.
> 
> As of now the example code does not run error free. It eventually results in 
> an erro "fatal: Missed an event at time ...". So for now I leave the patch 
> for discussion until the error is resolved.
> 
> 
> Diffs
> -
> 
>   util/tlm/README dd6dfd38b6c2 
>   util/tlm/examples/master_port/Makefile PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/examples/slave_port/Makefile PRE-CREATION 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3528/diff/
> 
> 
> Testing
> ---
> 
> A simple example application consisting of a TLM traffic generator and a gem5 
> memory. Currently the test fails.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Christian Menard]

Hi Andreas,

I didn't get your motivation for intergrating SystemC in gem5. You mention 
testing, but is it only testing related or you actually want to intergrate the 
TLM-Ports and other SystemC parts in gem5 so that it can be compiled into 
libgem5? (I would like this approach)

There isn't a standard path for placing SystemC in the system (Mostly because 
SystemC is not availbale as a packege in most distributions). So detecting if 
SystemC is installed is difficult. I think the best way (TM) would be to add a 
scons option '--with-systemc' that wgets the SystemC sources and compiles all 
SystemC modules.

Cheers,

Christian

On Friday, 1 July 2016 17:26:04 CEST Matthias Jung wrote:
> > On Juni 23, 2016, 7:09 nachm., Matthias Jung wrote:
> > > Dear Christian,
> > > 
> > > thank you for this nice contribution. I will have a look on your patch
> > > and maybe I can help you fixing your issue.
> > > 
> > > Regards
> > > Matthias
> > 
> > Andreas Hansson wrote:
> > Christian, Matthias, is there any sensible way we could actually get
> > some of this functionality tested? Including SystemC in ext seems
> > problematic due to the non-BSD compatible license, but perhaps we
> > should do something like we do with protobuf, and check if the host
> > HAS_SYSTEMC or similar, and if so compile the extra bits, and run the
> > extra tests etc.
> > 
> > This is tremendously useful functionality, and it feels like it is
> > bolted on rather than properly integrated at the moment (not because
> > of the functionality, but due to the non-default use). Any thoughts
> > or suggestions?
> What about an automated shell script that downloads SystemC from
> http://accellera.org/images/downloads/standards/systemc/systemc-2.3.1.tgz
> and compiles it? Its maybe a little complicated but makes things easy for
> people that don't have SystemC by default. Usually people install SystemC
> in /opt/systemc so thats a place that could be checked for existance.
> Christian? what do you think?
> 
> 
> - Matthias
> 
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/#review8436
> ---
> 
> On Juni 24, 2016, 10:20 vorm., Christian Menard wrote:
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviews.gem5.org/r/3528/
> > ---
> > 
> > (Updated Juni 24, 2016, 10:20 vorm.)
> > 
> > 
> > Review request for Default.
> > 
> > 
> > Repository: gem5
> > 
> > 
> > Description
> > ---
> > 
> > The current TLM code only provides a Slave Port that allows the gem5 world
> > to send requests to the the TLM world. This patch adds a Master Port that
> > allows the TLM world to send requests to the gem5 world. Furthermore, the
> > patch provides a simple example application based on a TLM traffic
> > generator.
> > 
> > As of now the example code does not run error free. It eventually results
> > in an erro "fatal: Missed an event at time ...". So for now I leave the
> > patch for discussion until the error is resolved.
> > 
> > 
> > Diffs
> > -
> > 
> >   util/tlm/README dd6dfd38b6c2
> >   util/tlm/examples/master_port/Makefile PRE-CREATION
> >   util/tlm/examples/master_port/main.cc PRE-CREATION
> >   util/tlm/examples/master_port/tlm.py PRE-CREATION
> >   util/tlm/examples/slave_port/Makefile PRE-CREATION
> >   util/tlm/sc_master_port.hh PRE-CREATION
> >   util/tlm/sc_master_port.cc PRE-CREATION
> >   util/tlm/sim_control.cc PRE-CREATION
> > 
> > Diff: http://reviews.gem5.org/r/3528/diff/
> > 
> > 
> > Testing
> > ---
> > 
> > A simple example application consisting of a TLM traffic generator and a
> > gem5 memory. Currently the test fails.
> > 
> > 
> > Thanks,
> > 
> > Christian Menard


-- 
Dipl.-Ing. Christian Menard
Research Assistant

TU Dresden
Faculty of Computer Science
Chair for Compiler Construction
01062 Dresden

Phone: +49 351 463-42441
e-Mail: christian.men...@tu-dresden.de

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Matthias Jung]

> On Juni 23, 2016, 7:09 nachm., Matthias Jung wrote:
> > Dear Christian,
> > 
> > thank you for this nice contribution. I will have a look on your patch and 
> > maybe I can help you fixing your issue.
> > 
> > Regards
> > Matthias
> 
> Andreas Hansson wrote:
> Christian, Matthias, is there any sensible way we could actually get some 
> of this functionality tested? Including SystemC in ext seems problematic due 
> to the non-BSD compatible license, but perhaps we should do something like we 
> do with protobuf, and check if the host HAS_SYSTEMC or similar, and if so 
> compile the extra bits, and run the extra tests etc.
> 
> This is tremendously useful functionality, and it feels like it is bolted 
> on rather than properly integrated at the moment (not because of the 
> functionality, but due to the non-default use). Any thoughts or suggestions?

What about an automated shell script that downloads SystemC from 
http://accellera.org/images/downloads/standards/systemc/systemc-2.3.1.tgz and 
compiles it? Its maybe a little complicated but makes things easy for people 
that don't have SystemC by default. Usually people install SystemC in 
/opt/systemc so thats a place that could be checked for existance. 
Christian? what do you think?


- Matthias


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/#review8436
---


On Juni 24, 2016, 10:20 vorm., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/
> ---
> 
> (Updated Juni 24, 2016, 10:20 vorm.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> The current TLM code only provides a Slave Port that allows the gem5 world to 
> send requests to the the TLM world. This patch adds a Master Port that allows 
> the TLM world to send requests to the gem5 world. Furthermore, the patch 
> provides a simple example application based on a TLM traffic generator.
> 
> As of now the example code does not run error free. It eventually results in 
> an erro "fatal: Missed an event at time ...". So for now I leave the patch 
> for discussion until the error is resolved.
> 
> 
> Diffs
> -
> 
>   util/tlm/README dd6dfd38b6c2 
>   util/tlm/examples/master_port/Makefile PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/examples/slave_port/Makefile PRE-CREATION 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3528/diff/
> 
> 
> Testing
> ---
> 
> A simple example application consisting of a TLM traffic generator and a gem5 
> memory. Currently the test fails.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Andreas Hansson]

> On June 23, 2016, 7:09 p.m., Matthias Jung wrote:
> > Dear Christian,
> > 
> > thank you for this nice contribution. I will have a look on your patch and 
> > maybe I can help you fixing your issue.
> > 
> > Regards
> > Matthias

Christian, Matthias, is there any sensible way we could actually get some of 
this functionality tested? Including SystemC in ext seems problematic due to 
the non-BSD compatible license, but perhaps we should do something like we do 
with protobuf, and check if the host HAS_SYSTEMC or similar, and if so compile 
the extra bits, and run the extra tests etc.

This is tremendously useful functionality, and it feels like it is bolted on 
rather than properly integrated at the moment (not because of the 
functionality, but due to the non-default use). Any thoughts or suggestions?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/#review8436
---


On June 24, 2016, 10:20 a.m., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/
> ---
> 
> (Updated June 24, 2016, 10:20 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> The current TLM code only provides a Slave Port that allows the gem5 world to 
> send requests to the the TLM world. This patch adds a Master Port that allows 
> the TLM world to send requests to the gem5 world. Furthermore, the patch 
> provides a simple example application based on a TLM traffic generator.
> 
> As of now the example code does not run error free. It eventually results in 
> an erro "fatal: Missed an event at time ...". So for now I leave the patch 
> for discussion until the error is resolved.
> 
> 
> Diffs
> -
> 
>   util/tlm/README dd6dfd38b6c2 
>   util/tlm/examples/master_port/Makefile PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/examples/slave_port/Makefile PRE-CREATION 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3528/diff/
> 
> 
> Testing
> ---
> 
> A simple example application consisting of a TLM traffic generator and a gem5 
> memory. Currently the test fails.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Christian Menard]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/
---

(Updated June 24, 2016, 10:20 a.m.)


Review request for Default.


Changes
---

Rebase patch to #3477


Repository: gem5


Description
---

The current TLM code only provides a Slave Port that allows the gem5 world to 
send requests to the the TLM world. This patch adds a Master Port that allows 
the TLM world to send requests to the gem5 world. Furthermore, the patch 
provides a simple example application based on a TLM traffic generator.

As of now the example code does not run error free. It eventually results in an 
erro "fatal: Missed an event at time ...". So for now I leave the patch for 
discussion until the error is resolved.


Diffs (updated)
-

  util/tlm/README dd6dfd38b6c2 
  util/tlm/examples/master_port/Makefile PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/slave_port/Makefile PRE-CREATION 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3528/diff/


Testing
---

A simple example application consisting of a TLM traffic generator and a gem5 
memory. Currently the test fails.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

[Matthias Jung]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3528/#review8436
---


Dear Christian,

thank you for this nice contribution. I will have a look on your patch and 
maybe I can help you fixing your issue.

Regards
Matthias

- Matthias Jung


On Juni 23, 2016, 3:32 nachm., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3528/
> ---
> 
> (Updated Juni 23, 2016, 3:32 nachm.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> The current TLM code only provides a Slave Port that allows the gem5 world to 
> send requests to the the TLM world. This patch adds a Master Port that allows 
> the TLM world to send requests to the gem5 world. Furthermore, the patch 
> provides a simple example application based on a TLM traffic generator.
> 
> As of now the example code does not run error free. It eventually results in 
> an erro "fatal: Missed an event at time ...". So for now I leave the patch 
> for discussion until the error is resolved.
> 
> 
> Diffs
> -
> 
>   util/tlm/README dd6dfd38b6c2 
>   util/tlm/examples/master_port/Makefile PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/examples/slave_port/Makefile PRE-CREATION 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3528/diff/
> 
> 
> Testing
> ---
> 
> A simple example application consisting of a TLM traffic generator and a gem5 
> memory. Currently the test fails.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev