Re: [gem5-dev] Review Request 2372: style: add .clang-format file
On Sept. 1, 2014, 6:14 p.m., Andreas Sandberg wrote: .clang-format, line 18 http://reviews.gem5.org/r/2372/diff/1/?file=41128#file41128line18 Has this changed name? The clang documentation lists DerivePointerAlignment, but not DerivePointerBinding. Nilay Vaish wrote: Documentation for version 3.4 lists DerivePointerBinding. That explains it. I was looking at the 3.6 documentation. (http://clang.llvm.org/docs/ClangFormatStyleOptions.html) - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/#review5321 --- On Sept. 3, 2014, 5:50 a.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/ --- (Updated Sept. 3, 2014, 5:50 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10318:34b549ec182b --- style: add .clang-format file The format specified in this file is used by clang-format to fix the formatting of a given file. Hopefully, this will ease the burden on the developers as they no longer need to manually format things. Diffs - .clang-format PRE-CREATION Diff: http://reviews.gem5.org/r/2372/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2372: style: add .clang-format file
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/ --- (Updated Sept. 3, 2014, 4:50 a.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 10318:34b549ec182b --- style: add .clang-format file The format specified in this file is used by clang-format to fix the formatting of a given file. Hopefully, this will ease the burden on the developers as they no longer need to manually format things. Diffs (updated) - .clang-format PRE-CREATION Diff: http://reviews.gem5.org/r/2372/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2372: style: add .clang-format file
On Sept. 1, 2014, 5:14 p.m., Andreas Sandberg wrote: .clang-format, line 18 http://reviews.gem5.org/r/2372/diff/1/?file=41128#file41128line18 Has this changed name? The clang documentation lists DerivePointerAlignment, but not DerivePointerBinding. Documentation for version 3.4 lists DerivePointerBinding. On Sept. 1, 2014, 5:14 p.m., Andreas Sandberg wrote: .clang-format, line 46 http://reviews.gem5.org/r/2372/diff/1/?file=41128#file41128line46 ?? The file was originally file generated using clang-format and the ellipsis came with it. - Nilay --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/#review5321 --- On Sept. 3, 2014, 4:50 a.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/ --- (Updated Sept. 3, 2014, 4:50 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10318:34b549ec182b --- style: add .clang-format file The format specified in this file is used by clang-format to fix the formatting of a given file. Hopefully, this will ease the burden on the developers as they no longer need to manually format things. Diffs - .clang-format PRE-CREATION Diff: http://reviews.gem5.org/r/2372/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2372: style: add .clang-format file
On Mon, 1 Sep 2014, Andreas Sandberg wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/#review5321 --- I looked into this tool a couple of months ago. At the time, I encountered some issues relating to indentation (IIRC, the way we indent case labels by 2 spaces wasn't supported). My conclusion at the time was that it wasn't possible to configure clang-format to adhere to the gem5 style. Has this changed? If not, I'd suggest that we don't commit this for now and wait while clang-format matures. I am not in a hurry to commit the patch. But I don't think waiting for clang-format to change is the right thing either. -- Nilay ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2372: style: add .clang-format file
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/#review5320 --- .clang-format http://reviews.gem5.org/r/2372/#comment4834 we usually do not use this style .clang-format http://reviews.gem5.org/r/2372/#comment4835 we usually do not use this style .clang-format http://reviews.gem5.org/r/2372/#comment4836 78 or 76 I would say Somehow we need to be able to tell clang to put the return type on a separate line for methods. This is one major difference with how things are done at the moment. The way we format our stats is also a bit of an odd one with the name .init .desc etc. the formatter really does not like this, and I'm not sure what to do about it. - Andreas Hansson On Sept. 1, 2014, 6:05 a.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/ --- (Updated Sept. 1, 2014, 6:05 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10318:a79d63495fed --- style: add .clang-format file The format specified in this file is used by clang-format to fix the formatting of a given file. Diffs - .clang-format PRE-CREATION Diff: http://reviews.gem5.org/r/2372/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2372: style: add .clang-format file
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/#review5321 --- I looked into this tool a couple of months ago. At the time, I encountered some issues relating to indentation (IIRC, the way we indent case labels by 2 spaces wasn't supported). My conclusion at the time was that it wasn't possible to configure clang-format to adhere to the gem5 style. Has this changed? If not, I'd suggest that we don't commit this for now and wait while clang-format matures. .clang-format http://reviews.gem5.org/r/2372/#comment4837 Shouldn't this be -2? .clang-format http://reviews.gem5.org/r/2372/#comment4838 I used 78 here. .clang-format http://reviews.gem5.org/r/2372/#comment4840 Has this changed name? The clang documentation lists DerivePointerAlignment, but not DerivePointerBinding. .clang-format http://reviews.gem5.org/r/2372/#comment4839 Shouldn't this be 'Linux'? That'd add a newline after function/namespace/class definitions. .clang-format http://reviews.gem5.org/r/2372/#comment4841 ?? - Andreas Sandberg On Sept. 1, 2014, 7:05 a.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/ --- (Updated Sept. 1, 2014, 7:05 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10318:a79d63495fed --- style: add .clang-format file The format specified in this file is used by clang-format to fix the formatting of a given file. Diffs - .clang-format PRE-CREATION Diff: http://reviews.gem5.org/r/2372/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
