Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2016-04-18 Thread Steve Reinhardt 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3194/#review8248
---

Ship it!


Thanks!

- Steve Reinhardt


On April 13, 2016, 7:23 a.m., Bjoern A. Zeeb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3194/
> ---
> 
> (Updated April 13, 2016, 7:23 a.m.)
> 
> 
> Review request for Default, Jason Lowe-Power and Steve Reinhardt.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> According to the Intel Multi Processor Specification rev 1.4 (-006) (*), 
> section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII 
> (blank-filled) strings<<.
> Properly pad the entries with the missing spaces at the end.
> 
> (*) http://www.intel.com/design/pentium/datashts/24201606.pdf
> 
> 
> Diffs
> -
> 
>   configs/common/FSConfig.py 9c7b55faea5d 
>   src/arch/x86/bios/IntelMP.py 9c7b55faea5d 
> 
> Diff: http://reviews.gem5.org/r/3194/diff/
> 
> 
> Testing
> ---
> 
> Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and 
> "ISA".
> 
> 
> Thanks,
> 
> Bjoern A. Zeeb
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2016-04-13 Thread Jason Lowe-Power 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3194/#review8198
---

Ship it!


Seems fine to me. The linux kernel I'm using boots correctly with the change.

In the future, make sure you use one of the keywords in the first line of the 
description (The keyword should be one or more of the following separated by 
commas: base, ext, stats, sim, syscall_emul, config, ruby, mem, cpu, 
gpu-compute, dev, energy, arch, arm, x86, alpha, mips, power, sparc, kvm, 
scons, tests, misc, style. From 
http://gem5.org/Submitting_Contributions#Creating_Patches). I think "config" is 
probably the right one for this patch.

- Jason Lowe-Power


On April 13, 2016, 2:23 p.m., Bjoern A. Zeeb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3194/
> ---
> 
> (Updated April 13, 2016, 2:23 p.m.)
> 
> 
> Review request for Default, Jason Lowe-Power and Steve Reinhardt.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> According to the Intel Multi Processor Specification rev 1.4 (-006) (*), 
> section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII 
> (blank-filled) strings<<.
> Properly pad the entries with the missing spaces at the end.
> 
> (*) http://www.intel.com/design/pentium/datashts/24201606.pdf
> 
> 
> Diffs
> -
> 
>   configs/common/FSConfig.py 9c7b55faea5d 
>   src/arch/x86/bios/IntelMP.py 9c7b55faea5d 
> 
> Diff: http://reviews.gem5.org/r/3194/diff/
> 
> 
> Testing
> ---
> 
> Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and 
> "ISA".
> 
> 
> Thanks,
> 
> Bjoern A. Zeeb
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2016-04-13 Thread Bjoern A. Zeeb 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3194/
---

(Updated April 13, 2016, 2:23 p.m.)


Review request for Default, Jason Lowe-Power and Steve Reinhardt.


Changes
---

Update diff.  Be careful given the "whitespace only" changes in FSConfig.py are 
the actual changes!


Repository: gem5


Description
---

According to the Intel Multi Processor Specification rev 1.4 (-006) (*), 
section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII 
(blank-filled) strings<<.
Properly pad the entries with the missing spaces at the end.

(*) http://www.intel.com/design/pentium/datashts/24201606.pdf


Diffs (updated)
-

  configs/common/FSConfig.py 9c7b55faea5d 
  src/arch/x86/bios/IntelMP.py 9c7b55faea5d 

Diff: http://reviews.gem5.org/r/3194/diff/


Testing
---

Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and 
"ISA".


Thanks,

Bjoern A. Zeeb

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2016-04-13 Thread Bjoern A. Zeeb 


> On Nov. 5, 2015, 3:21 p.m., Nilay Vaish wrote:
> > src/arch/x86/bios/IntelMP.py, lines 118-122
> > 
> >
> > This is a comment.  I don't see how changing it helps.  I would rather 
> > add the "6 byte" comment near the changes made to FSConfig.py.   Also 
> > should we add a check in the corresponding c++ class?

I am indifferent on fixing the comments or removing the quotes around them, or 
just adding the note about "space padded to 6 bytes".


- Bjoern A.


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3194/#review7494
---


On Nov. 4, 2015, 2:51 p.m., Bjoern A. Zeeb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3194/
> ---
> 
> (Updated Nov. 4, 2015, 2:51 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> According to the Intel Multi Processor Specification rev 1.4 (-006) (*), 
> section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII 
> (blank-filled) strings<<.
> Properly pad the entries with the missing spaces at the end.
> 
> (*) http://www.intel.com/design/pentium/datashts/24201606.pdf
> 
> 
> Diffs
> -
> 
>   src/arch/x86/bios/IntelMP.py 2d1d51615e0e 
>   configs/common/FSConfig.py 2d1d51615e0e 
> 
> Diff: http://reviews.gem5.org/r/3194/diff/
> 
> 
> Testing
> ---
> 
> Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and 
> "ISA".
> 
> 
> Thanks,
> 
> Bjoern A. Zeeb
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2015-11-05 Thread Nilay Vaish 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3194/#review7495
---


One moer thing.  Please confirm that x86 full system regression tests pass
with this change.

- Nilay Vaish


On Nov. 4, 2015, 2:51 p.m., Bjoern A. Zeeb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3194/
> ---
> 
> (Updated Nov. 4, 2015, 2:51 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> According to the Intel Multi Processor Specification rev 1.4 (-006) (*), 
> section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII 
> (blank-filled) strings<<.
> Properly pad the entries with the missing spaces at the end.
> 
> (*) http://www.intel.com/design/pentium/datashts/24201606.pdf
> 
> 
> Diffs
> -
> 
>   src/arch/x86/bios/IntelMP.py 2d1d51615e0e 
>   configs/common/FSConfig.py 2d1d51615e0e 
> 
> Diff: http://reviews.gem5.org/r/3194/diff/
> 
> 
> Testing
> ---
> 
> Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and 
> "ISA".
> 
> 
> Thanks,
> 
> Bjoern A. Zeeb
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2015-11-05 Thread Nilay Vaish 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3194/#review7494
---



src/arch/x86/bios/IntelMP.py (lines 118 - 122)


This is a comment.  I don't see how changing it helps.  I would rather add 
the "6 byte" comment near the changes made to FSConfig.py.   Also should we add 
a check in the corresponding c++ class?


- Nilay Vaish


On Nov. 4, 2015, 2:51 p.m., Bjoern A. Zeeb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3194/
> ---
> 
> (Updated Nov. 4, 2015, 2:51 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> According to the Intel Multi Processor Specification rev 1.4 (-006) (*), 
> section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII 
> (blank-filled) strings<<.
> Properly pad the entries with the missing spaces at the end.
> 
> (*) http://www.intel.com/design/pentium/datashts/24201606.pdf
> 
> 
> Diffs
> -
> 
>   src/arch/x86/bios/IntelMP.py 2d1d51615e0e 
>   configs/common/FSConfig.py 2d1d51615e0e 
> 
> Diff: http://reviews.gem5.org/r/3194/diff/
> 
> 
> Testing
> ---
> 
> Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and 
> "ISA".
> 
> 
> Thanks,
> 
> Bjoern A. Zeeb
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2015-11-04 Thread Bjoern A. Zeeb 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3194/
---

(Updated Nov. 4, 2015, 2:51 p.m.)


Review request for Default.


Changes
---

Also update the documenting comment in the class.


Repository: gem5


Description
---

According to the Intel Multi Processor Specification rev 1.4 (-006) (*), 
section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII 
(blank-filled) strings<<.
Properly pad the entries with the missing spaces at the end.

(*) http://www.intel.com/design/pentium/datashts/24201606.pdf


Diffs (updated)
-

  src/arch/x86/bios/IntelMP.py 2d1d51615e0e 
  configs/common/FSConfig.py 2d1d51615e0e 

Diff: http://reviews.gem5.org/r/3194/diff/


Testing
---

Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and 
"ISA".


Thanks,

Bjoern A. Zeeb

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev