Re: Guidance on copyrights in sample code.

2017-07-03 Thread Justin Mclean
Hi,

> That's actually why I asked James to pose the question on the general
> list.  I wasn't particularly sure if he found the right file, based on the
> comments made by Justin and was hoping Justin could speak up to explain why
> it is or isn't an issue

I believe it wasn’t this example but that there were copyright lines in ASF 
headers - see [1].

Sorry but I’ve since deleted the RC I downloaded and it doesn’t look to be 
available anymore so not 100% were it was.

Thanks,
Justin

1. https://www.apache.org/legal/src-headers.html#headers
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: Guidance on copyrights in sample code.

2017-07-03 Thread Craig Russell

> On Jul 3, 2017, at 5:08 PM, James Bognar  wrote:
> 
> Hrm...that sort of complicates the example.
> 
> Here's the example code that creates an Atom feed DTO with a copyright...
> 
File file = new File("fileName");
Charset charset = Charset.forName("utf-8");
// read the copyright notice from the file into the copyrightNotice string
String copyrightNotice =
org.apache.commons.io.FileUtils.readFileToString(file, charset);

> Feed f = new Feed()
>   ...
>   .rights(copyrightNotice);
>   ...
> 
> 
> How about just "Copyright (c) ..."?

My understanding of the problem is that RAT reports that there is a copyright 
notice in the code.

Craig
> 
> 
> On Mon, Jul 3, 2017 at 8:02 PM, Craig Russell  wrote:
> 
>> Hi James,
>> 
>> Instead of including "Copyright (c) 2001, Apache Foobar Foundation" in the
>> sample code, would it be possible/easy to "assume the copyright notice is
>> in a file and include the file contents here".
>> 
>> That is probably how you would want to do it anyway, considering the task
>> of updating copyright years should be limited to one file per distribution
>> in downstream users, similar to the single copyright notice that an Apache
>> project has in its distribution.
>> 
>> Craig
>> 
>>> On Jul 3, 2017, at 2:37 PM, James Bognar  wrote:
>>> 
>>> Need some quick guidance.
>>> 
>>> On the release vote for Juneau 6.3.0, Justin Mclean made this note...
>>> "There's a number of "Copyright (c) 2016, Apache Foundation” in the
>>> documentation you may want to update the year."
>>> 
>>> I tracked it down to sample code where the copyright statement itself was
>>> sample code.  (i.e. showing how to create an ATOM feed with an embedded
>>> copyright statement).
>>> 
>>> Can I change it to the following so that it's not flagged in the future?
>>> 
>>> "Copyright (c) 2001, Apache Foobar Foundation”
>>> 
>>> Or better ideas?
>> 
>> Craig L Russell
>> Secretary, Apache Software Foundation
>> c...@apache.org http://db.apache.org/jdo
>> 
>> 
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>> 
>> 

Craig L Russell
Secretary, Apache Software Foundation
c...@apache.org http://db.apache.org/jdo


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: Guidance on copyrights in sample code.

2017-07-03 Thread James Bognar
Hrm...that sort of complicates the example.

Here's the example code that creates an Atom feed DTO with a copyright...

Feed f = new Feed()
   ...
   .rights("Copyright (c) 2016, Apache Foundation")
   ...


How about just "Copyright (c) ..."?


On Mon, Jul 3, 2017 at 8:02 PM, Craig Russell  wrote:

> Hi James,
>
> Instead of including "Copyright (c) 2001, Apache Foobar Foundation" in the
> sample code, would it be possible/easy to "assume the copyright notice is
> in a file and include the file contents here".
>
> That is probably how you would want to do it anyway, considering the task
> of updating copyright years should be limited to one file per distribution
> in downstream users, similar to the single copyright notice that an Apache
> project has in its distribution.
>
> Craig
>
> > On Jul 3, 2017, at 2:37 PM, James Bognar  wrote:
> >
> > Need some quick guidance.
> >
> > On the release vote for Juneau 6.3.0, Justin Mclean made this note...
> > "There's a number of "Copyright (c) 2016, Apache Foundation” in the
> > documentation you may want to update the year."
> >
> > I tracked it down to sample code where the copyright statement itself was
> > sample code.  (i.e. showing how to create an ATOM feed with an embedded
> > copyright statement).
> >
> > Can I change it to the following so that it's not flagged in the future?
> >
> > "Copyright (c) 2001, Apache Foobar Foundation”
> >
> > Or better ideas?
>
> Craig L Russell
> Secretary, Apache Software Foundation
> c...@apache.org http://db.apache.org/jdo
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: Guidance on copyrights in sample code.

2017-07-03 Thread Craig Russell
Hi James,

Instead of including "Copyright (c) 2001, Apache Foobar Foundation" in the 
sample code, would it be possible/easy to "assume the copyright notice is in a 
file and include the file contents here". 

That is probably how you would want to do it anyway, considering the task of 
updating copyright years should be limited to one file per distribution in 
downstream users, similar to the single copyright notice that an Apache project 
has in its distribution.

Craig

> On Jul 3, 2017, at 2:37 PM, James Bognar  wrote:
> 
> Need some quick guidance.
> 
> On the release vote for Juneau 6.3.0, Justin Mclean made this note...
> "There's a number of "Copyright (c) 2016, Apache Foundation” in the
> documentation you may want to update the year."
> 
> I tracked it down to sample code where the copyright statement itself was
> sample code.  (i.e. showing how to create an ATOM feed with an embedded
> copyright statement).
> 
> Can I change it to the following so that it's not flagged in the future?
> 
> "Copyright (c) 2001, Apache Foobar Foundation”
> 
> Or better ideas?

Craig L Russell
Secretary, Apache Software Foundation
c...@apache.org http://db.apache.org/jdo


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: Guidance on copyrights in sample code.

2017-07-03 Thread James Bognar
> Also, why make the example strange? Why not take a real copyright header
> for an example?

A real copyright header can be mistaken for an actual copyright which gets
flagged during releases.


On Mon, Jul 3, 2017 at 7:52 PM, Ted Dunning  wrote:

> On Jul 3, 2017 3:43 PM, "John D. Ament"  wrote:
>
> On Mon, Jul 3, 2017 at 6:28 PM Ted Dunning  wrote:
>
> > That's confusing. Here are some questions and thoughts.
> >
> ...
> >
> >
>
>
>
> wouldn't get flagged.  I had posed on the list "1955 - 1971, Fake Atom
> Enterprises" which obviously would be an invalid copyright used only for
> demonstration purposes.  (for those unfamiliar, US Copyright law started in
> 1976, entities prior to that date wouldn't have been valid).
>
>
> US copyright laws started with authorization in the Constitution followed
> by enabling legislation shortly after Independence.
>
> US laws *changed* several times after that point. A particularly big change
> occurred in 1989 when the US entered the Berne convention by passing
> implementing legislation.
>
> Not sure what you could be thinking relative to 1976.
>
> Also, why make the example strange? Why not take a real copyright header
> for an example?
>
>
>
> >
> > On Jul 3, 2017 2:38 PM, "James Bognar"  wrote:
> >
> > > Need some quick guidance.
> > >
> > > On the release vote for Juneau 6.3.0, Justin Mclean made this note...
> > > "There's a number of "Copyright (c) 2016, Apache Foundation” in the
> > > documentation you may want to update the year."
> > >
> > > I tracked it down to sample code where the copyright statement itself
> was
> > > sample code.  (i.e. showing how to create an ATOM feed with an embedded
> > > copyright statement).
> > >
> > > Can I change it to the following so that it's not flagged in the
> future?
> > >
> > > "Copyright (c) 2001, Apache Foobar Foundation”
> > >
> > > Or better ideas?
> > >
> >
>


Re: Guidance on copyrights in sample code.

2017-07-03 Thread Ted Dunning
On Jul 3, 2017 3:43 PM, "John D. Ament"  wrote:

On Mon, Jul 3, 2017 at 6:28 PM Ted Dunning  wrote:

> That's confusing. Here are some questions and thoughts.
>
...
>
>



wouldn't get flagged.  I had posed on the list "1955 - 1971, Fake Atom
Enterprises" which obviously would be an invalid copyright used only for
demonstration purposes.  (for those unfamiliar, US Copyright law started in
1976, entities prior to that date wouldn't have been valid).


US copyright laws started with authorization in the Constitution followed
by enabling legislation shortly after Independence.

US laws *changed* several times after that point. A particularly big change
occurred in 1989 when the US entered the Berne convention by passing
implementing legislation.

Not sure what you could be thinking relative to 1976.

Also, why make the example strange? Why not take a real copyright header
for an example?



>
> On Jul 3, 2017 2:38 PM, "James Bognar"  wrote:
>
> > Need some quick guidance.
> >
> > On the release vote for Juneau 6.3.0, Justin Mclean made this note...
> > "There's a number of "Copyright (c) 2016, Apache Foundation” in the
> > documentation you may want to update the year."
> >
> > I tracked it down to sample code where the copyright statement itself
was
> > sample code.  (i.e. showing how to create an ATOM feed with an embedded
> > copyright statement).
> >
> > Can I change it to the following so that it's not flagged in the future?
> >
> > "Copyright (c) 2001, Apache Foobar Foundation”
> >
> > Or better ideas?
> >
>


Re: Guidance on copyrights in sample code.

2017-07-03 Thread James Bognar
Yes...to clarify, it's not a real copyright.  It's an example of a
copyright.

So the question is what copyright should I use so that it's not mistaken
for a real copyright.


On Mon, Jul 3, 2017 at 6:43 PM, John D. Ament  wrote:

> On Mon, Jul 3, 2017 at 6:28 PM Ted Dunning  wrote:
>
> > That's confusing. Here are some questions and thoughts.
> >
> > A) 2001?
> >
> > B) the only Apache foundation is the Apache software foundation. What did
> > you mean by foobar?
> >
> > C) you don't need a copyright notice on code included in the
> documentation.
> > Save that for the copy of the sample code that you put into a separate
> > file.
> >
> >
> That's actually why I asked James to pose the question on the general
> list.  I wasn't particularly sure if he found the right file, based on the
> comments made by Justin and was hoping Justin could speak up to explain why
> it is or isn't an issue, and if there's a way to include a sample atom that
> wouldn't get flagged.  I had posed on the list "1955 - 1971, Fake Atom
> Enterprises" which obviously would be an invalid copyright used only for
> demonstration purposes.  (for those unfamiliar, US Copyright law started in
> 1976, entities prior to that date wouldn't have been valid).
>
>
> >
> > On Jul 3, 2017 2:38 PM, "James Bognar"  wrote:
> >
> > > Need some quick guidance.
> > >
> > > On the release vote for Juneau 6.3.0, Justin Mclean made this note...
> > > "There's a number of "Copyright (c) 2016, Apache Foundation” in the
> > > documentation you may want to update the year."
> > >
> > > I tracked it down to sample code where the copyright statement itself
> was
> > > sample code.  (i.e. showing how to create an ATOM feed with an embedded
> > > copyright statement).
> > >
> > > Can I change it to the following so that it's not flagged in the
> future?
> > >
> > > "Copyright (c) 2001, Apache Foobar Foundation”
> > >
> > > Or better ideas?
> > >
> >
>


Re: Guidance on copyrights in sample code.

2017-07-03 Thread John D. Ament
On Mon, Jul 3, 2017 at 6:28 PM Ted Dunning  wrote:

> That's confusing. Here are some questions and thoughts.
>
> A) 2001?
>
> B) the only Apache foundation is the Apache software foundation. What did
> you mean by foobar?
>
> C) you don't need a copyright notice on code included in the documentation.
> Save that for the copy of the sample code that you put into a separate
> file.
>
>
That's actually why I asked James to pose the question on the general
list.  I wasn't particularly sure if he found the right file, based on the
comments made by Justin and was hoping Justin could speak up to explain why
it is or isn't an issue, and if there's a way to include a sample atom that
wouldn't get flagged.  I had posed on the list "1955 - 1971, Fake Atom
Enterprises" which obviously would be an invalid copyright used only for
demonstration purposes.  (for those unfamiliar, US Copyright law started in
1976, entities prior to that date wouldn't have been valid).


>
> On Jul 3, 2017 2:38 PM, "James Bognar"  wrote:
>
> > Need some quick guidance.
> >
> > On the release vote for Juneau 6.3.0, Justin Mclean made this note...
> > "There's a number of "Copyright (c) 2016, Apache Foundation” in the
> > documentation you may want to update the year."
> >
> > I tracked it down to sample code where the copyright statement itself was
> > sample code.  (i.e. showing how to create an ATOM feed with an embedded
> > copyright statement).
> >
> > Can I change it to the following so that it's not flagged in the future?
> >
> > "Copyright (c) 2001, Apache Foobar Foundation”
> >
> > Or better ideas?
> >
>


Re: Guidance on copyrights in sample code.

2017-07-03 Thread Ted Dunning
That's confusing. Here are some questions and thoughts.

A) 2001?

B) the only Apache foundation is the Apache software foundation. What did
you mean by foobar?

C) you don't need a copyright notice on code included in the documentation.
Save that for the copy of the sample code that you put into a separate
file.


On Jul 3, 2017 2:38 PM, "James Bognar"  wrote:

> Need some quick guidance.
>
> On the release vote for Juneau 6.3.0, Justin Mclean made this note...
> "There's a number of "Copyright (c) 2016, Apache Foundation” in the
> documentation you may want to update the year."
>
> I tracked it down to sample code where the copyright statement itself was
> sample code.  (i.e. showing how to create an ATOM feed with an embedded
> copyright statement).
>
> Can I change it to the following so that it's not flagged in the future?
>
> "Copyright (c) 2001, Apache Foobar Foundation”
>
> Or better ideas?
>


Guidance on copyrights in sample code.

2017-07-03 Thread James Bognar
Need some quick guidance.

On the release vote for Juneau 6.3.0, Justin Mclean made this note...
"There's a number of "Copyright (c) 2016, Apache Foundation” in the
documentation you may want to update the year."

I tracked it down to sample code where the copyright statement itself was
sample code.  (i.e. showing how to create an ATOM feed with an embedded
copyright statement).

Can I change it to the following so that it's not flagged in the future?

"Copyright (c) 2001, Apache Foobar Foundation”

Or better ideas?