Change in osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: correct FAKE_RSSI command template

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11433


Change subject: library/TRXC_Types.ttcn: correct FAKE_RSSI command template
..

library/TRXC_Types.ttcn: correct FAKE_RSSI command template

Absolute form of FAKE_RSSI command shall contain an optional
threshold value. Otherwise it's interpreted as relative form.

Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637
---
M library/TRXC_Types.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/33/11433/1

diff --git a/library/TRXC_Types.ttcn b/library/TRXC_Types.ttcn
index 1a37a8c..77666d9 100644
--- a/library/TRXC_Types.ttcn
+++ b/library/TRXC_Types.ttcn
@@ -58,10 +58,10 @@
 external function dec_TrxcMessage(in charstring id) return TrxcMessage
with { extension "prototype(convert) decode(TEXT)" };

-template (value) TrxcMessage ts_TRXC_FAKE_RSSI(uint8_t rssi) := {
+template (value) TrxcMessage ts_TRXC_FAKE_RSSI(uint8_t rssi, int16_t thresh := 
0) := {
cmd := {
verb := "FAKE_RSSI",
-   params := { int2str(rssi) }
+   params := { int2str(rssi), int2str(thresh) }
}
 }


--
To view, visit https://gerrit.osmocom.org/11433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637
Gerrit-Change-Number: 11433
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in osmocom-bb[master]: fake_trx: introduce CTRL commands for RSSI simulation

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded a new patch set (#2) to the change originally 
created by Pau Espin Pedrol. ( https://gerrit.osmocom.org/11432 )

Change subject: fake_trx: introduce CTRL commands for RSSI simulation
..

fake_trx: introduce CTRL commands for RSSI simulation

Since FakeTRX is a proxy, it basically emulates transceiver for
both osmo-bts-trx and trxcon, hence there are two separate and
independent control interfaces (usually, ports 6701 and 5701).

All simulation commands (see 'FAKE_*') are usually implemented
on both interfaces separately:

  - ctrl_if_bb.py - simulation commands affecting Uplink,
  - ctrl_if_bts.py - simulation commands affecting Downlink.

This change introduces the 'FAKE_RSSI' command for both CTRL
interfaces in two variations:

  - absolute: CMD FAKE_RSSI  
  - relative: CMD FAKE_RSSI <+-BASE_DELTA>

where 'THRESH' affects optional value randomization.

Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
---
M src/target/trx_toolkit/ctrl_if_bb.py
M src/target/trx_toolkit/ctrl_if_bts.py
2 files changed, 42 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/32/11432/2
--
To view, visit https://gerrit.osmocom.org/11432
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmocom-bb[master]: fake_trx: Implement CTRL if for FAKE_RSSI

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11432 )

Change subject: fake_trx: Implement CTRL if for FAKE_RSSI
..


Patch Set 1: Code-Review-1


--
To view, visit https://gerrit.osmocom.org/11432
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 22 Oct 2018 21:32:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft meas rep

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11430 )

Change subject: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft 
meas rep
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11430
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c8f05bde6f9dc8e8a649e877209192d829dd923
Gerrit-Change-Number: 11430
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:54:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11391 )

Change subject: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing
..

MSC_Tests: Extend timeout in TC_mo_setup_and_nothing

The mncc guard timer in osmo-msc expires after 180 sec. This tests
terminates early and fails. Lets expand the timeout in order to give the
test a chance to pass.

Change-Id: I9f954a8807c0f0513422693ac24c647da0bfafd1
Related: OS#3599
---
M msc/MSC_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 93d7c77..c0cd9d3 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1206,7 +1206,7 @@

 /* Test MO Call SETUP with no response from MNCC */
 private function f_tc_mo_setup_and_nothing(charstring id, BSC_ConnHdlrPars 
pars) runs on BSC_ConnHdlr {
-   f_init_handler(pars);
+   f_init_handler(pars, 190.0);

var CallParameters cpars := valueof(t_CallParams('12345'H, 0));

@@ -1218,7 +1218,7 @@

BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_CC_SETUP(cpars.transaction_id, 
cpars.called_party)));

-   f_expect_clear(30.0);
+   f_expect_clear(185.0);
 }
 testcase TC_mo_setup_and_nothing() runs on MTC_CT {
var BSC_ConnHdlr vc_conn;

--
To view, visit https://gerrit.osmocom.org/11391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f954a8807c0f0513422693ac24c647da0bfafd1
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-ttcn3-hacks[master]: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11391 )

Change subject: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f954a8807c0f0513422693ac24c647da0bfafd1
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:23:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: fake_trx: Implement CTRL if for FAKE_RSSI

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11432 )

Change subject: fake_trx: Implement CTRL if for FAKE_RSSI
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11432
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:22:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft meas rep

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11430 )

Change subject: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft 
meas rep
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11430
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c8f05bde6f9dc8e8a649e877209192d829dd923
Gerrit-Change-Number: 11430
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:22:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: RSL_Emulation: handle ASP_IPA_EVENT_DOWN

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11429 )

Change subject: RSL_Emulation: handle ASP_IPA_EVENT_DOWN
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG@9
PS2, Line 9: Otherwise RSL layer fails this way when this event is received:
Why are we expecting the RSL layer to ever receive an ASP_IPA_EVENT_DOWN?  I 
agree the message is a bit cryptic, but I'm not sure if it is the right 
approach to simply ignore it.  Rather than ignoring, we could explicitly 
fail/stop?



--
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:21:31 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11428/2/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11428/2/bts/BTS_Tests.ttcn@336
PS2, Line 336:  };
rather than copy+pasting the entire array, one could probably have simply used 
the "append" operator (&) to add the one additional element in case 
mp_bb_trxc_port==-1.  But well, not critical.



--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:19:56 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failure of network:osmocom:nightly/osmo-python-tests in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-python-tests failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-python-tests

Last lines of build log:
[   21s] Processing triggers for libc-bin (2.23-0ubuntu3) ...
[   21s] [86/211] installing libunistring0-0.9.3-5.2ubuntu1
[   21s] Processing triggers for libc-bin (2.23-0ubuntu3) ...
[   21s] [87/211] installing unzip-6.0-20ubuntu1
[   21s] Processing triggers for mime-support (3.59ubuntu1) ...
[   21s] [88/211] installing groff-base-1.22.3-7
[   21s] Processing triggers for mime-support (3.59ubuntu1) ...
[   21s] [89/211] installing less-481-2.1
[   22s] Processing triggers for mime-support (3.59ubuntu1) ...
[   22s] [90/211] installing libc6-dev-2.23-0ubuntu3
[   22s] [91/211] installing libicu55-55.1-7
[   23s] Processing triggers for libc-bin (2.23-0ubuntu3) ...
[   23s] [92/211] installing python2.7-minimal-2.7.11-7ubuntu1
[   23s] Segmentation fault (core dumped)
[   23s] dpkg: error processing package python2.7-minimal (--install):
[   23s]  subprocess installed post-installation script returned error exit 
status 139
[   23s] Errors were encountered while processing:
[   23s]  python2.7-minimal
[   23s] exit ...
[   23s] 
[   23s] sheep83 failed "build osmo-python-tests_0.0.9.20181022.dsc" at Mon Oct 
22 20:05:54 UTC 2018.
[   23s] 
[   23s] ### VM INTERACTION START ###
[   26s] [   19.194381] sysrq: SysRq : Power Off
[   26s] [   19.199261] reboot: Power down
[   26s] ### VM INTERACTION END ###
[   26s] 
[   26s] sheep83 failed "build osmo-python-tests_0.0.9.20181022.dsc" at Mon Oct 
22 20:05:57 UTC 2018.
[   26s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft meas rep

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11430 )

Change subject: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft 
meas rep
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11430
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c8f05bde6f9dc8e8a649e877209192d829dd923
Gerrit-Change-Number: 11430
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Mon, 22 Oct 2018 18:26:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: fake_trx: Implement CTRL if for FAKE_RSSI

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11432


Change subject: fake_trx: Implement CTRL if for FAKE_RSSI
..

fake_trx: Implement CTRL if for FAKE_RSSI

Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
---
M src/target/trx_toolkit/ctrl_if_bb.py
1 file changed, 23 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/32/11432/1

diff --git a/src/target/trx_toolkit/ctrl_if_bb.py 
b/src/target/trx_toolkit/ctrl_if_bb.py
index 808c880..85aca15 100644
--- a/src/target/trx_toolkit/ctrl_if_bb.py
+++ b/src/target/trx_toolkit/ctrl_if_bb.py
@@ -144,6 +144,29 @@

return 0

+   # RSSI simulation for Uplink
+   # Absolute form: CMD FAKE_RSSI  
+   elif self.verify_cmd(request, "FAKE_RSSI", 2):
+   print("[i] Recv FAKE_RSSI cmd")
+
+   # Parse and apply both base and threshold
+   self.burst_fwd.randomize_ul_rssi = True
+   self.burst_fwd.rssi_ul_base = int(request[1])
+   self.burst_fwd.rssi_ul_threshold = int(request[2])
+
+   return 0
+
+   # Timing of Arrival simulation for Uplink
+   # Relative form: CMD FAKE_RSSI 
+   elif self.verify_cmd(request, "FAKE_RSSI", 1):
+   print("[i] Recv FAKE_RSSI cmd")
+
+   # Parse and apply value
+   self.burst_fwd.randomize_ul_rssi = False
+   self.burst_fwd.rssi_ul_base = int(request[1])
+
+   return 0
+
# Path loss simulation for UL: burst dropping
# Syntax: CMD FAKE_DROP 
# Dropping pattern: fn % 1 == 0

--
To view, visit https://gerrit.osmocom.org/11432
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11431


Change subject: ttcn3-bts-test: Log fake_trx output to file
..

ttcn3-bts-test: Log fake_trx output to file

Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/31/11431/1

diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 1cd06e7..fe448f5 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -17,6 +17,8 @@

 mkdir $VOL_BASE_DIR/unix

+mkdir $VOL_BASE_DIR/fake_trx
+
 echo Starting container with BSC
 docker run --rm \
--network $NET_NAME --ip 172.18.9.11 \
@@ -37,9 +39,10 @@
 echo Starting container with fake_trx
 docker run --rm \
--network $NET_NAME --ip 172.18.9.21 \
+   -v $VOL_BASE_DIR/fake_trx:/data \
--name ${BUILD_TAG}-fake_trx -d \
$REPO_USER/osmocom-bb-host-master \
-   /tmp/osmocom-bb/src/target/trx_toolkit/fake_trx.py -R 
172.18.9.20 -r 172.18.9.22
+   bash -c "/tmp/osmocom-bb/src/target/trx_toolkit/fake_trx.py -R 
172.18.9.20 -r 172.18.9.22 >/data/fake_trx.log 2>&1"

 echo Starting container with trxcon
 docker run --rm \

--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 22 Oct 2018 17:12:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft meas rep

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11430


Change subject: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft 
meas rep
..

bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft meas rep

Change-Id: I1c8f05bde6f9dc8e8a649e877209192d829dd923
---
M bts/BTS_Tests.ttcn
1 file changed, 5 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/30/11430/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 907a76a..bf85818 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -58,6 +58,7 @@
integer mp_tolerance_rxlev := 3;
integer mp_tolerance_timing_offset_256syms := 0;
integer mp_rxlev_exp := 57;
+   integer mp_ul_rxlev_exp := 10;
integer mp_ms_power_level_exp := 7;
integer mp_ms_actual_ta_exp := 0;
integer mp_timing_offset_256syms_exp := 512;
@@ -530,11 +531,11 @@
toa256_enabled := false,
meas_ul := {
full := {
-   rxlev := dbm2rxlev(-53),
+   rxlev := mp_ul_rxlev_exp,
rxqual := 0
},
sub := {
-   rxlev := dbm2rxlev(-53),
+   rxlev := mp_ul_rxlev_exp,
rxqual := 0
}
},
@@ -1174,7 +1175,7 @@
var L1ctlDlMessage l1_dl;
[] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, tr_RslLinkID_SACCH(?))) 
-> value l1_dl {
log("SACCH received: ", l1_dl.payload.data_ind.payload);
-   var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(true, 23, 
23, 0, 0, omit));
+   var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(true, 
mp_rxlev_exp, mp_rxlev_exp, 0, 0, omit));
var LapdmFrameAB lb := valueof(ts_LAPDm_AB(0, false, false, 
enc_GsmRrL3Message(meas_rep)));
log("LAPDm: ", lb);

@@ -1417,10 +1418,8 @@
f_l1_tune(L1CTL);
RSL.clear;

-   g_pars.l1_pars.meas_ul.full.rxlev := dbm2rxlev(-100);
-   g_pars.l1_pars.meas_ul.sub.rxlev := g_pars.l1_pars.meas_ul.full.rxlev;
if (mp_bb_trxc_port != -1) {
-   f_trxc_fake_rssi(100);
+   f_trxc_fake_rssi(-1 * rxlev2dbm(mp_ul_rxlev_exp));
f_trx_fake_toffs256(g_pars.l1_pars.timing_offset_256syms);
}


--
To view, visit https://gerrit.osmocom.org/11430
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c8f05bde6f9dc8e8a649e877209192d829dd923
Gerrit-Change-Number: 11430
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-trx[master]: sigProcLib: introduce both TS1 and TS2 RACH synch. sequences

[Vadim Yanitskiy]

Hello Tom Tsou, Max, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11390

to look at the new patch set (#3).

Change subject: sigProcLib: introduce both TS1 and TS2 RACH synch. sequences
..

sigProcLib: introduce both TS1 and TS2 RACH synch. sequences

According to 3GPP TS 05.02, section 5.2.7, there are three
synch. sequences for Access Bursts:

  - TS0: GSM, GMSK (default),
  - TS1: EGPRS, 8-PSK,
  - TS2: EGPRS, GMSK.

Let's prepare everythyng to be able to detect all TS0-3 synch.
sequences, but keep detection of both TS1 and TS2 disabled
until the corresponding VTY option is introduced.

Change-Id: I838c21db29c54f1924dd478c2b34b46b70aab2cd
Related: OS#3054
---
M GSM/GSMCommon.cpp
M GSM/GSMCommon.h
M Transceiver52M/radioInterface.cpp
M Transceiver52M/sigProcLib.cpp
4 files changed, 31 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/90/11390/3
--
To view, visit https://gerrit.osmocom.org/11390
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I838c21db29c54f1924dd478c2b34b46b70aab2cd
Gerrit-Change-Number: 11390
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Tom Tsou 

Change in osmo-trx[master]: sigProcLib: add a CorrType for extended (11-bit) RACH

[Vadim Yanitskiy]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11422

to look at the new patch set (#2).

Change subject: sigProcLib: add a CorrType for extended (11-bit) RACH
..

sigProcLib: add a CorrType for extended (11-bit) RACH

This is a preparatory change that enables a possibility to choose
the amount of synch. sequences to be used for Access Burst (RACH)
detection. The VTY flag will be introduced in further changes.

There are two correlation types now:

  - RACH (default) - TS0 only;
  - EXT_RACH - all TS0, TS1, and TS2 together.

Change-Id: Ia4f20524350bb8c380d7e10360758eddae8b03e9
Related: OS#3054
---
M Transceiver52M/sigProcLib.cpp
M Transceiver52M/sigProcLib.h
2 files changed, 12 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/22/11422/2
--
To view, visit https://gerrit.osmocom.org/11422
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4f20524350bb8c380d7e10360758eddae8b03e9
Gerrit-Change-Number: 11422
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..


Patch Set 1:

Hi Harald,

> [...] when RACH Detection is enabled on TCH during handover,
> we never need TS1/TS2 and hence can optimize that case.

Thanks, good point! I was thinking about that.

> did you actually do some benchmarking to see
> if my suspicion about performance impact was correct?

Not yet, and not sure will I be able to do in short term.
Anyway, which tool(s) would you recommend for benchmarking?

> it would be great if we could somehow do this automatically,
> [...] Maybe some addition to the TRXCTRL protocol? [...]

This is also a good idea! But it would require more efforts,
and could be done in a separate change I think.


--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 22 Oct 2018 15:33:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #284

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in docker-playground[master]: jenkins-common.sh: add docker_images_require()

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11365 )

Change subject: jenkins-common.sh: add docker_images_require()
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/11365/1/jenkins-common.sh
File jenkins-common.sh:

https://gerrit.osmocom.org/#/c/11365/1/jenkins-common.sh@5
PS1, Line 5: docker_images_require() {
> On the one hand we want atomic commits, i.e. as small as makes sense. […]
Thanks for the explanation. For this time I've added the change-id it prepares 
for to the commit message, and next time I'll submit it together with the first 
usage unless there's a good reason to do it otherwise.



--
To view, visit https://gerrit.osmocom.org/11365
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Mon, 22 Oct 2018 14:46:12 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in docker-playground[master]: symlinks: ttcn3-bsc-test-sccplite

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11367 )

Change subject: symlinks: ttcn3-bsc-test-sccplite
..


Patch Set 5: Verified+1


--
To view, visit https://gerrit.osmocom.org/11367
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d1d277475090cd615a0e2d07a42b2032cdefb9c
Gerrit-Change-Number: 11367
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Mon, 22 Oct 2018 14:46:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11370 )

Change subject: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs
..


Patch Set 4:

(1 comment)

> I don't like the file name "testsuite.yml" -- we have so many different test 
> suites, better to indicate which one this is about in the name.

Fixed, it's called "ttcn3-testsuites.yml" now.

> What's "nplab"?

The m3ua and sua jobs are prefixed with that (the existing jobs). It seems to 
stand for "Network Programming Lab of Münster University of Applied Sciences", 
see  and .

https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml
File jobs/testsuite.yml:

https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml@26
PS1, Line 26:
> I've realized that in order to do that, I'll need to rewrite the file a bit - 
> right now it can only  […]
With the latest patchset, it should be possible to safely migrate the existing 
jobs (they won't be disabled, timers have been added based on existing configs, 
e-mail notifications for laforge have been enabled just like it was in all 
existing jobs). It is still commented out though, so it does not happen by 
accident.

So... after you guys have reviewed the patch, we could roll out it as follows:
* remove comments
* update the jobs
* update this patch to remove the comments as well

Is that alright?



--
To view, visit https://gerrit.osmocom.org/11370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
Gerrit-Change-Number: 11370
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Mon, 22 Oct 2018 14:45:20 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
..


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11428/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11428/1//COMMIT_MSG@7
PS1, Line 7: bts: Disable testing FACCH/H with real HW
Would be great to point out that we *temporary* disable
testing on FACCH/H *because* Calypso PHY is not stable.


https://gerrit.osmocom.org/#/c/11428/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11428/1/bts/BTS_Tests.ttcn@316
PS1, Line 316: FACCH/H is unreliable with calypso firmware, see OS#3653
Let's format this comment as "FIXME: ...".



--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 22 Oct 2018 14:43:37 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11428


Change subject: bts: Disable testing FACCH/H with real HW
..

bts: Disable testing FACCH/H with real HW

Related: OS#3653
Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
---
M bts/BTS_Tests.ttcn
1 file changed, 22 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/28/11428/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 2f48b0f..3debb62 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -312,17 +312,29 @@
valueof(ts_RslChanNr_SDCCH8(6,4)), 
valueof(ts_RslChanNr_SDCCH8(6,5)),
valueof(ts_RslChanNr_SDCCH8(6,6)), 
valueof(ts_RslChanNr_SDCCH8(6,7))
};
-   g_AllChanTypes := {
-   /* TS 1..4: TCH/F */
-   valueof(ts_RslChanNr_Bm(1)),
-   /* TS 5: TCH/H */
-   valueof(ts_RslChanNr_Lm(5,1)),
-   /* TS 0: SDCCH/4 */
-   valueof(ts_RslChanNr_SDCCH4(0,2)),
-   /* TS 6: SDCCH/8 */
-   valueof(ts_RslChanNr_SDCCH8(6,4))
-   };

+   /* FACCH/H is unreliable with calypso firmware, see OS#3653 */
+   if (mp_bb_trxc_port != -1) {
+   g_AllChanTypes := {
+   /* TS 1..4: TCH/F */
+   valueof(ts_RslChanNr_Bm(1)),
+   /* TS 5: TCH/H */
+   valueof(ts_RslChanNr_Lm(5,1)),
+   /* TS 0: SDCCH/4 */
+   valueof(ts_RslChanNr_SDCCH4(0,2)),
+   /* TS 6: SDCCH/8 */
+   valueof(ts_RslChanNr_SDCCH8(6,4))
+   };
+   } else {
+   g_AllChanTypes := {
+   /* TS 1..4: TCH/F */
+   valueof(ts_RslChanNr_Bm(1)),
+   /* TS 0: SDCCH/4 */
+   valueof(ts_RslChanNr_SDCCH4(0,2)),
+   /* TS 6: SDCCH/8 */
+   valueof(ts_RslChanNr_SDCCH8(6,4))
+   };
+   }
f_init_rsl(id);
T.start;
alt {

--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: RSL_Emulation: handle ASP_IPA_EVENT_DOWN

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11429


Change subject: RSL_Emulation: handle ASP_IPA_EVENT_DOWN
..

RSL_Emulation: handle ASP_IPA_EVENT_DOWN

Otherwise RSL layer fails this way when this event is received:

RSL_Emulation.ttcn:429 Receive operation on port IPA_PT succeeded, message from 
TC_chan_act_a51-RSL-IPA(3): @IPA_Emulation.ASP_IPA_Event: { up_down := 
ASP_IPA_EVENT_DOWN (0) } id 9
- Function main_client was stopped. PTC terminates.
RSL_Emulation.ttcn:429 Message with id 9 was extracted from the queue of IPA_PT.
RSL_Emulation.ttcn:430 setverdict(fail): none -> fail reason: "Received unknown 
primitive from IPA", new component reason: "Received unknown primitive from IPA"

Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
---
M library/RSL_Emulation.ttcn
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/29/11429/1

diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index c56c278..57efcc1 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -346,6 +346,11 @@
[not bts_role] IPA_PT.receive(ASP_IPA_Event:{up_down := 
ASP_IPA_EVENT_UP}) -> value evt {
CCHAN_PT.send(evt);
}
+   [bts_role] IPA_PT.receive(ASP_IPA_Event:{up_down := 
ASP_IPA_EVENT_DOWN}) {
+   }
+   [not bts_role] IPA_PT.receive(ASP_IPA_Event:{up_down := 
ASP_IPA_EVENT_DOWN}) -> value evt {
+   CCHAN_PT.send(evt);
+   }
[bts_role] IPA_PT.receive(ASP_IPA_Event:{up_down := 
ASP_IPA_EVENT_ID_ACK}) {

IPA_PT.send(ts_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,ts_RSL_PAGING_LOAD_IND(23)));
}

--
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ci[master]: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

[osmith]

Hello Neels Hofmeyr,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11370

to look at the new patch set (#4).

Change subject: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs
..

jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

New JJB config, that is able to generate all jobs in the TTCN3 tab at
Jenkins: 

The new *-latest jobs test against the latest stable releases. Existing
jobs are not overwritten (this is commented out).
ttcn3-bsc-test-sccplite-latest is disabled for now, because it hangs
forever.

Related: OS#3268
Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
---
A jobs/ttcn3-testsuites.yml
1 file changed, 106 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/70/11370/4
--
To view, visit https://gerrit.osmocom.org/11370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
Gerrit-Change-Number: 11370
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in docker-playground[master]: jenkins.sh: IMAGE_SUFFIX, docker_images_require()

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11366 )

Change subject: jenkins.sh: IMAGE_SUFFIX, docker_images_require()
..


Patch Set 5: Verified+1


--
To view, visit https://gerrit.osmocom.org/11366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb708ab16cb71bab5069127945b63388222369e
Gerrit-Change-Number: 11366
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Mon, 22 Oct 2018 14:25:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: symlinks: ttcn3-bsc-test-sccplite

[osmith]

Hello Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11367

to look at the new patch set (#5).

Change subject: symlinks: ttcn3-bsc-test-sccplite
..

symlinks: ttcn3-bsc-test-sccplite

Create the ttcn3-bsc-test-sccplite folder, with symlinks to
ttcn3-bsc-test/jenkins-sccplite.sh and ttcn3-bsc-test/sccplite. This
allows writing the jenkins job builder config files in a generic way.

Related: OS#3268
Change-Id: I1d1d277475090cd615a0e2d07a42b2032cdefb9c
---
A ttcn3-bsc-test-sccplite/jenkins.sh
A ttcn3-bsc-test-sccplite/sccplite
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/67/11367/5
--
To view, visit https://gerrit.osmocom.org/11367
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d1d277475090cd615a0e2d07a42b2032cdefb9c
Gerrit-Change-Number: 11367
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

[osmith]

Hello Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11368

to look at the new patch set (#7).

Change subject: rename m3ua-test, sua-test to nplab-*-test
..

rename m3ua-test, sua-test to nplab-*-test

Allows writing a generic Jenkins Job Builder config by renaming the
container folders to match the job names. This needs changes in the
Jenkins jobs, as done in Ie433925ee81a61c5788b4a6f2bc5b89c2689d251.

Related: OS#3268
Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
---
R nplab-m3ua-test/.release
R nplab-m3ua-test/Dockerfile
R nplab-m3ua-test/Makefile
R nplab-m3ua-test/all-sgp-tests.txt
R nplab-m3ua-test/dotguile
R nplab-m3ua-test/jenkins.sh
R nplab-m3ua-test/m3ua-param-testtool.scm
R nplab-m3ua-test/osmo-stp.cfg
R nplab-sua-test/.release
R nplab-sua-test/Dockerfile
R nplab-sua-test/Makefile
R nplab-sua-test/dotguile
R nplab-sua-test/jenkins.sh
R nplab-sua-test/osmo-stp.cfg
R nplab-sua-test/some-sua-sgp-tests.txt
R nplab-sua-test/sua-param-testtool-sgp.scm
16 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/68/11368/7
--
To view, visit https://gerrit.osmocom.org/11368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
Gerrit-Change-Number: 11368
Gerrit-PatchSet: 7
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith 
Gerrit-CC: Neels Hofmeyr 

Change in docker-playground[master]: jenkins-common.sh: add docker_images_require()

[osmith]

Hello Neels Hofmeyr,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11365

to look at the new patch set (#4).

Change subject: jenkins-common.sh: add docker_images_require()
..

jenkins-common.sh: add docker_images_require()

This new function can be used on top of each *-test/jenkins.sh to
automatically build the required Docker images before starting a
testsuite.

The top-level Makefile should also be able to build all Docker images
on which a job depends. But in that Makefile the list of dependencies
can not be specified dynamically, as it will be necessary for OS#3268:
ttcn3-mgw-test may depend on osmo-mgw-latest or on osmo-mgw-master.

This will be used by Idbb708ab16cb71bab5069127945b63388222369e.

Related: OS#3268
Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1
---
M jenkins-common.sh
1 file changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/65/11365/4
--
To view, visit https://gerrit.osmocom.org/11365
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in docker-playground[master]: jenkins.sh: IMAGE_SUFFIX, docker_images_require()

[osmith]

Hello Neels Hofmeyr, Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11366

to look at the new patch set (#5).

Change subject: jenkins.sh: IMAGE_SUFFIX, docker_images_require()
..

jenkins.sh: IMAGE_SUFFIX, docker_images_require()

Default value "master" of the IMAGE_SUFFIX environment variable can be
changed to "latest" to test the latest stable builds instead of the
nightly ones. Use docker_images_require() to make sure that the required
images are existing and up-to-date before running the tests.

Related: OS#3268
Change-Id: Idbb708ab16cb71bab5069127945b63388222369e
---
M m3ua-test/jenkins.sh
M sua-test/jenkins.sh
M ttcn3-bsc-test/jenkins-sccplite.sh
M ttcn3-bsc-test/jenkins.sh
M ttcn3-bts-test/jenkins.sh
M ttcn3-ggsn-test/jenkins.sh
M ttcn3-hlr-test/jenkins.sh
M ttcn3-mgw-test/jenkins.sh
M ttcn3-msc-test/jenkins.sh
M ttcn3-sgsn-test/jenkins.sh
M ttcn3-sip-test/jenkins.sh
11 files changed, 97 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/66/11366/5
--
To view, visit https://gerrit.osmocom.org/11366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idbb708ab16cb71bab5069127945b63388222369e
Gerrit-Change-Number: 11366
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-ci[master]: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

[osmith]

Hello Neels Hofmeyr,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11370

to look at the new patch set (#3).

Change subject: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs
..

jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

New JJB config, that is able to generate all jobs in the TTCN3 tab at
Jenkins: 

The new *-latest jobs test against the latest stable releases. Existing
jobs are not overwritten (this is commented out).
ttcn3-bsc-test-sccplite-latest is disabled for now, because it hangs
forever.

Related: OS#3268
Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
---
A jobs/ttcn3-testsuites.yml
1 file changed, 106 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/70/11370/3
--
To view, visit https://gerrit.osmocom.org/11370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
Gerrit-Change-Number: 11370
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-ci[master]: jobs: testsuite.yml for all ttcn3/nplab jobs

[osmith]

Hello Neels Hofmeyr,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11370

to look at the new patch set (#2).

Change subject: jobs: testsuite.yml for all ttcn3/nplab jobs
..

jobs: testsuite.yml for all ttcn3/nplab jobs

New JJB config, that is able to generate all jobs in the TTCN3 tab at
Jenkins: 

The new *-latest jobs test against the latest stable releases. Existing
jobs are not overwritten (this is commented out).
ttcn3-bsc-test-sccplite-latest is disabled for now, because it hangs
forever.

Related: OS#3268
Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
---
A jobs/ttcn3-testsuites.yml
1 file changed, 106 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/70/11370/2
--
To view, visit https://gerrit.osmocom.org/11370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
Gerrit-Change-Number: 11370
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11368 )

Change subject: rename m3ua-test, sua-test to nplab-*-test
..


Patch Set 6:

I have realized that we also need to update the reference to the image names 
inside jenkins.sh when renaming the folders. This is done with the current 
patchset.


Neels wrote:
>> NOTE: we need to modify the existing jobs to use the renamed folders after 
>> this is merged.
>
> (If that is done by a yml file patch you have submitted, then indicate its 
> change-id in the commit log)

Done.


--
To view, visit https://gerrit.osmocom.org/11368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
Gerrit-Change-Number: 11368
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Mon, 22 Oct 2018 14:11:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

[osmith]

Hello Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11368

to look at the new patch set (#6).

Change subject: rename m3ua-test, sua-test to nplab-*-test
..

rename m3ua-test, sua-test to nplab-*-test

Allows writing a generic Jenkins Job Builder config by renaming the
container folders to match the job names. This needs changes in the
Jenkins jobs, as done in Ie433925ee81a61c5788b4a6f2bc5b89c2689d251.

Related: OS#3268
Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
---
R nplab-m3ua-test/.release
R nplab-m3ua-test/Dockerfile
R nplab-m3ua-test/Makefile
R nplab-m3ua-test/all-sgp-tests.txt
R nplab-m3ua-test/dotguile
R nplab-m3ua-test/jenkins.sh
R nplab-m3ua-test/m3ua-param-testtool.scm
R nplab-m3ua-test/osmo-stp.cfg
R nplab-sua-test/.release
R nplab-sua-test/Dockerfile
R nplab-sua-test/Makefile
R nplab-sua-test/dotguile
R nplab-sua-test/jenkins.sh
R nplab-sua-test/osmo-stp.cfg
R nplab-sua-test/some-sua-sgp-tests.txt
R nplab-sua-test/sua-param-testtool-sgp.scm
16 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/68/11368/6
--
To view, visit https://gerrit.osmocom.org/11368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
Gerrit-Change-Number: 11368
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith 
Gerrit-CC: Neels Hofmeyr 

Change in docker-playground[master]: Remove top-level Makefile

[osmith]

Hello Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11369

to look at the new patch set (#6).

Change subject: Remove top-level Makefile
..

Remove top-level Makefile

Obsoleted by docker_images_require(). The top-level Makefile had the
following drawbacks:
* it was not maintained: many targets were missing, and some of the
  existing ones did not build anymore
* make targets have the same names as the folders, so if they are not
  listed in the Makefile, it will assume that the target has been built
  already (prone to making mistakes)

Related: OS#3268
Change-Id: Id18a9a7a70f85127e6f6c9447d71764018bdb4ff
---
D Makefile
1 file changed, 0 insertions(+), 82 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/69/11369/6
--
To view, visit https://gerrit.osmocom.org/11369
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id18a9a7a70f85127e6f6c9447d71764018bdb4ff
Gerrit-Change-Number: 11369
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith 
Gerrit-CC: Neels Hofmeyr 

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

[osmith]

Hello Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11368

to look at the new patch set (#5).

Change subject: rename m3ua-test, sua-test to nplab-*-test
..

rename m3ua-test, sua-test to nplab-*-test

Allows writing a generic Jenkins Job Builder config.

Related: OS#3268
Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
---
R nplab-m3ua-test/.release
R nplab-m3ua-test/Dockerfile
R nplab-m3ua-test/Makefile
R nplab-m3ua-test/all-sgp-tests.txt
R nplab-m3ua-test/dotguile
R nplab-m3ua-test/jenkins.sh
R nplab-m3ua-test/m3ua-param-testtool.scm
R nplab-m3ua-test/osmo-stp.cfg
R nplab-sua-test/.release
R nplab-sua-test/Dockerfile
R nplab-sua-test/Makefile
R nplab-sua-test/dotguile
R nplab-sua-test/jenkins.sh
R nplab-sua-test/osmo-stp.cfg
R nplab-sua-test/some-sua-sgp-tests.txt
R nplab-sua-test/sua-param-testtool-sgp.scm
16 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/68/11368/5
--
To view, visit https://gerrit.osmocom.org/11368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
Gerrit-Change-Number: 11368
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith 
Gerrit-CC: Neels Hofmeyr 

Change in osmo-ci[master]: jobs: testsuite.yml for all ttcn3/nplab jobs

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11370 )

Change subject: jobs: testsuite.yml for all ttcn3/nplab jobs
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml
File jobs/testsuite.yml:

https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml@26
PS1, Line 26:   # nightly (overwrites the existing, manually created jobs!)
> ideally this would migrate the manual jobs to being created by this file 
> instead, which we want anyw […]
I've realized that in order to do that, I'll need to rewrite the file a bit - 
right now it can only set properties like "disabled" for both latest and master 
at once. So if we rolled this out for the master jobs too, then 
ttcn3-bsc-test-sccplite would be disabled because tcn3-bsc-test-sccplite-latest 
needs to be disabled right now. (Also we are missing the trigger timers from 
the current jobs, they have specific times instead of "midnight".)

After reading a lot of JJB documentation, the easiest way seems to be to 
duplicate all testsuites in the "testsuite-name" variable above instead of 
using the "job-suffix" variable here. That's what I'm working on now.



-- 
To view, visit https://gerrit.osmocom.org/11370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
Gerrit-Change-Number: 11370
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Mon, 22 Oct 2018 12:55:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmocom-bb[master]: firmware: set corret shebang in solve_envs.py python2 script

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11424 )

Change subject: firmware: set corret shebang in solve_envs.py python2 script
..

firmware: set corret shebang in solve_envs.py python2 script

Change-Id: I64582568f7390b7f4e3253508209a59eb78ee4dd
---
M src/target/firmware/solve_envs.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/target/firmware/solve_envs.py 
b/src/target/firmware/solve_envs.py
index d6414d6..0e5f5e8 100755
--- a/src/target/firmware/solve_envs.py
+++ b/src/target/firmware/solve_envs.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2

 import sys


--
To view, visit https://gerrit.osmocom.org/11424
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I64582568f7390b7f4e3253508209a59eb78ee4dd
Gerrit-Change-Number: 11424
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: Convert lchan CCCH_LCHAN to chan_nr BCCH and viceversa

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11427 )

Change subject: Convert lchan CCCH_LCHAN to chan_nr BCCH and viceversa
..

Convert lchan CCCH_LCHAN to chan_nr BCCH and viceversa

Before this patch it was being coded as SDCCH4 TS0 SS 0, and as a
result the state LCHAN_REL_ACT_OML applied in opstart_compl in abused
SDCCH4 TS0 SS 4 was not being checked when deciding whether to send a
Chan Act ACK in rsl_tx_chan_act_acknack.

Fixes: OS#3513
Change-Id: I1641960c9ffbb3ed0de74ab5b53e24e5b4ff3397
---
M include/osmo-bts/l1sap.h
M src/common/gsm_data_shared.c
2 files changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmo-bts/l1sap.h b/include/osmo-bts/l1sap.h
index e2c92fa..3cf0ea5 100644
--- a/include/osmo-bts/l1sap.h
+++ b/include/osmo-bts/l1sap.h
@@ -12,6 +12,7 @@
 #define L1SAP_CHAN2SS_TCHH(chan_nr) ((chan_nr >> 3) & 1)
 #define L1SAP_CHAN2SS_SDCCH4(chan_nr) ((chan_nr >> 3) & 3)
 #define L1SAP_CHAN2SS_SDCCH8(chan_nr) ((chan_nr >> 3) & 7)
+#define L1SAP_CHAN2SS_BCCH(chan_nr) (CCCH_LCHAN)

 /* logical channel from chan_nr + link_id */
 #define L1SAP_IS_LINK_SACCH(link_id) ((link_id & 0xC0) == LID_SACCH)
@@ -48,6 +49,8 @@
 /* subslot from any chan_nr */
 static inline uint8_t l1sap_chan2ss(uint8_t chan_nr)
 {
+   if (L1SAP_IS_CHAN_BCCH(chan_nr))
+return L1SAP_CHAN2SS_BCCH(chan_nr);
if (L1SAP_IS_CHAN_SDCCH8(chan_nr))
return L1SAP_CHAN2SS_SDCCH8(chan_nr);
if (L1SAP_IS_CHAN_SDCCH4(chan_nr))
diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c
index 8c3229c..588d0fd 100644
--- a/src/common/gsm_data_shared.c
+++ b/src/common/gsm_data_shared.c
@@ -622,11 +622,12 @@
 * See osmo-bts-xxx/oml.c:opstart_compl().
 */
if (lchan_nr == CCCH_LCHAN)
-   lchan_nr = 0;
-   else
+   cbits = 0x10; /* BCCH */
+   else {
OSMO_ASSERT(lchan_nr < 4);
-   cbits = 0x04;
-   cbits += lchan_nr;
+   cbits = 0x04;
+   cbits += lchan_nr;
+   }
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:

--
To view, visit https://gerrit.osmocom.org/11427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1641960c9ffbb3ed0de74ab5b53e24e5b4ff3397
Gerrit-Change-Number: 11427
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11425 )

Change subject: gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11425
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1dee716991e6faa406f02c029e998af5780162a
Gerrit-Change-Number: 11425
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Mon, 22 Oct 2018 12:31:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11425 )

Change subject: gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN
..

gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN

Previous implementation made no sense, since chan_nr is never read
before being set below from lchan_nr.

Furthemore, if lcahn_nr=CCH_LCHAN=4, then:
cbits = 0x4 + lchan_nr = 0x8 = b1000 which then becomes SDCCH8 according
to GSM 08.58 9.3.1, so it's totally wrong:
SDCCH/8 + ACCH 0 1 T T T

Change-Id: Id1dee716991e6faa406f02c029e998af5780162a
---
M src/common/gsm_data_shared.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c
index 2a1f9c8..8c3229c 100644
--- a/src/common/gsm_data_shared.c
+++ b/src/common/gsm_data_shared.c
@@ -622,7 +622,7 @@
 * See osmo-bts-xxx/oml.c:opstart_compl().
 */
if (lchan_nr == CCCH_LCHAN)
-   chan_nr = 0;
+   lchan_nr = 0;
else
OSMO_ASSERT(lchan_nr < 4);
cbits = 0x04;

--
To view, visit https://gerrit.osmocom.org/11425
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1dee716991e6faa406f02c029e998af5780162a
Gerrit-Change-Number: 11425
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: Convert lchan CCCH_LCHAN to chan_nr BCCH and viceversa

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11427 )

Change subject: Convert lchan CCCH_LCHAN to chan_nr BCCH and viceversa
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1641960c9ffbb3ed0de74ab5b53e24e5b4ff3397
Gerrit-Change-Number: 11427
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Mon, 22 Oct 2018 12:30:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: osmo-*-latest: s/nightly/latest/g in Dockerfile

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11364 )

Change subject: osmo-*-latest: s/nightly/latest/g in Dockerfile
..

osmo-*-latest: s/nightly/latest/g in Dockerfile

Follow up to I6a564206dd81743deb1eb27eca7081bc333d7434 where the
"*-latest" Dockerfiles were introduced. msc, sgsn, sip, stp had
references to "nightly" instead of "latest" in their Dockerfiles.

Related: OS#3268
Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5
---
M osmo-msc-latest/Dockerfile
M osmo-sgsn-latest/Dockerfile
M osmo-sip-latest/Dockerfile
M osmo-stp-latest/Dockerfile
4 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, approved
  osmith: Verified



diff --git a/osmo-msc-latest/Dockerfile b/osmo-msc-latest/Dockerfile
index 02298e7..a8cc3ba 100644
--- a/osmo-msc-latest/Dockerfile
+++ b/osmo-msc-latest/Dockerfile
@@ -2,7 +2,7 @@

 MAINTAINER Harald Welte 

-ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/;
+ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/;

 COPY   Release.key /tmp/Release.key

@@ -12,7 +12,7 @@

 RUNapt-key add /tmp/Release.key && \
rm /tmp/Release.key && \
-   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-nightly.list
+   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-latest.list

 ADD$OSMOCOM_REPO/Release /tmp/Release
 RUNapt-get update && \
diff --git a/osmo-sgsn-latest/Dockerfile b/osmo-sgsn-latest/Dockerfile
index 56b5fda..87dbca2 100644
--- a/osmo-sgsn-latest/Dockerfile
+++ b/osmo-sgsn-latest/Dockerfile
@@ -2,7 +2,7 @@

 MAINTAINER Harald Welte 

-ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/;
+ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/;

 COPY   Release.key /tmp/Release.key

@@ -12,7 +12,7 @@

 RUNapt-key add /tmp/Release.key && \
rm /tmp/Release.key && \
-   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-nightly.list
+   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-latest.list

 ADD$OSMOCOM_REPO/Release /tmp/Release
 RUNapt-get update && \
diff --git a/osmo-sip-latest/Dockerfile b/osmo-sip-latest/Dockerfile
index 9f978d8..a468c9f 100644
--- a/osmo-sip-latest/Dockerfile
+++ b/osmo-sip-latest/Dockerfile
@@ -2,7 +2,7 @@

 MAINTAINER Harald Welte 

-ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/;
+ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/;

 COPY   Release.key /tmp/Release.key

diff --git a/osmo-stp-latest/Dockerfile b/osmo-stp-latest/Dockerfile
index f5920a5..053e2ab 100644
--- a/osmo-stp-latest/Dockerfile
+++ b/osmo-stp-latest/Dockerfile
@@ -2,7 +2,7 @@

 MAINTAINER Harald Welte 

-ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/;
+ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/;

 COPY   Release.key /tmp/Release.key

@@ -12,7 +12,7 @@

 RUNapt-key add /tmp/Release.key && \
rm /tmp/Release.key && \
-   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-nightly.list
+   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-latest.list

 ADD$OSMOCOM_REPO/Release /tmp/Release
 RUNapt-get update && \

--
To view, visit https://gerrit.osmocom.org/11364
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5
Gerrit-Change-Number: 11364
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-bts[master]: Convert lchan CCCH_LCHAN to chan_nr BCCH and viceversa

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11427


Change subject: Convert lchan CCCH_LCHAN to chan_nr BCCH and viceversa
..

Convert lchan CCCH_LCHAN to chan_nr BCCH and viceversa

Before this patch it was being coded as SDCCH4 TS0 SS 0, and as a
result the state LCHAN_REL_ACT_OML applied in opstart_compl in abused
SDCCH4 TS0 SS 4 was not being checked when deciding whether to send a
Chan Act ACK in rsl_tx_chan_act_acknack.

Fixes: OS#3513
Change-Id: I1641960c9ffbb3ed0de74ab5b53e24e5b4ff3397
---
M include/osmo-bts/l1sap.h
M src/common/gsm_data_shared.c
2 files changed, 8 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/11427/1

diff --git a/include/osmo-bts/l1sap.h b/include/osmo-bts/l1sap.h
index e2c92fa..3cf0ea5 100644
--- a/include/osmo-bts/l1sap.h
+++ b/include/osmo-bts/l1sap.h
@@ -12,6 +12,7 @@
 #define L1SAP_CHAN2SS_TCHH(chan_nr) ((chan_nr >> 3) & 1)
 #define L1SAP_CHAN2SS_SDCCH4(chan_nr) ((chan_nr >> 3) & 3)
 #define L1SAP_CHAN2SS_SDCCH8(chan_nr) ((chan_nr >> 3) & 7)
+#define L1SAP_CHAN2SS_BCCH(chan_nr) (CCCH_LCHAN)

 /* logical channel from chan_nr + link_id */
 #define L1SAP_IS_LINK_SACCH(link_id) ((link_id & 0xC0) == LID_SACCH)
@@ -48,6 +49,8 @@
 /* subslot from any chan_nr */
 static inline uint8_t l1sap_chan2ss(uint8_t chan_nr)
 {
+   if (L1SAP_IS_CHAN_BCCH(chan_nr))
+return L1SAP_CHAN2SS_BCCH(chan_nr);
if (L1SAP_IS_CHAN_SDCCH8(chan_nr))
return L1SAP_CHAN2SS_SDCCH8(chan_nr);
if (L1SAP_IS_CHAN_SDCCH4(chan_nr))
diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c
index 8c3229c..588d0fd 100644
--- a/src/common/gsm_data_shared.c
+++ b/src/common/gsm_data_shared.c
@@ -622,11 +622,12 @@
 * See osmo-bts-xxx/oml.c:opstart_compl().
 */
if (lchan_nr == CCCH_LCHAN)
-   lchan_nr = 0;
-   else
+   cbits = 0x10; /* BCCH */
+   else {
OSMO_ASSERT(lchan_nr < 4);
-   cbits = 0x04;
-   cbits += lchan_nr;
+   cbits = 0x04;
+   cbits += lchan_nr;
+   }
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:

--
To view, visit https://gerrit.osmocom.org/11427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1641960c9ffbb3ed0de74ab5b53e24e5b4ff3397
Gerrit-Change-Number: 11427
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-dev[master]: support osmo-sip-connector with kamailio

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11144 )

Change subject: support osmo-sip-connector with kamailio
..


Patch Set 8:

> But even nicer would be to just place both socket and rundir in the same dir 
> where the run.sh sits by default. No need to configure.

Done. Both use ${NET_DIR} now which is introduced here:
https://gerrit.osmocom.org/#/c/osmo-dev/+/11426/


--
To view, visit https://gerrit.osmocom.org/11144
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 8
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-CC: daniel 
Gerrit-Comment-Date: Mon, 22 Oct 2018 11:25:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-dev[master]: support osmo-sip-connector with kamailio

[osmith]

Hello Pau Espin Pedrol, Neels Hofmeyr,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11144

to look at the new patch set (#8).

Change subject: support osmo-sip-connector with kamailio
..

support osmo-sip-connector with kamailio

Kamailio is a SIP server, that is relatively easy to configure, in
contrary to asterisk it only has one config file. The config file
here is based on the example config provided in the wiki:



To enable the osmo-sip-connector, build it, install kamailio and
then set SIPCON_ENABLE=true in your copy of config_2g_3g.

Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2
---
M net/config_2g3g
A net/tmpl_std/kamailio.cfg
A net/tmpl_std/osmo-sip-connector.cfg
M net/tmpl_std/run.sh
4 files changed, 462 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/44/11144/8
--
To view, visit https://gerrit.osmocom.org/11144
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 8
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-CC: daniel 

Change in osmo-dev[master]: fill_config.py: add NET_DIR variable

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11426


Change subject: fill_config.py: add NET_DIR variable
..

fill_config.py: add NET_DIR variable

Allow all config files to use a new NET_DIR variable, which always
points to the network folder with the generated configs. We can use
this to place all temporary files (sockets, pid files, ...) there.

Change-Id: Idbdf478ebb9f0b2fcd860e5eff3c414a0a459561
---
M net/README
M net/fill_config.py
2 files changed, 6 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/26/11426/1

diff --git a/net/README b/net/README
index 352bc56..1d07775 100644
--- a/net/README
+++ b/net/README
@@ -71,7 +71,8 @@

 The fill_config.py script helps to fill the templates with the config values. 
Simply
 invoke fill_config.py with a dir argument (templates dir) and a file argument 
(specific
-config values).
+config values). The dir argument can be used in the templates with ${NET_DIR},
+temporary files (sockets etc.) should be placed inside this folder.

 If one or both are omitted, the script tries to re-use the most recent paths,
 they were stored in local files '.last_config' and '.last_templates'.
diff --git a/net/fill_config.py b/net/fill_config.py
index d0e2e04..c33e6b7 100755
--- a/net/fill_config.py
+++ b/net/fill_config.py
@@ -50,8 +50,9 @@

 local_config_file = os.path.realpath(local_config_file)
 tmpl_dir = os.path.realpath(tmpl_dir)
+net_dir = os.path.realpath(".")

-print('using config file %r\non templates %r' % (local_config_file, tmpl_dir))
+print('using config file %r\non templates %r\nwith NET_DIR %r' % 
(local_config_file, tmpl_dir, net_dir))

 with open(LAST_LOCAL_CONFIG_FILE, 'w') as last_file:
   last_file.write(local_config_file)
@@ -59,7 +60,8 @@
   last_file.write(tmpl_dir)

 # read in variable values from config file
-local_config = {}
+# NET_DIR is the folder where fill_config.py was started
+local_config = {"NET_DIR": net_dir}

 line_nr = 0
 for line in open(local_config_file):

--
To view, visit https://gerrit.osmocom.org/11426
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbdf478ebb9f0b2fcd860e5eff3c414a0a459561
Gerrit-Change-Number: 11426
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Change in osmo-bts[master]: gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11425


Change subject: gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN
..

gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN

Previous implementation made no sense, since chan_nr is never read
before being set below from lchan_nr.

Furthemore, if lcahn_nr=CCH_LCHAN=4, then:
cbits = 0x4 + lchan_nr = 0x8 = b1000 which then becomes SDCCH8 according
to GSM 08.58 9.3.1, so it's totally wrong:
SDCCH/8 + ACCH 0 1 T T T

Change-Id: Id1dee716991e6faa406f02c029e998af5780162a
---
M src/common/gsm_data_shared.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/11425/1

diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c
index 2a1f9c8..8c3229c 100644
--- a/src/common/gsm_data_shared.c
+++ b/src/common/gsm_data_shared.c
@@ -622,7 +622,7 @@
 * See osmo-bts-xxx/oml.c:opstart_compl().
 */
if (lchan_nr == CCCH_LCHAN)
-   chan_nr = 0;
+   lchan_nr = 0;
else
OSMO_ASSERT(lchan_nr < 4);
cbits = 0x04;

--
To view, visit https://gerrit.osmocom.org/11425
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1dee716991e6faa406f02c029e998af5780162a
Gerrit-Change-Number: 11425
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: ttcn3: Allow remote hosts (sysmobts) to access RSL srv inside TTCN3 d...

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11358 )

Change subject: ttcn3: Allow remote hosts (sysmobts) to access RSL srv inside 
TTCN3 docker
..

ttcn3: Allow remote hosts (sysmobts) to access RSL srv inside TTCN3 docker

And extra IP address is required/requested on the docker host because
the BSC handling the OML instance is binding to it's address, so we
cannot ask docker to use that one because it fails binding to it.

Change-Id: I734fba91db535d7b183ddc7f51d324a6cd2eaf6f
---
M ttcn3/default-suites.conf
M ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
M ttcn3/suites/ttcn3_bts_tests/suite.conf
M ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
4 files changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/ttcn3/default-suites.conf b/ttcn3/default-suites.conf
index 80f14e6..cfa46b4 100644
--- a/ttcn3/default-suites.conf
+++ b/ttcn3/default-suites.conf
@@ -1 +1,2 @@
 - ttcn3_bts_tests:trx
+- ttcn3_bts_tests:sysmo
diff --git a/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh 
b/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
index df8dcb2..daac3e0 100755
--- a/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
+++ b/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
@@ -3,8 +3,9 @@

 RUNDIR="$1"
 JUNIT_TTCN3_DST_FILE="$2"
-L2_SOCKET_PATH="$3"
-PCU_SOCKET_PATH="$4"
+BSC_RSL_ADDR="$3"
+L2_SOCKET_PATH="$4"
+PCU_SOCKET_PATH="$5"

 # Absolute path to this script
 SCRIPT=$(readlink -f "$0")
@@ -27,7 +28,7 @@
 network_create() {
NET=$1
echo Creating network $NET_NAME
-   docker network create --internal --subnet $NET $NET_NAME
+   docker network create --subnet $NET $NET_NAME
 }

 network_remove() {
@@ -70,6 +71,7 @@
 fi
 docker run --rm \
--network $NET_NAME --ip 172.18.9.10 \
+   -p ${BSC_RSL_ADDR}:3003:3003 \
-e "TTCN3_PCAP_PATH=/data" \
--mount 
type=bind,source=$VOL_BASE_DIR/bts-tester,destination=/data \
--mount type=bind,source="$(dirname 
"$L2_SOCKET_PATH")",destination=/data/unix_l2 \
diff --git a/ttcn3/suites/ttcn3_bts_tests/suite.conf 
b/ttcn3/suites/ttcn3_bts_tests/suite.conf
index 1eb0a02..2bb0cac 100644
--- a/ttcn3/suites/ttcn3_bts_tests/suite.conf
+++ b/ttcn3/suites/ttcn3_bts_tests/suite.conf
@@ -1,6 +1,6 @@
 resources:
   ip_address:
-  - times: 7 # msc, bsc, hlr, stp, mgw, sgsn, ggsn
+  - times: 8 # msc, bsc, hlr, stp, mgw, sgsn, ggsn
   bts:
   - times: 1
   osmocon_phone:
diff --git a/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py 
b/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
index f36b023..2684bf7 100755
--- a/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
+++ b/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
@@ -30,7 +30,8 @@
 msc_dummy.start()
 mgw_dummy.start()

-bsc.set_rsl_ip('172.18.9.10')
+nat_rsl_ip = suite.ip_address().get('addr')
+bsc.set_rsl_ip(nat_rsl_ip)
 bsc.bts_add(bts)
 sgsn_dummy.bts_add(bts)

@@ -52,7 +53,7 @@
 else: # PCU unix socket not available locally
 pcu_available = False
 pcu_sk = ''
-docker_cmd = (script_file, str(script_run_dir), junit_ttcn3_dst_file, 
osmocon.l2_socket_path(), pcu_sk)
+docker_cmd = (script_file, str(script_run_dir), junit_ttcn3_dst_file, 
nat_rsl_ip, osmocon.l2_socket_path(), pcu_sk)

 print('Creating template')
 mytemplate = Template(filename=bts_tmpl_file)

--
To view, visit https://gerrit.osmocom.org/11358
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I734fba91db535d7b183ddc7f51d324a6cd2eaf6f
Gerrit-Change-Number: 11358
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: ttcn3: Support running tests without PCU socket avail

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11322 )

Change subject: ttcn3: Support running tests without PCU socket avail
..

ttcn3: Support running tests without PCU socket avail

Change-Id: I902af460b798ffdba09d77d457bac672db606368
---
M src/osmo_gsm_tester/bts.py
A ttcn3/scenarios/sysmo.conf
M ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl
M ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
M ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
5 files changed, 23 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/bts.py b/src/osmo_gsm_tester/bts.py
index 041b2bc..f05a1ba 100644
--- a/src/osmo_gsm_tester/bts.py
+++ b/src/osmo_gsm_tester/bts.py
@@ -157,6 +157,10 @@
 'Get the Pcu object associated with the BTS'
 pass

+def bts_type(self):
+'Get the type of BTS'
+return self.conf.get('type')
+
 def set_bsc(self, bsc):
 self.bsc = bsc

diff --git a/ttcn3/scenarios/sysmo.conf b/ttcn3/scenarios/sysmo.conf
new file mode 12
index 000..5374081
--- /dev/null
+++ b/ttcn3/scenarios/sysmo.conf
@@ -0,0 +1 @@
+../../example/scenarios/sysmo.conf
\ No newline at end of file
diff --git a/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl 
b/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl
index 7379528..03d2721 100644
--- a/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl
+++ b/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl
@@ -10,7 +10,11 @@
 [MODULE_PARAMETERS]
 BTS_Tests.mp_rsl_ip := "172.18.9.10"
 BTS_Tests.mp_bb_trxc_ip := "127.0.0.1"
+%if pcu_available:
 BTS_Tests.mp_pcu_socket := "/data/unix_pcu/pcu_bts"
+%else:
+BTS_Tests.mp_pcu_socket := ""
+%endif
 BTS_Tests.mp_bb_trxc_port := -1
 L1CTL_PortType.m_l1ctl_sock_path := "/data/unix_l2/osmocom_l2"
 BTS_Tests.mp_ctrl_ip   := "${btsvty_ctrl_hostname}"
diff --git a/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh 
b/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
index 64987b3..df8dcb2 100755
--- a/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
+++ b/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
@@ -63,12 +63,17 @@

 echo Starting container with BTS testsuite
 docker kill ${DOCKER_NAME}
+if [ "x$PCU_SOCKET_PATH" != "x" ]; then
+   MOUNT_PCU_SOCKET_OPT="--mount type=bind,source=$(dirname 
"$PCU_SOCKET_PATH"),destination=/data/unix_pcu"
+else
+   MOUNT_PCU_SOCKET_OPT=""
+fi
 docker run --rm \
--network $NET_NAME --ip 172.18.9.10 \
-e "TTCN3_PCAP_PATH=/data" \
--mount 
type=bind,source=$VOL_BASE_DIR/bts-tester,destination=/data \
--mount type=bind,source="$(dirname 
"$L2_SOCKET_PATH")",destination=/data/unix_l2 \
-   --mount type=bind,source="$(dirname 
"$PCU_SOCKET_PATH")",destination=/data/unix_pcu \
+   $MOUNT_PCU_SOCKET_OPT \
--name ${DOCKER_NAME} \
$REPO_USER/${SUITE_NAME} &
 child_ps=$!
diff --git a/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py 
b/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
index b3ca946..f36b023 100755
--- a/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
+++ b/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
@@ -46,11 +46,17 @@
 script_run_dir = test.get_run_dir().new_dir('ttcn3')
 bts_cfg_file = os.path.join(str(script_run_dir), 'BTS_Tests.cfg')
 junit_ttcn3_dst_file = os.path.join(str(suite.trial.get_run_dir()), 'trial-') 
+ suite.name() + '.xml'
-docker_cmd = (script_file, str(script_run_dir), junit_ttcn3_dst_file, 
osmocon.l2_socket_path(), bts.pcu_socket_path())
+if bts.bts_type() == 'osmo-bts-trx':
+pcu_available = True
+pcu_sk = bts.pcu_socket_path()
+else: # PCU unix socket not available locally
+pcu_available = False
+pcu_sk = ''
+docker_cmd = (script_file, str(script_run_dir), junit_ttcn3_dst_file, 
osmocon.l2_socket_path(), pcu_sk)

 print('Creating template')
 mytemplate = Template(filename=bts_tmpl_file)
-r = mytemplate.render(btsvty_ctrl_hostname=bts.remote_addr())
+r = mytemplate.render(btsvty_ctrl_hostname=bts.remote_addr(), 
pcu_available=pcu_available)
 with open(bts_cfg_file, 'w') as f:
 f.write(r)


--
To view, visit https://gerrit.osmocom.org/11322
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I902af460b798ffdba09d77d457bac672db606368
Gerrit-Change-Number: 11322
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: ttcn3: Support running tests without PCU socket avail

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11322 )

Change subject: ttcn3: Support running tests without PCU socket avail
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11322
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I902af460b798ffdba09d77d457bac672db606368
Gerrit-Change-Number: 11322
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 22 Oct 2018 09:01:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ttcn3: Allow remote hosts (sysmobts) to access RSL srv inside TTCN3 d...

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11358 )

Change subject: ttcn3: Allow remote hosts (sysmobts) to access RSL srv inside 
TTCN3 docker
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11358
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I734fba91db535d7b183ddc7f51d324a6cd2eaf6f
Gerrit-Change-Number: 11358
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 22 Oct 2018 09:01:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: firmware: set corret shebang in solve_envs.py python2 script

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11424


Change subject: firmware: set corret shebang in solve_envs.py python2 script
..

firmware: set corret shebang in solve_envs.py python2 script

Change-Id: I64582568f7390b7f4e3253508209a59eb78ee4dd
---
M src/target/firmware/solve_envs.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/24/11424/1

diff --git a/src/target/firmware/solve_envs.py 
b/src/target/firmware/solve_envs.py
index d6414d6..0e5f5e8 100755
--- a/src/target/firmware/solve_envs.py
+++ b/src/target/firmware/solve_envs.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2

 import sys


--
To view, visit https://gerrit.osmocom.org/11424
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64582568f7390b7f4e3253508209a59eb78ee4dd
Gerrit-Change-Number: 11424
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11423 )

Change subject: VTY: add extended (11-bit) RACH detection toggle
..


Patch Set 1:

* did you actually do some benchmarking to see if my suspicion about 
performance impact was correct?
* it would be great if we could somehow do this automatically without having 
yet another config option at OsmoTRX.  Maybe some addition to the TRXCTRL 
protocol?  A separate verb, or something that can be stated during activation 
of the timeslot?

btw: As far as I know, the 11bit RACH (and hence TS1/TS2) is ever only used on 
RACH.  So when RACH Detection is enabled on TCH during handover, we never need 
TS1/TS2 and hence can optimize that case.


--
To view, visit https://gerrit.osmocom.org/11423
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aee998d83b06692d76a83f79748f9129a2547e8
Gerrit-Change-Number: 11423
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 22 Oct 2018 06:50:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-trx[master]: sigProcLib: add a CorrType for extended (11-bit) RACH

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11422 )

Change subject: sigProcLib: add a CorrType for extended (11-bit) RACH
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11422
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f20524350bb8c380d7e10360758eddae8b03e9
Gerrit-Change-Number: 11422
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Mon, 22 Oct 2018 06:48:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: sigProcLib: introduce both TS1 and TS2 RACH synch. sequences

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11390 )

Change subject: sigProcLib: introduce both TS1 and TS2 RACH synch. sequences
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11390
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I838c21db29c54f1924dd478c2b34b46b70aab2cd
Gerrit-Change-Number: 11390
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Tom Tsou 
Gerrit-Comment-Date: Mon, 22 Oct 2018 06:47:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes