date:20190206

Change in libusrp[master]: usrp2: firmware: ignore .lk build artifacts

2019-02-06 Thread Alexander Huemer

Alexander Huemer has uploaded this change for review. ( 
https://gerrit.osmocom.org/12849


Change subject: usrp2: firmware: ignore .lk build artifacts
..

usrp2: firmware: ignore .lk build artifacts

Change-Id: I79cbb834f02dc3f804e5a1476724245407f0eade
---
M firmware/src/usrp2/.gitignore
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/49/12849/1

diff --git a/firmware/src/usrp2/.gitignore b/firmware/src/usrp2/.gitignore
index 54a9e94..d1557f9 100644
--- a/firmware/src/usrp2/.gitignore
+++ b/firmware/src/usrp2/.gitignore
@@ -6,6 +6,7 @@
 /*.rel
 /*.rst
 /*.sym
+/*.lk
 /blink_leds.asm
 /usrp_common.asm
 /command_loop.asm

--
To view, visit https://gerrit.osmocom.org/12849
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79cbb834f02dc3f804e5a1476724245407f0eade
Gerrit-Change-Number: 12849
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Huemer

Change in libusrp[master]: edit-gpif: Fix build for distros with python3 as default

2019-02-06 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12848 )

Change subject: edit-gpif: Fix build for distros with python3 as default
..

edit-gpif: Fix build for distros with python3 as default

Fix the script so it is python2 and python3 compatible, then let the
distro decide which python version to use.

Change-Id: If805c8167e2cf57ce3d6143dddfd4685ad729142
---
M firmware/src/common/Makefile.am
M firmware/src/common/edit-gpif
M firmware/src/usrp2/Makefile.am
M firmware/src/usrp2/edit-gpif
4 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/src/common/Makefile.am b/firmware/src/common/Makefile.am
index 9523232..a98671e 100644
--- a/firmware/src/common/Makefile.am
+++ b/firmware/src/common/Makefile.am
@@ -39,7 +39,7 @@
 all: usrp_gpif.c

 usrp_gpif.c usrp_gpif_inline.h : gpif.c
-   srcdir=$(srcdir) $(PYTHON) $(srcdir)/edit-gpif $(srcdir)/gpif.c 
usrp_gpif.c usrp_gpif_inline.h
+   srcdir=$(srcdir) $(srcdir)/edit-gpif $(srcdir)/gpif.c usrp_gpif.c 
usrp_gpif_inline.h

 CLEANFILES = \
*.ihx *.lnk *.lst *.map *.mem *.rel *.rst *.sym *.asm *.lib \
diff --git a/firmware/src/common/edit-gpif b/firmware/src/common/edit-gpif
index 5367b75..87e16eb 100755
--- a/firmware/src/common/edit-gpif
+++ b/firmware/src/common/edit-gpif
@@ -27,7 +27,6 @@
 # uses.

 import re
-import string
 import sys

 def check_flow_state (line, flow_state_dict):
@@ -93,7 +92,7 @@

 while 1:
 line = input.readline ()
-line = string.replace (line, '\r','')
+line = line.replace ('\r','')
 line = re.sub (r' *$', r'', line)

 check_flow_state (line, flow_state_dict)
diff --git a/firmware/src/usrp2/Makefile.am b/firmware/src/usrp2/Makefile.am
index a32e20c..6d44320 100644
--- a/firmware/src/usrp2/Makefile.am
+++ b/firmware/src/usrp2/Makefile.am
@@ -159,7 +159,7 @@
 all: usrp_gpif.c

 usrp_gpif.c usrp_gpif_inline.h : gpif.c
-   srcdir=$(srcdir) $(PYTHON) $(srcdir)/edit-gpif $(srcdir)/gpif.c 
usrp_gpif.c usrp_gpif_inline.h
+   srcdir=$(srcdir) $(srcdir)/edit-gpif $(srcdir)/gpif.c usrp_gpif.c 
usrp_gpif_inline.h


 # dependencies
diff --git a/firmware/src/usrp2/edit-gpif b/firmware/src/usrp2/edit-gpif
index 5367b75..87e16eb 100755
--- a/firmware/src/usrp2/edit-gpif
+++ b/firmware/src/usrp2/edit-gpif
@@ -27,7 +27,6 @@
 # uses.

 import re
-import string
 import sys

 def check_flow_state (line, flow_state_dict):
@@ -93,7 +92,7 @@

 while 1:
 line = input.readline ()
-line = string.replace (line, '\r','')
+line = line.replace ('\r','')
 line = re.sub (r' *$', r'', line)

 check_flow_state (line, flow_state_dict)

--
To view, visit https://gerrit.osmocom.org/12848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If805c8167e2cf57ce3d6143dddfd4685ad729142
Gerrit-Change-Number: 12848
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Jenkins build is back to normal : master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #864

2019-02-06 Thread jenkins

See

Change in libusrp[master]: build_eeprom.py: Fix build for distros with python3 as default

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12847 )

Change subject: build_eeprom.py: Fix build for distros with python3 as default
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12847
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie695c26f1b2a4f84bdc2b67938fe37a4c50681dd
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 06 Feb 2019 18:08:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libusrp[master]: build_eeprom.py: Fix build for distros with python3 as default

2019-02-06 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12847 )

Change subject: build_eeprom.py: Fix build for distros with python3 as default
..

build_eeprom.py: Fix build for distros with python3 as default

The script contains python2-only syntax, so it can only be run with
python2. Make sure to explicitly specify it needs to be run with python2
in order to run it fine on distros where python points to python3.

Change-Id: Ie695c26f1b2a4f84bdc2b67938fe37a4c50681dd
---
M firmware/src/common/build_eeprom.py
M firmware/src/usrp2/Makefile.am
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/firmware/src/common/build_eeprom.py 
b/firmware/src/common/build_eeprom.py
index 00c2e34..6092d61 100755
--- a/firmware/src/common/build_eeprom.py
+++ b/firmware/src/common/build_eeprom.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2
 #
 # Copyright 2004,2006 Free Software Foundation, Inc.
 #
diff --git a/firmware/src/usrp2/Makefile.am b/firmware/src/usrp2/Makefile.am
index 24ff9b1..a32e20c 100644
--- a/firmware/src/usrp2/Makefile.am
+++ b/firmware/src/usrp2/Makefile.am
@@ -108,11 +108,11 @@
$(XCC) $(LINKOPTS) -o $@ $(EEPROM_BOOT_OBJS)

 burn-usrp2-eeprom: eeprom_boot.ihx
-   $(PYTHON) $(srcdir)/../common/build_eeprom.py -p$(prefix) -r2 
eeprom_boot.ihx > $@
+   $(srcdir)/../common/build_eeprom.py -p$(prefix) -r2 eeprom_boot.ihx > $@
chmod +x $@

 burn-usrp4-eeprom: eeprom_boot.ihx
-   $(PYTHON) $(srcdir)/../common/build_eeprom.py -p$(prefix) -r4 
eeprom_boot.ihx > $@
+   $(srcdir)/../common/build_eeprom.py -p$(prefix) -r4 eeprom_boot.ihx > $@
chmod +x $@



--
To view, visit https://gerrit.osmocom.org/12847
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie695c26f1b2a4f84bdc2b67938fe37a4c50681dd
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy

Change in libusrp[master]: edit-gpif: Fix build for distros with python3 as default

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12848 )

Change subject: edit-gpif: Fix build for distros with python3 as default
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If805c8167e2cf57ce3d6143dddfd4685ad729142
Gerrit-Change-Number: 12848
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 06 Feb 2019 18:08:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libusrp[master]: build_eeprom.py: Fix build for distros with python3 as default

2019-02-06 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12847 )

Change subject: build_eeprom.py: Fix build for distros with python3 as default
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12847
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie695c26f1b2a4f84bdc2b67938fe37a4c50681dd
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 06 Feb 2019 18:07:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: configure.ac: Check for libsctp

2019-02-06 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12846 )

Change subject: configure.ac: Check for libsctp
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12846/1/configure.ac
File configure.ac:

https://gerrit.osmocom.org/#/c/12846/1/configure.ac@50
PS1, Line 50: AC_SEARCH_LIBS([sctp_send], [sctp], [
> I'm just doing what libosmo-netif does, which is our existing sctp user.
Well we should change libosmo-netif to use PKG_CHECK_MODULES too then, but can 
be done later on another patch and by someone else too.



--
To view, visit https://gerrit.osmocom.org/12846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2321e4cb3800929cea56785e5c5bd7480408806
Gerrit-Change-Number: 12846
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 06 Feb 2019 18:00:38 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: debian: depend on libsctp-dev

2019-02-06 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12844 )

Change subject: debian: depend on libsctp-dev
..

debian: depend on libsctp-dev

Since we merged the SGs interface, we include , which
is provided by libsctp-dev.  This means that the Debian package should
depend on this.

It is expected that this will un-break the network:osmocom:nightly
builds.

Change-Id: I092e95ea970763c4008d3c7ff1b7028042574a64
---
M debian/control
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve



diff --git a/debian/control b/debian/control
index e607d10..f6e8ace 100644
--- a/debian/control
+++ b/debian/control
@@ -10,6 +10,7 @@
libtool,
pkg-config,
libdbi-dev,
+   libsctp-dev,
libtalloc-dev,
libsmpp34-dev (>= 1.12),
libasn1c-dev (>= 0.9.28),

--
To view, visit https://gerrit.osmocom.org/12844
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I092e95ea970763c4008d3c7ff1b7028042574a64
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-msc[master]: debian: depend on libsctp-dev

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12844 )

Change subject: debian: depend on libsctp-dev
..


Patch Set 3: Verified+1


--
To view, visit https://gerrit.osmocom.org/12844
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092e95ea970763c4008d3c7ff1b7028042574a64
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 06 Feb 2019 17:56:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: configure.ac: Check for libsctp

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12846 )

Change subject: configure.ac: Check for libsctp
..


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12846/1/configure.ac
File configure.ac:

https://gerrit.osmocom.org/#/c/12846/1/configure.ac@50
PS1, Line 50: AC_SEARCH_LIBS([sctp_send], [sctp], [
> Why not using PKG_CHECK_MODULES?
I'm just doing what libosmo-netif does, which is our existing sctp user.


https://gerrit.osmocom.org/#/c/12846/1/configure.ac@57
PS1, Line 57: AC_MSG_ERROR
> And do we really need to make this dependency mandatory? […]
libosmo-netif has the exect same snippet, so you wouldn't be able to build 
without it.  And since the STP/BSC/MSC communicate over M3UA/SCTP, you wouldn't 
be able to run any working setup anyway (without various hacks).



--
To view, visit https://gerrit.osmocom.org/12846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2321e4cb3800929cea56785e5c5bd7480408806
Gerrit-Change-Number: 12846
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 06 Feb 2019 17:55:50 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: configure.ac: Check for libsctp

2019-02-06 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12846 )

Change subject: configure.ac: Check for libsctp
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12846/1/configure.ac
File configure.ac:

https://gerrit.osmocom.org/#/c/12846/1/configure.ac@57
PS1, Line 57: AC_MSG_ERROR
And do we really need to make this dependency mandatory?
Could we print a warning and disable compilation of SGs interface?



--
To view, visit https://gerrit.osmocom.org/12846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2321e4cb3800929cea56785e5c5bd7480408806
Gerrit-Change-Number: 12846
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 06 Feb 2019 17:52:38 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libusrp[master]: build_eeprom.py: Fix build for distros with python3 as default

2019-02-06 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12847


Change subject: build_eeprom.py: Fix build for distros with python3 as default
..

build_eeprom.py: Fix build for distros with python3 as default

The script contains python2-only syntax, so it can only be run with
python2. Make sure to explicitly specify it needs to be run with python2
in order to run it fine on distros where python points to python3.

Change-Id: Ie695c26f1b2a4f84bdc2b67938fe37a4c50681dd
---
M firmware/src/common/build_eeprom.py
M firmware/src/usrp2/Makefile.am
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/47/12847/1

diff --git a/firmware/src/common/build_eeprom.py 
b/firmware/src/common/build_eeprom.py
index 00c2e34..6092d61 100755
--- a/firmware/src/common/build_eeprom.py
+++ b/firmware/src/common/build_eeprom.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2
 #
 # Copyright 2004,2006 Free Software Foundation, Inc.
 #
diff --git a/firmware/src/usrp2/Makefile.am b/firmware/src/usrp2/Makefile.am
index 24ff9b1..a32e20c 100644
--- a/firmware/src/usrp2/Makefile.am
+++ b/firmware/src/usrp2/Makefile.am
@@ -108,11 +108,11 @@
$(XCC) $(LINKOPTS) -o $@ $(EEPROM_BOOT_OBJS)

 burn-usrp2-eeprom: eeprom_boot.ihx
-   $(PYTHON) $(srcdir)/../common/build_eeprom.py -p$(prefix) -r2 
eeprom_boot.ihx > $@
+   $(srcdir)/../common/build_eeprom.py -p$(prefix) -r2 eeprom_boot.ihx > $@
chmod +x $@

 burn-usrp4-eeprom: eeprom_boot.ihx
-   $(PYTHON) $(srcdir)/../common/build_eeprom.py -p$(prefix) -r4 
eeprom_boot.ihx > $@
+   $(srcdir)/../common/build_eeprom.py -p$(prefix) -r4 eeprom_boot.ihx > $@
chmod +x $@



--
To view, visit https://gerrit.osmocom.org/12847
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie695c26f1b2a4f84bdc2b67938fe37a4c50681dd
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in libusrp[master]: edit-gpif: Fix build for distros with python3 as default

2019-02-06 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12848


Change subject: edit-gpif: Fix build for distros with python3 as default
..

edit-gpif: Fix build for distros with python3 as default

Fix the script so it is python2 and python3 compatible, then let the
distro decide which python version to use.

Change-Id: If805c8167e2cf57ce3d6143dddfd4685ad729142
---
M firmware/src/common/Makefile.am
M firmware/src/common/edit-gpif
M firmware/src/usrp2/Makefile.am
M firmware/src/usrp2/edit-gpif
4 files changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/48/12848/1

diff --git a/firmware/src/common/Makefile.am b/firmware/src/common/Makefile.am
index 9523232..a98671e 100644
--- a/firmware/src/common/Makefile.am
+++ b/firmware/src/common/Makefile.am
@@ -39,7 +39,7 @@
 all: usrp_gpif.c

 usrp_gpif.c usrp_gpif_inline.h : gpif.c
-   srcdir=$(srcdir) $(PYTHON) $(srcdir)/edit-gpif $(srcdir)/gpif.c 
usrp_gpif.c usrp_gpif_inline.h
+   srcdir=$(srcdir) $(srcdir)/edit-gpif $(srcdir)/gpif.c usrp_gpif.c 
usrp_gpif_inline.h

 CLEANFILES = \
*.ihx *.lnk *.lst *.map *.mem *.rel *.rst *.sym *.asm *.lib \
diff --git a/firmware/src/common/edit-gpif b/firmware/src/common/edit-gpif
index 5367b75..87e16eb 100755
--- a/firmware/src/common/edit-gpif
+++ b/firmware/src/common/edit-gpif
@@ -27,7 +27,6 @@
 # uses.

 import re
-import string
 import sys

 def check_flow_state (line, flow_state_dict):
@@ -93,7 +92,7 @@

 while 1:
 line = input.readline ()
-line = string.replace (line, '\r','')
+line = line.replace ('\r','')
 line = re.sub (r' *$', r'', line)

 check_flow_state (line, flow_state_dict)
diff --git a/firmware/src/usrp2/Makefile.am b/firmware/src/usrp2/Makefile.am
index a32e20c..6d44320 100644
--- a/firmware/src/usrp2/Makefile.am
+++ b/firmware/src/usrp2/Makefile.am
@@ -159,7 +159,7 @@
 all: usrp_gpif.c

 usrp_gpif.c usrp_gpif_inline.h : gpif.c
-   srcdir=$(srcdir) $(PYTHON) $(srcdir)/edit-gpif $(srcdir)/gpif.c 
usrp_gpif.c usrp_gpif_inline.h
+   srcdir=$(srcdir) $(srcdir)/edit-gpif $(srcdir)/gpif.c usrp_gpif.c 
usrp_gpif_inline.h


 # dependencies
diff --git a/firmware/src/usrp2/edit-gpif b/firmware/src/usrp2/edit-gpif
index 5367b75..87e16eb 100755
--- a/firmware/src/usrp2/edit-gpif
+++ b/firmware/src/usrp2/edit-gpif
@@ -27,7 +27,6 @@
 # uses.

 import re
-import string
 import sys

 def check_flow_state (line, flow_state_dict):
@@ -93,7 +92,7 @@

 while 1:
 line = input.readline ()
-line = string.replace (line, '\r','')
+line = line.replace ('\r','')
 line = re.sub (r' *$', r'', line)

 check_flow_state (line, flow_state_dict)

--
To view, visit https://gerrit.osmocom.org/12848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If805c8167e2cf57ce3d6143dddfd4685ad729142
Gerrit-Change-Number: 12848
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-msc[master]: configure.ac: Check for libsctp

2019-02-06 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12846 )

Change subject: configure.ac: Check for libsctp
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12846/1/configure.ac
File configure.ac:

https://gerrit.osmocom.org/#/c/12846/1/configure.ac@50
PS1, Line 50: AC_SEARCH_LIBS([sctp_send], [sctp], [
Why not using PKG_CHECK_MODULES?



--
To view, visit https://gerrit.osmocom.org/12846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2321e4cb3800929cea56785e5c5bd7480408806
Gerrit-Change-Number: 12846
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 06 Feb 2019 17:18:46 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: debian: depend on libsctp-dev

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12844 )

Change subject: debian: depend on libsctp-dev
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12844
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092e95ea970763c4008d3c7ff1b7028042574a64
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 06 Feb 2019 16:53:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: configure.ac: Check for libsctp

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12846 )

Change subject: configure.ac: Check for libsctp
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2321e4cb3800929cea56785e5c5bd7480408806
Gerrit-Change-Number: 12846
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 06 Feb 2019 16:53:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: configure.ac: Check for libsctp

2019-02-06 Thread Harald Welte

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12846


Change subject: configure.ac: Check for libsctp
..

configure.ac: Check for libsctp

Since we merged the SGs interface, we include , which
is provided by libsctp.

Change-Id: Id2321e4cb3800929cea56785e5c5bd7480408806
---
M configure.ac
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/46/12846/1

diff --git a/configure.ac b/configure.ac
index 17f4b90..f8787cf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -46,6 +46,17 @@
 PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.5.0)
 PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.0.0)

+old_LIBS=$LIBS
+AC_SEARCH_LIBS([sctp_send], [sctp], [
+   AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support])
+   AC_SUBST(HAVE_LIBSCTP, [1])
+   if test -n "$ac_lib"; then
+   AC_SUBST(LIBSCTP_LIBS, [-l$ac_lib])
+   fi
+   ], [
+   AC_MSG_ERROR([sctp_send not found in searched libs])])
+LIBS=$old_LIBS
+
 AC_ARG_ENABLE(sanitize,
[AS_HELP_STRING(
[--enable-sanitize],

--
To view, visit https://gerrit.osmocom.org/12846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2321e4cb3800929cea56785e5c5bd7480408806
Gerrit-Change-Number: 12846
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte

Change in osmo-msc[master]: debian: depend on libsctp-dev

2019-02-06 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12844 )

Change subject: debian: depend on libsctp-dev
..


Patch Set 1: Code-Review+1

Too bad osmo-msc 0df904dea9106587f40ec379e9cc05ea251beb7e didn't say in the 
commit description that a new dependency (libsctp) was added.

I see in https://packages.debian.org/buster/amd64/libsctp-dev/filelist that 
libsctp has a pkgconfig file, but I see in src/osmo-msc/Makefile.am that we 
directly append "-lsctp". We should use .pc file for that, as well as for 
CFLAGS.


--
To view, visit https://gerrit.osmocom.org/12844
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I092e95ea970763c4008d3c7ff1b7028042574a64
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 06 Feb 2019 16:42:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.04/x86_64

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  122s]  #include 
[  122s]   ^~~~
[  122s] compilation terminated.
[  122s] Makefile:518: recipe for target 'sgs_server.o' failed
[  122s] make[4]: *** [sgs_server.o] Error 1
[  122s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  122s] Makefile:424: recipe for target 'all-recursive' failed
[  122s] make[3]: *** [all-recursive] Error 1
[  122s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  122s] Makefile:464: recipe for target 'all-recursive' failed
[  122s] make[2]: *** [all-recursive] Error 1
[  122s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  122s] Makefile:396: recipe for target 'all' failed
[  122s] make[1]: *** [all] Error 2
[  122s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  122s] dh_auto_build: make -j1 returned exit code 2
[  122s] debian/rules:45: recipe for target 'build' failed
[  122s] make: *** [build] Error 2
[  122s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  122s] 
[  122s] lamb28 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:41:26 UTC 2019.
[  122s] 
[  122s] ### VM INTERACTION START ###
[  125s] [  114.343356] sysrq: SysRq : Power Off
[  125s] [  114.350924] reboot: Power down
[  126s] ### VM INTERACTION END ###
[  126s] 
[  126s] lamb28 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:41:31 UTC 2019.
[  126s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.10/x86_64

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.10/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  149s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized 
-Werror=memset-transposed-args -Werror=null-dereference 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o osmo_msc.o 
osmo_msc.c
[  149s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized 
-Werror=memset-transposed-args -Werror=null-dereference 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
ctrl_commands.o ctrl_commands.c
[  149s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized 
-Werror=memset-transposed-args -Werror=null-dereference 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
sgs_iface.o sgs_iface.c
[  150s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized 
-Werror=memset-transposed-args -Werror=null-dereference 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
sgs_server.o sgs_server.c
[  150s] sgs_server.c:28:10: fatal error: netinet/sctp.h: No such file or 
directory
[  150s]  #include 
[  150s]   ^~~~
[  150s] compilation terminated.
[  150s] make[4]: *** [Makefile:542: sgs_server.o] Error 1
[  150s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  150s] make[3]: *** [Makefile:424: all-recursive] Error 1
[  150s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  150s] make[2]: *** [Makefile:464: all-recursive] Error 1
[  150s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  150s] make[1]: *** [Makefile:396: all] Error 2
[  150s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  150s] dh_auto_build: make -j1 returned exit code 2
[  150s] make: *** [debian/rules:45: build] Error 2
[  150s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  150s] 
[  150s] lamb61 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:38:53 UTC 2019.
[  150s] 
[  150s] ### VM INTERACTION START ###
[  153s] [  141.989992] sysrq: SysRq : Power Off
[  153s] [  141.994844] reboot: Power down
[  153s] ### VM INTERACTION END ###
[  153s] 
[  153s] lamb61 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:38:56 UTC 2019.
[  153s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in libosmo-netif[master]: Deprecate osmo_stream_cli_open2()

2019-02-06 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12845


Change subject: Deprecate osmo_stream_cli_open2()
..

Deprecate osmo_stream_cli_open2()

This supposed to be variant of osmo_stream_cli_open() with explicit
control over reconnection logic but it's plain broken: doxygen docs
contradict the code, actual reconnection logic is affected by timeout
parameter directly which is set in different function.

It seems like we haven't been affected by this so far because we always
use it in auto-reconnection mode which is triggered by due to positive
reconnection timeout value (5 sec) used in the absense of explicitly set
timeout.

Looking at commit history, this function already been source of
confusion in the past. Instead of trying to fix this mess, let's just
deprecate it entirely and properly document use of
osmo_stream_cli_set_reconnect_timeout() to control reconnection logic.

Change-Id: Id988ed0274b363db049f59cbf6a193727c8c3c8a
---
M include/osmocom/netif/stream.h
M tests/stream/stream_test.c
2 files changed, 77 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/45/12845/1

diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h
index 3044511..f64daf9 100644
--- a/include/osmocom/netif/stream.h
+++ b/include/osmocom/netif/stream.h
@@ -71,7 +71,7 @@
 void osmo_stream_cli_destroy(struct osmo_stream_cli *cli);

 int osmo_stream_cli_open(struct osmo_stream_cli *cli);
-int osmo_stream_cli_open2(struct osmo_stream_cli *cli, int reconnect);
+int osmo_stream_cli_open2(struct osmo_stream_cli *cli, int reconnect) 
OSMO_DEPRECATED("Use osmo_stream_cli_set_reconnect_timeout() or 
osmo_stream_cli_reconnect() instead");
 void osmo_stream_cli_close(struct osmo_stream_cli *cli);

 void osmo_stream_cli_send(struct osmo_stream_cli *cli, struct msgb *msg);
diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c
index 7a24e21..35d18b5 100644
--- a/tests/stream/stream_test.c
+++ b/tests/stream/stream_test.c
@@ -127,6 +127,76 @@
return cli;
 }

+/* Without explicit timeout set with osmo_stream_cli_set_reconnect_timeout() 
default value is used.
+static struct osmo_stream_cli *init_client_reconnection_broken1(struct 
osmo_stream_cli *cli, bool autoreconnect)
+{
+   if (osmo_stream_cli_open2(cli, autoreconnect) < 0) {
+   LOGCLI(cli, "unable to open client\n");
+   return NULL;
+   }
+
+   return cli;
+}
+That's why those those functions result in exact the same output despite 
inverse use of autoreconnect parameter.
+static struct osmo_stream_cli *init_client_reconnection_broken2(struct 
osmo_stream_cli *cli, bool autoreconnect)
+{
+   if (osmo_stream_cli_open2(cli, !autoreconnect) < 0) {
+   LOGCLI(cli, "unable to open client\n");
+   return NULL;
+   }
+
+   return cli;
+}
+
+Variant below are also equivalent to each other.
+static struct osmo_stream_cli *init_client_reconnection_broken1(struct 
osmo_stream_cli *cli, bool autoreconnect)
+{
+   osmo_stream_cli_set_reconnect_timeout(cli, (!autoreconnect) ? 2 : -1);
+   if (osmo_stream_cli_open2(cli, autoreconnect) < 0) {
+   LOGCLI(cli, "unable to open client\n");
+   return NULL;
+   }
+
+   return cli;
+}
+
+static struct osmo_stream_cli *init_client_reconnection_broken2(struct 
osmo_stream_cli *cli, bool autoreconnect)
+{
+   osmo_stream_cli_set_reconnect_timeout(cli, (!autoreconnect) ? 2 : -1);
+   if (osmo_stream_cli_open2(cli, !autoreconnect) < 0) {
+   LOGCLI(cli, "unable to open client\n");
+   return NULL;
+   }
+
+   return cli;
+}
+Note: the result differs from normal init_client_reconnection()
+*/
+
+/* Setting reconnection value explicitly as follows is equivalent to normal 
init_client_reconnection()
+static struct osmo_stream_cli *init_client_reconnection_broken1(struct 
osmo_stream_cli *cli, bool autoreconnect)
+{
+   osmo_stream_cli_set_reconnect_timeout(cli, autoreconnect ? 2 : -1);
+   if (osmo_stream_cli_open2(cli, autoreconnect) < 0) {
+   LOGCLI(cli, "unable to open client\n");
+   return NULL;
+   }
+
+   return cli;
+}
+
+static struct osmo_stream_cli *init_client_reconnection_broken2(struct 
osmo_stream_cli *cli, bool autoreconnect)
+{
+   osmo_stream_cli_set_reconnect_timeout(cli, autoreconnect ? 2 : -1);
+   if (osmo_stream_cli_open2(cli, !autoreconnect) < 0) {
+   LOGCLI(cli, "unable to open client\n");
+   return NULL;
+   }
+
+   return cli;
+}
+*/
+
 static struct osmo_stream_cli *make_client(void *ctx, const char *host, 
unsigned port, bool autoreconnect)
 {
struct osmo_stream_cli *cli = osmo_stream_cli_create(ctx);
@@ -142,6 +212,12 @@
osmo_stream_cli_set_connect_cb(cli, connect_cb_cli);

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_17.10/x86_64

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[   88s]  #include 
[   88s]   ^~~~
[   88s] compilation terminated.
[   88s] Makefile:518: recipe for target 'sgs_server.o' failed
[   88s] make[4]: *** [sgs_server.o] Error 1
[   88s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   88s] Makefile:424: recipe for target 'all-recursive' failed
[   88s] make[3]: *** [all-recursive] Error 1
[   88s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   88s] Makefile:464: recipe for target 'all-recursive' failed
[   88s] make[2]: *** [all-recursive] Error 1
[   88s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   88s] Makefile:396: recipe for target 'all' failed
[   88s] make[1]: *** [all] Error 2
[   88s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   88s] dh_auto_build: make -j1 returned exit code 2
[   88s] debian/rules:45: recipe for target 'build' failed
[   88s] make: *** [build] Error 2
[   88s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   88s] 
[   88s] lamb14 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:21:40 UTC 2019.
[   88s] 
[   88s] ### VM INTERACTION START ###
[   91s] [   80.669861] sysrq: SysRq : Power Off
[   91s] [   80.679729] reboot: Power down
[   91s] ### VM INTERACTION END ###
[   91s] 
[   91s] lamb14 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:21:44 UTC 2019.
[   91s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.04/i586

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.04/i586

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  121s]  #include 
[  121s]   ^~~~
[  121s] compilation terminated.
[  121s] Makefile:518: recipe for target 'sgs_server.o' failed
[  121s] make[4]: *** [sgs_server.o] Error 1
[  121s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  121s] Makefile:424: recipe for target 'all-recursive' failed
[  121s] make[3]: *** [all-recursive] Error 1
[  121s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  121s] Makefile:464: recipe for target 'all-recursive' failed
[  121s] make[2]: *** [all-recursive] Error 1
[  121s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  121s] Makefile:396: recipe for target 'all' failed
[  121s] make[1]: *** [all] Error 2
[  121s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  121s] dh_auto_build: make -j1 returned exit code 2
[  121s] debian/rules:45: recipe for target 'build' failed
[  121s] make: *** [build] Error 2
[  121s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  121s] 
[  121s] lamb20 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:18:57 UTC 2019.
[  121s] 
[  121s] ### VM INTERACTION START ###
[  124s] [  112.586570] sysrq: SysRq : Power Off
[  124s] [  112.599477] reboot: Power down
[  124s] ### VM INTERACTION END ###
[  124s] 
[  124s] lamb20 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:19:00 UTC 2019.
[  124s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/x86_64

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  127s]  #include 
[  127s]   ^
[  127s] compilation terminated.
[  127s] Makefile:518: recipe for target 'sgs_server.o' failed
[  127s] make[4]: *** [sgs_server.o] Error 1
[  127s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  127s] Makefile:424: recipe for target 'all-recursive' failed
[  127s] make[3]: *** [all-recursive] Error 1
[  127s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  127s] Makefile:464: recipe for target 'all-recursive' failed
[  127s] make[2]: *** [all-recursive] Error 1
[  127s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  127s] Makefile:396: recipe for target 'all' failed
[  127s] make[1]: *** [all] Error 2
[  127s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  127s] dh_auto_build: make -j1 returned exit code 2
[  127s] debian/rules:45: recipe for target 'build' failed
[  127s] make: *** [build] Error 2
[  127s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  127s] 
[  127s] lamb55 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:10:03 UTC 2019.
[  127s] 
[  127s] ### VM INTERACTION START ###
[  130s] [  116.509709] sysrq: SysRq : Power Off
[  130s] [  116.525293] reboot: Power down
[  130s] ### VM INTERACTION END ###
[  130s] 
[  130s] lamb55 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:10:07 UTC 2019.
[  130s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-msc[master]: debian: depend on libsctp-dev

2019-02-06 Thread Harald Welte

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12844


Change subject: debian: depend on libsctp-dev
..

debian: depend on libsctp-dev

Since we merged the SGs interface, we include , which
is provided by libsctp-dev.  This means that the Debian package should
depend on this.

It is expected that this will un-break the network:osmocom:nightly
builds.

Change-Id: I092e95ea970763c4008d3c7ff1b7028042574a64
---
M debian/control
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/44/12844/1

diff --git a/debian/control b/debian/control
index e607d10..f6e8ace 100644
--- a/debian/control
+++ b/debian/control
@@ -10,6 +10,7 @@
libtool,
pkg-config,
libdbi-dev,
+   libsctp-dev,
libtalloc-dev,
libsmpp34-dev (>= 1.12),
libasn1c-dev (>= 0.9.28),

--
To view, visit https://gerrit.osmocom.org/12844
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I092e95ea970763c4008d3c7ff1b7028042574a64
Gerrit-Change-Number: 12844
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_16.04/x86_64

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[   93s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security 
-Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
sgs_server.o sgs_server.c
[   93s] sgs_server.c:28:26: fatal error: netinet/sctp.h: No such file or 
directory
[   93s] compilation terminated.
[   93s] Makefile:518: recipe for target 'sgs_server.o' failed
[   93s] make[4]: *** [sgs_server.o] Error 1
[   93s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   93s] Makefile:424: recipe for target 'all-recursive' failed
[   93s] make[3]: *** [all-recursive] Error 1
[   93s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   93s] Makefile:464: recipe for target 'all-recursive' failed
[   93s] make[2]: *** [all-recursive] Error 1
[   93s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   93s] Makefile:396: recipe for target 'all' failed
[   93s] make[1]: *** [all] Error 2
[   93s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   93s] dh_auto_build: make -j1 returned exit code 2
[   93s] debian/rules:45: recipe for target 'build' failed
[   93s] make: *** [build] Error 2
[   93s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   93s] 
[   93s] lamb11 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:09:26 UTC 2019.
[   93s] 
[   93s] ### VM INTERACTION START ###
[   96s] [   84.949275] sysrq: SysRq : Power Off
[   96s] [   84.956178] reboot: Power down
[   96s] ### VM INTERACTION END ###
[   96s] 
[   96s] lamb11 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:09:30 UTC 2019.
[   96s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/i586

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/i586

Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[   75s]  #include 
[   75s]   ^
[   75s] compilation terminated.
[   75s] Makefile:518: recipe for target 'sgs_server.o' failed
[   75s] make[4]: *** [sgs_server.o] Error 1
[   75s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   75s] Makefile:424: recipe for target 'all-recursive' failed
[   75s] make[3]: *** [all-recursive] Error 1
[   75s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   75s] Makefile:464: recipe for target 'all-recursive' failed
[   75s] make[2]: *** [all-recursive] Error 1
[   75s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   75s] Makefile:396: recipe for target 'all' failed
[   75s] make[1]: *** [all] Error 2
[   75s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   75s] dh_auto_build: make -j1 returned exit code 2
[   75s] debian/rules:45: recipe for target 'build' failed
[   75s] make: *** [build] Error 2
[   75s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   75s] 
[   75s] sheep84 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:08:00 UTC 2019.
[   75s] 
[   75s] ### VM INTERACTION START ###
[   79s] [   69.851099] sysrq: SysRq : Power Off
[   79s] [   69.856531] reboot: Power down
[   79s] ### VM INTERACTION END ###
[   79s] 
[   79s] sheep84 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:08:04 UTC 2019.
[   79s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_17.10/i586

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_17.10/i586

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  150s]  #include 
[  150s]   ^~~~
[  150s] compilation terminated.
[  150s] Makefile:518: recipe for target 'sgs_server.o' failed
[  150s] make[4]: *** [sgs_server.o] Error 1
[  150s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  150s] Makefile:424: recipe for target 'all-recursive' failed
[  150s] make[3]: *** [all-recursive] Error 1
[  150s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  150s] Makefile:464: recipe for target 'all-recursive' failed
[  150s] make[2]: *** [all-recursive] Error 1
[  150s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  150s] Makefile:396: recipe for target 'all' failed
[  150s] make[1]: *** [all] Error 2
[  150s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  150s] dh_auto_build: make -j1 returned exit code 2
[  150s] debian/rules:45: recipe for target 'build' failed
[  150s] make: *** [build] Error 2
[  150s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  150s] 
[  150s] morla5 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:00:48 UTC 2019.
[  150s] 
[  150s] ### VM INTERACTION START ###
[  153s] [  140.322514] sysrq: SysRq : Power Off
[  153s] [  140.332595] reboot: Power down
[  153s] ### VM INTERACTION END ###
[  153s] 
[  153s] morla5 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
16:00:52 UTC 2019.
[  153s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_16.04/i586

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[   76s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security 
-Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
sgs_server.o sgs_server.c
[   76s] sgs_server.c:28:26: fatal error: netinet/sctp.h: No such file or 
directory
[   76s] compilation terminated.
[   76s] Makefile:518: recipe for target 'sgs_server.o' failed
[   76s] make[4]: *** [sgs_server.o] Error 1
[   76s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   76s] Makefile:424: recipe for target 'all-recursive' failed
[   76s] make[3]: *** [all-recursive] Error 1
[   76s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   76s] Makefile:464: recipe for target 'all-recursive' failed
[   76s] make[2]: *** [all-recursive] Error 1
[   76s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   76s] Makefile:396: recipe for target 'all' failed
[   76s] make[1]: *** [all] Error 2
[   76s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   76s] dh_auto_build: make -j1 returned exit code 2
[   76s] debian/rules:45: recipe for target 'build' failed
[   76s] make: *** [build] Error 2
[   76s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   76s] 
[   76s] sheep83 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
15:55:46 UTC 2019.
[   76s] 
[   76s] ### VM INTERACTION START ###
[   79s] [   72.552424] sysrq: SysRq : Power Off
[   79s] [   72.557106] reboot: Power down
[   79s] ### VM INTERACTION END ###
[   79s] 
[   79s] sheep83 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
15:55:49 UTC 2019.
[   79s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_8.0/x86_64

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[   86s]  #include 
[   86s]   ^
[   86s] compilation terminated.
[   86s] Makefile:506: recipe for target 'sgs_server.o' failed
[   86s] make[4]: *** [sgs_server.o] Error 1
[   86s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   86s] Makefile:412: recipe for target 'all-recursive' failed
[   86s] make[3]: *** [all-recursive] Error 1
[   86s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   86s] Makefile:452: recipe for target 'all-recursive' failed
[   86s] make[2]: *** [all-recursive] Error 1
[   86s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   86s] Makefile:383: recipe for target 'all' failed
[   86s] make[1]: *** [all] Error 2
[   86s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   86s] dh_auto_build: make -j1 returned exit code 2
[   86s] debian/rules:45: recipe for target 'build' failed
[   86s] make: *** [build] Error 2
[   86s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   86s] 
[   86s] lamb13 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
15:53:03 UTC 2019.
[   86s] 
[   86s] ### VM INTERACTION START ###
[   87s] Powering off.
[   87s] [   76.135147] reboot: Power down
[   87s] ### VM INTERACTION END ###
[   87s] 
[   87s] lamb13 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
15:53:04 UTC 2019.
[   87s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_8.0/i586

2019-02-06 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_8.0/i586

Package network:osmocom:nightly/osmo-msc failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[   71s]  #include 
[   71s]   ^
[   71s] compilation terminated.
[   71s] Makefile:506: recipe for target 'sgs_server.o' failed
[   71s] make[4]: *** [sgs_server.o] Error 1
[   71s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   71s] Makefile:412: recipe for target 'all-recursive' failed
[   71s] make[3]: *** [all-recursive] Error 1
[   71s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   71s] Makefile:452: recipe for target 'all-recursive' failed
[   71s] make[2]: *** [all-recursive] Error 1
[   71s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   71s] Makefile:383: recipe for target 'all' failed
[   71s] make[1]: *** [all] Error 2
[   71s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   71s] dh_auto_build: make -j1 returned exit code 2
[   71s] debian/rules:45: recipe for target 'build' failed
[   71s] make: *** [build] Error 2
[   71s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   71s] 
[   71s] sheep84 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
15:37:06 UTC 2019.
[   71s] 
[   71s] ### VM INTERACTION START ###
[   72s] Powering off.
[   72s] [   64.738199] reboot: Power down
[   72s] ### VM INTERACTION END ###
[   72s] 
[   72s] sheep84 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Wed Feb  6 
15:37:07 UTC 2019.
[   72s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #393

2019-02-06 Thread jenkins

See 


--
[...truncated 3.83 KB...]
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking how to run the C preprocessor... gcc -E
checking for a

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #863

2019-02-06 Thread jenkins

See 


--
[...truncated 107.90 KB...]
Searching INPUT for files to process...
Reading and parsing tag files
Parsing files
Building group list...
Building directory list...
Building namespace list...
Building file list...
Building class list...
Associating documentation with classes...
Computing nesting relations for classes...
Building example list...
Searching for enumerations...
Searching for documented typedefs...
Searching for members imported via using declarations...
Searching for included using directives...
Searching for documented variables...
Building interface member list...
Building member list...
Searching for friends...
Searching for documented defines...
Computing class inheritance relations...
Computing class usage relations...
Flushing cached template relations that have become invalid...
Computing class relations...
Add enum values to enums...
Searching for member function documentation...
Creating members for template instances...
Building page list...
Search for main page...
Computing page relations...
Determining the scope of groups...
Sorting lists...
Freeing entry tree
Determining which enums are documented
Computing member relations...
Building full member lists recursively...
Adding members to member groups.
Computing member references...
Inheriting documentation...
Generating disk names...
Adding source references...
Adding xrefitems...
Sorting member lists...
Computing dependencies between directories...
Generating citations page...
Counting data structures...
Resolving user defined references...
Finding anchors and sections in the documentation...
Transferring function references...
Combining using relations...
Adding members to index pages...
Generating style sheet...
Generating search indices...
Generating example documentation...
Generating file sources...
Generating file documentation...
Generating page documentation...
Generating group documentation...
Generating class documentation...
Generating namespace index...
Generating graph info page...
Generating directory documentation...
Generating index page...
Generating page index...
Generating module index...
Generating namespace index...
Generating namespace member index...
Generating annotated compound index...
Generating alphabetical compound index...
Generating hierarchical class index...
Generating graphical class hierarchy...
Generating member index...
Generating file index...
Generating file member index...
Generating example index...
finalizing index lists...
writing tag file...
Running dot...
Running dot for graph 1/1
lookup cache used 0/65536 hits=0 misses=0
finished...
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p 

 /bin/mkdir -p 
'
/usr/bin/install -c -m 644 usrp_guide.html 

 /usr/bin/install -c -m 644 ../README 
'
cp -r html 

make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in firmware
make[2]: Entering directory

Change in osmo-bsc[master]: comments: clarify usage of conn.assignment and .handover scopes

2019-02-06 Thread Neels Hofmeyr

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12842 )

Change subject: comments: clarify usage of conn.assignment and .handover scopes
..

comments: clarify usage of conn.assignment and .handover scopes

Change-Id: I7ef602c3ce086aecbc3ae3ae6d3fd33ad2b9f85c
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 13 insertions(+), 2 deletions(-)



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 867a46c..f6c5129 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -99,6 +99,9 @@
SUBSCR_SCCP_ST_CONNECTED
 };

+/* Information retrieved during an Assignment Request from the MSC. This is 
storage of the Assignment instructions
+ * parsed from the Assignment Request message, to pass on until the gscon and 
assignment FSMs have decided whether an
+ * Assignment is actually going to be carried out. Should remain unchanged 
after initial decoding. */
 struct assignment_request {
bool aoip;

@@ -112,6 +115,9 @@
uint16_t s15_s0;
 };

+/* State of an ongoing Assignment, while the assignment_fsm is still busy. 
This serves as state separation to keep the
+ * currently used lchan and gscon unmodified until the outcome of an 
Assignment is known. If the Assignment fails, this
+ * state is simply discarded, and the gscon carries on with the original lchan 
remaining unchanged. */
 struct assignment_fsm_data {
struct assignment_request req;
bool requires_voice_stream;
@@ -204,12 +210,17 @@
/* back pointers */
struct gsm_network *network;

-   /* the primary / currently active lchan to the BTS/subscriber */
+   /* the primary / currently active lchan to the BTS/subscriber. During 
Assignment and Handover, separate lchans
+* are kept in the .assignment or .handover sub-structs, respectively, 
so that this lchan remains unaffected
+* until Assignment or Handover have actually succeeded. */
struct gsm_lchan *lchan;

+   /* Only valid during an ongoing Assignment; might be overwritten at any 
time by a failed Assignment attempt.
+* Once an Assignment was successful, all relevant state must be copied 
out of this sub-struct. */
struct assignment_fsm_data assignment;

-   /* handover information, if a handover is pending for this conn. */
+   /* handover information, if a handover is pending for this conn. Valid 
only during an ongoing Handover
+* operation. If a Handover was successful, all relevant state must be 
copied out of this sub-struct. */
struct handover ho;

/* buffer/cache for classmark of the ME of the subscriber */

--
To view, visit https://gerrit.osmocom.org/12842
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ef602c3ce086aecbc3ae3ae6d3fd33ad2b9f85c
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: handover_fsm: do not access conn->assignment.req, it may be outdated

2019-02-06 Thread Neels Hofmeyr

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12734 )

Change subject: handover_fsm: do not access conn->assignment.req, it may be 
outdated
..

handover_fsm: do not access conn->assignment.req, it may be outdated

handover_fsm.c accesses conn->assignment.req.s15_s0 to find out the current
lchan's AMR configuration. However, conn->assignment.* values are only valid
during an ongoing assignment.  Those values may be overwritten by any failed
Assignment attempt, at any time, and hence do not reflect the currently
assigned conn->lchan. Those realms must be kept separate.

The assignment.req.s15_s0 get passed to lchan_activate(), so it makes most
sense to store these values in struct gsm_lchan once the lchan activation
succeeded.

Add gsm_lchan.s15_s0, store the s15_s0 received in lchan_activate_info during
lchan_activate().

In handover_fsm.c, use conn->lchan->s15_s0 instead of conn->assignment.*.

Change-Id: Id8018fd9d56421f2ab7be91703018f6d6f21c929
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/lchan_fsm.c
3 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index a5fe1f1..867a46c 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -578,6 +578,8 @@
/* AMR bits */
uint8_t mr_ms_lv[7];
uint8_t mr_bts_lv[7];
+   /* AMR bits were based on these rate bits: */
+   uint16_t s15_s0;

/* Established data link layer services */
uint8_t sapis[8];
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index 35f2e55..578cff3 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -715,7 +715,7 @@
if (gscon_is_aoip(conn)) {
/* Extrapolate speech codec from speech mode */
gsm0808_speech_codec_from_chan_type(, 
ho_perf_params.speech_version_chosen);
-   sc.cfg = conn->assignment.req.s15_s0;
+   sc.cfg = conn->lchan->s15_s0;
memcpy(_perf_params.speech_codec_chosen, , 
sizeof(sc));
ho_perf_params.speech_codec_chosen_present = true;
}
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index f344cf9..70f7622 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -544,6 +544,7 @@
lchan_fail("Can not generate multirate configuration 
IE\n");
return;
}
+   lchan->s15_s0 = info->s15_s0;
}

switch (info->chan_mode) {

--
To view, visit https://gerrit.osmocom.org/12734
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8018fd9d56421f2ab7be91703018f6d6f21c929
Gerrit-Change-Number: 12734
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Max

Change in osmo-bsc[master]: comments: clarify usage of conn.assignment and .handover scopes

2019-02-06 Thread Neels Hofmeyr

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12842

to look at the new patch set (#2).

Change subject: comments: clarify usage of conn.assignment and .handover scopes
..

comments: clarify usage of conn.assignment and .handover scopes

Change-Id: I7ef602c3ce086aecbc3ae3ae6d3fd33ad2b9f85c
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 13 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/12842/2
--
To view, visit https://gerrit.osmocom.org/12842
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ef602c3ce086aecbc3ae3ae6d3fd33ad2b9f85c
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

2019-02-06 Thread osmith

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
..

Inactive connection cleanup (disabled by default)

Add a watchdog timer to connections, and close these connections when
the watchdog timer expires. Kick the watchdog whenever RTP messages or
the relevant MGCP messages arrive. Add the currently remaining timeout
to "show mgcp stats" in the VTY.

This feature is disabled by default, as it is incompatible with LCLS
(connections in LCLS state appear to be inactive). Enable it with the
new "conn-timeout" VTY setting. In general, this feature can be used to
work around interoperability problems causing connections to stay open
forever, and slowly exhausting all available ports. This happened for
various reasons already.

MDCX is the only relevant MGCP message:
- CRCX creates the conn and timer
- DLCX deletes the conn and timer
- MDCX is the only remaining supported MGCP message that indicates a CI
- Can't easily generically parse a CI for all MGCP messages, parsing is
  done in handle_modify_con().

Related: OS#3429
Change-Id: I18886052e090466f73829133c24f011806cc1fe0
---
M include/osmocom/mgcp/mgcp.h
M include/osmocom/mgcp/mgcp_internal.h
M src/libosmo-mgcp/mgcp_conn.c
M src/libosmo-mgcp/mgcp_network.c
M src/libosmo-mgcp/mgcp_protocol.c
M src/libosmo-mgcp/mgcp_vty.c
M tests/mgcp/mgcp_test.c
7 files changed, 61 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/mgcp/mgcp.h b/include/osmocom/mgcp/mgcp.h
index 034a780..7597af8 100644
--- a/include/osmocom/mgcp/mgcp.h
+++ b/include/osmocom/mgcp/mgcp.h
@@ -274,6 +274,9 @@
uint16_t osmux_dummy;
/* domain name of the media gateway */
char domain[255+1];
+
+   /* time after which inactive connections (CIs) get closed */
+   int conn_timeout;
 };
 
 /* config management */
diff --git a/include/osmocom/mgcp/mgcp_internal.h 
b/include/osmocom/mgcp/mgcp_internal.h
index f75ae8b..14c5f11 100644
--- a/include/osmocom/mgcp/mgcp_internal.h
+++ b/include/osmocom/mgcp/mgcp_internal.h
@@ -231,6 +231,9 @@
/*! human readable name (vty, logging) */
char name[256];

+   /*! activity tracker (for cleaning up inactive connections) */
+   struct osmo_timer_list watchdog;
+
/*! union with connection description */
union {
struct mgcp_conn_rtp rtp;
@@ -328,3 +331,4 @@
 #define PTYPE_UNDEFINED (-1)

 void mgcp_get_local_addr(char *addr, struct mgcp_conn_rtp *conn);
+void mgcp_conn_watchdog_kick(struct mgcp_conn *conn);
diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c
index fce8a78..a8341d6 100644
--- a/src/libosmo-mgcp/mgcp_conn.c
+++ b/src/libosmo-mgcp/mgcp_conn.c
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 

 const static struct rate_ctr_group_desc rate_ctr_group_desc = {
@@ -125,6 +126,23 @@
rate_ctr_group_free(conn_rtp->rate_ctr_group);
 }

+void mgcp_conn_watchdog_cb(void *data)
+{
+   struct mgcp_conn *conn = data;
+   LOGP(DLMGCP, LOGL_ERROR, "endpoint:0x%x CI:%s connection timed out!\n", 
ENDPOINT_NUMBER(conn->endp), conn->id);
+   mgcp_conn_free(conn->endp, conn->id);
+}
+
+void mgcp_conn_watchdog_kick(struct mgcp_conn *conn)
+{
+   int timeout = conn->endp->cfg->conn_timeout;
+   if (!timeout)
+   return;
+
+   LOGP(DLMGCP, LOGL_DEBUG, "endpoint:0x%x CI:%s watchdog kicked\n", 
ENDPOINT_NUMBER(conn->endp), conn->id);
+   osmo_timer_schedule(>watchdog, timeout, 0);
+}
+
 /*! allocate a new connection list entry.
  *  \param[in] ctx talloc context
  *  \param[in] endp associated endpoint
@@ -167,6 +185,9 @@
OSMO_ASSERT(false);
}

+   /* Initialize watchdog */
+   osmo_timer_setup(>watchdog, mgcp_conn_watchdog_cb, conn);
+   mgcp_conn_watchdog_kick(conn);
llist_add(>entry, >conns);

return conn;
@@ -274,6 +295,7 @@
OSMO_ASSERT(false);
}

+   osmo_timer_del(>watchdog);
llist_del(>entry);
talloc_free(conn);
 }
diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c
index 7af8e71..2c86f8f 100644
--- a/src/libosmo-mgcp/mgcp_network.c
+++ b/src/libosmo-mgcp/mgcp_network.c
@@ -1246,6 +1246,8 @@
if (len < 0)
return -1;

+   mgcp_conn_watchdog_kick(conn_src->conn);
+
/* Check if the connection is in loopback mode, if yes, just send the
 * incoming data back to the origin */
if (conn_src->conn->mode == MGCP_CONN_LOOPBACK) {
diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index f141485..9f95ea4 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -1141,6 +1141,8 @@
return

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
..


Patch Set 7: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 7
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 06 Feb 2019 12:35:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: platform independence fix: tdef range tests

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12841 )

Change subject: platform independence fix: tdef range tests
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
Gerrit-Change-Number: 12841
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 06 Feb 2019 12:34:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

2019-02-06 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
..


Patch Set 7:

(1 comment)

> I think this patch is missing to export the currently remaining timeout as 
> part of the "show mgcp [stats]" command.  Or did I miss something?

Right, I did not think about displaying the remaining timeout anywhere. It is 
implemented now, e.g. with "conn-timeout 60":


 OsmoMGW> show mgcp stats 
 Virtual trunk 0 with 64 endpoints:   
 Virtual trunk 0 endpoint rtpbridge/01:
CONN: (138c/rtp, id:0xC4E6CC99, ip:192.168.1.37, rtp:16008 rtcp:16009)  
  
Currently remaining timeout (seconds): 59.990917   
Packets Sent: 108 (4955 bytes total)
Packets Received: 108 (4955 bytes total)
 ...

And it even helped uncover a bug, I had parsed the conn-timeout value as hex 
number instead of decimal number. It's all fixed now, can you guys take another 
look?

https://gerrit.osmocom.org/#/c/12730/6/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/#/c/12730/6/src/libosmo-mgcp/mgcp_vty.c@1342
PS6, Line 1342:
This must be 10!



--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 7
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 06 Feb 2019 11:05:57 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

2019-02-06 Thread osmith

Hello Vadim Yanitskiy, daniel, Max, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12730

to look at the new patch set (#7).

Change subject: Inactive connection cleanup (disabled by default)
..

Inactive connection cleanup (disabled by default)

Add a watchdog timer to connections, and close these connections when
the watchdog timer expires. Kick the watchdog whenever RTP messages or
the relevant MGCP messages arrive. Add the currently remaining timeout
to "show mgcp stats" in the VTY.

This feature is disabled by default, as it is incompatible with LCLS
(connections in LCLS state appear to be inactive). Enable it with the
new "conn-timeout" VTY setting. In general, this feature can be used to
work around interoperability problems causing connections to stay open
forever, and slowly exhausting all available ports. This happened for
various reasons already.

MDCX is the only relevant MGCP message:
- CRCX creates the conn and timer
- DLCX deletes the conn and timer
- MDCX is the only remaining supported MGCP message that indicates a CI
- Can't easily generically parse a CI for all MGCP messages, parsing is
  done in handle_modify_con().

Related: OS#3429
Change-Id: I18886052e090466f73829133c24f011806cc1fe0
---
M include/osmocom/mgcp/mgcp.h
M include/osmocom/mgcp/mgcp_internal.h
M src/libosmo-mgcp/mgcp_conn.c
M src/libosmo-mgcp/mgcp_network.c
M src/libosmo-mgcp/mgcp_protocol.c
M src/libosmo-mgcp/mgcp_vty.c
M tests/mgcp/mgcp_test.c
7 files changed, 61 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/30/12730/7
--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 7
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2019-02-06 Thread Vadim Yanitskiy

Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11992

to look at the new patch set (#10).

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..

libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

It may happen that either the MS or an ESME would become
unresponsive during a call independent SS session, e.g.
due to a bug, or a dropped message. In such cases, the
corresponding transaction would remain unfreed forever.

This change introduces a guard timer, that prevents keeping
'stalled' NCSS sessions forever. As soon as it expires, both
sides (i.e. MS and ESME) are getting notified, and the
transaction is being released.

By default, the timer expires after 30 seconds. As soon as
either the MS, or an ESME initiates any activity,
the watchdog timer is rescheduled.

The timeout value can be configured from the VTY:

  msc
   ...
   ! Use 0 to disable this timer
   ncss guard-timeout 30

This change makes TC_lu_and_ss_session_timeout pass.

Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Related Change-Id: (TTCN) I3e1791773d56617172ae27a46889a1ae4d400e2f
Related: OS#3655
---
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/transaction.h
M src/libmsc/gsm_09_11.c
M src/libmsc/msc_vty.c
M src/libmsc/osmo_msc.c
M tests/test_nodes.vty
6 files changed, 86 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/11992/10
--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 10
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Stefan Sperling

Change in osmo-msc[master]: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

2019-02-06 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/12843 )

Change subject: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()
..

libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

According to GSM 04.80, section 2.5.1, Release complete message
may have an optional Cause IE. Let's add a new function, that
allows to specify cause location and value.

This function will be used by the upcoming changes.

Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
Depends Change-Id: (libosmocore) Ie3ac85fcef90a5e532334ba3482804d5305c88d7
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
2 files changed, 31 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/43/12843/2
--
To view, visit https://gerrit.osmocom.org/12843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
Gerrit-Change-Number: 12843
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-msc[master]: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()

2019-02-06 Thread Vadim Yanitskiy

Hello Max, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12840

to look at the new patch set (#2).

Change subject: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()
..

libmsc/gsm_04_80.c: use gsm0480_create_release_complete()

The previous implementation of msc_send_ussd_release_complete() was
based on gsm0480_create_ussd_release_complete(), that doesn't
allow to specify GSM 04.07 transaction identifier.

The ability to specify particular transaction identifier
is required for handling multiple SS/USSD transactions.

Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb
Depends Change-Id: (libosmocore) Ie3ac85fcef90a5e532334ba3482804d5305c88d7
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
M src/libmsc/msc_vty.c
3 files changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/12840/2
--
To view, visit https://gerrit.osmocom.org/12840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb
Gerrit-Change-Number: 12840
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2019-02-06 Thread Vadim Yanitskiy

Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11992

to look at the new patch set (#9).

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..

libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

It may happen that either the MS or an ESME would become
unresponsive during a call independent SS session, e.g.
due to a bug, or a dropped message. In such cases, the
corresponding transaction would remain unfreed forever.

This change introduces a guard timer, that prevents keeping
'stalled' NCSS sessions forever. As soon as it expires, both
sides (i.e. MS and ESME) are getting notified, and the
transaction is being released.

By default, the timer expires after 30 seconds. As soon as
either the MS, or an ESME initiates any activity,
the watchdog timer is rescheduled.

The timeout value can be configured from the VTY:

  msc
   ...
   ! Use 0 to disable this timer
   ncss guard-timeout 30

This change makes TC_lu_and_ss_session_timeout pass.

Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Depends Change-Id: (libosmocore) Ie3ac85fcef90a5e532334ba3482804d5305c88d7
Related Change-Id: (TTCN) I3e1791773d56617172ae27a46889a1ae4d400e2f
Related: OS#3655
---
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/transaction.h
M src/libmsc/gsm_09_11.c
M src/libmsc/msc_vty.c
M src/libmsc/osmo_msc.c
M tests/test_nodes.vty
6 files changed, 86 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/11992/9
--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 9
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Stefan Sperling

Change in osmo-msc[master]: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

2019-02-06 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12843


Change subject: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()
..

libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

According to GSM 04.80, section 2.5.1, Release complete message
may have an optional Cause IE. Let's add a new function, that
allows to specify cause location and value.

This function will be used by the upcoming changes.

Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
2 files changed, 31 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/43/12843/1

diff --git a/include/osmocom/msc/gsm_04_80.h b/include/osmocom/msc/gsm_04_80.h
index 0008c22..c95ca85 100644
--- a/include/osmocom/msc/gsm_04_80.h
+++ b/include/osmocom/msc/gsm_04_80.h
@@ -12,3 +12,6 @@
 const char *text);
 int msc_send_ussd_release_complete(struct ran_conn *conn,
   uint8_t transaction_id)
+int msc_send_ussd_release_complete_cause(struct ran_conn *conn,
+uint8_t transaction_id,
+uint8_t cause_loc, uint8_t cause_val)
diff --git a/src/libmsc/gsm_04_80.c b/src/libmsc/gsm_04_80.c
index 502848f..e3547f4 100644
--- a/src/libmsc/gsm_04_80.c
+++ b/src/libmsc/gsm_04_80.c
@@ -86,3 +86,31 @@
return -1;
return msc_tx_dtap(conn, msg);
 }
+
+int msc_send_ussd_release_complete_cause(struct ran_conn *conn,
+uint8_t transaction_id,
+uint8_t cause_loc, uint8_t cause_val)
+{
+   struct msgb *msg;
+   uint8_t *cause_ie;
+
+   msg = gsm0480_create_release_complete(transaction_id);
+   if (!msg)
+   return -1;
+
+   /* Encode cause IE (see GSM 04.08, section 10.5.4.11)
+* with fixed length (2 bytes of TL, 2 bytes of payload).
+* NOTE: we don't use gsm48_encode_cause() API because
+* it wants gsm_mncc_cause struct from us. */
+   cause_ie = msgb_put(msg, 2 + 2);
+   cause_ie[0] = GSM48_IE_CAUSE;
+   cause_ie[1] = 2;
+
+   /* Coding standard defined for the GSM PLMNs,
+* location and cause: as given by caller,
+* no extension, no diagnostics. */
+   cause_ie[2] = (1 << 7) | (0x03 << 5) | (cause_loc & 0x0f);
+   cause_ie[3] = (1 << 7) | cause_val;
+
+   return msc_tx_dtap(conn, msg);
+}

--
To view, visit https://gerrit.osmocom.org/12843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
Gerrit-Change-Number: 12843
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in libosmocore[master]: gsm/gsm0480: introduce gsm0480_create_release_complete()

2019-02-06 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12839 )

Change subject: gsm/gsm0480: introduce gsm0480_create_release_complete()
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/12839
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac85fcef90a5e532334ba3482804d5305c88d7
Gerrit-Change-Number: 12839
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 06 Feb 2019 10:38:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2019-02-06 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..


Patch Set 8:

Hi Max,

 > Same comments as before.
 > Patch set 8: Code-Review -1

same opinion as before: not critical.

> If that's the only reason than it's better to use uint8_t
> (which can be casted to int without any issues) to keep it
> consistent with vty code.

Your suggestion to use 'uint8_t' wouldn't make it better, as there is no need 
to use fixed-size type in this particular case. We can extend the VTY later on 
to allow longer timeout values, so using generic 'unsigned int' would make more 
sense.

Anyway, in general we neither use 'unsigned int' nor fixed-types in the 'for' 
statements where the counter 'i' is always > 0 - we just use 'int' and leave it 
up to the compiler. Nobody does complain about this.

This patch is consistent with the current code, where we use 'int' for MNCC 
timeout, as well as with the libosmocore's API, where osmo_timer_schedule() 
does accept 'int'. The change does what is written in the commit message, and 
it also has the test case, so I don't see any reason to block it due to such 
minor issues. Again, if you have enough time and strong desire, feel free to 
submit a patch that changes both variables to 'unsigned int'.


--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 8
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Wed, 06 Feb 2019 10:30:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2019-02-06 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..


Patch Set 8: Code-Review-1

Same comments as before.


--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 8
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Wed, 06 Feb 2019 10:08:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()

2019-02-06 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/12840 )

Change subject: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb
Gerrit-Change-Number: 12840
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Wed, 06 Feb 2019 10:05:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add stream client/server test

2019-02-06 Thread Max

Hello daniel, Harald Welte, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12837

to look at the new patch set (#8).

Change subject: Add stream client/server test
..

Add stream client/server test

Previously stream client and server code were only used in examples
which means regressions could be easily introduced unnoticed until they
trigger bugs in external code which relies on osmo_stream_*()

Fix this by adding basic client-server interaction test with single
reconnection iteration.

Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
---
M .gitignore
M tests/Makefile.am
A tests/stream/stream_test.c
A tests/stream/stream_test.ok
M tests/testsuite.at
5 files changed, 297 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/37/12837/8
--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 8
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith

Change in libosmocore[master]: gsm/gsm0480: introduce gsm0480_create_release_complete[_cause]() API

2019-02-06 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12839 )

Change subject: gsm/gsm0480: introduce 
gsm0480_create_release_complete[_cause]() API
..


Patch Set 1:

Hi Harald,

 > If you're introducing a new API function, I would consider it "most
 > clean" if one were to pass a "struct release_cause { location;
 > cause; }" kind of struct as a "const *" pointer to a function.  If
 > that pointer is NULL, then the optional element is not encoded.  If
 > it's non-null the optional element is encoded as per the elements
 > in that struct.

hmm, yes. But since you're suggesting to introduce a new struct, I think we 
need to introduce the new API for Cause IE. The current gsm48_encode_cause() is 
mixed up with gsm_mncc_cause struct, and I really don't like this...


--
To view, visit https://gerrit.osmocom.org/12839
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac85fcef90a5e532334ba3482804d5305c88d7
Gerrit-Change-Number: 12839
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:23:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: VTY: add command show asciidoc ctrl

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12814 )

Change subject: VTY: add command show asciidoc ctrl
..


Patch Set 2:

(3 comments)

I agree with Vadim in that there are two separate features merged in one patch 
which should be separate: 1) exposing the list via CTRL, and 2) adding access 
modes.   I would assume '1' is the less controversial change, and hence it 
should be first so it can be merged independently of the second.

Whether or not we'd want to go this way with extneding the CTRL interface, and 
whether the proposed implementation complies with the CTRL interface in general 
is something I put into Daniels' hands, as he created CTRL originally.

https://gerrit.osmocom.org/#/c/12814/2/include/osmocom/ctrl/control_cmd.h
File include/osmocom/ctrl/control_cmd.h:

https://gerrit.osmocom.org/#/c/12814/2/include/osmocom/ctrl/control_cmd.h@107
PS2, Line 107: enum ctrl_cmd_mode mode;
> You're breaking ABI here.
To give more context: As per our policy, this would require dding an entry to 
the TODO-RELEASE file, as it requires us to increment the LIBVERSION at the 
next version tag to avoid breaking backwards/forwards ABI compatibility.


https://gerrit.osmocom.org/#/c/12814/2/include/osmocom/ctrl/control_cmd.h@152
PS2, Line 152: CTRL_CMD_DEFINE_STRUCT
> Since this is a public header, we cannot modify existing symbols nor 
> definitions.
this is required to ensure that old code can be built against new libraries.  
So you cannot change the number/order of arguments to any existing function or 
macro, but must always introduce a new one while keeping the old one as a 
compatibility wrapper with reasonable defaults.


https://gerrit.osmocom.org/#/c/12814/2/src/ctrl/control_vty.c
File src/ctrl/control_vty.c:

https://gerrit.osmocom.org/#/c/12814/2/src/ctrl/control_vty.c@89
PS2, Line 89:   switch(cmd_el->mode){
> Missing space, should be 'switch ('.
the philosophy of the Linux kernel coding style (which we use) is "if, switch, 
etc. are no functions, hence a space".



--
To view, visit https://gerrit.osmocom.org/12814
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16f59bfca72a7dd9c268bc64499b26d82a2115d2
Gerrit-Change-Number: 12814
Gerrit-PatchSet: 2
Gerrit-Owner: Omar Ramadan 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:21:41 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmo-netif[master]: Add stream client/server test

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 7: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 7
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:15:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
..


Patch Set 6:

I think this patch is missing to export the currently remaining timeout as part 
of the "show mgcp [stats]" command.  Or did I miss something?


--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:14:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bsc: Test CSFB "Fast Return" in new TC_chan_rel_hard_clear_csfb

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12820 )

Change subject: bsc: Test CSFB "Fast Return" in new TC_chan_rel_hard_clear_csfb
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12820
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7501fb25578412c882ff92da5d388f3079bbce7f
Gerrit-Change-Number: 12820
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:10:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Install signal handlers before processing config

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12758 )

Change subject: Install signal handlers before processing config
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12758
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd1ad55a227db08595d844008be86f648fa92c1
Gerrit-Change-Number: 12758
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:10:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Install signal handlers before processing config

2019-02-06 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12758 )

Change subject: Install signal handlers before processing config
..

Install signal handlers before processing config

It's easier to troubleshoot vty-related issues when we can send signals
to obtain talloc report.

Change-Id: I6dd1ad55a227db08595d844008be86f648fa92c1
---
M src/osysmon_main.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osysmon_main.c b/src/osysmon_main.c
index eb4f50b..91d5039 100644
--- a/src/osysmon_main.c
+++ b/src/osysmon_main.c
@@ -210,6 +210,10 @@
ping_init = osysmon_ping_init();
osysmon_file_init();

+   signal(SIGUSR1, _handler);
+   signal(SIGUSR2, _handler);
+   osmo_init_ignore_signals();
+
rc = vty_read_config_file(cmdline_opts.config_file, NULL);
if (rc < 0) {
fprintf(stderr, "Failed to parse the config file %s\n",
@@ -217,10 +221,6 @@
exit(2);
}

-   signal(SIGUSR1, _handler);
-   signal(SIGUSR2, _handler);
-   osmo_init_ignore_signals();
-
if (cmdline_opts.daemonize) {
rc = osmo_daemonize();
if (rc < 0) {

-- 
To view, visit https://gerrit.osmocom.org/12758
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dd1ad55a227db08595d844008be86f648fa92c1
Gerrit-Change-Number: 12758
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith

Change in osmo-ttcn3-hacks[master]: bsc: replace octet string with decmatch when matching RR RELEASE

2019-02-06 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12819 )

Change subject: bsc: replace octet string with decmatch when matching RR RELEASE
..

bsc: replace octet string with decmatch when matching RR RELEASE

The 'decmatch' keyword allows us to match the decoded version of some
octetstring, which is very useful in the situations where we have
the L3 message only as octetstring but want to check if it matches
some L3 template.

Change-Id: I0a91e067f7e8062bf991fef8b0d4d8da740bfafc
---
M bsc/BSC_Tests.ttcn
M bsc/BSC_Tests_LCLS.ttcn
M library/L3_Templates.ttcn
3 files changed, 34 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 5ac8191..555aac8 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -62,7 +62,6 @@
 const integer NUM_TCHH_PER_BTS := 2;
 const integer NUM_TCHF_PER_BTS := 4;
 const integer NUM_SDCCH_PER_BTS := 4;
-template octetstring t_l3_rr_chan_rel := '060D??*'O;


 /* per-BTS state which we keep */
@@ -872,7 +871,7 @@
got_deact_sacch := true;
repeat;
}
-   [] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, t_l3_rr_chan_rel))) {
+   [] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE))) {
got_rr_chan_rel := true;
repeat;
}
@@ -2816,7 +2815,7 @@
[] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {
log("Got Deact SACCH");
}
-   [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, t_l3_rr_chan_rel)) {
+   [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch 
tr_RRM_RR_RELEASE)) {
log("Got RR Release");
}
[] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {
diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn
index 0fada93..67ccecf 100644
--- a/bsc/BSC_Tests_LCLS.ttcn
+++ b/bsc/BSC_Tests_LCLS.ttcn
@@ -702,7 +702,7 @@
var myBSSMAP_Cause cause_val := GSM0808_CAUSE_CALL_CONTROL;
CONN_A.send(ts_BSSMAP_ClearCommand(enum2int(cause_val)));
interleave {
-   [] CONN_A.receive(tr_RSL_DATA_REQ(?, tr_RslLinkID_DCCH(0), 
t_l3_rr_chan_rel));
+   [] CONN_A.receive(tr_RSL_DATA_REQ(?, tr_RslLinkID_DCCH(0), decmatch 
tr_RRM_RR_RELEASE));
[] CONN_A.receive(tr_RSL_DEACT_SACCH(?));
[] CONN_A.receive(tr_RSL_RF_CHAN_REL(?)) -> value rsl {
var RSL_IE_Body ieb;
diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index 3978498..0b714d3 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -660,6 +660,37 @@
}
 }

+template PDU_ML3_NW_MS tr_RRM_RR_RELEASE(template OCT1 cause := ?) := {
+   discriminator := '0110'B,
+   tiOrSkip := {
+   skipIndicator := ''B
+   },
+   msgs := {
+   rrm := {
+   channelRelease := {
+   messageType := '1101'B,
+   rRCause := {
+   valuePart := cause
+   },
+   bARange := *,
+   groupChannelDescription := *,
+   groupCipherKeyNumber := *,
+   gPRSResumption := *,
+   bAListPref := *,
+   uTRANFrequencyList := *,
+   cellChannelDescr := *,
+   cellSelectionIndicator := *,
+   enhanced_DTM_CS_Release_Indication := *,
+   vGCS_Ciphering_Parameters := *,
+   group_Channel_Description_2 := *,
+   talkerIdentity := *,
+   talkerPriorityStatus := *,
+   vGCS_AMR_Configuration := *,
+   individual_Priorities := *
+   }
+   }
+   }
+}


 template PDU_ML3_MS_NW ts_ML3_MO := {

--
To view, visit https://gerrit.osmocom.org/12819
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a91e067f7e8062bf991fef8b0d4d8da740bfafc
Gerrit-Change-Number: 12819
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmo-netif[master]: Stream examples: fix typos in error message

2019-02-06 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12825 )

Change subject: Stream examples: fix typos in error message
..

Stream examples: fix typos in error message

Likely a copy-paste error from corresponding client example code.

Change-Id: I47cc8c7340eb188d85a49d4f41c295bed0e1bee4
---
M examples/stream-server.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/examples/stream-server.c b/examples/stream-server.c
index c1086ec..f3ee315 100644
--- a/examples/stream-server.c
+++ b/examples/stream-server.c
@@ -148,7 +148,7 @@

srv = osmo_stream_srv_link_create(tall_test);
if (srv == NULL) {
-   fprintf(stderr, "cannot create client\n");
+   fprintf(stderr, "cannot create server link\n");
exit(EXIT_FAILURE);
}
osmo_stream_srv_link_set_addr(srv, "127.0.0.1");
@@ -156,7 +156,7 @@
osmo_stream_srv_link_set_accept_cb(srv, accept_cb);

if (osmo_stream_srv_link_open(srv) < 0) {
-   fprintf(stderr, "cannot open client\n");
+   fprintf(stderr, "cannot open server link\n");
exit(EXIT_FAILURE);
}


--
To view, visit https://gerrit.osmocom.org/12825
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I47cc8c7340eb188d85a49d4f41c295bed0e1bee4
Gerrit-Change-Number: 12825
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: osmith 
Gerrit-CC: daniel

Change in libosmo-netif[master]: Stream examples: fix typos in error message

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12825 )

Change subject: Stream examples: fix typos in error message
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12825
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47cc8c7340eb188d85a49d4f41c295bed0e1bee4
Gerrit-Change-Number: 12825
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: osmith 
Gerrit-CC: daniel 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:09:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bsc: Test CSFB "Fast Return" in new TC_chan_rel_hard_clear_csfb

2019-02-06 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12820 )

Change subject: bsc: Test CSFB "Fast Return" in new TC_chan_rel_hard_clear_csfb
..

bsc: Test CSFB "Fast Return" in new TC_chan_rel_hard_clear_csfb

When a MSC releases a connection using the BSSMAP CLEAR CMD, it can
specify that this call was part of CSFB.

The BSC is then supposed to add a special IE to the RR RELEASE
message which will help the phone to switch back to LTE as soon
as possible.

This commit adds a new test case testing for exactly that behavior.

The test does *not* verify if the EARFCN information contained is
actually correct, only that the IE is present in the RR RELEASE.

Change-Id: I7501fb25578412c882ff92da5d388f3079bbce7f
Requires: osmo-bsc Ibfbb87e2e16b05032ad1cb91c11fad1b2f76d755
Related: OS#3777
---
M bsc/BSC_Tests.ttcn
M library/BSSMAP_Templates.ttcn
M library/L3_Templates.ttcn
3 files changed, 56 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 555aac8..5d8f375 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -856,7 +856,8 @@
   boolean expect_deact_sacch := true,
   boolean expect_rr_chan_rel := true,
   boolean expect_rll_rel_req := true,
-  boolean handle_rll_rel := true
+  boolean handle_rll_rel := true,
+  boolean is_csfb := false
   ) runs on test_CT {

var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0));
@@ -871,7 +872,11 @@
got_deact_sacch := true;
repeat;
}
-   [] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE))) {
+   [is_csfb] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE_CSFB))) {
+   got_rr_chan_rel := true;
+   repeat;
+   }
+   [not is_csfb] 
IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE))) {
got_rr_chan_rel := true;
repeat;
}
@@ -932,6 +937,29 @@
setverdict(pass);
 }
 
+/* Test behavior of channel release after Clear Command with CSFB indicator 
from MSC */
+testcase TC_chan_rel_hard_clear_csfb() runs on test_CT {
+   var BSSAP_N_DATA_ind rx_di;
+   var DchanTuple dt;
+
+   f_init(1);
+
+   dt := f_est_dchan('23'O, 23, '00010203040506'O);
+
+   /* Instruct BSC to clear channel */
+   var BssmapCause cause := 0;
+   BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, 
ts_BSSMAP_ClearCommandCSFB(cause)));
+
+   /* expect Clear Complete from BSC on A */
+   BSSAP.receive(tr_BSSAP_DATA_ind(dt.sccp_conn_id, 
tr_BSSMAP_ClearComplete)) {
+   /* release the SCCP connection */
+   BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));
+   }
+
+   f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false, 
is_csfb := true);
+   setverdict(pass);
+}
+
 /* Test behavior of channel release after hard RLSD from MSC */
 testcase TC_chan_rel_hard_rlsd() runs on test_CT {
var DchanTuple dt;
@@ -3697,6 +3725,7 @@
execute( TC_chan_rel_rll_rel_ind() );
execute( TC_chan_rel_conn_fail() );
execute( TC_chan_rel_hard_clear() );
+   execute( TC_chan_rel_hard_clear_csfb() );
execute( TC_chan_rel_hard_rlsd() );
execute( TC_chan_rel_hard_rlsd_ms_dead() );
execute( TC_chan_rel_a_reset() );
diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn
index ff151f0..a30b8e7 100644
--- a/library/BSSMAP_Templates.ttcn
+++ b/library/BSSMAP_Templates.ttcn
@@ -612,6 +612,18 @@
}
}
 }
+template (value) PDU_BSSAP ts_BSSMAP_ClearCommandCSFB(BssmapCause cause)
+modifies ts_BSSMAP_ClearCommand := {
+   pdu := {
+   bssmap := {
+   clearCommand := {
+   cSFB_Indication := {
+   elementIdentifier := '8F'O
+   }
+   }
+   }
+   }
+}

 template PDU_BSSAP tr_BSSMAP_ClearCommand modifies tr_BSSAP_BSSMAP := {
pdu := {
diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index 0b714d3..6099303 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -692,6 +692,19 @@
}
 }

+template PDU_ML3_NW_MS tr_RRM_RR_RELEASE_CSFB(template OCT1 cause := ?) 
modifies tr_RRM_RR_RELEASE := {
+   msgs := {
+   rrm := {
+   channelRelease := {
+   cellSelectionIndicator := {
+

Change in osmo-ttcn3-hacks[master]: bsc: replace octet string with decmatch when matching RR RELEASE

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12819 )

Change subject: bsc: replace octet string with decmatch when matching RR RELEASE
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12819
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a91e067f7e8062bf991fef8b0d4d8da740bfafc
Gerrit-Change-Number: 12819
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:10:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Ignore test binaries

2019-02-06 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12759 )

Change subject: Ignore test binaries
..

Ignore test binaries

Change-Id: Ice6f5aec2f22a97033a555a292a5648090fc5970
---
M .gitignore
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/.gitignore b/.gitignore
index 31b7a15..672708d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -53,3 +53,6 @@
 /examples/udp-test-server

 .*.sw?
+jibuf_test
+jibuf_tool
+osmux_test2

--
To view, visit https://gerrit.osmocom.org/12759
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice6f5aec2f22a97033a555a292a5648090fc5970
Gerrit-Change-Number: 12759
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pablo Neira Ayuso 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith

Change in libosmocore[master]: gsm/gsm0480: introduce gsm0480_create_release_complete[_cause]() API

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12839 )

Change subject: gsm/gsm0480: introduce 
gsm0480_create_release_complete[_cause]() API
..


Patch Set 1:

If you're introducing a new API function, I would consider it "most clean" if 
one were to pass a "struct release_cause { location; cause; }" kind of struct 
as a "const *" pointer to a function.  If that pointer is NULL, then the 
optional element is not encoded.  If it's non-null the optional element is 
encoded as per the elements in that struct.

It's not critical, I would also merge your patch as-is, if you prefer.


--
To view, visit https://gerrit.osmocom.org/12839
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac85fcef90a5e532334ba3482804d5305c88d7
Gerrit-Change-Number: 12839
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:08:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/osmo_msc.c: move connection ref-counting code to 'ran_conn.c'

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12698 )

Change subject: libmsc/osmo_msc.c: move connection ref-counting code to 
'ran_conn.c'
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I593675d9bf56eaef12afdaf596ee1337b9a44259
Gerrit-Change-Number: 12698
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:06:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: handover_fsm: do not access conn->assignment.req, it may be outdated

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12734 )

Change subject: handover_fsm: do not access conn->assignment.req, it may be 
outdated
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12734
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8018fd9d56421f2ab7be91703018f6d6f21c929
Gerrit-Change-Number: 12734
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Max 
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:05:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: comments: clarify usage of conn.assignment and .handover scopes

2019-02-06 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12842 )

Change subject: comments: clarify usage of conn.assignment and .handover scopes
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12842
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ef602c3ce086aecbc3ae3ae6d3fd33ad2b9f85c
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 06 Feb 2019 08:05:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

69 matches

Mail list logo