Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions ...................................................................... Patch Set 8: Hi Max, > Same comments as before. > Patch set 8: Code-Review -1 same opinion as before: not critical. > If that's the only reason than it's better to use uint8_t > (which can be casted to int without any issues) to keep it > consistent with vty code. Your suggestion to use 'uint8_t' wouldn't make it better, as there is no need to use fixed-size type in this particular case. We can extend the VTY later on to allow longer timeout values, so using generic 'unsigned int' would make more sense. Anyway, in general we neither use 'unsigned int' nor fixed-types in the 'for' statements where the counter 'i' is always > 0 - we just use 'int' and leave it up to the compiler. Nobody does complain about this. This patch is consistent with the current code, where we use 'int' for MNCC timeout, as well as with the libosmocore's API, where osmo_timer_schedule() does accept 'int'. The change does what is written in the commit message, and it also has the test case, so I don't see any reason to block it due to such minor issues. Again, if you have enough time and strong desire, feel free to submit a patch that changes both variables to 'unsigned int'. -- To view, visit https://gerrit.osmocom.org/11992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb Gerrit-Change-Number: 11992 Gerrit-PatchSet: 8 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Wed, 06 Feb 2019 10:30:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
