Change in libosmocore[master]: TLV: Add one-shot TLV encoder

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12900


Change subject: TLV: Add one-shot TLV encoder
..

TLV: Add one-shot TLV encoder

So far, the TLV code contained two types of functions
* tlp_parse() to parse all TLVs according to definition into tlvp_parsed
* various helper functions to encode individual TLVs during message
  generation

This patch implements the inverse of tlv_parse(): tlv_encode(), which
takes a full 'struct tlv_pared' and encodes all IEs found in it.  The
order of IEs is in numerically ascending order of the tag.

As many protocols have different IE/TLV ordering requirements, let's add
a tlv_encode_ordered() function where the caller can specify the TLV
ordering during the one-shot encode.

Change-Id: I761a30bf20355a9f80a4a8e0c60b0b0f78515efe
---
M include/osmocom/gsm/tlv.h
M src/gsm/libosmogsm.map
M src/gsm/tlv_parser.c
3 files changed, 96 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/00/12900/1

diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h
index d0c9552..bb0e8fc 100644
--- a/include/osmocom/gsm/tlv.h
+++ b/include/osmocom/gsm/tlv.h
@@ -457,6 +457,12 @@
 /* take a master (src) tlv def and fill up all empty slots in 'dst' */
 void tlv_def_patch(struct tlv_definition *dst, const struct tlv_definition 
*src);

+int tlv_encode_one(struct msgb *msg, enum tlv_type type, uint8_t tag,
+  unsigned int len, const uint8_t *val);
+int tlv_encode(struct msgb *msg, const struct tlv_definition *def, const 
struct tlv_parsed *tp);
+int tlv_encode_ordered(struct msgb *msg, const struct tlv_definition *def, 
const struct tlv_parsed *tp,
+   const uint8_t *tag_order, unsigned int tag_order_len);
+
 #define TLVP_PRESENT(x, y) ((x)->lv[y].val)
 #define TLVP_LEN(x, y) (x)->lv[y].len
 #define TLVP_VAL(x, y) (x)->lv[y].val
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index ae7c0a1..c123dfc 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -493,6 +493,9 @@
 tlv_parse;
 tlv_parse2;
 tlv_parse_one;
+tlv_encode;
+tlv_encode_ordered;
+tlv_encode_one;
 tvlv_att_def;
 vtvlv_gan_att_def;

diff --git a/src/gsm/tlv_parser.c b/src/gsm/tlv_parser.c
index 6e089f7..b227c84 100644
--- a/src/gsm/tlv_parser.c
+++ b/src/gsm/tlv_parser.c
@@ -120,6 +120,93 @@
return 0;
 }

+
+/*! Encode a single TLV into given message buffer
+ *  \param[inout] msg Caller-allocated message buffer with sufficient tailroom
+ *  \param[in] type TLV type/format to use during encode
+ *  \param[in] tag Tag of TLV to be encoded
+ *  \parma[in] len Length of TLV to be encoded
+ *  \param[in] val Value part of TLV to be encoded
+ *  \returns 0 on success; negative in case of error */
+int tlv_encode_one(struct msgb *msg, enum tlv_type type, uint8_t tag,
+  unsigned int len, const uint8_t *val)
+{
+   switch (type) {
+   case TLV_TYPE_NONE:
+   break;
+   case TLV_TYPE_FIXED:
+   msgb_tv_fixed_put(msg, tag, len, val);
+   break;
+   case TLV_TYPE_T:
+   msgb_v_put(msg, tag);
+   break;
+   case TLV_TYPE_TV:
+   msgb_tv_put(msg, tag, val[0]);
+   break;
+   case TLV_TYPE_TLV:
+   msgb_tlv_put(msg, tag, len, val);
+   break;
+   case TLV_TYPE_TL16V:
+   msgb_tl16v_put(msg, tag, len, val);
+   break;
+   case TLV_TYPE_TvLV:
+   msgb_tvlv_put(msg, tag, len, val);
+   break;
+   case TLV_TYPE_SINGLE_TV:
+   msgb_v_put(msg, (tag << 4) | (val[0] & 0xf));
+   break;
+   case TLV_TYPE_vTvLV_GAN:
+   msgb_vtvlv_gan_put(msg, tag, len, val);
+   break;
+   default:
+   return -EINVAL;
+   }
+   return 0;
+}
+
+/*! Encode a set of decoded TLVs according to a given definition into a 
message buffer
+ *  \param[inout] msg Caller-allocated message buffer with sufficient tailroom
+ *  \param[in] def structure defining the valid TLV tags / configurations
+ *  \param[in] tp decoded values to be encoded
+ *  \returns number of bytes consumed in msg; negative in case of error */
+int tlv_encode(struct msgb *msg, const struct tlv_definition *def, const 
struct tlv_parsed *tp)
+{
+   unsigned int tailroom_before = msgb_tailroom(msg);
+   unsigned int i;
+   int rc;
+
+   for (i = 0; i < ARRAY_SIZE(tp->lv); i++) {
+   rc = tlv_encode_one(msg, def->def[i].type, i, TLVP_LEN(tp, i), 
TLVP_VAL(tp, i));
+   if (rc < 0)
+   return rc;
+   }
+   return tailroom_before - msgb_tailroom(msg);
+}
+
+/*! Encode a set of decoded TLVs according to a given definition and IE order 
into a message buffer
+ *  \param[inout] msg Caller-allocated message buffer with sufficient 

Change in libosmocore[master]: Add multipatch capability to osmo-config-merge

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12897 )

Change subject: Add multipatch capability to osmo-config-merge
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d
Gerrit-Change-Number: 12897
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 13 Feb 2019 19:47:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: GMM: permit VLR_ANSWERED event in attach FSM

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12895 )

Change subject: GMM: permit VLR_ANSWERED event in attach FSM
..


Patch Set 2:

commitlog does not contain reasons/rationale


--
To view, visit https://gerrit.osmocom.org/12895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14d234632224e20faf865d2273c83cfff31abf61
Gerrit-Change-Number: 12895
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 13 Feb 2019 19:47:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: modem: print call ID during log of call state

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12896 )

Change subject: modem: print call ID during log of call state
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d0153b3e89aa1924129b8068ef068c08059958
Gerrit-Change-Number: 12896
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 13 Feb 2019 19:46:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: modem: Log once dbus returns call was answered

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12898 )

Change subject: modem: Log once dbus returns call was answered
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12898
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia277b2eecdbf9969d77a688638837f9d9e1a44b6
Gerrit-Change-Number: 12898
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 13 Feb 2019 19:46:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: Log signals from VoiceCall dbus objects

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12899 )

Change subject: Log signals from VoiceCall dbus objects
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12899
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0def02b9063f75ec32c8b9382bdb12d65e1fb9eb
Gerrit-Change-Number: 12899
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 13 Feb 2019 19:46:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: modem: Log once dbus returns call was answered

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12898


Change subject: modem: Log once dbus returns call was answered
..

modem: Log once dbus returns call was answered

Change-Id: Ia277b2eecdbf9969d77a688638837f9d9e1a44b6
---
M src/osmo_gsm_tester/modem.py
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/98/12898/1

diff --git a/src/osmo_gsm_tester/modem.py b/src/osmo_gsm_tester/modem.py
index 6a2a49a..59e2136 100644
--- a/src/osmo_gsm_tester/modem.py
+++ b/src/osmo_gsm_tester/modem.py
@@ -717,6 +717,7 @@
 assert self.call_state(call_id) == 'incoming'
 call_dbus_obj = systembus_get(call_id)
 call_dbus_obj.Answer()
+self.dbg('Answered call %s' % call_id)
 
 def call_hangup(self, call_id):
 self.dbg('Hang up call %s' % call_id)

--
To view, visit https://gerrit.osmocom.org/12898
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia277b2eecdbf9969d77a688638837f9d9e1a44b6
Gerrit-Change-Number: 12898
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: Log signals from VoiceCall dbus objects

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12899


Change subject: Log signals from VoiceCall dbus objects
..

Log signals from VoiceCall dbus objects

Change-Id: I0def02b9063f75ec32c8b9382bdb12d65e1fb9eb
---
M src/osmo_gsm_tester/modem.py
1 file changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/99/12899/1

diff --git a/src/osmo_gsm_tester/modem.py b/src/osmo_gsm_tester/modem.py
index 59e2136..efb21c7 100644
--- a/src/osmo_gsm_tester/modem.py
+++ b/src/osmo_gsm_tester/modem.py
@@ -39,6 +39,7 @@
 I_CALL = 'org.ofono.VoiceCall'
 I_SS = 'org.ofono.SupplementaryServices'
 I_SIMMGR = 'org.ofono.SimManager'
+I_VOICECALL = 'org.ofono.VoiceCall'

 # See https://github.com/intgr/ofono/blob/master/doc/network-api.txt#L78
 NETREG_ST_REGISTERED = 'registered'
@@ -739,8 +740,17 @@
 self.dbg('call state: %s' % state, call_id=call_id)
 return state

+def on_voicecall_property_change(self, obj_path, name, value):
+self.dbg('%r:%r.PropertyChanged() -> %s=%s' % (obj_path, I_VOICECALL, 
name, value))
+
+def on_voicecall_disconnect_reason(self, obj_path, reason):
+self.dbg('%r:%r.DisconnectReason() -> %s' % (obj_path, I_VOICECALL, 
reason))
+
 def _on_callmgr_call_added(self, obj_path, properties):
 self.dbg('%r.CallAdded() -> %s=%r' % (I_CALLMGR, obj_path, 
repr(properties)))
+call_dbus_obj = systembus_get(obj_path)
+dbus_connect(call_dbus_obj.PropertyChanged, lambda name, value: 
self.on_voicecall_property_change(obj_path, name, value))
+dbus_connect(call_dbus_obj.DisconnectReason, lambda reason: 
self.on_voicecall_disconnect_reason(obj_path, reason))
 if obj_path not in self.call_list:
 self.call_list.append(obj_path)
 else:

--
To view, visit https://gerrit.osmocom.org/12899
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0def02b9063f75ec32c8b9382bdb12d65e1fb9eb
Gerrit-Change-Number: 12899
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in libosmocore[master]: Add multipatch capability to osmo-config-merge

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12897


Change subject: Add multipatch capability to osmo-config-merge
..

Add multipatch capability to osmo-config-merge

That's pretty straightforward and convenient extention: handle all
extra positional arguments as patch file names. This makes it similar to
'cp' and other basic tools. For example:
osmo-config-merge base.cfg patch1.cfg patch2.cfg patch3.cfg
will apply 3 patches to th base config file.

Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d
---
M utils/osmo-config-merge.c
1 file changed, 43 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/12897/1

diff --git a/utils/osmo-config-merge.c b/utils/osmo-config-merge.c
index afaf86b..b29a331 100644
--- a/utils/osmo-config-merge.c
+++ b/utils/osmo-config-merge.c
@@ -49,6 +49,7 @@
 #include 
 #include 
 #include 
+#include 

 struct node {
struct node *parent;/* back-pointer */
@@ -57,6 +58,11 @@
char *line;
 };

+struct osmo_patch_entry {
+   struct llist_head list;
+   struct node *tree;
+};
+
 /* allocate a new node */
 static struct node *node_alloc(void *ctx)
 {
@@ -225,49 +231,65 @@

 static void exit_usage(int rc)
 {
-   fprintf(stderr, "Usage: osmo-config-merge   
[--debug]\n");
+   fprintf(stderr, "Usage: osmo-config-merge  
... [--debug]\n");
exit(rc);
 }


 int main(int argc, char **argv)
 {
-   const char *base_fname, *patch_fname;
-   struct node *base_tree, *patch_tree;
+   struct node *base_tree;
+   struct osmo_config_list *trees;
+   struct osmo_patch_entry *entry;
bool debug_enabled = false;
+   unsigned i;
void *ctx;

if (argc < 3)
exit_usage(1);

-   base_fname = argv[1];
-   patch_fname = argv[2];
-
-   if (argc > 3) {
-   if (!strcmp(argv[3], "--debug"))
-   debug_enabled = true;
-   else
-   exit_usage(1);
-   }
-
ctx = talloc_named_const(NULL, 0, "root");

-   base_tree = file_read(ctx, base_fname);
-   patch_tree = file_read(ctx, patch_fname);
-
-   if (!base_tree || ! patch_tree) {
+   base_tree = file_read(ctx, argv[1]);
+   trees = talloc_zero(ctx, struct osmo_config_list);
+   if (!base_tree || !trees) {
talloc_free(ctx);
return 2;
}

+   INIT_LLIST_HEAD(>entry);
+   for (i = 2; i < argc; i++) {
+   if (!strcmp(argv[3], "--debug"))
+   debug_enabled = true;
+   else {
+   entry = talloc_zero(trees, struct osmo_patch_entry);
+   if (!entry)
+   return 3;
+
+   entry->tree = file_read(ctx, argv[i]);
+   if (!entry->tree) {
+   talloc_free(ctx);
+   return 4;
+   }
+   llist_add_tail(>list, >entry);
+   }
+   }
+
+   if (llist_empty(>entry))
+   exit_usage(1);
+
if (debug_enabled) {
fprintf(stderr, "== dumping tree (base)\n");
dump_node(base_tree, stderr, true);
-   fprintf(stderr, "== dumping tree (patch)\n");
-   dump_node(patch_tree, stderr, true);
}

-   append_patch(base_tree, patch_tree);
+   llist_for_each_entry(entry, >entry, list) {
+   append_patch(base_tree, entry->tree);
+   if (debug_enabled) {
+   fprintf(stderr, "== dumping tree (patch)\n");
+   dump_node(entry->tree, stderr, true);
+   }
+   }

if (debug_enabled)
fprintf(stderr, "== dumping tree (patched)\n");
@@ -275,7 +297,7 @@
fflush(stdout);

/* make AddressSanitizer / LeakSanitizer happy by recursively freeing 
the trees */
-   talloc_free(patch_tree);
+   talloc_free(trees);
talloc_free(base_tree);
talloc_free(ctx);


--
To view, visit https://gerrit.osmocom.org/12897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d
Gerrit-Change-Number: 12897
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-gsm-tester[master]: modem: print call ID during log of call state

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12896


Change subject: modem: print call ID during log of call state
..

modem: print call ID during log of call state

Change-Id: I33d0153b3e89aa1924129b8068ef068c08059958
---
M src/osmo_gsm_tester/modem.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/96/12896/1

diff --git a/src/osmo_gsm_tester/modem.py b/src/osmo_gsm_tester/modem.py
index 5106702..6a2a49a 100644
--- a/src/osmo_gsm_tester/modem.py
+++ b/src/osmo_gsm_tester/modem.py
@@ -735,7 +735,7 @@
 self.log('asking call state for non existent call')
 log.log_exn()
 state = 'disconnected'
-self.dbg('call state: %s' % state)
+self.dbg('call state: %s' % state, call_id=call_id)
 return state

 def _on_callmgr_call_added(self, obj_path, properties):

--
To view, visit https://gerrit.osmocom.org/12896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33d0153b3e89aa1924129b8068ef068c08059958
Gerrit-Change-Number: 12896
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-sgsn[master]: GMM: permit VLR_ANSWERED event in attach FSM

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12895

to look at the new patch set (#2).

Change subject: GMM: permit VLR_ANSWERED event in attach FSM
..

GMM: permit VLR_ANSWERED event in attach FSM

Change-Id: I14d234632224e20faf865d2273c83cfff31abf61
---
M src/gprs/gprs_gmm_attach.c
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/95/12895/2
--
To view, visit https://gerrit.osmocom.org/12895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I14d234632224e20faf865d2273c83cfff31abf61
Gerrit-Change-Number: 12895
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: OML: Store merged attributes of IPA OML Managed Objects

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12893 )

Change subject: OML: Store merged attributes of IPA OML Managed Objects
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12893
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75ebda46da9c1fcecc484311bf3833f31c536ee1
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 13 Feb 2019 16:10:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: OML: Fix encoded length value of OML GET ATTRIBUTES

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12890 )

Change subject: OML: Fix encoded length value of OML GET ATTRIBUTES
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12890
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56068de0bb14a99ec39be587e542e27cddb7d1df
Gerrit-Change-Number: 12890
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 13 Feb 2019 16:06:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: OML: Don't advertise baseband transceiver as UNLOCKED at startup

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12892 )

Change subject: OML: Don't advertise baseband transceiver as UNLOCKED at startup
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12892
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id505594b9f224567566caac84dae2e2ae4477fae
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 13 Feb 2019 16:01:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #400

[jenkins]

See 


--
[...truncated 3.83 KB...]
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking how to run the C preprocessor... gcc -E
checking for a 

Jenkins build is back to normal : master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #880

[jenkins]

See 

Change in osmo-sgsn[master]: GMM: permit VLR_ANSWERED event in attach FSM

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12895


Change subject: GMM: permit VLR_ANSWERED event in attach FSM
..

GMM: permit VLR_ANSWERED event in attach FSM

Change-Id: I14d234632224e20faf865d2273c83cfff31abf61
---
M src/gprs/gprs_gmm_attach.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/95/12895/1

diff --git a/src/gprs/gprs_gmm_attach.c b/src/gprs/gprs_gmm_attach.c
index 6fdb3af..0a31a47 100644
--- a/src/gprs/gprs_gmm_attach.c
+++ b/src/gprs/gprs_gmm_attach.c
@@ -195,6 +195,9 @@
extract_subscr_hlr(ctx);
osmo_fsm_inst_state_chg(fi, ST_INIT, 0, 0);
break;
+   case E_VLR_ANSWERED:
+   /* FIXME: do we need any special handling for answer in this 
state? */
+   break;
}
 }

@@ -295,7 +298,7 @@
.action = st_iu_security_cmd,
},
[ST_ACCEPT] = {
-   .in_event_mask = X(E_ATTACH_COMPLETE_RECV),
+   .in_event_mask = X(E_ATTACH_COMPLETE_RECV) | X(E_VLR_ANSWERED),
.out_state_mask = X(ST_INIT) | X(ST_REJECT),
.name = "WaitAttachComplete",
.onenter = st_accept_on_enter,

--
To view, visit https://gerrit.osmocom.org/12895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14d234632224e20faf865d2273c83cfff31abf61
Gerrit-Change-Number: 12895
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-sgsn[master]: Improve 'show subscriber cache' vty command

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12894


Change subject: Improve 'show subscriber cache' vty command
..

Improve 'show subscriber cache' vty command

* don't use spaces when printing hex data like RAND, SRES etc to
  increase the chance that it'll fit onto single line which will improve
  readability

* don't print non-existent QoS value

Change-Id: I0a09063f30c1116803994117f49df9d02bcc9181
---
M src/gprs/sgsn_vty.c
1 file changed, 13 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/94/12894/1

diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c
index 3757c07..0147b85 100644
--- a/src/gprs/sgsn_vty.c
+++ b/src/gprs/sgsn_vty.c
@@ -749,13 +749,13 @@
at->key_seq);
if (at->vec.auth_types & OSMO_AUTH_TYPE_GSM) {
vty_out(vty, "RAND: %s, ",
-   osmo_hexdump(at->vec.rand,
+   osmo_hexdump_nospc(at->vec.rand,
 sizeof(at->vec.rand)));
vty_out(vty, "SRES: %s, ",
-   osmo_hexdump(at->vec.sres,
+   osmo_hexdump_nospc(at->vec.sres,
 sizeof(at->vec.sres)));
vty_out(vty, "Kc: %s%s",
-   osmo_hexdump(at->vec.kc,
+   osmo_hexdump_nospc(at->vec.kc,
 sizeof(at->vec.kc)), VTY_NEWLINE);
}
if (at->vec.auth_types & OSMO_AUTH_TYPE_UMTS) {
@@ -763,19 +763,22 @@
osmo_hexdump(at->vec.autn,
 sizeof(at->vec.autn)));
vty_out(vty, "RES: %s, ",
-   osmo_hexdump(at->vec.res, at->vec.res_len));
+   osmo_hexdump_nospc(at->vec.res, 
at->vec.res_len));
vty_out(vty, "IK: %s, ",
-   osmo_hexdump(at->vec.ik, sizeof(at->vec.ik)));
+   osmo_hexdump_nospc(at->vec.ik, 
sizeof(at->vec.ik)));
vty_out(vty, "CK: %s, ",
-   osmo_hexdump(at->vec.ck, sizeof(at->vec.ck)));
+   osmo_hexdump_nospc(at->vec.ck, 
sizeof(at->vec.ck)));
}
}

llist_for_each_entry(pdp, >sgsn_data->pdp_list, list) {
-   vty_out(vty, "PDP info: Id: %d, Type: 0x%04x, APN: '%s' 
QoS: %s%s",
-   pdp->context_id, pdp->pdp_type, pdp->apn_str,
-   osmo_hexdump(pdp->qos_subscribed, 
pdp->qos_subscribed_len),
-   VTY_NEWLINE);
+   vty_out(vty, "PDP info: Id: %d, Type: 0x%04x, APN: '%s'",
+   pdp->context_id, pdp->pdp_type, pdp->apn_str);
+
+   if (pdp->qos_subscribed_len)
+   vty_out(vty, " QoS: %s", 
osmo_hexdump(pdp->qos_subscribed, pdp->qos_subscribed_len));
+
+   vty_out(vty, "%s", VTY_NEWLINE);
}

 #if 0

--
To view, visit https://gerrit.osmocom.org/12894
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a09063f30c1116803994117f49df9d02bcc9181
Gerrit-Change-Number: 12894
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in libosmocore[master]: add OSMO_STRBUF_PRINTF()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12880 )

Change subject: add OSMO_STRBUF_PRINTF()
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12880/2/include/osmocom/core/utils.h
File include/osmocom/core/utils.h:

https://gerrit.osmocom.org/#/c/12880/2/include/osmocom/core/utils.h@153
PS2, Line 153:  size_t len_needed;
the members might need a quick comment, at least the len_needed isn't 
immediately obvious.



--
To view, visit https://gerrit.osmocom.org/12880
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2497514e26c5e7a5d88985fc7e58343be1a027b2
Gerrit-Change-Number: 12880
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-CC: Max 
Gerrit-Comment-Date: Wed, 13 Feb 2019 12:59:17 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: get_value_string(): guard against NULL

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12879 )

Change subject: get_value_string(): guard against NULL
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12879
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie640e9258a959da8f4f9089478de993509853997
Gerrit-Change-Number: 12879
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Wed, 13 Feb 2019 12:59:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: add OSMO_STRBUF_PRINTF()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12880 )

Change subject: add OSMO_STRBUF_PRINTF()
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12880
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2497514e26c5e7a5d88985fc7e58343be1a027b2
Gerrit-Change-Number: 12880
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Max 
Gerrit-Comment-Date: Wed, 13 Feb 2019 12:59:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: add OSMO_STRBUF_PRINTF()

[Neels Hofmeyr]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12880

to look at the new patch set (#3).

Change subject: add OSMO_STRBUF_PRINTF()
..

add OSMO_STRBUF_PRINTF()

We are using macros like this or different workarounds in libmsc. In the course
of implementing inter-MSC handover, I am encountering yet another such
situation of appending multiple strings to a limited char buffer. Standardize.

Add a unit test to utils_test.c.

Change-Id: I2497514e26c5e7a5d88985fc7e58343be1a027b2
---
M include/osmocom/core/utils.h
M tests/utils/utils_test.c
M tests/utils/utils_test.ok
3 files changed, 188 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/12880/3
--
To view, visit https://gerrit.osmocom.org/12880
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2497514e26c5e7a5d88985fc7e58343be1a027b2
Gerrit-Change-Number: 12880
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Max 

Jenkins build is back to normal : master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #8680

[jenkins]

See 

Change in libosmo-sccp[master]: osmo_ss7.c: fix typo

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12889 )

Change subject: osmo_ss7.c: fix typo
..

osmo_ss7.c: fix typo

Change-Id: Idd0945ef7fa5cc0caf2f35919f97e2e11691f3a3
---
M src/osmo_ss7.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 05668b0..381a53a 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1316,7 +1316,7 @@
{ SCTP_PARTIAL_DELIVERY_EVENT,  "PARTIAL_DELIVERY_EVENT" },
{ SCTP_ADAPTATION_INDICATION,   "ADAPTATION_INDICATION" },
 #ifdef SCTP_AUTHENTICATION_INDICATION
-   { SCTP_AUTHENTICATION_INDICATION, "UTHENTICATION_INDICATION" },
+   { SCTP_AUTHENTICATION_INDICATION, "AUTHENTICATION_INDICATION" },
 #endif
 #ifdef SCTP_SENDER_DRY_EVENT
{ SCTP_SENDER_DRY_EVENT,"SENDER_DRY_EVENT" },

--
To view, visit https://gerrit.osmocom.org/12889
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd0945ef7fa5cc0caf2f35919f97e2e11691f3a3
Gerrit-Change-Number: 12889
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..


Patch Set 10:

(1 comment)

https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c
File src/libmsc/gsm_09_11.c:

https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@153
PS10, Line 153: if (conn->network->ncss_guard_timeout > 0) {
> Hmm, I am not sure if we really need to care about changing the configuration 
> at run-time...
it is a valid scenario to change the timeout at runtime in the VTY.  However, I 
don't think it's required to affect all ongoing NCSS sessions.  It's sufficient 
if all newly-established NCSS sessions are affected by the new timer.



--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 10
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Wed, 13 Feb 2019 12:56:11 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: install: keep existing / modified etc/osmocom/*.cfg files

[Neels Hofmeyr]

Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/12861 )

Change subject: install: keep existing / modified etc/osmocom/*.cfg files
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/12861
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I95c9b5dc6117b3dd7a095b34437f5030a141c93b
Gerrit-Change-Number: 12861
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-msc[master]: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12843 )

Change subject: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()
..

libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

According to GSM 04.80, section 2.5.1, Release complete message
may have an optional Cause IE. Let's add a new function, that
allows to specify cause location and value.

This function will be used by the upcoming changes.

Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
Depends Change-Id: (libosmocore) Ie3ac85fcef90a5e532334ba3482804d5305c88d7
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
2 files changed, 31 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/msc/gsm_04_80.h b/include/osmocom/msc/gsm_04_80.h
index 073794b..b786dcc 100644
--- a/include/osmocom/msc/gsm_04_80.h
+++ b/include/osmocom/msc/gsm_04_80.h
@@ -12,3 +12,6 @@
 const char *text);
 int msc_send_ussd_release_complete(struct ran_conn *conn,
   uint8_t transaction_id);
+int msc_send_ussd_release_complete_cause(struct ran_conn *conn,
+uint8_t transaction_id,
+uint8_t cause_loc, uint8_t cause_val);
diff --git a/src/libmsc/gsm_04_80.c b/src/libmsc/gsm_04_80.c
index 502848f..e3547f4 100644
--- a/src/libmsc/gsm_04_80.c
+++ b/src/libmsc/gsm_04_80.c
@@ -86,3 +86,31 @@
return -1;
return msc_tx_dtap(conn, msg);
 }
+
+int msc_send_ussd_release_complete_cause(struct ran_conn *conn,
+uint8_t transaction_id,
+uint8_t cause_loc, uint8_t cause_val)
+{
+   struct msgb *msg;
+   uint8_t *cause_ie;
+
+   msg = gsm0480_create_release_complete(transaction_id);
+   if (!msg)
+   return -1;
+
+   /* Encode cause IE (see GSM 04.08, section 10.5.4.11)
+* with fixed length (2 bytes of TL, 2 bytes of payload).
+* NOTE: we don't use gsm48_encode_cause() API because
+* it wants gsm_mncc_cause struct from us. */
+   cause_ie = msgb_put(msg, 2 + 2);
+   cause_ie[0] = GSM48_IE_CAUSE;
+   cause_ie[1] = 2;
+
+   /* Coding standard defined for the GSM PLMNs,
+* location and cause: as given by caller,
+* no extension, no diagnostics. */
+   cause_ie[2] = (1 << 7) | (0x03 << 5) | (cause_loc & 0x0f);
+   cause_ie[3] = (1 << 7) | cause_val;
+
+   return msc_tx_dtap(conn, msg);
+}

--
To view, visit https://gerrit.osmocom.org/12843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
Gerrit-Change-Number: 12843
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 

Change in osmo-msc[master]: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12840 )

Change subject: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()
..

libmsc/gsm_04_80.c: use gsm0480_create_release_complete()

The previous implementation of msc_send_ussd_release_complete() was
based on gsm0480_create_ussd_release_complete(), that doesn't
allow to specify GSM 04.07 transaction identifier.

The ability to specify particular transaction identifier
is required for handling multiple SS/USSD transactions.

Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb
Depends Change-Id: (libosmocore) Ie3ac85fcef90a5e532334ba3482804d5305c88d7
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
M src/libmsc/msc_vty.c
3 files changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/msc/gsm_04_80.h b/include/osmocom/msc/gsm_04_80.h
index 29b800b..073794b 100644
--- a/include/osmocom/msc/gsm_04_80.h
+++ b/include/osmocom/msc/gsm_04_80.h
@@ -10,4 +10,5 @@

 int msc_send_ussd_notify(struct ran_conn *conn, int level,
 const char *text);
-int msc_send_ussd_release_complete(struct ran_conn *conn);
+int msc_send_ussd_release_complete(struct ran_conn *conn,
+  uint8_t transaction_id);
diff --git a/src/libmsc/gsm_04_80.c b/src/libmsc/gsm_04_80.c
index 119f0e1..502848f 100644
--- a/src/libmsc/gsm_04_80.c
+++ b/src/libmsc/gsm_04_80.c
@@ -78,9 +78,10 @@
return msc_tx_dtap(conn, msg);
 }

-int msc_send_ussd_release_complete(struct ran_conn *conn)
+int msc_send_ussd_release_complete(struct ran_conn *conn,
+  uint8_t transaction_id)
 {
-   struct msgb *msg = gsm0480_create_ussd_release_complete();
+   struct msgb *msg = gsm0480_create_release_complete(transaction_id);
if (!msg)
return -1;
return msc_tx_dtap(conn, msg);
diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index e1019a2..078b83a 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -1149,7 +1149,9 @@
}

msc_send_ussd_notify(conn, level, text);
-   msc_send_ussd_release_complete(conn);
+   /* FIXME: since we don't allocate a transaction here,
+* we use dummy GSM 04.07 transaction ID. */
+   msc_send_ussd_release_complete(conn, 0x00);

vlr_subscr_put(vsub);
talloc_free(text);

--
To view, visit https://gerrit.osmocom.org/12840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb
Gerrit-Change-Number: 12840
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 

Change in libosmocore[master]: add OSMO_STRBUF_PRINTF()

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12880 )

Change subject: add OSMO_STRBUF_PRINTF()
..


Patch Set 2:

but it seems this pragma doesn't exist everywhere, I'm going to think of 
another way to test writing past the end.

jenkins:

utils_test.c:941:32: error: unknown option after ‘#pragma GCC diagnostic’ 
kind [-Werror=pragmas]
 #pragma GCC diagnostic ignored "-Wformat-truncation"
^


--
To view, visit https://gerrit.osmocom.org/12880
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2497514e26c5e7a5d88985fc7e58343be1a027b2
Gerrit-Change-Number: 12880
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Max 
Gerrit-Comment-Date: Wed, 13 Feb 2019 12:40:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: add OSMO_STRBUF_PRINTF()

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12880 )

Change subject: add OSMO_STRBUF_PRINTF()
..


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/12880/2/tests/utils/utils_test.c
File tests/utils/utils_test.c:

https://gerrit.osmocom.org/#/c/12880/2/tests/utils/utils_test.c@941
PS2, Line 941: #pragma GCC diagnostic ignored "-Wformat-truncation"
> Why is this necessary? Do we have to use it every time alongside with 
> OSMO_STRBUF_* as well?
I am deliberately testing to write past a buffer's end, with a locally defined 
buffer, here: ...


https://gerrit.osmocom.org/#/c/12880/2/tests/utils/utils_test.c@958
PS2, Line 958:  char buf[23];
... and gcc then thinks that it must check the buffer bounds and warn that 
snprintf() will write past the buffer. Above compiler directive tells it that 
this is exactly what I want to test and it shouldn't bother checking the bounds 
for me.



--
To view, visit https://gerrit.osmocom.org/12880
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2497514e26c5e7a5d88985fc7e58343be1a027b2
Gerrit-Change-Number: 12880
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Max 
Gerrit-Comment-Date: Wed, 13 Feb 2019 12:37:56 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmocom-bb[master]: firmware/board: introduce new FCDEV3B (FreeCalypso) target

[Vadim Yanitskiy]

Hello Max, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12888

to look at the new patch set (#3).

Change subject: firmware/board: introduce new FCDEV3B (FreeCalypso) target
..

firmware/board: introduce new FCDEV3B (FreeCalypso) target

FCDEV3B (stands for "FreeCalypso development board, triband") is a
GSM mobile station development board by FreeCalypso project. The
board features the same legendary TI Calypso GSM MS chipset that
was used in commercial GSM/GPRS modems such as Openmoko's, and
functions as a standalone (or "bare") GSM modem.

For more information, please see the project's web side:

  https://www.freecalypso.org/fcdev3b.html.

Change-Id: I09bd35a18d3ea09450169a62fd82ba6eccfe
Related: OS#3581
---
M src/target/firmware/Makefile
A src/target/firmware/board/fcdev3b/init.c
2 files changed, 157 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/88/12888/3
--
To view, visit https://gerrit.osmocom.org/12888
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09bd35a18d3ea09450169a62fd82ba6eccfe
Gerrit-Change-Number: 12888
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in osmocom-bb[master]: firmware/lib: introduce TIFFS filesystem support

[Vadim Yanitskiy]

Hello Max, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12885

to look at the new patch set (#2).

Change subject: firmware/lib: introduce TIFFS filesystem support
..

firmware/lib: introduce TIFFS filesystem support

All known TI GSM firmwares implement some kind of flash file system, or FFS.
We call it TIFFS (Texas Instruments FFS) because it is TI's invention.

TIFFS is a file system with a hierarchical directory tree structure, and
with Unixy forward-slash-separated, case-sensitive pathnames; the semantics
of "what is a file" and "what is a directory" are exactly the same as in
UNIX; and TIFFS even supports symlinks, although that support is a little
under-developed, and apparently no FFS symlinks were ever used in any
production GSM device. Thus the FFS implemented in TI-based GSM devices
(modems and "dumbphone" handsets) is really no different from, for example,
JFFS2 in embedded Linux systems.

The FFS in a GSM device typically stores two kinds of content:

  - Factory data: IMEI, RF calibration values, device make/model/revision
ID strings etc.  These files are expected to be programmed on the
factory production line and not changed afterward.

  - Dynamic data written into the FFS in normal device operation: contacts,
settings / preferences, call history, received SMS, etc.

It should be noted that both Compal (Mot C1xx) and Foxconn (Pirelli DP-L10)
vendors moved their vital per-unit factory data out of the FFS into their
own ad hoc flash data structures, leaving their FFS only for less
critical data. However, we do enable TIFFS access for them anyway.

The location of TIFFS within the flash memory of a given GSM device is
defined by the firmware design of that device, but is always some integral
number of contiguous flash sectors.

  - On Motorola/Compal C139/140 phones, the FFS used by the original
proprietary firmware occupies 5 sectors of 64 KiB each (320 KiB
in total), starting at 0x37. C11x/123 use smaller FFS
configurations, whereas C155/156 seem to have switched to some
other FFS format, different from our familiar TIFFS.

  - On the Pirelli DP-L10, the FFS used by the original proprietary
firmware occupies 18 sectors of 256 KiB each (for 4.5 MiB in total),
starting at the beginning of the 2nd flash chip select (0x0200
in the ARM7 address space).

  - On FCDEV3B (FreeCalypso hardware), the FFS is located in the first
8 sectors (of 256 KiB each) in the 2nd flash chip select bank,
which appears at 0x0180 in the ARM7 address space.

  - On the GTA01/02 GSM modem, FFS occupies 7 sectors of 64 KiB each,
starting at flash offset 0x38.

For more information, please refer to the FreeCalypso project
documentation, from where this great contribution comes from.

Please note that existing MediaTek targets most likely use different
storage format as they have nothing from TI Calypso. Also, we don't
(yet) know the location of TIFFS on SE J100i and some other
Compal Exx platforms.

The TIFFS support is needed for the follow-up change, that
implements reading of the factory RF calibration values.

Tweaked (coding style changes) by Vadim Yanitskiy 
Change-Id: If6e212baeb10953129fb0d5253d263567f5e12d6
Related: OS#3582
---
M src/target/firmware/Makefile
M src/target/firmware/board/compal_e86/init.c
M src/target/firmware/board/fcdev3b/init.c
M src/target/firmware/board/gta0x/init.c
M src/target/firmware/board/pirelli_dpl10/init.c
M src/target/firmware/include/string.h
A src/target/firmware/include/tiffs.h
M src/target/firmware/lib/Makefile
A src/target/firmware/lib/index.c
A src/target/firmware/lib/memcmp.S
A src/target/firmware/lib/strcmp.c
A src/target/firmware/tiffs/Makefile
A src/target/firmware/tiffs/globals.c
A src/target/firmware/tiffs/globals.h
A src/target/firmware/tiffs/init.c
A src/target/firmware/tiffs/readfile.c
16 files changed, 491 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/85/12885/2
--
To view, visit https://gerrit.osmocom.org/12885
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If6e212baeb10953129fb0d5253d263567f5e12d6
Gerrit-Change-Number: 12885
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in osmocom-bb[master]: firmware/board/compal: indicate both DCS and PCS Rx ports as connected

[Vadim Yanitskiy]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12884

to look at the new patch set (#2).

Change subject: firmware/board/compal: indicate both DCS and PCS Rx ports as 
connected
..

firmware/board/compal: indicate both DCS and PCS Rx ports as connected

Each given Mot C1xx phone is made either for 900+1800 MHz, in which
case only the DCS Rx port is connected, or for 850+1900 MHz, in which
case only the PCS Rx port is connected. Let's tell the TRF6151 driver
that both DCS and PCS ports are connected, so that the same binary
build can be used on both EU-band and US-band C1xx phones.

If one needs to tune the TRF6151 receiver out of spec, or at least
outside of the DCS/PCS Rx SAW filter's legitimate passband (or if
the SAW filter was changed or removed), then the rffe_get_rx_ports()
function might be changed to indicate which Rx port is physically
connected: PORT_DCS1800 only or PORT_PCS1900 only.

Change-Id: I620084c33ad165faffbbfc45923faedad77aafb2
---
M src/target/firmware/board/compal/rffe_dualband.c
M src/target/firmware/board/compal_e86/rffe_dualband_e86.c
2 files changed, 44 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/84/12884/2
--
To view, visit https://gerrit.osmocom.org/12884
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I620084c33ad165faffbbfc45923faedad77aafb2
Gerrit-Change-Number: 12884
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #8679

[jenkins]

See 


--
[...truncated 23.08 KB...]
  CC   bits.lo
  CC   bitcomp.lo
  CC   counter.lo
  CC   fsm.lo
  CC   write_queue.lo
  CC   utils.lo
  CC   socket.lo
  CC   logging.lo
  CC   logging_syslog.lo
  CC   rate_ctr.lo
  CC   logging_gsmtap.lo
  CC   gsmtap_util.lo
  CC   crc16.lo
  CC   panic.lo
  CC   backtrace.lo
  CC   conv.lo
  CC   application.lo
  CC   rbtree.lo
  CC   strrb.lo
  CC   loggingrb.lo
  CC   crc8gen.lo
  CC   crc16gen.lo
  CC   crc32gen.lo
  CC   crc64gen.lo
  CC   macaddr.lo
  CC   stat_item.lo
  CC   stats.lo
  CC   stats_statsd.lo
  CC   prim.lo
  CC   conv_acc.lo
  CC   conv_acc_generic.lo
  CC   sercomm.lo
  CC   prbs.lo
  CC   isdnhdlc.lo
  CC   conv_acc_sse.lo
  CC   tdef.lo
  CC   conv_acc_sse_avx.lo
  CC   plugin.lo
  CC   msgfile.lo
  CC   serial.lo
  CCLD libosmocore.la
make[4]: Entering directory '/build/deps/libosmocore/src'
make[4]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../libtool   --mode=install /usr/bin/install -c   libosmocore.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: /usr/bin/install -c .libs/libosmocore.so.12.0.1 
/build/deps/install/stow/libosmocore/lib/libosmocore.so.12.0.1
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocore.so.12.0.1 libosmocore.so.12 || { rm -f libosmocore.so.12 && ln -s 
libosmocore.so.12.0.1 libosmocore.so.12; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocore.so.12.0.1 libosmocore.so || { rm -f libosmocore.so && ln -s 
libosmocore.so.12.0.1 libosmocore.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocore.lai 
/build/deps/install/stow/libosmocore/lib/libosmocore.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[4]: Leaving directory '/build/deps/libosmocore/src'
make[3]: Leaving directory '/build/deps/libosmocore/src'
make[2]: Leaving directory '/build/deps/libosmocore/src'
Making install in src/vty
make[2]: Entering directory '/build/deps/libosmocore/src/vty'
  CC   buffer.lo
  CC   command.lo
  CC   logging_vty.lo
  CC   telnet_interface.lo
  CC   utils.lo
  CC   vty.lo
  CC   vector.lo
  CC   stats_vty.lo
  CC   talloc_ctx_vty.lo
  CC   fsm_vty.lo
  CC   tdef_vty.lo
  CCLD libosmovty.la
make[3]: Entering directory '/build/deps/libosmocore/src/vty'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmovty.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmovty.la'
libtool: install: (cd /build/deps/libosmocore/src/vty; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE -Wall -version-info 6:0:2 -no-undefined -o 
libosmovty.la -rpath /build/deps/install/stow/libosmocore/lib buffer.lo 
command.lo vty.lo vector.lo utils.lo telnet_interface.lo logging_vty.lo 
stats_vty.lo fsm_vty.lo talloc_ctx_vty.lo tdef_vty.lo ../../src/libosmocore.la 
-ltalloc )
libtool: install: /usr/bin/install -c .libs/libosmovty.so.4.2.0T 
/build/deps/install/stow/libosmocore/lib/libosmovty.so.4.2.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmovty.so.4.2.0 libosmovty.so.4 || { rm -f libosmovty.so.4 && ln -s 
libosmovty.so.4.2.0 libosmovty.so.4; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmovty.so.4.2.0 libosmovty.so || { rm -f libosmovty.so && ln -s 
libosmovty.so.4.2.0 libosmovty.so; }; })

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #879

[jenkins]

See 


--
[...truncated 107.30 KB...]
Searching INPUT for files to process...
Reading and parsing tag files
Parsing files
Building group list...
Building directory list...
Building namespace list...
Building file list...
Building class list...
Associating documentation with classes...
Computing nesting relations for classes...
Building example list...
Searching for enumerations...
Searching for documented typedefs...
Searching for members imported via using declarations...
Searching for included using directives...
Searching for documented variables...
Building interface member list...
Building member list...
Searching for friends...
Searching for documented defines...
Computing class inheritance relations...
Computing class usage relations...
Flushing cached template relations that have become invalid...
Computing class relations...
Add enum values to enums...
Searching for member function documentation...
Creating members for template instances...
Building page list...
Search for main page...
Computing page relations...
Determining the scope of groups...
Sorting lists...
Freeing entry tree
Determining which enums are documented
Computing member relations...
Building full member lists recursively...
Adding members to member groups.
Computing member references...
Inheriting documentation...
Generating disk names...
Adding source references...
Adding xrefitems...
Sorting member lists...
Computing dependencies between directories...
Generating citations page...
Counting data structures...
Resolving user defined references...
Finding anchors and sections in the documentation...
Transferring function references...
Combining using relations...
Adding members to index pages...
Generating style sheet...
Generating search indices...
Generating example documentation...
Generating file sources...
Generating file documentation...
Generating page documentation...
Generating group documentation...
Generating class documentation...
Generating namespace index...
Generating graph info page...
Generating directory documentation...
Generating index page...
Generating page index...
Generating module index...
Generating namespace index...
Generating namespace member index...
Generating annotated compound index...
Generating alphabetical compound index...
Generating hierarchical class index...
Generating graphical class hierarchy...
Generating member index...
Generating file index...
Generating file member index...
Generating example index...
finalizing index lists...
writing tag file...
Running dot...
Running dot for graph 1/1
lookup cache used 0/65536 hits=0 misses=0
finished...
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p 

 /bin/mkdir -p 
'
/usr/bin/install -c -m 644 usrp_guide.html 

 /usr/bin/install -c -m 644 ../README 
'
cp -r html 

make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in firmware
make[2]: Entering directory 

Change in osmo-msc[master]: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12843 )

Change subject: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9e8e4f473d113d5b9e9e5d33f7914202077203
Gerrit-Change-Number: 12843
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 13 Feb 2019 09:37:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12840 )

Change subject: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12840
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb
Gerrit-Change-Number: 12840
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 13 Feb 2019 09:34:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes