Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions ...................................................................... Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c File src/libmsc/gsm_09_11.c: https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@153 PS10, Line 153: if (conn->network->ncss_guard_timeout > 0) { > Hmm, I am not sure if we really need to care about changing the configuration > at run-time... it is a valid scenario to change the timeout at runtime in the VTY. However, I don't think it's required to affect all ongoing NCSS sessions. It's sufficient if all newly-established NCSS sessions are affected by the new timer. -- To view, visit https://gerrit.osmocom.org/11992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb Gerrit-Change-Number: 11992 Gerrit-PatchSet: 10 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Wed, 13 Feb 2019 12:56:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
