date:20190221

Change in libosmocore[master]: gsm0808: make msgb size and headroom configurable

2019-02-21 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/13004


Change subject: gsm0808: make msgb size and headroom configurable
..

gsm0808: make msgb size and headroom configurable

Allow for manual configuration of buffer size and headroom by exposing
osmo_gsm0808_msg_size and osmo_gsm0808_msg_headroom; if unset (remaining 0),
the current defaults remain in effect.

In osmo-msc, I would like to prepend an osmo_prim to the msgb created by
gsm0808 API, but turns out the headroom is too small:

msgb(0x6171b660): Not enough headroom msgb_push (126 < 264)

Instead of always copying a msgb that has just that instant been created, it
makes more sense to allocate sufficient headroom in the first place. The
gsm0808 API allocates msgb implicitly, this is the least impact fix.

Compat: the BSSMAP_MSG_SIZE and BSSMAP_HEADROOM_SIZE can no longer be used as
constants, e.g. to initialize the size of static things. They should only ever
be used with msgb_alloc_headroom(), so I assert that this is fine.
I am not sure why these #defines are in the public header in the first place,
but since they are, keep them there and make them reflect the actually used
sizes.

Change-Id: I95729991eb49555f8bba60c5dc916131b03b6cf2
---
M TODO-RELEASE
M include/osmocom/gsm/gsm0808.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
4 files changed, 12 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/13004/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 8ccfa49..9bf5b03 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,4 @@
 # If any interfaces have been added since the last public release: c:r:a + 1.
 # If any interfaces have been removed or changed since the last public 
release: c:r:0.
 #library   whatdescription / commit summary line
+gsmgsm0808.h   GSM0808_MSG_SIZE and 
GSM0808_MSG_HEADROOM are no longer compile-time constant numbers
diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 35e7a8e..dfab29a 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -29,8 +29,12 @@
 #include 
 #include 

-#define BSSMAP_MSG_SIZE 512
-#define BSSMAP_MSG_HEADROOM 128
+#define BSSMAP_MSG_DEFAULT_SIZE 512
+#define BSSMAP_MSG_DEFAULT_HEADROOM 128
+extern size_t osmo_gsm0808_msg_size;
+extern size_t osmo_gsm0808_msg_headroom;
+#define BSSMAP_MSG_HEADROOM (osmo_gsm0808_msg_headroom ? : 
BSSMAP_MSG_DEFAULT_HEADROOM)
+#define BSSMAP_MSG_SIZE (osmo_gsm0808_msg_size ? : BSSMAP_MSG_DEFAULT_SIZE - 
BSSMAP_MSG_DEFAULT_HEADROOM + BSSMAP_MSG_HEADROOM)

 struct sockaddr_storage;

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 4873076..ff17bd2 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -27,6 +27,9 @@
 #include 
 #include 

+size_t osmo_gsm0808_msg_size = 0;
+size_t osmo_gsm0808_msg_headroom = 0;
+
 /*! \addtogroup gsm0808
  *  @{
  *  \file gsm0808.c
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 48757a7..525fa0d 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -228,6 +228,8 @@
 gsm0808_lcls_status_names;
 gsm0808_enc_lcls;
 gsm0808_dec_lcls;
+osmo_gsm0808_msg_size;
+osmo_gsm0808_msg_headroom;

 gsm29118_msgb_alloc;
 gsm29118_create_alert_req;

--
To view, visit https://gerrit.osmocom.org/13004
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95729991eb49555f8bba60c5dc916131b03b6cf2
Gerrit-Change-Number: 13004
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Build failure of network:osmocom:nightly/libosmo-netif in Raspbian_9.0/armv7l

2019-02-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Raspbian_9.0/armv7l

Package network:osmocom:nightly/libosmo-netif failed to build in 
Raspbian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-netif

Last lines of build log:
[   16s] [68/71] preinstalling sysvinit-utils...
[   16s] [69/71] preinstalling e2fsprogs...
[   16s] [70/71] preinstalling sysv-rc...
[   16s] [71/71] preinstalling initscripts...
[   16s] 
[   17s] [1/1] preinstalling libdevmapper1.02.1...
[   18s] copying packages...
[   25s] reordering...cycle: libc6 -> libgcc1
[   25s]   breaking dependency libgcc1 -> libc6
[   25s] cycle: debhelper -> dh-autoreconf
[   25s]   breaking dependency debhelper -> dh-autoreconf
[   25s] cycle: dh-strip-nondeterminism -> debhelper
[   25s]   breaking dependency debhelper -> dh-strip-nondeterminism
[   25s] done
[   25s] objdump: /boot/Image.guest32: file format not recognized
[   25s] Warning: cross compile not possible due to missing static binaries. 
please install build-initvm package for that purpose.
[   25s]  check that the right architecture is available for your build 
host, you need initvm.armv8l for this one.
[   29s] booting kvm...
[   29s] ### VM INTERACTION START ###
[   29s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga 
none -cpu host,aarch64=off -enable-kvm -M virt,gic-version=host -object 
rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 
-runas qemu -mem-prealloc -mem-path /dev/hugepages -net none -kernel 
/boot/Image.guest32 -initrd /boot/initrd.guest32 -append 
root=/dev/disk/by-id/virtio-0 rootfstype=ext4 rootflags=noatime 
ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet 
no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc 
console=ttyAMA0 init=/.build/build -m 9216 -drive 
file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe 
-device virtio-blk-device,drive=disk,serial=0 -drive 
file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe 
-device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev 
socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor
 -mon chardev=monitor,mode=readline -smp 6
[  338s] ### WATCHDOG TRIGGERED, KILLING VM ###
[  339s] /var/cache/obs/worker/root_5/root: 14396
[  339s] qemu-system-aarch64: terminating on signal 15 from pid 23549 ()
[  339s] ### VM INTERACTION END ###
[  339s] /var/run/obs/worker/5/build/build-vm: line 462: kill: (14389) - No 
such process
[  339s] No buildstatus set, either the base system is broken 
(kernel/initrd/udev/glibc/bash/perl)
[  339s] or the build host has a kernel or hardware problem...

gave up after 12 failed build attempts...

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ci[master]: Add timeout wrapper to regular gerrit verification jobs

2019-02-21 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/12857 )

Change subject: Add timeout wrapper to regular gerrit verification jobs
..


Patch Set 2:

https://docs.openstack.org/infra/jenkins-job-builder/wrappers.html#wrappers.timeout


--
To view, visit https://gerrit.osmocom.org/12857
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0eb6b9eddf3e17120e74d7570d42291c0750ae
Gerrit-Change-Number: 12857
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 20:07:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ci[master]: Add timeout wrapper to regular gerrit verification jobs

2019-02-21 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/12857 )

Change subject: Add timeout wrapper to regular gerrit verification jobs
..


Patch Set 2:

@Max: there is also a timeout wrapper, but that might work differently. The 
jenkins timeout wrapper will terminate the whole shell, which prevents you from 
doing the cleanup in the same script.


--
To view, visit https://gerrit.osmocom.org/12857
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0eb6b9eddf3e17120e74d7570d42291c0750ae
Gerrit-Change-Number: 12857
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 20:06:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sysmon[master]: Update config example

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12992 )

Change subject: Update config example
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Gerrit-Change-Number: 12992
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 18:42:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-Comment-Date: Thu, 21 Feb 2019 18:40:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: OpenVPN: track interface disconnect

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12989 )

Change subject: OpenVPN: track interface disconnect
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b8bc71c1e9cbbf992ee3b7c1c9aae6e6f697e0
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 18:36:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: OpenVPN: track interface disconnect

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12989 )

Change subject: OpenVPN: track interface disconnect
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b8bc71c1e9cbbf992ee3b7c1c9aae6e6f697e0
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 18:36:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: select: Call log_reset_context() before calling file descriptor callb...

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12998 )

Change subject: select: Call log_reset_context() before calling file descriptor 
callbacks
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12998/1/src/select.c
File src/select.c:

https://gerrit.osmocom.org/#/c/12998/1/src/select.c@222
PS1, Line 222:  log_reset_context();
Probably doesn't change that much in practice, but I think it makes sense to 
remove it immeditelly AFTER cb is called.



--
To view, visit https://gerrit.osmocom.org/12998
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3644c7bc1a9cec5858eb0faf94efc8c3ba7f5d8d
Gerrit-Change-Number: 12998
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 21 Feb 2019 18:35:22 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: contrib: Add script to build osmo-bts and osmo-pcu for oc2g

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/13003 )

Change subject: contrib: Add script to build osmo-bts and osmo-pcu for oc2g
..

contrib: Add script to build osmo-bts and osmo-pcu for oc2g

Change-Id: I7cc8937fb3e6c5d74b56cb049afb293b0b7ed25e
---
A contrib/jenkins-build-osmo-bts-oc2g.sh
A contrib/jenkins-build-osmo-pcu-oc2g.sh
2 files changed, 55 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/03/13003/2
--
To view, visit https://gerrit.osmocom.org/13003
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cc8937fb3e6c5d74b56cb049afb293b0b7ed25e
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: contrib: Add script to build osmo-bts-oc2g

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/13003


Change subject: contrib: Add script to build osmo-bts-oc2g
..

contrib: Add script to build osmo-bts-oc2g

Change-Id: I7cc8937fb3e6c5d74b56cb049afb293b0b7ed25e
---
A contrib/jenkins-build-osmo-bts-oc2g.sh
A contrib/jenkins-build-osmo-pcu-oc2g.sh
2 files changed, 55 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/03/13003/1

diff --git a/contrib/jenkins-build-osmo-bts-oc2g.sh 
b/contrib/jenkins-build-osmo-bts-oc2g.sh
new file mode 100755
index 000..9ed2099
--- /dev/null
+++ b/contrib/jenkins-build-osmo-bts-oc2g.sh
@@ -0,0 +1,31 @@
+#!/bin/sh
+set -e -x
+
+_poky_version="$POKY_VERSION"
+_poky_path="$POKY_PATH"
+
+[ -z "$_poky_version" ] && _poky_version="2.3.2"
+[ -z "$_poky_path" ] && _poky_path="/opt/poky/$_poky_version"
+
+. "$_poky_path/environment-setup-armv5te-poky-linux-gnueabi"
+
+# Cross-compilation: all installations need to be put in the sysmo SDK sysroot
+export DESTDIR="$_poky_path/sysroots/armv5te-poky-linux-gnueabi"
+
+base="$PWD"
+name="osmo-bts-oc2g"
+prefix="/usr/local/jenkins-build/inst-$name"
+prefix_real="$DESTDIR$prefix"
+. "$(dirname "$0")/jenkins-build-common.sh"
+
+prev_git_url="${git_url}"
+git_url="https://gitlab.com/nrw_oc2g/;
+have_repo "oc2g-fw" "nrw/oc2g"
+git_url="${prev_git_url}"
+L1_OC2G_HEADERS="$PWD/oc2g-fw/inc"
+
+build_repo libosmocore --disable-pcsc --disable-doxygen --disable-gnutls
+build_repo libosmo-abis
+build_repo osmo-bts --disable-sysmocom-bts --enable-oc2g 
--with-oc2g="$L1_OC2G_HEADERS"
+
+create_bin_tgz osmo-bts-oc2g
diff --git a/contrib/jenkins-build-osmo-pcu-oc2g.sh 
b/contrib/jenkins-build-osmo-pcu-oc2g.sh
new file mode 100755
index 000..2164926
--- /dev/null
+++ b/contrib/jenkins-build-osmo-pcu-oc2g.sh
@@ -0,0 +1,24 @@
+#!/bin/sh
+set -e -x
+
+_poky_version="$POKY_VERSION"
+_poky_path="$POKY_PATH"
+
+[ -z "$_poky_version" ] && _poky_version="2.3.2"
+[ -z "$_poky_path" ] && _poky_path="/opt/poky/$_poky_version"
+
+. "$_poky_path/environment-setup-armv5te-poky-linux-gnueabi"
+
+# Cross-compilation: all installations need to be put in the sysmo SDK sysroot
+export DESTDIR="$_poky_path/sysroots/armv5te-poky-linux-gnueabi"
+
+base="$PWD"
+name="osmo-pcu-oc2g"
+prefix="/usr/local/jenkins-build/inst-$name"
+prefix_real="$DESTDIR$prefix"
+. "$(dirname "$0")/jenkins-build-common.sh"
+
+build_repo libosmocore --disable-pcsc --disable-doxygen --disable-gnutls
+build_repo osmo-pcu --disable-sysmocom-dsp
+
+create_bin_tgz osmo-pcu

--
To view, visit https://gerrit.osmocom.org/13003
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cc8937fb3e6c5d74b56cb049afb293b0b7ed25e
Gerrit-Change-Number: 13003
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-ci[master]: jobs: osmo-gsm-tester: Add oc2g jobs

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/13002


Change subject: jobs: osmo-gsm-tester: Add oc2g jobs
..

jobs: osmo-gsm-tester: Add oc2g jobs

Change-Id: I5ea9b783a2a2017cb134e72087e217a4184184b2
---
M jobs/osmo-gsm-tester-builder.yml
M jobs/osmo-gsm-tester-runner.yml
M jobs/osmo-gsm-tester-trigger.yml
3 files changed, 13 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/02/13002/1

diff --git a/jobs/osmo-gsm-tester-builder.yml b/jobs/osmo-gsm-tester-builder.yml
index 1b522fc..89ca203 100644
--- a/jobs/osmo-gsm-tester-builder.yml
+++ b/jobs/osmo-gsm-tester-builder.yml
@@ -25,6 +25,10 @@
   triggered-by: master-osmo-bts
   - osmo-pcu-sysmo:
   triggered-by: master-osmo-pcu
+  - osmo-bts-oc2g:
+  triggered-by: master-osmo-bts
+  - osmo-pcu-oc2g:
+  triggered-by: master-osmo-pcu
 triggered-by: 'master-{repo}'

 jobs:
diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml
index e0cfe40..c9d84a3 100644
--- a/jobs/osmo-gsm-tester-runner.yml
+++ b/jobs/osmo-gsm-tester-runner.yml
@@ -82,6 +82,10 @@
  repo: osmo-gsm-tester_build-osmo-bts-sysmo
   - copy_artifact:
  repo: osmo-gsm-tester_build-osmo-pcu-sysmo
+  - copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-bts-oc2g
+  - copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-pcu-oc2g

 - defaults:
 name: runner
@@ -122,6 +126,8 @@
 - osmo-gsm-tester_build-osmo-stp
 - osmo-gsm-tester_build-osmo-bts-sysmo
 - osmo-gsm-tester_build-osmo-pcu-sysmo
+- osmo-gsm-tester_build-osmo-bts-oc2g
+- osmo-gsm-tester_build-osmo-pcu-oc2g
 builders:
   - copy_artifact_all
   - shell: !include-raw: osmo-gsm-tester_run-{stage}.sh
diff --git a/jobs/osmo-gsm-tester-trigger.yml b/jobs/osmo-gsm-tester-trigger.yml
index aa24a4e..43298dc 100644
--- a/jobs/osmo-gsm-tester-trigger.yml
+++ b/jobs/osmo-gsm-tester-trigger.yml
@@ -26,4 +26,6 @@
 osmo-gsm-tester_build-osmo-nitb,
 osmo-gsm-tester_build-osmo-stp,
 osmo-gsm-tester_build-osmo-bts-sysmo,
-osmo-gsm-tester_build-osmo-pcu-sysmo
+osmo-gsm-tester_build-osmo-pcu-sysmo,
+osmo-gsm-tester_build-osmo-bts-oc2g,
+osmo-gsm-tester_build-osmo-pcu-oc2g

--
To view, visit https://gerrit.osmocom.org/13002
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ea9b783a2a2017cb134e72087e217a4184184b2
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

2019-02-21 Thread tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-Comment-Date: Thu, 21 Feb 2019 17:16:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: RTP_Emulation: check received RTP packets

2019-02-21 Thread dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13000


Change subject: RTP_Emulation: check received RTP packets
..

RTP_Emulation: check received RTP packets

The configuration of the RTP Emulation (RtpemConfig) allows to set a
fixed RTP payload that is then used when RTP packets are transmitted.
However, when packets are received, then the payload is not checked.
Lets check the received data against some user configurable rx payload,
that is by default set to the tx payload.

Change-Id: Id0b125aaf915497d0a4f051af890fc34e09da61d
Related: OS#3807
---
M library/RTP_Emulation.ttcn
1 file changed, 14 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/00/13000/1

diff --git a/library/RTP_Emulation.ttcn b/library/RTP_Emulation.ttcn
index fcb158b..b8f0ce4 100644
--- a/library/RTP_Emulation.ttcn
+++ b/library/RTP_Emulation.ttcn
@@ -119,7 +119,9 @@
/* number of packets received wrong payload type */
integer num_pkts_rx_err_pt,
/* number of packets received during Rx disable */
-   integer num_pkts_rx_err_disabled
+   integer num_pkts_rx_err_disabled,
+   /* number of packets received with mismatching payload */
+   integer num_pkts_rx_err_payload
 }

 const RtpemStats c_RtpemStatsReset := {
@@ -130,7 +132,8 @@
num_pkts_rx_err_seq := 0,
num_pkts_rx_err_ts := 0,
num_pkts_rx_err_pt := 0,
-   num_pkts_rx_err_disabled := 0
+   num_pkts_rx_err_disabled := 0,
+   num_pkts_rx_err_payload := 0
 }

 type record RtpemConfig {
@@ -139,6 +142,7 @@
integer tx_duration_ms,
BIT32_BO_LAST tx_ssrc,
octetstring tx_fixed_payload optional,
+   octetstring rx_fixed_payload optional,
boolean iuup_mode,
boolean iuup_tx_init
 };
@@ -149,6 +153,7 @@
tx_duration_ms := 20,
tx_ssrc := '11001010110110101110'B,
tx_fixed_payload := '01020304'O,
+   rx_fixed_payload := '01020304'O,
iuup_mode := false,
iuup_tx_init := true
 }
@@ -276,6 +281,10 @@
setverdict(fail, "RTP packets received while RX was disabled");
mtc.stop;
}
+   if (s.num_pkts_rx_err_payload != 0) {
+   setverdict(fail, "RTP packets with mismatching payload 
received");
+   mtc.stop;
+   }
 }

 template PDU_RTP ts_RTP(BIT32_BO_LAST ssrc, INT7b pt, LIN2_BO_LAST seq, 
uint32_t ts,
@@ -437,8 +446,6 @@

/* process received RTCP/RTP if receiver enabled */
[g_rx_enabled] RTP.receive(tr_rtp) -> value rx_rtp {
-   //log("RX RTP: ", rx_rtp);
-
/* increment counters */
if (rx_rtp.msg.rtp.payload_type != 
g_cfg.tx_payload_type) {
g_stats_rtp.num_pkts_rx_err_pt := 
g_stats_rtp.num_pkts_rx_err_pt+1;
@@ -446,6 +453,9 @@
g_stats_rtp.num_pkts_rx := g_stats_rtp.num_pkts_rx+1;
g_stats_rtp.bytes_payload_rx := 
g_stats_rtp.bytes_payload_rx +

lengthof(rx_rtp.msg.rtp.data);
+   if (rx_rtp.msg.rtp.data != g_cfg.rx_fixed_payload) {
+   g_stats_rtp.num_pkts_rx_err_payload := 
g_stats_rtp.num_pkts_rx_err_payload + 1
+   }
if (g_cfg.iuup_mode) {
rx_rtp.msg.rtp.data := 
f_IuUP_Em_rx_decaps(g_iuup_ent, rx_rtp.msg.rtp.data);
}

--
To view, visit https://gerrit.osmocom.org/13000
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0b125aaf915497d0a4f051af890fc34e09da61d
Gerrit-Change-Number: 13000
Gerrit-PatchSet: 1
Gerrit-Owner: dexter

Change in osmo-ttcn3-hacks[master]: MGCP_Test: Add testcase to test ts101318/rfc5993 conversion

2019-02-21 Thread dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13001


Change subject: MGCP_Test: Add testcase to test ts101318/rfc5993 conversion
..

MGCP_Test: Add testcase to test ts101318/rfc5993 conversion

The MGW recentenly adds support to convert between ts101318 and rfc5993
when GSM-HR is used. Lets add a testcase for that.

depends: osmo-mgw Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Change-Id: I96df45fe45b53088e07b26f14173a75498a84143
Related: OS#3807
---
M mgw/MGCP_Test.ttcn
M mgw/expected-results.xml
2 files changed, 59 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/01/13001/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 9eff8c2..4969a3f 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -1314,6 +1314,63 @@
setverdict(pass);
}

+
+   /* create two local RTP emulations; create two connections on MGW EP, 
see if
+* exchanged data is converted bwtween ts101318 and rfc5993 */
+   testcase TC_ts101318_rfc5993_rtp_conversion() runs on dummy_CT {
+   var RtpFlowData flow[2];
+   var RtpemStats stats[2];
+   var MgcpResponse resp;
+   var MgcpEndpoint ep := c_mgw_ep_rtpbridge & "2@" & c_mgw_domain;
+   var MgcpCallId call_id := '1226'H;
+
+   f_init(ep);
+
+   /* Turn on conversion mode */
+   f_vty_enter_config(MGWVTY);
+   f_vty_transceive(MGWVTY, "mgcp");
+   f_vty_transceive(MGWVTY, "rtp-patch rfc5993hr");
+
+   /* from us to MGW */
+   flow[0] := valueof(t_RtpFlow(mp_local_ip, mp_remote_ip, 111, 
"GSM-HR-08/8000"));
+   /* bind local RTP emulation sockets */
+   flow[0].em.portnr := 1;
+   flow[0].rtp_cfg := c_RtpemDefaultCfg;
+   flow[0].rtp_cfg.tx_payload_type := flow[0].pt;
+   flow[0].rtp_cfg.rx_fixed_payload := 
'0b11b3eede60be4e3ec68838c7b5'O;
+   flow[0].rtp_cfg.tx_fixed_payload := 
'0b11b3eede60be4e3ec68838c7b5'O;
+   f_flow_create(RTPEM[0], ep, call_id, "sendrecv", flow[0]);
+
+   /* from MGW back to us */
+   flow[1] := valueof(t_RtpFlow(mp_local_ip, mp_remote_ip, 111, 
"GSM-HR-08/8000"));
+   flow[1].em.portnr := 2;
+   flow[1].rtp_cfg := c_RtpemDefaultCfg;
+   flow[1].rtp_cfg.tx_payload_type := flow[1].pt;
+   flow[1].rtp_cfg.rx_fixed_payload := 
'000b11b3eede60be4e3ec68838c7b5'O;
+   flow[1].rtp_cfg.tx_fixed_payload := 
'000b11b3eede60be4e3ec68838c7b5'O;
+   f_flow_create(RTPEM[1], ep, call_id, "sendrecv", flow[1]);
+
+   f_rtpem_mode(RTPEM[1], RTPEM_MODE_BIDIR);
+   f_rtpem_mode(RTPEM[0], RTPEM_MODE_BIDIR);
+
+   f_sleep(1.0);
+
+   f_flow_delete(RTPEM[0]);
+   f_flow_delete(RTPEM[1], ep, call_id);
+
+   stats[0] := f_rtpem_stats_get(RTPEM[0]);
+   stats[1] := f_rtpem_stats_get(RTPEM[1]);
+
+   f_rtpem_stats_err_check(stats[0]);
+   f_rtpem_stats_err_check(stats[1]);
+
+   /* Turn off conversion mode */
+   f_vty_transceive(MGWVTY, "no rtp-patch rfc5993hr");
+
+   setverdict(pass);
+   }
+
+
/* TODO: Double-DLCX (no retransmission) */


@@ -1364,5 +1421,6 @@
execute(TC_two_crcx_mdcx_and_rtp());
execute(TC_two_crcx_and_unsolicited_rtp());
execute(TC_two_crcx_and_one_mdcx_rtp_ho());
+   execute(TC_ts101318_rfc5993_rtp_conversion());
}
 }
diff --git a/mgw/expected-results.xml b/mgw/expected-results.xml
index b45ba1f..f5bc1a0 100644
--- a/mgw/expected-results.xml
+++ b/mgw/expected-results.xml
@@ -37,4 +37,5 @@
   
   
   
+  
 

--
To view, visit https://gerrit.osmocom.org/13001
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96df45fe45b53088e07b26f14173a75498a84143
Gerrit-Change-Number: 13001
Gerrit-PatchSet: 1
Gerrit-Owner: dexter

Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

2019-02-21 Thread dexter

Hello tnt, Pau Espin Pedrol, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12979

to look at the new patch set (#3).

Change subject: Add option to GSM HR frames to RFC5593 representation
..

Add option to GSM HR frames to RFC5593 representation

There are different specifications around on how a GSM-HR frame should
be encapsulated into an RTP packet. RFC5593 specifies a ToC (Table of
Contents) byte to be prepended in front of the payload data.

The two formats can be distinguished easily by their length. Then the
data can be formatted into the corresponding opposite format and vice
versa.

- Add new VTY rtp-patch options
- Add conversion function

Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Related: OS#3807
---
M include/osmocom/mgcp/mgcp.h
M include/osmocom/mgcp/mgcp_internal.h
M src/libosmo-mgcp/mgcp_network.c
M src/libosmo-mgcp/mgcp_protocol.c
M src/libosmo-mgcp/mgcp_vty.c
5 files changed, 88 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/79/12979/3
--
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt

Change in osmo-ci[master]: Add timeout wrapper to regular gerrit verification jobs

2019-02-21 Thread daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12857 )

Change subject: Add timeout wrapper to regular gerrit verification jobs
..


Patch Set 2:

Have you also checked that this terminates as expected when something runs 
longer than expected?
i.e. that the signal causes ttcn3 and the docker instance to terminate?


--
To view, visit https://gerrit.osmocom.org/12857
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d0eb6b9eddf3e17120e74d7570d42291c0750ae
Gerrit-Change-Number: 12857
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 16:26:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: Add multipatch capability to osmo-config-merge

2019-02-21 Thread daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12897 )

Change subject: Add multipatch capability to osmo-config-merge
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d
Gerrit-Change-Number: 12897
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 21 Feb 2019 16:22:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Update config example

2019-02-21 Thread Max

Hello Pau Espin Pedrol, daniel, Harald Welte, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12992

to look at the new patch set (#2).

Change subject: Update config example
..

Update config example

Add OpenVPN and ping probe entries to example config.

Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Related: SYS#2655
---
M doc/examples/osmo-sysmon.cfg
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/92/12992/2
--
To view, visit https://gerrit.osmocom.org/12992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Gerrit-Change-Number: 12992
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith

Change in osmo-ci[master]: jobs: Introduce a tester using "virtual" tests

2019-02-21 Thread Holger Freyther

Holger Freyther has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12993 )

Change subject: jobs: Introduce a tester using "virtual" tests
..

jobs: Introduce a tester using "virtual" tests

With mobile, virtphy, osmo-bts-virtual we can run e2e tests without
the need of any hardware. Create a dedicated job for it. This avoids
having to share resources (e.g. lock state/ip allocations) with other
builds.

Change-Id: I19993b287cc948dbdfba9d375f80a7904f96ff4a
---
M jobs/osmo-gsm-tester-runner.yml
1 file changed, 57 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Holger Freyther: Verified



diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml
index cfb32e2..e0cfe40 100644
--- a/jobs/osmo-gsm-tester-runner.yml
+++ b/jobs/osmo-gsm-tester-runner.yml
@@ -8,6 +8,7 @@
   - 'osmo-gsm-tester_run-{stage}'
   - 'osmo-gsm-tester_gerrit'
   - 'osmo-gsm-tester_ttcn3'
+  - 'osmo-gsm-tester_virtual'

 - scm:
 name: osmo-gsm-tester-gerrit
@@ -195,3 +196,59 @@
   - junit:
   results: 'trial-*/last_run/trial-*.xml'
   allow-empty-results: true
+
+# virtual tester job
+- job:
+name: 'osmo-gsm-tester_virtual'
+defaults: runner
+node: 'osmocom-master-debian9'
+scm:
+  - 'osmo-gsm-tester-repo'
+triggers:
+  - timed: "H H/2 * * *"
+  - pollscm:
+  cron: "H/5 * * * *"
+builders:
+  - shell: |
+  # make sure no bin artifacts from a previous run remain
+  rm -f *.tgz *.md5
+  - copy_artifact_all
+  - copy_artifact:
+ repo: osmo-gsm-tester_build-osmocom-bb
+  - shell: >
+unlink osmo-gsm-tester/example/resources.conf || true
+
+ln -s resources.conf.virtual osmo-gsm-tester/example/resources.conf
+
+# TODO: We (want to) grant CAP_SYS_NICE for osmo-bts-virtual
+# but with newer cgroup support and the --cpu-rt-runtime/--ulimit
+# rtprio=99 flags we can limit the damage a job can do.
+
+docker run --rm=true \
+  -e HOME=/build \
+  -e JOB_NAME="$JOB_NAME" \
+  -e OSMO_GSM_TESTER_CONF="/build/osmo-gsm-tester/example" \
+  -e OSMO_GSM_TESTER_OPTS="$OSMO_GSM_TESTER_OPTS" \
+  -e BUILD_NUMBER="$BUILD_NUMBER" \
+  -w /build -i \
+  -v "$PWD:/build" \
+  -v "$HOME/bin:/build_bin" \
+  -v "$HOME/.ssh:/home/build/.ssh:ro" \
+  --cap-add=sys_nice \
+  osmocom:deb9_amd64 /bin/bash -c 'LANG="en_US.utf8" 
LC_ALL="en_US.UTF-8" LC_LANG="en_US.UTF-8" 
PATH="$PWD/osmo-gsm-tester/src:${PATH}" 
./osmo-gsm-tester/contrib/jenkins-run.sh'
+publishers:
+  - archive:
+  artifacts: '*-run.tgz, *-bin.tgz'
+  default-excludes: false
+  - junit:
+  results: 'trial-*/last_run/trial-*.xml'
+  allow-empty-results: true
+parameters:
+  - string:
+  name: "OSMO_GSM_TESTER_OPTS"
+  default: "-s nitb_netreg_mass"
+  description: "pass additional command line options to 
osmo-gsm-tester.py, e.g. to select specific suites:scenarios. Default: leave 
empty."
+  - string:
+  name: "OSMO_GSM_TESTER_BRANCH"
+  default: "origin/master"
+  description: "Which branch/sha should be used for testing"

--
To view, visit https://gerrit.osmocom.org/12993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19993b287cc948dbdfba9d375f80a7904f96ff4a
Gerrit-Change-Number: 12993
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther

Change in osmo-ci[master]: jobs: Introduce a tester using "virtual" tests

2019-02-21 Thread Holger Freyther

Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/12993 )

Change subject: jobs: Introduce a tester using "virtual" tests
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/12993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19993b287cc948dbdfba9d375f80a7904f96ff4a
Gerrit-Change-Number: 12993
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Comment-Date: Thu, 21 Feb 2019 16:04:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

2019-02-21 Thread tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
..


Patch Set 2: Code-Review-1

(1 comment)

Looks good to me except for the small cut issue in the vty command.

https://gerrit.osmocom.org/#/c/12979/2/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/#/c/12979/2/src/libosmo-mgcp/mgcp_vty.c@743
PS2, Line 743:  g_cfg->trunk.rfc5993_hr_convert = true;
I think this should be false.



--
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:56:09 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:55:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: PCU_Tests.default: Remove content of [EXECUTE] section

2019-02-21 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12996 )

Change subject: PCU_Tests.default: Remove content of [EXECUTE] section
..

PCU_Tests.default: Remove content of [EXECUTE] section

If we have tests stated in the .default file and we have them stated
again in the .cfg file, they will be executed twice.  Let's align
the PCU tests suite with those of other network elements.

Change-Id: Ieeaf70153f4dc61978569d06e20947fa939cabdd
---
M pcu/PCU_Tests.default
1 file changed, 0 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default
index 72b1c45..a877045 100644
--- a/pcu/PCU_Tests.default
+++ b/pcu/PCU_Tests.default
@@ -29,13 +29,3 @@
 [MAIN_CONTROLLER]

 [EXECUTE]
-PCU_Tests_RAW.control
-# for internal use only: will always fail when called as part of normal routine
-#PCU_Tests.TC_selftest_llc
-#PCU_Tests.TC_selftest_rlcmac
-#PCU_Tests.TC_selftest_bssgp
-#PCU_Tests.TC_nsem
-#PCU_Tests.TC_paging
-#PCU_Tests.TC_rach
-#PCU_Tests.TC_selftest_rr
-#PCU_Tests.TC_dl_tbf

--
To view, visit https://gerrit.osmocom.org/12996
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeaf70153f4dc61978569d06e20947fa939cabdd
Gerrit-Change-Number: 12996
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-ttcn3-hacks[master]: PCU_Tests.default: Remove content of [EXECUTE] section

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12996 )

Change subject: PCU_Tests.default: Remove content of [EXECUTE] section
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12996
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeaf70153f4dc61978569d06e20947fa939cabdd
Gerrit-Change-Number: 12996
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:54:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: Log FN and RA on RACH test timeouts

2019-02-21 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12999 )

Change subject: Log FN and RA on RACH test timeouts
..

Log FN and RA on RACH test timeouts

Change-Id: I6caac582649e38e77938602fa675d50bdde57790
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 230d3b6..66bf040 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1015,7 +1015,7 @@
}
[] RSL_CCHAN.receive { repeat; }
[] T.timeout {
-   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"Timeout waiting for CHAN RQD");
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
log2str("Timeout waiting for CHAN RQD FN=", fn, " RA=", ra));
}
}
}

--
To view, visit https://gerrit.osmocom.org/12999
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6caac582649e38e77938602fa675d50bdde57790
Gerrit-Change-Number: 12999
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith

Change in osmo-ttcn3-hacks[master]: Log FN and RA on RACH test timeouts

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12999 )

Change subject: Log FN and RA on RACH test timeouts
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12999
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6caac582649e38e77938602fa675d50bdde57790
Gerrit-Change-Number: 12999
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:53:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gprs_ns: Add missing NSVCI IE to NS-BLOCK-ACK message

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12969 )

Change subject: gprs_ns: Add missing NSVCI IE to NS-BLOCK-ACK message
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12969/1/src/gb/gprs_ns.c
File src/gb/gprs_ns.c:

https://gerrit.osmocom.org/#/c/12969/1/src/gb/gprs_ns.c@560
PS1, Line 560:  log_set_context(LOG_CTX_GB_NSVC, nsvc);
> the solution then is to make sure the logging context is re-initialized to 
> none every time we come o […]
see https://osmocom.org/issues/3813



--
To view, visit https://gerrit.osmocom.org/12969
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7205e99d57f1e42d941f1be2460d8c9f46aadfe
Gerrit-Change-Number: 12969
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:52:53 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-sysmon[master]: OpenVPN: track interface disconnect

2019-02-21 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/12989 )

Change subject: OpenVPN: track interface disconnect
..


Patch Set 1:

> Missing header include?

Missing dependency - see commit message.


--
To view, visit https://gerrit.osmocom.org/12989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b8bc71c1e9cbbf992ee3b7c1c9aae6e6f697e0
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:52:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmo-netif[master]: Stream client: add disconnect callback

2019-02-21 Thread Max

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12980 )

Change subject: Stream client: add disconnect callback
..

Stream client: add disconnect callback

It's similar to connect_cb() but called once client has been
disconnected.

Change-Id: I905adb2d6191216551a3bcdcd1aec1f96f01612a
---
M examples/ipa-stream-client.c
M examples/stream-client.c
M include/osmocom/netif/stream.h
M src/stream.c
4 files changed, 31 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c
index 2151090..ec7d2b3 100644
--- a/examples/ipa-stream-client.c
+++ b/examples/ipa-stream-client.c
@@ -54,6 +54,13 @@
exit(EXIT_SUCCESS);
 }

+static int disconnect_cb(struct osmo_stream_cli *conn)
+{
+   LOGP(DIPATEST, LOGL_NOTICE, "disconnected\n");
+
+   return 0;
+}
+
 static int connect_cb(struct osmo_stream_cli *conn)
 {
int *__num_msgs = osmo_stream_cli_get_data(conn);
@@ -176,6 +183,7 @@
osmo_stream_cli_set_addr(conn, "127.0.0.1");
osmo_stream_cli_set_port(conn, 1);
osmo_stream_cli_set_connect_cb(conn, connect_cb);
+   osmo_stream_cli_set_disconnect_cb(conn, disconnect_cb);
osmo_stream_cli_set_read_cb(conn, read_cb);
osmo_stream_cli_set_data(conn, _msgs);

diff --git a/examples/stream-client.c b/examples/stream-client.c
index e2fb901..f590f25 100644
--- a/examples/stream-client.c
+++ b/examples/stream-client.c
@@ -43,6 +43,13 @@
return 0;
 }

+static int disconnect_cb(struct osmo_stream_cli *conn)
+{
+   LOGP(DSTREAMTEST, LOGL_NOTICE, "disconnected: %s\n", 
osmo_stream_cli_get_sockname(conn));
+
+   return 0;
+}
+
 static int read_cb(struct osmo_stream_cli *conn)
 {
int bytes;
@@ -121,6 +128,7 @@
osmo_stream_cli_set_addr(conn, "127.0.0.1");
osmo_stream_cli_set_port(conn, 1);
osmo_stream_cli_set_connect_cb(conn, connect_cb);
+   osmo_stream_cli_set_disconnect_cb(conn, disconnect_cb);
osmo_stream_cli_set_read_cb(conn, read_cb);

if (osmo_stream_cli_open(conn) < 0) {
diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h
index 3044511..56162e4 100644
--- a/include/osmocom/netif/stream.h
+++ b/include/osmocom/netif/stream.h
@@ -64,6 +64,7 @@
 char *osmo_stream_cli_get_sockname(const struct osmo_stream_cli *cli);
 struct osmo_fd *osmo_stream_cli_get_ofd(struct osmo_stream_cli *cli);
 void osmo_stream_cli_set_connect_cb(struct osmo_stream_cli *cli, int 
(*connect_cb)(struct osmo_stream_cli *cli));
+void osmo_stream_cli_set_disconnect_cb(struct osmo_stream_cli *cli, int 
(*disconnect_cb)(struct osmo_stream_cli *cli));
 void osmo_stream_cli_set_read_cb(struct osmo_stream_cli *cli, int 
(*read_cb)(struct osmo_stream_cli *cli));
 void osmo_stream_cli_reconnect(struct osmo_stream_cli *cli);

diff --git a/src/stream.c b/src/stream.c
index 1880e25..c4db3d7 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -155,6 +155,7 @@
uint16_tlocal_port;
uint16_tproto;
int (*connect_cb)(struct osmo_stream_cli *srv);
+   int (*disconnect_cb)(struct osmo_stream_cli *srv);
int (*read_cb)(struct osmo_stream_cli *srv);
int (*write_cb)(struct osmo_stream_cli *srv);
void*data;
@@ -194,8 +195,11 @@
close(cli->ofd.fd);
cli->ofd.fd = -1;

-   if (cli->state == STREAM_CLI_STATE_CONNECTED)
+   if (cli->state == STREAM_CLI_STATE_CONNECTED) {
LOGSCLI(cli, LOGL_DEBUG, "connection closed\n");
+   if (cli->disconnect_cb)
+   cli->disconnect_cb(cli);
+   }

cli->state = STREAM_CLI_STATE_NONE;
 }
@@ -442,6 +446,15 @@
cli->connect_cb = connect_cb;
 }

+/*! \brief Set the call-back function called on disconnect of the stream 
client socket
+ *  \param[in] cli Stream Client to modify
+ *  \param[in] disconnect_cb Call-back function to be called upon disconnect */
+void osmo_stream_cli_set_disconnect_cb(struct osmo_stream_cli *cli,
+  int (*disconnect_cb)(struct 
osmo_stream_cli *cli))
+{
+   cli->disconnect_cb = disconnect_cb;
+}
+
 /*! \brief Set the call-back function called to read from the stream client 
socket
  *  \param[in] cli Stream Client to modify
  *  \param[in] read_cb Call-back function to be called when we want to read */

--
To view, visit https://gerrit.osmocom.org/12980
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I905adb2d6191216551a3bcdcd1aec1f96f01612a
Gerrit-Change-Number: 12980
Gerrit-PatchSet: 2
Gerrit-Owner:

Change in osmo-ttcn3-hacks[master]: Log FN and RA on RACH test timeouts

2019-02-21 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12999


Change subject: Log FN and RA on RACH test timeouts
..

Log FN and RA on RACH test timeouts

Change-Id: I6caac582649e38e77938602fa675d50bdde57790
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/99/12999/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 230d3b6..66bf040 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1015,7 +1015,7 @@
}
[] RSL_CCHAN.receive { repeat; }
[] T.timeout {
-   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"Timeout waiting for CHAN RQD");
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
log2str("Timeout waiting for CHAN RQD FN=", fn, " RA=", ra));
}
}
}

--
To view, visit https://gerrit.osmocom.org/12999
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6caac582649e38e77938602fa675d50bdde57790
Gerrit-Change-Number: 12999
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in libosmocore[master]: select: Call log_reset_context() before calling file descriptor callb...

2019-02-21 Thread Harald Welte

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12998


Change subject: select: Call log_reset_context() before calling file descriptor 
callbacks
..

select: Call log_reset_context() before calling file descriptor callbacks

Make sure to clear any log context before processing the next incoming message
as part of some file descriptor callback.  This effectively prevents "context
leaking" from processing of one message into processing of the next message as 
part
of one iteration through the list of file descriptors here.

Change-Id: I3644c7bc1a9cec5858eb0faf94efc8c3ba7f5d8d
Closes: OS#3813
---
M src/select.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/12998/1

diff --git a/src/select.c b/src/select.c
index b594ca5..4e7be35 100644
--- a/src/select.c
+++ b/src/select.c
@@ -35,6 +35,7 @@
 #include 
 #include 
 #include 
+#include 

 #include "../config.h"

@@ -214,6 +215,11 @@

if (flags) {
work = 1;
+   /* make sure to clear any log context before processing 
the next incoming message
+* as part of some file descriptor callback.  This 
effectively prevents "context
+* leaking" from processing of one message into 
processing of the next message as part
+* of one iteration through the list of file 
descriptors here.  See OS#3813 */
+   log_reset_context();
ufd->cb(ufd, flags);
}
/* ugly, ugly hack. If more than one filedescriptor was

--
To view, visit https://gerrit.osmocom.org/12998
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3644c7bc1a9cec5858eb0faf94efc8c3ba7f5d8d
Gerrit-Change-Number: 12998
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte

Change in osmo-sysmon[master]: Update config example

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12992 )

Change subject: Update config example
..


Patch Set 1: Code-Review-1


--
To view, visit https://gerrit.osmocom.org/12992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Gerrit-Change-Number: 12992
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:03:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: OpenVPN: track interface disconnect

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12989 )

Change subject: OpenVPN: track interface disconnect
..


Patch Set 1: Code-Review-1

build failure:
osysmon_openvpn.c:191:2: error: implicit declaration of function 
‘osmo_stream_cli_set_disconnect_cb’ [-Werror=implicit-function-declaration]
  osmo_stream_cli_set_disconnect_cb(vpn->mgmt, disconnect_cb);
  ^


Missing header include?


--
To view, visit https://gerrit.osmocom.org/12989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b8bc71c1e9cbbf992ee3b7c1c9aae6e6f697e0
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:06:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #408

2019-02-21 Thread jenkins

See 


--
[...truncated 3.69 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed

Change in osmo-sysmon[master]: Update config example

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12992 )

Change subject: Update config example
..


Patch Set 1:

Agree with osmith.


--
To view, visit https://gerrit.osmocom.org/12992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Gerrit-Change-Number: 12992
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:03:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sysmon[master]: OpenVPN: track interface disconnect

2019-02-21 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12989 )

Change subject: OpenVPN: track interface disconnect
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b8bc71c1e9cbbf992ee3b7c1c9aae6e6f697e0
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:00:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Stream client: add disconnect callback

2019-02-21 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12980 )

Change subject: Stream client: add disconnect callback
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12980
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I905adb2d6191216551a3bcdcd1aec1f96f01612a
Gerrit-Change-Number: 12980
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 14:49:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Update config example

2019-02-21 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12992 )

Change subject: Update config example
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12992/1/doc/examples/osmo-sysmon.cfg
File doc/examples/osmo-sysmon.cfg:

https://gerrit.osmocom.org/#/c/12992/1/doc/examples/osmo-sysmon.cfg@14
PS1, Line 14: ping www.siminn.is
Are we sure that this is okay with them?

Otherwise, maybe use something neutral like "yourdomain.example"?

https://en.wikipedia.org/wiki/.example



--
To view, visit https://gerrit.osmocom.org/12992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Gerrit-Change-Number: 12992
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 14:55:53 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmocore[master]: ipa_ccm_idtag_parse*: Fix reported length value

2019-02-21 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/10216 )

Change subject: ipa_ccm_idtag_parse*: Fix reported length value
..


Patch Set 3: Code-Review+2

> Sure, but if I understood it correctly it's not related to commit itself so 
> it shouldn't stop us from merging this.

Then go ahead and merge it, you already have 2x +1 :)


--
To view, visit https://gerrit.osmocom.org/10216
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I435aaa33605bd48635715a2c81aa2d231c1abf51
Gerrit-Change-Number: 10216
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 14:44:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: jenkins: Fix the test for journalctl if it isn't present

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12997 )

Change subject: jenkins: Fix the test for journalctl if it isn't present
..

jenkins: Fix the test for journalctl if it isn't present

test -x for an empty string is still true. Check if the result of
command is empty or not. It seems to work for the negative case now.

Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
---
M contrib/jenkins-run.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins-run.sh b/contrib/jenkins-run.sh
index 0b41247..4a76c09 100755
--- a/contrib/jenkins-run.sh
+++ b/contrib/jenkins-run.sh
@@ -30,7 +30,7 @@

 # tar up all results for archiving (optional)
 cd "$trial_dir"
-if [ -x $(command -v journalctl) ]; then
+if [ ! -z "$(command -v journalctl)" ]; then
   journalctl -u ofono -o short-precise --since "${time_start}" > "$(readlink 
last_run)/ofono.log"
 fi
 tar czf "$base/${trial_dir}-run.tgz" "$(readlink last_run)"

--
To view, visit https://gerrit.osmocom.org/12997
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: jenkins: Fix the test for journalctl if it isn't present

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12997 )

Change subject: jenkins: Fix the test for journalctl if it isn't present
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12997
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 21 Feb 2019 14:52:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trxcon/scheduler: count number of measurements

2019-02-21 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/12990 )

Change subject: trxcon/scheduler: count number of measurements
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12990
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 21 Feb 2019 14:30:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Jenkins build is back to normal : master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #897

2019-02-21 Thread jenkins

See

Change in osmocom-bb[master]: trxcon/scheduler: count number of measurements

2019-02-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12990 )

Change subject: trxcon/scheduler: count number of measurements
..


Patch Set 1:

(1 comment)

Hi Max,

> Would be nice to get more detailed explanation in commit message
> as to why this is the right thing.

I believe the commit message is satisfactory, please read it carefully.

In other words:

We used to count the amount of both RSSI and ToA measurements separately,
but since we always receive both, i.e. there are no cases when we receive
either RSSI, or ToA, it makes sense to have a shared counter of measurements.

> Was dbm_avg too high/incorrect before?

No. It would be calculated in the same way as before.

> Patch Set 1: Code-Review-1
> Also, why +2 with no reviews?

Because at the moment we have a lack of code review. Some of my further
changes depend on this one, so I need to get it merged ASAP. Also, I have
not merged this change immediately, so I don't see any problems here.

https://gerrit.osmocom.org/#/c/12990/1/src/host/trxcon/sched_lchan_common.c
File src/host/trxcon/sched_lchan_common.c:

https://gerrit.osmocom.org/#/c/12990/1/src/host/trxcon/sched_lchan_common.c@104
PS1, Line 104:  dbm_avg = lchan->meas.rssi_sum / lchan->meas.num;
> because meas.num = meas.rssi_num + meas.toa256_num?

>From where this assumption comes from?

> now you will end up with lower dbm_avg value than before

No.



--
To view, visit https://gerrit.osmocom.org/12990
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 21 Feb 2019 13:49:29 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: Log signals from VoiceCall dbus objects

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12899 )

Change subject: Log signals from VoiceCall dbus objects
..


Patch Set 1: Code-Review-1

Waiting to do some more tests before merging this one.


--
To view, visit https://gerrit.osmocom.org/12899
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0def02b9063f75ec32c8b9382bdb12d65e1fb9eb
Gerrit-Change-Number: 12899
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 21 Feb 2019 13:32:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: Fix race condition in f_dyn_ipa_pdch_(de)act

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12949 )

Change subject: bts: Fix race condition in f_dyn_ipa_pdch_(de)act
..

bts: Fix race condition in f_dyn_ipa_pdch_(de)act

Test BTS_Tests.TC_dyn_osmo_pdch_act_deact was sporadically failing due
to receiving IND_INFO on the PCU port with pdch_mask related TS bit set
to 0 after sending a PDCH ACT. That happened due to a race condition
because PCU send IND_INFO periodically. As a result, it can happen that
BTS sends an IND_INFO after PCU.clear was called and before the PDCH ACT
is handled.

Change-Id: If11ef05d97aa5f6caaa731f3817c1fecfc3edf7c
---
M bts/BTS_Tests.ttcn
1 file changed, 18 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index f7caac2..230d3b6 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3182,13 +3182,21 @@
PCU.clear;
RSL.send(ts_RSL_IPA_PDCH_ACT(g_chan_nr));
/* expect INFO_IND on PCU interface listing TS as PDCH */
+   timer T_wait := 2.0;
+   T_wait.start;
alt {
[] PCU.receive(t_SD_PCUIF(pcu_conn_id, tr_PCUIF_INFO_IND(bts_nr, ?))) 
-> value sd {
if (substr(sd.data.u.info_ind.trx[trx_nr].pdch_mask, 
g_chan_nr.tn, 1) != '1'B) {
-   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"PCUIF_INFO_IND PDCH_MASK not '1' after PDCH ACT");
+   log("PCUIF_INFO_IND PDCH_MASK not yet '1' after PDCH 
ACT on TS", g_chan_nr.tn,
+   " mask:", sd.data.u.info_ind.trx[trx_nr].pdch_mask);
+   repeat;
}
}
[] PCU.receive { repeat; }
+   [] T_wait.timeout {
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+   log2str("Timeout waiting for PCUIF_INFO_IND PDCH_MASK 
to be '1' on TS", g_chan_nr.tn));
+   }
}
/* try to activate this PDCH from the PCU point of view */
PCU.send(t_SD_PCUIF(pcu_conn_id, ts_PCUIF_ACT_REQ(bts_nr, trx_nr, 
g_chan_nr.tn)));
@@ -3204,13 +3212,21 @@
RSL.send(ts_RSL_IPA_PDCH_DEACT(g_chan_nr));
PCU.clear;
/* expect BTS to ask PCU to deactivate the channel */
+   timer T_wait := 2.0;
+   T_wait.start;
alt {
[] PCU.receive(t_SD_PCUIF(pcu_conn_id, tr_PCUIF_INFO_IND(bts_nr, ?))) 
-> value sd {
if (substr(sd.data.u.info_ind.trx[trx_nr].pdch_mask, 
g_chan_nr.tn, 1) != '0'B) {
-   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"PCUIF_INFO_IND PDCH_MASK not '0' after PDCH DEACT");
+   log("PCUIF_INFO_IND PDCH_MASK not yet '0' after PDCH 
DEACT on TS", g_chan_nr.tn,
+   " mask:", sd.data.u.info_ind.trx[trx_nr].pdch_mask);
+   repeat;
}
}
[] PCU.receive { repeat; }
+   [] T_wait.timeout {
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+   log2str("Timeout waiting for PCUIF_INFO_IND PDCH_MASK 
to be '0' on TS", g_chan_nr.tn));
+   }
}
/* Emulate PCU asking BTS to deactivate PDCH */
PCU.send(t_SD_PCUIF(pcu_conn_id, ts_PCUIF_DEACT_REQ(bts_nr, trx_nr, 
g_chan_nr.tn)));

--
To view, visit https://gerrit.osmocom.org/12949
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If11ef05d97aa5f6caaa731f3817c1fecfc3edf7c
Gerrit-Change-Number: 12949
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-bts[master]: oc2g: Remove unused static function

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12972 )

Change subject: oc2g: Remove unused static function
..

oc2g: Remove unused static function

Change-Id: I4d0a476f84bc9e92e02f94c3990daddeeaa3c5d5
---
M src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c 
b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
index 104d279..eac8ed1 100644
--- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
+++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
@@ -245,18 +245,6 @@
ipa_client_conn_send(mgr->oc2gbts_ctrl.bts_conn, msg);
 }

-static void send_set_ctrl_cmd_int(struct oc2gbts_mgr_instance *mgr, const char 
*key, const int val)
-{
-   struct msgb *msg;
-   int ret;
-
-   msg = msgb_alloc_headroom(1024, 128, "CTRL SET");
-   ret = snprintf((char *) msg->data, 4096, "SET %u %s %d",
-   mgr->oc2gbts_ctrl.last_seqno++, key, val);
-   msg->l2h = msgb_put(msg, ret);
-   return send_ctrl_cmd(mgr, msg);
-}
-
 static void send_set_ctrl_cmd(struct oc2gbts_mgr_instance *mgr, const char 
*key, const int val, const char *text)
 {
struct msgb *msg;

--
To view, visit https://gerrit.osmocom.org/12972
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d0a476f84bc9e92e02f94c3990daddeeaa3c5d5
Gerrit-Change-Number: 12972
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-bts[master]: oc2g: vty: Compilation error fixes due to commented code

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12973 )

Change subject: oc2g: vty: Compilation error fixes due to commented code
..

oc2g: vty: Compilation error fixes due to commented code

Change-Id: Id2b16b9acd15d0c80085fac0fdc2a57173ebb0a0
---
M src/osmo-bts-oc2g/oc2gbts_vty.c
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-oc2g/oc2gbts_vty.c b/src/osmo-bts-oc2g/oc2gbts_vty.c
index 099698f..9bb4579 100644
--- a/src/osmo-bts-oc2g/oc2gbts_vty.c
+++ b/src/osmo-bts-oc2g/oc2gbts_vty.c
@@ -77,11 +77,13 @@
{ 0, NULL }
 };

+/*
 static const struct value_string oc2g_led_mode_strs[] = {
{ OC2G_LED_CONTROL_BTS, "bts" },
{ OC2G_LED_CONTROL_EXT, "external" },
{ 0, NULL }
 };
+*/

 static const struct value_string oc2g_auto_adj_pwr_strs[] = {
{ OC2G_TX_PWR_ADJ_NONE, "none" },
@@ -455,7 +457,7 @@
struct gsm_lchan *lchan;
int trx_nr, ts_nr, lchan_nr;
uint8_t ho_cause;
-   uint8_t old_ho_cause;
+   /* uint8_t old_ho_cause; */

/* get BTS pointer */
bts = gsm_bts_num(net, 0);
@@ -519,6 +521,7 @@
/ * restore HO cause * /
lchan->meas_preproc.rec_ho_causes = old_ho_cause;
*/
+   (void)lchan; /* to use lchan and avoid compilation warning */

return CMD_SUCCESS;
 }
@@ -728,5 +731,5 @@
rc |= ctrl_cmd_install(CTRL_NODE_ROOT, _oc2g_oml_ceased);
*/

-   return 0;
+   return rc;
 }

--
To view, visit https://gerrit.osmocom.org/12973
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2b16b9acd15d0c80085fac0fdc2a57173ebb0a0
Gerrit-Change-Number: 12973
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy

Change in osmo-gsm-tester[master]: jenkins: Fix the test for journalctl if it isn't present

2019-02-21 Thread Holger Freyther

Holger Freyther has uploaded a new patch set (#3). ( 
https://gerrit.osmocom.org/12997 )

Change subject: jenkins: Fix the test for journalctl if it isn't present
..

jenkins: Fix the test for journalctl if it isn't present

test -x for an empty string is still true. Check if the result of
command is empty or not. It seems to work for the negative case now.

Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
---
M contrib/jenkins-run.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/97/12997/3
--
To view, visit https://gerrit.osmocom.org/12997
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther

Change in osmo-gsm-tester[master]: jenkins: Only run journalctl if it is available on the machine

2019-02-21 Thread Holger Freyther

Holger Freyther has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/12997 )

Change subject: jenkins: Only run journalctl if it is available on the machine
..

jenkins: Only run journalctl if it is available on the machine

It's not common to run journald inside containers and the journalctl
command is not installed. Don't attempt to run it.

Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
---
M contrib/jenkins-run.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/97/12997/2
--
To view, visit https://gerrit.osmocom.org/12997
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther

Change in osmo-gsm-tester[master]: jenkins: Only run journalctl if it is available on the machine

2019-02-21 Thread Holger Freyther

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/12997


Change subject: jenkins: Only run journalctl if it is available on the machine
..

jenkins: Only run journalctl if it is available on the machine

It's not common to run journald inside containers and the journalctl
command is not installed. Don't attempt to run it.

Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
---
M contrib/jenkins-run.sh
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/97/12997/1

diff --git a/contrib/jenkins-run.sh b/contrib/jenkins-run.sh
index 716899e..4a76c09 100755
--- a/contrib/jenkins-run.sh
+++ b/contrib/jenkins-run.sh
@@ -30,7 +30,9 @@

 # tar up all results for archiving (optional)
 cd "$trial_dir"
-journalctl -u ofono -o short-precise --since "${time_start}" > "$(readlink 
last_run)/ofono.log"
+if [ ! -z "$(command -v journalctl)" ]; then
+  journalctl -u ofono -o short-precise --since "${time_start}" > "$(readlink 
last_run)/ofono.log"
+fi
 tar czf "$base/${trial_dir}-run.tgz" "$(readlink last_run)"
 tar czf "$base/${trial_dir}-bin.tgz" *.md5 *.tgz


--
To view, visit https://gerrit.osmocom.org/12997
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e4326df155dae776481bf7824694b3fb47abcad
Gerrit-Change-Number: 12997
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther

Change in osmo-gsm-tester[master]: jenkins: Only run journalctl if it is available on the machine

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12991 )

Change subject: jenkins: Only run journalctl if it is available on the machine
..

jenkins: Only run journalctl if it is available on the machine

It's not common to run journald inside containers and the journalctl
command is not installed. Don't attempt to run it.

Change-Id: I9dee3cb0d0ca203da77dfa1a793a4e4e5f8593c6
---
M contrib/jenkins-run.sh
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/contrib/jenkins-run.sh b/contrib/jenkins-run.sh
index 716899e..0b41247 100755
--- a/contrib/jenkins-run.sh
+++ b/contrib/jenkins-run.sh
@@ -30,7 +30,9 @@

 # tar up all results for archiving (optional)
 cd "$trial_dir"
-journalctl -u ofono -o short-precise --since "${time_start}" > "$(readlink 
last_run)/ofono.log"
+if [ -x $(command -v journalctl) ]; then
+  journalctl -u ofono -o short-precise --since "${time_start}" > "$(readlink 
last_run)/ofono.log"
+fi
 tar czf "$base/${trial_dir}-run.tgz" "$(readlink last_run)"
 tar czf "$base/${trial_dir}-bin.tgz" *.md5 *.tgz


--
To view, visit https://gerrit.osmocom.org/12991
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9dee3cb0d0ca203da77dfa1a793a4e4e5f8593c6
Gerrit-Change-Number: 12991
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: jenkins: Only run journalctl if it is available on the machine

2019-02-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12991 )

Change subject: jenkins: Only run journalctl if it is available on the machine
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12991
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dee3cb0d0ca203da77dfa1a793a4e4e5f8593c6
Gerrit-Change-Number: 12991
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 21 Feb 2019 13:13:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: PCU_Tests.default: Remove content of [EXECUTE] section

2019-02-21 Thread Harald Welte

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12996


Change subject: PCU_Tests.default: Remove content of [EXECUTE] section
..

PCU_Tests.default: Remove content of [EXECUTE] section

If we have tests stated in the .default file and we have them stated
again in the .cfg file, they will be executed twice.  Let's align
the PCU tests suite with those of other network elements.

Change-Id: Ieeaf70153f4dc61978569d06e20947fa939cabdd
---
M pcu/PCU_Tests.default
1 file changed, 0 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/96/12996/1

diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default
index 72b1c45..a877045 100644
--- a/pcu/PCU_Tests.default
+++ b/pcu/PCU_Tests.default
@@ -29,13 +29,3 @@
 [MAIN_CONTROLLER]

 [EXECUTE]
-PCU_Tests_RAW.control
-# for internal use only: will always fail when called as part of normal routine
-#PCU_Tests.TC_selftest_llc
-#PCU_Tests.TC_selftest_rlcmac
-#PCU_Tests.TC_selftest_bssgp
-#PCU_Tests.TC_nsem
-#PCU_Tests.TC_paging
-#PCU_Tests.TC_rach
-#PCU_Tests.TC_selftest_rr
-#PCU_Tests.TC_dl_tbf

--
To view, visit https://gerrit.osmocom.org/12996
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeaf70153f4dc61978569d06e20947fa939cabdd
Gerrit-Change-Number: 12996
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte

Change in osmocom-bb[master]: trxcon/scheduler: count number of measurements

2019-02-21 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/12990 )

Change subject: trxcon/scheduler: count number of measurements
..


Patch Set 1: Code-Review-1

Also, why +2 with no reviews?


--
To view, visit https://gerrit.osmocom.org/12990
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 21 Feb 2019 12:33:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trxcon/scheduler: count number of measurements

2019-02-21 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/12990 )

Change subject: trxcon/scheduler: count number of measurements
..


Patch Set 1:

(1 comment)

Would be nice to get more detailed explanation in commit message as to why this 
is the right thing. Was dbm_avg too high/incorrect before?

https://gerrit.osmocom.org/#/c/12990/1/src/host/trxcon/sched_lchan_common.c
File src/host/trxcon/sched_lchan_common.c:

https://gerrit.osmocom.org/#/c/12990/1/src/host/trxcon/sched_lchan_common.c@104
PS1, Line 104:  dbm_avg = lchan->meas.rssi_sum / lchan->meas.num;
So now you will end up with lower dbm_avg value than before because meas.num = 
meas.rssi_num + meas.toa256_num?



--
To view, visit https://gerrit.osmocom.org/12990
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Max 
Gerrit-Comment-Date: Thu, 21 Feb 2019 12:32:58 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: ttcn3-testsuites: Add PCU tests

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12994 )

Change subject: ttcn3-testsuites: Add PCU tests
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12994
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd8113c8db2b6e84d6e01539a6df031dc6f4ee80
Gerrit-Change-Number: 12994
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 21 Feb 2019 11:06:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-pcu-test: Use master branch, not laforge/gb-sns

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12995 )

Change subject: ttcn3-pcu-test: Use master branch, not laforge/gb-sns
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12995
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I106184f3f75802ac9a3109408c8eee6597b70caa
Gerrit-Change-Number: 12995
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 21 Feb 2019 11:06:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-pcu-test: Use master branch, not laforge/gb-sns

2019-02-21 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12995 )

Change subject: ttcn3-pcu-test: Use master branch, not laforge/gb-sns
..

ttcn3-pcu-test: Use master branch, not laforge/gb-sns

All required code is now in master, let's use master.

Change-Id: I106184f3f75802ac9a3109408c8eee6597b70caa
---
M ttcn3-pcu-test/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/ttcn3-pcu-test/Dockerfile b/ttcn3-pcu-test/Dockerfile
index 2cfacce..45b22d0 100644
--- a/ttcn3-pcu-test/Dockerfile
+++ b/ttcn3-pcu-test/Dockerfile
@@ -11,7 +11,7 @@
 RUNgit config --global user.email doc...@dock.er && \
git config --global user.name "Dock Er"

-ARGOSMO_TTCN3_BRANCH="laforge/gb-sns"
+ARGOSMO_TTCN3_BRANCH="master"

 ADDhttp://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH 
/tmp/commit
 RUNcd osmo-ttcn3-hacks && \

--
To view, visit https://gerrit.osmocom.org/12995
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I106184f3f75802ac9a3109408c8eee6597b70caa
Gerrit-Change-Number: 12995
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte

Change in osmo-ci[master]: ttcn3-testsuites: Add PCU tests

2019-02-21 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12994 )

Change subject: ttcn3-testsuites: Add PCU tests
..

ttcn3-testsuites: Add PCU tests

Change-Id: Ifd8113c8db2b6e84d6e01539a6df031dc6f4ee80
Closes: OS#2890
---
M jobs/ttcn3-testsuites.yml
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index b7a3fd0..b53d3dd 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -33,6 +33,8 @@
   timer: 30 05 * * *
   - ttcn3-sip-test:
   timer: 00 07 * * *
+  - ttcn3-pcu-test:
+  timer: 00 05 * * *

   # latest stable
   - nplab-m3ua-test-latest:
@@ -57,6 +59,8 @@
   blocking: "^ttcn3-sgsn-test.*"
   - ttcn3-sip-test-latest:
   blocking: "^ttcn3-sip-test.*"
+  - ttcn3-pcu-test-latest:
+  blocking: "^ttcn3-pcu-test.*"
 - job-template:
 name: '{job-name}'
 project-type: freestyle

--
To view, visit https://gerrit.osmocom.org/12994
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd8113c8db2b6e84d6e01539a6df031dc6f4ee80
Gerrit-Change-Number: 12994
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte

Change in osmo-ci[master]: jobs: Introduce a tester using "virtual" tests

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12993 )

Change subject: jobs: Introduce a tester using "virtual" tests
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19993b287cc948dbdfba9d375f80a7904f96ff4a
Gerrit-Change-Number: 12993
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 21 Feb 2019 11:06:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-pcu-test: Use master branch, not laforge/gb-sns

2019-02-21 Thread Harald Welte

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12995


Change subject: ttcn3-pcu-test: Use master branch, not laforge/gb-sns
..

ttcn3-pcu-test: Use master branch, not laforge/gb-sns

All required code is now in master, let's use master.

Change-Id: I106184f3f75802ac9a3109408c8eee6597b70caa
---
M ttcn3-pcu-test/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/95/12995/1

diff --git a/ttcn3-pcu-test/Dockerfile b/ttcn3-pcu-test/Dockerfile
index 2cfacce..45b22d0 100644
--- a/ttcn3-pcu-test/Dockerfile
+++ b/ttcn3-pcu-test/Dockerfile
@@ -11,7 +11,7 @@
 RUNgit config --global user.email doc...@dock.er && \
git config --global user.name "Dock Er"

-ARGOSMO_TTCN3_BRANCH="laforge/gb-sns"
+ARGOSMO_TTCN3_BRANCH="master"

 ADDhttp://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH 
/tmp/commit
 RUNcd osmo-ttcn3-hacks && \

--
To view, visit https://gerrit.osmocom.org/12995
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I106184f3f75802ac9a3109408c8eee6597b70caa
Gerrit-Change-Number: 12995
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte

Change in osmo-ci[master]: ttcn3-testsuites: Add PCU tests

2019-02-21 Thread Harald Welte

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12994


Change subject: ttcn3-testsuites: Add PCU tests
..

ttcn3-testsuites: Add PCU tests

Change-Id: Ifd8113c8db2b6e84d6e01539a6df031dc6f4ee80
Closes: OS#2890
---
M jobs/ttcn3-testsuites.yml
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/94/12994/1

diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index b7a3fd0..b53d3dd 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -33,6 +33,8 @@
   timer: 30 05 * * *
   - ttcn3-sip-test:
   timer: 00 07 * * *
+  - ttcn3-pcu-test:
+  timer: 00 05 * * *

   # latest stable
   - nplab-m3ua-test-latest:
@@ -57,6 +59,8 @@
   blocking: "^ttcn3-sgsn-test.*"
   - ttcn3-sip-test-latest:
   blocking: "^ttcn3-sip-test.*"
+  - ttcn3-pcu-test-latest:
+  blocking: "^ttcn3-pcu-test.*"
 - job-template:
 name: '{job-name}'
 project-type: freestyle

--
To view, visit https://gerrit.osmocom.org/12994
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd8113c8db2b6e84d6e01539a6df031dc6f4ee80
Gerrit-Change-Number: 12994
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte

Change in docker-playground[master]: PCU: Add osmo-pcu-* + ttcn3-pcu-test containers

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12986 )

Change subject: PCU: Add osmo-pcu-* + ttcn3-pcu-test containers
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/12986
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8e2ed2e7d03b8afdc7b1e068f94b0544a8112c7
Gerrit-Change-Number: 12986
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 21 Feb 2019 10:56:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: PCU: Add osmo-pcu-* + ttcn3-pcu-test containers

2019-02-21 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12986 )

Change subject: PCU: Add osmo-pcu-* + ttcn3-pcu-test containers
..

PCU: Add osmo-pcu-* + ttcn3-pcu-test containers

This will enable us to run the PCU testsuite automatically by
jenkins, just like for other Osmocom projects.

Change-Id: Ia8e2ed2e7d03b8afdc7b1e068f94b0544a8112c7
Related: OS#2890
---
A osmo-pcu-latest/.release
A osmo-pcu-latest/Dockerfile
A osmo-pcu-latest/Makefile
A osmo-pcu-latest/Release.key
A osmo-pcu-latest/osmo-pcu.cfg
A osmo-pcu-latest/respawn.sh
A osmo-pcu-master/.release
A osmo-pcu-master/Dockerfile
A osmo-pcu-master/Makefile
A osmo-pcu-master/Release.key
A osmo-pcu-master/osmo-pcu.cfg
A osmo-pcu-master/respawn.sh
A ttcn3-pcu-test/.release
A ttcn3-pcu-test/Dockerfile
A ttcn3-pcu-test/Makefile
A ttcn3-pcu-test/PCU_Tests.cfg
A ttcn3-pcu-test/jenkins.sh
A ttcn3-pcu-test/osmo-pcu.cfg
18 files changed, 282 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/osmo-pcu-latest/.release b/osmo-pcu-latest/.release
new file mode 100644
index 000..466d8a8
--- /dev/null
+++ b/osmo-pcu-latest/.release
@@ -0,0 +1,2 @@
+release=0.0.0
+tag=osmo-pcu-latest-0.0.0
diff --git a/osmo-pcu-latest/Dockerfile b/osmo-pcu-latest/Dockerfile
new file mode 100644
index 000..fdd5e56
--- /dev/null
+++ b/osmo-pcu-latest/Dockerfile
@@ -0,0 +1,36 @@
+FROM debian:stretch
+
+MAINTAINER Harald Welte 
+
+ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/;
+
+COPY   Release.key /tmp/Release.key
+
+ADD$OSMOCOM_REPO/Release /tmp/Release
+RUNapt-get update && \
+   apt-get install -y --no-install-recommends \
+   gnupg
+
+RUNapt-key add /tmp/Release.key && \
+   rm /tmp/Release.key && \
+   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-latest.list
+
+ADD$OSMOCOM_REPO/Release /tmp/Release
+RUNapt-get update && \
+   apt-get install -y --no-install-recommends \
+   telnet \
+   osmo-pcu && \
+   apt-get clean
+
+ADDrespawn.sh /usr/local/bin/respawn.sh
+
+WORKDIR/tmp
+
+VOLUME /data
+
+COPY   osmo-pcu.cfg /data/osmo-pcu.cfg
+
+WORKDIR/data
+CMD["/usr/bin/osmo-pcu"]
+
+#EXPOSE
diff --git a/osmo-pcu-latest/Makefile b/osmo-pcu-latest/Makefile
new file mode 100644
index 000..8d0e10b
--- /dev/null
+++ b/osmo-pcu-latest/Makefile
@@ -0,0 +1 @@
+include ../make/Makefile
diff --git a/osmo-pcu-latest/Release.key b/osmo-pcu-latest/Release.key
new file mode 100644
index 000..e656238
--- /dev/null
+++ b/osmo-pcu-latest/Release.key
@@ -0,0 +1,20 @@
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: GnuPG v1.4.5 (GNU/Linux)
+
+mQENBFJBt/wBCADAht3d/ilNuyzaXYw/QwTRvmjyoDvfXw+H/3Fvk1zlDZoiKPPc
+a1wCVBINUZl7vYM2OXqbJwYa++JP2Q48xKSvC6thbRc/YLievkbcvTemf7IaREfl
+CTjoYpoqXHa9kHMw1aALDm8CNU88jZmnV7v9L6hKkbYDxie+jpoj7D6B9JlxgNJ4
+5dQyRNsFGVcIl4Vplt1HyGc5Q5nQI/VgS2rlF/IOXmhRQBc4LEDdU8R2IKnkU4ee
+S7TWanAigGAQhxGuCkS39/CWzc1DhLhjlNhBl/+RTPejkqJtAy00ZLps3+RqUN1Y
+CU/Fsr7aRlYVGqQ/BlptwV0XQ2VVYJX2oEBBABEBAAG0MG5ldHdvcmsgT0JTIFBy
+b2plY3QgPG5ldHdvcmtAYnVpbGQub3BlbnN1c2Uub3JnPokBPAQTAQIAJgUCWmMc
+aQIbAwUJDEAUbQYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJEGLrGgkXKA3fjsoI
+ALSXmXzFCpTxg8a6tvXkqddY/qAmeBMNUf7hslI9wN3leNmCrnuHS8TbHWYJZgtw
+8M5fKL3aRQYaIiqqm1XOUF0OqwYNDj5V3y38mM68NYOkzgSP7foMwZp9Y0TlGhtI
+L8weA+2RUjB4hwwGMAYMqkRZyKW3NhPqdlGGoXac1ilwEyGXFHdOLbkhtyS+P2yb
+/EvaKIN5cMLzRZKeYgdp9WuAirV+yV/SDbgvabW098lrWhGLltlRRDQgMV883p8I
+ERMI1wlLFZGnHL3mfBWGeQ24M/DaBOdXQDtfBLCJ9nGztmDBUb8i6GFWU7nD2TGi
+8mYUsED1ZDwO/0jdvJ4gSluIRgQTEQIABgUCUkG3/AAKCRA7MBG3a51lIzhdAJ9v
+d6XPffMZRcCGgDEY5OaTn/MsCQCgrXbeZpFJgnirSrc8rRonvzYFiF4=
+=Gvly
+-END PGP PUBLIC KEY BLOCK-
diff --git a/osmo-pcu-latest/osmo-pcu.cfg b/osmo-pcu-latest/osmo-pcu.cfg
new file mode 100644
index 000..9a5db59
--- /dev/null
+++ b/osmo-pcu-latest/osmo-pcu.cfg
@@ -0,0 +1,10 @@
+line vty
+ no login
+ bind 0.0.0.0
+pcu
+ flow-control-interval 10
+ cs 2
+ alloc-algorithm dynamic
+ alpha 0
+ gamma 0
+ pcu-socket /data/pcu_bts
diff --git a/osmo-pcu-latest/respawn.sh b/osmo-pcu-latest/respawn.sh
new file mode 100755
index 000..ae5cf60
--- /dev/null
+++ b/osmo-pcu-latest/respawn.sh
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+trap "kill 0" EXIT
+
+while [ -e /etc/passwd ]; do
+   $* &
+   LAST_PID=$!
+   wait $LAST_PID
+done
diff --git a/osmo-pcu-master/.release b/osmo-pcu-master/.release
new file mode 100644
index 000..49b830d
--- /dev/null
+++ b/osmo-pcu-master/.release
@@ -0,0 +1,2 @@
+release=0.0.0
+tag=osmo-pcu-master-0.0.0
diff --git a/osmo-pcu-master/Dockerfile b/osmo-pcu-master/Dockerfile
new file mode 100644
index 000..867f534
--- /dev/null
+++ b/osmo-pcu-master/Dockerfile
@@ -0,0 +1,43 @@
+ARGUSER
+FROM   $USER/debian-jessie-build
+
+MAINTAINER Harald Welte 
+
+ARG

Change in osmo-ttcn3-hacks[master]: PCU: Tests for the BSS/PCU side NS/BSSGP implementations

2019-02-21 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12984 )

Change subject: PCU: Tests for the BSS/PCU side NS/BSSGP implementations
..

PCU: Tests for the BSS/PCU side NS/BSSGP implementations

The existing (unused) PCU_Tests are operating on top of a NS + BSSGP
emulation, i.e. they're aimed at testing higher protocol layers.  Also,
they required BTS+BSC to run next to the PCU.

The new PCU_Tests_RAW introduced in this patch are the exact opposite:
* they test the PCU alone (attach to PCUIF and Gb interface)
* they don't require BTS or BSC to run
* they don't use NS + BSSGP emulation but raw NS/BSSGP frames to
  test the very NS/BSSGP implementation inside of OsmoPCU.

Change-Id: I7ad76b96974cf0a686ad0f00ccd09d1a9df8b4d5
Related: OS#2890
---
M pcu/PCU_Tests.cfg
A pcu/PCU_Tests.default
A pcu/PCU_Tests_RAW.ttcn
M pcu/gen_links.sh
4 files changed, 427 insertions(+), 28 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/pcu/PCU_Tests.cfg b/pcu/PCU_Tests.cfg
index 5975290..2dfce51 100644
--- a/pcu/PCU_Tests.cfg
+++ b/pcu/PCU_Tests.cfg
@@ -1,10 +1,10 @@
 [ORDERED_INCLUDE]
 # Common configuration, shared between test suites
 "../Common.cfg"
+# testsuite specific configuration, not expected to change
+"./PCU_Tests.default"

 [LOGGING]
-#*.FileMask := LOG_ALL
-ConsoleMask := ERROR | WARNING | TESTCASE | TIMEROP_START | DEBUG_ENCDEC

 [MODULE_PARAMETERS]
 PCU_Tests.mp_nsconfig := {
@@ -16,34 +16,9 @@
nsei := 1234
 }

-PCU_Tests.mp_gb_cfg := {
-   nsei := 1234,
-   bvci := 1234,
-   cell_id := {
-   ra_id := {
-   lai := {
-   mcc_mnc := '00101F'H, lac := 1
-   },
-   rac := 0
-   },
-   cell_id := 0
-   },
-   sgsn_role := true
-}
-
 [TESTPORT_PARAMETERS]
-*.*.udpReuseAddress := "yes";

 [MAIN_CONTROLLER]

 [EXECUTE]
-PCU_Tests.control
-# for internal use only: will always fail when called as part of normal routine
-#PCU_Tests.TC_selftest_llc
-#PCU_Tests.TC_selftest_rlcmac
-#PCU_Tests.TC_selftest_bssgp
-#PCU_Tests.TC_nsem
-#PCU_Tests.TC_paging
-#PCU_Tests.TC_rach
-#PCU_Tests.TC_selftest_rr
-#PCU_Tests.TC_dl_tbf
+PCU_Tests_RAW.control
diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default
new file mode 100644
index 000..72b1c45
--- /dev/null
+++ b/pcu/PCU_Tests.default
@@ -0,0 +1,41 @@
+[ORDERED_INCLUDE]
+# Common configuration, shared between test suites
+"../Common.cfg"
+
+[LOGGING]
+#*.FileMask := LOG_ALL
+ConsoleMask := ERROR | WARNING | TESTCASE | TIMEROP_START | DEBUG_ENCDEC
+
+[MODULE_PARAMETERS]
+PCU_Tests.mp_gb_cfg := {
+   nsei := 1234,
+   bvci := 1234,
+   cell_id := {
+   ra_id := {
+   lai := {
+   mcc_mnc := '00101F'H, lac := 1
+   },
+   rac := 0
+   },
+   cell_id := 0
+   },
+   sgsn_role := true
+}
+
+[TESTPORT_PARAMETERS]
+*.*.udpReuseAddress := "yes";
+*.PCU.socket_type := "SEQPACKET"
+
+[MAIN_CONTROLLER]
+
+[EXECUTE]
+PCU_Tests_RAW.control
+# for internal use only: will always fail when called as part of normal routine
+#PCU_Tests.TC_selftest_llc
+#PCU_Tests.TC_selftest_rlcmac
+#PCU_Tests.TC_selftest_bssgp
+#PCU_Tests.TC_nsem
+#PCU_Tests.TC_paging
+#PCU_Tests.TC_rach
+#PCU_Tests.TC_selftest_rr
+#PCU_Tests.TC_dl_tbf
diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
new file mode 100644
index 000..eb06088
--- /dev/null
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -0,0 +1,382 @@
+module PCU_Tests_RAW {
+
+/* "RAW" PCU tests: Talk directly to the PCU socket of OsmoPCU on the one hand 
side (emulating
+   the BTS/BSC side PCU socket server) and the Gb interface on the other hand 
side.  No NS/BSSGP
+   Emulation is used; rather, we simply use the NS_CodecPort to implement both 
standard and non-
+   standard procedures on the NS and BSSGP level.  The goal of these tests is 
to test exactly
+   those NS and BSSGP implementations on the BSS (PCU) side. */
+
+import from General_Types all;
+import from Osmocom_Types all;
+import from NS_Types all;
+import from BSSGP_Types all;
+import from Osmocom_Gb_Types all;
+
+import from BSSGP_Emulation all; /* BssgpConfig */
+import from NS_Emulation all; /* NSConfiguration */
+
+import from UD_Types all;
+import from PCUIF_Types all;
+import from PCUIF_CodecPort all;
+import from IPL4asp_Types all;
+import from NS_CodecPort all;
+import from NS_CodecPort_CtrlFunct all;
+import from Native_Functions all;
+import from PCU_Tests all;
+
+modulepar {
+   charstring mp_pcu_sock_path := PCU_SOCK_DEFAULT;
+}
+
+type component RAW_NS_CT {
+   /* UDP port towards the bottom (IUT) */
+   port NS_CODEC_PT NSCP;
+   var ConnectionId g_ns_conn_id := -1;
+   timer g_T_guard;
+
+   /* PCUIF

Change in osmo-ttcn3-hacks[master]: PCU: Tests for the BSS/PCU side NS/BSSGP implementations

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12984 )

Change subject: PCU: Tests for the BSS/PCU side NS/BSSGP implementations
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12984
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad76b96974cf0a686ad0f00ccd09d1a9df8b4d5
Gerrit-Change-Number: 12984
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Thu, 21 Feb 2019 10:54:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: PCU: Tests for the BSS/PCU side NS/BSSGP implementations

2019-02-21 Thread Harald Welte

Hello Max, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12984

to look at the new patch set (#3).

Change subject: PCU: Tests for the BSS/PCU side NS/BSSGP implementations
..

PCU: Tests for the BSS/PCU side NS/BSSGP implementations

The existing (unused) PCU_Tests are operating on top of a NS + BSSGP
emulation, i.e. they're aimed at testing higher protocol layers.  Also,
they required BTS+BSC to run next to the PCU.

The new PCU_Tests_RAW introduced in this patch are the exact opposite:
* they test the PCU alone (attach to PCUIF and Gb interface)
* they don't require BTS or BSC to run
* they don't use NS + BSSGP emulation but raw NS/BSSGP frames to
  test the very NS/BSSGP implementation inside of OsmoPCU.

Change-Id: I7ad76b96974cf0a686ad0f00ccd09d1a9df8b4d5
Related: OS#2890
---
M pcu/PCU_Tests.cfg
A pcu/PCU_Tests.default
A pcu/PCU_Tests_RAW.ttcn
M pcu/gen_links.sh
4 files changed, 427 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/84/12984/3
--
To view, visit https://gerrit.osmocom.org/12984
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ad76b96974cf0a686ad0f00ccd09d1a9df8b4d5
Gerrit-Change-Number: 12984
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max

Change in osmo-ci[master]: jobs: Introduce a tester using "virtual" tests

2019-02-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12993 )

Change subject: jobs: Introduce a tester using "virtual" tests
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19993b287cc948dbdfba9d375f80a7904f96ff4a
Gerrit-Change-Number: 12993
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 21 Feb 2019 10:55:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: Introduce a tester using "virtual" tests

2019-02-21 Thread Holger Freyther

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/12993


Change subject: jobs: Introduce a tester using "virtual" tests
..

jobs: Introduce a tester using "virtual" tests

With mobile, virtphy, osmo-bts-virtual we can run e2e tests without
the need of any hardware. Create a dedicated job for it. This avoids
having to share resources (e.g. lock state/ip allocations) with other
builds.

Change-Id: I19993b287cc948dbdfba9d375f80a7904f96ff4a
---
M jobs/osmo-gsm-tester-runner.yml
1 file changed, 57 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/93/12993/1

diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml
index cfb32e2..e0cfe40 100644
--- a/jobs/osmo-gsm-tester-runner.yml
+++ b/jobs/osmo-gsm-tester-runner.yml
@@ -8,6 +8,7 @@
   - 'osmo-gsm-tester_run-{stage}'
   - 'osmo-gsm-tester_gerrit'
   - 'osmo-gsm-tester_ttcn3'
+  - 'osmo-gsm-tester_virtual'

 - scm:
 name: osmo-gsm-tester-gerrit
@@ -195,3 +196,59 @@
   - junit:
   results: 'trial-*/last_run/trial-*.xml'
   allow-empty-results: true
+
+# virtual tester job
+- job:
+name: 'osmo-gsm-tester_virtual'
+defaults: runner
+node: 'osmocom-master-debian9'
+scm:
+  - 'osmo-gsm-tester-repo'
+triggers:
+  - timed: "H H/2 * * *"
+  - pollscm:
+  cron: "H/5 * * * *"
+builders:
+  - shell: |
+  # make sure no bin artifacts from a previous run remain
+  rm -f *.tgz *.md5
+  - copy_artifact_all
+  - copy_artifact:
+ repo: osmo-gsm-tester_build-osmocom-bb
+  - shell: >
+unlink osmo-gsm-tester/example/resources.conf || true
+
+ln -s resources.conf.virtual osmo-gsm-tester/example/resources.conf
+
+# TODO: We (want to) grant CAP_SYS_NICE for osmo-bts-virtual
+# but with newer cgroup support and the --cpu-rt-runtime/--ulimit
+# rtprio=99 flags we can limit the damage a job can do.
+
+docker run --rm=true \
+  -e HOME=/build \
+  -e JOB_NAME="$JOB_NAME" \
+  -e OSMO_GSM_TESTER_CONF="/build/osmo-gsm-tester/example" \
+  -e OSMO_GSM_TESTER_OPTS="$OSMO_GSM_TESTER_OPTS" \
+  -e BUILD_NUMBER="$BUILD_NUMBER" \
+  -w /build -i \
+  -v "$PWD:/build" \
+  -v "$HOME/bin:/build_bin" \
+  -v "$HOME/.ssh:/home/build/.ssh:ro" \
+  --cap-add=sys_nice \
+  osmocom:deb9_amd64 /bin/bash -c 'LANG="en_US.utf8" 
LC_ALL="en_US.UTF-8" LC_LANG="en_US.UTF-8" 
PATH="$PWD/osmo-gsm-tester/src:${PATH}" 
./osmo-gsm-tester/contrib/jenkins-run.sh'
+publishers:
+  - archive:
+  artifacts: '*-run.tgz, *-bin.tgz'
+  default-excludes: false
+  - junit:
+  results: 'trial-*/last_run/trial-*.xml'
+  allow-empty-results: true
+parameters:
+  - string:
+  name: "OSMO_GSM_TESTER_OPTS"
+  default: "-s nitb_netreg_mass"
+  description: "pass additional command line options to 
osmo-gsm-tester.py, e.g. to select specific suites:scenarios. Default: leave 
empty."
+  - string:
+  name: "OSMO_GSM_TESTER_BRANCH"
+  default: "origin/master"
+  description: "Which branch/sha should be used for testing"

--
To view, visit https://gerrit.osmocom.org/12993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19993b287cc948dbdfba9d375f80a7904f96ff4a
Gerrit-Change-Number: 12993
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther

Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

2019-02-21 Thread dexter

Hello tnt, Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12979

to look at the new patch set (#2).

Change subject: Add option to GSM HR frames to RFC5593 representation
..

Add option to GSM HR frames to RFC5593 representation

There are different specifications around on how a GSM-HR frame should
be encapsulated into an RTP packet. RFC5593 specifies a ToC (Table of
Contents) byte to be prepended in front of the payload data.

The two formats can be distinguished easily by their length. Then the
data can be formatted into the corresponding opposite format and vice
versa.

- Add new VTY rtp-patch options
- Add conversion function

Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Related: OS#3807
---
M include/osmocom/mgcp/mgcp.h
M include/osmocom/mgcp/mgcp_internal.h
M src/libosmo-mgcp/mgcp_network.c
M src/libosmo-mgcp/mgcp_protocol.c
M src/libosmo-mgcp/mgcp_vty.c
5 files changed, 88 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/79/12979/2
--
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-CC: Harald Welte

Change in osmocom-bb[master]: trxcon/scheduler: count number of measurements

2019-02-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12990 )

Change subject: trxcon/scheduler: count number of measurements
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12990
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 21 Feb 2019 10:32:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Update config example

2019-02-21 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12992


Change subject: Update config example
..

Update config example

Add OpenVPN and ping probe entries to example config.

Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Related: SYS#2655
---
M doc/examples/osmo-sysmon.cfg
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/92/12992/1

diff --git a/doc/examples/osmo-sysmon.cfg b/doc/examples/osmo-sysmon.cfg
index e3adab9..e4ed6e6 100644
--- a/doc/examples/osmo-sysmon.cfg
+++ b/doc/examples/osmo-sysmon.cfg
@@ -11,4 +11,6 @@
  get-variable gbproxy-state
 netdev eth0
 netdev tun0
+ping www.siminn.is
+openvpn 127.0.0.1 1234
 file os-image /etc/image-datetime

--
To view, visit https://gerrit.osmocom.org/12992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78025027d48a1213b2a23252c8261d9cb4564027
Gerrit-Change-Number: 12992
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in osmo-gsm-tester[master]: jenkins: Only run journalctl if it is available on the machine

2019-02-21 Thread Holger Freyther

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/12991


Change subject: jenkins: Only run journalctl if it is available on the machine
..

jenkins: Only run journalctl if it is available on the machine

It's not common to run journald inside containers and the journalctl
command is not installed. Don't attempt to run it.

Change-Id: I9dee3cb0d0ca203da77dfa1a793a4e4e5f8593c6
---
M contrib/jenkins-run.sh
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/91/12991/1

diff --git a/contrib/jenkins-run.sh b/contrib/jenkins-run.sh
index 716899e..0b41247 100755
--- a/contrib/jenkins-run.sh
+++ b/contrib/jenkins-run.sh
@@ -30,7 +30,9 @@

 # tar up all results for archiving (optional)
 cd "$trial_dir"
-journalctl -u ofono -o short-precise --since "${time_start}" > "$(readlink 
last_run)/ofono.log"
+if [ -x $(command -v journalctl) ]; then
+  journalctl -u ofono -o short-precise --since "${time_start}" > "$(readlink 
last_run)/ofono.log"
+fi
 tar czf "$base/${trial_dir}-run.tgz" "$(readlink last_run)"
 tar czf "$base/${trial_dir}-bin.tgz" *.md5 *.tgz


--
To view, visit https://gerrit.osmocom.org/12991
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dee3cb0d0ca203da77dfa1a793a4e4e5f8593c6
Gerrit-Change-Number: 12991
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther

Change in osmocom-bb[master]: trxcon/scheduler: count number of measurements

2019-02-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12990


Change subject: trxcon/scheduler: count number of measurements
..

trxcon/scheduler: count number of measurements

Instead of counting both RSSI and ToA measurements separately,
let's have a single counter in trx_lchan_state.meas struct.

Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a
---
M src/host/trxcon/sched_lchan_common.c
M src/host/trxcon/sched_lchan_pdtch.c
M src/host/trxcon/sched_lchan_tchf.c
M src/host/trxcon/sched_lchan_tchh.c
M src/host/trxcon/sched_lchan_xcch.c
M src/host/trxcon/sched_trx.h
6 files changed, 8 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/90/12990/1

diff --git a/src/host/trxcon/sched_lchan_common.c 
b/src/host/trxcon/sched_lchan_common.c
index 921c466..615d81c 100644
--- a/src/host/trxcon/sched_lchan_common.c
+++ b/src/host/trxcon/sched_lchan_common.c
@@ -99,9 +99,9 @@
dl_hdr.num_biterr = bit_error_count;

/* Convert average RSSI to RX level */
-   if (lchan->meas.rssi_num) {
+   if (lchan->meas.num) {
/* RX level: 0 .. 63 in typical GSM notation (dBm + 110) */
-   dbm_avg = lchan->meas.rssi_sum / lchan->meas.rssi_num;
+   dbm_avg = lchan->meas.rssi_sum / lchan->meas.num;
dl_hdr.rx_level = dbm2rxlev(dbm_avg);
} else {
/* No measurements, assuming the worst */
diff --git a/src/host/trxcon/sched_lchan_pdtch.c 
b/src/host/trxcon/sched_lchan_pdtch.c
index aa9cb6a..845ef64 100644
--- a/src/host/trxcon/sched_lchan_pdtch.c
+++ b/src/host/trxcon/sched_lchan_pdtch.c
@@ -75,8 +75,7 @@
/* Update measurements */
lchan->meas.toa256_sum += toa256;
lchan->meas.rssi_sum += rssi;
-   lchan->meas.toa256_num++;
-   lchan->meas.rssi_num++;
+   lchan->meas.num++;

/* Copy burst to buffer of 4 bursts */
offset = buffer + bid * 116;
diff --git a/src/host/trxcon/sched_lchan_tchf.c 
b/src/host/trxcon/sched_lchan_tchf.c
index 5bebe49..cec7daf 100644
--- a/src/host/trxcon/sched_lchan_tchf.c
+++ b/src/host/trxcon/sched_lchan_tchf.c
@@ -77,8 +77,7 @@
/* Update mask and RSSI */
lchan->meas.rssi_sum += rssi;
lchan->meas.toa256_sum += toa256;
-   lchan->meas.rssi_num++;
-   lchan->meas.toa256_num++;
+   lchan->meas.num++;

/* Copy burst to end of buffer of 8 bursts */
offset = buffer + bid * 116 + 464;
diff --git a/src/host/trxcon/sched_lchan_tchh.c 
b/src/host/trxcon/sched_lchan_tchh.c
index 5b7daa3..172f54b 100644
--- a/src/host/trxcon/sched_lchan_tchh.c
+++ b/src/host/trxcon/sched_lchan_tchh.c
@@ -243,8 +243,7 @@
 */
lchan->meas.rssi_sum += rssi;
lchan->meas.toa256_sum += toa256;
-   lchan->meas.rssi_num++;
-   lchan->meas.toa256_num++;
+   lchan->meas.num++;

/* Copy burst to the end of buffer of 6 bursts */
offset = buffer + bid * 116 + 464;
diff --git a/src/host/trxcon/sched_lchan_xcch.c 
b/src/host/trxcon/sched_lchan_xcch.c
index 825fc58..71eb38d 100644
--- a/src/host/trxcon/sched_lchan_xcch.c
+++ b/src/host/trxcon/sched_lchan_xcch.c
@@ -74,8 +74,7 @@
/* Update measurements */
lchan->meas.rssi_sum += rssi;
lchan->meas.toa256_sum += toa256;
-   lchan->meas.rssi_num++;
-   lchan->meas.toa256_num++;
+   lchan->meas.num++;

/* Copy burst to buffer of 4 bursts */
offset = buffer + bid * 116;
diff --git a/src/host/trxcon/sched_trx.h b/src/host/trxcon/sched_trx.h
index f914eee..72d9549 100644
--- a/src/host/trxcon/sched_trx.h
+++ b/src/host/trxcon/sched_trx.h
@@ -181,12 +181,10 @@
uint8_t ul_facch_blocks;

struct {
-   /*! \brief Number of RSSI values */
-   uint8_t rssi_num;
+   /*! \brief Number of measurements */
+   unsigned int num;
/*! \brief Sum of RSSI values */
float rssi_sum;
-   /*! \brief Number of TOA values */
-   uint8_t toa256_num;
/*! \brief Sum of TOA values */
int32_t toa256_sum;
} meas;

--
To view, visit https://gerrit.osmocom.org/12990
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2019-02-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..


Patch Set 12: Code-Review+1

Let's move it forward.


--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 12
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Thu, 21 Feb 2019 10:19:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2019-02-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..

libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

It may happen that either the MS or an EUSE would become
unresponsive during a call independent SS session, e.g.
due to a bug, or a dropped message. In such cases, the
corresponding transaction would remain unfreed forever.

This change introduces a guard timer, that prevents keeping
'stalled' NCSS sessions forever. As soon as it expires, both
sides (i.e. MS and EUSE) are getting notified, and the
transaction is being released.

By default, the timer expires after 30 seconds. As soon as
either the MS, or an EUSE initiates any activity,
the watchdog timer is rescheduled.

The timeout value can be configured from the VTY:

  msc
   ...
   ! Use 0 to disable this timer
   ncss guard-timeout 30

Please note that changing the timeout value at run-time
doesn't affect the existing NCSS sessions, excepting the
case when the timer is disabled at run-time.

This change makes TC_lu_and_ss_session_timeout pass.

Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Related Change-Id: (TTCN) I3e1791773d56617172ae27a46889a1ae4d400e2f
Related: OS#3655
---
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/transaction.h
M src/libmsc/gsm_09_11.c
M src/libmsc/msc_vty.c
M src/libmsc/osmo_msc.c
M tests/test_nodes.vty
6 files changed, 90 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve



diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h
index dab082d..7d3a1e7 100644
--- a/include/osmocom/msc/gsm_data.h
+++ b/include/osmocom/msc/gsm_data.h
@@ -192,6 +192,8 @@

/* Global MNCC guard timer value */
int mncc_guard_timeout;
+   /* Global guard timer value for NCSS sessions */
+   int ncss_guard_timeout;

struct {
struct mgcp_client_conf conf;
diff --git a/include/osmocom/msc/transaction.h 
b/include/osmocom/msc/transaction.h
index 39b09ae..830328b 100644
--- a/include/osmocom/msc/transaction.h
+++ b/include/osmocom/msc/transaction.h
@@ -87,6 +87,8 @@
 * a subscriber after successful Paging Response
 */
struct msgb *msg;
+   /* Inactivity timer, triggers transaction release */
+   struct osmo_timer_list timer_guard;
} ss;
};

diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c
index d2ad0b7..c133656 100644
--- a/src/libmsc/gsm_09_11.c
+++ b/src/libmsc/gsm_09_11.c
@@ -51,6 +51,39 @@
 /* FIXME: choose a proper range */
 static uint32_t new_callref = 0x2001;

+static void ncss_session_timeout_handler(void *_trans)
+{
+   struct gsm_trans *trans = (struct gsm_trans *) _trans;
+   struct osmo_gsup_message gsup_msg = { 0 };
+
+   /* The timeout might be disabled from the VTY */
+   if (trans->net->ncss_guard_timeout == 0)
+   return;
+
+   LOGP(DMM, LOGL_NOTICE, "SS/USSD session timeout, releasing "
+   "transaction (trans=%p, callref=%x)\n", trans, trans->callref);
+
+   /* Indicate connection release to subscriber (if active) */
+   if (trans->conn != NULL) {
+   /* This pair of cause location and value is used by commercial 
networks */
+   msc_send_ussd_release_complete_cause(trans->conn, 
trans->transaction_id,
+   GSM48_CAUSE_LOC_PUN_S_LU, GSM48_CC_CAUSE_NORMAL_UNSPEC);
+   }
+
+   /* Terminate GSUP session with EUSE */
+   gsup_msg.message_type = OSMO_GSUP_MSGT_PROC_SS_ERROR;
+   OSMO_STRLCPY_ARRAY(gsup_msg.imsi, trans->vsub->imsi);
+
+   gsup_msg.session_state = OSMO_GSUP_SESSION_STATE_END;
+   gsup_msg.session_id = trans->callref;
+   gsup_msg.cause = GMM_CAUSE_NET_FAIL;
+
+   osmo_gsup_client_enc_send(trans->net->vlr->gsup_client, _msg);
+
+   /* Finally, release this transaction */
+   trans_free(trans);
+}
+
 /* Entry point for call independent MO SS messages */
 int gsm0911_rcv_nc_ss(struct ran_conn *conn, struct msgb *msg)
 {
@@ -108,6 +141,10 @@
return -ENOMEM;
}

+   /* Init inactivity timer */
+   osmo_timer_setup(>ss.timer_guard,
+   ncss_session_timeout_handler, trans);
+
/* Count active NC SS/USSD sessions */
osmo_counter_inc(conn->network->active_nc_ss);

@@ -116,6 +153,12 @@
cm_service_request_concludes(conn, msg);
}

+   /* (Re)schedule the inactivity timer */
+   if (conn->network->ncss_guard_timeout > 0) {
+   osmo_timer_schedule(>ss.timer_guard,
+

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

2019-02-21 Thread tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
..


Patch Set 12:

(1 comment)

https://gerrit.osmocom.org/#/c/12625/8/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/#/c/12625/8/src/osmo-bsc/osmo_bsc_bssap.c@635
PS8, Line 635:  switch (ct->ch_rate_type) {
> > I can of course change it but I am not sure if this is wise, we might break 
> > the backward compatibi […]
@Max the above comment is irrelevant. This wasn't a mask, naming is correct. 
0xf is a valid value, so is 0x1f. This is now handled properly in the v12 of 
this patch.



--
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 12
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 21 Feb 2019 10:02:49 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

2019-02-21 Thread dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
..


Patch Set 1:

> Yes indeed the only difference between the two formats is the TOC
 > byte.

Thanks for checking this back. I have removed the hr_jumble now. I also
noticed in a second check this morning that it only works when I make an
MO to MT call. When I place a call to somewhere else I get garbled audio.


--
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 21 Feb 2019 09:57:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: PCU: Tests for the BSS/PCU side NS/BSSGP implementations

2019-02-21 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/12984 )

Change subject: PCU: Tests for the BSS/PCU side NS/BSSGP implementations
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12984
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad76b96974cf0a686ad0f00ccd09d1a9df8b4d5
Gerrit-Change-Number: 12984
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Thu, 21 Feb 2019 09:54:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

2019-02-21 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
..


Patch Set 12:

(1 comment)

https://gerrit.osmocom.org/#/c/12625/8/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/#/c/12625/8/src/osmo-bsc/osmo_bsc_bssap.c@635
PS8, Line 635:  switch (ct->ch_rate_type) {
> I can of course change it but I am not sure if this is wise, we might break 
> the backward compatibility of the API.

You can always add wrapper to libosmocore's src/gsm/gsm0808_utils.c to avoid 
dealing with gsm0808_chan_rate_type_speech values/masking directly. This would 
hide the odd naming until we can deprecate it properly. It'd also help with 
documenting/clarifying that naming confusion.



--
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 12
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 21 Feb 2019 09:52:10 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #896

2019-02-21 Thread jenkins

See 


--
[...truncated 107.45 KB...]
Searching INPUT for files to process...
Reading and parsing tag files
Parsing files
Building group list...
Building directory list...
Building namespace list...
Building file list...
Building class list...
Associating documentation with classes...
Computing nesting relations for classes...
Building example list...
Searching for enumerations...
Searching for documented typedefs...
Searching for members imported via using declarations...
Searching for included using directives...
Searching for documented variables...
Building interface member list...
Building member list...
Searching for friends...
Searching for documented defines...
Computing class inheritance relations...
Computing class usage relations...
Flushing cached template relations that have become invalid...
Computing class relations...
Add enum values to enums...
Searching for member function documentation...
Creating members for template instances...
Building page list...
Search for main page...
Computing page relations...
Determining the scope of groups...
Sorting lists...
Freeing entry tree
Determining which enums are documented
Computing member relations...
Building full member lists recursively...
Adding members to member groups.
Computing member references...
Inheriting documentation...
Generating disk names...
Adding source references...
Adding xrefitems...
Sorting member lists...
Computing dependencies between directories...
Generating citations page...
Counting data structures...
Resolving user defined references...
Finding anchors and sections in the documentation...
Transferring function references...
Combining using relations...
Adding members to index pages...
Generating style sheet...
Generating search indices...
Generating example documentation...
Generating file sources...
Generating file documentation...
Generating page documentation...
Generating group documentation...
Generating class documentation...
Generating namespace index...
Generating graph info page...
Generating directory documentation...
Generating index page...
Generating page index...
Generating module index...
Generating namespace index...
Generating namespace member index...
Generating annotated compound index...
Generating alphabetical compound index...
Generating hierarchical class index...
Generating graphical class hierarchy...
Generating member index...
Generating file index...
Generating file member index...
Generating example index...
finalizing index lists...
writing tag file...
Running dot...
Running dot for graph 1/1
lookup cache used 0/65536 hits=0 misses=0
finished...
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p 

 /bin/mkdir -p 
'
/usr/bin/install -c -m 644 usrp_guide.html 

 /usr/bin/install -c -m 644 ../README 
'
cp -r html 

make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in firmware
make[2]: Entering directory

Change in libosmocore[master]: ipa_ccm_idtag_parse*: Fix reported length value

2019-02-21 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/10216 )

Change subject: ipa_ccm_idtag_parse*: Fix reported length value
..


Patch Set 3: Code-Review+1

> @Max: there's an unanswered question from Neels.

Sure, but if I understood it correctly it's not related to commit itself so it 
shouldn't stop us from merging this.

FYI, I've stumbled across related commit 
da5f41cdada843ede0a360dc72601fc2125d0677 in libosmo-netif.


--
To view, visit https://gerrit.osmocom.org/10216
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I435aaa33605bd48635715a2c81aa2d231c1abf51
Gerrit-Change-Number: 10216
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 21 Feb 2019 09:39:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

2019-02-21 Thread tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
..


Patch Set 12: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 12
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 21 Feb 2019 09:36:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: OpenVPN: track interface disconnect

2019-02-21 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12989


Change subject: OpenVPN: track interface disconnect
..

OpenVPN: track interface disconnect

Setup disconnection callback and use it to properly track management
interface availability.

Change-Id: I11b8bc71c1e9cbbf992ee3b7c1c9aae6e6f697e0
Requires: libosmo-netif I905adb2d6191216551a3bcdcd1aec1f96f01612a
Related: SYS#2655
---
M src/client.h
M src/osysmon_openvpn.c
2 files changed, 17 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/89/12989/1

diff --git a/src/client.h b/src/client.h
index d878450..a14019e 100644
--- a/src/client.h
+++ b/src/client.h
@@ -15,7 +15,7 @@
/* name of this client */
const char *name;
/* remote host/IP */
-   const char *remote_host;
+   char *remote_host;
/* remote port */
uint16_t remote_port;
 };
diff --git a/src/osysmon_openvpn.c b/src/osysmon_openvpn.c
index 135a532..148e3b8 100644
--- a/src/osysmon_openvpn.c
+++ b/src/osysmon_openvpn.c
@@ -113,12 +113,26 @@
return NULL;
 }

+static int disconnect_cb(struct osmo_stream_cli *conn)
+{
+   struct openvpn_client *vpn = osmo_stream_cli_get_data(conn);
+
+   update_name(vpn->rem_cfg, "management interface unavailable");
+   vpn->connected = false;
+   talloc_free(vpn->tun_ip);
+   talloc_free(vpn->rem_cfg->remote_host);
+   vpn->tun_ip = NULL;
+   vpn->rem_cfg->remote_host = NULL;
+
+   return 0;
+}
+
 static int connect_cb(struct osmo_stream_cli *conn)
 {
struct openvpn_client *vpn = osmo_stream_cli_get_data(conn);

update_name(vpn->rem_cfg, "management interface incompatible");
-   vpn->connected = true; /* FIXME: there's no callback for lost 
connection to drop this flag */
+   vpn->connected = true;

return 0;
 }
@@ -174,6 +188,7 @@
osmo_stream_cli_set_reconnect_timeout(vpn->mgmt, 60);
osmo_stream_cli_set_read_cb(vpn->mgmt, read_cb);
osmo_stream_cli_set_connect_cb(vpn->mgmt, connect_cb);
+   osmo_stream_cli_set_disconnect_cb(vpn->mgmt, disconnect_cb);

if (osmo_stream_cli_open(vpn->mgmt) < 0) {
OVPN_LOG(vpn->rem_cfg, vpn, "failed to connect to management 
interface\n");
@@ -261,7 +276,6 @@
if (remote)
value_node_add(vn_host, "remote", remote);

-   /* FIXME: there's no way to check client state so this might be 
triggered even while it's reconnecting */
if (vpn->connected) { /* re-trigger state command */
msgb_printf(msg, "state\n");
osmo_stream_cli_send(vpn->mgmt, msg);

--
To view, visit https://gerrit.osmocom.org/12989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11b8bc71c1e9cbbf992ee3b7c1c9aae6e6f697e0
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

2019-02-21 Thread dexter

Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12625

to look at the new patch set (#12).

Change subject: assignment_fsm: fix channel allocator preferences
..

assignment_fsm: fix channel allocator preferences

When the MSC allocates a channel through the ASSIGNMENT REQUEST, it may
ask for a TCH/H and a TCH/F at the same time and tell which of the two
types it prefers.

The process of channel allocation currently selects, based on the BTS,
MSC and MS capabilites exactly one apropriate codec/rate (e.g. TCH/H)
and then tries to allocate it. If that allocation fails, there is no way
to try the second choice and the assignment fails.

For example: The MSC asks for TCH/F and TCH/H, prefering TCH/F, then the
channel allocator will try TCH/F and if it fails (all TCH/F are
currently in use), then TCH/H is never tried.

Since the BSC currently only trys the first best codec/rate that is
supported it also ignores the preference.

Lets fix those problems by including the preference information and both
possible codec/rate settings into the channel allocation decision.

Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Related: OS#3503
---
M include/osmocom/bsc/codec_pref.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/codec_pref.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/codec_pref/codec_pref_test.c
8 files changed, 321 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/25/12625/12
--
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 12
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-CC: tnt

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

2019-02-21 Thread dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
..


Patch Set 11:

(38 comments)

> * See comment about the unsupported value, any reason for this ?
I have now added that value, it was indeed missing.

 > * The preference of codec expressed by the MSC in the assignement
Yes thats true, when I was implementing it it was not clear to me how to
handle the preference and if there is any preference at all so I did not
take that into consideration. I also can not remember seeing anything in
the spec that dictates that the order of the codecs needs to be retained
when making the codec decision. I think thats also not in scope of the
spec since at the end of the day it will be up to the vendor how to
optimize the resource management at the BSC anyway.

However, I think that if we decide to analyze and possibly fix/optimize
the codec selection behavior we should do that in a separate patch.

https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h
File include/osmocom/bsc/codec_pref.h:

https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h@24
PS2, Line 24:const struct gsm_bts *bts, enum rate_pref 
rate_pref);
> in ch_mode_rate, we add a 'bool full_rate', and we also add a 'rate_pref'? […]
The bool in ch_mode_rate and the enum rate_pref are two different things. The 
bool symbols an absolute choice between FR and HR, the enum rate_pref members 
symbolize a set of three different preference choices. I don't think that it is 
a good idea to mix this together.

match_codec_pref() is used here to make an absolute choice based on a 
preference. If the MSC asks for FR and HR (with a preference) we execute 
match_codec_pref() two times to get the choices for the two situations. These 
two are then handed over to the channel allocator which makes the final 
decision based on the channel load.

There is also a problem with the FR/HR flag that not every codec is available 
for FR and HR. So we can not first choose a codec with match_codec_pref() and 
then say if the TCH/F version of the codec is not available, just pick the 
TCH/H version. This does not work for EFR and even for AMR there are problems 
with the S-Bits. Thats why we need the full information for both possible 
situations.


https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/codec_pref.h@24
PS2, Line 24:const struct gsm_bts *bts, enum rate_pref 
rate_pref);
> Also talked about this in person, and obviously ch_mode_rate is an 
> out-argument, while the rate_pref […]
Done


https://gerrit.osmocom.org/#/c/12625/8/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/12625/8/include/osmocom/bsc/gsm_data.h@104
PS8, Line 104:  bool full_rate;
> Just wondering if it wouldn't be worth directly using GSM_LCHAN_xxx constant 
> in there rather than fu […]
Done


https://gerrit.osmocom.org/#/c/12625/8/include/osmocom/bsc/gsm_data.h@104
PS8, Line 104:  bool full_rate;
> We ignore the MS channel preference on purpose and do "late assignment" 
> instead. […]
Done


https://gerrit.osmocom.org/#/c/12625/8/include/osmocom/bsc/gsm_data.h@104
PS8, Line 104:  bool full_rate;
> I hope I understood this right, though. […]
Done


https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h@121
PS4, Line 121:
> We talked in person, and there really are only two possible outcomes: one for 
> an FR and one for an H […]
Done


https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h@300
PS4, Line 300:  /* LCLS FSM */
> this ^ should probably go inside the assignment{} scope instead, see other 
> comments
Done


https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/12625/2/include/osmocom/bsc/gsm_data.h@121
PS2, Line 121:
> Are there really only two possible mode,rate combinations?
Yes, the MSC can only ask for TCH/F and TCH/H at the same time. It may also ask 
only for one of the two. The codec is a different thing. There are more 
combinations possible, but thats a pure capability thing since a TCH may be 
used with several different codecs.


https://gerrit.osmocom.org/#/c/12625/1/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/#/c/12625/1/src/osmo-bsc/abis_rsl.c@1378
PS1, Line 1378: a
> Spelling: 'to' is not needed here I think.
Done


https://gerrit.osmocom.org/#/c/12625/2/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/#/c/12625/2/src/osmo-bsc/abis_rsl.c@1391
PS2, Line 1391: if (!lchan) {
> These changes above make up a separate fix by themselves. […]
I have now separated this.

Change in osmo-sysmon[master]: Add OpenVPN probe

2019-02-21 Thread Max

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12763 )

Change subject: Add OpenVPN probe
..

Add OpenVPN probe

This adds support for OpenVPN status probe which uses OpenVPN's
management interface (configured via 'management 127.0.0.1 1234' in
OpenVPN's config).

The output looks as follows:
...
  OpenVPN
127.0.0.1:1234
  status: CONNECTED
  tunnel: 10.8.0.15
  remote: 144.76.43.77:1194
localhost:4242
  status: management interface incompatible
127.0.0.1:
  status: management interface unavailable
...

We show tunnel's IP (if available) as well as remote (OpenVPN server
itself) address/port in addition to general connection status. If
management interface is unavailable it's reported as such. If we've
managed to establish connection with a given management interface but
are unable to obtain expected information than we report this
incompatibility as well.

Related: SYS#2655
Change-Id: I4493e19b9a09dcebd289457eacd1719f7f8cc31c
---
M configure.ac
M contrib/jenkins.sh
M src/Makefile.am
M src/client.c
M src/client.h
M src/osysmon.h
M src/osysmon_main.c
A src/osysmon_openvpn.c
8 files changed, 342 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

Objections:
  Pau Espin Pedrol: I would prefer this is not merged as is



diff --git a/configure.ac b/configure.ac
index d98de89..44a040c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -42,6 +42,7 @@
 PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.11.0)
 PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 0.11.0)
 PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.4.0)
 PKG_CHECK_MODULES(LIBMNL, libmnl)
 dnl FIXME: bump to 1.10.0 once it's available on build slaves and remove 
workaround from osysmon_ping.c
 PKG_CHECK_MODULES(LIBOPING, liboping >= 1.9.0)
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index b1529c4..631f95a 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -25,6 +25,9 @@
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"

+osmo-build-dep.sh libosmo-abis
+osmo-build-dep.sh libosmo-netif "" '--disable-doxygen'
+
 set +x
 echo
 echo
diff --git a/src/Makefile.am b/src/Makefile.am
index f639023..f9b79f2 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -9,6 +9,7 @@
-Wall \
$(LIBOSMOCORE_CFLAGS) \
$(LIBOSMOGSM_CFLAGS) \
+   $(LIBOSMONETIF_CFLAGS) \
$(NULL)

 AM_LDFLAGS = \
@@ -22,12 +23,13 @@

 noinst_LTLIBRARIES = libintern.la
 libintern_la_SOURCES = simple_ctrl.c client.c
-libintern_la_LIBADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS)
+libintern_la_LIBADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(LIBOSMONETIF_LIBS)

 osmo_sysmon_CFLAGS = $(LIBMNL_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOPING_CFLAGS) 
$(AM_CFLAGS)

 osmo_sysmon_LDADD = $(LDADD) \
$(LIBOSMOVTY_LIBS) \
+   $(LIBOSMONETIF_LIBS) \
$(LIBMNL_LIBS) \
$(LIBOPING_LIBS) \
$(NULL)
@@ -39,6 +41,7 @@
osysmon_rtnl.c \
osysmon_file.c \
osysmon_ping.c \
+   osysmon_openvpn.c \
osysmon_main.c \
$(NULL)

diff --git a/src/client.c b/src/client.c
index 6b37fc6..758884d 100644
--- a/src/client.c
+++ b/src/client.c
@@ -27,6 +27,7 @@
 #include 

 #include 
+#include 

 #include "client.h"

@@ -71,3 +72,24 @@

return talloc_asprintf(ctx, "%s:%u", cfg->remote_host, 
cfg->remote_port);
 }
+
+struct osmo_stream_cli *make_tcp_client(struct host_cfg *cfg)
+{
+   struct osmo_stream_cli *cl = osmo_stream_cli_create(cfg);
+   if (cl) {
+   osmo_stream_cli_set_addr(cl, cfg->remote_host);
+   osmo_stream_cli_set_port(cl, cfg->remote_port);
+   }
+
+   return cl;
+}
+
+void update_name(struct host_cfg *cfg, const char *new_name)
+{
+   osmo_talloc_replace_string(cfg, (char **)>name, new_name);
+}
+
+void update_host(struct host_cfg *cfg, const char *new_host)
+{
+   osmo_talloc_replace_string(cfg, (char **)>remote_host, new_host);
+}
diff --git a/src/client.h b/src/client.h
index 605ddd7..d878450 100644
--- a/src/client.h
+++ b/src/client.h
@@ -23,3 +23,8 @@
 struct host_cfg *host_cfg_alloc(void *ctx, const char *name, const char *host, 
uint16_t port);
 bool match_config(const struct host_cfg *cfg, const char *match, enum 
match_kind k);
 char *make_authority(void *ctx, const struct host_cfg *cfg);
+
+struct osmo_stream_cli *make_tcp_client(struct host_cfg *cfg);
+
+void update_name(struct host_cfg *cfg, const char *new_name);
+void update_host(struct host_cfg *cfg, const char *new_host);
diff --git a/src/osysmon.h b/src/osysmon.h
index df8bf8d..2f82c47 100644
--- a/src/osysmon.h
+++ b/src/osysmon.h
@@ -15,6 +15,8 @@
struct rtnl_client_state *rcs;
/* list of 'struct ctrl client' */
struct llist_head ctrl_clients;
+   /*

89 matches

Mail list logo