Build failure of network:osmocom:nightly/osmo-sysmon in Raspbian_9.0/armv7l
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Raspbian_9.0/armv7l
Package network:osmocom:nightly/osmo-sysmon failed to build in
Raspbian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 108s] #define VERSION "0.1.0"
[ 108s] #define STDC_HEADERS 1
[ 108s] #define HAVE_SYS_TYPES_H 1
[ 108s] #define HAVE_SYS_STAT_H 1
[ 108s] #define HAVE_STDLIB_H 1
[ 108s] #define HAVE_STRING_H 1
[ 108s] #define HAVE_MEMORY_H 1
[ 108s] #define HAVE_STRINGS_H 1
[ 108s] #define HAVE_INTTYPES_H 1
[ 108s] #define HAVE_STDINT_H 1
[ 108s] #define HAVE_UNISTD_H 1
[ 108s] #define HAVE_DLFCN_H 1
[ 108s] #define LT_OBJDIR ".libs/"
[ 108s]
[ 108s] configure: exit 1
[ 108s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 108s] debian/rules:45: recipe for target 'build' failed
[ 108s] make: *** [build] Error 2
[ 108s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 108s]
[ 108s] obs-arm-6 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:32:57
UTC 2019.
[ 108s]
[ 108s] ### VM INTERACTION START ###
[ 111s] [ 87.782297] sysrq: SysRq : Power Off
[ 111s] [ 87.784011] reboot: Power down
[ 112s] ### VM INTERACTION END ###
[ 112s]
[ 112s] obs-arm-6 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:33:01
UTC 2019.
[ 112s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in Debian_9.0/armv7l
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_9.0/armv7l
Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 180s] #define PACKAGE_NAME "osmo-sysmon"
[ 180s] #define PACKAGE_TARNAME "osmo-sysmon"
[ 180s] #define PACKAGE_VERSION "0.1.0"
[ 180s] #define PACKAGE_STRING "osmo-sysmon 0.1.0"
[ 180s] #define PACKAGE_BUGREPORT "open...@lists.osmocom.org"
[ 180s] #define PACKAGE_URL ""
[ 180s] #define PACKAGE "osmo-sysmon"
[ 180s] #define VERSION "0.1.0"
[ 180s] #define STDC_HEADERS 1
[ 180s] #define HAVE_SYS_TYPES_H 1
[ 180s] #define HAVE_SYS_STAT_H 1
[ 180s] #define HAVE_STDLIB_H 1
[ 180s] #define HAVE_STRING_H 1
[ 180s] #define HAVE_MEMORY_H 1
[ 180s] #define HAVE_STRINGS_H 1
[ 180s] #define HAVE_INTTYPES_H 1
[ 180s] #define HAVE_STDINT_H 1
[ 180s] #define HAVE_UNISTD_H 1
[ 180s] #define HAVE_DLFCN_H 1
[ 180s] #define LT_OBJDIR ".libs/"
[ 180s]
[ 180s] configure: exit 1
[ 180s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 182s] debian/rules:45: reci[ 130.847902] sysrq: SysRq : Power Off
[ 182s] [ 130.850107] reboot: Power down
[ 183s] ### VM INTERACTION END ###
[ 183s]
[ 183s] armbuild14 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:28:55
UTC 2019.
[ 183s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_18.04/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_18.04/i586
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_18.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 95s] #define STDC_HEADERS 1
[ 95s] #define HAVE_SYS_TYPES_H 1
[ 95s] #define HAVE_SYS_STAT_H 1
[ 95s] #define HAVE_STDLIB_H [ 84.192261] serial8250: too much work for irq4
[ 95s] 1
[ 96s] #define HAVE_STRING_H 1
[ 96s] #define HAVE_MEMORY_H 1
[ 96s] #define HAVE_STRINGS_H 1
[ 96s] #define HAVE_INTTYPES_H 1
[ 96s] #define HAVE_STDINT_H 1
[ 96s] #define HAVE_UNISTD_H 1
[ 96s] #define HAVE_DLFCN_H 1
[ 96s] #define LT_OBJDIR ".libs/"
[ 96s]
[ 96s] configure: exit 1
[ 96s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu
--libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 96s] debian/rules:45: recipe for target 'build' failed
[ 96s] make: *** [build] Error 2
[ 96s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 96s]
[ 96s] lamb21 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:03:36 UTC
2019.
[ 96s]
[ 96s] ### VM INTERACTION START ###
[ 99s] [ 87.361533] sysrq: SysRq : Power Off
[ 99s] [ 87.369453] reboot: Power down
[ 99s] ### VM INTERACTION END ###
[ 99s]
[ 99s] lamb21 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:03:40 UTC
2019.
[ 99s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_17.10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 75s] #define VERSION "0.1.0"
[ 75s] #define STDC_HEADERS 1
[ 75s] #define HAVE_SYS_TYPES_H 1
[ 75s] #define HAVE_SYS_STAT_H 1
[ 75s] #define HAVE_STDLIB_H 1
[ 75s] #define HAVE_STRING_H 1
[ 75s] #define HAVE_MEMORY_H 1
[ 75s] #define HAVE_STRINGS_H 1
[ 75s] #define HAVE_INTTYPES_H 1
[ 75s] #define HAVE_STDINT_H 1
[ 75s] #define HAVE_UNISTD_H 1
[ 75s] #define HAVE_DLFCN_H 1
[ 75s] #define LT_OBJDIR ".libs/"
[ 75s]
[ 75s] configure: exit 1
[ 75s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 75s] debian/rules:45: recipe for target 'build' failed
[ 75s] make: *** [build] Error 2
[ 75s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 75s]
[ 75s] build34 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:02:39
UTC 2019.
[ 75s]
[ 75s] ### VM INTERACTION START ###
[ 79s] [ 65.775105] sysrq: SysRq : Power Off
[ 79s] [ 65.777831] reboot: Power down
[ 79s] ### VM INTERACTION END ###
[ 79s]
[ 79s] build34 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:02:43
UTC 2019.
[ 79s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_18.04/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_18.04/x86_64
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_18.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 95s] #define VERSION "0.1.0"
[ 95s] #define STDC_HEADERS 1
[ 95s] #define HAVE_SYS_TYPES_H 1
[ 95s] #define HAVE_SYS_STAT_H 1
[ 95s] #define HAVE_STDLIB_H 1
[ 95s] #define HAVE_STRING_H 1
[ 95s] #define HAVE_MEMORY_H 1
[ 95s] #define HAVE_STRINGS_H 1
[ 95s] #define HAVE_INTTYPES_H 1
[ 95s] #define HAVE_STDINT_H 1
[ 95s] #define HAVE_UNISTD_H 1
[ 95s] #define HAVE_DLFCN_H 1
[ 95s] #define LT_OBJDIR ".libs/"
[ 95s]
[ 95s] configure: exit 1
[ 95s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 95s] debian/rules:45: recipe for target 'build' failed
[ 95s] make: *** [build] Error 2
[ 95s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 95s]
[ 95s] lamb57 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:03:03 UTC
2019.
[ 95s]
[ 95s] ### VM INTERACTION START ###
[ 98s] [ 87.265715] sysrq: SysRq : Power Off
[ 98s] [ 87.273572] reboot: Power down
[ 98s] ### VM INTERACTION END ###
[ 98s]
[ 98s] lamb57 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:03:06 UTC
2019.
[ 98s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in Debian_9.0/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_9.0/i586
Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 75s] #define HAVE_SYS_TYPES_H 1
[ 75s] #define HAVE_SYS_STAT_H 1
[ 75s] #define HAVE_STDLIB_H 1
[ 75s] #define HAVE_STRING_H 1
[ 75s] #define HAVE_MEMORY_H 1
[ 75s] #define HAVE_STRINGS_H 1
[ 75s] #define HAVE_INTTYPES_H 1
[ 75s] #define HAVE_STDINT_H 1
[ 75s] #define HAVE_UNISTD_H 1
[ 75s] #define HAVE_DLFCN_H 1
[ 63.060310] serial8250: too much work for irq4
[ 75s]
[ 75s] #define LT_OBJDIR ".libs/"
[ 75s]
[ 75s] configure: exit 1
[ 75s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr
--includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu
--libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 75s] debian/rules:45: recipe for target 'build' failed
[ 75s] make: *** [build] Error 2
[ 75s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 75s]
[ 75s] lamb18 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:02:42 UTC
2019.
[ 75s]
[ 75s] ### VM INTERACTION START ###
[ 78s] [ 66.281009] sysrq: SysRq : Power Off
[ 78s] [ 66.287555] reboot: Power down
[ 78s] ### VM INTERACTION END ###
[ 79s]
[ 79s] lamb18 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:02:46 UTC
2019.
[ 79s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_17.10/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_17.10/i586
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_17.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 77s] #define VERSION "0.1.0"
[ 77s] #define STDC_HEADERS 1
[ 77s] #define HAVE_SYS_TYPES_H 1
[ 77s] #define HAVE_SYS_STAT_H 1
[ 77s] #define HAVE_STDLIB_H 1
[ 77s] #define HAVE_STRING_H 1
[ 77s] #define HAVE_MEMORY_H 1
[ 77s] #define HAVE_STRINGS_H 1
[ 77s] #define HAVE_INTTYPES_H 1
[ 77s] #define HAVE_STDINT_H 1
[ 77s] #define HAVE_UNISTD_H 1
[ 77s] #define HAVE_DLFCN_H 1
[ 77s] #define LT_OBJDIR ".libs/"
[ 77s]
[ 77s] configure: exit 1
[ 77s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu
--libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 77s] debian/rules:45: recipe for target 'build' failed
[ 77s] make: *** [build] Error 2
[ 77s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 77s]
[ 77s] lamb22 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:02:10 UTC
2019.
[ 77s]
[ 77s] ### VM INTERACTION START ###
[ 80s] [ 69.123836] sysrq: SysRq : Power Off
[ 80s] [ 69.130351] reboot: Power down
[ 80s] ### VM INTERACTION END ###
[ 80s]
[ 80s] lamb22 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:02:13 UTC
2019.
[ 80s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_18.10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_18.10/x86_64
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_18.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 99s] #define PACKAGE "osmo-sysmon"
[ 99s] #define VERSION "0.1.0"
[ 99s] #define STDC_HEADERS 1
[ 99s] #define HAVE_SYS_TYPES_H 1
[ 99s] #define HAVE_SYS_STAT_H 1
[ 99s] #define HAVE_STDLIB_H 1
[ 99s] #define HAVE_STRING_H 1
[ 99s] #define HAVE_MEMORY_H 1
[ 99s] #define HAVE_STRINGS_H 1
[ 99s] #define HAVE_INTTYPES_H 1
[ 99s] #define HAVE_STDINT_H 1
[ 99s] #define HAVE_UNISTD_H 1
[ 99s] #define HAVE_DLFCN_H 1
[ 99s] #define LT_OBJDIR ".libs/"
[ 99s]
[ 99s] configure: exit 1
[ 99s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 99s] make: *** [debian/rules:45: build] Error 2
[ 99s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 99s]
[ 99s] lamb27 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:01:51 UTC
2019.
[ 99s]
[ 99s] ### VM INTERACTION START ###
[ 102s] [ 90.866410] sysrq: SysRq : Power Off
[ 102s] [ 90.873425] reboot: Power down
[ 102s] ### VM INTERACTION END ###
[ 102s]
[ 102s] lamb27 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:01:54 UTC
2019.
[ 102s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in Debian_9.0/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_9.0/x86_64
Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 71s] #define VERSION "0.1.0"
[ 71s] #define STDC_HEADERS 1
[ 71s] #define HAVE_SYS_TYPES_H 1
[ 71s] #define HAVE_SYS_STAT_H 1
[ 71s] #define HAVE_STDLIB_H 1
[ 71s] #define HAVE_STRING_H 1
[ 71s] #define HAVE_MEMORY_H 1
[ 71s] #define HAVE_STRINGS_H 1
[ 71s] #define HAVE_INTTYPES_H 1
[ 71s] #define HAVE_STDINT_H 1
[ 71s] #define HAVE_UNISTD_H 1
[ 71s] #define HAVE_DLFCN_H 1
[ 71s] #define LT_OBJDIR ".libs/"
[ 71s]
[ 71s] configure: exit 1
[ 71s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu
--libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 71s] debian/rules:45: recipe for target 'build' failed
[ 71s] make: *** [build] Error 2
[ 71s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 71s]
[ 71s] lamb26 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:00:47 UTC
2019.
[ 71s]
[ 71s] ### VM INTERACTION START ###
[ 74s] [ 61.324485] sysrq: SysRq : Power Off
[ 74s] [ 61.329665] reboot: Power down
[ 74s] ### VM INTERACTION END ###
[ 74s]
[ 74s] lamb26 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 03:00:51 UTC
2019.
[ 74s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sysmon in Debian_9.0/armv7l
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_9.0/armv7l
Package network:osmocom:latest/osmo-sysmon failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:latest osmo-sysmon
Last lines of build log:
[ 168s] #define VERSION "0.1.0"
[ 168s] #define STDC_HEADERS 1
[ 168s] #define HAVE_SYS_TYPES_H 1
[ 168s] #define HAVE_SYS_STAT_H 1
[ 168s] #define HAVE_STDLIB_H 1
[ 168s] #define HAVE_STRING_H 1
[ 168s] #define HAVE_MEMORY_H 1
[ 168s] #define HAVE_STRINGS_H 1
[ 168s] #define HAVE_INTTYPES_H 1
[ 168s] #define HAVE_STDINT_H 1
[ 168s] #define HAVE_UNISTD_H 1
[ 168s] #define HAVE_DLFCN_H 1
[ 168s] #define LT_OBJDIR ".libs/"
[ 168s]
[ 168s] configure: exit 1
[ 168s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 168s] debian/rules:45: recipe for target 'build' failed
[ 168s] make: *** [build] Error 2
[ 168s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 168s]
[ 168s] armbuild10 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:29:50
UTC 2019.
[ 168s]
[ 168s] ### VM INTERACTION START ###
[ 170s] [ 132.460965] sysrq: SysRq : Power Off
[ 170s] [ 132.463159] reboot: Power down
[ 170s] ### VM INTERACTION END ###
[ 170s]
[ 170s] armbuild10 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:29:54
UTC 2019.
[ 170s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sysmon in Raspbian_9.0/armv7l
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Raspbian_9.0/armv7l
Package network:osmocom:latest/osmo-sysmon failed to build in
Raspbian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:latest osmo-sysmon
Last lines of build log:
[ 115s] #define VERSION "0.1.0"
[ 115s] #define STDC_HEADERS 1
[ 115s] #define HAVE_SYS_TYPES_H 1
[ 115s] #define HAVE_SYS_STAT_H 1
[ 115s] #define HAVE_STDLIB_H 1
[ 115s] #define HAVE_STRING_H 1
[ 115s] #define HAVE_MEMORY_H 1
[ 115s] #define HAVE_STRINGS_H 1
[ 115s] #define HAVE_INTTYPES_H 1
[ 115s] #define HAVE_STDINT_H 1
[ 115s] #define HAVE_UNISTD_H 1
[ 115s] #define HAVE_DLFCN_H 1
[ 115s] #define LT_OBJDIR ".libs/"
[ 115s]
[ 115s] configure: exit 1
[ 115s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 115s] debian/rules:45: recipe for target 'build' failed
[ 115s] make: *** [build] Error 2
[ 115s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 115s]
[ 115s] armbuild01 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:50
UTC 2019.
[ 115s]
[ 115s] ### VM INTERACTION START ###
[ 118s] [ 92.850699] SysRq : Power Off
[ 118s] [ 92.851682] reboot: Power down
[ 118s] ### VM INTERACTION END ###
[ 118s]
[ 118s] armbuild01 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:53
UTC 2019.
[ 118s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sysmon in Debian_9.0/aarch64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_9.0/aarch64
Package network:osmocom:latest/osmo-sysmon failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-sysmon
Last lines of build log:
[ 121s] #define VERSION "0.1.0"
[ 121s] #define STDC_HEADERS 1
[ 121s] #define HAVE_SYS_TYPES_H 1
[ 121s] #define HAVE_SYS_STAT_H 1
[ 121s] #define HAVE_STDLIB_H 1
[ 121s] #define HAVE_STRING_H 1
[ 121s] #define HAVE_MEMORY_H 1
[ 121s] #define HAVE_STRINGS_H 1
[ 121s] #define HAVE_INTTYPES_H 1
[ 121s] #define HAVE_STDINT_H 1
[ 121s] #define HAVE_UNISTD_H 1
[ 121s] #define HAVE_DLFCN_H 1
[ 121s] #define LT_OBJDIR ".libs/"
[ 121s]
[ 121s] configure: exit 1
[ 121s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr
--includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/aarch64-linux-gnu
--libexecdir=${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 121s] debian/rules:45: recipe for target 'build' failed
[ 121s] make: *** [build] Error 2
[ 121s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 121s]
[ 121s] obs-arm-4 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:52
UTC 2019.
[ 121s]
[ 121s] ### VM INTERACTION START ###
[ 123s] [ 102.246318] sysrq: SysRq : Power Off
[ 123s] [ 102.250859] reboot: Power down
[ 123s] ### VM INTERACTION END ###
[ 123s]
[ 123s] obs-arm-4 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:56
UTC 2019.
[ 123s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sysmon in xUbuntu_18.10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/xUbuntu_18.10/x86_64
Package network:osmocom:latest/osmo-sysmon failed to build in
xUbuntu_18.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-sysmon
Last lines of build log:
[ 114s] #define PACKAGE "osmo-sysmon"
[ 114s] #define VERSION "0.1.0"
[ 114s] #define STDC_HEADERS 1
[ 114s] #define HAVE_SYS_TYPES_H 1
[ 114s] #define HAVE_SYS_STAT_H 1
[ 114s] #define HAVE_STDLIB_H 1
[ 114s] #define HAVE_STRING_H 1
[ 114s] #define HAVE_MEMORY_H 1
[ 114s] #define HAVE_STRINGS_H 1
[ 114s] #define HAVE_INTTYPES_H 1
[ 114s] #define HAVE_STDINT_H 1
[ 114s] #define HAVE_UNISTD_H 1
[ 114s] #define HAVE_DLFCN_H 1
[ 114s] #define LT_OBJDIR ".libs/"
[ 114s]
[ 114s] configure: exit 1
[ 114s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 114s] make: *** [debian/rules:45: build] Error 2
[ 114s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 114s]
[ 114s] cloud121 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:59
UTC 2019.
[ 114s]
[ 114s] ### VM INTERACTION START ###
[ 117s] [ 96.423079] sysrq: SysRq : Power Off
[ 117s] [ 96.427490] reboot: Power down
[ 118s] ### VM INTERACTION END ###
[ 118s]
[ 118s] cloud121 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:29:04
UTC 2019.
[ 118s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sysmon in xUbuntu_17.10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/xUbuntu_17.10/x86_64
Package network:osmocom:latest/osmo-sysmon failed to build in
xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-sysmon
Last lines of build log:
[ 73s] #define VERSION "0.1.0"
[ 73s] #define STDC_HEADERS 1
[ 73s] #define HAVE_SYS_TYPES_H 1
[ 73s] #define HAVE_SYS_STAT_H 1
[ 73s] #define HAVE_STDLIB_H 1
[ 73s] #define HAVE_STRING_H 1
[ 73s] #define HAVE_MEMORY_H 1
[ 73s] #define HAVE_STRINGS_H 1
[ 73s] #define HAVE_INTTYPES_H 1
[ 73s] #define HAVE_STDINT_H 1
[ 73s] #define HAVE_UNISTD_H 1
[ 73s] #define HAVE_DLFCN_H 1
[ 73s] #define LT_OBJDIR ".libs/"
[ 73s]
[ 73s] configure: exit 1
[ 73s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 73s] debian/rules:45: recipe for target 'build' failed
[ 73s] make: *** [build] Error 2
[ 73s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 73s]
[ 73s] lamb27 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:10 UTC
2019.
[ 73s]
[ 73s] ### VM INTERACTION START ###
[ 76s] [ 65.315863] sysrq: SysRq : Power Off
[ 76s] [ 65.322536] reboot: Power down
[ 76s] ### VM INTERACTION END ###
[ 76s]
[ 76s] lamb27 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:14 UTC
2019.
[ 76s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sysmon in Debian_9.0/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_9.0/x86_64
Package network:osmocom:latest/osmo-sysmon failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-sysmon
Last lines of build log:
[ 73s] "0.1.0"
[ 73s] #define STDC_HEADERS 1
[ 73s] #define HAVE_SYS_TYPES_H 1
[ 73s] #define HAVE_SYS_STAT_H 1
[ 73s] #define HAVE_STDLIB_H 1
[ 73s] #define HAVE_STRING_H 1
[ 73s] #define HAVE_MEMORY_H 1
[ 73s] #define HAVE_STRINGS_H 1
[ 73s] #define HAVE_INTTYPES_H 1
[ 73s] #define HAVE_STDINT_H 1
[ 73s] #define HAVE_UNISTD_H 1
[ 73s] #define HAVE_DLFCN_H 1
[ 73s] #define LT_OBJDIR ".libs/"
[ 73s]
[ 73s] configure: exit 1
[ 73s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu
--libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 73s] debian/rules:45: recipe for target 'build' failed
[ 73s] make: *** [build] Error 2
[ 73s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 73s]
[ 73s] lamb24 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:22 UTC
2019.
[ 73s]
[ 73s] ### VM INTERACTION START ###
[ 77s] [ 64.922642] sysrq: SysRq : Power Off
[ 77s] [ 64.930521] reboot: Power down
[ 77s] ### VM INTERACTION END ###
[ 77s]
[ 77s] lamb24 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:26 UTC
2019.
[ 77s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sysmon in xUbuntu_18.04/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/xUbuntu_18.04/x86_64
Package network:osmocom:latest/osmo-sysmon failed to build in
xUbuntu_18.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-sysmon
Last lines of build log:
[ 98s] #define VERSION "0.1.0"
[ 98s] #define STDC_HEADERS 1
[ 98s] #define HAVE_SYS_TYPES_H 1
[ 98s] #define HAVE_SYS_STAT_H 1
[ 98s] #define HAVE_STDLIB_H 1
[ 98s] #define HAVE_STRING_H 1
[ 98s] #define HAVE_MEMORY_H 1
[ 98s] #define HAVE_STRINGS_H 1
[ 98s] #define HAVE_INTTYPES_H 1
[ 98s] #define HAVE_STDINT_H 1
[ 98s] #define HAVE_UNISTD_H 1
[ 98s] #define HAVE_DLFCN_H 1
[ 98s] #define LT_OBJDIR ".libs/"
[ 98s]
[ 98s] configure: exit 1
[ 98s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 98s] debian/rules:45: recipe for target 'build' failed
[ 98s] make: *** [build] Error 2
[ 98s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 98s]
[ 98s] lamb03 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:34 UTC
2019.
[ 98s]
[ 98s] ### VM INTERACTION START ###
[ 101s] [ 90.110346] sysrq: SysRq : Power Off
[ 102s] [ 90.117859] reboot: Power down
[ 102s] ### VM INTERACTION END ###
[ 102s]
[ 102s] lamb03 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:38 UTC
2019.
[ 102s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sysmon in Debian_9.0/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_9.0/i586
Package network:osmocom:latest/osmo-sysmon failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:latest osmo-sysmon
Last lines of build log:
[ 74s] #define HAVE_SYS_TYPES_H 1
[ 74s] #define HAVE_SYS_STAT_H 1
[ 74s] #define HAVE_STDLIB_H 1
[ 74s] #define HAVE_STRING_H 1
[ 74s] #define HAVE_MEMORY_H 1
[ 74s] #define HAVE_STRINGS_H 1
[ 74s] #define HAVE_INTTYPES_H 1
[ 74s] #define HAVE_STDINT_H 1
[ 74s] #define HAVE_UNISTD_H 1
[ 74s] #define HAVE_DLFCN_H 1
[ 61.907642] serial8250: too much work for irq4
[ 74s]
[ 74s] #define LT_OBJDIR ".libs/"
[ 74s]
[ 74s] configure: exit 1
[ 74s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr
--includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu
--libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 74s] debian/rules:45: recipe for target 'build' failed
[ 74s] make: *** [build] Error 2
[ 74s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 74s]
[ 74s] lamb04 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:10 UTC
2019.
[ 74s]
[ 74s] ### VM INTERACTION START ###
[ 77s] [ 65.219675] sysrq: SysRq : Power Off
[ 77s] [ 65.227657] reboot: Power down
[ 77s] ### VM INTERACTION END ###
[ 77s]
[ 77s] lamb04 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 01:28:13 UTC
2019.
[ 77s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-ttcn3-hacks[master]: BTS: use PCU-related test cases as version string
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13305 ) Change subject: BTS: use PCU-related test cases as version string .. Patch Set 3: > > why are you copy-pasting a single line to dozens of functions? I > don't understand why this patch cannot simply be a single-line diff > that changes only one line, replacing the static string with > testcasename() ? > > Because there're both PCU-related and unrelated test cases. I'd > like to report testcasename() in place of PCU version only for the > former hence copy-paste. Am I missing something? Well, then please either define a very simple non-parametric template and send that from every test case, or (more within our coding style) add a function and call it. I don't think we want to copy+paste the identical line so many times all over. Thanks! -- To view, visit https://gerrit.osmocom.org/13305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ef9e46061ef116529bdea196050f914804615b3 Gerrit-Change-Number: 13305 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 22:02:39 + Gerrit-HasComments: No Gerrit-HasLabels: No
Build failure of network:osmocom:nightly/libosmo-netif in Debian_8.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_8.0/i586 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 106s] | #define HAVE_DLFCN_H 1 [ 106s] | #define LT_OBJDIR ".libs/" [ 106s] | #define STDC_HEADERS 1 [ 106s] | #define HAVE_EXECINFO_H 1 [ 106s] | #define HAVE_SYS_SELECT_H 1 [ 106s] | #define HAVE_SYS_SOCKET_H 1 [ 106s] | #define HAVE_SYSLOG_H 1 [ 106s] | #define HAVE_CTYPE_H 1 [ 106s] | #define HAVE_LIBSCTP 1 [ 106s] | #define HAVE_PCAP_H 1 [ 106s] | [ 106s] | configure: exit 0 [ 106s] [ 106s] debian/rules:27: recipe for target 'override_dh_auto_test' failed [ 106s] make[1]: *** [override_dh_auto_test] Error 1 [ 106s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 106s] debian/rules:13: recipe for target 'build' failed [ 106s] make: *** [build] Error 2 [ 106s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 106s] [ 106s] wildcard2 failed "build libosmo-netif_0.4.0.24.b3e3.dsc" at Wed Mar 20 20:05:48 UTC 2019. [ 106s] [ 106s] ### VM INTERACTION START ### [ 107s] Powering off. [ 107s] [ 90.811430] reboot: Power down [ 108s] ### VM INTERACTION END ### [ 108s] [ 108s] wildcard2 failed "build libosmo-netif_0.4.0.24.b3e3.dsc" at Wed Mar 20 20:05:51 UTC 2019. [ 108s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in openbsc[master]: osmo-bsc-mgcp.service: Fix parsing of cmdline option s
Pau Espin Pedrol has uploaded this change for review. (
https://gerrit.osmocom.org/13348
Change subject: osmo-bsc-mgcp.service: Fix parsing of cmdline option s
..
osmo-bsc-mgcp.service: Fix parsing of cmdline option s
>From journald output:
/usr/bin/osmo-bsc_mgcp: invalid option -- 's'
Change-Id: I995d2f5909640fc007aa39dd6c6b54ff97ee45f7
---
M openbsc/src/osmo-bsc_mgcp/mgcp_main.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/48/13348/1
diff --git a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
index 6cf9ab7..419f852 100644
--- a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
+++ b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
@@ -102,7 +102,7 @@
{0, 0, 0, 0},
};
- c = getopt_long(argc, argv, "hc:VD", long_options,
_index);
+ c = getopt_long(argc, argv, "hc:sVD", long_options,
_index);
if (c == -1)
break;
--
To view, visit https://gerrit.osmocom.org/13348
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I995d2f5909640fc007aa39dd6c6b54ff97ee45f7
Gerrit-Change-Number: 13348
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol
Change in openbsc[master]: Write configuration correctly from vty (alert notifications)
Max has posted comments on this change. ( https://gerrit.osmocom.org/13320 ) Change subject: Write configuration correctly from vty (alert notifications) .. Patch Set 3: The failure seems to be related to https://osmocom.org/issues/3851 Please re-trigger tests once it's resolved. -- To view, visit https://gerrit.osmocom.org/13320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b0363fa34dd9ac0a221844974e4ebf7465b56f4 Gerrit-Change-Number: 13320 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 17:07:07 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ttcn3-hacks[master]: BTS: use PCU-related test cases as version string
Max has posted comments on this change. ( https://gerrit.osmocom.org/13305 ) Change subject: BTS: use PCU-related test cases as version string .. Patch Set 3: > why are you copy-pasting a single line to dozens of functions? I don't > understand why this patch cannot simply be a single-line diff that changes > only one line, replacing the static string with testcasename() ? Because there're both PCU-related and unrelated test cases. I'd like to report testcasename() in place of PCU version only for the former hence copy-paste. Am I missing something? -- To view, visit https://gerrit.osmocom.org/13305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ef9e46061ef116529bdea196050f914804615b3 Gerrit-Change-Number: 13305 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 16:36:54 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13347 ) Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h@8 PS1, Line 8: #define PCU_IF_VERSION 0x09 > Should we bump version as well? we only do that if we make incompatible changes like size/layout of structures. This patch is simply adding a new message type which any older receivers would log+drop, so it's safe to keep the version as-is https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2636 PS1, Line 2636: tlli = osmo_htonl(gsr->tlli); > shouldn't this be osmo_ntohl? correct, it's network to host order that we need here. -- To view, visit https://gerrit.osmocom.org/13347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f Gerrit-Change-Number: 13347 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 16:22:01 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13347 ) Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket .. Patch Set 1: For some context: this is Harald's patch. I've submitted it after verifying that it works. See: https://osmocom.org/issues/2249#note-10 -- To view, visit https://gerrit.osmocom.org/13347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f Gerrit-Change-Number: 13347 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 15:30:44 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13347 ) Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2592 PS1, Line 2592: static int rslms_is_gprs_susp_req(struct msgb *msg) Can we please merge this function inside rslms_is_meas_rep and return GSM48_MT_* ? Feel free to keep rslms_is_meas_rep and rslms_is_gprs_susp_req as shim to this new function. https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2636 PS1, Line 2636: tlli = osmo_htonl(gsr->tlli); shouldn't this be osmo_ntohl? -- To view, visit https://gerrit.osmocom.org/13347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f Gerrit-Change-Number: 13347 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 15:28:41 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket
Max has posted comments on this change. ( https://gerrit.osmocom.org/13347 ) Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h@8 PS1, Line 8: #define PCU_IF_VERSION 0x09 Should we bump version as well? -- To view, visit https://gerrit.osmocom.org/13347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f Gerrit-Change-Number: 13347 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 15:27:31 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13347
Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket
..
Forward GPRS SUSPEND REQ from DCCH to PCU socket
As specified in 3GPP TS 03.60 Section 16.2.1 and 44.018 Section 3.4.15,
a Class B MS is sending a "RR GPRS SUSPEND REQ" via a DCCH to the BTS if
it wants to suspend GPRS services. The BSS is now responsible to
somehow forward this to the SGSN. As the Gs interface between BSC and
SGSN is both optional and doesn't have any provision to forward this
message, we have to send it over to the PCU so it can use regular BSSGP
signaling to inform the SGSN of the SUSPEND REQUEST.
This patch requires libosmocore Change-Id
I90113044460a6c511ced14f588876c4280d1cac7 for the related definition of
struct gsm48_gprs_susp_req.
Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f
Closes: OS#2249
---
M include/osmo-bts/pcu_if.h
M include/osmo-bts/pcuif_proto.h
M src/common/pcu_sock.c
M src/common/rsl.c
4 files changed, 87 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/47/13347/1
diff --git a/include/osmo-bts/pcu_if.h b/include/osmo-bts/pcu_if.h
index 98efb57..6253c84 100644
--- a/include/osmo-bts/pcu_if.h
+++ b/include/osmo-bts/pcu_if.h
@@ -15,6 +15,7 @@
int pcu_tx_time_ind(uint32_t fn);
int pcu_tx_pag_req(const uint8_t *identity_lv, uint8_t chan_needed);
int pcu_tx_pch_data_cnf(uint32_t fn, uint8_t *data, uint8_t len);
+int pcu_tx_susp_req(struct gsm_lchan *lchan, uint32_t tlli, const uint8_t
*ra_id, uint8_t cause);
int pcu_sock_init(const char *path);
void pcu_sock_exit(void);
diff --git a/include/osmo-bts/pcuif_proto.h b/include/osmo-bts/pcuif_proto.h
index b06077c..5a85859 100644
--- a/include/osmo-bts/pcuif_proto.h
+++ b/include/osmo-bts/pcuif_proto.h
@@ -11,7 +11,8 @@
/* msg_type */
#define PCU_IF_MSG_DATA_REQ0x00/* send data to given channel */
#define PCU_IF_MSG_DATA_CNF0x01/* confirm (e.g. transmission on PCH) */
-#define PCU_IF_MSG_DATA_IND0x02/* receive data from given channel */
+#define PCU_IF_MSG_DATA_IND0x02/* receive data from given channel */
+#define PCU_IF_MSG_SUSP_REQ0x03/* BTS forwards GPRS SUSP REQ to PCU */
#define PCU_IF_MSG_RTS_REQ 0x10/* ready to send request */
#define PCU_IF_MSG_DATA_CNF_DT 0x11/* confirm (with direct tlli) */
#define PCU_IF_MSG_RACH_IND0x22/* receive RACH */
@@ -171,6 +172,13 @@
uint8_t identity_lv[9];
} __attribute__ ((packed));
+/* BTS tells PCU about a GPRS SUSPENSION REQUEST received on DCCH */
+struct gsm_pcu_if_susp_req {
+ uint32_ttlli;
+ uint8_t ra_id[6];
+ uint8_t cause;
+} __attribute__ ((packed));
+
struct gsm_pcu_if {
/* context based information */
uint8_t msg_type; /* message type */
@@ -182,6 +190,7 @@
struct gsm_pcu_if_data data_cnf;
struct gsm_pcu_if_data_cnf_dt data_cnf_dt;
struct gsm_pcu_if_data data_ind;
+ struct gsm_pcu_if_susp_req susp_req;
struct gsm_pcu_if_rts_req rts_req;
struct gsm_pcu_if_rach_ind rach_ind;
struct gsm_pcu_if_txt_ind txt_ind;
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 2c7028e..48efe51 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -465,6 +465,23 @@
return pcu_sock_send(_gsmnet, msg);
}
+/* forward data from a RR GPRS SUSPEND REQ towards PCU */
+int pcu_tx_susp_req(struct gsm_lchan *lchan, uint32_t tlli, const uint8_t
*ra_id, uint8_t cause)
+{
+ struct msgb *msg;
+ struct gsm_pcu_if *pcu_prim;
+
+ msg = pcu_msgb_alloc(PCU_IF_MSG_SUSP_REQ, lchan->ts->trx->bts->nr);
+ if (!msg)
+ return -ENOMEM;
+ pcu_prim = (struct gsm_pcu_if *) msg->data;
+ pcu_prim->u.susp_req.tlli = tlli;
+ memcpy(pcu_prim->u.susp_req.ra_id, ra_id,
sizeof(pcu_prim->u.susp_req.ra_id));
+ pcu_prim->u.susp_req.cause = cause;
+
+ return pcu_sock_send(_gsmnet, msg);
+}
+
static int pcu_rx_data_req(struct gsm_bts *bts, uint8_t msg_type,
const struct gsm_pcu_if_data *data_req)
{
diff --git a/src/common/rsl.c b/src/common/rsl.c
index fce3495..cac4abd 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -29,12 +29,14 @@
#include
#include
+#include
#include
#include
#include
#include
#include
#include
+#include
#include
#include
@@ -2587,6 +2589,61 @@
return 0;
}
+static int rslms_is_gprs_susp_req(struct msgb *msg)
+{
+ struct abis_rsl_common_hdr *rh = msgb_l2(msg);
+ struct abis_rsl_rll_hdr *rllh;
+ struct gsm48_hdr *gh;
+
+ if ((rh->msg_discr & 0xfe) != ABIS_RSL_MDISC_RLL)
+ return 0;
+
+ if (rh->msg_type != RSL_MT_UNIT_DATA_IND)
+
Change in libosmo-netif[master]: amr: use sizeof(struct amr_hdr) when working with amr header length
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13346 ) Change subject: amr: use sizeof(struct amr_hdr) when working with amr header length .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13346 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7ca04b99a97d7d3b91717b0c3e6c55ef3001a3e Gerrit-Change-Number: 13346 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 15:08:29 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bts[master]: oc2gbts_mgr: use msgb_talloc_ctx_init() instead of msgb_set_talloc_ctx()
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13274 ) Change subject: oc2gbts_mgr: use msgb_talloc_ctx_init() instead of msgb_set_talloc_ctx() .. oc2gbts_mgr: use msgb_talloc_ctx_init() instead of msgb_set_talloc_ctx() The function msgb_set_talloc_ctx() is deprecated. Lets use msgb_talloc_ctx_init() as suggested. Change-Id: I61f80a7b11e9117e8b71c49b7d81d2f959f3150d --- M src/osmo-bts-oc2g/misc/oc2gbts_mgr.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Pau Espin Pedrol: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c index f8768e4..46831f6 100644 --- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c +++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c @@ -274,7 +274,7 @@ tall_mgr_ctx = talloc_named_const(NULL, 1, "bts manager"); tall_msgb_ctx = talloc_named_const(tall_mgr_ctx, 1, "msgb"); - msgb_set_talloc_ctx(tall_msgb_ctx); + msgb_talloc_ctx_init(tall_msgb_ctx, 0); mgr_log_init(); -- To view, visit https://gerrit.osmocom.org/13274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I61f80a7b11e9117e8b71c49b7d81d2f959f3150d Gerrit-Change-Number: 13274 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: dexter
Change in libosmo-netif[master]: amr: use sizeof(struct amr_hdr) when working with amr header length
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13346
Change subject: amr: use sizeof(struct amr_hdr) when working with amr header
length
..
amr: use sizeof(struct amr_hdr) when working with amr header length
The header of an AMR header payload is 2 bytes long. At the moment we
use just a constant of 2 when we refer to the header length, but we have a
struct amr_hdr defined. Lets use sizeof(struct amr_hdr) to make it more
clear that we are refering to the header length.
Change-Id: Ic7ca04b99a97d7d3b91717b0c3e6c55ef3001a3e
---
M src/amr.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/46/13346/1
diff --git a/src/amr.c b/src/amr.c
index 9c63f60..5609c46 100644
--- a/src/amr.c
+++ b/src/amr.c
@@ -82,7 +82,7 @@
unsigned int frame_len;
/* Broken payload? */
- if (!payload || payload_len < 2)
+ if (!payload || payload_len < sizeof(struct amr_hdr))
return false;
/* In octet aligned mode, padding bits are specified to be
@@ -106,7 +106,7 @@
if(!osmo_amr_ft_valid(oa_hdr->ft))
return false;
frame_len = osmo_amr_bytes(oa_hdr->ft);
- if (frame_len != payload_len - 2)
+ if (frame_len != payload_len - sizeof(struct amr_hdr))
return false;
return true;
@@ -119,7 +119,7 @@
int osmo_amr_oa_to_bwe(uint8_t *payload, unsigned int payload_len)
{
struct amr_hdr *oa_hdr = (struct amr_hdr *)payload;
- unsigned int frame_len = payload_len - 2;
+ unsigned int frame_len = payload_len - sizeof(struct amr_hdr);
unsigned int i;
/* This implementation is not capable to handle multi-frame
--
To view, visit https://gerrit.osmocom.org/13346
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7ca04b99a97d7d3b91717b0c3e6c55ef3001a3e
Gerrit-Change-Number: 13346
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Change in libosmocore[master]: add osmo_sockaddr_str API
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13123 ) Change subject: add osmo_sockaddr_str API .. Patch Set 8: > maybe osmith has time to do the rename so we can get this merged? Done -- To view, visit https://gerrit.osmocom.org/13123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63 Gerrit-Change-Number: 13123 Gerrit-PatchSet: 8 Gerrit-Owner: Neels Hofmeyr Gerrit-Assignee: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-CC: Harald Welte Gerrit-CC: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 14:15:44 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmocore[master]: add osmo_sockaddr_str API
osmith has uploaded a new patch set (#8) to the change originally created by
Neels Hofmeyr. ( https://gerrit.osmocom.org/13123 )
Change subject: add osmo_sockaddr_str API
..
add osmo_sockaddr_str API
For handling RTP IP addresses and ports, osmo-mgw, osmo-bsc and osmo-msc
so far have their own separate shims and code duplication around
inet_ntoa(), htons(), sockaddr conversions etc. Unify and standardize
with this common API.
In the MGW endpoint FSM that was introduced in osmo-bsc and which I
would like to re-use for osmo-msc (upcoming patch moving that to
osmo-mgw), it has turned out that using char* IP address and uint16_t
port number types are a convenient common denominator for logging,
MGCP message composition and GSM48. Ongoing osmo-msc work also uses this
for MNCC.
This is of course potentially useful for any other IP+port combinations
besides RTP stream handling.
Needless to say that most current implementations will probably stay
with their current own conversion code for a long time; for current
osmo-{bsc,msc,mgw} work (MGW endpoint FSM) though, I would like to move
to this API here.
Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63
---
M configure.ac
M include/Makefile.am
A include/osmocom/core/sockaddr_str.h
M src/Makefile.am
A src/sockaddr_str.c
M tests/Makefile.am
A tests/sockaddr_str/sockaddr_str_test.c
A tests/sockaddr_str/sockaddr_str_test.ok
M tests/testsuite.at
9 files changed, 1,008 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/13123/8
--
To view, visit https://gerrit.osmocom.org/13123
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 8
Gerrit-Owner: Neels Hofmeyr
Gerrit-Assignee: osmith
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-CC: Harald Welte
Gerrit-CC: osmith
Change in openbsc[master]: Drop openggsn from build dependencies
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13345 ) Change subject: Drop openggsn from build dependencies .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6725d39449a3d498adcd83fb8c3fe892367df0e8 Gerrit-Change-Number: 13345 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Jenkins Builder (102) Gerrit-Comment-Date: Wed, 20 Mar 2019 14:11:14 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in docker-playground[master]: BTS tests: update NSVC config in osmo-bsc.cfg
Max has posted comments on this change. ( https://gerrit.osmocom.org/13341 ) Change subject: BTS tests: update NSVC config in osmo-bsc.cfg .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie424107672496df70fc83c8fd6cef99a312fcee7 Gerrit-Change-Number: 13341 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 14:10:23 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: add osmo_sockaddr_str API
osmith has uploaded a new patch set (#7) to the change originally created by
Neels Hofmeyr. ( https://gerrit.osmocom.org/13123 )
Change subject: add osmo_sockaddr_str API
..
add osmo_sockaddr_str API
For handling RTP IP addresses and ports, osmo-mgw, osmo-bsc and osmo-msc
so far have their own separate shims and code duplication around
inet_ntoa(), htons(), sockaddr conversions etc. Unify and standardize
with this common API.
In the MGW endpoint FSM that was introduced in osmo-bsc and which I
would like to re-use for osmo-msc (upcoming patch moving that to
osmo-mgw), it has turned out that using char* IP address and uint16_t
port number types are a convenient common denominator for logging,
MGCP message composition and GSM48. Ongoing osmo-msc work also uses this
for MNCC.
This is of course potentially useful for any other IP+port combinations
besides RTP stream handling.
Needless to say that most current implementations will probably stay
with their current own conversion code for a long time; for current
osmo-{bsc,msc,mgw} work (MGW endpoint FSM) though, I would like to move
to this API here.
Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63
---
M configure.ac
M include/Makefile.am
A include/osmocom/core/sockaddr_str.h
M src/Makefile.am
A src/sockaddr_str.c
M tests/Makefile.am
A tests/sockaddr_str/sockaddr_str_test.c
A tests/sockaddr_str/sockaddr_str_test.ok
M tests/testsuite.at
9 files changed, 1,008 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/13123/7
--
To view, visit https://gerrit.osmocom.org/13123
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr
Gerrit-Assignee: osmith
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-CC: Harald Welte
Gerrit-CC: osmith
Change in openbsc[master]: Drop openggsn from build dependencies
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13345
Change subject: Drop openggsn from build dependencies
..
Drop openggsn from build dependencies
We don't have SGSN-related code here anymore so we don't need libgtp
from openggsn any longer.
Change-Id: I6725d39449a3d498adcd83fb8c3fe892367df0e8
---
M contrib/jenkins.sh
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/45/13345/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 7083976..f8ae49c 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -18,7 +18,6 @@
x="${x}_$($1 libosmo-netif)"
x="${x}_$($1 libosmo-sccp "$sccp_branch")"
x="${x}_$($1 libsmpp34)"
- x="${x}_$($1 openggsn)"
if [ "x$IU" = "x--enable-iu" ]; then
x="${x}_$($1 libasn1c)"
@@ -36,7 +35,6 @@
osmo-build-dep.sh libosmo-netif
osmo-build-dep.sh libosmo-sccp "$sccp_branch"
PARALLEL_MAKE=-j1 osmo-build-dep.sh libsmpp34
- osmo-build-dep.sh openggsn
if [ "x$IU" = "x--enable-iu" ]; then
osmo-build-dep.sh libasn1c
--
To view, visit https://gerrit.osmocom.org/13345
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6725d39449a3d498adcd83fb8c3fe892367df0e8
Gerrit-Change-Number: 13345
Gerrit-PatchSet: 1
Gerrit-Owner: Max
Change in libosmocore[master]: add osmo_sockaddr_str API
osmith has uploaded a new patch set (#6) to the change originally created by
Neels Hofmeyr. ( https://gerrit.osmocom.org/13123 )
Change subject: add osmo_sockaddr_str API
..
add osmo_sockaddr_str API
For handling RTP IP addresses and ports, osmo-mgw, osmo-bsc and osmo-msc so far
have their own separate shims and code duplication around inet_ntoa(), htons(),
sockaddr conversions etc. Unify and standardize with this common API.
In the MGW endpoint FSM that was introduced in osmo-bsc and which I would like
to re-use for osmo-msc (upcoming patch moving that to osmo-mgw), it has turned
out that using char* IP address and uint16_t port number types are a convenient
common denominator for logging, MGCP message composition and GSM48. Ongoing
osmo-msc work also uses this for MNCC.
This is of course potentially useful for any other IP+port combinations besides
RTP stream handling.
Needless to say that most current implementations will probably stay with their
current own conversion code for a long time; for current osmo-{bsc,msc,mgw}
work (MGW endpoint FSM) though, I would like to move to this API here.
Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63
---
M configure.ac
M include/Makefile.am
A include/osmocom/core/sockaddr_str.h
M src/Makefile.am
A src/sockaddr_str.c
M tests/Makefile.am
A tests/sockaddr_str/sockaddr_str_test.c
A tests/sockaddr_str/sockaddr_str_test.ok
M tests/testsuite.at
9 files changed, 1,008 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/13123/6
--
To view, visit https://gerrit.osmocom.org/13123
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 6
Gerrit-Owner: Neels Hofmeyr
Gerrit-Assignee: osmith
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-CC: Harald Welte
Gerrit-CC: osmith
Change in osmo-bts[master]: oc2g: change log level for calibration file errors to FATAL
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13266 to look at the new patch set (#6). Change subject: oc2g: change log level for calibration file errors to FATAL .. oc2g: change log level for calibration file errors to FATAL The log level of the messages that notify calibration file loading problems is NOTICE, but since it is a severe problem when calibration can not be loaded lets change it to FATAL Change-Id: I32aed25ca7925f1c776f00b37f404a58a85ddbc7 Related: OS#3823 --- M src/osmo-bts-oc2g/calib_file.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/13266/6 -- To view, visit https://gerrit.osmocom.org/13266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32aed25ca7925f1c776f00b37f404a58a85ddbc7 Gerrit-Change-Number: 13266 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: dexter Gerrit-CC: Max
Change in osmo-ci[master]: scripts: Enable osmo-sysmon debian package OBS build
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13331 ) Change subject: scripts: Enable osmo-sysmon debian package OBS build .. Patch Set 2: I created the project in OBS nightly, not in testing since we don't enable it there yet. https://build.opensuse.org/package/show/network:osmocom:nightly/osmo-sysmon -- To view, visit https://gerrit.osmocom.org/13331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I638c58be1ddf5e7fcf5a51de532ae8c4c06dcdbb Gerrit-Change-Number: 13331 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 13:57:49 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-msc[master]: a_iface_bssap: add context information to log output
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13319 to look at the new patch set (#3). Change subject: a_iface_bssap: add context information to log output .. a_iface_bssap: add context information to log output At the moment many of the log statements in a_iface_bssap.c are just LOGP statements without futrher context information. Since those messages appear at a point where no related ran conn can be identified, lets use the BSC as context information, so that the origin of those messages can be traced back to at least one specific BSC. Change-Id: I704954edc8677688fc7cccd2b23d2aff958ebf32 --- M src/libmsc/a_iface_bssap.c M tests/msc_vlr/msc_vlr_test_gsm_ciph.c M tests/msc_vlr/msc_vlr_test_gsm_ciph.err 3 files changed, 69 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/19/13319/3 -- To view, visit https://gerrit.osmocom.org/13319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I704954edc8677688fc7cccd2b23d2aff958ebf32 Gerrit-Change-Number: 13319 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Max
Change in osmo-ci[master]: scripts: Enable osmo-sysmon debian package OBS build
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13331 ) Change subject: scripts: Enable osmo-sysmon debian package OBS build .. Patch Set 2: Patches fixing build in OBS are present for review here: https://gerrit.osmocom.org/#/c/osmo-sysmon/+/13344/ -- To view, visit https://gerrit.osmocom.org/13331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I638c58be1ddf5e7fcf5a51de532ae8c4c06dcdbb Gerrit-Change-Number: 13331 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 13:55:12 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ci[master]: scripts: Enable osmo-sysmon debian package OBS build
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13331 ) Change subject: scripts: Enable osmo-sysmon debian package OBS build .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/13331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I638c58be1ddf5e7fcf5a51de532ae8c4c06dcdbb Gerrit-Change-Number: 13331 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 13:54:31 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-sysmon[master]: Depend on liboping 1.7.0 instead of 1.9.0
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13344 Change subject: Depend on liboping 1.7.0 instead of 1.9.0 .. Depend on liboping 1.7.0 instead of 1.9.0 Debian8 provides 1.7.0. Let's depend on it so we can build packages for debian8. Change-Id: Idba4494102d48d125bcd215dd0d3fdf42bbd409e --- M configure.ac M debian/control 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/44/13344/1 diff --git a/configure.ac b/configure.ac index 44a040c..5242b6a 100644 --- a/configure.ac +++ b/configure.ac @@ -45,7 +45,8 @@ PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.4.0) PKG_CHECK_MODULES(LIBMNL, libmnl) dnl FIXME: bump to 1.10.0 once it's available on build slaves and remove workaround from osysmon_ping.c -PKG_CHECK_MODULES(LIBOPING, liboping >= 1.9.0) +dnl FIXME: debian8 provides 1.7.0, debian9 provides 1.9.0 +PKG_CHECK_MODULES(LIBOPING, liboping >= 1.7.0) dnl checks for header files AC_HEADER_STDC diff --git a/debian/control b/debian/control index 9439c3b..fc8aed7 100644 --- a/debian/control +++ b/debian/control @@ -11,7 +11,7 @@ pkg-config, libtalloc-dev, libmnl-dev, - liboping-dev (>= 1.9.0), + liboping-dev (>= 1.7.0), libosmocore-dev (>= 1.0.1), libosmo-netif-dev (>= 0.4.0), Standards-Version: 3.9.8 -- To view, visit https://gerrit.osmocom.org/13344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idba4494102d48d125bcd215dd0d3fdf42bbd409e Gerrit-Change-Number: 13344 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol
Change in osmo-sysmon[master]: debian: Add missing libmnl-dev dependency
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13343 Change subject: debian: Add missing libmnl-dev dependency .. debian: Add missing libmnl-dev dependency Change-Id: I1157b1f0edabac16d664c2d4ad2250d3802dcc60 --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/43/13343/1 diff --git a/debian/control b/debian/control index 651ecce..9439c3b 100644 --- a/debian/control +++ b/debian/control @@ -10,6 +10,7 @@ libtool, pkg-config, libtalloc-dev, + libmnl-dev, liboping-dev (>= 1.9.0), libosmocore-dev (>= 1.0.1), libosmo-netif-dev (>= 0.4.0), -- To view, visit https://gerrit.osmocom.org/13343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1157b1f0edabac16d664c2d4ad2250d3802dcc60 Gerrit-Change-Number: 13343 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol
Change in libosmocore[master]: src/signal.c: cosmetic: use talloc_zero()
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13342 ) Change subject: src/signal.c: cosmetic: use talloc_zero() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55c6249b0c4c82d5a181001e945ff2eca6e9ca36 Gerrit-Change-Number: 13342 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 13:47:53 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: src/signal.c: cosmetic: use talloc_zero()
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13342
Change subject: src/signal.c: cosmetic: use talloc_zero()
..
src/signal.c: cosmetic: use talloc_zero()
Change-Id: I55c6249b0c4c82d5a181001e945ff2eca6e9ca36
---
M src/signal.c
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/42/13342/1
diff --git a/src/signal.c b/src/signal.c
index 188876b..7e53e83 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -67,12 +67,10 @@
{
struct signal_handler *sig_data;
- sig_data = talloc(tall_sigh_ctx, struct signal_handler);
+ sig_data = talloc_zero(tall_sigh_ctx, struct signal_handler);
if (!sig_data)
return -ENOMEM;
- memset(sig_data, 0, sizeof(*sig_data));
-
sig_data->subsys = subsys;
sig_data->data = data;
sig_data->cbfn = cbfn;
--
To view, visit https://gerrit.osmocom.org/13342
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55c6249b0c4c82d5a181001e945ff2eca6e9ca36
Gerrit-Change-Number: 13342
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Change in docker-playground[master]: BTS tests: update NSVC config in osmo-bsc.cfg
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13341 ) Change subject: BTS tests: update NSVC config in osmo-bsc.cfg .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie424107672496df70fc83c8fd6cef99a312fcee7 Gerrit-Change-Number: 13341 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Comment-Date: Wed, 20 Mar 2019 13:40:57 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: signal.c: Make non-exported tall_sigh_ctx static
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13337 ) Change subject: signal.c: Make non-exported tall_sigh_ctx static .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7132ffe9a7efcab226cc639d1b2357f7115bcadf Gerrit-Change-Number: 13337 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Assignee: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 20 Mar 2019 13:40:39 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: jobs: add osmocom-list-commits.yml
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13302 ) Change subject: jobs: add osmocom-list-commits.yml .. jobs: add osmocom-list-commits.yml Related: OS#3840 Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b --- A jobs/osmocom-list-commits.yml 1 file changed, 44 insertions(+), 0 deletions(-) Approvals: Max: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved osmith: Verified diff --git a/jobs/osmocom-list-commits.yml b/jobs/osmocom-list-commits.yml new file mode 100644 index 000..f2651f4 --- /dev/null +++ b/jobs/osmocom-list-commits.yml @@ -0,0 +1,44 @@ +--- +- project: +name: Osmocom-list-commits +jobs: + - Osmocom-list-commits + +- job-template: +name: 'Osmocom-list-commits' +project-type: freestyle +defaults: global +description: | +Generate and upload a list of Osmocom git repositories and their latest tag and commits. +The latest list is https://jenkins.osmocom.org/jenkins/job/Osmocom-list-commits/lastSuccessfulBuild/artifact/commits.txt/*view*/;>here. +node: osmocom-master-debian9 +parameters: + - string: + name: BRANCH + description: | +osmo-ci.git branch where the osmocom-list-commits.sh gets pulled from + default: '*/master' +builders: + - shell: | + scripts/osmocom-list-commits.sh > commits.txt + cat commits.txt +scm: + - git: + branches: +- '$BRANCH' + url: git://git.osmocom.org/osmo-ci + git-config-name: 'Jenkins Builder' + git-config-email: 'jenk...@osmocom.org' +triggers: + - timed: "@midnight" +publishers: + - archive: + allow-empty: false + artifacts: commits.txt + case-sensitive: true + only-if-success: true + - email: + notify-every-unstable-build: true + recipients: 'jenkins-notificati...@lists.osmocom.org' + +# vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/13302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b Gerrit-Change-Number: 13302 Gerrit-PatchSet: 6 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: osmith
Change in osmo-ci[master]: jobs: add osmocom-list-commits.yml
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13302 ) Change subject: jobs: add osmocom-list-commits.yml .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.osmocom.org/13302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b Gerrit-Change-Number: 13302 Gerrit-PatchSet: 6 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 13:36:07 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.osmocom.org/13301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da Gerrit-Change-Number: 13301 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 13:36:03 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/13301 )
Change subject: Add scripts/osmocom-list-commits.sh
..
Add scripts/osmocom-list-commits.sh
Generate a table of Osmocom CNI repositories and their latest tag,
related commit, and last commit on master.
Related: OS#3840
Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da
---
A scripts/osmocom-list-commits.sh
1 file changed, 85 insertions(+), 0 deletions(-)
Approvals:
Max: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
osmith: Verified
diff --git a/scripts/osmocom-list-commits.sh b/scripts/osmocom-list-commits.sh
new file mode 100755
index 000..d8183c6
--- /dev/null
+++ b/scripts/osmocom-list-commits.sh
@@ -0,0 +1,85 @@
+#!/bin/sh -e
+# Environment variables:
+# * NO_HEADER: do not output the header line when set
+
+FORMAT_STR="%-22s %-42s %9s %-40s %s\n"
+URL="https://git.osmocom.org;
+REPOS="
+ libasn1c
+ libosmo-abis
+ libosmocore
+ libosmo-netif
+ libosmo-sccp
+ libsmpp34
+ libusrp
+ osmo-bsc
+ osmo-bts
+ osmo-ggsn
+ osmo-hlr
+ osmo-iuh
+ osmo-mgw
+ osmo-msc
+ osmo-pcu
+ osmo-sgsn
+ osmo-sip-connector
+ osmo-sysmon
+ osmo-trx
+ osmocom-bb
+"
+
+# Print commit of HEAD for an Osmocom git repository, e.g.:
+# "f90496f577e78944ce8db1aa5b900477c1e479b0"
+# $1: repository
+get_head_commit() {
+ # git output:
+ # f90496f577e78944ce8db1aa5b900477c1e479b0HEAD
+ ret="$(git ls-remote "$URL/$1" HEAD)"
+ ret="$(echo "$ret" | awk '{print $1}')"
+ echo "$ret"
+}
+
+# Print last tag and related commit for an Osmocom git repository, e.g.:
+# "ec798b89700dcca5c5b28edf1a1cd16ea311f30arefs/tags/1.0.1"
+# Print "-" when no tags were found.
+# $1: repository
+get_last() {
+ # git output:
+ # ec798b89700dcca5c5b28edf1a1cd16ea311f30arefs/tags/1.0.1
+ # eab5f594b0a7cf50ad97b039f73beff42cc8312arefs/tags/1.0.1^{}
+ # ...
+ # 41e7cf115d4148a9f34fcb863b68b2d5370e335drefs/tags/1.3.1^{}
+ # 8a9f12dc2f69bf3a4e861cc9a81b71bdc5f13180refs/tags/3G_2016_09
+ # ee618ecbedec82dfd240334bc87d0d1c806477b0
refs/tags/debian/0.9.13-0_jrsantos.1
+ # a3fdd24af099b449c9856422eb099fb45a5595df
refs/tags/debian/0.9.13-0_jrsantos.1^{}
+ # ...
+ ret="$(git ls-remote --tags "$URL/$1")"
+ ret="$(echo "$ret" | grep 'refs/tags/[0-9.]*$' || true)"
+ ret="$(echo "$ret" | sort -n -k2)"
+ ret="$(echo "$ret" | tail -n 1)"
+
+ if [ -n "$ret" ]; then
+ echo "$ret"
+ else
+ echo "-"
+ fi
+}
+
+# Header
+if [ -z "$NO_HEADER" ]; then
+ printf "$FORMAT_STR" "# repository" "clone URL" "last tag" "last tag
commit" "HEAD commit"
+fi
+
+# Table
+for repo in $REPOS; do
+ last="$(get_last "$repo")"
+ last_tag="$(echo "$last" | cut -d/ -f 3)"
+ last_commit="$(echo "$last" | awk '{print $1}')"
+ head_commit="$(get_head_commit "$repo")"
+
+ printf "$FORMAT_STR" \
+ "$repo.git" \
+ "$URL/$repo" \
+ "$last_tag" \
+ "$last_commit" \
+ "$head_commit"
+done
--
To view, visit https://gerrit.osmocom.org/13301
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da
Gerrit-Change-Number: 13301
Gerrit-PatchSet: 5
Gerrit-Owner: osmith
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: osmith
Change in osmo-ci[master]: jobs: add osmocom-list-commits.yml
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13302 ) Change subject: jobs: add osmocom-list-commits.yml .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b Gerrit-Change-Number: 13302 Gerrit-PatchSet: 6 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 13:31:27 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da Gerrit-Change-Number: 13301 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 13:31:13 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: signal.c: Fix osmo_signal_talloc_ctx_init()
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13336 ) Change subject: signal.c: Fix osmo_signal_talloc_ctx_init() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13336/1/src/signal.c File src/signal.c: https://gerrit.osmocom.org/#/c/13336/1/src/signal.c@a54 PS1, Line 54: > Huh, I would expect a compiler warning about an unused param / variable... Could be related to function being public/exported. -- To view, visit https://gerrit.osmocom.org/13336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f Gerrit-Change-Number: 13336 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Assignee: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 20 Mar 2019 13:30:11 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in libosmocore[master]: signal.c: Fix osmo_signal_talloc_ctx_init()
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13336 ) Change subject: signal.c: Fix osmo_signal_talloc_ctx_init() .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/13336/1/src/signal.c File src/signal.c: https://gerrit.osmocom.org/#/c/13336/1/src/signal.c@a54 PS1, Line 54: Huh, I would expect a compiler warning about an unused param / variable... -- To view, visit https://gerrit.osmocom.org/13336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f Gerrit-Change-Number: 13336 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Assignee: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 20 Mar 2019 13:29:11 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in libosmocore[master]: select: Rename BSC_FD_* constants to OSMO_FD_*
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13335 ) Change subject: select: Rename BSC_FD_* constants to OSMO_FD_* .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifae33ed61a7cf0ae54ad487399e7dd2489986436 Gerrit-Change-Number: 13335 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 20 Mar 2019 13:19:36 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13330 ) Change subject: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie98bb286d9333158985ddb80edf7208d69702d73 Gerrit-Change-Number: 13330 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 13:15:16 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Add debian packaging content
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13328 ) Change subject: Add debian packaging content .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bcacca040364f77aa6b17edf53acf53c820c17b Gerrit-Change-Number: 13328 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 13:15:13 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Add debian packaging content
Pau Espin Pedrol has submitted this change and it was merged. (
https://gerrit.osmocom.org/13328 )
Change subject: Add debian packaging content
..
Add debian packaging content
Change-Id: I2bcacca040364f77aa6b17edf53acf53c820c17b
---
A debian/changelog
A debian/compat
A debian/control
A debian/copyright
A debian/osmo-sysmon.install
A debian/rules
A debian/source/format
7 files changed, 183 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
diff --git a/debian/changelog b/debian/changelog
new file mode 100644
index 000..4e8308d
--- /dev/null
+++ b/debian/changelog
@@ -0,0 +1,5 @@
+osmo-sysmon (0.0.1) unstable; urgency=medium
+
+ * Initial release.
+
+ -- Pau Espin Pedrol Tue, 19 Mar 2019 18:32:14 +0100
diff --git a/debian/compat b/debian/compat
new file mode 100644
index 000..ec63514
--- /dev/null
+++ b/debian/compat
@@ -0,0 +1 @@
+9
diff --git a/debian/control b/debian/control
new file mode 100644
index 000..651ecce
--- /dev/null
+++ b/debian/control
@@ -0,0 +1,47 @@
+Source: osmo-sysmon
+Section: net
+Priority: extra
+Maintainer: Pau Espin Pedrol
+Build-Depends: debhelper (>=9),
+ dh-autoreconf,
+ autotools-dev,
+ autoconf,
+ automake,
+ libtool,
+ pkg-config,
+ libtalloc-dev,
+ liboping-dev (>= 1.9.0),
+ libosmocore-dev (>= 1.0.1),
+ libosmo-netif-dev (>= 0.4.0),
+Standards-Version: 3.9.8
+Vcs-Git: git://git.osmocom.org/osmo-sysmon.git
+Vcs-Browser: https://git.osmocom.org/osmo-sysmon/
+Homepage: https://osmocom.org/
+
+Package: osmo-sysmon
+Architecture: any
+Multi-Arch: foreign
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Description: Simple Osmocom System Monitor (osysmon)
+ This application prints on screen once per second relevant information about
+ the status of the system. Information being printed can be specified through
+ configuration file (and VTY).
+ .
+ Useful to run as a login shell to provide users with some diagnose system
+ without providing full access the system.
+
+Package: osmo-sysmon-dbg
+Section: debug
+Architecture: any
+Multi-Arch: same
+Depends: osmo-sysmon (= ${binary:Version}), ${misc:Depends}
+Description: Simple Osmocom System Monitor (osysmon)
+ This application prints on screen once per second relevant information about
+ the status of the system. Information being printed can be specified through
+ configuration file (and VTY).
+ .
+ Useful to run as a login shell to provide users with some diagnose system
+ without providing full access the system.
+ .
+ This package contains the debug symbols for osmo-sysmon in order to
+ generate meaningful backtraces in bug-reports.
diff --git a/debian/copyright b/debian/copyright
new file mode 100644
index 000..f8d29de
--- /dev/null
+++ b/debian/copyright
@@ -0,0 +1,77 @@
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: osmo-sysmon
+Source: git://git.osmocom.org/osmo-sysmon
+
+Files: *
+Copyright: 2019 sysmocom s.f.m.c. GmbH
+License: GPL-2.0+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License along
+ with this program; if not, write to the Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ .
+ On Debian systems, the complete text of the GNU General Public License
+ Version 2 can be found in `/usr/share/common-licenses/GPL-2'.
+
+Files: git-version-gen
+Copyright: 2007-2010 Free Software Foundation, Inc.
+License: GPL-3.0+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see
Change in osmo-sysmon[master]: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13330 ) Change subject: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 .. Patch Set 3: > Have you checked that it actually builds against latest releases of > libosmo*? I'm pretty sure it requires libosmo-netif functions which > are only available in master branch and not in any of the releases. Yes, it requires master libosmocore and libosmo-netif. That's fine, I just need to remember to only build it under nightly for now. -- To view, visit https://gerrit.osmocom.org/13330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie98bb286d9333158985ddb80edf7208d69702d73 Gerrit-Change-Number: 13330 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 13:14:57 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-sysmon[master]: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13330 ) Change subject: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 .. Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 Change-Id: Ie98bb286d9333158985ddb80edf7208d69702d73 --- M debian/changelog 1 file changed, 80 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve Pau Espin Pedrol: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 4e8308d..a2b0789 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,83 @@ +osmo-sysmon (0.1.0) unstable; urgency=medium + + [ Harald Welte ] + * initial checkin + * simple_ctrl: Add timeout to blocking I/O + * simple_ctrl.c: Support an indefinite timeout (using tout_msec=0) + * simple_ctrl.c: API for setting timeout + raw CTRL msgb read + * osmo-ctrl-client: Implement "monitor" mode + * simple-ctrl-client: Add basic help/usage information + * simple_ctrl: Abstract out timeval_from_msec() function + * simple_ctrl: Non-blocking connect() with timeout + * initial implementation of 'osysmon' main program + CTRL client + * add osysmon_sysinfo for uptime/ram/load + * osysmon_ctrl: Use variable name, not ctrl-client name as val->name + * osysmon_main: Show hierarchical/tree structure during printing + * value_node: add combined find_or_add() and avoid duplicate names + * value_node: Add 'idx' member to handle lookup by ifindex. + * Add network link + address monitiring via osysmon_rtnl.c + * add osysmon_file.c for reading/monitoring files (like sysfs) + * migrate to autoconf + * add .gitignore file + * rename to osmo-sysmon + * simple_ctrl: Check for NULL return of simple_ctrl_xceive + * add contrib/jenkins.sh for build verification + + [ Daniel Willmann ] + * Remove unused function + * Fix compilation issue on my machine, remove unused include + * Remove unused last_value handling code + * Add zero termination char to received ctrl cmd message + * Disconnect properly on errors so we can reconnect + * git-version-gen: Don't check for .git directory + + [ Martin Hauke ] + * Makefile.am: Fix typo + + [ Max ] + * Add git-review config + * Update gitignore + * Report config file name on error + * Update default config + * Expand default config + * Add OpenVPN status helper example from corresponding ticket + * Move shared libs into common LDADD + * Drop unused parameter + * ctrl: separate config structure + * Update Makefile.am + * Add ping probe support + * jenkins.sh: remove obsolete comments + * Install signal handlers before processing config + * ctrl: log host/port on errors + * Introduce generic host config and related helpers + * Add OpenVPN probe + * OpenVPN: track interface disconnect + * Update config example + + [ Stefan Sperling ] + * fix file descriptor leak in osysmon_file_read + + [ Pau Espin Pedrol ] + * Add m4 missing files to fix build + * Move source code to src subdir + * Add cmdline option parsing support + * Integrate sleeping/printing loop into osmo main loop + * openvpn: Improve logging and status information + * openvpn: Set reconnect timeout to a much lower value + * openvpn: String returned from openvpn is not null-terminated + * openvpn: log status description + * openvpn: Fix garbage printed after remote port + * openvpn: Remove useless conditional block in parse_state + * openvn: Fix missing break in last commit + * Add vty option to print output of shell cmd on every poll step + * Makefile.am: Add missing bits to have make release working + * Add debian packaging content + + [ Oliver Smith ] + * osmo-sysmon -h: s/OsmoHLR/osmo-sysmon/ + + -- Pau Espin Pedrol Wed, 20 Mar 2019 13:14:30 +0100 + osmo-sysmon (0.0.1) unstable; urgency=medium * Initial release. -- To view, visit https://gerrit.osmocom.org/13330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie98bb286d9333158985ddb80edf7208d69702d73 Gerrit-Change-Number: 13330 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Max
Change in osmo-ci[master]: jobs: add osmocom-list-commits.yml
Max has posted comments on this change. ( https://gerrit.osmocom.org/13302 ) Change subject: jobs: add osmocom-list-commits.yml .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b Gerrit-Change-Number: 13302 Gerrit-PatchSet: 6 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 12:34:50 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0
Max has posted comments on this change. ( https://gerrit.osmocom.org/13330 ) Change subject: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 .. Patch Set 3: Have you checked that it actually builds against latest releases of libosmo*? I'm pretty sure it requires libosmo-netif functions which are only available in master branch and not in any of the releases. -- To view, visit https://gerrit.osmocom.org/13330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie98bb286d9333158985ddb80edf7208d69702d73 Gerrit-Change-Number: 13330 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 12:33:57 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-sysmon[master]: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13330 ) Change subject: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie98bb286d9333158985ddb80edf7208d69702d73 Gerrit-Change-Number: 13330 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 12:27:18 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Add debian packaging content
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13328 ) Change subject: Add debian packaging content .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bcacca040364f77aa6b17edf53acf53c820c17b Gerrit-Change-Number: 13328 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 12:20:50 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13330 to look at the new patch set (#3). Change subject: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 .. Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 Change-Id: Ie98bb286d9333158985ddb80edf7208d69702d73 --- M debian/changelog 1 file changed, 80 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/30/13330/3 -- To view, visit https://gerrit.osmocom.org/13330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie98bb286d9333158985ddb80edf7208d69702d73 Gerrit-Change-Number: 13330 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-sysmon[master]: Add debian packaging content
Hello lynxis lazus, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13328 to look at the new patch set (#3). Change subject: Add debian packaging content .. Add debian packaging content Change-Id: I2bcacca040364f77aa6b17edf53acf53c820c17b --- A debian/changelog A debian/compat A debian/control A debian/copyright A debian/osmo-sysmon.install A debian/rules A debian/source/format 7 files changed, 183 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/28/13328/3 -- To view, visit https://gerrit.osmocom.org/13328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2bcacca040364f77aa6b17edf53acf53c820c17b Gerrit-Change-Number: 13328 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-CC: Max
Change in docker-playground[master]: BTS tests: update NSVC config in osmo-bsc.cfg
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13341 Change subject: BTS tests: update NSVC config in osmo-bsc.cfg .. BTS tests: update NSVC config in osmo-bsc.cfg * remove extra NSVC config * use 0.0.0.0 for nsvc 0 The additional nsvc and this particular address are not used for BTS' PCU-related tests in any way and only add confusion. It's likely a result of copy-paste from another test. Change-Id: Ie424107672496df70fc83c8fd6cef99a312fcee7 --- M ttcn3-bts-test/osmo-bsc.cfg 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/41/13341/1 diff --git a/ttcn3-bts-test/osmo-bsc.cfg b/ttcn3-bts-test/osmo-bsc.cfg index b06cf06..54264e8 100644 --- a/ttcn3-bts-test/osmo-bsc.cfg +++ b/ttcn3-bts-test/osmo-bsc.cfg @@ -131,11 +131,7 @@ gprs nsvc 0 nsvci 1234 gprs nsvc 0 local udp port 23000 gprs nsvc 0 remote udp port 23000 - gprs nsvc 0 remote ip 192.168.100.239 - gprs nsvc 1 nsvci 0 - gprs nsvc 1 local udp port 0 - gprs nsvc 1 remote udp port 0 - gprs nsvc 1 remote ip 0.0.0.0 + gprs nsvc 0 remote ip 0.0.0.0 no force-combined-si trx 0 rf_locked 0 -- To view, visit https://gerrit.osmocom.org/13341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie424107672496df70fc83c8fd6cef99a312fcee7 Gerrit-Change-Number: 13341 Gerrit-PatchSet: 1 Gerrit-Owner: Max
Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13340
Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel,
EF.PLMNwAcT and EF.OPLMNwAcT
..
cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and
EF.OPLMNwAcT
The files EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT are currently not
programmed for sysmo-usim-sjs1, lets add them.
Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b
Related: OS#3850
---
M pySim/cards.py
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/13340/1
diff --git a/pySim/cards.py b/pySim/cards.py
index 3a25040..3a5caac 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -537,6 +537,7 @@
super(SysmoUSIMSJS1, self).__init__(ssc)
self._scc.cla_byte = "00"
self._scc.sel_ctrl = "000C"
+ self._scc.sel_ctrl = "0004" #request an FCP
@classmethod
def autodetect(kls, scc):
@@ -575,6 +576,25 @@
# write EF.IMSI
data, sw = self._scc.update_binary('6f07', enc_imsi(p['imsi']))
+ # EF.PLMNsel
+if p.get('mcc') and p.get('mnc'):
+sw = self.update_plmnsel(p['mcc'], p['mnc'])
+if sw != '9000':
+ print("Programming PLMNsel failed with code
%s"%sw)
+
+# EF.PLMNwAcT
+if p.get('mcc') and p.get('mnc'):
+ sw = self.update_plmn_act(p['mcc'], p['mnc'])
+ if sw != '9000':
+ print("Programming PLMNwAcT failed with code
%s"%sw)
+
+# EF.OPLMNwAcT
+if p.get('mcc') and p.get('mnc'):
+ sw = self.update_oplmn_act(p['mcc'], p['mnc'])
+ if sw != '9000':
+ print("Programming OPLMNwAcT failed with code
%s"%sw)
+
+
# EF.SMSP
r = self._scc.select_file(['3f00', '7f10'])
data, sw = self._scc.update_record('6f42', 1, lpad(p['smsp'],
104), force_len=True)
--
To view, visit https://gerrit.osmocom.org/13340
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Change in pysim[master]: commands: correct case of a TLV tag (A5 => a5)
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13339 Change subject: commands: correct case of a TLV tag (A5 => a5) .. commands: correct case of a TLV tag (A5 => a5) The hexadecimal tag defintions of pytlv are cas sensitive strings. So 'A5' is something different than 'a5'. Pytlv uses lower case letters for the upper hexadecimal digits. Lets correct this. Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0 Related: OS#3850 --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/13339/1 diff --git a/pySim/commands.py b/pySim/commands.py index 73c2247..913f394 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -35,7 +35,7 @@ # see also: ETSI TS 102 221, chapter 11.1.1.3.1 Response for MF, # DF or ADF from pytlv.TLV import TLV - tlvparser = TLV(['82', '83', '84', 'A5', '8a', '8b', '8c', '80', 'ab', 'c6', '81', '88']) + tlvparser = TLV(['82', '83', '84', 'a5', '8a', '8b', '8c', '80', 'ab', 'c6', '81', '88']) # pytlv is case sensitive! fcp = fcp.lower() -- To view, visit https://gerrit.osmocom.org/13339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0 Gerrit-Change-Number: 13339 Gerrit-PatchSet: 1 Gerrit-Owner: dexter
Change in libosmocore[master]: signal.c: Make non-exported tall_sigh_ctx static
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13337 ) Change subject: signal.c: Make non-exported tall_sigh_ctx static .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7132ffe9a7efcab226cc639d1b2357f7115bcadf Gerrit-Change-Number: 13337 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Assignee: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 11:38:12 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: signal.c: Fix osmo_signal_talloc_ctx_init()
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13336 ) Change subject: signal.c: Fix osmo_signal_talloc_ctx_init() .. Patch Set 1: Code-Review+2 Ouch, good catch. -- To view, visit https://gerrit.osmocom.org/13336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f Gerrit-Change-Number: 13336 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Assignee: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 11:37:25 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: select: Rename BSC_FD_* constants to OSMO_FD_*
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13335 ) Change subject: select: Rename BSC_FD_* constants to OSMO_FD_* .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifae33ed61a7cf0ae54ad487399e7dd2489986436 Gerrit-Change-Number: 13335 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 11:33:38 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: Add example systemd user unit files
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13326 ) Change subject: Add example systemd user unit files .. Patch Set 2: > I think it makes more sense to have all *.service files in a single > directory: $PROJECT/contrib/systemd/... Oh good point, I didn't notice they were under src/target/... I agree here with Vadim. However, I still want to have them placed under /user/ subdir. systemd user service and sytem services files are different stuff and it's better not having them together in same directory in order to avoid confusion (systemd does install them to different directories too). Regading Max's splitting argument, we can still do that easily if they are placed in $PROJECT/contrib/systemd. -- To view, visit https://gerrit.osmocom.org/13326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc6b571cfb7796af1cfcf0af2d4e12e53f7a4ee6 Gerrit-Change-Number: 13326 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 11:30:18 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmo-abis[master]: Add IPA keep-alive FSM implementation
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13196 ) Change subject: Add IPA keep-alive FSM implementation .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2763da49a74de85046ac07d53592c89973314ca6 Gerrit-Change-Number: 13196 Gerrit-PatchSet: 3 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 20 Mar 2019 11:26:43 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: signal.c: Make non-exported tall_sigh_ctx static
Max has posted comments on this change. ( https://gerrit.osmocom.org/13337 ) Change subject: signal.c: Make non-exported tall_sigh_ctx static .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7132ffe9a7efcab226cc639d1b2357f7115bcadf Gerrit-Change-Number: 13337 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Assignee: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 20 Mar 2019 11:17:09 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: expected-results: add new S15-S0 related testscases
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/1 ) Change subject: expected-results: add new S15-S0 related testscases .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28a853ec25feb723b2d333061e1ae4d2e0b34d86 Gerrit-Change-Number: 1 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 10:57:04 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4()
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13332 ) Change subject: gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4() .. gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4() When putting together a sockaddr_in, we must not only set the IP address and port, but also set the address family to AF_INET. And while at it, let's zero-initialize the entire 'struct sockdadr_in'. Change-Id: I1c8d8fe7f79a2ec737baa7800247269c3271983e --- M src/gb/gprs_ns_sns.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Max: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/src/gb/gprs_ns_sns.c b/src/gb/gprs_ns_sns.c index cbaa468..dd8d3a2 100644 --- a/src/gb/gprs_ns_sns.c +++ b/src/gb/gprs_ns_sns.c @@ -88,6 +88,8 @@ struct gprs_nsvc *nsvc; struct sockaddr_in sin; /* copy over. Both data structures use network byte order */ + memset(, 0, sizeof(sin)); + sin.sin_family = AF_INET; sin.sin_addr.s_addr = ip4->ip_addr; sin.sin_port = ip4->udp_port; -- To view, visit https://gerrit.osmocom.org/13332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1c8d8fe7f79a2ec737baa7800247269c3271983e Gerrit-Change-Number: 13332 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max
Change in osmo-ttcn3-hacks[master]: pcu: Add SNS tests for SGSN-originated BVC-RESET handling
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13334 )
Change subject: pcu: Add SNS tests for SGSN-originated BVC-RESET handling
..
pcu: Add SNS tests for SGSN-originated BVC-RESET handling
Change-Id: Ib6b80acf98711f4749da4faf549b02ff2b82425f
---
M pcu/PCU_Tests_RAW.ttcn
M pcu/PCU_Tests_RAW_SNS.ttcn
2 files changed, 76 insertions(+), 8 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Max: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index a30829e..6022d36 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -172,6 +172,29 @@
}
}
+/* Transmit BSSGP RESET for given BVCI and expect ACK */
+function f_tx_bvc_reset_rx_ack(BssgpBvci bvci, integer idx := 0, boolean
exp_ack := true)
+runs on RAW_NS_CT {
+ var PDU_BSSGP bssgp_tx :=
valueof(ts_BVC_RESET(BSSGP_CAUSE_NET_SV_CAP_MOD_GT_ZERO_KBPS, bvci,
+ mp_gb_cfg.cell_id));
+ timer T := 5.0;
+ NSCP[idx].send(t_NS_Send(g_ns_conn_id[idx], ts_NS_UNITDATA(t_SduCtrlB,
0, enc_PDU_BSSGP(bssgp_tx;
+ T.start;
+ alt {
+ [exp_ack] NSCP[idx].receive(t_NS_RecvFrom(tr_NS_UNITDATA(t_SduCtrlB, 0,
+ decmatch
tr_BVC_RESET_ACK(bvci, ? {
+ setverdict(pass);
+ }
+ [exp_ack] T.timeout {
+ setverdict(fail, "No response to BVC-RESET");
+ }
+ [not exp_ack] T.timeout {
+ setverdict(pass);
+ }
+ [] NSCP[idx].receive { repeat; }
+ }
+}
+
/* Receive a BSSGP RESET for given BVCI and ACK it */
altstep as_rx_bvc_reset_tx_ack(BssgpBvci bvci, boolean oneshot := false,
integer idx := 0) runs on RAW_NS_CT {
var NS_RecvFrom ns_rf;
diff --git a/pcu/PCU_Tests_RAW_SNS.ttcn b/pcu/PCU_Tests_RAW_SNS.ttcn
index 7f71744..7513196 100644
--- a/pcu/PCU_Tests_RAW_SNS.ttcn
+++ b/pcu/PCU_Tests_RAW_SNS.ttcn
@@ -186,7 +186,7 @@
setverdict(pass);
}
-private function f_sns_bringup_1c1u() runs on RAW_Test_CT {
+private function f_sns_bringup_1c1u(boolean sgsn_originated_reset := false)
runs on RAW_Test_CT {
/* Activate two NS codec ports */
f_init_ns_codec();
f_init_ns_codec(1);
@@ -208,9 +208,14 @@
f_outgoing_ns_alive(0);
f_outgoing_ns_alive(1);
- /* Expect BVC-RESET for signaling (0) and ptp BVCI */
- as_rx_bvc_reset_tx_ack(0, oneshot := true);
- as_rx_bvc_reset_tx_ack(mp_gb_cfg.bvci, oneshot := true);
+ if (sgsn_originated_reset) {
+ f_tx_bvc_reset_rx_ack(0);
+ f_tx_bvc_reset_rx_ack(mp_gb_cfg.bvci);
+ } else {
+ /* Expect BVC-RESET for signaling (0) and ptp BVCI */
+ as_rx_bvc_reset_tx_ack(0, oneshot := true);
+ as_rx_bvc_reset_tx_ack(mp_gb_cfg.bvci, oneshot := true);
+ }
/* Expect UNBLOCK for ptp BVCI on signaling NS-VC (idx==0) */
as_rx_bvc_unblock_tx_ack(mp_gb_cfg.bvci, oneshot := true);
@@ -226,7 +231,7 @@
setverdict(pass);
}
-private function f_sns_bringup_1c1u_separate() runs on RAW_Test_CT {
+private function f_sns_bringup_1c1u_separate(boolean sgsn_originated_reset :=
false) runs on RAW_Test_CT {
/* Activate two NS codec ports */
f_init_ns_codec();
f_init_ns_codec(1);
@@ -253,9 +258,14 @@
/* ensure there's no response to NS-ALIVE sent on idx==0 */
f_outgoing_ns_alive_no_ack(idx := 0);
- /* Expect BVC-RESET for signaling BVCI=0 and ptp BVCI */
- as_rx_bvc_reset_tx_ack(0, oneshot := true, idx := 1);
- as_rx_bvc_reset_tx_ack(mp_gb_cfg.bvci, oneshot := true, idx := 1);
+ if (sgsn_originated_reset) {
+ f_tx_bvc_reset_rx_ack(0, idx := 1);
+ f_tx_bvc_reset_rx_ack(mp_gb_cfg.bvci, idx := 1);
+ } else {
+ /* Expect BVC-RESET for signaling BVCI=0 and ptp BVCI */
+ as_rx_bvc_reset_tx_ack(0, oneshot := true, idx := 1);
+ as_rx_bvc_reset_tx_ack(mp_gb_cfg.bvci, oneshot := true, idx :=
1);
+ }
/* Expect UNBLOCK for ptp BVCI on signaling NS-VC (idx==1) */
as_rx_bvc_unblock_tx_ack(mp_gb_cfg.bvci, oneshot := true, idx := 1);
@@ -272,6 +282,39 @@
setverdict(pass);
}
+/* Test full IP-SNS bring-up with two NS-VCs, one sig-only and one user-only
and use
+ * SGSN-originated BVC-RESET rather than BSS-originated */
+testcase TC_sns_1c1u_so_bvc_reset() runs on RAW_Test_CT {
+ f_sns_bringup_1c1u_separate(sgsn_originated_reset := true);
+ setverdict(pass);
+}
+
+/* Transmit BVC-RESET before NS-ALIVE of PCU was ACKed: expect no response */
+testcase TC_sns_1c1u_so_bvc_reset_too_early() runs on RAW_Test_CT {
+ /* Activate two NS codec ports */
+
Change in osmo-ttcn3-hacks[master]: expected-results: add new S15-S0 related testscases
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/1 ) Change subject: expected-results: add new S15-S0 related testscases .. expected-results: add new S15-S0 related testscases The S15-S0 related testscases are missing from the expected-results.xml file. Lets add them. Change-Id: I28a853ec25feb723b2d333061e1ae4d2e0b34d86 Related: SYS#4470 --- M bsc/expected-results.xml 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Max: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index dadb349..f9de543 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -101,6 +101,23 @@ + + + + + + + + + + + + + + + + + -- To view, visit https://gerrit.osmocom.org/1 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I28a853ec25feb723b2d333061e1ae4d2e0b34d86 Gerrit-Change-Number: 1 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max
Change in libosmocore[master]: gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13332 ) Change subject: gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8d8fe7f79a2ec737baa7800247269c3271983e Gerrit-Change-Number: 13332 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 10:56:49 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Makefile.am: Add missing bits to have make release working
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13323 ) Change subject: Makefile.am: Add missing bits to have make release working .. Makefile.am: Add missing bits to have make release working Change-Id: I2758561ff2b08e33042161253a3bd36ce73bf259 --- M Makefile.am 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Harald Welte: Looks good to me, approved Max: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Makefile.am b/Makefile.am index a838715..59ac423 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,3 +1,5 @@ SUBDIRS = doc src ACLOCAL_AMFLAGS = -I m4 + +@RELMAKE@ -- To view, visit https://gerrit.osmocom.org/13323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2758561ff2b08e33042161253a3bd36ce73bf259 Gerrit-Change-Number: 13323 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: osmith
Change in osmo-sysmon[master]: Makefile.am: Add missing bits to have make release working
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13323 ) Change subject: Makefile.am: Add missing bits to have make release working .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2758561ff2b08e33042161253a3bd36ce73bf259 Gerrit-Change-Number: 13323 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 10:55:58 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: signal.c: Fix osmo_signal_talloc_ctx_init()
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13336
Change subject: signal.c: Fix osmo_signal_talloc_ctx_init()
..
signal.c: Fix osmo_signal_talloc_ctx_init()
This function is broken ever since it was added back in 2018 in commit
Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09
Rather than allocating from the user-supplied 'root_ctx', it is
allocating from the context that it's trying to create (which is
NULL at that time, rendering the entire operation more or less
a no-op. For sure you will not see osmo_signal structures never in
any talloc report.
Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f
---
M src/signal.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/13336/1
diff --git a/src/signal.c b/src/signal.c
index 188876b..2302788 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -52,7 +52,7 @@
* \returns the new osmo_signal talloc context, e.g. for reporting
*/
void *osmo_signal_talloc_ctx_init(void *root_ctx) {
- tall_sigh_ctx = talloc_named_const(tall_sigh_ctx, 0, "osmo_signal");
+ tall_sigh_ctx = talloc_named_const(root_ctx, 0, "osmo_signal");
return tall_sigh_ctx;
}
--
To view, visit https://gerrit.osmocom.org/13336
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f
Gerrit-Change-Number: 13336
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in libosmocore[master]: signal.c: Make non-exported tall_sigh_ctx static
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13337
Change subject: signal.c: Make non-exported tall_sigh_ctx static
..
signal.c: Make non-exported tall_sigh_ctx static
As indicated in the commitlog of
Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09,
the symbol was never exported in a header file, so it should be safe
to mark it as static.
Change-Id: I7132ffe9a7efcab226cc639d1b2357f7115bcadf
---
M src/signal.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/37/13337/1
diff --git a/src/signal.c b/src/signal.c
index 2302788..852749a 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -36,7 +36,7 @@
* \file signal.c */
-void *tall_sigh_ctx;
+static void *tall_sigh_ctx;
static LLIST_HEAD(signal_handler_list);
struct signal_handler {
--
To view, visit https://gerrit.osmocom.org/13337
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7132ffe9a7efcab226cc639d1b2357f7115bcadf
Gerrit-Change-Number: 13337
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in libosmocore[master]: make use of OTC_GLOBAL when allocating library-internal contexts
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13338
Change subject: make use of OTC_GLOBAL when allocating library-internal contexts
..
make use of OTC_GLOBAL when allocating library-internal contexts
As libosmcore is now managing the global talloc contexts, there's
no point in having APIs where the user tells the library about
which talloc contexts to use for a given sub-system.
Change-Id: I48f475efd3ee0d5120b8fc30861e852d1a6920b1
---
M include/osmocom/core/signal.h
M src/counter.c
M src/ctrl/control_vty.c
M src/gb/gprs_bssgp.c
M src/gsm/lapd_core.c
M src/logging.c
M src/signal.c
M src/stats.c
M src/vty/telnet_interface.c
M tests/ctrl/ctrl_test.c
10 files changed, 36 insertions(+), 22 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/13338/1
diff --git a/include/osmocom/core/signal.h b/include/osmocom/core/signal.h
index 449b976..0f17843 100644
--- a/include/osmocom/core/signal.h
+++ b/include/osmocom/core/signal.h
@@ -1,6 +1,7 @@
#pragma once
#include
+#include
/*! \defgroup signal Intra-application signals
* @{
@@ -34,7 +35,8 @@
/* Management */
-void *osmo_signal_talloc_ctx_init(void *root_ctx);
+void *osmo_signal_talloc_ctx_init(void *root_ctx)
+ OSMO_DEPRECATED("libosmocore internally allocates this context now.");
int osmo_signal_register_handler(unsigned int subsys, osmo_signal_cbfn *cbfn,
void *data);
void osmo_signal_unregister_handler(unsigned int subsys, osmo_signal_cbfn
*cbfn, void *data);
diff --git a/src/counter.c b/src/counter.c
index 0fa3166..482dfc2 100644
--- a/src/counter.c
+++ b/src/counter.c
@@ -1,7 +1,7 @@
/*! \file counter.c
* utility routines for keeping some statistics. */
/*
- * (C) 2009 by Harald Welte
+ * (C) 2009,2019 by Harald Welte
*
* All Rights Reserved
*
@@ -39,8 +39,12 @@
* \returns Allocated counter on success; NULL on error */
struct osmo_counter *osmo_counter_alloc(const char *name)
{
- struct osmo_counter *ctr = talloc_zero(tall_ctr_ctx, struct
osmo_counter);
+ struct osmo_counter *ctr;
+ if (!tall_ctr_ctx)
+ tall_ctr_ctx = talloc_named_const(OTC_GLOBAL, 0,
"osmo_counter");
+
+ ctr = talloc_zero(tall_ctr_ctx, struct osmo_counter);
if (!ctr)
return NULL;
diff --git a/src/ctrl/control_vty.c b/src/ctrl/control_vty.c
index ef98889..0dc8bfe 100644
--- a/src/ctrl/control_vty.c
+++ b/src/ctrl/control_vty.c
@@ -79,9 +79,14 @@
return CMD_SUCCESS;
}
+/*! Initialize the VTY configuration for the CTRL interface.
+ * \param[in] ctx UNUSED, only for legacy compatibility
+ * \returns 0 on success; negative on error */
int ctrl_vty_init(void *ctx)
{
- ctrl_vty_ctx = ctx;
+ ctrl_vty_ctx = talloc_named_const(OTC_GLOBAL, 0, "ctrl-vty");
+ if (!ctrl_vty_ctx)
+ return -1;
install_element(CONFIG_NODE, _ctrl_cmd);
install_node(_node, config_write_ctrl);
diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index 4a4bab3..884914b 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -121,6 +121,9 @@
{
struct bssgp_bvc_ctx *ctx;
+ if (!bssgp_tall_ctx)
+ bssgp_tall_ctx = talloc_named_const(OTC_GLOBAL, 0, "bssgp");
+
ctx = talloc_zero(bssgp_tall_ctx, struct bssgp_bvc_ctx);
if (!ctx)
return NULL;
diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c
index a2ff230..afbb1e9 100644
--- a/src/gsm/lapd_core.c
+++ b/src/gsm/lapd_core.c
@@ -252,7 +252,7 @@
dl->state = state;
}
-static void *tall_lapd_ctx = NULL;
+static __thread void *tall_lapd_ctx;
/* init datalink instance and allocate history */
void lapd_dl_init(struct lapd_datalink *dl, uint8_t k, uint8_t v_range,
@@ -299,7 +299,7 @@
lapd_dl_newstate(dl, LAPD_STATE_IDLE);
if (!tall_lapd_ctx)
- tall_lapd_ctx = talloc_named_const(NULL, 1, "lapd context");
+ tall_lapd_ctx = talloc_named_const(OTC_GLOBAL, 1, "lapd
context");
dl->tx_hist = talloc_zero_array(tall_lapd_ctx,
struct lapd_history, dl->range_hist);
}
diff --git a/src/logging.c b/src/logging.c
index 09021e4..80a1852 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -954,7 +954,7 @@
/*! Initialize the Osmocom logging core
* \param[in] inf Information regarding logging categories, could be NULL
- * \param[in] ctx \ref talloc context for logging allocations
+ * \param[in] ctx UNUSED, only for legacy API compatibility
* \returns 0 in case of success, negative in case of error
*
* If inf is NULL then only library-internal categories are initialized.
@@ -963,7 +963,7 @@
{
int i;
- tall_log_ctx = talloc_named_const(ctx, 1, "logging");
+ tall_log_ctx = talloc_named_const(OTC_GLOBAL, 1, "logging");
if (!tall_log_ctx)
return -ENOMEM;
diff --git
Change in osmo-ci[master]: jobs: add osmocom-list-commits.yml
Hello Max, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13302 to look at the new patch set (#6). Change subject: jobs: add osmocom-list-commits.yml .. jobs: add osmocom-list-commits.yml Related: OS#3840 Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b --- A jobs/osmocom-list-commits.yml 1 file changed, 44 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/02/13302/6 -- To view, visit https://gerrit.osmocom.org/13302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b Gerrit-Change-Number: 13302 Gerrit-PatchSet: 6 Gerrit-Owner: osmith Gerrit-Reviewer: Max Gerrit-Reviewer: osmith
Change in osmo-ci[master]: jobs: add osmocom-list-commits.yml
Max has posted comments on this change. ( https://gerrit.osmocom.org/13302 ) Change subject: jobs: add osmocom-list-commits.yml .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b Gerrit-Change-Number: 13302 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 10:36:17 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh
Max has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da Gerrit-Change-Number: 13301 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 10:35:14 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: jobs: add osmocom-list-commits.yml
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13302 ) Change subject: jobs: add osmocom-list-commits.yml .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/13302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a65cb750bbe6c278b9f67eb70bdb36759cb775b Gerrit-Change-Number: 13302 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 10:34:25 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh
Hello Pau Espin Pedrol, Max, Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13301 to look at the new patch set (#5). Change subject: Add scripts/osmocom-list-commits.sh .. Add scripts/osmocom-list-commits.sh Generate a table of Osmocom CNI repositories and their latest tag, related commit, and last commit on master. Related: OS#3840 Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da --- A scripts/osmocom-list-commits.sh 1 file changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/01/13301/5 -- To view, visit https://gerrit.osmocom.org/13301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da Gerrit-Change-Number: 13301 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith
Change in libosmocore[master]: select: Rename BSC_FD_* constants to OSMO_FD_*
Max has posted comments on this change. ( https://gerrit.osmocom.org/13335 ) Change subject: select: Rename BSC_FD_* constants to OSMO_FD_* .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifae33ed61a7cf0ae54ad487399e7dd2489986436 Gerrit-Change-Number: 13335 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 10:33:22 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Makefile.am: Add missing bits to have make release working
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13323 ) Change subject: Makefile.am: Add missing bits to have make release working .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2758561ff2b08e33042161253a3bd36ce73bf259 Gerrit-Change-Number: 13323 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 20 Mar 2019 09:53:28 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: Add debian packaging content
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13328 ) Change subject: Add debian packaging content .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13328/2/debian/osmo-sysmon.install File debian/osmo-sysmon.install: https://gerrit.osmocom.org/#/c/13328/2/debian/osmo-sysmon.install@3 PS2, Line 3: usr/share/doc/examples/osmo-sysmon.cfg usr/share/doc/osmo-sysmon/examples This needs to be: usr/share/doc/osmo-sysmon/examples/osmo-sysmon/osmo-sysmon.cfg usr/share/doc/osmo-sysmon/examples Otherwise it fails with: dh_install: Cannot find (any matches for) "usr/share/doc/examples/osmo-sysmon.cfg" (tried in "." and "debian/tmp") dh_install: osmo-sysmon missing files: usr/share/doc/examples/osmo-sysmon.cfg dh_install: missing files, aborting -- To view, visit https://gerrit.osmocom.org/13328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bcacca040364f77aa6b17edf53acf53c820c17b Gerrit-Change-Number: 13328 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 09:49:59 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: test
dexter has abandoned this change. ( https://gerrit.osmocom.org/13324 ) Change subject: test .. Abandoned -- To view, visit https://gerrit.osmocom.org/13324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I0cf5432aec1f61adc6f6cf74a8d4f89dbaea0863 Gerrit-Change-Number: 13324 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Max
Change in libosmocore[master]: select: Rename BSC_FD_* constants to OSMO_FD_*
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13335
Change subject: select: Rename BSC_FD_* constants to OSMO_FD_*
..
select: Rename BSC_FD_* constants to OSMO_FD_*
The naming of these constants dates back to when the code was private
within OpenBSC. Everything else was renamed (bsc_fd -> osmo_fd) at
the time, but somehow the BSC_FD_* defines have been missed at the
time.
Keep compatibility #defines around, but allow us to migrate the
applications to a less confusing naming meanwhile.
Change-Id: Ifae33ed61a7cf0ae54ad487399e7dd2489986436
---
M include/osmocom/core/select.h
M src/ctrl/control_if.c
M src/gb/gprs_ns.c
M src/gb/gprs_ns_frgre.c
M src/gsmtap_util.c
M src/select.c
M src/socket.c
M src/vty/telnet_interface.c
M src/write_queue.c
9 files changed, 42 insertions(+), 37 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/13335/1
diff --git a/include/osmocom/core/select.h b/include/osmocom/core/select.h
index 1ba6b83..e4787b0 100644
--- a/include/osmocom/core/select.h
+++ b/include/osmocom/core/select.h
@@ -13,11 +13,16 @@
* \file select.h */
/*! Indicate interest in reading from the file descriptor */
-#define BSC_FD_READ0x0001
+#define OSMO_FD_READ 0x0001
/*! Indicate interest in writing to the file descriptor */
-#define BSC_FD_WRITE 0x0002
+#define OSMO_FD_WRITE 0x0002
/*! Indicate interest in exceptions from the file descriptor */
-#define BSC_FD_EXCEPT 0x0004
+#define OSMO_FD_EXCEPT 0x0004
+
+/* legacy naming dating back to early OpenBSC / bsc_hack of 2008 */
+#define BSC_FD_READOSMO_FD_READ
+#define BSC_FD_WRITE OSMO_FD_WRITE
+#define BSC_FD_EXCEPT OSMO_FD_EXCEPT
/*! Structure representing a file dsecriptor */
struct osmo_fd {
@@ -25,8 +30,8 @@
struct llist_head list;
/*! actual operating-system level file decriptor */
int fd;
- /*! bit-mask or of \ref BSC_FD_READ, \ref BSC_FD_WRITE and/or
-* \ref BSC_FD_EXCEPT */
+ /*! bit-mask or of \ref OSMO_FD_READ, \ref OSMO_FD_WRITE and/or
+* \ref OSMO_FD_EXCEPT */
unsigned int when;
/*! call-back function to be called once file descriptor becomes
* available */
diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c
index 0209f3b..ce2e367 100644
--- a/src/ctrl/control_if.c
+++ b/src/ctrl/control_if.c
@@ -524,7 +524,7 @@
char *name;
- if (!(what & BSC_FD_READ))
+ if (!(what & OSMO_FD_READ))
return 0;
fd = accept(listen_bfd->fd, NULL, NULL);
@@ -554,7 +554,7 @@
LOGP(DLCTRL, LOGL_INFO, "accept()ed new CTRL connection from %s\n",
name);
ccon->write_queue.bfd.fd = fd;
- ccon->write_queue.bfd.when = BSC_FD_READ;
+ ccon->write_queue.bfd.when = OSMO_FD_READ;
ret = osmo_fd_register(>write_queue.bfd);
if (ret < 0) {
diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index 8c3b0fa..c7ff78e 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -2006,9 +2006,9 @@
{
int rc = 0;
- if (what & BSC_FD_READ)
+ if (what & OSMO_FD_READ)
rc = handle_nsip_read(bfd);
- if (what & BSC_FD_WRITE)
+ if (what & OSMO_FD_WRITE)
rc = handle_nsip_write(bfd);
return rc;
diff --git a/src/gb/gprs_ns_frgre.c b/src/gb/gprs_ns_frgre.c
index 483fdb6..dbbd8d2 100644
--- a/src/gb/gprs_ns_frgre.c
+++ b/src/gb/gprs_ns_frgre.c
@@ -315,9 +315,9 @@
{
int rc = 0;
- if (what & BSC_FD_READ)
+ if (what & OSMO_FD_READ)
rc = handle_nsfrgre_read(bfd);
- if (what & BSC_FD_WRITE)
+ if (what & OSMO_FD_WRITE)
rc = handle_nsfrgre_write(bfd);
return rc;
diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c
index 385b467..996830f 100644
--- a/src/gsmtap_util.c
+++ b/src/gsmtap_util.c
@@ -355,7 +355,7 @@
int rc;
uint8_t buf[4096];
- if (!(flags & BSC_FD_READ))
+ if (!(flags & OSMO_FD_READ))
return 0;
rc = read(fd->fd, buf, sizeof(buf));
@@ -395,7 +395,7 @@
sink_ofd = >sink_ofd;
sink_ofd->fd = fd;
- sink_ofd->when = BSC_FD_READ;
+ sink_ofd->when = OSMO_FD_READ;
sink_ofd->cb = gsmtap_sink_fd_cb;
rc = osmo_fd_register(sink_ofd);
diff --git a/src/select.c b/src/select.c
index 4e7be35..7ce135f 100644
--- a/src/select.c
+++ b/src/select.c
@@ -55,7 +55,7 @@
/*! Set up an osmo-fd. Will not register it.
* \param[inout] ofd Osmo FD to be set-up
* \param[in] fd OS-level file descriptor number
- * \param[in] when bit-mask of BSC_FD_{READ,WRITE,EXECEPT}
+ * \param[in] when bit-mask of OSMO_FD_{READ,WRITE,EXECEPT}
* \param[in] cb Call-back function to be called
* \param[in] data Private context pointer
* \param[in] priv_nr Private number
@@ -171,13 +171,13 @@
int highfd = 0;
Change in osmo-ttcn3-hacks[master]: pcu: Add SNS tests for SGSN-originated BVC-RESET handling
Max has posted comments on this change. ( https://gerrit.osmocom.org/13334 ) Change subject: pcu: Add SNS tests for SGSN-originated BVC-RESET handling .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b80acf98711f4749da4faf549b02ff2b82425f Gerrit-Change-Number: 13334 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 09:21:52 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: test
Max has posted comments on this change. ( https://gerrit.osmocom.org/13324 ) Change subject: test .. Patch Set 1: Can you mark this as WIP? -- To view, visit https://gerrit.osmocom.org/13324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cf5432aec1f61adc6f6cf74a8d4f89dbaea0863 Gerrit-Change-Number: 13324 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 09:19:39 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmocore[master]: gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4()
Max has posted comments on this change. ( https://gerrit.osmocom.org/13332 ) Change subject: gprs_ns_sns: Properly initialize sockaddr_in in gprs_nsvc_create_ip4() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8d8fe7f79a2ec737baa7800247269c3271983e Gerrit-Change-Number: 13332 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Wed, 20 Mar 2019 09:18:57 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
