Change in osmo-msc[master]: Allow MME name preformatted as FQDN in SGsAP
Omar Ramadan has uploaded this change for review. (
https://gerrit.osmocom.org/13627
Change subject: Allow MME name preformatted as FQDN in SGsAP
..
Allow MME name preformatted as FQDN in SGsAP
Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
---
M src/libmsc/sgs_iface.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/27/13627/1
diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index f64b191..9ad8021 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -167,6 +167,12 @@
if (!mme_name_enc)
return -EINVAL;
+ /* some implementations use FDQN format violating TS 29.118 9.3.14 */
+ if (!osmo_parse_mme_domain(, (const char *) mme_name_enc)) {
+ memcpy(mme_name, mme_name_enc, TLVP_LEN(tp, SGSAP_IE_MME_NAME));
+ return 0;
+ }
+
/* decode the MME name from DNS labels to string */
osmo_apn_to_str(mme_name, TLVP_VAL(tp, SGSAP_IE_MME_NAME), TLVP_LEN(tp,
SGSAP_IE_MME_NAME));
--
To view, visit https://gerrit.osmocom.org/13627
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
Gerrit-Change-Number: 13627
Gerrit-PatchSet: 1
Gerrit-Owner: Omar Ramadan
Change in osmo-ci[master]: nightly-packages: Move some code and rename some vars to look similar...
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13604 ) Change subject: nightly-packages: Move some code and rename some vars to look similar to latest-packages .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/13604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177bb7fb75e293ef665e95363a38c6b4f8e49c13 Gerrit-Change-Number: 13604 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 17:13:12 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: nightly-packages: Build latest tag of limesuite
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13605 ) Change subject: nightly-packages: Build latest tag of limesuite .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/13605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a9e97a7a93c1d2a9983926cd0f5d7255e9666bd Gerrit-Change-Number: 13605 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:56:20 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: nightly-packages: Move some code and rename some vars to look similar...
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13604 ) Change subject: nightly-packages: Move some code and rename some vars to look similar to latest-packages .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177bb7fb75e293ef665e95363a38c6b4f8e49c13 Gerrit-Change-Number: 13604 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:56:16 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: nightly-packages: Remove duplicated check
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13602 ) Change subject: nightly-packages: Remove duplicated check .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9659e71d87b03971673da3bfb2101de9d5fe3c6a Gerrit-Change-Number: 13602 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:56:07 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: nightly-packages: Remove unused variable
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13603 ) Change subject: nightly-packages: Remove unused variable .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic120dbc134cba9bd77098ab14a5dba3d5c4d71b9 Gerrit-Change-Number: 13603 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:56:10 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: nightly-packages: Move some code and rename some vars to look similar...
Pau Espin Pedrol has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/13604 ) Change subject: nightly-packages: Move some code and rename some vars to look similar to latest-packages .. nightly-packages: Move some code and rename some vars to look similar to latest-packages Change-Id: I177bb7fb75e293ef665e95363a38c6b4f8e49c13 --- M scripts/osmocom-latest-packages.sh M scripts/osmocom-nightly-packages.sh 2 files changed, 28 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/04/13604/2 -- To view, visit https://gerrit.osmocom.org/13604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I177bb7fb75e293ef665e95363a38c6b4f8e49c13 Gerrit-Change-Number: 13604 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol
Change in libosmocore[master]: gsm/gsm_utils.c: indicate intentional fall-through
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13626 ) Change subject: gsm/gsm_utils.c: indicate intentional fall-through .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica7d2d1884b745fe30234d6c50d93828c4930680 Gerrit-Change-Number: 13626 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:49:15 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: gsm/gsm_utils.c: indicate intentional fall-through
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13626 Change subject: gsm/gsm_utils.c: indicate intentional fall-through .. gsm/gsm_utils.c: indicate intentional fall-through Change-Id: Ica7d2d1884b745fe30234d6c50d93828c4930680 Fixes: CID#57700 --- M src/gsm/gsm_utils.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/26/13626/1 diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index 94c6ca5..07f053c 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -307,6 +307,7 @@ case 0x5d: case 0x7c: result[y++] = 0x1b; + /* fall-through */ default: result[y] = gsm_7bit_alphabet[ch]; break; -- To view, visit https://gerrit.osmocom.org/13626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ica7d2d1884b745fe30234d6c50d93828c4930680 Gerrit-Change-Number: 13626 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy
Change in osmo-ci[master]: nightly-packages: Move some code and rename some vars to look similar...
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13604 ) Change subject: nightly-packages: Move some code and rename some vars to look similar to latest-packages .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/13604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I177bb7fb75e293ef665e95363a38c6b4f8e49c13 Gerrit-Change-Number: 13604 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:37:21 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: gb/gprs_ns_sns.c: fix incorrect sizeof() calculation
Vadim Yanitskiy has submitted this change and it was merged. (
https://gerrit.osmocom.org/13625 )
Change subject: gb/gprs_ns_sns.c: fix incorrect sizeof() calculation
..
gb/gprs_ns_sns.c: fix incorrect sizeof() calculation
Calling sizeof() on a pointer would result in getting size of the
pointer (usually 4 or 8 bytes) itself, but not the size of the
memory it points to.
Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6
Fixes: CID#194266
---
M src/gb/gprs_ns_sns.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Vadim Yanitskiy: Looks good to me, approved
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gb/gprs_ns_sns.c b/src/gb/gprs_ns_sns.c
index dd8d3a2..aa8b121 100644
--- a/src/gb/gprs_ns_sns.c
+++ b/src/gb/gprs_ns_sns.c
@@ -498,7 +498,7 @@
}
/* make a copy as do_sns_delete() will change the array
underneath us */
ip4_remote = talloc_memdup(fi, gss->ip4_remote,
-
gss->num_ip4_remote*sizeof(v4_list));
+
gss->num_ip4_remote*sizeof(*v4_list));
for (i = 0; i < gss->num_ip4_remote; i++) {
if (ip4_remote[i].ip_addr == ip_addr) {
rc = do_sns_delete(fi, _remote[i]);
--
To view, visit https://gerrit.osmocom.org/13625
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6
Gerrit-Change-Number: 13625
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Vadim Yanitskiy
Change in libosmocore[master]: add vty_is_active()
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13581 ) Change subject: add vty_is_active() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42cf2af47283dd42c101faae0fac293c3a68d599 Gerrit-Change-Number: 13581 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Apr 2019 15:32:05 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: GSUP: add inter-MSC handover related msgs and IEs
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12860 ) Change subject: GSUP: add inter-MSC handover related msgs and IEs .. Patch Set 9: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12860/9/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: https://gerrit.osmocom.org/#/c/12860/9/include/osmocom/gsm/gsup.h@369 PS9, Line 369: cause_rr_set An alternative solution is to use pointers, i.e.: uint8_t *cause_rr; enum gsm0808_cause *cause_bssap; This is how we do for sm_rp_cause and sm_rp_mms, so there is no need for such bool flags. -- To view, visit https://gerrit.osmocom.org/12860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic00b0601eacff6d72927cea51767801142ee75db Gerrit-Change-Number: 12860 Gerrit-PatchSet: 9 Gerrit-Owner: osmith Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Apr 2019 15:29:28 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in libosmocore[master]: gb/gprs_ns_sns.c: fix incorrect sizeof() calculation
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13625 ) Change subject: gb/gprs_ns_sns.c: fix incorrect sizeof() calculation .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6 Gerrit-Change-Number: 13625 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Apr 2019 15:22:54 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: gb/gprs_ns_sns.c: fix incorrect sizeof() calculation
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13625 ) Change subject: gb/gprs_ns_sns.c: fix incorrect sizeof() calculation .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/13625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6 Gerrit-Change-Number: 13625 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Fri, 12 Apr 2019 15:19:14 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmocore[master]: gb/gprs_ns_sns.c: fix incorrect sizeof() calculation
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13625 ) Change subject: gb/gprs_ns_sns.c: fix incorrect sizeof() calculation .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6 Gerrit-Change-Number: 13625 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Apr 2019 15:19:16 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: gb/gprs_ns_sns.c: fix incorrect buffer size calculation
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13625 ) Change subject: gb/gprs_ns_sns.c: fix incorrect buffer size calculation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6 Gerrit-Change-Number: 13625 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-CC: Jenkins Builder (102) Gerrit-Comment-Date: Fri, 12 Apr 2019 15:13:48 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13597 )
Change subject: Makefile.common.inc: add {,un}install targets
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 5
Gerrit-Owner: osmith
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: osmith
Gerrit-Comment-Date: Fri, 12 Apr 2019 15:13:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Change in osmo-bts[master]: common/pcu_sock.c: fix possible memleaks in pcu_sock_read()
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13618 )
Change subject: common/pcu_sock.c: fix possible memleaks in pcu_sock_read()
..
common/pcu_sock.c: fix possible memleaks in pcu_sock_read()
Change-Id: I58352e5f2b5715361c7089d0e134a42975171022
---
M src/common/pcu_sock.c
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, approved
Harald Welte: Looks good to me, approved
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index d694602..d496a49 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -790,14 +790,17 @@
goto close;
if (rc < 0) {
- if (errno == EAGAIN)
+ if (errno == EAGAIN) {
+ msgb_free(msg);
return 0;
+ }
goto close;
}
if (rc < sizeof(*pcu_prim)) {
LOGP(DPCU, LOGL_ERROR, "Received %d bytes on PCU Socket, but
primitive size "
"is %lu, discarding\n", rc, sizeof(*pcu_prim));
+ msgb_free(msg);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/13618
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58352e5f2b5715361c7089d0e134a42975171022
Gerrit-Change-Number: 13618
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-bts[master]: common/pcu_sock.c: fix possible memleaks in pcu_sock_read()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13618 ) Change subject: common/pcu_sock.c: fix possible memleaks in pcu_sock_read() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58352e5f2b5715361c7089d0e134a42975171022 Gerrit-Change-Number: 13618 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:11:34 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: gb/gprs_ns_sns.c: fix incorrect buffer size calculation
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13625
Change subject: gb/gprs_ns_sns.c: fix incorrect buffer size calculation
..
gb/gprs_ns_sns.c: fix incorrect buffer size calculation
Calling sizeof() on a pointer to dynamically allocated memory would
result in getting size of the pointer (usually 4 or 8 bytes) itself,
but not the size of allocated memory.
Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6
Fixes: CID#194266
---
M src/gb/gprs_ns_sns.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/13625/1
diff --git a/src/gb/gprs_ns_sns.c b/src/gb/gprs_ns_sns.c
index dd8d3a2..aa8b121 100644
--- a/src/gb/gprs_ns_sns.c
+++ b/src/gb/gprs_ns_sns.c
@@ -498,7 +498,7 @@
}
/* make a copy as do_sns_delete() will change the array
underneath us */
ip4_remote = talloc_memdup(fi, gss->ip4_remote,
-
gss->num_ip4_remote*sizeof(v4_list));
+
gss->num_ip4_remote*sizeof(*v4_list));
for (i = 0; i < gss->num_ip4_remote; i++) {
if (ip4_remote[i].ip_addr == ip_addr) {
rc = do_sns_delete(fi, _remote[i]);
--
To view, visit https://gerrit.osmocom.org/13625
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6
Gerrit-Change-Number: 13625
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Change in osmo-ttcn3-hacks[master]: Ensure BcdMccMnc is encoded as 24.008 10.5.5.15
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13619 ) Change subject: Ensure BcdMccMnc is encoded as 24.008 10.5.5.15 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f67f16f18e4c5090bc5a4c46a866a7e7e00206 Gerrit-Change-Number: 13619 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Fri, 12 Apr 2019 15:10:22 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: Fix incorrect buffer size calculation
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13620 )
Change subject: Fix incorrect buffer size calculation
..
Fix incorrect buffer size calculation
Calling sizeof() on a pointer to dynamically allocated memory would
result in getting size of the pointer (usually 4 or 8 bytes) itself,
but not the size of allocated memory.
Change-Id: I8ffda4dea2b7f9b4b76dfeecad1fab6384c5a62c
Fixes: CID#197629, CID#197628, CID#197627
Fixes: CID#197626, CID#197625, CID#197624
---
M src/msgb.c
M src/socket.c
M src/utils.c
3 files changed, 16 insertions(+), 11 deletions(-)
Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, approved
Harald Welte: Looks good to me, approved
diff --git a/src/msgb.c b/src/msgb.c
index 5a154e5..940135f 100644
--- a/src/msgb.c
+++ b/src/msgb.c
@@ -522,10 +522,11 @@
*/
char *msgb_hexdump_c(const void *ctx, const struct msgb *msg)
{
- char *buf = talloc_size(ctx, msgb_length(msg)*3 + 100);
+ size_t buf_len = msgb_length(msg) * 3 + 100;
+ char *buf = talloc_size(ctx, buf_len);
if (!buf)
return NULL;
- return msgb_hexdump_buf(buf, sizeof(buf), msg);
+ return msgb_hexdump_buf(buf, buf_len, msg);
}
/*! Print a string to the end of message buffer.
diff --git a/src/socket.c b/src/socket.c
index c817e72..7c412b6 100644
--- a/src/socket.c
+++ b/src/socket.c
@@ -837,7 +837,7 @@
char *str = talloc_size(ctx, OSMO_SOCK_NAME_MAXLEN);
if (!str)
return NULL;
- osmo_sock_get_name_buf(str, sizeof(str), fd);
+ osmo_sock_get_name_buf(str, OSMO_SOCK_NAME_MAXLEN, fd);
return str;
}
diff --git a/src/utils.c b/src/utils.c
index 896e917..b66721e 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -351,10 +351,11 @@
*/
char *osmo_hexdump_c(const void *ctx, const unsigned char *buf, int len)
{
- char *hexd_buff = talloc_size(ctx, len*3 + 1);
+ size_t hexd_buff_len = len * 3 + 1;
+ char *hexd_buff = talloc_size(ctx, hexd_buff_len);
if (!hexd_buff)
return NULL;
- osmo_hexdump_buf(hexd_buff, sizeof(hexd_buff), buf, len, " ", true);
+ osmo_hexdump_buf(hexd_buff, hexd_buff_len, buf, len, " ", true);
return hexd_buff;
}
@@ -389,10 +390,11 @@
*/
char *osmo_hexdump_nospc_c(const void *ctx, const unsigned char *buf, int len)
{
- char *hexd_buff = talloc_size(ctx, len*2 + 1);
+ size_t hexd_buff_len = len * 2 + 1;
+ char *hexd_buff = talloc_size(ctx, hexd_buff_len);
if (!hexd_buff)
return NULL;
- osmo_hexdump_buf(hexd_buff, sizeof(hexd_buff), buf, len, "", true);
+ osmo_hexdump_buf(hexd_buff, hexd_buff_len, buf, len, "", true);
return hexd_buff;
}
@@ -908,10 +910,11 @@
*/
char *osmo_str_tolower_c(const void *ctx, const char *src)
{
- char *buf = talloc_size(ctx, strlen(src)+1);
+ size_t buf_len = strlen(src) + 1;
+ char *buf = talloc_size(ctx, buf_len);
if (!buf)
return NULL;
- osmo_str_tolower_buf(buf, sizeof(buf), src);
+ osmo_str_tolower_buf(buf, buf_len, src);
return buf;
}
@@ -966,10 +969,11 @@
*/
char *osmo_str_toupper_c(const void *ctx, const char *src)
{
- char *buf = talloc_size(ctx, strlen(src)+1);
+ size_t buf_len = strlen(src) + 1;
+ char *buf = talloc_size(ctx, buf_len);
if (!buf)
return NULL;
- osmo_str_toupper_buf(buf, sizeof(buf), src);
+ osmo_str_toupper_buf(buf, buf_len, src);
return buf;
}
--
To view, visit https://gerrit.osmocom.org/13620
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ffda4dea2b7f9b4b76dfeecad1fab6384c5a62c
Gerrit-Change-Number: 13620
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Change in libosmocore[master]: Fix incorrect buffer size calculation
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13620 ) Change subject: Fix incorrect buffer size calculation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ffda4dea2b7f9b4b76dfeecad1fab6384c5a62c Gerrit-Change-Number: 13620 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:09:56 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sgsn[master]: LLC XID: Fix string representation of N201_U
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13622 ) Change subject: LLC XID: Fix string representation of N201_U .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8799e3a3c47377aeeb9923d9d73f5d0b73cd8d0b Gerrit-Change-Number: 13622 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Jenkins Builder (102) Gerrit-Comment-Date: Fri, 12 Apr 2019 15:09:54 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sgsn[master]: LLC: Store the XID inside the LLC Entity, not LLC Mgmg Entity
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13623
Change subject: LLC: Store the XID inside the LLC Entity, not LLC Mgmg Entity
..
LLC: Store the XID inside the LLC Entity, not LLC Mgmg Entity
The LLC XID exchange is negotiating parameters for a given SAPI,
and not for the entire connection from/to that given subscriber.
Change-Id: Iaeb54ca5ac58391be45e56c2e721f531969f3a9e
---
M include/osmocom/sgsn/gprs_llc.h
M src/gprs/gprs_llc.c
M src/gprs/gprs_sndcp.c
3 files changed, 25 insertions(+), 26 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/23/13623/1
diff --git a/include/osmocom/sgsn/gprs_llc.h b/include/osmocom/sgsn/gprs_llc.h
index 376ae9a..711bcd6 100644
--- a/include/osmocom/sgsn/gprs_llc.h
+++ b/include/osmocom/sgsn/gprs_llc.h
@@ -145,6 +145,13 @@
unsigned int retrans_ctr;
struct gprs_llc_params params;
+
+ /* Copy of the XID fields we have sent with the last
+* network originated XID-Request. Since the phone
+* may strip the optional fields in the confirmation
+* we need to remeber those fields in order to be
+* able to create the compression entity. */
+ struct llist_head *xid;
};
#define NUM_SAPIS 16
@@ -169,13 +176,6 @@
uint16_t nsei;
struct gprs_llc_lle lle[NUM_SAPIS];
- /* Copy of the XID fields we have sent with the last
-* network originated XID-Request. Since the phone
-* may strip the optional fields in the confirmation
-* we need to remeber those fields in order to be
-* able to create the compression entity. */
- struct llist_head *xid;
-
/* Compression entities */
struct {
/* In these two list_heads we will store the
diff --git a/src/gprs/gprs_llc.c b/src/gprs/gprs_llc.c
index abbb742..1cb0f5d 100644
--- a/src/gprs/gprs_llc.c
+++ b/src/gprs/gprs_llc.c
@@ -52,7 +52,7 @@
/* Generate XID message */
static int gprs_llc_generate_xid(uint8_t *bytes, int bytes_len,
struct gprs_llc_xid_field *l3_xid_field,
-struct gprs_llc_llme *llme)
+struct gprs_llc_lle *lle)
{
/* Note: Called by gprs_ll_xid_req() */
@@ -89,8 +89,8 @@
}
/* Store generated XID for later reference */
- talloc_free(llme->xid);
- llme->xid = gprs_llc_copy_xid(llme, _fields);
+ talloc_free(lle->xid);
+ lle->xid = gprs_llc_copy_xid(lle->llme, _fields);
return gprs_llc_compile_xid(bytes, bytes_len, _fields);
}
@@ -98,7 +98,7 @@
/* Generate XID message that will cause the GMM to reset */
static int gprs_llc_generate_xid_for_gmm_reset(uint8_t *bytes,
int bytes_len, uint32_t iov_ui,
- struct gprs_llc_llme *llme)
+ struct gprs_llc_lle *lle)
{
/* Called by gprs_llgmm_reset() and
* gprs_llgmm_reset_oldmsg() */
@@ -123,8 +123,8 @@
llist_add(_reset.list, _fields);
/* Store generated XID for later reference */
- talloc_free(llme->xid);
- llme->xid = gprs_llc_copy_xid(llme, _fields);
+ talloc_free(lle->xid);
+ lle->xid = gprs_llc_copy_xid(lle->llme, _fields);
return gprs_llc_compile_xid(bytes, bytes_len, _fields);
}
@@ -143,8 +143,8 @@
struct gprs_llc_xid_field *xid_field_request_l3 = NULL;
/* Pick layer3 XID from the XID request we have sent last */
- if (lle->llme->xid) {
- llist_for_each_entry(xid_field_request, lle->llme->xid, list) {
+ if (lle->xid) {
+ llist_for_each_entry(xid_field_request, lle->xid, list) {
if (xid_field_request->type == GPRS_LLC_XID_T_L3_PAR)
xid_field_request_l3 = xid_field_request;
}
@@ -188,8 +188,8 @@
}
/* Flush pending XID fields */
- talloc_free(lle->llme->xid);
- lle->llme->xid = NULL;
+ talloc_free(lle->xid);
+ lle->xid = NULL;
return 0;
}
@@ -324,8 +324,7 @@
/* Generate XID */
xid_bytes_len =
- gprs_llc_generate_xid(xid_bytes, sizeof(xid_bytes),
- l3_xid_field, lle->llme);
+ gprs_llc_generate_xid(xid_bytes, sizeof(xid_bytes), l3_xid_field,
lle);
/* Only perform XID sending if the XID message contains something */
if (xid_bytes_len > 0) {
@@ -576,7 +575,6 @@
{
gprs_sndcp_comp_free(llme->comp.proto);
gprs_sndcp_comp_free(llme->comp.data);
- talloc_free(llme->xid);
llist_del(>list);
talloc_free(llme);
}
@@ -1084,8 +1082,8 @@
}
/* Generate XID message */
- xid_bytes_len = gprs_llc_generate_xid_for_gmm_reset(xid_bytes,
-
Change in osmo-sgsn[master]: LLC: Don't use hard-coded N201-U / N201-I values in XID
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13624 Change subject: LLC: Don't use hard-coded N201-U / N201-I values in XID .. LLC: Don't use hard-coded N201-U / N201-I values in XID The N201 values are negotiated per SAPI, and there are default values per each SAPI. Let's use those rather than hard-coded values. Change-Id: I447a3c6dd85311772a6e219c62dc820d2726857f --- M src/gprs/gprs_llc.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/24/13624/1 diff --git a/src/gprs/gprs_llc.c b/src/gprs/gprs_llc.c index 1cb0f5d..2111e10 100644 --- a/src/gprs/gprs_llc.c +++ b/src/gprs/gprs_llc.c @@ -61,17 +61,20 @@ struct gprs_llc_xid_field xid_version; struct gprs_llc_xid_field xid_n201u; struct gprs_llc_xid_field xid_n201i; + uint16_t n201_u, n201_i; xid_version.type = GPRS_LLC_XID_T_VERSION; xid_version.data = (uint8_t *) "\x00"; xid_version.data_len = 1; + n201_u = htons(lle->params.n201_u); xid_n201u.type = GPRS_LLC_XID_T_N201_U; - xid_n201u.data = (uint8_t *) "\x05\xf0"; + xid_n201u.data = (uint8_t *) _u; xid_n201u.data_len = 2; + n201_i = htons(lle->params.n201_i); xid_n201i.type = GPRS_LLC_XID_T_N201_I; - xid_n201i.data = (uint8_t *) "\x05\xf0"; + xid_n201i.data = (uint8_t *) _i; xid_n201i.data_len = 2; /* Add locally managed XID Fields */ -- To view, visit https://gerrit.osmocom.org/13624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I447a3c6dd85311772a6e219c62dc820d2726857f Gerrit-Change-Number: 13624 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte
Change in osmo-sgsn[master]: LLC XID: Fix string representation of N201_U
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13622
Change subject: LLC XID: Fix string representation of N201_U
..
LLC XID: Fix string representation of N201_U
Change-Id: I8799e3a3c47377aeeb9923d9d73f5d0b73cd8d0b
---
M src/gprs/gprs_llc_xid.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/22/13622/1
diff --git a/src/gprs/gprs_llc_xid.c b/src/gprs/gprs_llc_xid.c
index de60e49..b91fa6b 100644
--- a/src/gprs/gprs_llc_xid.c
+++ b/src/gprs/gprs_llc_xid.c
@@ -41,7 +41,7 @@
{ GPRS_LLC_XID_T_IOV_I, "IOV_I"},
{ GPRS_LLC_XID_T_T200, "T200"},
{ GPRS_LLC_XID_T_N200, "N200"},
- { GPRS_LLC_XID_T_N201_U,"N201_"},
+ { GPRS_LLC_XID_T_N201_U,"N201_U"},
{ GPRS_LLC_XID_T_N201_I,"N201_I"},
{ GPRS_LLC_XID_T_mD,"mD"},
{ GPRS_LLC_XID_T_mU,"mU"},
--
To view, visit https://gerrit.osmocom.org/13622
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8799e3a3c47377aeeb9923d9d73f5d0b73cd8d0b
Gerrit-Change-Number: 13622
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in libosmocore[master]: Fix incorrect buffer size calculation
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13620 ) Change subject: Fix incorrect buffer size calculation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ffda4dea2b7f9b4b76dfeecad1fab6384c5a62c Gerrit-Change-Number: 13620 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 15:08:52 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-tester[master]: powersupply: Add support for Intellinet PDU
Pau Espin Pedrol has uploaded this change for review. (
https://gerrit.osmocom.org/13621
Change subject: powersupply: Add support for Intellinet PDU
..
powersupply: Add support for Intellinet PDU
Based on original pdutool code from Joachim Steiger.
Change-Id: Iab4f7aec1c50f47da4cd734441bb36fa09d171a3
---
M check_dependencies.py
M src/osmo_gsm_tester/powersupply.py
A src/osmo_gsm_tester/powersupply_intellinet.py
3 files changed, 103 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/21/13621/1
diff --git a/check_dependencies.py b/check_dependencies.py
index 83df7a9..28bfdf7 100755
--- a/check_dependencies.py
+++ b/check_dependencies.py
@@ -26,5 +26,7 @@
import sqlite3
import sispm
import smpplib
+import urllib.request
+import xml.etree.ElementTree
print('dependencies ok')
diff --git a/src/osmo_gsm_tester/powersupply.py
b/src/osmo_gsm_tester/powersupply.py
index 86fc010..1cf7106 100644
--- a/src/osmo_gsm_tester/powersupply.py
+++ b/src/osmo_gsm_tester/powersupply.py
@@ -1,6 +1,6 @@
# osmo_gsm_tester: class defining a Power Supply object
#
-# Copyright (C) 2018 by sysmocom - s.f.m.c. GmbH
+# Copyright (C) 2018-2019 by sysmocom - s.f.m.c. GmbH
#
# Author: Pau Espin Pedrol
#
@@ -51,10 +51,11 @@
self.power_set(True)
-from . import powersupply_sispm
+from . import powersupply_sispm, powersupply_intellinet
KNOWN_PWSUPPLY_TYPES = {
'sispm' : powersupply_sispm.PowerSupplySispm,
+'intellinet' : powersupply_intellinet.PowerSupplyIntellinet,
}
def register_type(name, clazz):
diff --git a/src/osmo_gsm_tester/powersupply_intellinet.py
b/src/osmo_gsm_tester/powersupply_intellinet.py
new file mode 100644
index 000..c2bf2c8
--- /dev/null
+++ b/src/osmo_gsm_tester/powersupply_intellinet.py
@@ -0,0 +1,98 @@
+# osmo_gsm_tester: class defining a Power Supply object
+#
+# Copyright (C) 2019 by sysmocom - s.f.m.c. GmbH
+#
+# Author: Pau Espin Pedrol
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as
+# published by the Free Software Foundation, either version 3 of the
+# License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see
Change in libosmocore[master]: Fix incorrect buffer size calculation
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13620
Change subject: Fix incorrect buffer size calculation
..
Fix incorrect buffer size calculation
Calling sizeof() on a pointer to dynamically allocated memory would
result in getting size of the pointer (usually 4 or 8 bytes) itself,
but not the size of allocated memory.
Change-Id: I8ffda4dea2b7f9b4b76dfeecad1fab6384c5a62c
Fixes: CID#197629, CID#197628, CID#197627
Fixes: CID#197626, CID#197625, CID#197624
---
M src/msgb.c
M src/socket.c
M src/utils.c
3 files changed, 16 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/13620/1
diff --git a/src/msgb.c b/src/msgb.c
index 5a154e5..940135f 100644
--- a/src/msgb.c
+++ b/src/msgb.c
@@ -522,10 +522,11 @@
*/
char *msgb_hexdump_c(const void *ctx, const struct msgb *msg)
{
- char *buf = talloc_size(ctx, msgb_length(msg)*3 + 100);
+ size_t buf_len = msgb_length(msg) * 3 + 100;
+ char *buf = talloc_size(ctx, buf_len);
if (!buf)
return NULL;
- return msgb_hexdump_buf(buf, sizeof(buf), msg);
+ return msgb_hexdump_buf(buf, buf_len, msg);
}
/*! Print a string to the end of message buffer.
diff --git a/src/socket.c b/src/socket.c
index c817e72..7c412b6 100644
--- a/src/socket.c
+++ b/src/socket.c
@@ -837,7 +837,7 @@
char *str = talloc_size(ctx, OSMO_SOCK_NAME_MAXLEN);
if (!str)
return NULL;
- osmo_sock_get_name_buf(str, sizeof(str), fd);
+ osmo_sock_get_name_buf(str, OSMO_SOCK_NAME_MAXLEN, fd);
return str;
}
diff --git a/src/utils.c b/src/utils.c
index 896e917..b66721e 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -351,10 +351,11 @@
*/
char *osmo_hexdump_c(const void *ctx, const unsigned char *buf, int len)
{
- char *hexd_buff = talloc_size(ctx, len*3 + 1);
+ size_t hexd_buff_len = len * 3 + 1;
+ char *hexd_buff = talloc_size(ctx, hexd_buff_len);
if (!hexd_buff)
return NULL;
- osmo_hexdump_buf(hexd_buff, sizeof(hexd_buff), buf, len, " ", true);
+ osmo_hexdump_buf(hexd_buff, hexd_buff_len, buf, len, " ", true);
return hexd_buff;
}
@@ -389,10 +390,11 @@
*/
char *osmo_hexdump_nospc_c(const void *ctx, const unsigned char *buf, int len)
{
- char *hexd_buff = talloc_size(ctx, len*2 + 1);
+ size_t hexd_buff_len = len * 2 + 1;
+ char *hexd_buff = talloc_size(ctx, hexd_buff_len);
if (!hexd_buff)
return NULL;
- osmo_hexdump_buf(hexd_buff, sizeof(hexd_buff), buf, len, "", true);
+ osmo_hexdump_buf(hexd_buff, hexd_buff_len, buf, len, "", true);
return hexd_buff;
}
@@ -908,10 +910,11 @@
*/
char *osmo_str_tolower_c(const void *ctx, const char *src)
{
- char *buf = talloc_size(ctx, strlen(src)+1);
+ size_t buf_len = strlen(src) + 1;
+ char *buf = talloc_size(ctx, buf_len);
if (!buf)
return NULL;
- osmo_str_tolower_buf(buf, sizeof(buf), src);
+ osmo_str_tolower_buf(buf, buf_len, src);
return buf;
}
@@ -966,10 +969,11 @@
*/
char *osmo_str_toupper_c(const void *ctx, const char *src)
{
- char *buf = talloc_size(ctx, strlen(src)+1);
+ size_t buf_len = strlen(src) + 1;
+ char *buf = talloc_size(ctx, buf_len);
if (!buf)
return NULL;
- osmo_str_toupper_buf(buf, sizeof(buf), src);
+ osmo_str_toupper_buf(buf, buf_len, src);
return buf;
}
--
To view, visit https://gerrit.osmocom.org/13620
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ffda4dea2b7f9b4b76dfeecad1fab6384c5a62c
Gerrit-Change-Number: 13620
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Change in osmo-bts[master]: common/pcu_sock.c: fix possible memleaks in pcu_sock_read()
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13618 ) Change subject: common/pcu_sock.c: fix possible memleaks in pcu_sock_read() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58352e5f2b5715361c7089d0e134a42975171022 Gerrit-Change-Number: 13618 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 14:53:04 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: Ensure BcdMccMnc is encoded as 24.008 10.5.5.15
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/13619
Change subject: Ensure BcdMccMnc is encoded as 24.008 10.5.5.15
..
Ensure BcdMccMnc is encoded as 24.008 10.5.5.15
PCU is using BcdMccMnc as it's encoded as 24.008.
But SGSN code is using it as it would be byte by byte
sorted.
Fixes: OS#3878
Change-Id: Ie8f67f16f18e4c5090bc5a4c46a866a7e7e00206
---
M library/L3_Common.ttcn
M library/Osmocom_Gb_Types.ttcn
M sgsn/SGSN_Tests.ttcn
3 files changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/19/13619/1
diff --git a/library/L3_Common.ttcn b/library/L3_Common.ttcn
index 57db6b3..01f0a34 100644
--- a/library/L3_Common.ttcn
+++ b/library/L3_Common.ttcn
@@ -106,9 +106,9 @@
rai.mccDigit1
& rai.mccDigit2
& rai.mccDigit3
+ & rai.mncDigit3
& rai.mncDigit1
- & rai.mncDigit2
- & rai.mncDigit3;
+ & rai.mncDigit2;
return plmn;
}
diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn
index 95d3028..55a2816 100644
--- a/library/Osmocom_Gb_Types.ttcn
+++ b/library/Osmocom_Gb_Types.ttcn
@@ -868,8 +868,8 @@
ret.mccDigit2 := cid.ra_id.lai.mcc_mnc[1];
ret.mccDigit3 := cid.ra_id.lai.mcc_mnc[2];
ret.mncDigit3 := cid.ra_id.lai.mcc_mnc[3];
- ret.mncDigit2 := cid.ra_id.lai.mcc_mnc[5];
ret.mncDigit1 := cid.ra_id.lai.mcc_mnc[4];
+ ret.mncDigit2 := cid.ra_id.lai.mcc_mnc[5];
}
if (isvalue(cid.ra_id.lai.lac)) {
ret.lac := f_oct_or_wc(cid.ra_id.lai.lac, 2);
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 8b639e6..74cdece 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -137,15 +137,16 @@
};
private function f_cellid_to_RAI(in BssgpCellId cell_id) return
RoutingAreaIdentificationV {
+ /* mcc_mnc is encoded as of 24.008 10.5.5.15 */
var BcdMccMnc mcc_mnc := cell_id.ra_id.lai.mcc_mnc;
var RoutingAreaIdentificationV ret := {
mccDigit1 := mcc_mnc[0],
mccDigit2 := mcc_mnc[1],
mccDigit3 := mcc_mnc[2],
-mncDigit3 := mcc_mnc[5],
-mncDigit1 := mcc_mnc[3],
-mncDigit2 := mcc_mnc[4],
+mncDigit3 := mcc_mnc[3],
+mncDigit1 := mcc_mnc[4],
+mncDigit2 := mcc_mnc[5],
lac := int2oct(cell_id.ra_id.lai.lac, 16),
rac := int2oct(cell_id.ra_id.rac, 8)
}
@@ -225,7 +226,8 @@
}
-function f_init(BcdMccMnc mcc_mnc := '26242F'H) runs on test_CT {
+/* mcc_mnc is 24.008 10.5.5.15 encoded. 262 42 */
+function f_init(BcdMccMnc mcc_mnc := '262F42'H) runs on test_CT {
if (g_initialized == true) {
return;
}
--
To view, visit https://gerrit.osmocom.org/13619
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8f67f16f18e4c5090bc5a4c46a866a7e7e00206
Gerrit-Change-Number: 13619
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Change in osmo-bts[master]: pcu_sock: use %zu conversion specifier for printing sizeof() result
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13267 ) Change subject: pcu_sock: use %zu conversion specifier for printing sizeof() result .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/13267/4/src/common/pcu_sock.c File src/common/pcu_sock.c: https://gerrit.osmocom.org/#/c/13267/4/src/common/pcu_sock.c@794 PS4, Line 794: return 0; > Here too, memleak. […] Oh, right! Please see: https://gerrit.osmocom.org/#/c/osmo-bts/+/13618 -- To view, visit https://gerrit.osmocom.org/13267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5cb656537b1b73b9361a132801ab47ab7f8a709 Gerrit-Change-Number: 13267 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-Comment-Date: Fri, 12 Apr 2019 14:31:16 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bts[master]: common/pcu_sock.c: fix possible memleaks in pcu_sock_read()
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13618
Change subject: common/pcu_sock.c: fix possible memleaks in pcu_sock_read()
..
common/pcu_sock.c: fix possible memleaks in pcu_sock_read()
Change-Id: I58352e5f2b5715361c7089d0e134a42975171022
---
M src/common/pcu_sock.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/18/13618/1
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index d694602..d496a49 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -790,14 +790,17 @@
goto close;
if (rc < 0) {
- if (errno == EAGAIN)
+ if (errno == EAGAIN) {
+ msgb_free(msg);
return 0;
+ }
goto close;
}
if (rc < sizeof(*pcu_prim)) {
LOGP(DPCU, LOGL_ERROR, "Received %d bytes on PCU Socket, but
primitive size "
"is %lu, discarding\n", rc, sizeof(*pcu_prim));
+ msgb_free(msg);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/13618
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58352e5f2b5715361c7089d0e134a42975171022
Gerrit-Change-Number: 13618
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Change in libosmocore[master]: GSUP: add Message Class IE
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/13576 )
Change subject: GSUP: add Message Class IE
..
Patch Set 4: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/13576/4/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:
https://gerrit.osmocom.org/#/c/13576/4/include/osmocom/gsm/gsup.h@71
PS4, Line 71: = 0x0a,
alignment
https://gerrit.osmocom.org/#/c/13576/3/src/gsm/gsup.c
File src/gsm/gsup.c:
https://gerrit.osmocom.org/#/c/13576/3/src/gsm/gsup.c@739
PS3, Line 739: {}
> I always use {}, and have been doing that all over the place.
But in this particular file all 'value_string' arrays are using '{ 0, NULL }'.
Let's please keep the code consistent.
--
To view, visit https://gerrit.osmocom.org/13576
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397a9f2c4a7224e47cab944c72e75ca5592efef
Gerrit-Change-Number: 13576
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Comment-Date: Fri, 12 Apr 2019 14:02:05 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Change in libosmocore[master]: add OSMO_IMSI_BUF_SIZE
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13575 ) Change subject: add OSMO_IMSI_BUF_SIZE .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id11ada4c96b79f7f0ad58185ab7dbf24622fb770 Gerrit-Change-Number: 13575 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Apr 2019 13:45:20 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: Add debian packaging for osmo-gsm-manuals-dev
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13599 ) Change subject: Add debian packaging for osmo-gsm-manuals-dev .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7edb5093e5b58eb3b0f7af2376476db4026db735 Gerrit-Change-Number: 13599 Gerrit-PatchSet: 7 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Apr 2019 13:27:18 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13597 )
Change subject: Makefile.common.inc: add {,un}install targets
..
Patch Set 5: Code-Review+1
Leaving +2 to Harald since he suggested using "foo-doc" directory naming scheme.
--
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 5
Gerrit-Owner: osmith
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: osmith
Gerrit-Comment-Date: Fri, 12 Apr 2019 13:26:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: Add debian packaging for osmo-gsm-manuals-dev
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13599 ) Change subject: Add debian packaging for osmo-gsm-manuals-dev .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/13599/2/debian/copyright File debian/copyright: https://gerrit.osmocom.org/#/c/13599/2/debian/copyright@10 PS2, Line 10: Copyright: 2019 Oliver Smith > Changed to […] We'll then need to change the company name ;) https://gerrit.osmocom.org/#/c/13599/2/debian/copyright@13 PS2, Line 13: License: GPL-3.0+ > That was generated by dh_make, and it fits debian's copyright-format: […] Ah fine, it looked weird specially having the gerrit patch commits in between. -- To view, visit https://gerrit.osmocom.org/13599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7edb5093e5b58eb3b0f7af2376476db4026db735 Gerrit-Change-Number: 13599 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 13:19:48 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in libosmocore[master]: add OSMO_IMSI_BUF_SIZE
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13575 ) Change subject: add OSMO_IMSI_BUF_SIZE .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id11ada4c96b79f7f0ad58185ab7dbf24622fb770 Gerrit-Change-Number: 13575 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Apr 2019 13:16:55 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ggsn[master]: ggsn: Add minimalistic PAP support
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13608 ) Change subject: ggsn: Add minimalistic PAP support .. Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/13608/4/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/13608/4/ggsn/ggsn.c@531 PS4, Line 531: if (pap_in->len < 1) That's wrong, because len includes header according to line 501. Also, you are accessing data[0] and data[1], so you miss one byte len. if (pap_in->len < sizeof(*pap_in) + 2) https://gerrit.osmocom.org/#/c/13608/4/ggsn/ggsn.c@535 PS4, Line 535: if (pap_in->len < 1 + peer_id_len) if (pap_in->len < sizeof(*pap_in) + 2 + peer_id_len) -- To view, visit https://gerrit.osmocom.org/13608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731 Gerrit-Change-Number: 13608 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 13:16:19 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-hlr[master]: use new OSMO_IMSI_BUF_SIZE
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13589 ) Change subject: use new OSMO_IMSI_BUF_SIZE .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e8fa221e97303df3c6cce96b25d31a53f67b939 Gerrit-Change-Number: 13589 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 13:09:01 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/13597
to look at the new patch set (#5).
Change subject: Makefile.common.inc: add {,un}install targets
..
Makefile.common.inc: add {,un}install targets
Allow installing generated pdfs with 'make install' in all Osmocom
projects using osmo-gsm-manuals. This makes proper debian packaging of
the manuals easier.
Autotools will automatically run this file's install target, when
running 'make install' in the top source dir. Do not install anything,
when OSMO_GSM_MANUALS_NO_INSTALL is set, and set this variable for the
tests dir, so we don't install the test pdfs.
Related: OS#3899
Change-Id: I66f33172fa410681acbaef4592e9405627948705
---
M build/Makefile.common.inc
M tests/Makefile.am
2 files changed, 30 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/97/13597/5
--
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 5
Gerrit-Owner: osmith
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith
Gerrit-CC: Pau Espin Pedrol
Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13597 )
Change subject: Makefile.common.inc: add {,un}install targets
..
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc
File build/Makefile.common.inc:
https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc@36
PS1, Line 36: OS
> Done
Update after Harald's review in
https://gerrit.osmocom.org/#/c/osmo-bts/+/13601/ - it uses the repository name
in the install dir now, e.g. /usr/share/doc/osmo-bts-doc/*.pdf
--
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 4
Gerrit-Owner: osmith
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith
Gerrit-CC: Pau Espin Pedrol
Gerrit-Comment-Date: Fri, 12 Apr 2019 12:29:43 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: Add debian packaging for osmo-gsm-manuals-dev
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13599 to look at the new patch set (#5). Change subject: Add debian packaging for osmo-gsm-manuals-dev .. Add debian packaging for osmo-gsm-manuals-dev Allow including pdf manuals in each Osmocom repositories -doc debian package, by depending on osmo-gsm-manuals-dev. Related: OS#3899 Example usage: I4c184c62804c0b805a0a2425a5bd0312e94e49ab (osmo-bts.git) Change-Id: I7edb5093e5b58eb3b0f7af2376476db4026db735 --- M build/Makefile.common.inc A debian/changelog A debian/compat A debian/control A debian/copyright A debian/rules A debian/source/format 7 files changed, 77 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/99/13599/5 -- To view, visit https://gerrit.osmocom.org/13599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7edb5093e5b58eb3b0f7af2376476db4026db735 Gerrit-Change-Number: 13599 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-CC: Pau Espin Pedrol
Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/13597
to look at the new patch set (#3).
Change subject: Makefile.common.inc: add {,un}install targets
..
Makefile.common.inc: add {,un}install targets
Allow installing generated pdfs with 'make install' in all Osmocom
projects using osmo-gsm-manuals. This makes proper debian packaging of
the manuals easier.
Autotools will automatically run this file's install target, when
running 'make install' in the top source dir. Do not install anything,
when OSMO_GSM_MANUALS_NO_INSTALL is set, and set this variable for the
tests dir, so we don't install the test pdfs.
Related: OS#3899
Change-Id: I66f33172fa410681acbaef4592e9405627948705
---
M build/Makefile.common.inc
M tests/Makefile.am
2 files changed, 30 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/97/13597/3
--
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 3
Gerrit-Owner: osmith
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith
Gerrit-CC: Pau Espin Pedrol
Change in libosmocore[master]: GSUP: add Message Class IE
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13576 ) Change subject: GSUP: add Message Class IE .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic397a9f2c4a7224e47cab944c72e75ca5592efef Gerrit-Change-Number: 13576 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Apr 2019 10:33:33 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: add OSMO_IMSI_BUF_SIZE
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13575 ) Change subject: add OSMO_IMSI_BUF_SIZE .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id11ada4c96b79f7f0ad58185ab7dbf24622fb770 Gerrit-Change-Number: 13575 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Apr 2019 10:33:16 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: Add debian packaging for osmo-gsm-manuals-dev
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13599 ) Change subject: Add debian packaging for osmo-gsm-manuals-dev .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7edb5093e5b58eb3b0f7af2376476db4026db735 Gerrit-Change-Number: 13599 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 10:29:30 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: Makefile.am: proper noarch pkgconfig install dir
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13598 ) Change subject: Makefile.am: proper noarch pkgconfig install dir .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63bc8ab6d2845751079f40383d2aa92c709ce2fe Gerrit-Change-Number: 13598 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 10:29:06 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13597 )
Change subject: Makefile.common.inc: add {,un}install targets
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 2
Gerrit-Owner: osmith
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith
Gerrit-CC: Pau Espin Pedrol
Gerrit-Comment-Date: Fri, 12 Apr 2019 10:28:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Change in osmo-ggsn[master]: ggsn: Add minimalistic PAP support
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13608 to look at the new patch set (#4). Change subject: ggsn: Add minimalistic PAP support .. ggsn: Add minimalistic PAP support Some modems are configured to use PAP as an additional authentication mechanism beyond the GSM authentication that's part of GMM. Let's handle such PAP authentication requests by simply acknowledging them all, without actually checking any credentials database. This is the most sane thing we can do for now, without adding external requirements / interfaces like radius servers or the like. Closes: OS#3914 Change-Id: I81875f30f9f1497199253497f84718510747f731 --- M ggsn/ggsn.c 1 file changed, 72 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/08/13608/4 -- To view, visit https://gerrit.osmocom.org/13608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731 Gerrit-Change-Number: 13608 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-ggsn[master]: ggsn: More logging from PCO handling (e.g. in case of malconfiguration)
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13609 )
Change subject: ggsn: More logging from PCO handling (e.g. in case of
malconfiguration)
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/13609/3/ggsn/ggsn.c
File ggsn/ggsn.c:
https://gerrit.osmocom.org/#/c/13609/3/ggsn/ggsn.c@570
PS3, Line 570: if (!peer_v4) {
> Wondering why IPCP is only used in ipv4...
because IPCP is specified strictly for IPv4 only. There is no IP6CP (at least
not for communicating DNS servers), and as a result, the IPv6 DNS adresses had
to be pushed directl into PCO without any IETF format/layer.
--
To view, visit https://gerrit.osmocom.org/13609
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38c2c4178ff4fd795f54638adec63166b1c0838e
Gerrit-Change-Number: 13609
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Comment-Date: Fri, 12 Apr 2019 10:23:57 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-ggsn[master]: ggsn: Add minimalistic PAP support
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13608 ) Change subject: ggsn: Add minimalistic PAP support .. Patch Set 3: (5 comments) https://gerrit.osmocom.org/#/c/13608/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13608/3//COMMIT_MSG@12 PS3, Line 12: all, without actually checking any credentials database. > So the MS is expected to send inside PAP the values you configure your APN > with? (the User+Password […] yes, if you add username/password, the MS/UE should send those values in PAP. https://gerrit.osmocom.org/#/c/13608/3/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/13608/3/ggsn/ggsn.c@518 PS3, Line 518: unsigned int pap_welcome_len = strlen(pap_welcome); > "ARRAY_SIZE(pap_welcome) -1" would make sense too :) I think gcc is smart enough to do the strlen at compile-time these days. It's much more readable, for sure. https://gerrit.osmocom.org/#/c/13608/3/ggsn/ggsn.c@519 PS3, Line 519: uint8_t pap_out_size = sizeof(struct pap_element) + 1 + pap_welcome_len; > Is that +1 for the NULL chat of pap_welcome? please add comment (and add +1 > to the end). the one bytes is for the *length* byte. There is no requirement for NUL termination https://gerrit.osmocom.org/#/c/13608/3/ggsn/ggsn.c@520 PS3, Line 520: struct pap_element *pap_out = alloca(pap_out_size); > nice, didn't know about alloca() you can also use runtime-computed size for arrays these days. So something like having the length passed in as a function argument and then putting "char foo[len_arg];" on the stack works. However, in this case we don't want to allocate an array but 'struct pcap_element' with some extra bytes at the end, and hence I went for alloca. https://gerrit.osmocom.org/#/c/13608/3/ggsn/ggsn.c@526 PS3, Line 526: if (htons(pap_in->len) > pco_in->length) > is htons() fine alignment-access wise? […] ACK, will update. -- To view, visit https://gerrit.osmocom.org/13608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731 Gerrit-Change-Number: 13608 Gerrit-PatchSet: 3 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 10:21:45 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13597 )
Change subject: Makefile.common.inc: add {,un}install targets
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc
File build/Makefile.common.inc:
https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc@34
PS1, Line 34: if [ "$(OSMO_GSM_MANUALS_NO_INSTALL)" != "1" ]; then \
> According to configure. […]
Good point. But we don't include the Makefile.common.inc unless
--enable-manuals is set, so it won't try run the install target from here (or
try to build its dependencies, $(PDF_FILES)). I've added a comment to clarify,
as you have suggested.
https://git.osmocom.org/osmo-bsc/tree/doc/manuals/Makefile.am
if BUILD_MANUALS
...
include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc
endif
https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc@36
PS1, Line 36: Dm6
> Probably better using /share/doc/osmo-gsm-manuals/. […]
Done
--
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith
Gerrit-CC: Pau Espin Pedrol
Gerrit-Comment-Date: Fri, 12 Apr 2019 08:58:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: Add debian packaging for osmo-gsm-manuals-dev
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13599 ) Change subject: Add debian packaging for osmo-gsm-manuals-dev .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/13599/2/debian/copyright File debian/copyright: https://gerrit.osmocom.org/#/c/13599/2/debian/copyright@10 PS2, Line 10: Copyright: 2019 Oliver Smith Changed to > 2019 sysmocom s.f.m.c. GmbH (I just realized, we have the s.m.f.c. (f and m switched) typo quite a few times across the source trees...) https://gerrit.osmocom.org/#/c/13599/2/debian/copyright@13 PS2, Line 13: License: GPL-3.0+ > Repeated line (l11)? That was generated by dh_make, and it fits debian's copyright-format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph -- To view, visit https://gerrit.osmocom.org/13599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7edb5093e5b58eb3b0f7af2376476db4026db735 Gerrit-Change-Number: 13599 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 12 Apr 2019 08:58:16 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/13597
to look at the new patch set (#2).
Change subject: Makefile.common.inc: add {,un}install targets
..
Makefile.common.inc: add {,un}install targets
Allow installing generated pdfs with 'make install' in all Osmocom
projects using osmo-gsm-manuals. This makes proper debian packaging of
the manuals easier.
Autotools will automatically run this file's install target, when
running 'make install' in the top source dir. Do not install anything,
when OSMO_GSM_MANUALS_NO_INSTALL is set, and set this variable for the
tests dir, so we don't install the test pdfs.
Related: OS#3899
Change-Id: I66f33172fa410681acbaef4592e9405627948705
---
M build/Makefile.common.inc
M tests/Makefile.am
2 files changed, 27 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/97/13597/2
--
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 2
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol
Change in osmo-gsm-manuals[master]: Add debian packaging for osmo-gsm-manuals-dev
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13599 to look at the new patch set (#3). Change subject: Add debian packaging for osmo-gsm-manuals-dev .. Add debian packaging for osmo-gsm-manuals-dev Allow including pdf manuals in each Osmocom repositories -doc debian package, by depending on osmo-gsm-manuals-dev. Related: OS#3899 Example usage: I4c184c62804c0b805a0a2425a5bd0312e94e49ab (osmo-bts.git) Change-Id: I7edb5093e5b58eb3b0f7af2376476db4026db735 --- A debian/changelog A debian/compat A debian/control A debian/copyright A debian/rules A debian/source/format 6 files changed, 76 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/99/13599/3 -- To view, visit https://gerrit.osmocom.org/13599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7edb5093e5b58eb3b0f7af2376476db4026db735 Gerrit-Change-Number: 13599 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol
Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13006 ) Change subject: hlr.c: forward GSUP messages between clients .. Patch Set 12: > My apologies, but I'm infinitely way past my time, can I burden you with > resurrecting the parts I destroyed, while keeping the parts I might have > fixed? thanks! No problem, rebased on master and pushed patchset 10 again as patchset 12. It looks like your patchset 11 was the same as your patchset 7, except that it was rebased. (Patchset 10 was based on patchset 7 already, so all your fixes should be there.) -- To view, visit https://gerrit.osmocom.org/13006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5 Gerrit-Change-Number: 13006 Gerrit-PatchSet: 12 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: osmith Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Apr 2019 08:16:30 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/13006
to look at the new patch set (#12).
Change subject: hlr.c: forward GSUP messages between clients
..
hlr.c: forward GSUP messages between clients
Allow clients to forward any GSUP message between clients. Determine the
sender and receiver from the new {source,dest}_name{,_len} IEs. Reject
messages with a forged source name.
This will be used for the inter-MSC handover.
Depends: Ic00b0601eacff6d72927cea51767801142ee75db (libosmocore.git)
Related: OS#3793
Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5
---
M src/hlr.c
1 file changed, 78 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/06/13006/12
--
To view, visit https://gerrit.osmocom.org/13006
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5
Gerrit-Change-Number: 13006
Gerrit-PatchSet: 12
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: osmith
Gerrit-CC: Vadim Yanitskiy
Change in osmo-gsm-manuals[master]: check-depends.sh: don't depend on git binary
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13596 ) Change subject: check-depends.sh: don't depend on git binary .. check-depends.sh: don't depend on git binary Remove git from depends, because it isn't needed when building the manuals from a source tarball. Avoid having git in the build dependencies of the upcoming manuals packaging for debian. Related: OS#3899 Change-Id: I46ad818a1d009c03357821f7c8100ecb5d62962e --- M check-depends.sh 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Pau Espin Pedrol: Looks good to me, approved diff --git a/check-depends.sh b/check-depends.sh index 7845719..ec3f26f 100755 --- a/check-depends.sh +++ b/check-depends.sh @@ -18,7 +18,6 @@ check_dep_bin mscgen mscgen check_dep_bin xsltproc libxslt -check_dep_bin git git check_dep_bin a2x asciidoc check_dep_bin asciidoc asciidoc check_dep_bin dblatex dblatex -- To view, visit https://gerrit.osmocom.org/13596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I46ad818a1d009c03357821f7c8100ecb5d62962e Gerrit-Change-Number: 13596 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith
Change in osmo-gsm-manuals[master]: build/unix-time-to-fmt.py: use default python ver
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13595 ) Change subject: build/unix-time-to-fmt.py: use default python ver .. build/unix-time-to-fmt.py: use default python ver Don't explicitly depend on python 3, so we don't need to have python 2 *and* python 3 installed to build osmo-gsm-manuals. The script is short and works fine with either python version. Related: OS#3899 Change-Id: I8af9b8159f5c7e39b905f85edd1584cb4d5a33ef --- M build/unix-time-to-fmt.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Pau Espin Pedrol: Looks good to me, approved diff --git a/build/unix-time-to-fmt.py b/build/unix-time-to-fmt.py index 026e55c..72ece26 100755 --- a/build/unix-time-to-fmt.py +++ b/build/unix-time-to-fmt.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/env python """ Usage: -- To view, visit https://gerrit.osmocom.org/13595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8af9b8159f5c7e39b905f85edd1584cb4d5a33ef Gerrit-Change-Number: 13595 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith
