Build failure of network:osmocom:nightly/libosmo-netif in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Raspbian_10/armv7l Package network:osmocom:nightly/libosmo-netif failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 413s] extracted packet: RTP ver=2 ssrc=117440512 type=98 marker=0 ext=0 csrc_count=0 sequence=9640 timestamp=1681769897 [20 14 ff d4 f9 ff fb e7 eb f9 9f f8 f2 26 33 65 54 ] [ 413s] extracted packet: RTP ver=2 ssrc=117440512 type=98 marker=0 ext=0 csrc_count=0 sequence=9641 timestamp=1681770057 [20 14 ff d4 f9 ff fb e7 eb f9 9f f8 f2 26 33 65 54 ] [ 413s] extracted packet: RTP ver=2 ssrc=117440512 type=98 marker=0 ext=0 csrc_count=0 sequence=9642 timestamp=1681770217 [20 14 ff d4 f9 ff fb e7 eb f9 9f f8 f2 26 33 65 54 ] [ 413s] extracted packet: RTP ver=2 ssrc=117440512 type=98 marker=0 ext=0 csrc_count=0 sequence=9643 timestamp=1681770377 [20 14 ff d4 f9 ff fb e7 eb f9 9f f8 f2 26 33 65 54 ] [ 413s] extracted packet: RTP ver=2 ssrc=117440512 type=98 marker=0 ext=0 csrc_count=0 sequence=9644 timestamp=1681770537 [20 14 ff d4 f9 ff fb e7 eb f9 9f f8 f2 26 33 65 54 ] [ 413s] extracted packet: RTP ver=2 ssrc=117440512 type=98 marker=0 ext=0 csrc_count=0 sequence=9645 timestamp=1681770697 [20 14 ff d4 f9 ff fb e7 eb f9 9f f8 f2 26 33 65 54 ] [ 413s] extracted packet: RTP ver=2 ssrc=117440512 type=98 marker=0 ext=0 csrc_count=0 sequence=9646 timestamp=1681770857 [20 14 ff d4 f9 ff fb e7 eb f9 9f f8 f2 26 33 65 54 ] [ 413s] extracted packet: RTP ver=2 ssrc=117440512 type=98 marker=0 ext=0 csrc_count=0 sequence=9647 timestamp=1681771017 [20 14 ff d4 f9 ff fb e7 eb f9 9f f8 f2 26 33 65 54 ] [ 413s] --- expout 2019-10-04 02:02:29.68000 + [ 413s] +++ /usr/src/packages/BUILD/tests/testsuite.dir/at-groups/2/stdout 2019-10-04 02:02:39.82000 + [ 413s] @@ -1 +1 @@ [ 413s] -OK: Test passed [ 413s] +FAIL: test did not run successfully [ 413s] ./testsuite.at:14: exit code was 1, expected 0 [ 413s] 2. testsuite.at:11: 2. osmux_test (testsuite.at:11): FAILED (testsuite.at:14) [ 413s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 413s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 413s] make: *** [debian/rules:13: build] Error 2 [ 413s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 413s] [ 413s] obs-arm-6 failed "build libosmo-netif_0.6.0.4.8c7d.dsc" at Fri Oct 4 02:02:50 UTC 2019. [ 413s] [ 413s] ### VM INTERACTION START ### [ 416s] [ 387.232503] sysrq: SysRq : Power Off [ 416s] [ 387.290389] reboot: Power down [ 417s] ### VM INTERACTION END ### [ 417s] [ 417s] obs-arm-6 failed "build libosmo-netif_0.6.0.4.8c7d.dsc" at Fri Oct 4 02:02:54 UTC 2019. [ 417s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 327s] ar: `u' modifier ignored since `D' is the default (see `U') [ 327s] libtool: link: ranlib .libs/libtransceiver_common.a [ 327s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 327s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 328s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 328s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 328s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 328s] collect2: error: ld returned 1 exit status [ 328s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 328s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 328s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 328s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 328s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 328s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 328s] make[1]: *** [Makefile:444: all] Error 2 [ 328s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 328s] dh_auto_build: make -j1 returned exit code 2 [ 328s] make: *** [debian/rules:6: build] Error 255 [ 328s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 328s] [ 328s] sheep82 failed "build osmo-trx_1.1.1.29.e503.dsc" at Fri Oct 4 01:47:31 UTC 2019. [ 328s] [ 328s] ### VM INTERACTION START ### [ 331s] [ 317.782541] sysrq: SysRq : Power Off [ 331s] [ 317.792640] reboot: Power down [ 331s] ### VM INTERACTION END ### [ 331s] [ 331s] sheep82 failed "build osmo-trx_1.1.1.29.e503.dsc" at Fri Oct 4 01:47:35 UTC 2019. [ 331s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 419s] ar: `u' modifier ignored since `D' is the default (see `U') [ 419s] libtool: link: ranlib .libs/libtransceiver_common.a [ 419s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 419s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 420s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 420s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 420s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 420s] collect2: error: ld returned 1 exit status [ 420s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 420s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 420s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 420s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 420s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 420s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 420s] make[1]: *** [Makefile:444: all] Error 2 [ 420s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 420s] dh_auto_build: make -j1 returned exit code 2 [ 420s] make: *** [debian/rules:6: build] Error 255 [ 420s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 420s] [ 420s] lamb55 failed "build osmo-trx_1.1.1.29.e503.dsc" at Fri Oct 4 01:47:14 UTC 2019. [ 420s] [ 420s] ### VM INTERACTION START ### [ 423s] [ 404.336557] sysrq: SysRq : Power Off [ 423s] [ 404.341739] reboot: Power down [ 423s] ### VM INTERACTION END ### [ 423s] [ 423s] lamb55 failed "build osmo-trx_1.1.1.29.e503.dsc" at Fri Oct 4 01:47:18 UTC 2019. [ 423s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-iuh[master]: iu_client: pass return value of osmo_sccp_user_sap_down() towards the...
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15665 Change subject: iu_client: pass return value of osmo_sccp_user_sap_down() towards the caller .. iu_client: pass return value of osmo_sccp_user_sap_down() towards the caller osmo_sccp_user_sap_down return 0 on success, negative values on failure Change-Id: I3b7c2296eb8b26f0881cee643b834336daab86ea --- M src/iu_client.c 1 file changed, 3 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/65/15665/1 diff --git a/src/iu_client.c b/src/iu_client.c index c309ce4..f4a9cd3 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -306,9 +306,7 @@ osmo_prim_init(>oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_DATA, PRIM_OP_REQUEST, msg); - osmo_sccp_user_sap_down(g_scu, >oph); - - return 0; + return osmo_sccp_user_sap_down(g_scu, >oph); } int ranap_iu_tx_common_id(struct ranap_ue_conn_ctx *uectx, const char *imsi) @@ -326,8 +324,7 @@ osmo_prim_init(>oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_DATA, PRIM_OP_REQUEST, msg); - osmo_sccp_user_sap_down(g_scu, >oph); - return 0; + return osmo_sccp_user_sap_down(g_scu, >oph); } static int iu_grnc_id_parse(struct iu_grnc_id *dst, struct RANAP_GlobalRNC_ID *src) @@ -467,8 +464,7 @@ osmo_prim_init(>oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_DATA, PRIM_OP_REQUEST, msg); - osmo_sccp_user_sap_down(g_scu, >oph); - return 0; + return osmo_sccp_user_sap_down(g_scu, >oph); } /* Send Iu Release for the given UE connection. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3b7c2296eb8b26f0881cee643b834336daab86ea Gerrit-Change-Number: 15665 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange
Change in ...osmo-iuh[master]: iu_client: ranap_iu_tx_release() change default cause code to Success
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-iuh/+/15666
Change subject: iu_client: ranap_iu_tx_release() change default cause code to
Success
..
iu_client: ranap_iu_tx_release() change default cause code to Success
The cause code no remaining rab should only used, when closing the Iu connection
on this specific reason. Change default to NAS Sucess Release which is a
usual release.
Change-Id: Icf3f06b0de7dcda9f967ae29863054ef813c75e5
---
M src/iu_client.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/66/15666/1
diff --git a/src/iu_client.c b/src/iu_client.c
index f4a9cd3..4b0acb0 100644
--- a/src/iu_client.c
+++ b/src/iu_client.c
@@ -468,15 +468,15 @@
}
/* Send Iu Release for the given UE connection.
- * If cause is NULL, the standard "No remaining RAB" cause is sent, otherwise
+ * If cause is NULL, Normal Release cause is sent, otherwise
* the provided cause. */
int ranap_iu_tx_release(struct ranap_ue_conn_ctx *ctx, const struct
RANAP_Cause *cause)
{
struct msgb *msg;
struct osmo_scu_prim *prim;
static const struct RANAP_Cause default_cause = {
- .present = RANAP_Cause_PR_radioNetwork,
- .choice.radioNetwork = RANAP_CauseRadioNetwork_no_remaining_rab,
+ .present = RANAP_Cause_PR_nAS,
+ .choice.radioNetwork = RANAP_CauseNAS_normal_release,
};
if (!cause)
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15666
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Icf3f06b0de7dcda9f967ae29863054ef813c75e5
Gerrit-Change-Number: 15666
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in ...osmo-sgsn[master]: gprs_ranap: release Iu UE Context when exiting PMM Connected
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15482 ) Change subject: gprs_ranap: release Iu UE Context when exiting PMM Connected .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/15482/6/src/sgsn/gprs_ranap.c File src/sgsn/gprs_ranap.c: https://gerrit.osmocom.org/#/c/15482/6/src/sgsn/gprs_ranap.c@138 PS6, Line 138: if (mm->iu.mm_state_fsm->state == ST_PMM_CONNECTED) > (could mm_state_fsm ever be NULL for some mm in a weird state?) no. otherwise it would follow the path in line 123 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie05d2bdf8dfb593b4c7e837107a3a06f22e90119 Gerrit-Change-Number: 15482 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 20:27:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Avoid compiling unneeded files when building without Iu
lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 ) Change subject: Avoid compiling unneeded files when building without Iu .. Avoid compiling unneeded files when building without Iu Remove gprs_ranap.c and gprs_mm_state_iu_fsm.c from the Makefile when building without IU. Change-Id: I2386f8e86bbf0b87eedce9f57eb86b1b64998a69 --- M src/sgsn/Makefile.am M src/sgsn/gprs_ranap.c M tests/sgsn/Makefile.am 3 files changed, 7 insertions(+), 8 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sgsn/Makefile.am b/src/sgsn/Makefile.am index 8bc1abb..6a7392b 100644 --- a/src/sgsn/Makefile.am +++ b/src/sgsn/Makefile.am @@ -45,8 +45,6 @@ gprs_gmm.c \ gprs_gmm_fsm.c \ gprs_mm_state_gb_fsm.c \ - gprs_mm_state_iu_fsm.c \ - gprs_ranap.c \ gprs_sgsn.c \ gprs_sm.c \ gprs_sndcp.c \ @@ -87,4 +85,9 @@ $(LIBOSMORANAP_LIBS) \ $(LIBASN1C_LIBS) \ $(NULL) + +osmo_sgsn_SOURCES += \ + gprs_mm_state_iu_fsm.c \ + gprs_ranap.c + endif diff --git a/src/sgsn/gprs_ranap.c b/src/sgsn/gprs_ranap.c index b0d0f8d..d2b3455 100644 --- a/src/sgsn/gprs_ranap.c +++ b/src/sgsn/gprs_ranap.c @@ -22,9 +22,6 @@ */ #include "bscconfig.h" - -#ifdef BUILD_IU - #include #include @@ -220,4 +217,3 @@ return rc; } -#endif diff --git a/tests/sgsn/Makefile.am b/tests/sgsn/Makefile.am index bdcd9b4..b72c446 100644 --- a/tests/sgsn/Makefile.am +++ b/tests/sgsn/Makefile.am @@ -44,13 +44,11 @@ sgsn_test_LDADD = \ $(top_builddir)/src/sgsn/gprs_llc.o \ $(top_builddir)/src/sgsn/gprs_gb.o \ - $(top_builddir)/src/sgsn/gprs_ranap.o \ $(top_builddir)/src/sgsn/gprs_sndcp.o \ $(top_builddir)/src/sgsn/gprs_gmm_attach.o \ $(top_builddir)/src/sgsn/gprs_gmm.o \ $(top_builddir)/src/sgsn/gprs_gmm_fsm.o \ $(top_builddir)/src/sgsn/gprs_mm_state_gb_fsm.o \ - $(top_builddir)/src/sgsn/gprs_mm_state_iu_fsm.o \ $(top_builddir)/src/sgsn/gprs_sgsn.o \ $(top_builddir)/src/sgsn/sgsn_vty.o \ $(top_builddir)/src/sgsn/sgsn_libgtp.o \ @@ -82,6 +80,8 @@ if BUILD_IU sgsn_test_LDADD += \ + $(top_builddir)/src/sgsn/gprs_ranap.o \ + $(top_builddir)/src/sgsn/gprs_mm_state_iu_fsm.o \ $(LIBOSMORANAP_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(LIBASN1C_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2386f8e86bbf0b87eedce9f57eb86b1b64998a69 Gerrit-Change-Number: 15618 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce some function helpers
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664 ) Change subject: pcu: Introduce some function helpers .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15664/1/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/#/c/15664/1/pcu/PCU_Tests_RAW.ttcn@570 PS1, Line 570: f_pad_oct(data, 23, '00'O); /* CS-1 */ > We may want different coding schemes in the future, so the amount of padding > may vary. […] I think it's better to add them whenever we need them in the commit requiring the param. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8608fac4375153d5020df5d05026513a7fe931d6 Gerrit-Change-Number: 15664 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 19:35:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Avoid compiling unneeded files when building without Iu
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 ) Change subject: Avoid compiling unneeded files when building without Iu .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2386f8e86bbf0b87eedce9f57eb86b1b64998a69 Gerrit-Change-Number: 15618 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 19:27:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce some function helpers
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664 ) Change subject: pcu: Introduce some function helpers .. Patch Set 1: Code-Review+1 (1 comment) Cool! I was also thinking about introducing some kind of abstraction functions. https://gerrit.osmocom.org/#/c/15664/1/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/#/c/15664/1/pcu/PCU_Tests_RAW.ttcn@570 PS1, Line 570: f_pad_oct(data, 23, '00'O); /* CS-1 */ We may want different coding schemes in the future, so the amount of padding may vary. I recommend to add another parameter of type ChCodingCommand, which will define the amount of padding. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8608fac4375153d5020df5d05026513a7fe931d6 Gerrit-Change-Number: 15664 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 19:22:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: pcu: Introduce some function helpers
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664
Change subject: pcu: Introduce some function helpers
..
pcu: Introduce some function helpers
Change-Id: I8608fac4375153d5020df5d05026513a7fe931d6
---
M pcu/PCU_Tests_RAW.ttcn
1 file changed, 44 insertions(+), 18 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/64/15664/1
diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index 6b45af2..90404d8 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -552,6 +552,48 @@
return false;
}
+/* Enqueue DATA.ind (both TDMA frame and block numbers to be patched) */
+private function f_tx_pcuif_data_ind(octetstring data, int16_t lqual_cb := 0)
+runs on RAW_PCU_Test_CT {
+
+ BTS.send(ts_PCUIF_DATA_IND(bts_nr := 0, trx_nr := 0, ts_nr := 7,
block_nr := 0,
+ sapi := PCU_IF_SAPI_PDTCH, data := data,
+ fn := 0, arfcn := 871, lqual_cb :=
lqual_cb));
+ BTS.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_SENT));
+}
+
+private function f_tx_pcuif_rlcmac_ul_block(template (value) RlcmacUlBlock
ul_data, int16_t lqual_cb := 0)
+runs on RAW_PCU_Test_CT {
+ var octetstring data;
+ /* Encode the payload of DATA.ind */
+ data := enc_RlcmacUlBlock(valueof(ul_data));
+ data := f_pad_oct(data, 23, '00'O); /* CS-1 */
+
+ /* Enqueue DATA.ind (both TDMA frame and block numbers to be patched) */
+ f_tx_pcuif_data_ind(data, lqual_cb);
+}
+
+/* Enqueue RTS.req, expect DATA.req with UL ACK from the PCU */
+private function f_rx_pcuif_rlcmac_dl_block(out RlcmacDlBlock dl_block)
+runs on RAW_PCU_Test_CT {
+ var PCUIF_Message pcu_msg;
+ BTS.send(ts_PCUIF_RTS_REQ(bts_nr := 0, trx_nr := 0, ts_nr := 7,
+ sapi := PCU_IF_SAPI_PDTCH, fn := 0,
+ arfcn := 871, block_nr := 0));
+ BTS.receive(tr_PCUIF_DATA_REQ(bts_nr := 0, trx_nr := 0, ts_nr := 7,
+ sapi := PCU_IF_SAPI_PDTCH)) -> value
pcu_msg;
+ dl_block := dec_RlcmacDlBlock(pcu_msg.u.data_req.data);
+}
+
+private function f_rx_pcuif_rlcmac_dl_block_exp_ack_nack(out RlcmacDlBlock
dl_block)
+runs on RAW_PCU_Test_CT {
+ f_rx_pcuif_rlcmac_dl_block(dl_block);
+ if (not match(dl_block, tr_RLCMAC_ACK_NACK(ul_tfi := ?, tlli := ?))) {
+ setverdict(fail, "Failed to match Packet Uplink ACK / NACK");
+ mtc.stop;
+ }
+}
+
testcase TC_pcuif_suspend() runs on RAW_PCU_Test_CT {
var octetstring ra_id :=
enc_RoutingAreaIdentification(mp_gb_cfg.cell_id.ra_id);
var GprsTlli tlli := ''O;
@@ -661,31 +703,15 @@
ul_data.data.mac_hdr.countdown := (15 - i);
ul_data.data.blocks := {
valueof(t_RLCMAC_LLCBLOCK(f_rnd_octstring(10))) };
- /* Encode the payload of DATA.ind */
- data := enc_RlcmacUlBlock(valueof(ul_data));
- data := f_pad_oct(data, 23, '00'O); /* CS-1 */
-
/* Link quality in dB and our CS1-4 expectations */
var integer lqual := i * 2;
/* Enqueue DATA.ind (both TDMA frame and block numbers to be
patched) */
log("Sending DATA.ind with link quality (dB): ", lqual);
- BTS.send(ts_PCUIF_DATA_IND(bts_nr := 0, trx_nr := 0, ts_nr :=
7, block_nr := 0,
- sapi := PCU_IF_SAPI_PDTCH, data :=
data,
- fn := 0, arfcn := 871, lqual_cb :=
lqual * 10));
- BTS.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_SENT));
+ f_tx_pcuif_rlcmac_ul_block(ul_data, lqual * 10);
/* Enqueue RTS.req, expect DATA.req with UL ACK from the PCU */
- BTS.send(ts_PCUIF_RTS_REQ(bts_nr := 0, trx_nr := 0, ts_nr := 7,
- sapi := PCU_IF_SAPI_PDTCH, fn := 0,
- arfcn := 871, block_nr := 0));
- BTS.receive(tr_PCUIF_DATA_REQ(bts_nr := 0, trx_nr := 0, ts_nr
:= 7,
- sapi := PCU_IF_SAPI_PDTCH)) ->
value pcu_msg;
- dl_block := dec_RlcmacDlBlock(pcu_msg.u.data_req.data);
- if (not match(dl_block, tr_RLCMAC_ACK_NACK(ul_tfi := ?, tlli :=
?))) {
- setverdict(fail, "Failed to match Packet Uplink ACK /
NACK");
- mtc.stop;
- }
+ f_rx_pcuif_rlcmac_dl_block_exp_ack_nack(dl_block);
log("Rx Packet Uplink ACK / NACK with Channel Coding Command: ",
dl_block.ctrl.payload.u.ul_ack_nack.gprs.ch_coding_cmd);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15664
To unsubscribe, or for help writing mail filters, visit
Change in ...osmo-sgsn[master]: Avoid compiling unneeded files when building without Iu
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 ) Change subject: Avoid compiling unneeded files when building without Iu .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2386f8e86bbf0b87eedce9f57eb86b1b64998a69 Gerrit-Change-Number: 15618 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 18:54:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Avoid compiling unneeded files when building without Iu
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 to look at the new patch set (#3). Change subject: Avoid compiling unneeded files when building without Iu .. Avoid compiling unneeded files when building without Iu Remove gprs_ranap.c and gprs_mm_state_iu_fsm.c from the Makefile when building without IU. Change-Id: I2386f8e86bbf0b87eedce9f57eb86b1b64998a69 --- M src/sgsn/Makefile.am M src/sgsn/gprs_ranap.c M tests/sgsn/Makefile.am 3 files changed, 7 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/18/15618/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2386f8e86bbf0b87eedce9f57eb86b1b64998a69 Gerrit-Change-Number: 15618 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-bsc[master]: gsm_08_08.c: Mark func bsc_find_msc() static
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/15663
Change subject: gsm_08_08.c: Mark func bsc_find_msc() static
..
gsm_08_08.c: Mark func bsc_find_msc() static
Its currently only used by bsc_compl_l3() in same file.
Change-Id: I7273a9452dbc4c1285cfa69269fa36ab09551d89
---
M include/osmocom/bsc/osmo_bsc.h
M src/osmo-bsc/gsm_08_08.c
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/15663/1
diff --git a/include/osmocom/bsc/osmo_bsc.h b/include/osmocom/bsc/osmo_bsc.h
index bebfb2f..163e494 100644
--- a/include/osmocom/bsc/osmo_bsc.h
+++ b/include/osmocom/bsc/osmo_bsc.h
@@ -28,7 +28,6 @@
struct bsc_msc_data *msc, int send_ping);
int bsc_delete_connection(struct gsm_subscriber_connection *sccp);
-struct bsc_msc_data *bsc_find_msc(struct gsm_subscriber_connection *conn,
struct msgb *);
int bsc_scan_bts_msg(struct gsm_subscriber_connection *conn, struct msgb *msg);
int bsc_scan_msc_msg(struct gsm_subscriber_connection *conn, struct msgb *msg);
int bsc_send_welcome_ussd(struct gsm_subscriber_connection *conn);
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 4b0752f..ad67c3f 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -269,7 +269,7 @@
return subscr;
}
-struct bsc_msc_data *bsc_find_msc(struct gsm_subscriber_connection *conn,
+static struct bsc_msc_data *bsc_find_msc(struct gsm_subscriber_connection
*conn,
struct msgb *msg)
{
struct gsm48_hdr *gh;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15663
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7273a9452dbc4c1285cfa69269fa36ab09551d89
Gerrit-Change-Number: 15663
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in ...docker-playground[master]: ttcn-*: Fix gsmtap log not enabled
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15662 ) Change subject: ttcn-*: Fix gsmtap log not enabled .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf8062c0d962f2572a07623e6f06936df0d42c67 Gerrit-Change-Number: 15662 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 12:18:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...docker-playground[master]: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-h...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15652 ) Change subject: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-hacks .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iccda25bc274ee93705c23dfd3e0f9dad5fc2a059 Gerrit-Change-Number: 15652 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 12:18:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...docker-playground[master]: ttcn3-pcu: Enable GSMTAP
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15635 ) Change subject: ttcn3-pcu: Enable GSMTAP .. Patch Set 1: Verified+1 Fixed with followup commits. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I24782f5403266d29aea46ef1d94a431077b194b3 Gerrit-Change-Number: 15635 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 12:17:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...docker-playground[master]: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-h...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15652 ) Change subject: debian-stretch-titan: Install netcat-openbsd required by osmo-ttcn3-hacks .. Patch Set 1: See https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15651 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iccda25bc274ee93705c23dfd3e0f9dad5fc2a059 Gerrit-Change-Number: 15652 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 12:18:07 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...docker-playground[master]: ttcn3-pcu: Enable logging color in osmo-pcu.log
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/15634 ) Change subject: ttcn3-pcu: Enable logging color in osmo-pcu.log .. ttcn3-pcu: Enable logging color in osmo-pcu.log Change-Id: I209b03e493bb6b047a46eadd80712259f1d1474d --- M ttcn3-pcu-test/osmo-pcu.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Verified diff --git a/ttcn3-pcu-test/osmo-pcu.cfg b/ttcn3-pcu-test/osmo-pcu.cfg index ed31269..cf13ed8 100644 --- a/ttcn3-pcu-test/osmo-pcu.cfg +++ b/ttcn3-pcu-test/osmo-pcu.cfg @@ -3,7 +3,7 @@ log file /data/osmo-pcu.log logging filter all 1 - logging color 0 + logging color 1 logging print level 1 logging print category 1 logging print category-hex 0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I209b03e493bb6b047a46eadd80712259f1d1474d Gerrit-Change-Number: 15634 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...docker-playground[master]: ttcn3-pcu: Enable logging color in osmo-pcu.log
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15634 ) Change subject: ttcn3-pcu: Enable logging color in osmo-pcu.log .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I209b03e493bb6b047a46eadd80712259f1d1474d Gerrit-Change-Number: 15634 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 12:01:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...docker-playground[master]: ttcn-*: Fix gsmtap log not enabled
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/15662 Change subject: ttcn-*: Fix gsmtap log not enabled .. ttcn-*: Fix gsmtap log not enabled gsmtap log won't be sending any message unless it is allowed by "logging filter all 1". Change-Id: Ibf8062c0d962f2572a07623e6f06936df0d42c67 --- M ttcn3-bsc-test/osmo-bsc.cfg M ttcn3-bsc-test/osmo-stp.cfg M ttcn3-bsc-test/sccplite/osmo-bsc.cfg M ttcn3-bscnat-test/osmo-bsc-nat.cfg M ttcn3-bts-test/oml/osmo-bts.cfg M ttcn3-bts-test/osmo-bsc.cfg M ttcn3-bts-test/osmo-bts.cfg M ttcn3-bts-test/virtphy/osmo-bts.cfg M ttcn3-ggsn-test/osmo-ggsn.cfg M ttcn3-hlr-test/osmo-hlr.cfg M ttcn3-mgw-test/osmo-mgw.cfg M ttcn3-msc-test/osmo-msc.cfg M ttcn3-msc-test/osmo-stp.cfg M ttcn3-pcu-test/osmo-pcu.cfg M ttcn3-pcu-test/sns/osmo-pcu.cfg M ttcn3-sgsn-test/osmo-sgsn.cfg M ttcn3-sgsn-test/osmo-stp.cfg M ttcn3-sip-test/osmo-sip-connector.cfg 18 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/62/15662/1 diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg index 5bb1525..2f6ab99 100644 --- a/ttcn3-bsc-test/osmo-bsc.cfg +++ b/ttcn3-bsc-test/osmo-bsc.cfg @@ -5,6 +5,7 @@ ! log gsmtap 172.18.2.203 logging level set-all debug + logging filter all 1 ! log file /data/osmo-bsc.log logging filter all 1 diff --git a/ttcn3-bsc-test/osmo-stp.cfg b/ttcn3-bsc-test/osmo-stp.cfg index f58fe64..084f3ed 100644 --- a/ttcn3-bsc-test/osmo-stp.cfg +++ b/ttcn3-bsc-test/osmo-stp.cfg @@ -4,6 +4,7 @@ ! log gsmtap 172.18.2.203 logging level set-all debug + logging filter all 1 ! log file /data/osmo-stp.log logging filter all 1 diff --git a/ttcn3-bsc-test/sccplite/osmo-bsc.cfg b/ttcn3-bsc-test/sccplite/osmo-bsc.cfg index 1cbd0c8..0ef5135 100644 --- a/ttcn3-bsc-test/sccplite/osmo-bsc.cfg +++ b/ttcn3-bsc-test/sccplite/osmo-bsc.cfg @@ -5,6 +5,7 @@ ! log gsmtap 172.18.12.203 logging level set-all debug + logging filter all 1 ! log file /data/osmo-bsc.log logging filter all 1 diff --git a/ttcn3-bscnat-test/osmo-bsc-nat.cfg b/ttcn3-bscnat-test/osmo-bsc-nat.cfg index 66ecdc9..b873b21 100644 --- a/ttcn3-bscnat-test/osmo-bsc-nat.cfg +++ b/ttcn3-bscnat-test/osmo-bsc-nat.cfg @@ -4,6 +4,7 @@ ! log gsmtap 172.18.15.203 logging level set-all debug + logging filter all 1 ! log file /data/osmo-bsc_nat.log logging filter all 1 diff --git a/ttcn3-bts-test/oml/osmo-bts.cfg b/ttcn3-bts-test/oml/osmo-bts.cfg index 562440b..2ed761a 100644 --- a/ttcn3-bts-test/oml/osmo-bts.cfg +++ b/ttcn3-bts-test/oml/osmo-bts.cfg @@ -4,6 +4,7 @@ ! log gsmtap 172.18.9.10 logging level set-all debug + logging filter all 1 ! log file /data/osmo-bts.log logging filter all 1 diff --git a/ttcn3-bts-test/osmo-bsc.cfg b/ttcn3-bts-test/osmo-bsc.cfg index b2a45bc..8b04f4a 100644 --- a/ttcn3-bts-test/osmo-bsc.cfg +++ b/ttcn3-bts-test/osmo-bsc.cfg @@ -5,6 +5,7 @@ ! log gsmtap 172.18.9.10 logging level set-all debug + logging filter all 1 ! log file /data/osmo-bsc.log logging filter all 1 diff --git a/ttcn3-bts-test/osmo-bts.cfg b/ttcn3-bts-test/osmo-bts.cfg index 11afc0d..b8ad8ee 100644 --- a/ttcn3-bts-test/osmo-bts.cfg +++ b/ttcn3-bts-test/osmo-bts.cfg @@ -4,6 +4,7 @@ ! log gsmtap 172.18.9.10 logging level set-all debug + logging filter all 1 ! log file /data/osmo-bts.log logging filter all 1 diff --git a/ttcn3-bts-test/virtphy/osmo-bts.cfg b/ttcn3-bts-test/virtphy/osmo-bts.cfg index 540dcc3..ce47b6d 100644 --- a/ttcn3-bts-test/virtphy/osmo-bts.cfg +++ b/ttcn3-bts-test/virtphy/osmo-bts.cfg @@ -4,6 +4,7 @@ ! log gsmtap 172.18.9.10 logging level set-all debug + logging filter all 1 ! log file /data/osmo-bts.log logging filter all 1 diff --git a/ttcn3-ggsn-test/osmo-ggsn.cfg b/ttcn3-ggsn-test/osmo-ggsn.cfg index fd1ea95..6644dae 100644 --- a/ttcn3-ggsn-test/osmo-ggsn.cfg +++ b/ttcn3-ggsn-test/osmo-ggsn.cfg @@ -4,6 +4,7 @@ ! log gsmtap 172.18.3.202 logging level set-all debug + logging filter all 1 ! log file /data/osmo-ggsn.log logging filter all 1 diff --git a/ttcn3-hlr-test/osmo-hlr.cfg b/ttcn3-hlr-test/osmo-hlr.cfg index 57c1701..c5dcd89 100644 --- a/ttcn3-hlr-test/osmo-hlr.cfg +++ b/ttcn3-hlr-test/osmo-hlr.cfg @@ -3,6 +3,7 @@ ! log gsmtap 172.18.10.103 logging level set-all debug + logging filter all 1 ! log stderr logging filter all 1 diff --git a/ttcn3-mgw-test/osmo-mgw.cfg b/ttcn3-mgw-test/osmo-mgw.cfg index 86645ba..3c08ee0 100644 --- a/ttcn3-mgw-test/osmo-mgw.cfg +++ b/ttcn3-mgw-test/osmo-mgw.cfg @@ -4,6 +4,7 @@ ! log gsmtap 172.18.4.181 logging level set-all debug + logging filter all 1 ! log stderr logging filter all 1 diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index 98a1a01..48765d2 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -4,6 +4,7 @@ ! log gsmtap 172.18.1.103 logging level set-all
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 686s] ar: `u' modifier ignored since `D' is the default (see `U') [ 686s] libtool: link: ranlib .libs/libtransceiver_common.a [ 686s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 686s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 687s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 687s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 687s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 687s] collect2: error: ld returned 1 exit status [ 687s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 687s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 687s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 687s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 687s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 687s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 687s] make[1]: *** [Makefile:444: all] Error 2 [ 687s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 687s] dh_auto_build: make -j1 returned exit code 2 [ 687s] make: *** [debian/rules:6: build] Error 255 [ 687s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 687s] [ 687s] lamb60 failed "build osmo-trx_1.1.1.29.e503.dsc" at Thu Oct 3 11:43:38 UTC 2019. [ 687s] [ 687s] ### VM INTERACTION START ### [ 690s] [ 641.761698] sysrq: SysRq : Power Off [ 690s] [ 641.774670] reboot: Power down [ 690s] ### VM INTERACTION END ### [ 690s] [ 690s] lamb60 failed "build osmo-trx_1.1.1.29.e503.dsc" at Thu Oct 3 11:43:41 UTC 2019. [ 690s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 573s] ar: `u' modifier ignored since `D' is the default (see `U') [ 574s] libtool: link: ranlib .libs/libtransceiver_common.a [ 574s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 574s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 574s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 574s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 574s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 574s] collect2: error: ld returned 1 exit status [ 574s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 574s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 574s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 574s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 574s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 574s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 574s] make[1]: *** [Makefile:444: all] Error 2 [ 574s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 574s] dh_auto_build: make -j1 returned exit code 2 [ 574s] make: *** [debian/rules:6: build] Error 255 [ 574s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 575s] [ 575s] morla3 failed "build osmo-trx_1.1.1.dsc" at Thu Oct 3 11:41:14 UTC 2019. [ 575s] [ 575s] ### VM INTERACTION START ### [ 578s] [ 553.553567] sysrq: SysRq : Power Off [ 578s] [ 553.584286] reboot: Power down [ 578s] ### VM INTERACTION END ### [ 578s] [ 578s] morla3 failed "build osmo-trx_1.1.1.dsc" at Thu Oct 3 11:41:18 UTC 2019. [ 578s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 445s] ar: `u' modifier ignored since `D' is the default (see `U') [ 445s] libtool: link: ranlib .libs/libtransceiver_common.a [ 445s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 445s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 445s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 446s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 446s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 446s] collect2: error: ld returned 1 exit status [ 446s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 446s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 446s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 446s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 446s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 446s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 446s] make[1]: *** [Makefile:444: all] Error 2 [ 446s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 446s] dh_auto_build: make -j1 returned exit code 2 [ 446s] make: *** [debian/rules:6: build] Error 255 [ 446s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 446s] [ 446s] lamb07 failed "build osmo-trx_1.1.1.29.e503.dsc" at Thu Oct 3 11:39:14 UTC 2019. [ 446s] [ 446s] ### VM INTERACTION START ### [ 449s] [ 431.154521] sysrq: SysRq : Power Off [ 449s] [ 431.160246] reboot: Power down [ 449s] ### VM INTERACTION END ### [ 449s] [ 449s] lamb07 failed "build osmo-trx_1.1.1.29.e503.dsc" at Thu Oct 3 11:39:18 UTC 2019. [ 449s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 422s] ar: `u' modifier ignored since `D' is the default (see `U') [ 422s] libtool: link: ranlib .libs/libtransceiver_common.a [ 422s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 422s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 422s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 423s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 423s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 423s] collect2: error: ld returned 1 exit status [ 423s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 423s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 423s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 423s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 423s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 423s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 423s] make[1]: *** [Makefile:444: all] Error 2 [ 423s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 423s] dh_auto_build: make -j1 returned exit code 2 [ 423s] make: *** [debian/rules:6: build] Error 255 [ 423s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 423s] [ 423s] lamb15 failed "build osmo-trx_1.1.1.dsc" at Thu Oct 3 11:35:10 UTC 2019. [ 423s] [ 423s] ### VM INTERACTION START ### [ 426s] [ 407.606916] sysrq: SysRq : Power Off [ 426s] [ 407.612337] reboot: Power down [ 426s] ### VM INTERACTION END ### [ 426s] [ 426s] lamb15 failed "build osmo-trx_1.1.1.dsc" at Thu Oct 3 11:35:13 UTC 2019. [ 426s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 350s] asciidoc: control_if.adoc: line 136: filtering: "/usr/bin/python3" "./build/filter-wrapper.py" mscgen -o "/usr/src/packages/BUILD/tests/test-usermanual__54.png" -Tpng - [ 350s] asciidoc: include: /usr/src/packages/BUILD/common/chapters/spectrum.adoc [ 350s] asciidoc: test-usermanual.adoc: line 30: reading: /usr/src/packages/BUILD/common/chapters/spectrum.adoc [ 350s] asciidoc: include: /usr/src/packages/BUILD/common/chapters/gfdl.adoc [ 350s] asciidoc: test-usermanual.adoc: line 31: reading: /usr/src/packages/BUILD/common/chapters/gfdl.adoc [ 350s] asciidoc: include: /usr/src/packages/BUILD/common/chapters/gb.adoc [ 350s] asciidoc: test-usermanual.adoc: line 32: reading: /usr/src/packages/BUILD/common/chapters/gb.adoc [ 350s] a2x: ERROR: "/usr/bin/asciidoc" --backend docbook -a "a2x-format=pdf" -f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -f ../build/python2-filter.conf -a srcdir='.' -a commondir='../common' --attribute "docinfo" --attribute "revnumber=DRAFT " --attribute "revdate=unknown" --verbose --out-file "/usr/src/packages/BUILD/tests/test-usermanual.xml" "/usr/src/packages/BUILD/tests/test-usermanual.adoc" returned non-zero exit status 1 [ 350s] [ 350s] [ 350s] make[3]: *** [../build/Makefile.asciidoc.inc:69: test-usermanual.pdf] Error 1 [ 350s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 350s] make[2]: *** [Makefile:438: all-recursive] Error 1 [ 350s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 350s] make[1]: *** [Makefile:362: all] Error 2 [ 350s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 350s] dh_auto_build: make -j1 returned exit code 2 [ 350s] make: *** [debian/rules:5: binary] Error 255 [ 350s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 350s] [ 350s] cloud114 failed "build osmo-gsm-manuals-dev_0.2.0.dsc" at Thu Oct 3 11:27:34 UTC 2019. [ 350s] [ 350s] ### VM INTERACTION START ### [ 353s] [ 317.594088] sysrq: SysRq : Power Off [ 353s] [ 317.602264] reboot: Power down [ 354s] ### VM INTERACTION END ### [ 354s] [ 354s] cloud114 failed "build osmo-gsm-manuals-dev_0.2.0.dsc" at Thu Oct 3 11:27:38 UTC 2019. [ 354s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...libosmocore[master]: add osmo_fsm_inst_watch()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15660 ) Change subject: add osmo_fsm_inst_watch() .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15660/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15660/2//COMMIT_MSG@20 PS2, Line 20: immediate error handling directly terminated and deallocated bar Looking at the problem from the other side: can we delay deallocation of the FSM instances and move it to osmo_select_main()? This way calling osmo_fsm_inst_term() would not deallocate a given FSM immediately, but just mark it as 'to be deallocated' instead, and you will be sure that bar still exists (we may want to discard all events in such case). https://gerrit.osmocom.org/#/c/15660/2//COMMIT_MSG@32 PS2, Line 32: osmo_fsm_inst_watch More I learn Erlang, more I realize that we're basically reimplementing basic primitives that it already has. At least this could be done using 'erlang:monitor/2'. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d8306488506c60b4c2fc1c4cb3ac04654db9c43 Gerrit-Change-Number: 15660 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 07:33:44 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...libosmocore[master]: API doc tweaks (mncc.h, gsm_08_08.h)
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15659 ) Change subject: API doc tweaks (mncc.h, gsm_08_08.h) .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b4c7e737c83c65e358496e4540c14be5abc5474 Gerrit-Change-Number: 15659 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 03 Oct 2019 07:17:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
