[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: laforge, neels, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email )
Change subject: libmsc: add X5 timer for delaying LU connections
..
Patch Set 4:
(4 comments)
Patchset:
PS4:
> Just an idea: […]
I suggested this improvement to the customer (see note-16 in SYS#6913), but
they refused. I would still like to implement this, but I ran out of the
estimated time, so I'll leave this as a potential improvement for a separate
patch.
PS4:
> If the SMSC has a response message to the readyForSM saying "ack, i had
> nothing to submit", then I would again like to remove this timeout, as soon
> as osmo-msc supports those messages.
This sounds logical and would be nice, but there exists no such thing in MAP
protocol and thus should not be in GSUP, unless we really want to deviate from
the former. See 3GPP TS 29.002, Table 12.4/1.
File src/libmsc/msc_a.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/db8c35e7_5129ac6b
PS4, Line 164: static void msc_a_put_use_lu(struct msc_a *msc_a)
> (i'd prefer the name msc_a_put_lu_deferred() […]
Done
File src/libmsc/ran_infra.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/cd9271a5_0f3703ef
PS4, Line 47: { .T = -5, .default_val = 0, .unit = OSMO_TDEF_MS, .desc =
"Additional delay for LU connections" }, \
(two separate things in one thread making it a bit hard to respond)
doc string change: ack, updated in the new patchset.
> you need to add a new timer entry to the list in the wiki: [...]
Done.
> I would encourage to avoid re-using the same timer numbers.
> By that scheme, currently the next available X timer is X 36 or -36.
I remember this was discussed somewhere, but I am not sure if we ever reached
an agreement on the numbering scope of those Osmocom specific X-timers.
According to that table, timer numbers like X1 and X2 are re-used in several
projects, but AFAIU this is because they were added before you suggested to
make X-timer numbers globally unique? Also, there is nothing on that wiki page
saying "please avoid re-using the same timer numbers"...
I don't have a strong opinion here, so I'll just follow your suggestion.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Attention: neels
Gerrit-Attention: laforge
Gerrit-Attention: pespin
Gerrit-Comment-Date: Tue, 28 May 2024 07:55:23 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: libmsc: add X5 timer for delaying LU connections .. libmsc: add X5 timer for delaying LU connections The idea is to allow re-using the radio channel that was used for Location Updating to deliver MT SMS over GSUP. This is achieved by delaying release of a BSSAP/RANAP connection and thus delaying the release of the radio channel. The delay can be configured using new timer X5 (default 0 ms), separately for GERAN and UTRAN. Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Related: osmo-ttcn3-hacks.git I74fa174ea649adb2112c8e471c0e339a2197a08d Related: SYS#6913 --- M include/osmocom/msc/msc_a.h M src/libmsc/msc_a.c M src/libmsc/ran_infra.c 3 files changed, 65 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/60/36760/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: fixeria, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email )
Change subject: libmsc: add X5 timer for delaying LU connections
..
Patch Set 4:
(2 comments)
Patchset:
PS4:
Just an idea:
Would it make sense to not apply this delay on periodic LU,
i.e. delay only on IMSI-attach LU?
Or maybe separate timers for periodic LU and IMSI-attach LU?
We have these types of LU:
osmo-msc/include/osmocom/msc/vlr.h
enum vlr_lu_type {
VLR_LU_TYPE_PERIODIC,
VLR_LU_TYPE_IMSI_ATTACH,
VLR_LU_TYPE_REGULAR,
};
A periodic LU happens every 15 minutes for each active subscriber, so it could
be significant.
File src/libmsc/ran_infra.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/82606554_7654435a
PS4, Line 47: { .T = -5, .default_val = 0, .unit = OSMO_TDEF_MS, .desc =
"Additional delay for LU connections" }, \
> you need to add a new timer entry to the list in the wiki: […]
(may I suggest the doc string:
"Delay connection release after LU. Useful to optimize an SMSC to dispatch
pending messages within the initial connection."
- clarify "release"; otherwise a misunderstanding could be: "let the MS wait
before accepting its LU"
- mention motivation
- vty doc strings are allowed to be long
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Attention: fixeria
Gerrit-Attention: pespin
Gerrit-Comment-Date: Tue, 28 May 2024 01:31:11 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email ) Change subject: libmsc: add X5 timer for delaying LU connections .. Patch Set 4: (1 comment) Patchset: PS2: > > But how is the program on the other side of GSUP supposed to know it may > > want to test sending SMS […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 28 May 2024 00:00:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: fixeria, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email )
Change subject: libmsc: add X5 timer for delaying LU connections
..
Patch Set 4:
(3 comments)
Patchset:
PS4:
thanks for the explanation!
If the SMSC has a response message to the readyForSM saying "ack, i had nothing
to submit", then I would again like to remove this timeout, as soon as osmo-msc
supports those messages.
But I see the point and this patch is simple enough, also the default is zero,
and a user has control.
I'd +2 now, but I found a minor detail: the timer number. see below.
(also a bikeshed, maybe you agree, or nm if not.)
File src/libmsc/msc_a.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/591de529_32838275
PS4, Line 164: static void msc_a_put_use_lu(struct msc_a *msc_a)
(i'd prefer the name msc_a_put_lu_deferred()
1: the prefix is 'MSC_A_USE' and 'LOCATION_UPDATING' is what we put and get.
2: the name should reflect that it may not happen immediately.
)
File src/libmsc/ran_infra.c:
https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/1e891f84_965b620f
PS4, Line 47: { .T = -5, .default_val = 0, .unit = OSMO_TDEF_MS, .desc =
"Additional delay for LU connections" }, \
you need to add a new timer entry to the list in the wiki:
https://osmocom.org/projects/cellular-infrastructure/wiki/List_of_Timer_numbers
This is the definitive source for new timers.
First add the new timer there, even before submitting a patch, to make sure
no-one else uses the same.
I would encourage to avoid re-using the same timer numbers.
By that scheme, currently the next available X timer is X 36 or -36.
The description line on the wiki page should be identical to the t_def doc
string.
Thanks!
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Attention: fixeria
Gerrit-Attention: pespin
Gerrit-Comment-Date: Mon, 27 May 2024 23:59:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email ) Change subject: libmsc: add X5 timer for delaying LU connections .. Patch Set 4: (1 comment) Patchset: PS4: > LGTM, but I'd like @nhofm...@sysmocom.de to have a look at it, he knows far > better this code. Neels: friendly ping? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 27 May 2024 20:18:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: fixeria, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email ) Change subject: libmsc: add X5 timer for delaying LU connections .. Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: I also think @nhofm...@sysmocom.de should have a look -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 22 May 2024 15:36:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email ) Change subject: libmsc: add X5 timer for delaying LU connections .. Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: LGTM, but I'd like @nhofm...@sysmocom.de to have a look at it, he knows far better this code. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 17 May 2024 16:07:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU connections
Attention is currently required from: laforge, neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email ) Change subject: libmsc: add X5 timer for delaying LU connections .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 17 May 2024 15:08:58 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
