Change in ...osmo-bsc[master]: Cell Broadcast: CBSP and CBCH scheduling support

2019-09-04 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/15373 )

Change subject: Cell Broadcast: CBSP and CBCH scheduling support
..


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc
File doc/manuals/chapters/smscb.adoc:

https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc@44
PS2, Line 44: connecting to the CBC.  This way the BSCs all need to know the 
CBC IP
> 1- Extra space after dot. […]
1- I always use double spacing after the end of a sentence.  It probably shows 
that I was using Emaacs in the 1990ies, where this was pretty much default.  I 
still think it's much more readable this way.  And it's an easy way to 
programmatically distinguish the dot as part of an abbreviation (e.g. ...) and 
the dot at the end of the sentence.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7
Gerrit-Change-Number: 15373
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Wed, 04 Sep 2019 10:44:31 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in ...osmo-bsc[master]: Cell Broadcast: CBSP and CBCH scheduling support

2019-09-02 Thread laforge 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/15373

to look at the new patch set (#3).

Change subject: Cell Broadcast: CBSP and CBCH scheduling support
..

Cell Broadcast: CBSP and CBCH scheduling support

This adds code to handle CBSP (Cell Broadcast Service Protocol)
from the CBC (Cell Broadcast Centre), as well as BSC-internal data
structures for scheduling the various SMSCB on the CBCH of each BTS.

There are currently one known shortcoming in the code: We don't yet
verify if keepalives are received within repetition period.

Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7
---
A doc/manuals/chapters/smscb.adoc
M doc/manuals/osmobsc-usermanual.adoc
M doc/manuals/vty/bsc_vty_reference.xml
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bsc_msc_data.h
M include/osmocom/bsc/debug.h
M include/osmocom/bsc/gsm_data.h
A include/osmocom/bsc/smscb.h
M include/osmocom/bsc/vty.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bsc_init.c
M src/osmo-bsc/bsc_vty.c
A src/osmo-bsc/cbch_scheduler.c
A src/osmo-bsc/cbsp_link.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/osmo_bsc_main.c
A src/osmo-bsc/smscb.c
M tests/handover/Makefile.am
19 files changed, 1,898 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/15373/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7
Gerrit-Change-Number: 15373
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in ...osmo-bsc[master]: Cell Broadcast: CBSP and CBCH scheduling support

2019-09-02 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/15373 )

Change subject: Cell Broadcast: CBSP and CBCH scheduling support
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c
File src/osmo-bsc/smscb.c:

https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c@142
PS2, Line 142:  static struct osmo_cell_global_id cgi;
> What about passing it as a parameter and filling it from there? This way 
> space is not lost for users […]
are we arguing about something like 16 estimated bytes for the entire program? 
For sure I'm against bloat, but we're not talking about anything worth 
considerng here.  Ease of development is more important thant those few bytes, 
for sure.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7
Gerrit-Change-Number: 15373
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Mon, 02 Sep 2019 09:59:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in ...osmo-bsc[master]: Cell Broadcast: CBSP and CBCH scheduling support

2019-09-02 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/15373 )

Change subject: Cell Broadcast: CBSP and CBCH scheduling support
..


Patch Set 2:

(5 comments)

https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc
File doc/manuals/chapters/smscb.adoc:

https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc@43
PS2, Line 43: configuration more simple, ti also can operate in TCP client mode,
typo: ti->it.


https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc@44
PS2, Line 44: connecting to the CBC.  This way the BSCs all need to know the 
CBC IP
1- Extra space after dot.
2- "This way the BSCs all need to know IS the CBC IP address".


https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc@45
PS2, Line 45: address, but not vice-versa
Missing dot.


https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c
File src/osmo-bsc/smscb.c:

https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c@44
PS2, Line 44: /* replace the old head of an entire list with e new head; 
effectively moves the entire
"a new head"


https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c@142
PS2, Line 142:  static struct osmo_cell_global_id cgi;
What about passing it as a parameter and filling it from there? This way space 
is not lost for users who don't plan to use CBCH.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7
Gerrit-Change-Number: 15373
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Comment-Date: Mon, 02 Sep 2019 09:41:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-bsc[master]: Cell Broadcast: CBSP and CBCH scheduling support

2019-09-02 Thread laforge 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/15373

to look at the new patch set (#2).

Change subject: Cell Broadcast: CBSP and CBCH scheduling support
..

Cell Broadcast: CBSP and CBCH scheduling support

This adds code to handle CBSP (Cell Broadcast Service Protocol)
from the CBC (Cell Broadcast Centre), as well as BSC-internal data
structures for scheduling the various SMSCB on the CBCH of each BTS.

There are currently one known shortcoming in the code: We don't yet
verify if keepalives are received within repetition period.

Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7
---
A doc/manuals/chapters/smscb.adoc
M doc/manuals/osmobsc-usermanual.adoc
M doc/manuals/vty/bsc_vty_reference.xml
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bsc_msc_data.h
M include/osmocom/bsc/debug.h
M include/osmocom/bsc/gsm_data.h
A include/osmocom/bsc/smscb.h
M include/osmocom/bsc/vty.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bsc_init.c
M src/osmo-bsc/bsc_vty.c
A src/osmo-bsc/cbch_scheduler.c
A src/osmo-bsc/cbsp_link.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/osmo_bsc_main.c
A src/osmo-bsc/smscb.c
M tests/handover/Makefile.am
19 files changed, 1,898 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/15373/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7
Gerrit-Change-Number: 15373
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset