Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Oct 2018 17:50:36 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. cosmetic: fix spec ref for gsm0808_cipher_mode() Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Max: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index a20d5d0..48af06b 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -415,7 +415,7 @@ } /* - * GSM 08.08 § 3.4.7 cipher mode handling. We will have to pick + * GSM 08.08 § 3.1.14 cipher mode handling. We will have to pick * the cipher to be used for this. In case we are already using * a cipher we will have to send cipher mode reject to the MSC, * otherwise we will have to pick something that we and the MS -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: osmith
Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
Max has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Oct 2018 15:35:27 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 2: > You have to find the related section in 08.08 (or these days, 48.008). Done, it's 08.08 § 3.1.14. -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Oct 2018 08:18:08 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11437 to look at the new patch set (#2). Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. cosmetic: fix spec ref for gsm0808_cipher_mode() Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/11437/2 -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith
Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 1: > What am I missing? That this code has nothing to do with the 04.08 (Mobile Layer 3), but with BSSAP/BSSMAP specified in 08.08. It's nice that some other spec also mentions something about what that layer of the stack / that interface has to do in case of a cipher mode set. But that still doesn't make it apply here. You have to find the related section in 08.08 (or these days, 48.008). -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 24 Oct 2018 18:49:53 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 1: > I don't really see where the entire function does anything related to GSM TS > 04.08? It's dealing with BSSAP/BSSMAP which is in 08.08 ?!? Well, originally this said: > GSM 08.08 § 3.4.7 cipher mode handling. So I went looking for that chapter in GSM 08.08, but I could not find it. * GSM 08.08 goes only until 3.3, no 3.4: https://www.etsi.org/deliver/etsi_gts/08/0808/05.12.00_60/gsmts_0808v051200p.pdf * GSM 04.08 has "3.4.7 Ciphering mode setting procedure", page 59 in this PDF: https://www.etsi.org/deliver/etsi_gts/04/0408/05.03.00_60/gsmts_0408v050300p.pdf ...so my conclusion was, that this was meant to point to 04.08 § 3.4.7. What am I missing? -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 24 Oct 2018 08:28:56 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11437 ) Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. Patch Set 1: Code-Review-1 I don't really see where the entire function does anything related to GSM TS 04.08? It's dealing with BSSAP/BSSMAP which is in 08.08 ?!? -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Tue, 23 Oct 2018 18:26:09 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11437 Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode() .. cosmetic: fix spec ref for gsm0808_cipher_mode() Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/11437/1 diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index a20d5d0..1e97f33 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -415,7 +415,7 @@ } /* - * GSM 08.08 § 3.4.7 cipher mode handling. We will have to pick + * GSM 04.08 § 3.4.7 cipher mode handling. We will have to pick * the cipher to be used for this. In case we are already using * a cipher we will have to send cipher mode reject to the MSC, * otherwise we will have to pick something that we and the MS -- To view, visit https://gerrit.osmocom.org/11437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6 Gerrit-Change-Number: 11437 Gerrit-PatchSet: 1 Gerrit-Owner: osmith
