Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters/gsup.adoc: document MO-/MT-forwardSM messages Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Related Change-Id: (core) Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71 Related Change-Id: (TTCN) Ibf49474a81235096c032ea21f217170f523bd94e Related: OS#3587 --- M common/chapters/gsup.adoc 1 file changed, 213 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Neels Hofmeyr: Looks good to me, approved Stefan Sperling: Looks good to me, but someone else must approve diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index 70295cf..56a6f9e 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -504,6 +504,113 @@ can be used to notify the MSC that a structured supplementary service is successfully activated or deactivated, etc. + MO-forwardSM Request + +Direction: MSC / SGSN => SMSC (via HLR) + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|41|SM-RP-DA (Destination Address)|<>|M|TLV|2-... +|42|SM-RP-OA (Originating Address)|<>|M|TLV|2-... +|43|SM-RP-UI (SM TPDU)|<>|M|TLV|1-... +|=== + +This message is used to forward MO short messages from MSC / SGSN to an SMSC. +The corresponding MAP service is MAP-MO-FORWARD-SHORT-MESSAGE, +see 3GPP TS 29.002, section 12.2. + + MO-forwardSM Error + +Direction: SMSC (via HLR) => MSC / SGSN + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|44|SM-RP-Cause (Cause value)|<>|M|TLV|1 +|43|SM-RP-UI (diagnostic field)|<>|O|TLV|1-... +|=== + +This message is used to indicate a negative result of an earlier +MO short message delivery. The corresponding MAP service is +MAP-MO-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.2. + + MO-forwardSM Result + +Direction: SMSC (via HLR) => MSC / SGSN + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|=== + +This message is used to indicate a successful result of an earlier +MO short message delivery. The corresponding MAP service is +MAP-MO-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.2. + + MT-forwardSM Request + +Direction: SMSC (via HLR) => MSC / SGSN + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|41|SM-RP-DA (Destination Address)|<>|M|TLV|2-... +|42|SM-RP-OA (Originating Address)|<>|M|TLV|2-... +|43|SM-RP-UI (SM TPDU)|<>|M|TLV|1-... +|45|SM-RP-MMS (More Messages to Send)|<>|O|TLV|1 +|=== + +This message is used to forward MT short messages from an SMSC to MSC / SGSN. +The corresponding MAP service is MAP-MT-FORWARD-SHORT-MESSAGE, +see 3GPP TS 29.002, section 12.9. + + MT-forwardSM Error + +Direction: MSC / SGSN => SMSC (via HLR) + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|44|SM-RP-Cause (Cause value)|<>|M|TLV|1 +|43|SM-RP-UI (diagnostic field)|<>|O|TLV|1-... +|=== + +This message is used to indicate a negative result of an earlier +MT short message delivery. The corresponding MAP service is +MAP-MT-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.9. + + MT-forwardSM Result + +Direction: MSC / SGSN => SMSC (via HLR) + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|=== + +This message is used to indicate a successful result of an earlier +MT short message delivery. The corresponding MAP service is +MAP-MT-FORWARD-SHORT-MESSAGE, see 3GPP TS 29.002, section 12.9. + === Information Elements [[gsup-ie-msgtype]] @@ -534,6 +641,12 @@ |0x20|Supplementary Service Request |0x21|Supplementary Service Error |0x22|Supplementary Service Result +|0x24|MO-forwardSM Request +|0x25|MO-forwardSM Error +|0x26|MO-forwardSM Result +|0x28|MT-forwardSM Request +|0x29|MT-forwardSM Error +|0x2a|MT-forwardSM Result |=== [[gsup-ie-ipaddr]] @@ -760,6 +873,12 @@ |0x30|Session ID|<> |0x31|Session State|<> |0x35|Supplementary Service Info|<> +|0x40|SM-RP-MR (Message Reference)|<> +|0x41|SM-RP-DA (Destination Address)|<> +|0x42|SM-RP-OA (Originating Address)|<> +|0x43|SM-RP-UI (SM TPDU)|<> +|0x44|SM-RP-Cause (RP Cause value)|<> +|0x45|SM-RP-MMS (More Messages to
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Tue, 18 Dec 2018 11:07:05 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 7: Code-Review+2 there have been only trivial changes since stsp's earlier +1, so +2ing -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 17 Dec 2018 19:29:29 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 17 Dec 2018 19:28:35 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/11836/6/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/6/common/chapters/gsup.adoc@1134 PS6, Line 1134: |0x00|Reserved (used inside libosmocore only) > Leaking implementation details into the protocol specification. […] Done -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 17 Dec 2018 17:53:51 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Hello Stefan Sperling, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11836 to look at the new patch set (#7). Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters/gsup.adoc: document MO-/MT-forwardSM messages Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Related Change-Id: (core) Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71 Related Change-Id: (TTCN) Ibf49474a81235096c032ea21f217170f523bd94e Related: OS#3587 --- M common/chapters/gsup.adoc 1 file changed, 213 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/36/11836/7 -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 6: Code-Review+1 (1 comment) got a comment still, but since it's minor... https://gerrit.osmocom.org/#/c/11836/6/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/6/common/chapters/gsup.adoc@1134 PS6, Line 1134: |0x00|Reserved (used inside libosmocore only) Leaking implementation details into the protocol specification. To guard 0x00 in libosmocore is a detail of how libosmocore handles presence flagging, does not belong here. Reserving should make sense from a protocol perspective, e.g.: "Reserved for future extension"? Or you could say just "Reserved" without a reason... -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 17 Dec 2018 14:52:20 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 17 Dec 2018 11:30:20 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11836 to look at the new patch set (#6). Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters/gsup.adoc: document MO-/MT-forwardSM messages Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Related Change-Id: (core) Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71 Related Change-Id: (TTCN) Ibf49474a81235096c032ea21f217170f523bd94e Related: OS#3587 --- M common/chapters/gsup.adoc 1 file changed, 214 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/36/11836/6 -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Stefan Sperling
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 5: (9 comments) https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@509 PS4, Line 509: Direction: MSC / SGSN => SMSC (via HLR) > (a nicer term is "via", not "through" ... […] Done https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@541 PS4, Line 541: MO short message delivery. The corresponding MAP service is > I still think it is really irritating to explain the same abbreviations over > and over. […] Done https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@578 PS4, Line 578: see 3GPP TS 29.002, section 12.9. > MT from glossary Done https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@579 PS4, Line 579: > and I still don't like this. […] Done https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@1122 PS4, Line 1122: |=== > I don't like the "nested" in here. See https://gerrit.osmocom. […] Done https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@1139 PS4, Line 1139: |=== > "Special"? What does it mean? If it has no meaning, does it even need > encoding? Keep apart the inner […] Done https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@1143 PS4, Line 1143: > This is also "Special"? Rather just say what it means, or that it is reserved > for purpose X = must n […] Done https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1093 PS5, Line 1093: relay sub-layer protocol. It can be either of the following: > "Either" implies that there are only two options. "Either" is used in the specs., see 7.6.8.1. I'll change anyway. https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1168 PS5, Line 1168: should keep RAN the connection open. See 3GPP TS 29.002, section 7.6.8.7. > I'm having trouble understanding this part: […] You're right. Thanks. -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Stefan Sperling Gerrit-Comment-Date: Fri, 14 Dec 2018 13:15:44 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1093 PS5, Line 1093: relay sub-layer protocol. It can be either of the following: "Either" implies that there are only two options. Since there are three options listed below, this should say "any of the following" instead of "either of the following". https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1106 PS5, Line 1106: relay sub-layer protocol. It can be either of the following: Here, "either" is fine :) https://gerrit.osmocom.org/#/c/11836/5/common/chapters/gsup.adoc@1168 PS5, Line 1168: should keep RAN the connection open. See 3GPP TS 29.002, section 7.6.8.7. I'm having trouble understanding this part: "the network should keep RAN the connection open" Did you mean to write "the network should keep the RAN connection open" instead? Or something else? -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Stefan Sperling Gerrit-Comment-Date: Fri, 14 Dec 2018 12:27:38 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 14 Dec 2018 00:56:22 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 4: Code-Review+2 (5 comments) I still see some of my points not addressed, but it's better to have this now than nothing. If you will, you could address below review and ping me to +2 again; or merge and come back with anoter patch later; or merge and disagree with me and I will eternally dislike it but probably forget about it soon :P https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@509 PS4, Line 509: Direction: MSC / SGSN => SMSC (through HLR) (a nicer term is "via", not "through" ... but nm) https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@541 PS4, Line 541: _MO (Mobile Originated)_ short message delivery. The corresponding I still think it is really irritating to explain the same abbreviations over and over. If you have to, place the braces once above and then don't do that anymore for the rest of the doc. But actually, instead make sure MO and MT are in the glossary and then rely on that completely. We did agree on that before, right? I think we also agreed before on less fancy fontsy stuff, i.e. try to avoid italics and bold script. Especially don't place an entire "FOO (yada)" in italics? https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@543 PS4, Line 543: section 12.2. it's much nicer with the reference in the end, thanks :) https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@578 PS4, Line 578: This message is used to forward _MT (Mobile Terminated)_ short messages MT from glossary https://gerrit.osmocom.org/#/c/11836/4/common/chapters/gsup.adoc@579 PS4, Line 579: from an SMSC to MSC (CS domain) / SGSN (PS domain). The corresponding MAP and I still don't like this. I am still of the same opinion: the protocol definition is not the place to explain MSC = CS domain and SGSN = PS domain, especially not N times over and over. -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 10 Dec 2018 20:46:25 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc@523 PS3, Line 523: ESME (External Short Message : Entity) > I'm sorry, it's not really an ESME here. It's actually the SMSC. […] Thanks for the clarification. I'll fix. -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 03 Dec 2018 13:18:03 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11836 to look at the new patch set (#4). Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters/gsup.adoc: document MO-/MT-forwardSM messages Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Related Change-Id: (core) Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71 Related Change-Id: (TTCN) Ibf49474a81235096c032ea21f217170f523bd94e Related: OS#3587 --- M common/chapters/gsup.adoc 1 file changed, 219 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/36/11836/4 -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 3: Code-Review-1 (6 comments) https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc@523 PS3, Line 523: ESME (External Short Message : Entity) I'm sorry, it's not really an ESME here. It's actually the SMSC. ESME is an external entity after/beyound the SMSC. https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc@529 PS3, Line 529: ESME SMSC https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc@548 PS3, Line 548: ESME smsc https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc@565 PS3, Line 565: ESME SMSC https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc@580 PS3, Line 580: ESME (External Short Message Entity) SMSC, not ESME. https://gerrit.osmocom.org/#/c/11836/3/common/chapters/gsup.adoc@586 PS3, Line 586: ESME SMSC -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 03 Dec 2018 13:05:17 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 03 Dec 2018 00:31:31 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 2: (7 comments) Let me state again that this documentation is fine as it is. I have quite detailed opinions on documentation, and it's intended to provide ideas (not so much criticism), and shouldn't be a blocker if others think it's fine. There are two(?) places where the reference to a section number isn't clear, that's the only reason why I -1. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@507 PS2, Line 507: MO-forwardSM Request > Well, this mix is not my invention. I am also not a big fun of such style. […] if Wireshark are the only ones using this naming, then that's not a reason to take it in here. If it were etsi specs that would be different. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@509 PS2, Line 509: Direction: SGSN / MSC => ESME (through VLR and HLR) > It isn't able yet, but there should be an issue about that. […] yes, not important. (yet ever so slightly confusing the status quo) https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@522 PS2, Line 522: This message is used to forward _MO (Mobile Originated)_ short messages > Actually, there is some magic happening between "When a subscriber […] yes, it is absolutely possible to understand, I just found myself reading the sentence was hard with all the interleaves, i.e. the braces like "(PS domain)", "(External...)", "(defined...)", so I would like to have a plain readable sentence first, and then more information separately, if it's required. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@528 PS2, Line 528: attempt and _RP-SMMA_ notification attempt on the _SM-RL (Relay Layer)_. > > "attempt" sounds like it fails […] agree (actually none of my remarks are critical) https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@532 PS2, Line 532: Direction: ESME (through VLR and HLR) => SGSN / MSC > No need to reverse, this is correct. […] I meant the order in the braces. As it is now I read that the ESME sends to the VLR and then to the HLR. So I'd favor: ESME (through HLR and VLR) -> MSC https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@545 PS2, Line 545: short message delivery from SGSN (PS domain) / MSC (CS domain) to an ESME > "... from SGSN (PS domain) / MSC (CS domain) to an ESME ..." […] It would help to put 'an earlier' in there: This message is used to indicate a negative result of an earlier MO short message delivery well ... and I still think an "MO message delivery" is clear and no need to explain its direction again. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@1094 PS2, Line 1094: Relay Layer)_ has an unique _message reference (see 8.2.3)_, that > > 8.2.3 in this document? then use a <> link. 8.2.3 in 04.11? […] To unclutter and remove uncertainties, I'd still rather have each reference in one place and complete, instead of spreading them with words in-between. -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 21 Nov 2018 13:34:21 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 2: (9 comments) https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@507 PS2, Line 507: MO-forwardSM Request > I'm slightly critical of the mix of dash and non-caps / CamelCase / acronym > style. […] Well, this mix is not my invention. I am also not a big fun of such style. But exactly this form is used in the MAP specifications and Wireshark. Anyway, I will think about changing to "MO Forward Short Message Request". https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@509 PS2, Line 509: Direction: SGSN / MSC => ESME (through VLR and HLR) > I'm curious why you name the SGSN first. So far I wasn't aware of our SGSN > even able to send SMS. It isn't able yet, but there should be an issue about that. I will change the order despite I don't think it's important. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@522 PS2, Line 522: This message is used to forward _MO (Mobile Originated)_ short messages Actually, there is some magic happening between "When a subscriber sends an SMS" and MSC / SGSN "forwards it to the ESME", so I could not just omit this part (SMC, SMR state machines) without a proper explanation. > Direction: SGSN / MSC => ESME (through VLR and HLR) This line clearly defines the scope - we are at the MSC / SGSN level, and we deal with MO/MT SMS messages. I don't think "MO/MT" is too technical to understand, moreover I believe everyone in the mobile telecom area should know what it means. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@524 PS2, Line 524: Entity). The corresponding MAP service (defined in 3GPP TS 29.002) is > We have a glossary of acronyms, maybe rather make sure they are in the > glossary and abbreviate every […] Thanks, I'll check out the glossary of acronyms. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@525 PS2, Line 525: *MAP-MO-FORWARD-SHORT-MESSAGE*, described in section 12.2. > rather give the spec reference once, complete, in the end "... (see 3GPP TS > 29.002 section 12. […] Thanks, I'll correct this part. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@528 PS2, Line 528: attempt and _RP-SMMA_ notification attempt on the _SM-RL (Relay Layer)_. > "attempt" sounds like it fails This word was taken exactly from the GSM 04.11 specs. Probably, I will change to "request", but I also don't think this is critical. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@532 PS2, Line 532: Direction: ESME (through VLR and HLR) => SGSN / MSC > above it spells "MSC => ESME (through VLR and HLR)" -- maybe rather reverse > it here? "ESME (through […] No need to reverse, this is correct. - Request is sent from MSC / SGSN to ESME, - Result / Error is sent back from ESME. Message flows to be introduced later. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@545 PS2, Line 545: short message delivery from SGSN (PS domain) / MSC (CS domain) to an ESME > above it says ESME => MSC, in this sentence the direction is reversed? > Copy-paste error? Or did you […] "... from SGSN (PS domain) / MSC (CS domain) to an ESME ..." is related to "... message delivery ...", this is not about the direction of Error message itself, because it was already stated above. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@1094 PS2, Line 1094: Relay Layer)_ has an unique _message reference (see 8.2.3)_, that > 8.2.3 in this document? then use a <> link. 8.2.3 in 04.11? > then write the full '3GPP TS 04.11 section 8.2.3' out here, > but rather not break the flow of the sentence with it. In the beginning of this sentence I am referencing "TS GSM 04.11", so it should be clear where to look. I would unconditionally agree with you if "8.2.3" was a part of a separate sentence. > I'd not use italics at all. If they are "given names", capitalize. Thanks, I'll most likely avoid using this. -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Tue, 20 Nov 2018 09:45:36 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 2: Code-Review-1 (12 comments) I'm sorry to criticise as much as this. I started out wanting to just +2 straight away, but ended up finding numerous trivial tweaks that would greatly serve readability. The bottom line is, this is probably correct, but I am distracted by the writing style ;) https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@507 PS2, Line 507: MO-forwardSM Request I'm slightly critical of the mix of dash and non-caps / CamelCase / acronym style. Why not just "MO Forward Short Message Request" -- that is easy to understand for the reader on first sight. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@509 PS2, Line 509: Direction: SGSN / MSC => ESME (through VLR and HLR) I'm curious why you name the SGSN first. So far I wasn't aware of our SGSN even able to send SMS. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@522 PS2, Line 522: This message is used to forward _MO (Mobile Originated)_ short messages would be nice to first say it in simple rather nontechnical terms and then add details. Like, "When a subscriber sends an SMS, this message forwards it to the ESME. [...]" https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@524 PS2, Line 524: Entity). The corresponding MAP service (defined in 3GPP TS 29.002) is We have a glossary of acronyms, maybe rather make sure they are in the glossary and abbreviate everywhere / choose to write them out everywhere. Naming both makes it harder to follow the sentence flow. Same goes for indicating "MS (CS domain) / SGSN (PS domain)" all the time, this is not the place to explain what PS and CS mean, so rather assume the reader knows these acronyms. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@525 PS2, Line 525: *MAP-MO-FORWARD-SHORT-MESSAGE*, described in section 12.2. rather give the spec reference once, complete, in the end "... (see 3GPP TS 29.002 section 12.2)" https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@528 PS2, Line 528: attempt and _RP-SMMA_ notification attempt on the _SM-RL (Relay Layer)_. "attempt" sounds like it fails. "request"? https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@532 PS2, Line 532: Direction: ESME (through VLR and HLR) => SGSN / MSC above it spells "MSC => ESME (through VLR and HLR)" -- maybe rather reverse it here? "ESME (through HLR and VLR) -> MSC"? https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@545 PS2, Line 545: short message delivery from SGSN (PS domain) / MSC (CS domain) to an ESME above it says ESME => MSC, in this sentence the direction is reversed? Copy-paste error? Or did you mean that the earlier message was in the other direction? To avoid the confusion, you could simply not name the direction again, just rely on the reader looking at the direction definition on top and knowing that an error response is for an earlier request in the other direction. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@546 PS2, Line 546: (External Short Message Entity). Thus it triggers an _RP-ERROR_ on the _SM-RL this is not the place to define what should happen in the implementation, is it? If at all, this could indicate "should usually trigger", but foremost, this explains the message definition, and the semantics are up to the implementation / explained elsewhere. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@1094 PS2, Line 1094: Relay Layer)_ has an unique _message reference (see 8.2.3)_, that Don't ask me why, but it is "a unique". I know the consonant vs vocal rule, but that is not as deterministic as one might think. There is also "an RSL procedure" because "R" is spoken "arr"... 8.2.3 in this document? then use a <> link. 8.2.3 in 04.11? then write the full '3GPP TS 04.11 section 8.2.3' out here, but rather not break the flow of the sentence with it. I'd not use italics at all. If they are "given names", capitalize. If already capitalized, italics are redundant. If you really must use italics, don't also use italics for '(see 8.2.3)'. (I used to use a lot of markup too in the past, but now my opinion is they are too much effort and rather than helping, they clutter up the reading flow.) https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@1110 PS2, Line 1110: * IMSI (see clause 7.6.2.1); clause 7.6.2.1 *where*? https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@ PS2, Line : * LMSI (see clause 7.6.2.16, not implemented!); clarify "not implemented" -- this here should be a protocol definition: it is by definition implemented or
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11836 to look at the new patch set (#2). Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters/gsup.adoc: document MO-/MT-forwardSM messages Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Related Change-Id: (core) Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71 Related Change-Id: (TTCN) Ibf49474a81235096c032ea21f217170f523bd94e Related: OS#3587 --- M common/chapters/gsup.adoc 1 file changed, 225 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/36/11836/2 -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11836 Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters/gsup.adoc: document MO-/MT-forwardSM messages Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Related Change-Id: Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71 Related Change-Id: Ibf49474a81235096c032ea21f217170f523bd94e Related: OS#3587 --- M common/chapters/gsup.adoc 1 file changed, 225 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/36/11836/1 diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index e87d979..7568fe2 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -504,6 +504,129 @@ can be used to notify the MSC that a structured supplementary service is successfully activated or deactivated, etc. + MO-forwardSM Request + +Direction: SGSN / MSC => ESME (through VLR and HLR) + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|41|SM-RP-DA (Destination Address)|<>|M|TLV|2-... +|42|SM-RP-OA (Originating Address)|<>|M|TLV|2-... +|43|SM-RP-UI (SM TPDU)|<>|M|TLV|1-... +|=== + +This message is used to forward _MO (Mobile Originated)_ short messages +from SGSN (PS domain) / MSC (CS domain) to an ESME (External Short Message +Entity). The corresponding MAP service (defined in 3GPP TS 29.002) is +*MAP-MO-FORWARD-SHORT-MESSAGE*, described in section 12.2. + +_MO-forwardSM Request_ is triggered by both _RP-DATA_ message transfer +attempt and _RP-SMMA_ notification attempt on the _SM-RL (Relay Layer)_. + + MO-forwardSM Error + +Direction: ESME (through VLR and HLR) => SGSN / MSC + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|44|SM-RP-Cause (Cause value)|<>|M|TLV|1 +|43|SM-RP-UI (diagnostic field)|<>|O|TLV|1-... +|=== + +This message is used to indicate a negative result of a _MO (Mobile Originated)_ +short message delivery from SGSN (PS domain) / MSC (CS domain) to an ESME +(External Short Message Entity). Thus it triggers an _RP-ERROR_ on the _SM-RL +(Relay Layer)_ of SGSN (PS domain) / MSC (CS domain). The corresponding MAP +service (defined in 3GPP TS 29.002) is *MAP-MO-FORWARD-SHORT-MESSAGE*, +described in section 12.2. + + MO-forwardSM Result + +Direction: ESME (through VLR and HLR) => SGSN / MSC + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|=== + +This message is used to indicate a successful result of a _MO (Mobile Originated)_ +short message delivery from SGSN (PS domain) / MSC (CS domain) to an ESME +(External Short Message Entity). Thus it triggers an _RP-ACK_ on the _SM-RL +(Relay Layer)_ of SGSN (PS domain) / MSC (CS domain). The corresponding MAP +service (defined in 3GPP TS 29.002) is *MAP-MO-FORWARD-SHORT-MESSAGE*, +described in section 12.2. + + MT-forwardSM Request + +Direction: ESME (through VLR and HLR) => SGSN / MSC + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|41|SM-RP-DA (Destination Address)|<>|M|TLV|2-... +|42|SM-RP-OA (Originating Address)|<>|M|TLV|2-... +|43|SM-RP-UI (SM TPDU)|<>|M|TLV|1-... +|=== + +This message is used to forward _MT (Mobile Terminated)_ short messages +from an ESME (External Short Message Entity) to SGSN (PS domain) / MSC +(CS domain). The corresponding MAP service (defined in 3GPP TS 29.002) is +*MAP-MT-FORWARD-SHORT-MESSAGE*, described in section 12.9. + + MT-forwardSM Error + +Direction: SGSN / MSC => ESME (through VLR and HLR) + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR (Message Reference)|<>|M|TLV|1 +|44|SM-RP-Cause (Cause value)|<>|M|TLV|1 +|43|SM-RP-UI (diagnostic field)|<>|O|TLV|1-... +|=== + +This message is used to indicate a negative result of a _MT (Mobile Terminated)_ +short message delivery from an ESME (External Short Message Entity) to SGSN +(PS domain) / MSC (CS domain). The corresponding MAP service (defined in 3GPP +TS 29.002) is *MAP-MT-FORWARD-SHORT-MESSAGE*, described in section 12.9. + +_MT-forwardSM Error_ is triggered by _RP-ERROR_ on the _SM-RL (Relay Layer)_. + + MT-forwardSM Result + +Direction: SGSN / MSC => ESME (through VLR and HLR) + +[options="header",cols="5%,45%,20%,10%,10%,10%"] +|=== +|IEI|IE|Type|Presence|Format|Length +| |Message Type|<>|M|V|1 +|01|IMSI|<>|M|TLV|2-10 +|40|SM-RP-MR
