Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm merged PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580662482
##
dev/release/utils-prepare.sh:
##
@@ -86,20 +106,20 @@ update_versions() {
git add "${desc_file}"
done
- sed -i.bak -E "s/^version = \".+\"/version = \"${version}\"/"
"${ADBC_DIR}/rust/Cargo.toml"
+ sed -i.bak -E "s/^version = \".+\"/version = \"${rust_version}\"/"
"${ADBC_DIR}/rust/Cargo.toml"
rm "${ADBC_DIR}/rust/Cargo.toml.bak"
git add "${ADBC_DIR}/rust/Cargo.toml"
if [ ${type} = "release" ]; then
pushd "${ADBC_DIR}/ci/linux-packages"
-rake version:update VERSION=${version}
+rake version:update VERSION=${linux_version}
git add debian*/changelog yum/*.spec.in
popd
else
so_version() {
local -r version=$1
- local -r major_version=$(echo $version | sed -E -e
's/^([0-9]+)\.[0-9]+\.[0-9]+$/\1/')
- local -r minor_version=$(echo $version | sed -E -e
's/^[0-9]+\.([0-9]+)\.[0-9]+$/\1/')
+ local -r major_version=$(echo $linux_version | sed -E -e
's/^([0-9]+)\.[0-9]+\.[0-9]+$/\1/')
+ local -r minor_version=$(echo $linux_version | sed -E -e
's/^[0-9]+\.([0-9]+)\.[0-9]+$/\1/')
Review Comment:
Could you use `c_version` here? Our deb packages use SO version for `c/`
libraries.
```suggestion
local -r major_version=$(echo $c_version | sed -E -e
's/^([0-9]+)\.[0-9]+\.[0-9]+$/\1/')
local -r minor_version=$(echo $c_version | sed -E -e
's/^[0-9]+\.([0-9]+)\.[0-9]+$/\1/')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078699433
Looks like it passed. That was quicker than I expected. Thanks for the help
@kou!
02-sign.sh worked:
https://github.com/lidavidm/arrow-adbc/releases/tag/apache-arrow-adbc-12-rc0
I just pushed some other fixes after grepping for uses of `$version` or
`${version}` that were left over.
I expect during the release I will have to adjust some things on the fly,
but that's OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078651444
Ah, we will use `RELEASE` as package version because `.deb`/`.rpm` uses
source archive's version (`apache-arrow-adbc-${RELEASE}.tar.gz`) as its package
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078650743 https://github.com/lidavidm/arrow-adbc/actions/runs/8843504428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078651710 Ok, sounds good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078650086 I'll give it a shot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078649346
```diff
diff --git a/dev/release/utils-prepare.sh b/dev/release/utils-prepare.sh
index dbbc531e5..acd5b7732 100644
--- a/dev/release/utils-prepare.sh
+++ b/dev/release/utils-prepare.sh
@@ -23,6 +23,7 @@ update_versions() {
local conda_version="${VERSION_NATIVE}"
local csharp_version="${VERSION_CSHARP}"
+ local linux_version="${RELEASE}"
local rust_version="${VERSION_CSHARP}"
case ${type} in
release)
@@ -30,7 +31,6 @@ update_versions() {
local docs_version="${RELEASE}"
local glib_version="${VERSION_NATIVE}"
local java_version="${VERSION_JAVA}"
- local linux_version="${VERSION_NATIVE}"
local py_version="${VERSION_NATIVE}"
local r_version="${VERSION_R}"
;;
@@ -39,7 +39,6 @@ update_versions() {
local docs_version="${RELEASE} (dev)"
local glib_version="${VERSION_NATIVE}-SNAPSHOT"
local java_version="${VERSION_JAVA}-SNAPSHOT"
- local linux_version="${VERSION_NATIVE}-SNAPSHOT"
local py_version="${VERSION_NATIVE}dev"
local r_version="${VERSION_R}.9000"
;;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078648918 Don't we want 1.0.0 as the actual version number of the package? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078648319 It should be `12-1` not `1.0.0-1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078647416 Hmm, no luck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078636498 Trying again: https://github.com/lidavidm/arrow-adbc/actions/runs/8843345685 It looks like debian/changelog was updated: https://github.com/lidavidm/arrow-adbc/commit/31d283e49e1b885eabdfae9a91912c8b40b477ff#diff-79fdeab51b21b35cb8b6b6544ca232fd4919a6b0e32f3551bbd94a044454b7e6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078633447 Hmm, I did run 01-prepare.sh. I'll try again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078631278 Here: https://github.com/lidavidm/arrow-adbc/blob/ab50f798307221e854ac0611dece70e814e3cebe/dev/release/utils-prepare.sh#L115-L118 Could you run `dev/release/01-prepare.sh` before tagging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078629215
https://github.com/lidavidm/arrow-adbc/blob/ab50f798307221e854ac0611dece70e814e3cebe/.github/workflows/packaging.yml#L300-L302
This is related.
This workflow assumes that we update versions in
`ci/linux-packages/{debian/changelog,yum/apache-arrow-spec.in}` before tagging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580478111 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: Sure, done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580477119 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a counter-based identifier (as in, 12.0.0 is the +# 12th release of ADBC). This is used to identify tags, branches, and so on. +RELEASE="12.0.0" +PREVIOUS_RELEASE="0.11.0" + +# Individual components will have a SemVer. +VERSION_CSHARP="0.12.0" +VERSION_JAVA="0.12.0" +# Because C++/Glib/Go/Python/Ruby are effectively tied at the hip, they share Review Comment: ```suggestion # Because C++/GLib/Go/Python/Ruby are effectively tied at the hip, they share ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078625474 Hmm. "1.0.0" not "12.0.0" as the version: https://github.com/lidavidm/arrow-adbc/actions/runs/8842860533/job/24282184256#step:9:2483 ```text (expected one of apache-arrow-adbc_1.0.0.orig.tar.gz, apache-arrow-adbc_1.0.0.orig.tar.bz2, ``` I'll take a look at it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078617216 It appears the Debian build is still having issues? https://github.com/lidavidm/arrow-adbc/actions/runs/8842860533/job/24282183949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580468216 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: Can we use "12" instead of "12.0.0" because we will always use ".0.0" for the part. ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to Review Comment: Could you update the "date-based" part? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078585268 Giving it a test here: https://github.com/lidavidm/arrow-adbc/actions/runs/8842860533 Assuming it builds successfully I'll validate that the expected version numbers made it into each package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580448972 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: Ah...the version in the docs will look a little funny. I suppose that's OK for now. We can always label the docs with a date or something later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580448220 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: Ok, I went with "12.0.0" since this will be our 12th release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580445825 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: I suppose there might be a little confusion for our first release. But after that we will have release = 2, version number = 1.1.0/0.13.0 which should be OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580440439 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: But yeah, in that case I think having the identifier just be 1, 2, 3, makes more sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580439828 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: Yeah, I think we can always adjust the identifier at publication time so it will be OK if we have to change it. We can always make the scripts a bit more flexible in that case too so we can update the version at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580296606 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: > What do you think of just using a counter in that case then? (2024.1, 2024.2, 2024.3) It will work too! It may be confused but we may be able to omit the `2024.` part: `1`, `2`, `3` We need to choose the next identifier when we publish a new release. If we use date-based identifier, it may be difficult. For example, we want to publish a next release in this year but it may be slipped to the next year. (Should we choose the next identifier when we publish the next release?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580238210 ## dev/release/versions.env: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: Ok! I'll take another look this afternoon What do you think of just using a counter in that case then? (2024.1, 2024.2, 2024.3) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580126841
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
adbc/ci/linux-packages/
+ # Need to align the file path with the version number (and not the
release)
+ cp -r adbc apache-arrow-adbc-${VERSION_NATIVE}
+ tar czf
adbc/ci/linux-packages/apache-arrow-adbc-${VERSION_NATIVE}.tar.gz
apache-arrow-adbc-${VERSION_NATIVE}
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580093034
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# The release as a whole has a date-based identifier. This is used to
+# identify tags, branches, and so on.
+RELEASE="2024.05.06"
Review Comment:
Hmm. It may be better that we omit preceding `0`: `2024.5.6`
This is not a semantic versioning but semver
https://pypi.org/project/semver/ can't parse `2024.05.06` format:
```console
>>> import semver
>>> semver.VersionInfo.parse('1.02.03')
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python3/dist-packages/semver.py", line 656, in parse
raise ValueError("%s is not valid SemVer string" % version)
ValueError: 1.02.03 is not valid SemVer string
```
(Sorry. The above transcript uses old semver, 2.10.2.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580075954
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
adbc/ci/linux-packages/
+ # Need to align the file path with the version number (and not the
release)
+ cp -r adbc apache-arrow-adbc-${VERSION_NATIVE}
+ tar czf
adbc/ci/linux-packages/apache-arrow-adbc-${VERSION_NATIVE}.tar.gz
apache-arrow-adbc-${VERSION_NATIVE}
Review Comment:
OK! I'll push to this branch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579236301
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
adbc/ci/linux-packages/
Review Comment:
ok, let's see if I did that right...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579184296
##
dev/release/utils-prepare.sh:
##
@@ -16,32 +16,53 @@
# under the License.
ADBC_DIR="${SOURCE_DIR}/../.."
+source "${SOURCE_DIR}/versions.env"
update_versions() {
- local base_version=$1
- local next_version=$2
- local type=$3
+ local type=$1
+ local conda_version="${VERSION_NATIVE}"
+ local csharp_version="${VERSION_CSHARP}"
+ local rust_version="${VERSION_CSHARP}"
case ${type} in
release)
- local version=${base_version}
- local conda_version=${base_version}
- local docs_version=${base_version}
- local py_version=${base_version}
- local r_version=${base_version}
+ local cmake_version="${VERSION_NATIVE}"
+ local docs_version="${RELEASE}"
+ local glib_version="${VERSION_NATIVE}"
+ local java_version="${VERSION_JAVA}"
+ local linux_version="${VERSION_NATIVE}"
+ local py_version="${VERSION_NATIVE}"
+ local r_version="${VERSION_R}"
;;
snapshot)
- local version=${next_version}-SNAPSHOT
- local conda_version=${next_version}
- local docs_version="${next_version} (dev)"
- local py_version="${next_version}dev"
- local r_version="${base_version}.9000"
+ local cmake_version="${VERSION_NATIVE}-SNAPSHOT"
+ local docs_version="${RELEASE} (dev)"
+ local glib_version="${VERSION_NATIVE}-SNAPSHOT"
+ local java_version="${VERSION_JAVA}-SNAPSHOT"
+ local linux_version="${VERSION_NATIVE}-SNAPSHOT"
+ local py_version="${VERSION_NATIVE}dev"
+ local r_version="${VERSION_R}.9000"
+ ;;
+*)
+ echo "Unknown type: ${type}"
+ exit 1
;;
esac
- local major_version=${version%%.*}
+
+ header "Updating versions for release ${RELEASE}"
+ echo "CMake: ${cmake_version}"
Review Comment:
(I'll fix up the PR later tonight!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579183791
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
adbc/ci/linux-packages/
+ # Need to align the file path with the version number (and not the
release)
Review Comment:
ah, well, if we add the day below then it will be a date and that sounds
good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579179915
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
adbc/ci/linux-packages/
+ # Need to align the file path with the version number (and not the
release)
+ cp -r adbc apache-arrow-adbc-${VERSION_NATIVE}
+ tar czf
adbc/ci/linux-packages/apache-arrow-adbc-${VERSION_NATIVE}.tar.gz
apache-arrow-adbc-${VERSION_NATIVE}
Review Comment:
I don't mind if you want to push to this branch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579179277
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
adbc/ci/linux-packages/
+ # Need to align the file path with the version number (and not the
release)
Review Comment:
Yup. Though I'm undecided if it should be MM or just a counter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579143808
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
adbc/ci/linux-packages/
Review Comment:
It's not related to this PR but we can remove `echo "VERSION=${VERSION}" >>
"$GITHUB_OUTPUT"` and always use `${VERSION}` instead of `${{
steps.info.outputs.VERSION }}`.
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
adbc/ci/linux-packages/
+ # Need to align the file path with the version number (and not the
release)
Review Comment:
Ah, we use `apache-arrow-adbc-.MM` tag after this PR?
(`VERSION` is `.MM` and `VERSION_NATIVE` is `1.0.0`, right?)
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# The release as a whole has a date-based identifier. This is used to
+# identify tags, branches, and so on.
+RELEASE="2024.05"
Review Comment:
We may want to add date too. (e.g. `2024.05.29`)
We may want to publish multiple versions in a month.
##
dev/release/utils-prepare.sh:
##
@@ -16,32 +16,53 @@
# under the License.
ADBC_DIR="${SOURCE_DIR}/../.."
+source "${SOURCE_DIR}/versions.env"
update_versions() {
- local base_version=$1
- local next_version=$2
- local type=$3
+ local type=$1
+ local conda_version="${VERSION_NATIVE}"
+ local csharp_version="${VERSION_CSHARP}"
+ local rust_version="${VERSION_CSHARP}"
case ${type} in
release)
- local version=${base_version}
- local conda_version=${base_version}
- local docs_version=${base_version}
- local py_version=${base_version}
- local r_version=${base_version}
+ local cmake_version="${VERSION_NATIVE}"
+ local docs_version="${RELEASE}"
+ local glib_version="${VERSION_NATIVE}"
+ local java_version="${VERSION_JAVA}"
+ local linux_version="${VERSION_NATIVE}"
+ local py_version="${VERSION_NATIVE}"
+ local r_version="${VERSION_R}"
;;
snapshot)
- local version=${next_version}-SNAPSHOT
- local conda_version=${next_version}
- local docs_version="${next_version} (dev)"
- local py_version="${next_version}dev"
- local r_version="${base_version}.9000"
+ local cmake_version="${VERSION_NATIVE}-SNAPSHOT"
+ local docs_version="${RELEASE} (dev)"
+ local glib_version="${VERSION_NATIVE}-SNAPSHOT"
+ local java_version="${VERSION_JAVA}-SNAPSHOT"
+ local linux_version="${VERSION_NATIVE}-SNAPSHOT"
+ local py_version="${VERSION_NATIVE}dev"
+ local r_version="${VERSION_R}.9000"
+ ;;
+*)
+ echo "Unknown type: ${type}"
+ exit 1
;;
esac
- local major_version=${version%%.*}
+
+ header "Updating versions for release ${RELEASE}"
+ echo "CMake: ${cmake_version}"
Review Comment:
How about `C` not `CMake` because we use `c/` as directory?
```suggestion
echo "C: ${c_version}"
```
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{ steps.info.outputs.VERSION }}.tar.gz
+
+ source ./apache-arrow-adbc-${{ steps.info.outputs.VERSION
}}/dev/release/versions.env
+
mv apache-arrow-adbc-${{ steps.info.outputs.VERSION }} adbc
- mv apache-arrow-adbc-${{ steps.info.outputs.VERSION
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076685740 @kou I did an initial pass over the release scripts...the main thing now will be having to bump all the versions by hand post-release but I think that's OK for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076499712 It appears our milestone assigner should still work ``` lidavidm@debian ~/C/arrow-adbc (versioning)> printf "maint-2024.05\nmaint-0.11.0" | grep -o '[0-9.]*$' | sort --version-sort 0.11.0 2024.05 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076490213 Linux packages look right, let's see about Python... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076472350 - Python used the wrong version number. - Need to validate what version number the Linux packages used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
lidavidm commented on PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076471507 Demo release: https://github.com/lidavidm/arrow-adbc/releases/tag/apache-arrow-adbc-2024.05-rc0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(dev/release): decouple version numbers [arrow-adbc]
kou commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1578811942 ## dev/release/versions.env: ## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05" +PREVIOUS_RELEASE="0.11.0" + +# Individual components will have a SemVer. +VERSION_CSHARP="0.12.0" +VERSION_GLIB="1.0.0" +VERSION_JAVA="0.12.0" +# Because C++/Go/Python are effectively tied at the hip, they share a single +# version number. Also covers Conda/Linux packages. +# TODO: untie this so that we can have independent version #s for different drivers (at least for Postgres/SQLite) +VERSION_NATIVE="1.0.0" Review Comment: GLib/Ruby can also use `VERSION_NATIVE`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
