Re: [Github-comments] [geany/geany-plugins] geanypy: Drop use of the most obvious deprecated Geany API (#363)

2016-06-09 Thread elextr
@b4n, AFAIK just use text, probably adding something like "[Deprecated, use 
...]" would do.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/363#issuecomment-225089625

Re: [Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread Tom Doan
@codebrainz Here's how you can reproduce this using Geany Portable:

1. Downloaded it from http://portableapps.com/apps/development/geany_portable
2. Install into any folder
3. Start Geany

You should see bunch of files in `GeanyPortable\Data\settings\filedefs` with 
overriding styles that prevent you from changing the theme. Geany Portable 
should not copy over these files on first start, or at least leave out the 
overriding styles, which could be confusing for first-time users.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059#issuecomment-225089501

Re: [Github-comments] [geany/geany] Font rendering is slightly harder to read (#1066)

2016-06-09 Thread elextr
Scintilla doesn't put any effort into GTK on windows because it also
provides a native windows version.  But IIUC it would be a lot of work to
change Geany to use that, and its only on windows, so there would be a big
increase in support work as there would now be two versions of Geany.

On 10 June 2016 at 14:10, Matthew Brush  wrote:

> @thdoan  yes, for a separate rendering engine.
> It would probably be less difficult to change Scintilla to mimic closer
> GTK+'s normal font rendering (ex. matching hinting, aliasing, widths, etc).
> For a comparison between Scintilla and GTK+'s normal font rendering,
> assuming you're not using "native" win32 dialogs, open the Font Chooser
> (View->Change Font) and compare the font shown in the "Preview" part of the
> font chooser dialog to what you see in Geany.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 
> .
>


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1066#issuecomment-225089402

Re: [Github-comments] [geany/geany] Emacs keybindings -mode in Devel-Geany? (#1062)

2016-06-09 Thread elextr
Emacs "open" (called visit) is the sequence ctrl-x ctrl-f which I don't believe 
GTK/Gnome can use instead of its default ctrl-o.  Only the single keystroke 
Emacs keys can be mapped IIUC.  And you can certainly do that for the ones 
Geany currently makes available for binding.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1062#issuecomment-225089076

Re: [Github-comments] [geany/geany] Font rendering is slightly harder to read (#1066)

2016-06-09 Thread Matthew Brush
@thdoan yes, for a separate rendering engine. It would probably be less 
difficult to change Scintilla to mimic closer GTK+'s normal font rendering (ex. 
matching hinting, aliasing, widths, etc). For a comparison between Scintilla 
and GTK+'s normal font rendering, assuming you're not using "native" win32 
dialogs, open the Font Chooser (View->Change Font) and compare the font shown 
in the "Preview" part of the font chooser dialog to what you see in Geany.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1066#issuecomment-225088853

Re: [Github-comments] [geany/geany] Font rendering is slightly harder to read (#1066)

2016-06-09 Thread Tom Doan
Would it be a big undertaking to adapt a different rendering engine?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1066#issuecomment-225088558

Re: [Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread Matthew Brush
@thdoan where do you get a zip file for Geany Portable? I was going to see if 
maybe they had a problem with the configuration files, but all I could find was 
a Win32 .exe file (definitively not portable :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059#issuecomment-225087808

Re: [Github-comments] [geany/geany] Font rendering is slightly harder to read (#1066)

2016-06-09 Thread Matthew Brush
It's definitively the rendering, Scintilla's Pango/Cairo rendering looks kind 
of rough on all platforms compared native Win32, or Qt or even real GTK+ font 
rendering like GtkSourceView-based apps. It's particularly bad on Windows 
though.

@thdoan You could try to copy the solarized-dark.conf file and make all the 
styles bold, it might give you better results. I have several themes where I've 
made "all bold" and "no bold" variants, which I use depending on the font and 
size to get adequate looking fonts.

IMO this bug report could made valid by changing the title to "Font rendering 
sucks." :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1066#issuecomment-225087435

Re: [Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread Tom Doan
I think this is an issue with the portable version. When I removed all the 
files in `GeanyPortable\Data\settings\filedefs` and restarted Geany, I was able 
to change themes without any issues.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059#issuecomment-225087139

Re: [Github-comments] [geany/geany] Font rendering is slightly harder to read (#1066)

2016-06-09 Thread elextr
Indeed it is likely to be a difference between rendering engines, Geany uses 
the GTK rendering engine, but IIUC Notepad uses windows native rendering.

All you can do is tweak the theme values to suit yourself.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1066#issuecomment-225086579

[Github-comments] [geany/geany] Font rendering is slightly harder to read (#1066)

2016-06-09 Thread Tom Doan
After using Geany for almost a day using the Solarized Dark theme, I felt that 
the text in Geany was slightly harder to read than in Notepad++, an editor I've 
been using for the past couple years. At first I thought I was imagining 
things, but after taking screenshots from each editor and comparing them 
side-by-side with a magnifying glass, I finally figured out why: the font 
rendering in Geany is ever so slightly darker (or thinner?) than the font 
rendering in other code editors like Notepad++. Here is the comparison:

![image](https://cloud.githubusercontent.com/assets/4110567/15953393/0537111c-2efd-11e6-93d5-92b7fdc33853.png)

Notepad++ is on top and Geany is on the bottom. It is barely noticeable in the 
image above, but if you zoom in and use the eyedropper tool you will find that 
the colors in Geany are darker than the ones in Notepad++:

![image](https://cloud.githubusercontent.com/assets/4110567/15953590/2826f2a8-2eff-11e6-9d51-5e6f1e852653.png)

Maybe I'm just more sensitive to this than others, but after spending a day 
editing code containing lots of strings using the Solarized Dark theme, I find 
that the code in Geany is slightly harder to read.

I'm not sure how to categorize this because I suspect it is related to the 
native font rendering engine that is used in Geany.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1066

Re: [Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread Matthew Brush
I don't know what this issue is about, but that comment is not accurate. It's 
extremely rare that any user should modify any style mappings in the 
filedefs/filetypes.* files, those mappings are only there for legacy reasons. 
CSS and XML should work with all colour schemes out-of-the-box, barring any 
bugs in the Portable version.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059#issuecomment-225084734

Re: [Github-comments] [geany/geany] brace_good and brace_bad styles cannot be changed (#1065)

2016-06-09 Thread Matthew Brush
The default scheme being called `filetypes.common` in the config dir instead of 
`default.conf` in the schemes dir like every other scheme is indeed confusing.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1065#issuecomment-225084083

Re: [Github-comments] [geany/geany-plugins] External plugins (#440)

2016-06-09 Thread Matthew Brush
I noticed Travis' Autotools doesn't support `AC_CONFIG_MACRO_DIRS`, but we 
could do it other ways like `m4_include`ing the file in `configure.ac` or using 
`-I` Autoconf option like we somehow do for the `build` and `build/bundled` 
dirs.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/440#issuecomment-225081171

[Github-comments] [geany/geany-plugins] External plugins (#440)

2016-06-09 Thread Matthew Brush
**_This PR isn't meant to be merged._**

I made it to show how we could allow "external" plugins, keeping their proper 
repositories as submodules to avoid the "all in" problem with GP currently 
where a plugin either has to completely move their plugin into GP repository, 
thus loosing the ability to have a separate Git host, repository history, and 
even it's own (standalone) Autotools build system.

It's still a little annoying having to maintain separate Autotools files for 
inside GP vs external, but it's not so bad (at least with Overview which is 
trivial to build). In a perfect world external plugins using Autotools 
themselves also could just add `AC_CONFIG_SUBDIRS` and re-use their existing 
(sub) build system, but I fear that would be more complicated, and I know it 
would be more slow.

Any thoughts?
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/440

-- Commit Summary --

  * Move GP build cruft for Overview into build/overview
  * Remove Overview fork from GP
  * Add submodule for Overview plugin
  * Use relative paths to allow Autotools to work

-- File Changes --

A .gitmodules (3)
M Makefile.am (2)
D build/overview.m4 (12)
R build/overview/AUTHORS (0)
R build/overview/COPYING (0)
R build/overview/ChangeLog (0)
A build/overview/Makefile.am (33)
R build/overview/NEWS (0)
R build/overview/README (0)
A build/overview/overview.m4 (6)
M configure.ac (3)
A overview (1)
D overview/Makefile.am (3)
D overview/data/Makefile.am (2)
D overview/data/prefs.ui (356)
D overview/overview/Makefile.am (29)
D overview/overview/overviewcolor.c (305)
D overview/overview/overviewcolor.h (79)
D overview/overview/overviewplugin.c (233)
D overview/overview/overviewplugin.h (36)
D overview/overview/overviewprefs.c (447)
D overview/overview/overviewprefs.h (78)
D overview/overview/overviewprefspanel.c (273)
D overview/overview/overviewprefspanel.h (47)
D overview/overview/overviewscintilla.c (1302)
D overview/overview/overviewscintilla.h (86)
D overview/overview/overviewui.c (376)
D overview/overview/overviewui.h (42)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/440.patch
https://github.com/geany/geany-plugins/pull/440.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/440


Re: [Github-comments] [geany/geany] brace_good and brace_bad styles cannot be changed (#1065)

2016-06-09 Thread Tom Doan
UPDATE: I found out that the styles in `filetypes.common` were being 
overwritten by the style definitions in the theme configuration file inside 
`Geany\data\colorschemes`.

Although this is not a bug, I found it confusing that there are multiple levels 
of overrides in different locations.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1065#issuecomment-225079257

Re: [Github-comments] [geany/geany] brace_good and brace_bad styles cannot be changed (#1065)

2016-06-09 Thread Tom Doan
Closed #1065.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1065#event-688063596

[Github-comments] [geany/geany] brace_good and brace_bad styles cannot be changed (#1065)

2016-06-09 Thread Tom Doan
I changed the `brace_good` foreground color to green (`0x00ff00`) in 
`filetypes.common`, but the color is still stuck on white. The same applies to 
the `brace_bad` style.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1065

Re: [Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread Tom Doan
Instead of adding the overriding styles there, can we add a comment instead, 
e.g.:

`# To override a style, copy the styles from the respective file inside 
Geany\App\DefaultData\settings\filedefs`

Perhaps this is something for the PortableApps team to consider.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059#issuecomment-225072835

[Github-comments] [geany/geany] Brace match bg color overrides current light highlight (#1064)

2016-06-09 Thread Tom Doan
The default brace match and brace match error background color should not be 
set so that it mixes well with any current line highlight. Right now the 
background color is overriding the current line highlight, e.g.:

![image](https://cloud.githubusercontent.com/assets/4110567/15951710/3de07a7c-2eed-11e6-8949-84804605f352.png)


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1064

Re: [Github-comments] [geany/geany-plugins] Resign Maintainership (#435)

2016-06-09 Thread Matthew Brush
> Correct, the Linux users can get it from the distros, as I said, there is no 
> distribution of upstream.​

FWIW, I used to provide binaries until Github dropped the Downloads feature and 
since GeanyPy got forked into another project which conveniently got packagers 
to package it, I stopped bothering.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/435#issuecomment-225065495

Re: [Github-comments] [geany/geany-plugins] Resign Maintainership (#435)

2016-06-09 Thread Matthew Brush
One neat thing might be to write a script which gets the list of issues off 
Github, reads MAINTAINERS, and for each maintainer emails them a list of links 
to the issues labelled with the plugin they maintain, maybe like once a week or 
month. It's only a technical solution to @b4n's first and second item above, 
but at least it might annoy people enough to either deal with the issues, or 
say "hey stop emailing me, I don't maintain this anymore". Just a thought.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/435#issuecomment-225063936

Re: [Github-comments] [geany/geany-plugins] geanypy: Drop use of the most obvious deprecated Geany API (#363)

2016-06-09 Thread Colomban Wendling
> ​I had asked that the deprecation message be put into the ​docstring, which 
> had not occurred.

Okay, I didn't get it was a request for this to be acceptable.  I'd be happy to 
add it, I'd just need to know how it should be done.  Is there a way to do that 
further than writing some random sentence?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/363#issuecomment-225061049

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread Colomban Wendling
> @@ -3498,6 +3516,7 @@
>   name="visible">True
>   name="can_focus">True
>   translatable="yes">Display height in rows for the autocompletion 
> list
> + name="invisible_char">●

I don't think I had such issues last time I modified that file, so IMO it 
requires at least an investigation.  Not to add and remove that every now and 
then.

Sure it's generated, but it requires reviewing as it's the source file. Less 
noise means less burden on the review.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060/files/67d9932e2620c252bb9e94d81dcc4991608b4fb0#r66542562

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread Matthew Brush
> @@ -3498,6 +3516,7 @@
>   name="visible">True
>   name="can_focus">True
>   translatable="yes">Display height in rows for the autocompletion 
> list
> + name="invisible_char">●

-1, better to add a few noise lines than to manually edit the glade file and 
push the problem onto the next guy like the problems we had before, IMO. It's 
just a generated file anyway, not like it's actual code people should be 
reading :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060/files/67d9932e2620c252bb9e94d81dcc4991608b4fb0#r66542343

Re: [Github-comments] [geany/geany] How to Free Geany's CTRL-A/E? (#1061)

2016-06-09 Thread Colomban Wendling
And you can copy the configuration files over to different machines.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1061#issuecomment-225060237

Re: [Github-comments] [geany/geany-plugins] multiterm: Drop deprecated geany_functions and bump API requirement (#438)

2016-06-09 Thread Matthew Brush
Seems kind of pointless to bump the required API just to remove a harmless line 
of code. If you're adamant, I don't really mind though, as long as the plugin 
still builds and works.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/438#issuecomment-225059815

Re: [Github-comments] [geany/geany] Crash on ubuntu 14.04 32bits when typing <> (#1056)

2016-06-09 Thread elextr
Then you should report the problem to tag-pair-highlighter on the [geany 
plugin](https://github.com/geany/geany-plugins/issues) issues, plugins is a 
separate project from Geany itself.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1056#issuecomment-225054190

Re: [Github-comments] [geany/geany] How to Have Variable Substitution for long paths in Geany? (#1057)

2016-06-09 Thread elextr
@sami10007 as I said above, its nothing to do with Geany how you encode your 
filenames in tex.  If tex can support what you are asking for is a question for 
a tex forum.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1057#issuecomment-225053579

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread elextr
> @@ -3427,6 +3427,23 @@
>
>  
>  
> +   id="check_always_auto_close_brackets">
> + translatable="yes">Auto-close brackets if matching bracket found

What about simply "Always auto-close brackets"?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060/files/67d9932e2620c252bb9e94d81dcc4991608b4fb0#r66537254

Re: [Github-comments] [geany/geany] Emacs keybindings -mode in Devel-Geany? (#1062)

2016-06-09 Thread elextr
As @b4n said, Emacs uses sequences of keypresses, whereas the GTK library we 
use only allows one keypress for accelerators (though that may use multiple 
keys, they must be pressed at once, not in sequence).  So it would require a 
complete re-work of the Geany keybinding system, but would still not solve the 
fact that GTK only supports single keypress accelerators for menu items and 
that would have to be overridden by Geany code as well.  So its a big job.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1062#issuecomment-225051866

Re: [Github-comments] [geany/geany-plugins] Resign Maintainership (#435)

2016-06-09 Thread Colomban Wendling
@elextr well, the problem is that

* many plugins aren't really maintained, even by their maintainers.  That's the 
problem of GP: we want some standard out of it, but maintainers don't 
necessarily answer.  Another approach could be arbitrarily dropping plugins 
when they have something we'd like to fix instead of proposing a fix.
* some are happy we do some of the work.  And that's mostly fine, although some 
should also show more concern :)
* some never answer PRs, neither refusing nor accepting them.  Which is the 
problem here, you probably should have refused it.  It's fairly complex to 
remember not to PR something here but other things there, for which part are 
here (e.g. build system should go on GP, but code changes on upstream, which 
then should be imported back).
So yeah, it might be annoying, I get that.  But maintaining it might mean 
triaging reports, or even backport changes -- or revert them.

So well… hard to please us all :S

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/435#issuecomment-225041736

Re: [Github-comments] [geany/geany] Incorrecting Folding and Marking for << (#1063)

2016-06-09 Thread Colomban Wendling
Closed #1063.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1063#event-687849666

Re: [Github-comments] [geany/geany] Incorrecting Folding and Marking for << (#1063)

2016-06-09 Thread Colomban Wendling
Your snippet is correctly highlighted, but is wrong.  Just try and run it 
you'll see Bash agrees it's malformed.  To allow indenting the terminator line, 
use `-` prefix, e.g. `-EOL`.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1063#issuecomment-225031934

Re: [Github-comments] [geany/geany] Incorrecting Folding and Marking for << (#1063)

2016-06-09 Thread Colomban Wendling
> (tab and returns does not appear to be working for me on this form)

You need to use a comment block, I edited your post.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1063#issuecomment-225031661

Re: [Github-comments] [geany/geany] Geany consistently crashes upon pasting a string (#1045)

2016-06-09 Thread Jiří Techet
Closing as I think it's fixed in 1.27. Feel free to reopen if you think I'm 
wrong.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1045#issuecomment-225012948

Re: [Github-comments] [geany/geany] Geany consistently crashes upon pasting a string (#1045)

2016-06-09 Thread Jiří Techet
Closed #1045.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1045#event-687762647

Re: [Github-comments] [geany/geany] Emacs keybindings -mode in Devel-Geany? (#1062)

2016-06-09 Thread Colomban Wendling
I have no idea.  It highly depends on what you mean by "emacs keybindings": if 
it's simple single sequences that basically just require remapping every 
actions to a different keybinding, all it would require is make everything 
configurable (some basic stuff is not, like movements).  This would require the 
work of adding the missing keybindings so they are configurable, that is, it 
would be fairly easy.

If however you want to support full multi-sequences like (I don't know emacs, 
so I won't know if it exists or what it does) M-a d or more complex, 
you'll basically need to rewrite the whole keybinding handling.  And that might 
be a lot of absolutely non-trivial work.

That said, I wonder if there isn't somebody already trying to do more or less 
this, `ville` on IRC I think.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1062#issuecomment-225003115

[Github-comments] [geany/geany] Emacs keybindings -mode in Devel-Geany? (#1062)

2016-06-09 Thread Sami L.
I would like to learn what it requires to start its development for Geany. 
Motivation
- convenient for typists (Dvorak/Colemak/...) and stereotypists (Plover)
- consistency for typing 

Some plan
- In Preferences > Keybindings > main field *Keybinding-mode*: Emacs or 
Standard. 
- Emacs-mode first keybindings: CTRL-A, CTRL-E, ... 

I can offer some help if I can grasp some basic understanding what it requires. 

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1062

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread Colomban Wendling
As said on the issue it fixes, I don't like "improving" the builting auto-close 
feature because IMO it's totally broken and useless, and there are plugins 
doing this better already available.
Also, although the "fix" makes some sense, IMO it just shows how broken the 
current approach is: it tries not to insert inappropriate pairs, but doesn't do 
it well enough.

Anyway, if really people want, I guess something like that would be fine-ish.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060#issuecomment-224969954

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread fdpierson
> @@ -3427,6 +3427,23 @@
>
>  
>  
> +   id="check_always_auto_close_brackets">
> + translatable="yes">Auto-close brackets if matching bracket found

I tried a while to think of a line that wouldn't be too long. I can change it 
though.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060/files/67d9932e2620c252bb9e94d81dcc4991608b4fb0#r66485821

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread fdpierson
> @@ -3498,6 +3516,7 @@
>   name="visible">True
>   name="can_focus">True
>   translatable="yes">Display height in rows for the autocompletion 
> list
> + name="invisible_char">●

Yea I noticed that too. I am using Glade 3.8.5 though.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060/files/67d9932e2620c252bb9e94d81dcc4991608b4fb0#r66485179

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread Colomban Wendling
> @@ -3427,6 +3427,23 @@
>
>  
>  
> +   id="check_always_auto_close_brackets">
> + translatable="yes">Auto-close brackets if matching bracket found

It probably would be better for it to read more like "Auto-closing bracket even 
if a matching bracket is found" or something.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060/files/67d9932e2620c252bb9e94d81dcc4991608b4fb0#r66485108

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread Colomban Wendling
> @@ -3498,6 +3516,7 @@
>   name="visible">True
>   name="can_focus">True
>   translatable="yes">Display height in rows for the autocompletion 
> list
> + name="invisible_char">●

same (and more below)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060/files/67d9932e2620c252bb9e94d81dcc4991608b4fb0#r66484871

Re: [Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread Colomban Wendling
> @@ -3479,6 +3496,7 @@
>   name="visible">True
>   name="can_focus">True
>   translatable="yes">The amount of characters which are necessary to show the 
> symbol autocompletion list
> + name="invisible_char">●

Spurious change.  This probably comes form using a different version of Glade 
than the one we recommend?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060/files/67d9932e2620c252bb9e94d81dcc4991608b4fb0#r66484755

Re: [Github-comments] [geany/geany] auto-close for brackets (#1041)

2016-06-09 Thread Colomban Wendling
IMO the whoel auto-close feature in Geany is broken and should rather be 
removed and the feature left to a plugin (like auto-close, that seem to do 
fairly well)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1041#issuecomment-224967166

Re: [Github-comments] [geany/geany] How to Free Geany's CTRL-A/E? (#1061)

2016-06-09 Thread Colomban Wendling
And you of course can change the key bindings that currently use 
Ctrl+A (*Selection/Select all*) and Ctrl+E 
(*Format/Comment/Uncomment line*) in the preferences.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1061#issuecomment-224966140

Re: [Github-comments] [geany/geany] How to Have Variable Substitution for long paths in Geany? (#1057)

2016-06-09 Thread Sami L.
Yes, snippets do not help because I type already enough fast. Generic feature 
would only help. Is it technically possible to do it generic?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1057#issuecomment-224950106

[Github-comments] [geany/geany] Auto-close brackets if matching bracket found. Fixes #1041. (#1060)

2016-06-09 Thread fdpierson
This is my first commit to any open source project so go easy on me.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1060

-- Commit Summary --

  * Auto-close brackets if matching bracket found. Fixes #1041.

-- File Changes --

M data/geany.glade (23)
M src/editor.c (2)
M src/editor.h (1)
M src/prefs.c (3)

-- Patch Links --

https://github.com/geany/geany/pull/1060.patch
https://github.com/geany/geany/pull/1060.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1060


Re: [Github-comments] [geany/geany-plugins] Geanygendoc: replace deprecated filetype_id (#437)

2016-06-09 Thread Jiří Techet
Looks like false positive from travis.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/437#issuecomment-224911277

Re: [Github-comments] [geany/geany] Crash on ubuntu 14.04 32bits when typing <> (#1056)

2016-06-09 Thread Laurent Marquet
It seems not

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1056#issuecomment-224904119

[Github-comments] [geany/geany-plugins] Geanygendoc: replace deprecated filetype_id (#437)

2016-06-09 Thread Jiří Techet

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/437

-- Commit Summary --

  * Geanygendoc: replace deprecated filetype_id

-- File Changes --

M geanygendoc/src/ggd.c (2)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/437.patch
https://github.com/geany/geany-plugins/pull/437.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/437


[Github-comments] [geany/geany-plugins] automark: Replace deprecated sci_get_text_range() (#436)

2016-06-09 Thread Jiří Techet
Untested.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/436

-- Commit Summary --

  * automark: Replace deprecated sci_get_text_range()

-- File Changes --

M automark/src/automark.c (22)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/436.patch
https://github.com/geany/geany-plugins/pull/436.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/436


Re: [Github-comments] [geany/geany-plugins] geanypy: Drop use of the most obvious deprecated Geany API (#363)

2016-06-09 Thread elextr
See #435 

This commit was not approved by the maintainer.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/363#issuecomment-224894598

Re: [Github-comments] [geany/geany-plugins] Resign Maintainership (#435)

2016-06-09 Thread elextr
On 9 June 2016 at 23:23, Frank Lanitz  wrote:

> G-p requires compiling too. We only offer the service for Windows users
> (is geanypy included there anyway?). Everything else is done by
> distribution workers like @hyperair , @dmaphy
> , ..
>

​Correct, the Linux users can get it from the distros, as I said, there is
no distribution of upstream.​



> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 
> .
>


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/435#issuecomment-224893396

Re: [Github-comments] [geany/geany-plugins] Shiftcolumn: Geany deprecation fixes + a simple fix (#366)

2016-06-09 Thread Jiří Techet
Merged #366.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/366#event-687223126

Re: [Github-comments] [geany/geany-plugins] Shiftcolumn: Geany deprecation fixes + a simple fix (#366)

2016-06-09 Thread Jiří Techet
LGBI

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/366#issuecomment-224892486

Re: [Github-comments] [geany/geany-plugins] Pretty printer: Geany deprecated stuff fixes and other stuff (#364)

2016-06-09 Thread Jiří Techet
Merged #364.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/364#event-687207162

Re: [Github-comments] [geany/geany-plugins] Pretty printer: Geany deprecated stuff fixes and other stuff (#364)

2016-06-09 Thread Jiří Techet
LGBI.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/364#issuecomment-224889092

Re: [Github-comments] [geany/geany-plugins] Resign Maintainership (#435)

2016-06-09 Thread elextr
The problem with that is this is the only distribution for the plugin, upstream 
is a development repository and requires users compiling the plugin.  But a 
Python user may not have C development experience.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/435#issuecomment-224880998

Re: [Github-comments] [geany/geany-plugins] Resign Maintainership (#435)

2016-06-09 Thread Frank Lanitz
Thinking about whether it would be useful to remove it at all from this 
distribution as having two plugin doesn't make sense and in future there will 
be always a gap due to the difference on developing. 

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/435#issuecomment-224876980

[Github-comments] [geany/geany-plugins] Resign Maintainership (#435)

2016-06-09 Thread elextr
Operation of Geany Plugins is untenable, commits are made without maintainer 
approval. The plugin has now diverged from upstream.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/435

-- Commit Summary --

  * Resign Maintainership

-- File Changes --

M MAINTAINERS (6)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/435.patch
https://github.com/geany/geany-plugins/pull/435.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/435


Re: [Github-comments] [geany/geany-plugins] geanypy: Drop use of the most obvious deprecated Geany API (#363)

2016-06-09 Thread elextr
@techee  its not my plugin, random people who commit stuff to it have just 
taken over its maintainership.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/363#issuecomment-224866165

Re: [Github-comments] [geany/geany-plugins] geanypy: Drop use of the most obvious deprecated Geany API (#363)

2016-06-09 Thread elextr
Better push it to upstream codebrainz/geanypy

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/363#issuecomment-224864711

Re: [Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread elextr
Yes, those filetypes specifically define styles, because they have syntactic 
entities that are special to those filetypes and not (or unlikely to be) 
covered by most colour schemes.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059#issuecomment-224864508

Re: [Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread Tom Doan
Never mind -- I had to go into `Geany\Data\settings\filedefs` and manually 
remove the styles defined in the files there in order to fix this.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059#issuecomment-224864208

Re: [Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread Tom Doan
Closed #1059.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059#event-687087512

[Github-comments] [geany/geany] Cannot change theme for some filetypes (#1059)

2016-06-09 Thread Tom Doan
Steps to reproduce:

1. Unzip Geany Portable 1.27 to a folder and run it
2. Open a CSS or XML file
3. Select View / Change Color Scheme

I got this prompt:

![image](https://cloud.githubusercontent.com/assets/4110567/15926973/69d944dc-2e71-11e6-8091-b77c3be1ddf5.png)

No matter what theme I select, the theme for CSS and XML files is stuck on 
Default (though for other filetypes the theme is updated properly).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1059

Re: [Github-comments] [geany/geany-plugins] geanypy: Drop use of the most obvious deprecated Geany API (#363)

2016-06-09 Thread Jiří Techet
Merged #363.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/363#event-687040638

Re: [Github-comments] [geany/geany-plugins] geanyprj: Drop use of the most obvious deprecated Geany API (#361)

2016-06-09 Thread Jiří Techet
LGBI.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/361#issuecomment-224853130

Re: [Github-comments] [geany/geany-plugins] geanyprj: Drop use of the most obvious deprecated Geany API (#361)

2016-06-09 Thread Jiří Techet
Merged #361.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/361#event-687032959

Re: [Github-comments] [geany/geany-plugins] geanyminiscript: Drop use of the most obvious deprecated Geany API (#360)

2016-06-09 Thread Jiří Techet
LGBI.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/360#issuecomment-224848976

Re: [Github-comments] [geany/geany-plugins] geanyminiscript: Drop use of the most obvious deprecated Geany API (#360)

2016-06-09 Thread Jiří Techet
Merged #360.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/360#event-687012757

Re: [Github-comments] [geany/geany-plugins] geanylua: Drop use of the most obvious deprecated Geany API (#358)

2016-06-09 Thread Jiří Techet
LGBI.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/358#issuecomment-224847695

Re: [Github-comments] [geany/geany-plugins] geanylua: Drop use of the most obvious deprecated Geany API (#358)

2016-06-09 Thread Jiří Techet
Merged #358.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/358#event-687006462

Re: [Github-comments] [geany/geany-plugins] geanyinsertnum: Drop use of the most obvious deprecated Geany API (#357)

2016-06-09 Thread Jiří Techet
LGBI.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/357#issuecomment-224845838

Re: [Github-comments] [geany/geany-plugins] geanyinsertnum: Drop use of the most obvious deprecated Geany API (#357)

2016-06-09 Thread Jiří Techet
Merged #357.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/357#event-686997109

Re: [Github-comments] [geany/geany-plugins] Codenav: Remove obvious deprecated code (#355)

2016-06-09 Thread Jiří Techet
LGBI.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/355#issuecomment-22484

Re: [Github-comments] [geany/geany-plugins] geanydoc: Drop use of the most obvious deprecated Geany API (#356)

2016-06-09 Thread Jiří Techet
LGBI.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/356#issuecomment-224842758

Re: [Github-comments] [geany/geany-plugins] geanydoc: Drop use of the most obvious deprecated Geany API (#356)

2016-06-09 Thread Jiří Techet
Merged #356.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/356#event-686981861

Re: [Github-comments] [geany/geany-plugins] geanydoc: Drop use of the most obvious deprecated Geany API (#356)

2016-06-09 Thread Jiří Techet
>  
>   doc = document_get_current();
>   g_return_val_if_fail(doc != NULL && doc->file_name != NULL, NULL);
>  
> - text_len = sci_get_selected_text_length(doc->editor->sci);
> - if (text_len > 1)

Technically this checks for 2-character selections and longer but looks more 
like a bug than a feature.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/356/files/1c6f05d8784ebe6c440b18b339739be86e1ad903#r66405664

Re: [Github-comments] [geany/geany-plugins] xmlsnippets: Drop use of the most obvious deprecated Geany API (#369)

2016-06-09 Thread Jiří Techet
LGBI.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/369#issuecomment-224837364

Re: [Github-comments] [geany/geany] TM cleanups (#957)

2016-06-09 Thread Jiří Techet
> +{
> + TMParserMap *map = _map[lang];
> + guint i;
> +
> + for (i = 0; i < map->size; i++)
> + {
> + TMParserMapEntry *entry = >entries[i];
> +
> + if (entry->type == type)
> + return entry->kind;
> + }
> + return '-';
> +}
> +
> +
> +void tm_parser_verify_type_mappings(void)

> Should still be possible to have a separate binary for checking, so long as 
> the symbol is public. We could have either that function public, or a 
> geany_test_main() that calls a bunch of tests and can be run without a GUI. 
> Or something like @codebrainz's idea of something like a self-test option, 
> --test that would perform tests and exit (with out without GUI, one could 
> probably be emulated somehow with some weird X-faking thingie).

What's the point of the separate testing binary? Or in other words, what's 
wrong with the current way the tests are run (already without GUI)? I don't 
understand what this is trying to achieve.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/957/files/aea7d7845917843dd6b02e5a8dc9031cabc87a86..5d9376ea801a6e6c3ec22748741362a3a2eff7ac#r66401618

Re: [Github-comments] [geany/geany] Improve Goto Symbol popup contents (#958)

2016-06-09 Thread Jiří Techet
> One thing (it's the same currently): if there's no definition available, but 
> a declaration, Ctrl+LBM goes nowhere. It might makes sense if it's bound to 
> "got to definition", but it's impractical (i.e. if you've got the header for 
> a lib but not its implementation, it'd be useful to be able to jump to the 
> declaration).

Makes sense, I've just pushed a fix for that.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/958#issuecomment-224826568

Re: [Github-comments] [geany/geany] Treat the "h" extension as a C++ file (#857)

2016-06-09 Thread Jiří Techet
> note for myself: has the fixing PR been merged? it's marked as closed, so 
> check needed.

I think all the necessary patches - the missing one was this

https://github.com/geany/geany/pull/906/commits/cb307e5b92479ce984aff01b106b1bdad346c0e8

which is now in.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/857#issuecomment-224819485