[Github-comments] Re: [geany/geany] Most recent directory is not remembered (Discussion #3664)
I didn't start Geany from the command line. On Windows, there is no reasons for me to start Geany from the command line. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3664#discussioncomment-7419853 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Most recent directory is not remembered (Discussion #3664)
Not sure where that bug number is from, Sourceforge never went that high, maybe its pre-Sourceforge SVN. One of our [elephants](https://en.wikipedia.org/wiki/Elephants_Can_Remember) might know more. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3664#discussioncomment-7418772 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Less warnings (PR #3665)
@elextr approved this pull request. Gold star to @b4n, one suggestion for extra points. > if (main_status.main_window_realized) - dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg, display_filename); + dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s", warn_msg); + + ui_set_statusbar(TRUE, "%s", warn_msg); Maybe the format should be taken out of `ui_set_statusbar` and `msgwin_status_add` or the compiler told they are [formats](https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/Function-Attributes.html) [and](https://releases.llvm.org/9.0.0/tools/clang/docs/AttributeReference.html#format). Note this is passed through printf substitution here, in `ui_set_statusbar()` and `msgwin_status_add()` called from that. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3665#pullrequestreview-1703112755 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Most recent directory is not remembered (Discussion #3664)
Normally the dialog opens in the directory of the current document. If that does not exist (no documents open or a new unsaved document) it opens with the current working directory. For Geany started from the command line this is sensible. Unfortunately on Windows for some Windows weirdness the working directory is changed from the startup working directory to the only other directory Geany knows must exist, the installation directory, the comment in the code says: ```C /* On Windows, change the working directory to the Geany installation path to not lock * the directory of a file passed as command line argument (see bug #2626124). * This also helps if plugins or other code uses relative paths to load * any additional resources (e.g. share/geany-plugins/...). */ ``` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3664#discussioncomment-7418287 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
> An alternative would be to replace all checks for WIN32 in the code with > _WIN32, but there are lots of places.. And they are in ctags code, so this would have to be fixed upstream. Not tested, but looks OK. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-1784261659 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Less warnings (PR #3665)
With this, you should be able to build *src/* and *plugins/* warning-free with `CFLAGS="-Wall -Wextra -g -Og -Wno-unused-parameter -Wunreachable-code -Wformat=2 -Wundef -Wshadow -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Werror-implicit-function-declaration"` (or just `-Wall -Wextra -g -Og -Wno-unused-parameter -Wwrite-strings` to start with) but for some Lexilla prototype and one deprecated Lexilla call. To review, go per-commit as it should be fairly trivial that way. Also, everything but maybe 12b30c5950eeccad2fed885745ff6cd0888d1d3a should not be controversial I think -- but please, raise any concern! You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3665 -- Commit Summary -- * Fix harmless GCC warning * Fix fairly nasty implicit integer conversion * "Fix" passing const arguments to spawn functions * Add casts for irrelevant -Wwrite-strings warnings * Remove invalid placeholder code * Use g_*list_free_full() instead of g_*list_foreach() * Avoid an easy-to-fix function cast * Silence warnings on appropriate GSourceFunc casts * Fix variable shadowing * Only pass literals as format strings for e.g. printf-style functions * Do not use GtkResponseType as response ID type * Silence some -Wcast-function-type warnings -- File Changes -- M plugins/filebrowser.c (12) M plugins/splitwindow.c (2) M src/build.c (40) M src/dialogs.c (5) M src/document.c (27) M src/editor.c (2) M src/filetypes.c (3) M src/libmain.c (16) M src/notebook.c (14) M src/plugins.c (14) M src/printing.c (4) M src/search.c (10) M src/spawn.c (10) M src/symbols.c (2) M src/tagmanager/tm_ctags.c (2) M src/tagmanager/tm_workspace.c (7) M src/toolbar.c (5) M src/ui_utils.c (35) M src/utils.h (4) M src/vte.c (10) -- Patch Links -- https://github.com/geany/geany/pull/3665.patch https://github.com/geany/geany/pull/3665.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3665 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Replace utils_make_human_readable_str() with g_format_size() (PR #3657)
Merged #3657 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3657#event-10800492414 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Most recent directory is not remembered (Discussion #3664)
For example, the most recent file you worked with is from that directory (you opened a file in that directory or saved a file to that directory). You then closed the file and create a new file. The directory is no longer remembered. It will default to save the new file into `C:\Program Files\Geany`. Anyway, `C:\Program Files\Geany` is not a location to save your files. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3664 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] New feature requests? (Issue #3659)
I realised that if I use geany's terminal then I could select/copy/paste code chunks from editor there. I also got 2.0 compiled though still need to get debugger/spellcheck going. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3659#issuecomment-1784022824 You are receiving this because you are subscribed to this thread. Message ID:
