[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> This doesn't mean we can't still drop the plugin if people want, I still > don't mind even if I spent some time on this This type of plugin seems inherently dangerous... But up to people to install and run what they want. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2171766865 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
I was curious about the upper limit because of problems described as being related to "newer GLib". But I guess the "invalid syntax" will or has been fixed? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2122364199 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
What's the range of glib versions this plugin is supposed to work with? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121342610 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)
> which assumes ReST markup I added the new lines because it was easier for me to read the text version. I ran it through pandoc to preview, and saw no difference. But with a different parser or added stylesheet, there could be extra space between the items. Like the difference between: ```html ... ... ``` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1343#issuecomment-2081828282 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add ability to build with meson (PR #1345)
@xiota pushed 1 commit. 442647c436a1188e07d8c9a56264436e1c989d34 meson: fix workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1345/files/a7d524b70dda93657149b90a378ce91813b1d2ac..442647c436a1188e07d8c9a56264436e1c989d34 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add ability to build with meson (PR #1345)
@xiota pushed 1 commit. a7d524b70dda93657149b90a378ce91813b1d2ac meson: fixes, update, workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1345/files/6efe0f6a6c798684b90ac8b2c287f4c9803ab0c9..a7d524b70dda93657149b90a378ce91813b1d2ac You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)
@xiota commented on this pull request.
> +* Wizard to create new LaTeX documents in a fast and easy way
+ with a bunch of templates available
+
+* A front end for add labels ``\label{}`` and references ``\ref{}`` and
+ ``\pageref{}`` with getting suggestion from aux file of document
+
+* Inserting special characters through menu
+
+* Help entering the right fields for BibTeX entries by
+ providing templates
+
+* Easy inserting format patterns like ``\texttt{}`` through menu
+
+* Support on inserting environments by offering an dialog and
+ recognising selections
+
+* Shortcuts for inserting ``\item`` and ``\newline``
+
+* Toolbar with often used format options
It was merged before I even saw this... so guess the newlines stay for now.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#discussion_r1582496945
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
> `GET request failed: WinHttp error: SECURE_CHANNEL_ERROR` > > `Unable to perform version check: Operation not supported` To confirm, the first is Windows? The second macOS? Both with GIO? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081532306 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] Add ability to build with meson (PR #1345)
This PR adds ability to build with meson. It does not attempt to duplicate autotools-specific functionality, like testing the presence of specific headers or functionality of build-system components. All plugins build successfully with meson. They all appear to load and unload correctly. Some plugins were not tested further because I have no idea how to use them. Most plugins had minimal testing, where one prominent feature appears to do what its supposed to. On Ubuntu 20.04, meson selects the correct install locations (eg, `/usr/lib/x86_64-linux-gnu/geany/` instead of `/usr/lib/geany`). You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1345 -- Commit Summary -- * Add ability to build with meson -- File Changes -- A addons/makefile (1) A addons/meson.build (45) A addons/meson_config/config.h.in (1) A addons/meson_config/meson.build (1) A addons/po (1) A autoclose/makefile (1) A autoclose/meson.build (34) A autoclose/meson_config/config.h.in (1) A autoclose/meson_config/meson.build (1) A autoclose/po (1) A automark/makefile (1) A automark/meson.build (34) A automark/meson_config/config.h.in (1) A automark/meson_config/meson.build (1) A automark/po (1) A codenav/makefile (1) A codenav/meson.build (37) A codenav/meson_config/config.h.in (1) A codenav/meson_config/meson.build (1) A codenav/po (1) A commander/makefile (1) A commander/meson.build (34) A commander/meson_config/config.h.in (1) A commander/meson_config/meson.build (1) A commander/po (1) A debugger/makefile (1) A debugger/meson.build (84) A debugger/meson_config/config.h.in (1) A debugger/meson_config/meson.build (1) A debugger/po (1) M debugger/src/gui.c (3) A debugger/subprojects/utils (1) A defineformat/makefile (1) A defineformat/meson.build (34) A defineformat/meson_config/config.h.in (1) A defineformat/meson_config/meson.build (1) A defineformat/po (1) A geanyctags/makefile (1) A geanyctags/meson.build (35) A geanyctags/meson_config/config.h.in (1) A geanyctags/meson_config/meson.build (1) A geanyctags/po (1) A geanydoc/makefile (1) A geanydoc/meson.build (35) A geanydoc/meson_config/config.h.in (1) A geanydoc/meson_config/meson.build (1) A geanydoc/po (1) A geanyextrasel/makefile (1) A geanyextrasel/meson.build (34) A geanyextrasel/meson_config/config.h.in (1) A geanyextrasel/meson_config/meson.build (1) A geanyextrasel/po (1) A geanygendoc/makefile (1) A geanygendoc/meson.build (69) A geanygendoc/meson_config/config.h.in (1) A geanygendoc/meson_config/meson.build (1) A geanygendoc/po (1) A geanyinsertnum/makefile (1) A geanyinsertnum/meson.build (34) A geanyinsertnum/meson_config/config.h.in (1) A geanyinsertnum/meson_config/meson.build (1) A geanyinsertnum/po (1) A geanylua/makefile (1) A geanylua/meson.build (92) A geanylua/meson_config/config.h.in (1) A geanylua/meson_config/meson.build (1) A geanylua/po (1) A geanymacro/makefile (1) A geanymacro/meson.build (34) A geanymacro/meson_config/config.h.in (1) A geanymacro/meson_config/meson.build (1) A geanymacro/po (1) A geanyminiscript/makefile (1) A geanyminiscript/meson.build (35) A geanyminiscript/meson_config/config.h.in (1) A geanyminiscript/meson_config/meson.build (1) A geanyminiscript/po (1) A geanynumberedbookmarks/makefile (1) A geanynumberedbookmarks/meson.build (41) A geanynumberedbookmarks/meson_config/config.h.in (1) A geanynumberedbookmarks/meson_config/meson.build (1) A geanynumberedbookmarks/po (1) A geanynumberedbookmarks/subprojects/utils (1) A geanypg/makefile (1) A geanypg/meson.build (51) A geanypg/meson_config/config.h.in (1) A geanypg/meson_config/meson.build (1) A geanypg/po (1) A geanyprj/makefile (1) A geanyprj/meson.build (42) A geanyprj/meson_config/config.h.in (1) A geanyprj/meson_config/meson.build (1) A geanyprj/po (1) A geanyvc/makefile (1) A geanyvc/meson.build (46) A geanyvc/meson_config/config.h.in (1) A geanyvc/meson_config/meson.build (1) A geanyvc/po (1) A geniuspaste/makefile (1) A geniuspaste/meson.build (47) A geniuspaste/meson_config/config.h.in (1) A geniuspaste/meson_config/meson.build (1) A geniuspaste/po (1) A git-changebar/makefile (1) A git-changebar/meson.build (42) A git-changebar/meson_config/config.h.in (1) A git-changebar/meson_config/meson.build (1) A git-changebar/po (1) A keyrecord/makefile (1) A keyrecord/meson.build (34) A keyrecord/meson_config/config.h.in (1) A keyrecord/meson_config/meson.build (1) A keyrecord/po (1) M keyrecord/src/keyrecord.c (5) A latex/makefile (1) A latex/meson.build (67)
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> it uses Geany's own `utils_open_browser()`, so that suggests this doesn't > work for you either? I had seen the browser setting, but don't know what actually uses it. Same with the terminal command. What actually uses it? I also often have ... "send selection to" not working until I restart geany. I'm close to being annoyed enough with it to search for the problem. > Though, note that the default behavior is to show the URL, not open it. It didn't appear to do either. No popup or message in status or msgwin on success. I don't recall seeing anything but some usual gtk errors in terminal. > ... by default the pastes are deleted after a while, and it just means that > nobody had made a forever-paste since then. I don't see how to use the geany pastebin service without the plugin. There's no web form I can find. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080702821 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
> has again pointed out the point I made a while back about this I realized later that you'd already said it. You're too far ahead. Takes a while to catch up. > four plugins to synchronise This number could be reduced... -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2080672792 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> not available in Debian before Bookworm (12, current stable) Do Debian and Ubuntu even bother rebuilding packages for old releases? After testing the plugin, I think it should be dropped. Most of the pastebins don't work. There's no confirmation of what it's sending. Half the time, there's no way to view the pastebin after it's sent (because plugin failed to open browser on my computer, and didn't print any message indicating issue, or where to get pastebin, etc). Once data is sent, there's no way to delete it, which is a security risk if accidentally triggered. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080481621 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
Tested... Seems to work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080360294 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
I think a problem with gio method is depends on gvfs (gnome) and not available on msys2 and brew (win/mac). Wondering now about libcurl vs libsoup. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079619971 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Someone could run the test program on windows or mac to find out. I no longer have (easy) access to either. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078735830 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
It is separate from GIO. This is the project page: https://gitlab.gnome.org/GNOME/gvfs Debian package, appears to be `gvfs-backends` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078714133 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
I use whatever is provided by the package manager. Even on Debian, pkg-config is a dummy package that redirects to pkgconf. Their stance doesn't seem particularly "aggressive" in context because they call out "passive-aggressive people who try to argue with us". Seems they probably had some people who opened numerous issues reporting closely related problems that they were told multiple times are not bugs. It would be like... what if someone opened multiple issues for Geany complaining that it doesn't support various Qt6 features despite being told multiple times that they aren't bugs? Eventually, those complaints could be considered intentionally disruptive, and people who "insist" on continuing need to be cut off. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078702112 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
> Unfortunately the GIO docs don't say when `g_file_new_from_URI()` and the > associated stream was supported (that I could see) but it works on the > machine I'm on ATM which is pretty olde. Looks like it depends on `gvfs`... After uninstalling... ``` $ ./test Error reading uri. ``` > PS I expect not everyone has your alias pkgconf == pkg-config On my computer, `pkg-config` is the symlink. Looks like [pkgconf](https://gitea.treehouse.systems/ariadne/pkgconf) and [pkg-config](https://www.freedesktop.org/wiki/Software/pkg-config/) are different projects. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078657909 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)
I'm new to meson, but switched my preview plugin over to it. One way it could be done... * Each plugin would have its own `meson.build` and `meson.options` that can be built independently. * The files should require minimal changes between plugins. * Building and testing individual plugins would become easier. * Each plugin folder would be symlinked or moved to a `subprojects` folder. This is a meson specified folder that cannot be renamed. * The main plugins folder would have a `meson.build` that imports subprojects based on whether the feature is enabled. * For convenience and compatibility, meson can be wrapped with makefiles. If there's interest, I can set up a trial with a few plugins. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1282#issuecomment-2078632550 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Size check is needed if this route is taken for the plugin... That code was intended to check whether `https://` is supported because I saw only `file://` mentioned in the docs. Typical version string is <8 bytes. Even with words like `alpha` or `pre-release`, I figured 32 bytes is enough for the test. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078600197 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)
The "freeze" isn't by explicit policy, but is what has effectively happened to plugins that aren't of primary interest to developers with commit privileges. If it helps facilitate bug fixes and minor improvements, I'm willing to be (interim) maintainer for the Markdown and GeanyLua plugins. I don't actively use them, but am interested in keeping them functional. In terms of collection infrastructure, autotools is very slow. I noticed that geany supports building with meson. Has similar work been done for geany plugins? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1282#issuecomment-2078593982 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)
Submitting a plugin to the geany-plugins collection would require freezing the code, even for bug fixes. I'm not willing to do that for a plugin I actively use, so never submitted it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1282#issuecomment-2078576837 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)
@manueljordan The procedure would be... to build and install it yourself. It uses webkit2gtk-4.0 or webkit2gtk-4.1. If you use 4.1, it will conflict with some other plugins: webhelper, markdown, updatechecker, geniuspaste. They are being updated, but I wouldn't expect rebuilds on most distros until the next release. Looks like Peppermint is based on Debian Bookworm, so I'd expect the [build instructions](https://github.com/xiota/geany-preview/blob/main/docs/Building_on_Linux.md) to work with minimal changes. If not, feel free to open a new issue on the project page. In terms of features, it's basically complete. I don't intend to turn it into a general web browser. The problem is the code isn't very maintainable. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1282#issuecomment-2078571791 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
> `g_file_new_for_uri()` and `g_file_read()` (or
> `g_file_read_async()/g_file_read_finish()`
It works...
```C
#include
#include
int main() {
GFile *file = g_file_new_for_uri("https://geany.org/service/version/;);
GError *error = NULL;
GFileInputStream *stream = g_file_read(file, NULL, );
if (!error) {
printf("No error.\n");
guint8 *buffer = NULL;
gsize size = 0;
buffer = (guint8 *)g_malloc(32);
gboolean success = g_input_stream_read_all((GInputStream *)stream, buffer,
32, , NULL, );
if (success) {
buffer[size] = '\0';
printf("Data: %s\n", buffer);
} else {
printf("Error reading stream.\n");
}
} else {
printf("Error reading uri.\n");
}
return 0;
}
```
```bash
$ gcc test.c -o test $(pkgconf --libs gio-2.0) $(pkgconf --cflags gio-2.0)
$ ./test
No error.
Data: 2.0.0
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078546850
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)
I have a plugin that shows a [preview](https://github.com/xiota/geany-preview) of several lightweight markup types... It needs refactoring... but works well enough. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1282#issuecomment-2077438240 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
@xiota commented on this pull request. > @@ -26,9 +26,9 @@ Prominent features Requirements -This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18), -GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to -work. If you intend to build it yourself, you will need to get the development +This plugin requires GTK3, GLib (>= 2.22), GIO (>= 2.18), GdkPixbuf (>= 2.0), +WebKit2GTK (either API 4.0 or 4.1), and obviously Geany (>= 0.20) to work. What was the first version of Geany supporting GTK 2.x? Is it necessary to mention Geany version? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#discussion_r1579595352 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
@xiota commented on this pull request.
> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
}
-static void update_check_result_cb(SoupSession *session,
-SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+gsize bytes_size = g_bytes_get_size(bytes);
+gchar *str = g_malloc(bytes_size + 1);
+memcpy(str, g_bytes_get_data(bytes, NULL), bytes_size);
I see... thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#discussion_r1578857604
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
@b4n Thanks... I've squashed the commits. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#issuecomment-2076289869 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
@xiota commented on this pull request.
> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
}
-static void update_check_result_cb(SoupSession *session,
-SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+gsize bytes_size = g_bytes_get_size(bytes);
+gchar *str = g_malloc(bytes_size + 1);
+memcpy(str, g_bytes_get_data(bytes, NULL), bytes_size);
I don't know any version of libsoup, but wondering why wrap
`g_bytes_get_data()` with another function and memcopy that has to be freed
later, rather than `g_bytes_get_data()` directly, and letting `g_bytes_unref()`
take care of it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#pullrequestreview-2021421076
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
@xiota pushed 1 commit. c8d5d229d73c2ddcbcfcca3fd3557f77c74d3d94 Markdown: Update version numbers -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1335/files/4003ca4cd882cdfb44cd86749d1c4630b0c10c56..c8d5d229d73c2ddcbcfcca3fd3557f77c74d3d94 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
Add support for webkit2gtk-4.1. Drop support for webkitgtk. Related: #1295 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1335 -- Commit Summary -- * Markdown: Allow building with webkit2gtk-4.1 * Markdown: Remove webkitgtk support -- File Changes -- M build/markdown.m4 (12) M markdown/src/Makefile.am (4) M markdown/src/viewer.c (33) M markdown/src/viewer.h (6) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1335.patch https://github.com/geany/geany-plugins/pull/1335.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
* Loads and seems to function when built with either webkit2gtk 4.0 or 4.1. * Key bindings all work when conditions for their function are met. * The reload on save function works. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#issuecomment-2074474371 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Use luaL_Reg instead of luaL_reg (PR #1231)
This was a straightforward find/replace to update the name of a struct. It is a necessary precursor to other updates/fixes of this plugin. Please merge. Thank you. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1231#issuecomment-2074156447 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)
So... checking availability of any library on the oldest Ubuntu LTS release should be sufficient? For webkit2gtk, there are a couple discontinued functions that probably need to be updated. Ubuntu 20.04 could be supported with conditional compilation, but if there will be no new geany/plugins release before 20.04 is EOL, there wouldn't be much point. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2073962383 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)
@elextr In a comment somewhere, you mention you're on an LTS distro without access to webkit2gtk-4.1? So I can look up what libraries you have available, what distro and release is it? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2073916851 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
I don't use this plugin, but can test it to help facilitate its update if provided a list of things to check. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#issuecomment-2073071561 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)
So... waiting until 2025, when Ubuntu 20.04 is EOL, so can use [g_string_replace()](https://github.com/geany/geany-plugins/pull/1128#issuecomment-954651043)? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2073015248 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
Changed the options and how they interact because I wanted to see what it would be like. * scrollwheel_lines (4): Number of lines for normal scrolling. Still don't know how to get the system default. * scrollwheel_alt_factor (6): Multiplier when alt is pressed, instead of pgup/pgdown. This is like a scrolling accelerator. Users can set it to scroll less than a full page so that context from jump to jump is still visible. * scrollwheel_ctrl_lines (4): Number of lines to scroll when control is pressed, when it doesn't activate zooming. Fine scrolling is easier if set to a low number, like 1. * scrollwheel_ctrl_zoom (T): Whether ctrl+scroll = zoom. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#issuecomment-2053968372 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
@xiota pushed 1 commit. 33e4ade264f5f09f3c886c60a08eb263847159eb Change filtering algorithm, add more options -- View it on GitHub: https://github.com/geany/geany/pull/3835/files/f6efbf6b55862187bfcfbb58c00ce209258cbc6b..33e4ade264f5f09f3c886c60a08eb263847159eb You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
@xiota commented on this pull request. > sci_scroll_columns(editor->sci, amount); return TRUE; } + else if (!event->state || (editor_prefs.scrollwheel_zoom_disable && (event->state & GDK_CONTROL_MASK))) If I want to remove the control mask, would either of the following work for mac? ``` event->state = event->state & !GDK_CONTROL_MASK; ``` ``` GdkModifierType modifiers = keybindings_get_modifiers(event->state); event->state = modifiers & !GDK_CONTROL_MASK; ``` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#discussion_r1564531191 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
@xiota commented on this pull request. > sci_scroll_columns(editor->sci, amount); return TRUE; } + else if (!event->state || (editor_prefs.scrollwheel_zoom_disable && (event->state & GDK_CONTROL_MASK))) I didn't understand the purpose earlier. It makes more sense now that I see it's to work around how Macs interpret some keys. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#discussion_r1564517036 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
@xiota commented on this pull request. > sci_scroll_columns(editor->sci, amount); return TRUE; } + else if (!event->state || (editor_prefs.scrollwheel_zoom_disable && (event->state & GDK_CONTROL_MASK))) Some existing code will need to be revised then. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#discussion_r1564402004 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
> Why is it transforming ctrl+scroll to scroll differently ... instead of doing > nothing ...? The mouse wheel would look broken if scrolling stopped when control is accidentally pressed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#issuecomment-2053866926 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
@xiota commented on this pull request. > @@ -2681,6 +2681,9 @@ indent_hard_tab_width The size of a tab > character. Don't change8 editor_ime_interactionInput method editor (IME)'s candidate 0 to new window behaviour. May be 0 (windowed) or documents 1 (inline) +scrollwheel_lines Number of lines the scrollwheel scrolls 3 immediately I miscounted and the historical value when mouse wheels were introduced to consumers was 3. So I didn't bother recounting to confirm. Would be better to use the system default, but I don't know how. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#discussion_r1564398663 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
@xiota commented on this pull request.
> +void sci_scroll_lines(ScintillaObject *sci, gint lines)
+{
+ SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines);
+}
+
+
Same could be said of...
https://github.com/geany/geany/blob/a44df8bb570e5d43f882649826e5d34ca3907a63/src/sciwrappers.c#L1015-L1018
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3835#discussion_r1564392814
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)
Closed #2954. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#event-12457795627 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
This PR adds two options to control scrollwheel behavior. * `scrollwheel_lines`: How many lines to scroll. * `scrollwheel_zoom_disable`: To disable zooming by control + scrollwheel. Control of vertical scrolling is taken away from Scintilla to provide consistent behavior when the control key is or is not pressed. Lines option added because I dont see a way to get or set the value used by Scintilla. Supersedes #2954 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3835 -- Commit Summary -- * Add option to block scroll-wheel zooming * Add option to change number of scroll lines -- File Changes -- M doc/geany.txt (3) M src/editor.c (18) M src/editor.h (2) M src/keyfile.c (4) M src/sciwrappers.c (6) M src/sciwrappers.h (1) -- Patch Links -- https://github.com/geany/geany/pull/3835.patch https://github.com/geany/geany/pull/3835.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)
@elextr Should unlocking zoom levels to be in a separate PR, or okay to bundle with the option to turn off scroll-wheel zooming? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#issuecomment-2052742604 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)
@elextr I'll look into your suggestion. Assuming it works well, should it go into a new PR or modify this one? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#issuecomment-2050940140 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)
@elextr Probability of getting this reviewed/merged if I rebase and update for current git head? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#issuecomment-2050874954 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add a 1px black border around the tab-switcher (Issue #3797)
I see now. Yes, different popup. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3797#issuecomment-2017027850 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add a 1px black border around the tab-switcher (Issue #3797)
Unknown reason, the tab switcher dialog on my computer is named GeanyDialog, and the CSS I pasted does work. Maybe the switcher dialog should be assigned a name (GeanyDialogSwitcher?) so that it can be styled more easily after the next release. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3797#issuecomment-2016970972 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add a 1px black border around the tab-switcher (Issue #3797)
I found the name "GeanyDialog". Maybe following should be added to default
`geany.css` because the existing dialog (at least on my computer) is a
borderless rectangle that blends in with the background.
```
#GeanyDialog {
border-width: 2px;
border-style: solid;
border-color: black;
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3797#issuecomment-2016955115
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Add option and keybinding to hide menubar (PR #2972)
> none of the Geany-plugins devs had enough interest in those capabilities or > enough time available at that point to examine it Features that devs have no interest in have low chance of being added. This applies to most projects. Would rather devs evaluate bug fix PRs than new features few others want. There are other ways to hide the menu bar: * Global / dbus menus and libraries. Plasma 5/6 have one included. XFCE has a widget that can be added to the panel. I've seen packages for other desktops, but have not tested them. * Via a script with the GeanyLua plugin. > so now nobody can try it at all The plugin is still available in its own repo (link in comment to PR). GitHub also keeps records of all PRs that sufficiently motivated users can use to build. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2972#issuecomment-1996188190 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Support for LuaJIT and Lua 5.1-5.4 (PR #1238)
Rebased on master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1238#issuecomment-1754075288 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Support for LuaJIT and Lua 5.1-5.4 (PR #1238)
@xiota pushed 4 commits. 73f8ff294f5130892f9637d848e199f235b15354 GeanyLua: Use luaL_Reg instead of luaL_reg e99bc00050722d343e9419e68adf39421657d22d GeanyLua: Don't ignore with-lua-pkg configure option 53cc8414a2227eb9ca1d2e840a90d3d52e671e52 GeanyLua: Add support for Lua 5.2+ d2a8537f474bfc63707dd4030d2e5779c02280d7 GeanyLua: Add compatibility for Lua 5.1 and LuaJIT -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1238/files/76dc5277a4688a30210d6587164e805ca96074d6..d2a8537f474bfc63707dd4030d2e5779c02280d7 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update Scintilla to version 5.3.6 (PR #3551)
[0001-Fix-assertion-failure-on-some-system-when-an-INDIC_S.patch.gz](https://github.com/geany/geany/files/12593500/0001-Fix-assertion-failure-on-some-system-when-an-INDIC_S.patch.gz) See: * [geany-plugins#1272](https://github.com/geany/geany-plugins/issues/1272) * [scintilla/652df8](https://sourceforge.net/p/scintilla/code/ci/652df80a41a010f404be51410d921f2df8b7175a/). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3551#issuecomment-1716942320 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)
@nyamatongwe
When I tested, I put the conditional return statement before the
`PLATFORM_ASSERT` line:
```
void SurfaceImpl::DrawRGBAImage(PRectangle rc, int width, int height, const
unsigned char *pixelsImage) {
if (width == 0) return;
PLATFORM_ASSERT(context);
```
I noticed in your commit that you put it after. What if the `PLATFORM_ASSERT`
is the origin of the abort?
```
void SurfaceImpl::DrawRGBAImage(PRectangle rc, int width, int height, const
unsigned char *pixelsImage) {
PLATFORM_ASSERT(context);
+ if (width == 0)
+ return;
if (rc.Width() > width)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1272#issuecomment-1716834236
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)
Isn't that too convoluted? Creating a PR for a PR? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1272#issuecomment-1716788396 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)
Geany no longer aborts with `if (width == 0) return;` pasted on a new line after `scintilla/gtk/PlatGTK.cxx:610`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1272#issuecomment-1716487056 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)
I built and installed geany as a package, but looking through the [PKGBUILD](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=geany-git), don't see anything turning off debug. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1272#issuecomment-1714940210 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)
geany git/3787677de; without rebuilding plugins, same issue. Rebuilding geany-plugins 27af15f9 for geany-git (without reverts), same issue. Following obtained from this build. Configure output. ``` aclocal: installing 'build/cache/glib-gettext.m4' from '/usr/share/aclocal/glib-gettext.m4' aclocal: installing 'build/cache/intltool.m4' from '/usr/share/aclocal/intltool.m4' aclocal: installing 'build/cache/libtool.m4' from '/usr/share/aclocal/libtool.m4' aclocal: installing 'build/cache/ltoptions.m4' from '/usr/share/aclocal/ltoptions.m4' aclocal: installing 'build/cache/ltsugar.m4' from '/usr/share/aclocal/ltsugar.m4' aclocal: installing 'build/cache/ltversion.m4' from '/usr/share/aclocal/ltversion.m4' aclocal: installing 'build/cache/lt~obsolete.m4' from '/usr/share/aclocal/lt~obsolete.m4' aclocal: installing 'build/cache/nls.m4' from '/usr/share/aclocal/nls.m4' aclocal: installing 'build/cache/pkg.m4' from '/usr/share/aclocal/pkg.m4' libtoolize: putting auxiliary files in '.'. libtoolize: copying file './ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build/cache'. libtoolize: copying file 'build/cache/libtool.m4' libtoolize: copying file 'build/cache/ltoptions.m4' libtoolize: copying file 'build/cache/ltsugar.m4' libtoolize: copying file 'build/cache/ltversion.m4' libtoolize: copying file 'build/cache/lt~obsolete.m4' You should update your 'aclocal.m4' by running aclocal. configure.ac:14: warning: The macro `AC_PROG_CC_C99' is obsolete. configure.ac:14: You should run autoupdate. ./lib/autoconf/c.m4:1659: AC_PROG_CC_C99 is expanded from... configure.ac:14: the top level configure.ac:17: warning: The macro `AC_PROG_LIBTOOL' is obsolete. configure.ac:17: You should run autoupdate. build/cache/libtool.m4:100: AC_PROG_LIBTOOL is expanded from... configure.ac:17: the top level configure.ac:21: warning: The macro `GLIB_GNU_GETTEXT' is obsolete. configure.ac:21: You should run autoupdate. build/cache/glib-gettext.m4:366: GLIB_GNU_GETTEXT is expanded from... build/cache/glib-gettext.m4:466: AM_GLIB_GNU_GETTEXT is expanded from... build/i18n.m4:1: GP_I18N is expanded from... configure.ac:21: the top level configure.ac:21: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:21: You should run autoupdate. ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... build/cache/glib-gettext.m4:51: GLIB_LC_MESSAGES is expanded from... build/cache/glib-gettext.m4:366: GLIB_GNU_GETTEXT is expanded from... build/cache/glib-gettext.m4:466: AM_GLIB_GNU_GETTEXT is expanded from... build/i18n.m4:1: GP_I18N is expanded from... configure.ac:21: the top level configure.ac:21: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:21: You should run autoupdate. ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/headers.m4:89: _AC_CHECK_HEADER_COMPILE is expanded from... ./lib/autoconf/headers.m4:56: AC_CHECK_HEADER is expanded from... build/cache/glib-gettext.m4:150: GLIB_WITH_NLS is expanded from... build/cache/glib-gettext.m4:366: GLIB_GNU_GETTEXT is expanded from... build/cache/glib-gettext.m4:466: AM_GLIB_GNU_GETTEXT is expanded from... build/i18n.m4:1: GP_I18N is expanded from... configure.ac:21: the top level configure.ac:21: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:21: You should run autoupdate. ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/headers.m4:89: _AC_CHECK_HEADER_COMPILE is expanded from... ./lib/autoconf/headers.m4:56: AC_CHECK_HEADER is expanded from... build/cache/glib-gettext.m4:150: GLIB_WITH_NLS is expanded from... build/cache/glib-gettext.m4:366: GLIB_GNU_GETTEXT is expanded from... build/cache/glib-gettext.m4:466: AM_GLIB_GNU_GETTEXT is expanded from... build/i18n.m4:1: GP_I18N is expanded from... configure.ac:21: the top level configure.ac:21: warning: The macro `AC_OUTPUT_COMMANDS' is obsolete. configure.ac:21: You should run autoupdate. ./lib/autoconf/status.m4:1025: AC_OUTPUT_COMMANDS is expanded from... build/cache/glib-gettext.m4:150: GLIB_WITH_NLS is expanded from... build/cache/glib-gettext.m4:366: GLIB_GNU_GETTEXT is expanded from... build/cache/glib-gettext.m4:466: AM_GLIB_GNU_GETTEXT is expanded from... build/i18n.m4:1: GP_I18N is expanded from... configure.ac:21: the top level configure.ac:24: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:24: You should run autoupdate.
[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with ZWJ emojis (Issue #1272)
Note: Occurs when "Toggle spell check" option is enabled. Disabling the option, no crash. Same problem with 27af15f9 with reverts to allow use with Geany 1.38 (5e130960bc6b9f3b3158cdb35d27f6bba03ba3c5 and 01b19d2d401f49f220157f28cc5e53de491f71a9). Unable to build for Geany git/1.39 because Lua appears to require another Scintilla update. Language doesn't seem to matter. I tried en_AU, en_GB, en_US. Font setting for editor and symbol list don't seem to matter. Tried Hack, Noto Sans, Courier Prime. Installed emoji font is noto-fonts-emoji 20220920. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1272#issuecomment-1714843050 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] Spell Check plugin crashes with ZWJ emojis (Issue #1272)
Spell Check plugin crashes whenever I paste text containing: ️ or ️. I believe they are ZWJ emojis because searching for them in a search engine produces the following in the location bar: %EF%B8%8F %EF%B8%8F. Pasting the non-ZWJ versions, and , does not cause the plugin to crash. Using Geany/Geany plugins 1.38 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1272 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota pushed 1 commit. 5f6bf44a760c1470108225921bbe27fede592e88 Replace set-output with $GITHUB_OUTPUT -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/e831ca1eb3eec50fb1ab6095cb23e2a7d419de92..5f6bf44a760c1470108225921bbe27fede592e88 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
Changed to `actions/checkout@v3` and `actions/cache@v3` because of message: > Node.js 12 actions are deprecated. ... There are some more messages. > The `save-state` command is deprecated and will be disabled soon. Please > upgrade to using Environment Files. For more information see: > https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ > > The `set-output` command is deprecated and will be disabled soon. Please > upgrade to using Environment Files. For more information see: > https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1458597534 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota pushed 1 commit. e831ca1eb3eec50fb1ab6095cb23e2a7d419de92 Use actions/checkout@v3 and actions/cache@v3 in workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/01faecc2dde77f5b188f3d30d1317e9405b15c45..e831ca1eb3eec50fb1ab6095cb23e2a7d419de92 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Project Organizer: Add option to open current folder in file manager and terminal (PR #1126)
Force push to rebase on master and remove some extraneous files from unrelated plugins that were accidentally added to the commit. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1126#issuecomment-1457541666 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Project Organizer: Add option to open current folder in file manager and terminal (PR #1126)
@xiota pushed 1 commit. 7e86828684c07622f2c2387db1785c73a2b04c50 Project Organizer: Add ability to open file manager and terminal -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1126/files/6cd488ae7a872e0812c19257488dcb24f598ec20..7e86828684c07622f2c2387db1785c73a2b04c50 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Support for LuaJIT and Lua 5.1-5.4 (PR #1238)
@xiota pushed 1 commit. 76dc5277a4688a30210d6587164e805ca96074d6 Remove multiterm plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1238/files/f35cc080cf4bbc87335198304172403525a77ee3..76dc5277a4688a30210d6587164e805ca96074d6 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota pushed 1 commit. 01faecc2dde77f5b188f3d30d1317e9405b15c45 Remove more pieces of multiterm -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/47d383eef6f6b0869b61768275037f8dffa9816b..01faecc2dde77f5b188f3d30d1317e9405b15c45 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota pushed 1 commit. 47d383eef6f6b0869b61768275037f8dffa9816b Remove multiterm -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/271bb6008885595d868baf01ea62735f7261e82b..47d383eef6f6b0869b61768275037f8dffa9816b You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
I'll test a more complete removal of multiterm to see what happens. Can revert if it goes bad or otherwise unwanted. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1457404773 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
distcheck is evil: ``` config.status: error: cannot find input file: `multiterm/Makefile.in' ``` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1457402260 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
When I run distcheck locally (not using Ubuntu though), the problem is vala cannot find vte. Maybe there is a separate package that vala needs to use vte? The reason the `--disable-*` flags don't work is distcheck runs configure *after* whatever it's doing that's failing. I'm going to try disabling multiterm in `Makefile.am`. The lines are just commented out, so if multiterm is ever fixed, the lines can be easily restored. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1457394689 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota pushed 2 commits. 00ab93929840cf88b8d14b8d5f04eddc432500d6 Disable multiterm in Makefile.am 271bb6008885595d868baf01ea62735f7261e82b Revert "Workflow, disable: devhelp, geanypy, multiterm, webhelper" -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/a6ffdb5acfa36999b80676357667541c58662349..271bb6008885595d868baf01ea62735f7261e82b You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
> Thinking about it it makes sense that distcheck doesn't look at configure > options, it makes a tarball that is unconfigured (but _is_ `autogen.sh`ed). Is `autogen.sh` why multiterm is getting in there when it shouldn't? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1457362599 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota pushed 1 commit. a6ffdb5acfa36999b80676357667541c58662349 Workflow, disable: devhelp, geanypy, multiterm, webhelper -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/8567c5278da79cdc18746ac95bf4118b2ade0269..a6ffdb5acfa36999b80676357667541c58662349 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota commented on this pull request. > @@ -127,7 +127,7 @@ jobs: # markdown libmarkdown2-dev # markdown/webhelper -libwebkitgtk-3.0-dev +libwebkit2gtk-4.0-dev The Markdown plugin does work with `libwebkit2gtk-4.0-dev`. GeanyPy is gone for other reasons. I don't know about MultiTerm, I vaguely recall it had other issues. WebHelper, I understood was using an even older version of webkitgtk than Markdown. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#discussion_r1127231355 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota pushed 1 commit. 8567c5278da79cdc18746ac95bf4118b2ade0269 Remove devhelp and multiterm dependencies -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/afc78ddf6c32c3072b31b26bb53c687954bbda55..8567c5278da79cdc18746ac95bf4118b2ade0269 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
Getting a distcheck failure related to `vte`. It may not build anymore on Ubuntu 20.04 because it's not in the repository. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1457290925 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota commented on this pull request. > @@ -127,7 +127,7 @@ jobs: # markdown libmarkdown2-dev # markdown/webhelper -libwebkitgtk-3.0-dev +libwebkit2gtk-4.0-dev `libwebkit2gtk-4.0-dev` is the dependency being used in the current Ubuntu [`geany-plugins`](http://archive.ubuntu.com/ubuntu/pool/universe/g/geany-plugins/geany-plugins_1.38+dfsg-1build1.debian.tar.xz) package. `libwebkitgtk-3.0-dev` doesn't exist anymore after 18.04. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#discussion_r1127214618 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
@xiota pushed 1 commit. afc78ddf6c32c3072b31b26bb53c687954bbda55 Add back some dependencies to workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/d9e7c2340aab3af9356ad7c768ec40f2d4ee0c36..afc78ddf6c32c3072b31b26bb53c687954bbda55 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)
I recently saw this message after creating a pull request. This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on April 1st, 2023. For more details, see https://github.com/actions/runner-images/issues/6002 Linux Build GitHub Actions has encountered an internal error when running your job. CI Build: .github#L1 The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see https://github.com/actions/virtual-environments/issues/6002 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1239 -- Commit Summary -- * Update GitHub workflow to Ubuntu 20.04 -- File Changes -- M .github/workflows/build.yml (12) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1239.patch https://github.com/geany/geany-plugins/pull/1239.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Add support LuaJIT and Lua 5.2-5.4 (PR #1238)
@xiota pushed 2 commits. 284085ab12815064d48b1a078d7c26af7e35893c Revert "Update workflow to use libwebkit2gtk-4.0-dev" f35cc080cf4bbc87335198304172403525a77ee3 Update workflow to update markdown/webhelper to libwebkit2gtk-4.0-dev -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1238/files/11dbdbee32c5007f073ac0b9a6eae9d248548874..f35cc080cf4bbc87335198304172403525a77ee3 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Add support LuaJIT and Lua 5.2-5.4 (PR #1238)
@xiota pushed 1 commit. 11dbdbee32c5007f073ac0b9a6eae9d248548874 Update workflow to use libwebkit2gtk-4.0-dev -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1238/files/ca56d831e52a8dd25dd729f77347d58205f6864e..11dbdbee32c5007f073ac0b9a6eae9d248548874 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Add support LuaJIT and Lua 5.2-5.4 (PR #1238)
@xiota pushed 2 commits. a60783b5ea29d9765d01e3d3160979d400d08694 Revert "GeanyLua: Change order of lua package search" ca56d831e52a8dd25dd729f77347d58205f6864e Update workflow to use Ubuntu 20.04 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1238/files/eb2888b6a4d6bd0323c31b16940c2b73febe3940..ca56d831e52a8dd25dd729f77347d58205f6864e You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Add support LuaJIT and Lua 5.2-5.4 (PR #1238)
@xiota pushed 1 commit. eb2888b6a4d6bd0323c31b16940c2b73febe3940 GeanyLua: Change order of lua package search -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1238/files/59e3c1aa65cba7d42f435e8abd000653d1e4c9d6..eb2888b6a4d6bd0323c31b16940c2b73febe3940 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] GeanyLua: Add support LuaJIT and Lua 5.2-5.4 (PR #1238)
Extends [#1233](https://github.com/geany/geany-plugins/pull/1233) to add support for Lua 5.1 and LuaJIT by adding compatibility functions/defines. The build script is fixed to not ignore the `--with-lua-pkg` option and to recognize Lua variants: lua, lua53, lua54, lua52, luajit, lua51 (currently in this order). Systems that use a different basename will have to explicitly specify the name, eg lua5.1 or lua-5.1, during configure. To change variants, reconfigure and rebuild. ``` ./configure --with-lua-pkg=[lua] make -C geanylua clean make -C geanylua ``` Supercedes #1231, #1233, #1235. Resolves #1228, #1133. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1238 -- Commit Summary -- * GeanyLua: Use luaL_Reg instead of luaL_reg * GeanyLua: Dont ignore with-lua-pkg configure option * GeanyLua: Add support for Lua 5.2+ * GeanyLua: Add compatibility for Lua 5.1 and LuaJIT -- File Changes -- M build/geanylua.m4 (28) M geanylua/Makefile.am (2) M geanylua/glspi.h (2) M geanylua/glspi_app.c (4) A geanylua/glspi_compat.c (55) A geanylua/glspi_compat.h (28) M geanylua/glspi_dlg.c (6) M geanylua/glspi_doc.c (4) M geanylua/glspi_init.c (4) M geanylua/glspi_kfile.c (10) M geanylua/glspi_run.c (30) M geanylua/glspi_sci.c (6) M geanylua/gsdlg_lua.c (11) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1238.patch https://github.com/geany/geany-plugins/pull/1238.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1238 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
> ... performance issues... I will ask someone who is having some performance issues while using some GeanyLua scripts whether he's willing to try LuaJIT to see if there's any noticeable difference. But I think the problem is that the computer is just slow. > True, and https://github.com/geany/geany-plugins/pull/1235 suggests the > changes are simple enough that both 5.1 and 5.4 C APIs could be supported > within the #ifdef pain threshold. As a wise man once said, if offered a > questionable choice, take all three (at least until a winner is clear). I'd request that adding support for 5.4, be deferred until late in 1.39 development or even a future release. This would make backporting bug fixes prior to the transition easier (eg, if a 1.38.1 bugfix branch were created). For instance, fixes for geany.activate (#1234) and geany.keygrab (#1236) can be applied to 1.38 with unmodified git-generated patches. #1235 itself would require more work to backport and would complicate backporting any subsequently written bugfix. (Is there a git command to extract only commits/patches that apply to one plugin/folder?) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1455390647 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix geany.keygrab (PR #1236)
@xiota pushed 1 commit. 3c2e16a9d5834b1f153a2557ac819386481a9c2e Use g_signal_handler_disconnect instead of g_clear_signal_handler -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1236/files/b061ff8aa1ef04402905339ad655043564d07207..3c2e16a9d5834b1f153a2557ac819386481a9c2e You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] GeanyLua: Fix geany.keygrab (PR #1236)
* Make platform agnostic * Fix infinite loop * Update documentation Resolves #1230. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1236 -- Commit Summary -- * GeanyLua: Fix geany.keygrab -- File Changes -- M geanylua/docs/geanylua-ref.html (57) M geanylua/glspi_app.c (188) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1236.patch https://github.com/geany/geany-plugins/pull/1236.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1236 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
> I just tried and on my other linux VM geanylua with the PR runs with Lua 5.4 > without any modifications needed. I saw that note. The problem is the Lua language changes between versions. And there may be subtle API differences that work fine on the C side, but result in different Lua execution results. So if different platforms are using different versions of Lua, say 5.3 and 5.4, the scripts won't necessarily be compatible. Also, existing Lua 5.1 scripts may break. > I'm not really convinced by the performance argument - I just don't see how > anyone would notice. The whole Geany except Scintilla lexers and ctags > parsers could be written in a scripting language and I don't think anyone > would notice any performance difference. Whether someone notices depends on how performant their hardware is. I've seen Geany touted as being suitable for use on low-end hardware. At least a few such users would notice. > ... by adding JIT you make from a nice little interpreter a beast which > introduces its own set of problems like CPU/OS/architecture dependence. I'm > not sure how LuaJIT's JIT works but since most of the scripts will be > short-running, it could make the execution of the scripts slower if it > performs JIT compilation every time and doesn't store the precompiled binary > somewhere. LuaJIT can run without JIT (as I understand, this is the default). According to benchmarks others have run, the LuaJIT interpreter, without JIT, runs faster than the Lua interpreter. > I suspect users of this plugin will use it for smaller utilities related to > their workflow and they won't use any advanced features from the language > where they might see differences. Based on code snippets posted online, changes in Lua behavior can be surprising. Even if something breaking is unlikely, it would be highly disruptive to the workflows of users who do experience problems. If not using advanced features, why switch to Lua 5.4 rather than add LuaJIT build support? > Anyway, my personal preference would be using pure Lua but I'm fine if others > have a different opinion and the LuaJIT patch gets merged. Adding LuaJIT build support now doesn't in and of itself block work toward supporting another Lua release in the future. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1455268327 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
@techee I tried migrating to 5.4 shortly before this issue was opened. I got it to compile, but segfaults on load. Maybe gave up to quickly. I did not know about LuaJIT at the time. Stepwise migration would have been easier, but the distro I was using at the time made that difficult. Problems with 5.3 and 5.4: * 5.3 is yet another deprecated branch. * 5.3 is not very popular, by package count. * 5.4 is not in your distro. (As old as it already is, really?) * Potential incompatibility with existing scripts (especially number handling). * GeanyLua will be unable to use LuaJIT in the future. Will be stuck with Lua and it's incompatible releases. Benefits of LuaJIT over 5.4 are: * Better performance. * Continued compatibility with existing Lua scripts. * FFI to call C functions from Lua. (But scripts using it will not be compatible with Lua 5.1.) * Almost as popular as 5.4, by package count. * Can fallback on Lua 5.1 if needed. Can change course in the future for 5.4/5.5 if desired. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1455237627 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua has an X11 dependency (Issue #1230)
`geany.keygrab()` doesn't work on X11. Looks like the callback function either
doesn't return or doesn't set the flag to signal that a key has been pressed.
Built and tested with both Lua 5.1 and LuaJIT with same result. Example Lua
code:
```
geany.status("keygrab - start")
key = geany.keygrab()
geany.status(key)
geany.status("keygrab - end")
```
Status window shows only:
```
keygrab - start
```
Keyboard input continues to be sent to the editor. Geany has to be force
closed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1230#issuecomment-1455210392
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix with-lua-pkg configure flag, Add option to use LuaJIT (PR #1233)
@xiota pushed 1 commit. c809d427536fde732937fdb8bbe3967fa5dd8ba9 GeanyLua: Add note about build default to NEWS file: -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1233/files/5df759949d148cd80b90ccf7b79ace5a7312536f..c809d427536fde732937fdb8bbe3967fa5dd8ba9 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix with-lua-pkg configure flag, Add option to use LuaJIT (PR #1233)
> ... the default should stay lua5.1... Done. > We can document that it will change in the release after... Is that something I should change/add to this PR? The `NEWS` file? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1233#issuecomment-1454965504 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix with-lua-pkg configure flag, Add option to use LuaJIT (PR #1233)
@xiota pushed 1 commit. 5df759949d148cd80b90ccf7b79ace5a7312536f GeanyLua: Build with Lua 5.1 by default, fallback to LuaJIT -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1233/files/96d39df306b9d03c027cbddcc0d258312265382c..5df759949d148cd80b90ccf7b79ace5a7312536f You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
> Yeah, I didn't understand the importance (or not) of those so I hoped a > Geanylua user could comment. I don't really know. But the changes in number handling seem significant and potentially able to cause problems in unexpected places. For instance, number handling changes, along with changes in the Geany API, are related to why `geany.activate` wasn't working. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1454960101 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
> But again, aren't we just complicating our lives with this unnecessarily? > Why having two different dependencies doing basically the same when the > current Lua 5.1 works fine? * There are people who do not use or work on GeanyLua (eg, fix bugs) because it is using an obsolete branch of Lua. * Supporting multiple packages can expose bugs. For instance, #1233 fixes a bug where `--with-lua-pkg=` was previously completely ignored. > I have a macbook with this processor already and I provide macOS binaries of > Geany... if geanylua is added (I've just managed to get it running), will > probably crash when the plugin is enabled (have to try what happens exactly). If GeanyLua crashes on Mac with Lua 5.1, there is no change in plugin availability whether LuaJIT is used or not. If GeanyLua works on Mac with Lua 5.1, but not LuaJIT, it can be built with Lua 5.1 either by autodetection or setting the `--with-lua-pkg` flag (which currently isn't working, but is fixed by #1233). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1454920751 You are receiving this because you are subscribed to this thread. Message ID:
