Re: UiBinder: ClientBundle with ImageResource ui:style. How?

2010-09-07 Thread marius.andreiana
On Sep 7, 5:53 am, Andrew Hughes ahhug...@gmail.com wrote:
 Seems like I can kinda answer two of these questions myself now...

 Q: How can loader1.gwt-image be loading.gif?

 ui:with type=blah.client.MyClientBundle field=cb/
 ui:image field=loading resource={cb.loading}/
 ui:style
   �...@sprite .loader1 {
        gwt-image: 'loading';
        padding-left: value('loading.getWidth','px');
        width: auto;
        height: auto;}

 /ui:style
You can also do it with less code:
ui:image field=loading src=loading.gif/


 The problem with this is that if (loading.gif  MyClientBundle) are in a
 different package/directory to that of the ui.xml BOOM!  
It certainly works for me with
ui:image field=loading src=path-to-image/loading.gif/
or
ui:with field='res' type='com.blah.client.Resources'/


 Q: How can loader3.margin-left be loading.gif.width?

 as above...  padding-left: value('loading.getWidth','px');
See 
http://groups.google.com/group/google-web-toolkit/browse_thread/thread/df5db4040f1f5c76/b3ee0f84cd372eb1?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



GWT 2.x/Jboss/Seam gen

2010-09-07 Thread Flori
Hey all,

did someone manage to run a seam generated application with gwt
compilied sources in hosted mode on JBoss?

http://community.jboss.org/wiki/UseJBossToolswithGoogleGWTPlugin  -
does not help really in my case - its the wrong order ;) I already
have my application and want to ADD a gwt application. So it's all
working fine - i can include my gwt module into a xhtml view - but i
don't know how i can use the hosted mode since my files are placed in
the generated view folder instead of the default gwt war folder! Can
someone point me in the right direction? Thanks a lot!

greetings!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: problems with auto-complete form login

2010-09-07 Thread Magnus
On 6 Sep., 19:59, Thomas Broyer t.bro...@gmail.com wrote:
 But honestly, I don't understand how this design is any different from
 redirecting to the login page (unless maybe you have a cancel button
 that leaves you in the app, i.e. without reload)

Well, from my point of view it would be nice if the login form is
visually integrated into my app. I managed to size and center the
iframe so that it just opens as a popup.

However, I now have an external login page, totally outside of GWT,
but I am not happy with all that. First, my app  loads. Then, when I
request the login, it unloads and loads the external login page, and
then, after login, my app loads again. This is a very time consuming
process. And the login page itself does not fit into the visual design
of the app at all...

I wonder why we have to research on this topic. It must be a problem
that almost all GWT developers must also have. Why isn't there a
generic recommendation, or even a solution within GWT? I have the
feeling that we are inventing some wheels here.

As I already said, I am totally unhappy with this solution, and I hope
some GWT developers point me/us into a better direction someday...

Magnus

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: showing all the elements from SuggestOracle in suggestionBox

2010-09-07 Thread Santosh kumar
Hi ,

I am adding the items to the suggestoracle on onmodule load. Its working
fine if the match is found for the key pressed (alphabet) .
But i want to show *all Existing Items* from the suggestoracle when their is
no match found for the key pressed (alphabet) by the user ???

Pls let me know if any one knows the solution ..!!



On Fri, Aug 13, 2010 at 7:19 PM, ctasada ctas...@gmail.com wrote:

 You can send me a private message attaching the source of your class,
 so I can take a look.

 I'm using it in my code without problems.

 On Aug 13, 6:33 am, aditya sanas 007aditya.b...@gmail.com wrote:
  Hello,
 
  yes you are right we dont have direct access to SuggestBox Popups.
 
  I have already extended SuggestOracle and have overridden method
 
  requestSuggestion(request,callback);
 
  code for the following as follows :
 
  public class StartsWithSuggestOracle extends SuggestOracle
  {
 //...  some other code...
 
  *@Override*
  *public void requestSuggestions(Request request, Callback callback) *
  *{ *
  *final List suggestions =
  computeItemsFor(request.getQuery().toLowerCase(),request.getLimit()); *
  *Response response = new Response(suggestions); *
  *callback.onSuggestionsReady(request, response); *
  *} *
 
  }
 
  and the underlined method computeItemsFor(); returns me the suggestions
  based upon request so as per my
 
  logic if request contains no character that is an empty string  i have
  returned all suggestions from oracle object.
 
  so here i m able to get this response correctly but i m nt getting wht
  should be done next with this response.
 
  from where i should give a call to this method and how that list get
  populated.
 
  I have followed that link suggested by you but that was the same
 mechanism
  that used there.
 
  so i m lil confuse why its not showing the response.
 
  --
  Aditya
 
  On Thu, Aug 12, 2010 at 5:50 PM, ctasada ctas...@gmail.com wrote:
   Hi Aditya,
 
   The problem is that you don't have direct access to the SuggestBox
   popup.
 
   If you want to see all the possible solutions you should extend the
   SuggestOracle and implement your own requestSuggestions method (see
   this link for some nice examples:http://development.lombardi.com/?p=39
 )
 
   In this way yo can simply return all your list, even ignoring the
   limit.
 
   Regards,
   Carlos.
 
   On Aug 12, 10:50 am, Aditya 007aditya.b...@gmail.com wrote:
hi,
 
I want to show all elements from the suggestoracle whenever
suggestionbox recieves a focus.
 
I did some search for it and i found something as follows :
 
   
 http://groups.google.com/group/google-web-toolkit/browse_thread/threa...
 
Now i m able to recieve Response
 
this.getSuggestOracle().requestSuggestions(request, new Callback() {
@Override
public void onSuggestionsReady(Request request, Response response) {
// here I m getting complete list from suggestoracle
}
 
});
 
I am able to get list of suggestions in this response but i dnt knw
what should i do next...?
 
what should be done with this response how this will help me to
populate suggestions...?
 
Thank you.
 
--
Aditya
 
   --
   You received this message because you are subscribed to the Google
 Groups
   Google Web Toolkit group.
   To post to this group, send email to
 google-web-tool...@googlegroups.com.
   To unsubscribe from this group, send email to
   google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 google-web-toolkit%2bunsubscr...@googlegroups.comgoogle-web-toolkit%252bunsubscr...@googlegroups.com
 
   .
   For more options, visit this group at
  http://groups.google.com/group/google-web-toolkit?hl=en.

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
Thanks  Regards

*S a n t o s h  k u m a r . k*

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



GWT + Spring - different functionality development approach

2010-09-07 Thread M. Eduard
Hi,
Say I have Spring web application. Some functionality where I need
JavaScript is developed using GWT under  Eclipse. What is the approach
of project organizing ? As I see for each functionality I need, for
example some menu, tree-menu, some widgets, I must create each
separate project, then compile to JS and copy-paste to my Spring
application? How to manage this development process better way?
Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: problems with auto-complete form login

2010-09-07 Thread Magnus
Just for the completeness: I recall what was the problem with the GWT
integration:

As I said I had an iframe with the src attribute pointing to a
separate html file with the login form. Then, to inject the JS code
for form submission I needed to wrap the form. But I did not get
access to the iframe's DOM...

Just for the completeness... I am still unhappy... :-/

Magnus

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Memory Leak IE7 GWT 2.0.4

2010-09-07 Thread chrisr
Does the issue that you're working on now give you any reason to
believe it could be an issue in the browser as well, under some
similar circumstances?

On Sep 3, 2:18 pm, Chris Conroy con...@google.com wrote:
 Okay, well if it's *in* hosted mode (read: the JVM), then it's a known issue
 that I'm working on at the moment.

 On Fri, Sep 3, 2010 at 3:00 PM, chrisr chris.robert.rowl...@gmail.comwrote:

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



how to transmit an image over rpc?

2010-09-07 Thread Magnus
Hi,

I tried to pass an Image object via RPC, but it doesn't work:

com.google.gwt.user.client.ui.Image is not assignable to
'com.google.gwt.user.client.rpc.IsSerializable' or
'java.io.Serializable' nor does it have a custom field serializer
(reached via com.google.gwt.user.client.ui.Image

How can I do that?

Magnus

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



how to use modal dialog boxes?

2010-09-07 Thread Magnus
Hi,

I want to use a modal DialogBox and used setModal.

The GUI makes it modal, but my code after dialog.center (); gets
executed immediately.

How can I do it so that code execution waits? Must I do this with
asynchronous calls? Can you give an example?

The application is a chess game. When a pawn reaches the last row, the
user should first select a figure (queen, rook, ...), and the move
should not be completed before this selection has finished...

Thanks
Magnus

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



declaring both a GWT and a javascript event handler on a html element

2010-09-07 Thread GWT noob
When I declare a event handler on a html element both at the GWT
level(using ClickHandler's onclick)  and at the external Javascript
levele(by using the onlclick attribute of the html element), the GWT
event handler is overriding the event handler in the external
javascript. Is there a way to have both these event handlers run on a
successful event.

thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



DisclosurePanel, class-name content

2010-09-07 Thread Jaroslav Záruba
Hello

There is one quite unfortunate class-name in the DisclosurePanel DOM. The
widget serving for content gets class-name content assigned. Such generic
name is very collision prone, which situation I'm currently facing.
Is there any special reason why this element did not get gwt-prefixed
class-name as the rest has?

Regards
  J. Záruba

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: unable to add gwt sdk

2010-09-07 Thread Nirav Joshi
hi Vik
I think the sufficient help is available on the Google's Site.
Wouldn't it sufficient to resolve your issue ?

Thanks and Regards
Nirav Joshi

On Mon, Sep 6, 2010 at 10:56 PM, Vik vik@gmail.com wrote:

 Hie

 gwt sdk is missing in my project and when i try to add there is a red cross
 on it. if i go to eclipse add new software and add it errors out saying 2.04
 gwt is already installed.
 please advise how to resolve it.

 Thankx and Regards

 Vik
 Founder
 www.sakshum.com
 www.sakshum.blogspot.com

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
*Thanks and Regards
Nirav Joshi*

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Upgrading from GWT 1.4 to 2.0

2010-09-07 Thread Jesper Christensen
I am trying to upgrade a GWT 1.4 application to 2.0 but I am having a
problem with the welcome file.

The 1.4 application uses a servlet as the welcome file. The servlet
checks the user credentials and forwards to the HTML page that loads
the GWT application if the user has the right credentials.

I have been trying to do the same with the GWT 2.0 version but no
matter what I put as the welcome file the HTML page is always loaded,
never the servet.

Is this not possible any more or is there a trick to make it work?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Calling methods from GWT script in existing HTML

2010-09-07 Thread Søren Kyndi-Wiuff
Or better yet, do it the cool way:

http://code.google.com/p/gwt-exporter/

Cheers
Søren

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



How to block click event?

2010-09-07 Thread ulgerang
Hi,

I am making 'ImageButton' that extends 'Image' and implemented
'HasEnabled' interface.
I made 3 state, disable,mouseover, enable.
When I was making disable,  I have to block the click event  from the
widget.
but  I couldn't find the way.

Is there any way to block the click event?



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Expenses Sample project

2010-09-07 Thread superdama
Hi guys,

I got the same issue. Still don't know how to solve the problem.
Frustrating.

-Zack



On Aug 25, 9:22 pm, tc camec...@gmail.com wrote:
 Does anyone know why I would get this error when trying to run the
 samples/expensesapp via maven.

 : java.lang.NoClassDefFoundError: org/datanucleus/
 PersistenceConfiguration
  java.lang.NoClassDefFoundError: Could not initialize class
 com.google.gwt.sample.expenses.server.domain.EMF

 I am running this by using these commands.

 mvncompilemvngwt:compilemvngwt:run

 I also tried to usemvngae:run  but get the same error.

 This is the sample project in the trunk of the GWT samples area.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



com.google.gwt.user.client.rpc.SerializationException

2010-09-07 Thread Costa
Please help with error below.

Is this mean that the class com.voxbone.voxAPI.Country could not be
serialize or it is just simple
NoClassDefFoundError ?

Exception while dispatching incoming RPC call
com.google.gwt.user.client.rpc.SerializationException: Type
'org.dozer.MappingException' was not included in the set of types
which can be serialized by this SerializationPolicy or its Class
object could not be loaded. For security purposes, this type will not
be serialized.: instance = org.dozer.MappingException:
java.lang.NoClassDefFoundError: Could not initialize class
com.voxbone.voxAPI.Country
at
com.google.gwt.user.server.rpc.impl.ServerSerializationStreamWriter.serialize(ServerSerializationStreamWriter.java:
610)
at
com.google.gwt.user.client.rpc.impl.AbstractSerializationStreamWriter.writeObject(AbstractSerializationStreamWriter.java:
129)
at
com.google.gwt.user.server.rpc.impl.ServerSerializationStreamWriter
$ValueWriter$8.write(ServerSerializationStreamWriter.java:152)
at
com.google.gwt.user.server.rpc.impl.ServerSerializationStreamWriter.serializeValue(ServerSerializationStreamWriter.java:
534)
at com.google.gwt.user.server.rpc.RPC.encodeResponse(RPC.java:
609)
at
com.google.gwt.user.server.rpc.RPC.encodeResponseForFailure(RPC.java:
383)
at
com.google.gwt.user.server.rpc.RPC.invokeAndEncodeResponse(RPC.java:
581)
at
com.google.gwt.user.server.rpc.RemoteServiceServlet.processCall(RemoteServiceServlet.java:
188)
at
com.google.gwt.user.server.rpc.RemoteServiceServlet.processPost(RemoteServiceServlet.java:
224)
at
com.google.gwt.user.server.rpc.AbstractRemoteServiceServlet.doPost(AbstractRemoteServiceServlet.java:
62)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:
710)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Require Help to have multiple HTML Pages with one Entrypoint in my GWT App

2010-09-07 Thread Nirav Joshi
Hi all
i am new user of the GWT app.
I want help from you guys to guide me for having multiple html/jsp
page with one entry point.
Let us i want to have two pages page1.html,page2.html.
page1.html is a login page.
when i logged in then it should redirect to page2.html.

How will i do it with the help of GWT ?

Thanks and Regards
Nirav Joshi

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Authorization/Authentication in GWT

2010-09-07 Thread Arachnida
Hello,

I'm currently developing a Spring/GWT application most things are
going just fine but I've experienced some troubles integrating with
Spring Security. It looks like there is no way to install global
handlers for asyncCallback failures to handle 401/403 errors. As I've
found there's currently two ways of integrating:

1. Check for error code in every onFailure handler of my
asyncCallbacks. Looks pretty ugly to me, the only way to fix is to
abstract asyncCallback and implement onSecondFailure as a method that
will be called from onFailure

2. Upcoming RequestFactory that is not yet stable as I understood
(still in developement)

So, the question: is there any best practice to enable security in
GWT apps? I believe it needs to be XSRF-proof, handle session-timeout,
401/403 status codes from service calls.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



GWT - database, authentication, session

2010-09-07 Thread pionas
Hi,

i would like to create a login panel, when i must enter username and
password. Next I check if the data are correct. When the data are
correct I reload home page and I see message Hi username! etc
When I refresh site i logged on.

Now I have something like this:
Test.java (default):
public void onModuleLoad() {
// Lets add a grid to hold all our widgets
Grid grid = new Grid(4, 2);
//Set the error label
grid.setWidget(0,1, lblError);
//Add the Label for the username
grid.setWidget(1,0, new Label(Username));
//Add the UserName textBox
grid.setWidget(1,1, txtLogin);
//Add the label for password
grid.setWidget(2,0, new Label(Password));
//Add the password widget
grid.setWidget(2,1, txtPassword);
//Create a button
Button btnLogin=new Button(login);
btnLogin.addClickHandler(new ClickHandler() {
public void onClick(ClickEvent event) {
sendNameToServer();
}
});

//Add the Login button to the form
grid.setWidget(3,1, btnLogin );
RootPanel.get().add(grid);
}

private void sendNameToServer() {
errorLabel.setText();
// First, we validate the input.
String login = txtLogin.getText();
String pass = txtPassword.getText();

// Then, we send the input to the server.
getService().greetServer(login, pass, 
GWT.getHostPageBaseURL(),
new AsyncCallbackLoginInfo() {
public void 
onFailure(Throwable error) {
// Show the RPC 
error message to the user

errorLabel.setText(Error);
}

public void 
onSuccess(LoginInfo result) {
loginInfo = 
result;
if(loginInfo.isLoggedIn()) {
RootPanel.get().clear();
errorLabel.setText(You are logged);
RootPanel.get().add(errorLabel);
} else {
errorLabel.setText(Login failed);
}

}
});
}

private GreetingServiceAsync getService() {
GreetingServiceAsync greetingService = 
(GreetingServiceAsync) GWT
.create(GreetingService.class);
ServiceDefTarget endpoint = (ServiceDefTarget) 
greetingService;

endpoint.setServiceEntryPoint(GWT.getModuleBaseURL() + login);

return greetingService;
}

GreetingService.java (client)
public interface GreetingService extends RemoteService {
public LoginInfo greetServer(String login, String pass, String
requestUri);
}

GreetingServiceAsync.java (client)
public interface GreetingServiceAsync {
public void greetServer(String login, String pass, String requestUri,
AsyncCallbackLoginInfo async);
}


GreetingServiceImpl.java (server)
public class GreetingServiceImpl extends RemoteServiceServlet
implements GreetingService {

/**
 *
 */
private static final long serialVersionUID = 1L;

public LoginInfo greetServer(String login, String pass, String
requestUri) {
LoginInfo loginInfo = new LoginInfo();

Connection myCon;
Statement myStmt;
try{
  Class.forName(com.mysql.jdbc.Driver).newInstance();
  myCon = DriverManager.getConnection(jdbc:mysql://localhost/
isr, root,root);
  myStmt = myCon.createStatement();
  ResultSet result = myStmt.executeQuery(SELECT * FROM users
WHERE login=\+login+\ and pass=\+pass+\ ORDER by login ASC
limit 1);
  loginInfo.setLoggedIn(true);
  result.last();
  if (result.getRow()0) {
  loginInfo.setLoggedIn(true);
  loginInfo.setEmailAddress(result.getString(mail));
  loginInfo.setLogoutUrl(requestUri);
  loginInfo.setNickname(result.getString(login));
  myCon.close();
  } else {
  loginInfo.setLoggedIn(false);
  loginInfo.setLoginUrl(requestUri);
  }
}
 

GWT + Spring 3.0 + hibernate references and easy guides

2010-09-07 Thread aces2805
Hi, I'm just new with GWT would like to ask if there are some
references that I can follow in integrating spring 3.0 and hibernate
with gwt. The usual sites that I go in uses maven, well I just think I
just need a plain and simple example. Hope some of you guys can help
me. Really appreciate it ... thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Almost impossible to extend CellTable

2010-09-07 Thread legion
Hi all

I checked out the code for gwt 2.1, i wanted to see the last changes
in the CellTable component. A nice addition is the SafeHtmlTemplate.
But one drawback of the current implementation of the CellTable
component is that you cannot reuse the code from the CellTable by
extending it. For example i would like to benefit from the rowspan and
colspan parameters of the tag td, or to build a more customizable
table. From my point of view this is impossible as the columns are
defined as private, and I wouldn’t be able to use them from my
subclass or somehow to change the table template.  It would be great
if I would be able to reuse the code, otherwise i would need to copy
the same functionality.

What is your opinion?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Issue with using com.google.gwt.xml.client package with GWT 1.5.3

2010-09-07 Thread Nik
Hello,

I am trying to use the com.google.gwt.xml.client module with my
GWT-1.5.3.
I want to basically fetch data, from an XML File and store it in a
document.
Document document = XMLParser.parse(xmlContent);
XMLParser.removeWhitespace(document);

Everything works fine in Hosted mode.
In the web mode, it works fine in Firefox and IE.
But somehow with Google Chrome I face the following issue.
I am trying to access an attribute in the XML file, and it turns out
to be empty in Chrome.(The only way I can confirm this is, I am
writing back to an xml file, and the relevant attribute is set to
empty).

Has anybody faced this issue before?

Also, how can I debug my code in web mode.

Thank you for your help.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Adding headings to a RichTextArea

2010-09-07 Thread HenrikA
Hi,

I have this problem that is nearly driving me crazy.
We need a RichTextEditor that will give us some basic functionality
like the RichTextArea combined with the RichTextToolbar from the
examples give us. But we have one requirement that is not met by the
example, and that is the possibility to add headings (H1, H2, ...)
Just adding the tags could easily be done using the insertHTML
functionality, but that would not make it possible to resemble the
normal behaviour of an editor that would enclose the current paragraph
inside the heading, whilst just adding the tags would split the text.

Any ideas on how to do this?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Cross Site Requests for JSON : Invalid Label

2010-09-07 Thread kudos
I have followed the steps here: 
http://code.google.com/webtoolkit/doc/1.6/tutorial/Xsite.html
to create a call to another server for JSON data.

Firebug shows an invalid label error when i run the application.

I had a search for solutions and all I could find was things about
adding parenthesis around the json string in the eval function.

I do not use the eval function and the json is not a string - it is a
JavaScriptObject.

Has anyone else found a solution to this?


Thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Dynamic Tree (RPC calls for nodes)

2010-09-07 Thread pksiazek
Hi.

I'm trying to implement dynamic tree.
During creation it contains only root node.
When I click open - it fetch nodes data via RPC call.

How I can pass information to which parent I should add nodes?
I defined AsyncCallback handler to parse response, but it has no
access to parent node.
I was trying to pass TreeItem object, but it's not serializable.


Regards
pksiazek

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: how to use modal dialog boxes?

2010-09-07 Thread Thomas Broyer


On Sep 7, 3:28 pm, Magnus alpineblas...@googlemail.com wrote:
 Hi,

 I want to use a modal DialogBox and used setModal.

 The GUI makes it modal, but my code after dialog.center (); gets
 executed immediately.

modal != blocking

The only blocking dialogs are Window.alert, Window.confirm and
Window.prompt (IE has had a showModalDialog for long, which is now
being standardized at the W3C http://www.w3.org/TR/html5/
timers.html#dom-showmodaldialog and is implemented in Firefox 3 and
recent WebKit –works in Chrome 7-dev and Safari 5.0.1 on Windows– but
still not Opera, and don't expect support in older WebKits –I think we
can just ignore Firefox 2 nowadays?–, not to mention that it loads
another HTML page, which makes things a bit harder to work with).

 How can I do it so that code execution waits? Must I do this with
 asynchronous calls? Can you give an example?

Modal just means you cannot interact with the rest of the page/
application, but it's still just a dialog box (i.e. a div –or is it
a table?– with position:absolute and some top/left/width/height
values) that needs to handle events (which is how you'd listen to...
events from the box; no asynchronous call, just event handlers)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT + Spring - different functionality development approach

2010-09-07 Thread lmolinero
Hi, Why don't you just use multiple gwt modules in the same GWT
proyect in eclipse.
One module for each functionality, i mean.


On Sep 7, 8:51 am, M. Eduard emoroz...@gmail.com wrote:
 Hi,
 Say I have Spring web application. Some functionality where I need
 JavaScript is developed using GWT under  Eclipse. What is the approach
 of project organizing ? As I see for each functionality I need, for
 example some menu, tree-menu, some widgets, I must create each
 separate project, then compile to JS and copy-paste to my Spring
 application? How to manage this development process better way?
 Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Expenses Sample project

2010-09-07 Thread Travis Camechis
try running tools/scripts/maven_script.sh from the root of the GWT
checkout.  This will build a current copy of GWT and them to your local
maven repo.  You should then be able to do a mvn compile, mvn
gwt:compile, mvn gw:run.

On Sun, Sep 5, 2010 at 9:08 AM, superdama zack...@gmail.com wrote:

 Hi guys,

 I got the same issue. Still don't know how to solve the problem.
 Frustrating.

 -Zack



 On Aug 25, 9:22 pm, tc camec...@gmail.com wrote:
  Does anyone know why I would get this error when trying to run the
  samples/expensesapp via maven.
 
  : java.lang.NoClassDefFoundError: org/datanucleus/
  PersistenceConfiguration
   java.lang.NoClassDefFoundError: Could not initialize class
  com.google.gwt.sample.expenses.server.domain.EMF
 
  I am running this by using these commands.
 
  mvncompilemvngwt:compilemvngwt:run
 
  I also tried to usemvngae:run  but get the same error.
 
  This is the sample project in the trunk of the GWT samples area.

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: How to get Scaffold GWT in STS to run Dev server -i tried to copy link and run on local browser

2010-09-07 Thread Thomas Broyer


On Sep 6, 8:26 am, blueJ lawsearch...@gmail.com wrote:
 http://127.0.0.1:/ApplicationScaffold.html?gwt.codesvr=127.0.0.1:...

 Here is what happened--for me--this is not trivial--thanks

 Loading modules
    com.lawo.demo1.gwt.ApplicationCommon
       Loading inherited module 'com.google.gwt.app.App'
          Loading inherited module 'com.google.gwt.user.User'
             Loading inherited module 'com.google.gwt.core.Core'
                Loading inherited module 'com.google.gwt.core.XSLinker'
                   [ERROR] Line 22: Unexpected element 'when-linker-
 added'

You're probably not using the appropriate (latest) version of GWT
(i.e. gwt-dev version older than gwt-user version in this case, with
gwt-dev being pre-2.1 AFAICT)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: How to block click event?

2010-09-07 Thread Chad
Instead of trying to block the event, why not just eat it. In your
widget, on the click event, check the state of the widget. If the
state is enable, only then fire the click event to any registered
listeners.

HTH,
Chad

On Sep 6, 10:06 am, ulgerang ulger...@gmail.com wrote:
 Hi,

 I am making 'ImageButton' that extends 'Image' and implemented
 'HasEnabled' interface.
 I made 3 state, disable,mouseover, enable.
 When I was making disable,  I have to block the click event  from the
 widget.
 but  I couldn't find the way.

 Is there any way to block the click event?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



change css without reload the page

2010-09-07 Thread jimmy6
How to change CSS without reload the page?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Removing / Adding nested LayoutPanels from DockLayoutPanel

2010-09-07 Thread Maurice
Hi,

I have a UIBinder that looks like this:

  g:DockLayoutPanel unit='EM'
g:north size='12'
   g:HorizontalPanel
  g:LabelSome/g:Label
  g:LabelStuff/g:Label
   /g:HorizontalPanel
/g:north
g:center
   g:AContainerToHoldLayoutPanels ui:field=centerContainer
my:MyDockLayoutPanel/
   /g:AContainerToHoldLayoutPanels
/g:center
  /g:DockLayoutPanel

The idea is that from the java code I can call:

   centerContainer.clear();
   centerContainer.add(myTotallyDifferentSplitLayoutPanel);

However I cannot figure out what AContainerToHoldLayoutPanels should
be. Any tips?! Is this even possible?

Thanks!

Maurice

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Memory Leak IE7 GWT 2.0.4

2010-09-07 Thread Chris Conroy
No. This particular issue is isolated to the DevMode JVM.

On Tue, Sep 7, 2010 at 8:18 AM, chrisr chris.robert.rowl...@gmail.comwrote:

 Does the issue that you're working on now give you any reason to
 believe it could be an issue in the browser as well, under some
 similar circumstances?

 On Sep 3, 2:18 pm, Chris Conroy con...@google.com wrote:
  Okay, well if it's *in* hosted mode (read: the JVM), then it's a known
 issue
  that I'm working on at the moment.
 
  On Fri, Sep 3, 2010 at 3:00 PM, chrisr chris.robert.rowl...@gmail.com
 wrote:

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
Chris Conroy
Software Engineer
Google, Atlanta

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: declaring both a GWT and a javascript event handler on a html element

2010-09-07 Thread Chris Conroy
You could have your GWT handler call your javascript handler using JSNI.

On Mon, Sep 6, 2010 at 12:42 PM, GWT noob karthik.ele...@gmail.com wrote:

 When I declare a event handler on a html element both at the GWT
 level(using ClickHandler's onclick)  and at the external Javascript
 levele(by using the onlclick attribute of the html element), the GWT
 event handler is overriding the event handler in the external
 javascript. Is there a way to have both these event handlers run on a
 successful event.

 thanks

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
Chris Conroy
Software Engineer
Google, Atlanta

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Strange behaviour

2010-09-07 Thread Tanguy Le Barzic
Hi Jeff,

I did try to use it, but I still need to know the position of the element I
want the popup to appear below. It's when I try to find this position that
the problem arises (due to scrolling apparently not taken into account).

-- 
Tanguy

2010/9/6 Jeff Chimene jchim...@gmail.com

 On 09/05/2010 04:53 PM, Tanguy Le Barzic wrote:
  Hi Thomas,
 
  Thanks for your answer. I tried your solution, with the exact same
  results :(.
  I think the problem comes from Window.getScrollTop() (which is used
  in  position(final UIObject relativeObject, int offsetWidth,
int offsetHeight) ). This function always return 0 in Firefox,
  even when I scroll the page.
 
  I managed to fix it by using the following custom javascript native
  function :
 
  public final native int getScrollTop() /*-{
return $wnd.pageYOffset;
  }-*/;
 
  However, I'm afraid it won't be cross-browser. Could it be a bug in the
  implementation of Window.getScrollTop() for Firefox (at least for the
  version I'm using, 3.6.8) ?
 
  --
  Tanguy

 Why aren't you using setPopupPositionAndShow() ?

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT + Spring - different functionality development approach

2010-09-07 Thread M. Eduard
Hm, seems I didn't noticed this thing. Thanks for advice.

On Sep 7, 5:03 pm, lmolinero lmolin...@gmail.com wrote:
 Hi, Why don't you just use multiple gwt modules in the same GWT
 proyect in eclipse.
 One module for each functionality, i mean.

 On Sep 7, 8:51 am, M. Eduard emoroz...@gmail.com wrote:

  Hi,
  Say I have Spring web application. Some functionality where I need
  JavaScript is developed using GWT under  Eclipse. What is the approach
  of project organizing ? As I see for each functionality I need, for
  example some menu, tree-menu, some widgets, I must create each
  separate project, then compile to JS and copy-paste to my Spring
  application? How to manage this development process better way?
  Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT + Spring 3.0 + hibernate references and easy guides

2010-09-07 Thread M. Eduard
Hibernate will be integrated withing your Spring application. So I
think you should first learn Spring if going use one... As GWT
application in result is no more than JavaScript, GWT will never know
anything about hibernate.

On Sep 7, 11:16 am, aces2805 ace...@gmail.com wrote:
 Hi, I'm just new with GWT would like to ask if there are some
 references that I can follow in integrating spring 3.0 and hibernate
 with gwt. The usual sites that I go in uses maven, well I just think I
 just need a plain and simple example. Hope some of you guys can help
 me. Really appreciate it ... thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Removing / Adding nested LayoutPanels from DockLayoutPanel

2010-09-07 Thread Thomas Broyer


On Sep 7, 5:34 pm, Maurice maurice.ocon...@gmail.com wrote:
 Hi,

 I have a UIBinder that looks like this:

   g:DockLayoutPanel unit='EM'
         g:north size='12'
            g:HorizontalPanel
               g:LabelSome/g:Label
               g:LabelStuff/g:Label
            /g:HorizontalPanel
         /g:north
     g:center
            g:AContainerToHoldLayoutPanels ui:field=centerContainer
                 my:MyDockLayoutPanel/
            /g:AContainerToHoldLayoutPanels
     /g:center
   /g:DockLayoutPanel

 The idea is that from the java code I can call:

    centerContainer.clear();
    centerContainer.add(myTotallyDifferentSplitLayoutPanel);

 However I cannot figure out what AContainerToHoldLayoutPanels should
 be. Any tips?! Is this even possible?

You can use a simple LayoutPanel; but you could also (to limit the
number of widgets you use, and because you're dealing with the center
pane here) keep track of the center panel, and remove() it from your
DockLayoutPanel before add()ing the new one:
   dock.remove(currentCenterPanel);
   doc.add(myTotallyDifferentSplitLayoutPanel);
   currentCenterPanel = myTotallyDifferentSplitLayoutPanel;

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: How to block click event?

2010-09-07 Thread Thomas Broyer

On Sep 6, 5:06 pm, ulgerang ulger...@gmail.com wrote:
 Hi,

 I am making 'ImageButton' that extends 'Image' and implemented
 'HasEnabled' interface.
 I made 3 state, disable,mouseover, enable.
 When I was making disable,  I have to block the click event  from the
 widget.
 but  I couldn't find the way.

 Is there any way to block the click event?

Why aren't you using a CustomButton in the first place?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT with GAE Blobstore

2010-09-07 Thread App Engine Notifications
Here's a sample project I'm working on that does an upload to blobstore as
well as uses the high performance image serving framework:

http://github.com/ikai/gwt-gae-image-gallery

Warning: This is still a work in progress, but the upload/image serving bits
are there.

On Mon, Sep 6, 2010 at 9:54 AM, Brandon Donnelson
branflake2...@gmail.comwrote:


 Here is what I did to upload: http://demofileuploadgae.appspot.com/ - demo

 http://code.google.com/p/gwt-examples/source/browse/trunk/DemoUpload/ -
 Source Code

 Brandon Donnelson


 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT with GAE Blobstore

2010-09-07 Thread Ikai Lan
Here's a sample project I'm working on that does an upload to
blobstore as well as uses the high performance image serving
framework:

http://github.com/ikai/gwt-gae-image-gallery

Warning: This is still a work in progress, but the upload/image
serving bits are there.

On Sep 6, 9:54 am, Brandon Donnelson branflake2...@gmail.com wrote:
 Here is what I did to upload:http://demofileuploadgae.appspot.com/- demo

 http://code.google.com/p/gwt-examples/source/browse/trunk/DemoUpload/- Source 
 Code

 Brandon Donnelson

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT + Spring 3.0 + hibernate references and easy guides

2010-09-07 Thread George Georgovassilis
The answer is not that easy. You can bring hibernate managed objects
(almost) transparently to GWT applications, have a look at Gilead [1]
Much has been said about Spring and GWT, a quick forum search will
surely bring something up


[1] http://noon.gilead.free.fr/gilead/index.php?page=gwt

On Sep 7, 6:32 pm, M. Eduard emoroz...@gmail.com wrote:
 Hibernate will be integrated withing your Spring application. So I
 think you should first learn Spring if going use one... As GWT
 application in result is no more than JavaScript, GWT will never know
 anything about hibernate.

 On Sep 7, 11:16 am, aces2805 ace...@gmail.com wrote:

  Hi, I'm just new with GWT would like to ask if there are some
  references that I can follow in integrating spring 3.0 and hibernate
  with gwt. The usual sites that I go in uses maven, well I just think I
  just need a plain and simple example. Hope some of you guys can help
  me. Really appreciate it ... thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Require Help to have multiple HTML Pages with one Entrypoint in my GWT App

2010-09-07 Thread Deepak Singh
Hi Nirav

Just right click on project(Eclipse IDE) and create new html. It
auotomatically configures this new html. Now u can put div element here
and then
RootPanel.get(div id).add() will work.

Regards
Deepak

On Sun, Sep 5, 2010 at 9:08 PM, Nirav Joshi joshi.nira...@gmail.com wrote:

 Hi all
 i am new user of the GWT app.
 I want help from you guys to guide me for having multiple html/jsp
 page with one entry point.,



 Let us i want to have two pages page1.html,page2.html.
 page1.html is a login page.
 when i logged in then it should redirect to page2.html.

 How will i do it with the help of GWT ?

 Thanks and Regards
 Nirav Joshi

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



How to add a widget to a CaptionPanel?

2010-09-07 Thread Kiarash
CaptionPanel panel = new CaptionPanel(myWidget) which is not
possible... only String and HTML is possible.
How can I add a widget as a CheckBox to a caption of a CaptionPanel?

Thank you for any suggestion

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Problems with gwt plugin and eclipse

2010-09-07 Thread TBirch
Hi Rajeev,

I have the same error using either eclipse or Springsource Sts with
Roo. I am not sure if any of what follows helps but these two sections
are from my error log.
Thanks, Terry


java.lang.ClassCastException: org.eclipse.jdt.internal.core.JavaModel
cannot be cast to org.eclipse.jdt.core.IJavaProject
at
org.eclipse.jdt.internal.launching.RuntimeClasspathEntry.getLocation(RuntimeClasspathEntry.java:
428)
at
org.eclipse.jdt.launching.JavaRuntime.computeDefaultRuntimeClassPath(JavaRuntime.java:
1375)
at com.google.gwt.eclipse.core.runtime.GWTRuntime
$ProjectBoundSdk.createClassLoader(GWTRuntime.java:88)
at
com.google.gwt.eclipse.core.runtime.GWTRuntime.containsSCL(GWTRuntime.java:
484)
at
com.google.gwt.eclipse.core.validators.GWTProjectValidator.build(GWTProjectValidator.java:
89)
at org.eclipse.core.internal.events.BuildManager
$2.run(BuildManager.java:629)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at
org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:
172)
at
org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:
203)
at org.eclipse.core.internal.events.BuildManager
$1.run(BuildManager.java:255)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at
org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:
258)
at
org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:
311)
at
org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:
343)
at
org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:
144)
at
org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:
242)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
 
-

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal org.apache.maven.plugins:maven-resources-plugin:
2.4.2:resources (default-resources) on project gwtroo: Execution
default-resources of goal org.apache.maven.plugins:maven-resources-
plugin:2.4.2:resources failed: Unable to load the mojo 'resources' in
the plugin 'org.apache.maven.plugins:maven-resources-plugin:2.4.2'. A
required class is missing: org/apache/maven/shared/filtering/
MavenFilteringException
-
realm =pluginorg.apache.maven.plugins:maven-resources-plugin:
2.4.2
strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
urls[0] = file:/C:/Users/terry/.m2/repository/org/apache/maven/plugins/
maven-resources-plugin/2.4.2/maven-resources-plugin-2.4.2.jar
urls[1] = file:/C:/Users/terry/.m2/repository/org/codehaus/plexus/
plexus-utils/1.5.15/plexus-utils-1.5.15.jar
urls[2] = file:/C:/Users/terry/.m2/repository/junit/junit/3.8.1/
junit-3.8.1.jar
urls[3] = file:/C:/Users/terry/.m2/repository/org/apache/maven/shared/
maven-filtering/1.0-beta-4/maven-filtering-1.0-beta-4.jar
urls[4] = file:/C:/Users/terry/.m2/repository/org/codehaus/plexus/
plexus-interpolation/1.13/plexus-interpolation-1.13.jar
Number of foreign imports: 4
import: Entry[import org.codehaus.plexus.util.xml.pull.XmlSerializer
from realm ClassRealm[plexus.core, parent: null]]
import: Entry[import
org.codehaus.plexus.util.xml.pull.XmlPullParserException from realm
ClassRealm[plexus.core, parent: null]]
import: Entry[import org.codehaus.plexus.util.xml.pull.XmlPullParser
from realm ClassRealm[plexus.core, parent: null]]
import: Entry[import org.codehaus.plexus.util.xml.Xpp3Dom from realm
ClassRealm[plexus.core, parent: null]]
Number of parent imports: 20
import: Entry[import org.codehaus.plexus.personality from realm null]
import: Entry[import org.codehaus.plexus.logging from realm null]
import: Entry[import org.codehaus.plexus.lifecycle from realm null]
import: Entry[import org.codehaus.plexus.context from realm null]
import: Entry[import org.codehaus.plexus.container from realm null]
import: Entry[import org.codehaus.plexus.configuration from realm
null]
import: Entry[import org.codehaus.plexus.component from realm null]
import: Entry[import org.codehaus.plexus.classworlds from realm null]
import: Entry[import org.codehaus.plexus.PlexusContainerException from
realm null]
import: Entry[import org.codehaus.plexus.PlexusContainer from realm
null]
import: Entry[import org.codehaus.plexus.PlexusConstants from realm
null]
import: Entry[import org.codehaus.plexus.MutablePlexusContainer from
realm null]
import: Entry[import
org.codehaus.plexus.DuplicateChildContainerException from realm null]
import: Entry[import org.codehaus.plexus.DefaultPlexusContainer from
realm null]
import: Entry[import org.codehaus.plexus.DefaultContainerConfiguration
from realm null]
import: Entry[import org.codehaus.plexus.DefaultComponentRegistry from
realm null]
import: Entry[import 

Re: showing all the elements from SuggestOracle in suggestionBox

2010-09-07 Thread ciosbel
Instead defining your own oracle (which is, indeed, the best
solution), just use a MultiWordSuggestOracle.
There you can find methods like:

setDefaultSuggestions(CollectionSuggestOracle.Suggestion
suggestionList)
or
setDefaultSuggestionsFromText(Collectionjava.lang.String
suggestionList)

You can simply add suggestions to you oracle (oracle.add ...) and then
use one of the above to set default suggestions.
Now, using yourSuggestBoxInstance.showSuggestionList(), *all* your
suggestions will popup.
Remember that the oracle that provides suggestion and the default set
you specified using one of the above are two different things, with
two different purposes. So, if your list of suggestions will change in
future (i.e. after a clear/add in the oracle) just remember to reset
the defaults.

If you want to display them *all* on textbox focus...

yourSuggestBoxInstance.getTextBox().addFocusHandler(new FocusHandler()
{
  public void onFocus(FocusEvent event) {
// showing all default suggestions
yourSuggestBoxInstance.showSuggestionList();
  }
});

Do note also, that with 2.1 milestones the interface of the suggestbox
has been slightly changed. In particular you can now define your own
display for the popup, and use it instead of the default (and a bit
old) one. The custom popup can be defined by either extending
SuggestBox.SuggestionDisplay (if you start from zero), or
SuggestBox.DefaultSuggestionDisplay if you want to start from the
default one.

Hope it helps.

cios.
On 7 Set, 12:46, Santosh kumar kopp@gmail.com wrote:
 Hi ,

 I am adding the items to the suggestoracle on onmodule load. Its working
 fine if the match is found for the key pressed (alphabet) .
 But i want to show *all Existing Items* from the suggestoracle when their is
 no match found for the key pressed (alphabet) by the user ???

 Pls let me know if any one knows the solution ..!!



 On Fri, Aug 13, 2010 at 7:19 PM, ctasada ctas...@gmail.com wrote:
  You can send me a private message attaching the source of your class,
  so I can take a look.

  I'm using it in my code without problems.

  On Aug 13, 6:33 am, aditya sanas 007aditya.b...@gmail.com wrote:
   Hello,

   yes you are right we dont have direct access to SuggestBox Popups.

   I have already extended SuggestOracle and have overridden method

   requestSuggestion(request,callback);

   code for the following as follows :

   public class StartsWithSuggestOracle extends SuggestOracle
   {
      //...  some other code...

   *   �...@override*
   *    public void requestSuggestions(Request request, Callback callback) *
   *    { *
   *        final List suggestions =
   computeItemsFor(request.getQuery().toLowerCase(),request.getLimit()); *
   *        Response response = new Response(suggestions); *
   *        callback.onSuggestionsReady(request, response); *
   *    } *

   }

   and the underlined method computeItemsFor(); returns me the suggestions
   based upon request so as per my

   logic if request contains no character that is an empty string  i have
   returned all suggestions from oracle object.

   so here i m able to get this response correctly but i m nt getting wht
   should be done next with this response.

   from where i should give a call to this method and how that list get
   populated.

   I have followed that link suggested by you but that was the same
  mechanism
   that used there.

   so i m lil confuse why its not showing the response.

   --
   Aditya

   On Thu, Aug 12, 2010 at 5:50 PM, ctasada ctas...@gmail.com wrote:
Hi Aditya,

The problem is that you don't have direct access to the SuggestBox
popup.

If you want to see all the possible solutions you should extend the
SuggestOracle and implement your own requestSuggestions method (see
this link for some nice examples:http://development.lombardi.com/?p=39
  )

In this way yo can simply return all your list, even ignoring the
limit.

Regards,
Carlos.

On Aug 12, 10:50 am, Aditya 007aditya.b...@gmail.com wrote:
 hi,

 I want to show all elements from the suggestoracle whenever
 suggestionbox recieves a focus.

 I did some search for it and i found something as follows :

 http://groups.google.com/group/google-web-toolkit/browse_thread/threa...

 Now i m able to recieve Response

 this.getSuggestOracle().requestSuggestions(request, new Callback() {
 @Override
 public void onSuggestionsReady(Request request, Response response) {
                 // here I m getting complete list from suggestoracle
         }

 });

 I am able to get list of suggestions in this response but i dnt knw
 what should i do next...?

 what should be done with this response how this will help me to
 populate suggestions...?

 Thank you.

 --
 Aditya

--
You received this message because you are subscribed to the Google
  Groups
Google Web Toolkit group.
To post to this group, send email to
  

Re: Dev plugin for firefox 3.7

2010-09-07 Thread csillag
Hi John,

On aug. 11, 18:06, John Tamplin j...@google.com wrote:
 On Wed, Aug 11, 2010 at 10:46 AM, Chris Conroy con...@google.com wrote:
  The short answer is that after preliminary support went in, the supporting
  libraries changed upstream. Also, when the prelim support went in Windows
  dev libraries weren't even available. I think John has a change in the works
  to get this updated but is blocked on something.

 Just being on vacation much of the last two weeks and having other things in
 front of it.  I intend to update all the platforms for 4.0b2 this week.

Could you please give us some update on the current status?

I have just downloaded the 64-bit version of FF4.0 B5 from mozilla,
installed it (on my Debian system),
updated my plugin svn dirs,
built the plugin (w. BROWSER=ff40), installed it
(shows up registered as 1.0.8725M.20100908004741),
and tried to run a GWT app (running in Eclipse, GWT 2.0.4)...
...but I only got a warning about not supporting anythin above 3.5.

Could you please help me finding out what am I doing wrong?

Thank you for your help!

Kristof Csillag

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Can't Set App Engine SDK - Eclipse Plugin

2010-09-07 Thread sdoca
Hi,

I have been trying to set up a Maven/GWT/Eclipse project and keep
running into road blocks.  I have Eclipse 3.6 (Helios) with m2eclipse
and GWT plugins installed.  I was trying with Eclipse 3.5 (Galileo)
but thought I may have messed up some config thing and figured I'd
start clean and upgrade to Helios.  I get the same issue in both.

I have been trying to use this blog as a guide for setting up my
project:

http://googlewebtoolkit.blogspot.com/2010/08/how-to-use-google-plugin-for-eclipse.html

I have a project set up in the standard Maven directory structure.  I
created a new Eclipse project and used this as the existing source
(deleted .project, .classpath and .settings that were created in
Galileo).  I then ran the mvn clean gae:unpack war:war and mvn
eclipse:clean eclipse:eclipse as per the blog.

When I go into the project properties and try to set the Google App
Engine to Use default SDK (App Engine - 1.3.7) and save, it doesn't
stick.  I go back in and it's still set at Use specific SDK which is
set to {userHome}\.m2\repository\com\google\appengine - unknown
version.  If I choose App Engine - 1.3.7 from the list and save, it
still reverts to the local repo unkown version.

When I check my Java Build Path, all the jars from the local repo are
listed.  I can delete them and save, but again, it doesn't stick.

I tried running the project to see what happens, and I get:

Exception in thread main java.lang.ExceptionInInitializerError
at
com.google.appengine.tools.info.SdkImplInfo.clinit(SdkImplInfo.java:
19)
at
com.google.appengine.tools.util.Logging.initializeLogging(Logging.java:
36)
at
com.google.appengine.tools.development.gwt.AppEngineLauncher.start(AppEngineLauncher.java:
72)
at com.google.gwt.dev.DevMode.doStartUpServer(DevMode.java:421)
at com.google.gwt.dev.DevModeBase.startUp(DevModeBase.java:1035)
at com.google.gwt.dev.DevModeBase.run(DevModeBase.java:783)
at com.google.gwt.dev.DevMode.main(DevMode.java:275)
Caused by: java.lang.RuntimeException: Unable to discover the Google
App Engine SDK root. This code should be loaded from the SDK
directory, but was instead loaded from file:{userHome}/.m2/repository/
com/google/appengine/appengine-tools-sdk/1.3.7/appengine-tools-
sdk-1.3.7.jar.  Specify -Dappengine.sdk.root to override the SDK
location.
at com.google.appengine.tools.info.SdkInfo.findSdkRoot(SdkInfo.java:
106)
at com.google.appengine.tools.info.SdkInfo.clinit(SdkInfo.java:24)
... 7 more

What gives??

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Cross Site Requests for JSON : Invalid Label

2010-09-07 Thread lineman78
In other words you are using JSONP client code to hit a JSON service.
Without more info I am assuming this is your problem.  In order to
make cross site requests using the method described on the page you
referenced you service needs to output JSONP, that is wrapping the
JSON with a call to the specified function; i.e. /test?
callback=testFunction would return
testFunction({testAttribute:testStringValue}).  Also, since 2.0
the JsonpRequestBuilder class is provided and you don't have to go
through as much trouble as you did in 1.6, which is what the referred
article is targeting.

http://google-web-toolkit.googlecode.com/svn/javadoc/2.0/com/google/gwt/jsonp/client/JsonpRequestBuilder.html

 I had a search for solutions and all I could find was things about
 adding parenthesis around the json string in the eval function.

 I do not use the eval function and the json is not a string - it is a
 JavaScriptObject.

This is true if you would like to use JSON directly if you are not
making a cross-site request.  you will sometimes need to wrap the JSON
returned by the service with {+jaonText+} if you use request
builder, which will return a string then you will have to make a
native method to call eval to translate that string into a javascript
object, but if you are making a cross-site request then you must use
the JsonpRequestBuilder.

On Sep 7, 7:31 am, kudos miss.michelle.dor...@googlemail.com wrote:
 I have followed the steps 
 here:http://code.google.com/webtoolkit/doc/1.6/tutorial/Xsite.html
 to create a call to another server for JSON data.

 Firebug shows an invalid label error when i run the application.

 I had a search for solutions and all I could find was things about
 adding parenthesis around the json string in the eval function.

 I do not use the eval function and the json is not a string - it is a
 JavaScriptObject.

 Has anyone else found a solution to this?

 Thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: How to block click event?

2010-09-07 Thread lineman78
you can try adding different handlers such as a click handler or mouse
down handler and call event.preventDefault().

On Sep 6, 9:06 am, ulgerang ulger...@gmail.com wrote:
 Hi,

 I am making 'ImageButton' that extends 'Image' and implemented
 'HasEnabled' interface.
 I made 3 state, disable,mouseover, enable.
 When I was making disable,  I have to block the click event  from the
 widget.
 but  I couldn't find the way.

 Is there any way to block the click event?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: DisclosurePanel, class-name content

2010-09-07 Thread lineman78
It is because content and header all both children of the gwt-
DisclosurePanel class and they expect you to use child selectors.
Here is what they expect you use so that you don't end up with
collisions:

.gwt-DisclosurePanel .content {
  border: 2px solid black;
}

On Sep 5, 11:08 am, Jaroslav Záruba jaroslav.zar...@gmail.com wrote:
 Hello

 There is one quite unfortunate class-name in the DisclosurePanel DOM. The
 widget serving for content gets class-name content assigned. Such generic
 name is very collision prone, which situation I'm currently facing.
 Is there any special reason why this element did not get gwt-prefixed
 class-name as the rest has?

 Regards
   J. Záruba

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Memory Leak IE7 GWT 2.0.4

2010-09-07 Thread ckendrick
Just a note on SmartGWT -

Built-in GWT widgets rely on the browser to garbage collect a detached
DOM tree.  In older browsers like IE6/7 we found a number of cases
where this didn't work completely, so we opted for manual destroy().
It's possible that as of IE8/9 all such leaks are gone (personally I
find this unlikely :), but, we're not really interested in finding
out.

And yes, we have tools that make leaks obvious - the Watch Tab in the
Developer Console, which shows a tree of all components.  You tend to
spot leaked components right away while using the tool for other
purposes.

On Sep 3, 5:12 am, Joel Webber j...@google.com wrote:
 @Marcos:
 I wish I could do more to help with memory leaks in SmartGWT, but
 that's way beyond the knowledge of anyone on our team. SmartGWT's a
 wrapper around a huge Javascript library that, from your earlier post,
 appears to require destroy() calls on widgets as part of its memory-
 leak strategy (IIUC). That strategy's rife with problems and very hard
 for users to get right in practice (I've tried it in other frameworks,
 and always found myself squashing leaks ad infinitum). Do the SmartGWT
 tools not provide some mechanism for tracing and finding leaks?

 On Aug 30, 9:10 am, chrisr chris.robert.rowl...@gmail.com wrote:

  This may be a valid solution, however its not an ideal one, as this
  application is already significantly large, and its not going to be
  easy to refactor all of the existing code to work this way.  It will
  be easy to keep this in mind while going forward, however.

  As I said above, I was trying to reproduce the way a lot of the code
  I'm working with has been written.  Also, while I thought this was
  reproducing the situation we are seeing in our live app (using GWT
  1.5.4) it turns out this only produces the memory leak in development
  mode using the most recent GWT.  I will have to see if this produces a
  leak when compiled using 1.5.4.  If not then I'll probably need to
  find a new simple case that reproduces the leak we're seeing.

  On Aug 28, 11:48 am, Michael W mwang_2...@yahoo.com wrote:

   I doubt following code causing the memory leak.
   In reloadRight method, you create and assign new DecoratedTabPanel()
   to tabPanel every time.

                   protected void reloadRight(){
                           ++rightPanelCount;
                           rPanel.clear();

                           tabPanel = new DecoratedTabPanel();

   You may reuse existing tabPanel instead of create new one.

   On Aug 27, 4:21 pm, chrisr chris.robert.rowl...@gmail.com wrote:

Hi Joel, i appreciate your help.

I was running in development mode and it appears that this memory
bloat goes away when not using development mode.
We have been developing our application using older GWT (1.5.4 I
belive) so I'm used to using the old hosted mode.  I didn't realize
the in browser development mode might have this side effect.

The goal of this was to reproduce a memory leak that we have in our
application (when compiled, of course) using as simple a case as
possible, in the newest version of GWT, if possible.  I erroneously
thought this was accomplishing that.

Does the fact that this growth occurs in development mode suggest
anything about why I might see similar growth in a compiled GWT 1.5.4
application?

On Aug 27, 12:52 pm, Joel Webber j...@google.com wrote:

 Hmm... I've tried to reproduce this on IE7 and IE8 (both quirks 
 standards), to no avail. I doubt it's anything in the outer HTML file,
 but just in case, here's what I used:

 !DOCTYPE HTML
 html
   head
     titleHello/title
     script type=text/javascript language=javascript src=hello/
 hello.nocache.js/script
   /head
   body
     div id='container'/div
   /body
 /html

 The initial calls to getSomeText() were causing a huge number of slow-
 script warnings on IE, so I was only able to run through a few
 iterations. I then dropped the count by a factor of 10 to get the SSWs
 under control, and the memory usage appears quite stable after a
 couple of hundred clicks. (~30MB). Can you think of anything else that
 might be different in your setup?

 On 27 août, 08:20, chrisr chris.robert.rowl...@gmail.com wrote:

  Sorry for posting this twice.  If a moderator wants to/can remove 
  the
  duplicate go ahead.

  On Aug 25, 2:56 pm, chrisr chris.robert.rowl...@gmail.com wrote:

   I created a simple application in an attempt to reproduce a memory
   leak issue in our decently large GWT application.

   This test application basically contains a split panel with a 
   button
   on the left, and a tab panel full of large blocks of text on the
   right.
   Clicking the reload button fires the reloadRight method, and does 
   a
   panel.clear() to remove the old tab panel and a  panel.add() to 
   

Problem of collecting GWT client Code coverage

2010-09-07 Thread Qi Zhang
We are trying to use the emma library to measure the code coverage of gwt
client code, our test case is driven by Selenium RC.

But we observed that some event handler code is never covered although we
are pretty sure the event is triggered and handled.

We did some hack to GWT source code and add some print code at
com.google.gwt.dev.shell.EmmaStrategy.java.

It is surprising that the PreinstrumentedEmmaStrategy did not select the
emma instrumented class sometimes, because the timestamp check failed.

(source code is newer than the instrumented code).

I suspect there is some bug there, but I am not sure.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Require Help to have multiple HTML Pages with one Entrypoint in my GWT App

2010-09-07 Thread suersh babu
Use Window.Location.assign(url) inside the gwt Entry point module so that
you can redirect to different page

Regards
Suresh Babu G

On Wed, Sep 8, 2010 at 12:19 AM, Deepak Singh deepaksingh...@gmail.comwrote:

 Hi Nirav

 Just right click on project(Eclipse IDE) and create new html. It
 auotomatically configures this new html. Now u can put div element here
 and then
 RootPanel.get(div id).add() will work.

 Regards
 Deepak

 On Sun, Sep 5, 2010 at 9:08 PM, Nirav Joshi joshi.nira...@gmail.comwrote:

 Hi all
 i am new user of the GWT app.
 I want help from you guys to guide me for having multiple html/jsp
 page with one entry point.,



 Let us i want to have two pages page1.html,page2.html.
 page1.html is a login page.
 when i logged in then it should redirect to page2.html.

 How will i do it with the help of GWT ?

 Thanks and Regards
 Nirav Joshi

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


  --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
Regards

Suresh Babu G

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: DisclosurePanel, class-name content

2010-09-07 Thread Jaroslav Záruba
When you're creating a component to existing web-site it is quite likely
someone has used the content class name. Therefore his CSS will merge with
your .gwt-DisclosurePanel .content.
There seem to be a naming convention in GWT. This just shows that there's a
good reason to have one.

On Wed, Sep 8, 2010 at 2:43 AM, lineman78 linema...@gmail.com wrote:

 It is because content and header all both children of the gwt-
 DisclosurePanel class and they expect you to use child selectors.
 Here is what they expect you use so that you don't end up with
 collisions:

 .gwt-DisclosurePanel .content {
  border: 2px solid black;
 }

 On Sep 5, 11:08 am, Jaroslav Záruba jaroslav.zar...@gmail.com wrote:
  Hello
 
  There is one quite unfortunate class-name in the DisclosurePanel DOM. The
  widget serving for content gets class-name content assigned. Such
 generic
  name is very collision prone, which situation I'm currently facing.
  Is there any special reason why this element did not get gwt-prefixed
  class-name as the rest has?
 
  Regards
J. Záruba

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: DisclosurePanel, class-name content

2010-09-07 Thread Jaroslav Záruba
On Wed, Sep 8, 2010 at 2:43 AM, lineman78 linema...@gmail.com wrote:

 It is because content and header all both children of the gwt-
 DisclosurePanel class and they expect you to use child selectors.
 Here is what they expect you use so that you don't end up with
 collisions:

 .gwt-DisclosurePanel .content {
  border: 2px solid black;
 }


In other words, this ^^^ does not address the issue.

Regards
  J. Záruba

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT + Spring 3.0 + hibernate references and easy guides

2010-09-07 Thread aces2805
I have look for some various approaches, i have also tried the one
posted in one of the forums, thanks to the link ^^

On Sep 8, 1:59 am, George Georgovassilis g.georgovassi...@gmail.com
wrote:
 The answer is not that easy. You can bring hibernate managed objects
 (almost) transparently to GWT applications, have a look at Gilead [1]
 Much has been said about Spring and GWT, a quick forum search will
 surely bring something up

 [1]http://noon.gilead.free.fr/gilead/index.php?page=gwt

 On Sep 7, 6:32 pm, M. Eduard emoroz...@gmail.com wrote:



  Hibernate will be integrated withing your Spring application. So I
  think you should first learn Spring if going use one... As GWT
  application in result is no more than JavaScript, GWT will never know
  anything about hibernate.

  On Sep 7, 11:16 am, aces2805 ace...@gmail.com wrote:

   Hi, I'm just new with GWT would like to ask if there are some
   references that I can follow in integrating spring 3.0 and hibernate
   with gwt. The usual sites that I go in uses maven, well I just think I
   just need a plain and simple example. Hope some of you guys can help
   me. Really appreciate it ... thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: [gwt-contrib] Re: Eclipse: GDT - Scala plugin cooperation problem

2010-09-07 Thread Martin Mauch
Ok, so I did the following:
I had an Eclipse installation with the Scala Development Tools running. I
installed the GPE (Google Plugin and GWT, no GAE) and restarted Eclipse.
When starting, Eclipse hung on the boot-up screen when Loading
org.eclipse.jdt.core consuming one of the two CPU cores with relatively
constant memory consumption. When trying to close the boot-up screen Windows
told me, that the application does not react and I force quit it.
So I removed all Google plugin jars from the plugins folder and Eclipse
started fine again.

Second, I installed the GPE again, restarted Eclipse which hung again. I
removed all Scala plugin jars and Eclipse started fine again.
I was using the official GPE (not the 2.1 Milestones) and the Scala
Development Tools Nightly from http://download.scala-ide.org/ which has
support for Helios (build 1.0.0.201009022343).

Is anyone able to reproduce this?

Best regards
  Martin

On Tue, Sep 7, 2010 at 02:28, Rajeev Dayal rda...@google.com wrote:



 On Sun, Sep 5, 2010 at 10:29 PM, Martin Mauch martin.ma...@gmail.comwrote:

 Installing the Scala plugin into a fresh copy of Eclipse works fine.
 I haven't tried installing and uninstalling the GPE. I could try that if
 it helps.


 If you could try this, that would be great.


 Concerning the launch configuration:
 Eclipse didn't even start, so I think it should be unrelated to any launch
 configurations.

 If the problem doesn't occur with other people's Eclipse installations
 don't consider it important.
 Atm I'm OK with using two Eclipse installations for Scala and GWT.

 Thanks!
   Martin


 On Wed, Aug 25, 2010 at 18:30, Rajeev Dayal rda...@google.com wrote:

 If you uninstall GPE and leave the Scala plugin, does everything work?
 What type of launch configuration are you using? Is it a Web Application
 launch configuration?


 On Wed, Aug 25, 2010 at 3:06 AM, Martin Mauch martin.ma...@gmail.comwrote:

 I'm running into the same problem here.
 Is there any known solution?

 On 15 Jul., 16:09, Marek marek.romanow...@gmail.com wrote:
  My Eclipse hangs up while startup (showing gwt plugin as actually
  loaded) and while changing run configuration properties pages. I've
  checked for thread dumps while this occured and in my opinion problem
  lies between Google Eclipse Plugin (any from v 1.3.2 and v 1.3.3) and
  Scala plugin (2.8.0-final). Eclipse hangs on thread with stacktrace:
 
  at java.util.zip.ZipFile.open(Native Method)
  at java.util.zip.ZipFile.init(Unknown Source)
  at java.util.zip.ZipFile.init(Unknown Source)
  at
 
 org.eclipse.jdt.internal.core.JavaModelManager.getZipFile(JavaModelManager.
 java:
  2453)
  at
 
 org.eclipse.jdt.internal.core.JarPackageFragmentRoot.getJar(JarPackageFragm
 entRoot.java:
  152)
  at
 org.eclipse.jdt.internal.core.ClassFile.getBytes(ClassFile.java:
  316)
  at
 
 scala.tools.eclipse.contribution.weaving.jdt.cfprovider.ClassFileProviderAs
 pect.ajc
  $around
 
 $scala_tools_eclipse_contribution_weaving_jdt_cfprovider_ClassFileProviderA
 spect
  $1$9776bbb8(ClassFileProviderAspect.aj:145)
  at
 
 org.eclipse.jdt.internal.core.JarPackageFragment.computeChildren(JarPackage
 Fragment.java:
  73)
  at
 
 org.eclipse.jdt.internal.core.JarPackageFragment.buildStructure(JarPackageF
 ragment.java:
  54)
 
  from second dump:
 
  at java.util.zip.Inflater.inflateBytes(Native Method)
  at java.util.zip.Inflater.inflate(Unknown Source)
  - locked 0x0f9b44f0 (a java.util.zip.ZStreamRef)
  at java.util.zip.InflaterInputStream.read(Unknown Source)
  at java.io.BufferedInputStream.read1(Unknown Source)
  at java.io.BufferedInputStream.read(Unknown Source)
  - locked 0x0f9b94d8 (a java.io.BufferedInputStream)
  at
 
 org.eclipse.jdt.internal.compiler.util.Util.getInputStreamAsByteArray(Util.
 java:
  345)
  at
 
 org.eclipse.jdt.internal.compiler.util.Util.getZipEntryByteContent(Util.jav
 a:
  511)
  at
 org.eclipse.jdt.internal.core.ClassFile.getBytes(ClassFile.java:
  320)
  at
 
 scala.tools.eclipse.contribution.weaving.jdt.cfprovider.ClassFileProviderAs
 pect.ajc
  $around
 
 $scala_tools_eclipse_contribution_weaving_jdt_cfprovider_ClassFileProviderA
 spect
  $1$9776bbb8(ClassFileProviderAspect.aj:145)
  at
 
 org.eclipse.jdt.internal.core.JarPackageFragment.computeChildren(JarPackage
 Fragment.java:
  73)
  at
 
 org.eclipse.jdt.internal.core.JarPackageFragment.buildStructure(JarPackageF
 ragment.java:
  54)
 
  from third dump:
 
  at java.util.zip.ZipFile.close(Native Method)
  at java.util.zip.ZipFile.close(Unknown Source)
  - locked 0x0bc6f540 (a java.util.zip.ZipFile)
  at
 
 org.eclipse.jdt.internal.core.JavaModelManager.closeZipFile(JavaModelManage
 r.java:
  1553)
  at
 org.eclipse.jdt.internal.core.ClassFile.getBytes(ClassFile.java:
  332)
  at
 
 

[gwt-contrib] [google-web-toolkit] r8721 committed - Remove -dumpSignatures in favor of a simpler command line invocation t...

2010-09-07 Thread codesite-noreply

Revision: 8721
Author: sco...@google.com
Date: Tue Sep  7 04:40:43 2010
Log: Remove -dumpSignatures in favor of a simpler command line invocation  
to get GWT's JRE support.


http://gwt-code-reviews.appspot.com/844801/show

Review by: fabb...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8721

Added:
 /trunk/dev/core/src/com/google/gwt/dev/GetJreEmulation.java
Deleted:
 /trunk/dev/core/src/com/google/gwt/dev/util/arg/OptionDumpSignatures.java
Modified:
 /trunk/dev/core/src/com/google/gwt/dev/CompilePerms.java
 /trunk/dev/core/src/com/google/gwt/dev/Compiler.java
 /trunk/dev/core/src/com/google/gwt/dev/GWTCompiler.java
 /trunk/dev/core/src/com/google/gwt/dev/Precompile.java
 /trunk/dev/core/src/com/google/gwt/dev/SignatureDumper.java
  
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDumpSignatures.java


===
--- /dev/null
+++ /trunk/dev/core/src/com/google/gwt/dev/GetJreEmulation.java	Tue Sep  7  
04:40:43 2010

@@ -0,0 +1,79 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.gwt.dev;
+
+import com.google.gwt.core.ext.TreeLogger;
+import com.google.gwt.core.ext.typeinfo.JAbstractMethod;
+import com.google.gwt.core.ext.typeinfo.JClassType;
+import com.google.gwt.core.ext.typeinfo.JField;
+import com.google.gwt.core.ext.typeinfo.TypeOracle;
+import com.google.gwt.dev.cfg.ModuleDef;
+import com.google.gwt.dev.cfg.ModuleDefLoader;
+import com.google.gwt.dev.javac.CompilationState;
+import com.google.gwt.dev.util.log.PrintWriterTreeLogger;
+
+import java.io.PrintWriter;
+
+/**
+ * Entry point that outputs the GWT JRE support.
+ */
+public class GetJreEmulation {
+
+  /**
+   * Only print the publicly visible API of the JRE.
+   */
+  private static final class FilterImplementation implements
+  SignatureDumper.Filter {
+public boolean shouldPrint(JAbstractMethod method) {
+  return method.isPublic() || method.isProtected();
+}
+
+public boolean shouldPrint(JClassType type) {
+  if (type.isMemberType()) {
+if (!shouldPrint(type.getEnclosingType())) {
+  return false;
+}
+  }
+  return type.getQualifiedSourceName().startsWith(java.)
+   (type.isPublic() || type.isProtected());
+}
+
+public boolean shouldPrint(JField field) {
+  return field.isPublic() || field.isProtected();
+}
+  }
+
+  /**
+   * @param args unused
+   */
+  public static void main(String[] args) {
+try {
+  PrintWriterTreeLogger logger = new PrintWriterTreeLogger(new  
PrintWriter(

+  System.err, true));
+  logger.setMaxDetail(TreeLogger.WARN);
+  ModuleDef module = ModuleDefLoader.loadFromClassPath(logger,
+  com.google.gwt.core.Core);
+  CompilationState compilationState =  
module.getCompilationState(logger);

+  TypeOracle typeOracle = compilationState.getTypeOracle();
+  SignatureDumper.dumpSignatures(typeOracle, System.out,
+  new FilterImplementation());
+} catch (Throwable e) {
+  System.err.println(Unexpected error);
+  e.printStackTrace();
+  System.exit(1);
+}
+  }
+}
===
---  
/trunk/dev/core/src/com/google/gwt/dev/util/arg/OptionDumpSignatures.java	 
Wed Oct 28 09:10:53 2009

+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- * Copyright 2009 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the License); you may  
not
- * use this file except in compliance with the License. You may obtain a  
copy of

- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an AS IS BASIS,  
WITHOUT

- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations  
under

- * the License.
- */
-package com.google.gwt.dev.util.arg;
-
-import java.io.File;
-
-/**
- * Option to set the output directory.
- */
-public interface OptionDumpSignatures {
-
-  /**
-   * Returns the signature dump file.
-   */
-  File getDumpSignatureFile();
-
-  /**
-   * Sets the signature dump file.
-   */
-  void setDumpSignatureFile(File dumpFile);
-}
===
--- /trunk/dev/core/src/com/google/gwt/dev/CompilePerms.java	Fri Apr  2  
09:39:56 2010
+++ 

Re: [gwt-contrib] Let MenuItem implement HasEnabled (issue846801)

2010-09-07 Thread Joel Webber
@rjrjr: I notice you own the bug -- do you have time to look at this, or
would you like me to take it off your hands?

Le 6 septembre 2010 04:48, johan.rydb...@gmail.com a écrit :

 Reviewers: ,

 Description:
 Let MenuItem implement HasEnabled and update MenuBar to use this
 information when selecting items.

 The themes are also updated with a gwt-MenuItem-disabled rule.

 This is an attempt to fix
 http://code.google.com/p/google-web-toolkit/issues/detail?id=1649


 Please review this at http://gwt-code-reviews.appspot.com/846801/show

 Affected files:
  user/src/com/google/gwt/user/client/ui/MenuBar.java
  user/src/com/google/gwt/user/client/ui/MenuItem.java
  user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css
  user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome_rtl.css
  user/src/com/google/gwt/user/theme/dark/public/gwt/dark/dark.css
  user/src/com/google/gwt/user/theme/dark/public/gwt/dark/dark_rtl.css

  user/src/com/google/gwt/user/theme/standard/public/gwt/standard/standard.css

  
 user/src/com/google/gwt/user/theme/standard/public/gwt/standard/standard_rtl.css


 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-07 Thread bobv


http://gwt-code-reviews.appspot.com/845801/diff/5001/6008
File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right):

http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24
user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private
final Class? clazz;
Could you change this to a JType or JClassType instead?  It's kind of
weird for generator models to use the class objects, since it may be the
case that there is no compiled version of the type available to the
generator.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6009
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/845801/diff/5001/6009#newcode92
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:92:
// HashSetConstraintViolationT();
+1 to example comments.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6009#newcode153
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:153:
sw.println(Class?... groups) {);
This code is fine as is, but as of last week SourceWriter has
printf-style overloads.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6011
File user/src/com/google/gwt/validation/rebind/ValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/845801/diff/5001/6011#newcode46
user/src/com/google/gwt/validation/rebind/ValidatorCreator.java:46:
private static final WeakHashMapTypeOracle, MapString, BeanHelper
helpers = new WeakHashMapTypeOracle, MapString, BeanHelper();
There's some ongoing work on the compiler-side of things to figure out
the best way to cache this kind of data.  The current approach for data
whose lifetime is bounded by the TypeOracle is to stash the map in a
ThreadLocal, since each GWT module lives in its own thread in DevMode.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6011#newcode56
user/src/com/google/gwt/validation/rebind/ValidatorCreator.java:56:
private final MapString, BeanHelper beansToValidate = new
HashMapString, BeanHelper();
You might want to use the StringKey utility class to make the generic
signature more informative.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6013
File user/test/com/google/gwt/validation/example/client/AuthorTest.java
(right):

http://gwt-code-reviews.appspot.com/845801/diff/5001/6013#newcode37
user/test/com/google/gwt/validation/example/client/AuthorTest.java:37:
// @Override
Old code?

http://gwt-code-reviews.appspot.com/845801/diff/5001/6013#newcode47
user/test/com/google/gwt/validation/example/client/AuthorTest.java:47:
// expected
Style: You can name the variable expected and eliminate the comment.

http://gwt-code-reviews.appspot.com/845801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


Re: [gwt-contrib] Let MenuItem implement HasEnabled (issue846801)

2010-09-07 Thread Ray Ryan
Please!

On Tue, Sep 7, 2010 at 8:01 AM, Joel Webber j...@google.com wrote:

 @rjrjr: I notice you own the bug -- do you have time to look at this, or
 would you like me to take it off your hands?

 Le 6 septembre 2010 04:48, johan.rydb...@gmail.com a écrit :

 Reviewers: ,

 Description:
 Let MenuItem implement HasEnabled and update MenuBar to use this
 information when selecting items.

 The themes are also updated with a gwt-MenuItem-disabled rule.

 This is an attempt to fix
 http://code.google.com/p/google-web-toolkit/issues/detail?id=1649


 Please review this at http://gwt-code-reviews.appspot.com/846801/show

 Affected files:
  user/src/com/google/gwt/user/client/ui/MenuBar.java
  user/src/com/google/gwt/user/client/ui/MenuItem.java
  user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css

  user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome_rtl.css
  user/src/com/google/gwt/user/theme/dark/public/gwt/dark/dark.css
  user/src/com/google/gwt/user/theme/dark/public/gwt/dark/dark_rtl.css

  user/src/com/google/gwt/user/theme/standard/public/gwt/standard/standard.css

  
 user/src/com/google/gwt/user/theme/standard/public/gwt/standard/standard_rtl.css


 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors




-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8722 committed - Continuation of r8542. Fixes double click where it was broken and adds...

2010-09-07 Thread codesite-noreply

Revision: 8722
Author: fre...@google.com
Date: Tue Sep  7 06:57:03 2010
Log: Continuation of r8542. Fixes double click where it was broken and adds  
tests to ensure that

events are sunk.

Fix double click in the following widgets (and their subclasses):
- com/google/gwt/user/client/ui/FocusWidget.java
- com/google/gwt/user/client/ui/HTMLTable.java
- com/google/gwt/user/client/ui/Image.java
- com/google/gwt/user/client/ui/Label.java

Undo the addition of double click support to Hyperlink, since it is  
provided by Anchor:

- com/google/gwt/user/client/ui/Hyperlink.java

Note that r8542 never actually added double click support for:
- com/google/gwt/user/client/ui/TabBar.java

Note also that double click support was indeed correctly added in r8542 for:
- com/google/gwt/user/client/ui/FocusPanel.java

Review at http://gwt-code-reviews.appspot.com/774801

Fixes issues: 5212
Review by: j...@google

http://code.google.com/p/google-web-toolkit/source/detail?r=8722

Added:
 /trunk/user/test/com/google/gwt/user/client/DoubleClickEventSinkTest.java
Modified:
 /trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java
 /trunk/user/src/com/google/gwt/user/client/ui/HTMLTable.java
 /trunk/user/src/com/google/gwt/user/client/ui/Hyperlink.java
 /trunk/user/src/com/google/gwt/user/client/ui/Image.java
 /trunk/user/src/com/google/gwt/user/client/ui/Label.java
 /trunk/user/test/com/google/gwt/user/UISuite.java

===
--- /dev/null
+++  
/trunk/user/test/com/google/gwt/user/client/DoubleClickEventSinkTest.java	 
Tue Sep  7 06:57:03 2010

@@ -0,0 +1,118 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+
+package com.google.gwt.user.client;
+
+import com.google.gwt.event.dom.client.DoubleClickEvent;
+import com.google.gwt.event.dom.client.DoubleClickHandler;
+import com.google.gwt.event.dom.client.HasDoubleClickHandlers;
+import com.google.gwt.junit.client.GWTTestCase;
+import com.google.gwt.user.client.ui.Anchor;
+import com.google.gwt.user.client.ui.Button;
+import com.google.gwt.user.client.ui.CheckBox;
+import com.google.gwt.user.client.ui.FlexTable;
+import com.google.gwt.user.client.ui.FocusPanel;
+import com.google.gwt.user.client.ui.Grid;
+import com.google.gwt.user.client.ui.Image;
+import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.user.client.ui.ListBox;
+import com.google.gwt.user.client.ui.PasswordTextBox;
+import com.google.gwt.user.client.ui.RichTextArea;
+import com.google.gwt.user.client.ui.RootPanel;
+import com.google.gwt.user.client.ui.SimpleRadioButton;
+import com.google.gwt.user.client.ui.TextArea;
+import com.google.gwt.user.client.ui.TextBox;
+import com.google.gwt.user.client.ui.ToggleButton;
+import com.google.gwt.user.client.ui.Widget;
+
+/**
+ * Test Case for sinking of double click events.
+ */
+public class DoubleClickEventSinkTest extends GWTTestCase {
+
+  private DoubleClickHandler dummyDoubleClickHandler = new  
DoubleClickHandler() {

+@Override
+public void onDoubleClick(DoubleClickEvent event) {
+}
+  };
+
+  @Override
+  public String getModuleName() {
+return com.google.gwt.user.User;
+  }
+
+  public void testDoubleClickBitFieldNotTriviallyZero() throws Exception {
+assertNotSame(0, Event.ONDBLCLICK);
+  }
+
+  public void testFocusWidgetDoubleClickEventSinkByAddingHandler() {
+verifyEventSinkOnAddHandler(new Anchor(), false);
+verifyEventSinkOnAddHandler(new Button(), false);
+
+CheckBox checkBox = new CheckBox();
+// Get the inputElem on which events are sunk
+Element e = (Element) checkBox.getElement().getFirstChildElement();
+verifyEventSinkOnAddHandler(checkBox, e, false);
+
+verifyEventSinkOnAddHandler(new ToggleButton(), false);
+verifyEventSinkOnAddHandler(new ListBox(), false);
+verifyEventSinkOnAddHandler(new RichTextArea(), false);
+verifyEventSinkOnAddHandler(new TextArea(), false);
+verifyEventSinkOnAddHandler(new PasswordTextBox(), false);
+verifyEventSinkOnAddHandler(new TextBox(), false);
+verifyEventSinkOnAddHandler(new SimpleRadioButton(foo), false);
+  }
+
+  public void testFocusPanelDoubleClickEventSinkByAddingHandler() {
+verifyEventSinkOnAddHandler(new FocusPanel(), false);
+  }
+
+  public void testHTMLTableDoubleClickEventSinkByAddingHandler() {
+verifyEventSinkOnAddHandler(new Grid(), false);
+verifyEventSinkOnAddHandler(new FlexTable(), false);
+  }
+
+  public 

[gwt-contrib] Re: Implement keyboard navigation for CellBrowser (issue843801)

2010-09-07 Thread rice

http://gwt-code-reviews.appspot.com/843801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] UiBinder. Design time tweaks for @UiField and @UiHandler (issue834802)

2010-09-07 Thread Konstantin . Scheglov

Reviewers: rjrjr,

Description:
It turns out that previous patch was not enough.
In new one instead of preventing failing when no owner or field found,
we disable assigning to fields and support for event handlers at all.
However we can not disable them globally, for all UiBinder templates, we
should do this only for template under design (because other templates
may be used on it). So, I've changed a little way for choosing
DesignTimeUtils implementation.


Please review this at http://gwt-code-reviews.appspot.com/834802/show

Affected files:
  user/src/com/google/gwt/uibinder/rebind/DesignTimeUtils.java
  user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java
  user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsStub.java
  user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
  user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
  user/test/com/google/gwt/uibinder/rebind/DesignTimeUtilsTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Provides support for fix of (issue841803)

2010-09-07 Thread rjrjr

http://gwt-code-reviews.appspot.com/841803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Provides support for fix of (issue841803)

2010-09-07 Thread rjrjr

Only real changes in the last patch are in AbstractJsonListRequest and
AbstractJsonObjectRequest to work around
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6437894

Submitting.

On 2010/09/07 19:14:54, rjrjr wrote:




http://gwt-code-reviews.appspot.com/841803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8723 committed - Rolling back due load test failures....

2010-09-07 Thread codesite-noreply

Revision: 8723
Author: gwt.mirror...@gmail.com
Date: Tue Sep  7 12:33:00 2010
Log: Rolling back due load test failures.

*** Original change description ***
Add Late Loading support to xsiframe linker
Review at http://gwt-code-reviews.appspot.com/807801

http://code.google.com/p/google-web-toolkit/source/detail?r=8723

Modified:
  
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/computeScriptBase.js

 /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.js
 /trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js

===
---  
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/computeScriptBase.js	 
Fri Sep  3 10:10:06 2010
+++  
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/computeScriptBase.js	 
Tue Sep  7 09:26:43 2010

@@ -24,39 +24,24 @@
  * on each side.
  */
 function computeScriptBase() {
-  // First, check if the meta properties give the baseUrl
+  var thisScript
+  ,markerId = __gwt_marker___MODULE_NAME__
+  ,markerScript;
+
   if (metaProps['baseUrl']) {
 base = metaProps['baseUrl'];
 return;
   }

-  // The baseUrl will be similar to the URL for this script's URL
-  var thisScript;
-
-  // By default, this script looks like something/moduleName.nocache.js
-  // so look for a script tag that looks like that
-  var scriptTags = $doc.getElementsByTagName('script');
-  for (var i = 0; i  scriptTags.length; ++i) {
-if (scriptTags[i].src.indexOf('__MODULE_NAME__.nocache.js') != -1) {
-  thisScript = scriptTags[i];
-}
-  }
-
-  // If the user renamed their script tag, we'll use a fancier method to  
find

-  // it. Note that this will not work in the Late Loading case due to the
-  // document.write call.
-  if (!thisScript) {
-// Put in a marker script element which should be the first script tag  
after
-// the tag we're looking for. To find it, we start at the marker and  
walk

-// backwards until we find a script.
-var markerId = __gwt_marker___MODULE_NAME__;
-var markerScript;
-$doc.write('script id=' + markerId + '/script');
-markerScript = $doc.getElementById(markerId);
-thisScript = markerScript  markerScript.previousSibling;
-while (thisScript  thisScript.tagName != 'SCRIPT') {
-  thisScript = thisScript.previousSibling;
-}
+  $doc.write('script id=' + markerId + '/script');
+  markerScript = $doc.getElementById(markerId);
+
+  // Our script element is assumed to be the closest previous script  
element

+  // to the marker, so start at the marker and walk backwards until we find
+  // a script.
+  thisScript = markerScript  markerScript.previousSibling;
+  while (thisScript  thisScript.tagName != 'SCRIPT') {
+thisScript = thisScript.previousSibling;
   }

   // Gets the part of a url up to and including the 'path' portion.
===
--- /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.js	Fri  
Sep  3 10:10:06 2010
+++ /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.js	Tue  
Sep  7 09:26:43 2010

@@ -333,20 +333,13 @@

 doBrowserSpecificFixes();

+// DevMode currently only supports iframe based linkers
+var query = parent.location.search;
 if (!findPluginXPCOM()) {
-  var embed = document.createElement('embed');
-  embed.id = 'pluginEmbed';
-  embed.type = 'application/x-gwt-hosted-mode';
-  embed.width = '10';
-  embed.height = '20';
-
-  var obj = document.createElement('object');
-  obj.id = 'pluginObject';
-  obj.CLASSID = 'CLSID:1D6156B6-002B-49E7-B5CA-C138FB843B4E';
-
-  var dochead = doc.getElementsByTagName('head')[0];
-  dochead.append(embed);
-  dochead.append(obj);
+  document.write('embed id=pluginEmbed  
type=application/x-gwt-hosted-mode width=10 height=10');

+  document.write('/embed');
+  document.write('object id=pluginObject  
CLASSID=CLSID:1D6156B6-002B-49E7-B5CA-C138FB843B4E');

+  document.write('/object');
 }

 setTimeout(function() { $wnd[$moduleName].onScriptInstalled(gwtOnLoad) },  
1);

===
---  
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js	 
Fri Sep  3 10:10:06 2010
+++  
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js	 
Tue Sep  7 09:26:43 2010

@@ -56,20 +56,24 @@

   ; // end of global vars

-  sendStats('bootstrap', 'begin');
+  $stats  $stats({
+moduleName: '__MODULE_NAME__',
+sessionId: $sessionId,
+subSystem: 'startup',
+evtGroup: 'bootstrap',
+millis:(new Date()).getTime(),
+type: 'begin',
+  });
+
+  // -- TRUE GLOBALS --
+
+  // Maps to synchronize the loading of styles and scripts; resources are  
loaded
+  // only once, even when multiple modules depend on them.  This API must  
not

+  // change across GWT versions.
+  if (!$wnd.__gwt_stylesLoaded) { $wnd.__gwt_stylesLoaded = {}; }
+  if (!$wnd.__gwt_scriptsLoaded) { $wnd.__gwt_scriptsLoaded = {}; }

   // --- INTERNAL FUNCTIONS 

[gwt-contrib] [google-web-toolkit] r8724 committed - Snip an @Override that jdk 1.5 cannot support,...

2010-09-07 Thread codesite-noreply

Revision: 8724
Author: rj...@google.com
Date: Tue Sep  7 09:47:45 2010
Log: Snip an @Override that jdk 1.5 cannot support,
and fix an unneeded throws warning.

http://code.google.com/p/google-web-toolkit/source/detail?r=8724

Modified:
 /trunk/user/test/com/google/gwt/user/client/DoubleClickEventSinkTest.java

===
---  
/trunk/user/test/com/google/gwt/user/client/DoubleClickEventSinkTest.java	 
Tue Sep  7 06:57:03 2010
+++  
/trunk/user/test/com/google/gwt/user/client/DoubleClickEventSinkTest.java	 
Tue Sep  7 09:47:45 2010

@@ -44,7 +44,6 @@
 public class DoubleClickEventSinkTest extends GWTTestCase {

   private DoubleClickHandler dummyDoubleClickHandler = new  
DoubleClickHandler() {

-@Override
 public void onDoubleClick(DoubleClickEvent event) {
 }
   };
@@ -54,7 +53,7 @@
 return com.google.gwt.user.User;
   }

-  public void testDoubleClickBitFieldNotTriviallyZero() throws Exception {
+  public void testDoubleClickBitFieldNotTriviallyZero() {
 assertNotSame(0, Event.ONDBLCLICK);
   }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-07 Thread pdr

Reviewers: jat,

Description:
Add SafeHtml support to UI widgets (2)

This is a first-pass at adding SafeHtml support to a subset of the
widgets. In cases where the class implements HasHTML, HasSafeHtml has
been implemented as well. In constructors that accept a string that can
be parsed as Html, a SafeHtml constructor has been added. In cases where
a method accepts a string that can be parsed as Html, a corresponding
SafeHtml method has been added.


Please review this at http://gwt-code-reviews.appspot.com/847801/show

Affected files:
  M tools/api-checker/config/gwt20_21userApi.conf
  M user/src/com/google/gwt/user/User.gwt.xml
  M user/src/com/google/gwt/user/client/ui/Anchor.java
  M user/src/com/google/gwt/user/client/ui/Button.java
  M user/src/com/google/gwt/user/client/ui/ButtonBase.java
  M user/src/com/google/gwt/user/client/ui/CaptionPanel.java
  M user/src/com/google/gwt/user/client/ui/CheckBox.java
  M user/src/com/google/gwt/user/client/ui/CustomButton.java
  M user/src/com/google/gwt/user/client/ui/DialogBox.java
  M user/src/com/google/gwt/user/client/ui/HTML.java
  M user/src/com/google/gwt/user/client/ui/HTMLPanel.java
  M user/src/com/google/gwt/user/client/ui/HTMLTable.java
  A user/src/com/google/gwt/user/client/ui/HasDirectionalSafeHtml.java
  M user/src/com/google/gwt/user/client/ui/Hyperlink.java
  M user/src/com/google/gwt/user/client/ui/InlineHTML.java
  M user/src/com/google/gwt/user/client/ui/InlineHyperlink.java
  M user/src/com/google/gwt/user/client/ui/Label.java
  M user/src/com/google/gwt/user/client/ui/MenuBar.java
  M user/src/com/google/gwt/user/client/ui/MenuItem.java
  M user/src/com/google/gwt/user/client/ui/RadioButton.java
  M user/src/com/google/gwt/user/client/ui/ResetButton.java
  M user/src/com/google/gwt/user/client/ui/RichTextArea.java
  M user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java
  M user/src/com/google/gwt/user/client/ui/StackPanel.java
  M user/src/com/google/gwt/user/client/ui/SubmitButton.java
  M user/src/com/google/gwt/user/client/ui/TabBar.java
  M user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
  M user/src/com/google/gwt/user/client/ui/TreeItem.java
  M user/test/com/google/gwt/user/UISuite.java
  M user/test/com/google/gwt/user/client/ui/AnchorTest.java
  M user/test/com/google/gwt/user/client/ui/ButtonTest.java
  M user/test/com/google/gwt/user/client/ui/CaptionPanelTest.java
  M user/test/com/google/gwt/user/client/ui/CheckBoxTest.java
  M user/test/com/google/gwt/user/client/ui/CustomButtonTest.java
  M user/test/com/google/gwt/user/client/ui/DialogBoxTest.java
  M user/test/com/google/gwt/user/client/ui/HTMLPanelTest.java
  M user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
  M user/test/com/google/gwt/user/client/ui/HTMLTest.java
  M user/test/com/google/gwt/user/client/ui/HyperlinkTest.java
  A user/test/com/google/gwt/user/client/ui/InlineHTMLTest.java
  A user/test/com/google/gwt/user/client/ui/InlineHyperlinkTest.java
  M user/test/com/google/gwt/user/client/ui/LabelTest.java
  M user/test/com/google/gwt/user/client/ui/MenuBarTest.java
  M user/test/com/google/gwt/user/client/ui/MenuItemTest.java
  M user/test/com/google/gwt/user/client/ui/RadioButtonTest.java
  A user/test/com/google/gwt/user/client/ui/ResetButtonTest.java
  M user/test/com/google/gwt/user/client/ui/RichTextAreaTest.java
  M user/test/com/google/gwt/user/client/ui/StackLayoutPanelTest.java
  A user/test/com/google/gwt/user/client/ui/SubmitButtonTest.java
  M user/test/com/google/gwt/user/client/ui/TabBarTest.java
  M user/test/com/google/gwt/user/client/ui/TreeItemTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: RR: Add statistics to optimizers (issue841801)

2010-09-07 Thread scottb

I went back and removed my style nit comments to focus on the
substantive stuff.  Manually tracking the number of visits in every
visitor, and how that data is used, are my primary concerns.


http://gwt-code-reviews.appspot.com/841801/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
(right):

http://gwt-code-reviews.appspot.com/841801/diff/1/4#newcode127
dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java:127:
numVisits++;
Ouch.. this is going to be a huge maintenance pain.  And it doesn't
*really* account for all the nodes this visitor visits... it only counts
nodes we wrote a specific override for here.  Can we rethink this?

http://gwt-code-reviews.appspot.com/841801/diff/1/4#newcode1839
dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java:1839:
stats.recordModified(deadCodeVisitor.getNumMods()).recordVisits(deadCodeVisitor.numVisits);
I have a sort of data nit here.  The way the data is displayed, it tends
to make you think that the visitor modified, say, 21 out of 800 nodes.
But when you loop like this, what really happens is that you modify
11/200, then 9/200, then 1/200, then 0/200.  If we're not going to break
each one out as a child stat, then it seems more useful to know the
general size of the whole AST going in, if that's possible, than to see
an inflated number of visit counts that depends entirely on how many
times the loop executed internally.

http://gwt-code-reviews.appspot.com/841801/diff/1/9
File dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java
(right):

http://gwt-code-reviews.appspot.com/841801/diff/1/9#newcode275
dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java:275:
madeChanges();
Shouldn't the ctx.replaceMe() do this?

http://gwt-code-reviews.appspot.com/841801/diff/1/9#newcode472
dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java:472:
madeChanges();
Same here.

http://gwt-code-reviews.appspot.com/841801/diff/1/10
File dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java
(right):

http://gwt-code-reviews.appspot.com/841801/diff/1/10#newcode29
dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java:29: private
ListOptimizerStats children = new ArrayListOptimizerStats();
This being used right now?  It's kind of odd that you can query
mods/visits programmatically, but you can't iterate over the children
from the outside.  Makes you think mods/visits should actually include
child counts as well, the way it's formulated.

The only way to see anything about the children is printing.

http://gwt-code-reviews.appspot.com/841801/diff/1/10#newcode43
dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java:43: return
numMods;
Seems kind of strange... how can I modify without visiting?

http://gwt-code-reviews.appspot.com/841801/diff/1/10#newcode52
dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java:52: public
OptimizerStats(String name, boolean didChange) {
What's this overload for?  (Need javadoc.)

http://gwt-code-reviews.appspot.com/841801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-07 Thread jat

LGTM with mostly nits.

A general concern is inconsistency about naming -- most places, the
SafeHtml version is just an overload, and that makes the most sense to
me.  Some places rename the method to be setSafeHtml instead of setHtml,
for example, and I don't think that difference is relevant to the name
-- in either case, you are setting the HTML, you are just conveying it
to the method differently.


http://gwt-code-reviews.appspot.com/847801/diff/1/2
File tools/api-checker/config/gwt20_21userApi.conf (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/2#newcode115
tools/api-checker/config/gwt20_21userApi.conf:115: # there needs to be:
method(SafeHtml html), etc.
Should probably add a statement that null is not acceptable to any of
these methods, so adding the overload is unlikely to break any code
besides possibly test mocks.

http://gwt-code-reviews.appspot.com/847801/diff/1/4
File user/src/com/google/gwt/user/client/ui/Anchor.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/4#newcode166
user/src/com/google/gwt/user/client/ui/Anchor.java:166:
Spaces.

http://gwt-code-reviews.appspot.com/847801/diff/1/5
File user/src/com/google/gwt/user/client/ui/Button.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/5#newcode92
user/src/com/google/gwt/user/client/ui/Button.java:92:
Spaces.

http://gwt-code-reviews.appspot.com/847801/diff/1/9
File user/src/com/google/gwt/user/client/ui/CustomButton.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/9#newcode449
user/src/com/google/gwt/user/client/ui/CustomButton.java:449:
Spaces.

http://gwt-code-reviews.appspot.com/847801/diff/1/24
File user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/847801/diff/1/24#newcode436
user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java:436: public
void setHeaderSafeHtml(int index, SafeHtml html) {
Why not just setHeaderHtml(int, SafeHtml)?  It is still just setting the
HTML, and the others all just overloaded the same method.

http://gwt-code-reviews.appspot.com/847801/diff/1/27
File user/src/com/google/gwt/user/client/ui/TabBar.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/27#newcode544
user/src/com/google/gwt/user/client/ui/TabBar.java:544: public void
setTabSafeHtml(int index, SafeHtml html) {
Here also -- why not just overload setTabHTML?

http://gwt-code-reviews.appspot.com/847801/diff/1/28
File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/28#newcode482
user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java:482: public
void setTabSafeHtml(int index, SafeHtml html) {
And here.

http://gwt-code-reviews.appspot.com/847801/diff/1/29
File user/src/com/google/gwt/user/client/ui/TreeItem.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/29#newcode613
user/src/com/google/gwt/user/client/ui/TreeItem.java:613: public void
setSafeHtml(SafeHtml html) {
And here.

http://gwt-code-reviews.appspot.com/847801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Provides support for fix of (issue841803)

2010-09-07 Thread Ray Ryan
r8725

On Tue, Sep 7, 2010 at 12:20 PM, rj...@google.com wrote:

 Only real changes in the last patch are in AbstractJsonListRequest and
 AbstractJsonObjectRequest to work around
 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6437894

 Submitting.


 On 2010/09/07 19:14:54, rjrjr wrote:




 http://gwt-code-reviews.appspot.com/841803/show


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-07 Thread pdr


http://gwt-code-reviews.appspot.com/847801/diff/1/2
File tools/api-checker/config/gwt20_21userApi.conf (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/2#newcode115
tools/api-checker/config/gwt20_21userApi.conf:115: # there needs to be:
method(SafeHtml html), etc.
On 2010/09/07 20:22:33, jat wrote:

Should probably add a statement that null is not acceptable to any of

these

methods, so adding the overload is unlikely to break any code besides

possibly

test mocks.


Done.

http://gwt-code-reviews.appspot.com/847801/diff/1/4
File user/src/com/google/gwt/user/client/ui/Anchor.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/4#newcode166
user/src/com/google/gwt/user/client/ui/Anchor.java:166:
On 2010/09/07 20:22:33, jat wrote:

Spaces.


Done.

http://gwt-code-reviews.appspot.com/847801/diff/1/5
File user/src/com/google/gwt/user/client/ui/Button.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/5#newcode92
user/src/com/google/gwt/user/client/ui/Button.java:92:
On 2010/09/07 20:22:33, jat wrote:

Spaces.


Done.

http://gwt-code-reviews.appspot.com/847801/diff/1/9
File user/src/com/google/gwt/user/client/ui/CustomButton.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/9#newcode449
user/src/com/google/gwt/user/client/ui/CustomButton.java:449:
On 2010/09/07 20:22:33, jat wrote:

Spaces.


Done.

http://gwt-code-reviews.appspot.com/847801/diff/1/24
File user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/847801/diff/1/24#newcode436
user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java:436: public
void setHeaderSafeHtml(int index, SafeHtml html) {
On 2010/09/07 20:22:33, jat wrote:

Why not just setHeaderHtml(int, SafeHtml)?  It is still just setting

the HTML,

and the others all just overloaded the same method.


Good point. Done.

http://gwt-code-reviews.appspot.com/847801/diff/1/27
File user/src/com/google/gwt/user/client/ui/TabBar.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/27#newcode544
user/src/com/google/gwt/user/client/ui/TabBar.java:544: public void
setTabSafeHtml(int index, SafeHtml html) {
On 2010/09/07 20:22:33, jat wrote:

Here also -- why not just overload setTabHTML?


Done.

http://gwt-code-reviews.appspot.com/847801/diff/1/28
File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/28#newcode482
user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java:482: public
void setTabSafeHtml(int index, SafeHtml html) {
On 2010/09/07 20:22:33, jat wrote:

And here.


Done.

http://gwt-code-reviews.appspot.com/847801/diff/1/29
File user/src/com/google/gwt/user/client/ui/TreeItem.java (right):

http://gwt-code-reviews.appspot.com/847801/diff/1/29#newcode613
user/src/com/google/gwt/user/client/ui/TreeItem.java:613: public void
setSafeHtml(SafeHtml html) {
On 2010/09/07 20:22:33, jat wrote:

And here.


In this case, setSafeHtml() is the method defined in the interface
HasSafeHtml. I am changing this to setHTML(SafeHtml), and the interface
as well.

http://gwt-code-reviews.appspot.com/847801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-07 Thread jat

LGTM

http://gwt-code-reviews.appspot.com/847801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Fix bug 2822942 Remove calls to System.currentTimeMillis in tests (issue849801)

2010-09-07 Thread rice


http://gwt-code-reviews.appspot.com/849801/diff/1/2
File user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java
(right):

http://gwt-code-reviews.appspot.com/849801/diff/1/2#newcode39
user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java:39: long
millis = 100;
Perhaps test with 10 and also a much larger value, since subtracting
a day from 10 will result in a negative (pre Jan 1, 1970) value.  It
would be worth testing cases where things stay positive.

For reference, the current Java timestamp in milliseconds is around
1283895273475.

http://gwt-code-reviews.appspot.com/849801/diff/1/3
File user/test/com/google/gwt/emultest/java/sql/SqlTimeTest.java
(right):

http://gwt-code-reviews.appspot.com/849801/diff/1/3#newcode127
user/test/com/google/gwt/emultest/java/sql/SqlTimeTest.java:127: long
millis = 100;
See comments for SqlTimestampTest.

http://gwt-code-reviews.appspot.com/849801/diff/1/4
File user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java
(right):

http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode44
user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:44:
long now = 100;
I would suggest refactoring the test so both cases (now % 1000) == 0 and
(now % 1000 != 0) are tested.

http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode73
user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:73:
long now = 100;
Ditto

http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode88
user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:88:
long now = 100;
Ditto

http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode110
user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:110:
long now = 100;
Ditto

http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode137
user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:137:
long now = (100 / 1000) * 1000 + 5;
Might as well just say 'long now = 15;' since everything is a
constant.

http://gwt-code-reviews.appspot.com/849801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8726 committed - Change UiBinder Message generation to use consistent examples for HTML...

2010-09-07 Thread codesite-noreply

Revision: 8726
Author: m...@google.com
Date: Tue Sep  7 12:42:09 2010
Log: Change UiBinder Message generation to use consistent examples for HTML  
and Widget placeholders to facilitate sharing of messages with embedded  
HTML elements or widgets.


Review at http://gwt-code-reviews.appspot.com/838801

Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8726

Modified:
  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java
  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/WidgetPlaceholderInterpreter.java


===
---  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java	 
Fri Apr  2 06:00:38 2010
+++  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java	 
Tue Sep  7 12:42:09 2010

@@ -31,6 +31,10 @@
  * {...@link XMLElement#consumeInnerHtml}.)
  */
 class HtmlPlaceholderInterpreter extends PlaceholderInterpreter {
+
+  private static final String EXAMPLE_OPEN_TAG = tag;
+  private static final String EXAMPLE_CLOSE_TAG = /tag;
+
   private int serial = 0;
   private final XMLElement.InterpreterString fieldAndComputed;

@@ -57,8 +61,7 @@

   String openTag = elem.consumeOpeningTag();
   String openPlaceholder =
-  nextPlaceholder(name + Begin, stripTokens(openTag),
-  uiWriter.detokenate(openTag));
+  nextOpenPlaceholder(name + Begin,  
uiWriter.detokenate(openTag));


   /*
* This recursive innerHtml call has already been escaped. Hide it  
in a

@@ -67,8 +70,7 @@
   String body = tokenator.nextToken(elem.consumeInnerHtml(this));

   String closeTag = elem.getClosingTag();
-  String closePlaceholder =
-  nextPlaceholder(name + End, closeTag, closeTag);
+  String closePlaceholder = nextClosePlaceholder(name + End,  
closeTag);


   return openPlaceholder + body + closePlaceholder;
 }
@@ -81,6 +83,24 @@
   throws UnableToCompleteException {
 return elem.consumeInnerHtml(fieldAndComputed);
   }
+
+  /**
+   * Returns the {...@link #nextPlaceholder(String, String, String)}, using  
the
+   * given {...@code name} and {...@code value} and a standard opening tag as  
example

+   * text.
+   */
+  protected String nextOpenPlaceholder(String name, String value) {
+return nextPlaceholder(name, EXAMPLE_OPEN_TAG, value);
+  }
+
+  /**
+   * Returns the {...@link #nextPlaceholder(String, String, String)}, using  
the
+   * given {...@code name} and {...@code value} and a standard closing tag as  
example

+   * text.
+   */
+  protected String nextClosePlaceholder(String name, String value) {
+return nextPlaceholder(name, EXAMPLE_CLOSE_TAG, value);
+  }

   /**
* An element will require a placeholder if the user has called it out  
with a

===
---  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/WidgetPlaceholderInterpreter.java	 
Fri Apr  2 06:00:38 2010
+++  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/WidgetPlaceholderInterpreter.java	 
Tue Sep  7 12:42:09 2010

@@ -127,15 +127,13 @@
   }

   private String genCloseTag(String name) {
-String closePlaceholder =
-nextPlaceholder(name + End, /span, /span);
+String closePlaceholder = nextClosePlaceholder(name  
+ End, /span);

 return closePlaceholder;
   }

   private String genOpenTag(String name, String idHolder) {
 String openTag = String.format(span id='\ + %s + \', idHolder);
-String openPlaceholder =
-nextPlaceholder(name + Begin, span, openTag);
+String openPlaceholder = nextOpenPlaceholder(name + Begin, openTag);
 return openPlaceholder;
   }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add SafeHtml support to ui widgets. (issue829801)

2010-09-07 Thread xtof

LGTM


http://gwt-code-reviews.appspot.com/829801/diff/8020/24004
File user/src/com/google/gwt/user/client/ui/CheckBox.java (right):

http://gwt-code-reviews.appspot.com/829801/diff/8020/24004#newcode265
user/src/com/google/gwt/user/client/ui/CheckBox.java:265: public void
setSafeHtml(SafeHtml html) {
Don't we already inherit this from ButtonBase?

http://gwt-code-reviews.appspot.com/829801/diff/8020/24013
File user/test/com/google/gwt/user/client/ui/CheckBoxTest.java (right):

http://gwt-code-reviews.appspot.com/829801/diff/8020/24013#newcode226
user/test/com/google/gwt/user/client/ui/CheckBoxTest.java:226: CheckBox
box = new CheckBox(html);
You could shorten this to
 new CheckBox(SafeHtmlUtils.fromSafeConstant(b...

(here and elsewhere)

http://gwt-code-reviews.appspot.com/829801/diff/8020/24015
File user/test/com/google/gwt/user/client/ui/HTMLTest.java (right):

http://gwt-code-reviews.appspot.com/829801/diff/8020/24015#newcode43
user/test/com/google/gwt/user/client/ui/HTMLTest.java:43:
sb.appendHtmlConstant(html);
It's a bit of a discouraged pattern to pass the value of local variables
to appendHtmlConstant (since in a more complicated method you have to
squint at it to be sure it's really a constant).  Can you make this
static final constants?

(here and elsewhere)

http://gwt-code-reviews.appspot.com/829801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Fix ROO-1362 caused by non-public GWT class. (issue835802)

2010-09-07 Thread rjrjr

LGTM

http://gwt-code-reviews.appspot.com/835802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Rolling back r8722 due to test failures (issue851801)

2010-09-07 Thread fredsa

Reviewers: kathrin,

Description:
Rolling back r8722 due to test failures


Please review this at http://gwt-code-reviews.appspot.com/851801/show

Affected files:
  M user/src/com/google/gwt/user/client/ui/FocusWidget.java
  M user/src/com/google/gwt/user/client/ui/HTMLTable.java
  M user/src/com/google/gwt/user/client/ui/Hyperlink.java
  M user/src/com/google/gwt/user/client/ui/Image.java
  M user/src/com/google/gwt/user/client/ui/Label.java
  M user/test/com/google/gwt/user/UISuite.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8727 committed - rollback r8722 due to test failure on Chrome

2010-09-07 Thread codesite-noreply

Revision: 8727
Author: k...@google.com
Date: Tue Sep  7 14:01:53 2010
Log: rollback r8722 due to test failure on Chrome

http://code.google.com/p/google-web-toolkit/source/detail?r=8727

Modified:
 /trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java
 /trunk/user/src/com/google/gwt/user/client/ui/HTMLTable.java
 /trunk/user/src/com/google/gwt/user/client/ui/Hyperlink.java
 /trunk/user/src/com/google/gwt/user/client/ui/Image.java
 /trunk/user/src/com/google/gwt/user/client/ui/Label.java
 /trunk/user/test/com/google/gwt/user/UISuite.java

===
--- /trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java	Tue Sep   
7 06:57:03 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java	Tue Sep   
7 14:01:53 2010

@@ -104,7 +104,7 @@
   }

   public HandlerRegistration addDoubleClickHandler(DoubleClickHandler  
handler) {

-return addDomHandler(handler, DoubleClickEvent.getType());
+return addHandler(handler, DoubleClickEvent.getType());
   }

   public HandlerRegistration addFocusHandler(FocusHandler handler) {
===
--- /trunk/user/src/com/google/gwt/user/client/ui/HTMLTable.java	Tue Sep  7  
06:57:03 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/HTMLTable.java	Tue Sep  7  
14:01:53 2010

@@ -725,7 +725,7 @@
   }

   public HandlerRegistration addDoubleClickHandler(DoubleClickHandler  
handler) {

-return addDomHandler(handler, DoubleClickEvent.getType());
+return addHandler(handler, DoubleClickEvent.getType());
   }

   /**
===
--- /trunk/user/src/com/google/gwt/user/client/ui/Hyperlink.java	Tue Sep  7  
06:57:03 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/Hyperlink.java	Tue Sep  7  
14:01:53 2010

@@ -18,7 +18,10 @@
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.event.dom.client.ClickEvent;
 import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.event.dom.client.DoubleClickEvent;
+import com.google.gwt.event.dom.client.DoubleClickHandler;
 import com.google.gwt.event.dom.client.HasClickHandlers;
+import com.google.gwt.event.dom.client.HasDoubleClickHandlers;
 import com.google.gwt.event.shared.HandlerRegistration;
 import com.google.gwt.user.client.DOM;
 import com.google.gwt.user.client.Element;
@@ -60,7 +63,7 @@
  */
 @SuppressWarnings(deprecation)
 public class Hyperlink extends Widget implements HasHTML,  
SourcesClickEvents,

-HasClickHandlers {
+HasClickHandlers, HasDoubleClickHandlers {

   private static HyperlinkImpl impl = GWT.create(HyperlinkImpl.class);

@@ -137,6 +140,10 @@
   public void addClickListener(ClickListener listener) {
 ListenerWrapper.WrappedClickListener.add(this, listener);
   }
+
+  public HandlerRegistration addDoubleClickHandler(DoubleClickHandler  
handler) {

+return addHandler(handler, DoubleClickEvent.getType());
+  }

   public String getHTML() {
 return DOM.getInnerHTML(anchorElem);
===
--- /trunk/user/src/com/google/gwt/user/client/ui/Image.java	Tue Sep  7  
06:57:03 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/Image.java	Tue Sep  7  
14:01:53 2010

@@ -125,7 +125,7 @@
   image.replaceElement(impl.createStructure(url, left, top, width,  
height));
   // Todo(ecc) This is wrong, we should not be sinking these here on  
such a

   // common widget.After the branch is stable, this should be fixed.
-  image.sinkEvents(Event.ONCLICK | Event.ONDBLCLICK |  
Event.MOUSEEVENTS | Event.ONMOUSEWHEEL
+  image.sinkEvents(Event.ONCLICK | Event.MOUSEEVENTS |  
Event.ONMOUSEWHEEL

   | Event.ONLOAD);
 }

@@ -282,7 +282,7 @@
 UnclippedState(Element element) {
   // This case is relatively unusual, in that we swapped a clipped  
image

   // out, so does not need to be efficient.
-  Event.sinkEvents(element, Event.ONCLICK | Event.ONDBLCLICK |  
Event.MOUSEEVENTS

+  Event.sinkEvents(element, Event.ONCLICK | Event.MOUSEEVENTS
   | Event.ONLOAD | Event.ONERROR | Event.ONMOUSEWHEEL);
 }

@@ -294,7 +294,7 @@
   Event.sinkEvents(image.getElement(), Event.ONLOAD);

   // Todo(ecc) this could be more efficient overall.
-  image.sinkEvents(Event.ONCLICK | Event.ONDBLCLICK |  
Event.MOUSEEVENTS | Event.ONLOAD

+  image.sinkEvents(Event.ONCLICK | Event.MOUSEEVENTS | Event.ONLOAD
   | Event.ONERROR | Event.ONMOUSEWHEEL);
 }

===
--- /trunk/user/src/com/google/gwt/user/client/ui/Label.java	Tue Sep  7  
06:57:03 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/Label.java	Tue Sep  7  
14:01:53 2010

@@ -216,7 +216,7 @@
   }

   public HandlerRegistration addDoubleClickHandler(DoubleClickHandler  
handler) {

-return addDomHandler(handler, DoubleClickEvent.getType());
+return addHandler(handler, DoubleClickEvent.getType());
   }

   public HandlerRegistration 

[gwt-contrib] [google-web-toolkit] r8728 committed - Fix checkstyle error introduced at r8726

2010-09-07 Thread codesite-noreply

Revision: 8728
Author: rj...@google.com
Date: Tue Sep  7 14:07:00 2010
Log: Fix checkstyle error introduced at r8726

http://code.google.com/p/google-web-toolkit/source/detail?r=8728

Modified:
  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java


===
---  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java	 
Tue Sep  7 12:42:09 2010
+++  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java	 
Tue Sep  7 14:07:00 2010

@@ -86,20 +86,20 @@

   /**
* Returns the {...@link #nextPlaceholder(String, String, String)}, using  
the
-   * given {...@code name} and {...@code value} and a standard opening tag as  
example
+   * given {...@code name} and {...@code value} and a standard closing tag as  
example

* text.
*/
-  protected String nextOpenPlaceholder(String name, String value) {
-return nextPlaceholder(name, EXAMPLE_OPEN_TAG, value);
+  protected String nextClosePlaceholder(String name, String value) {
+return nextPlaceholder(name, EXAMPLE_CLOSE_TAG, value);
   }

   /**
* Returns the {...@link #nextPlaceholder(String, String, String)}, using  
the
-   * given {...@code name} and {...@code value} and a standard closing tag as  
example
+   * given {...@code name} and {...@code value} and a standard opening tag as  
example

* text.
*/
-  protected String nextClosePlaceholder(String name, String value) {
-return nextPlaceholder(name, EXAMPLE_CLOSE_TAG, value);
+  protected String nextOpenPlaceholder(String name, String value) {
+return nextPlaceholder(name, EXAMPLE_OPEN_TAG, value);
   }

   /**

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Allow Checkbox to accept null as valid. (issue831803)

2010-09-07 Thread rjrjr

LGTM

Thanks, Ray. One wording nit.


http://gwt-code-reviews.appspot.com/831803/diff/1/3
File user/src/com/google/gwt/user/client/ui/HasValue.java (right):

http://gwt-code-reviews.appspot.com/831803/diff/1/3#newcode48
user/src/com/google/gwt/user/client/ui/HasValue.java:48: * p
How about:

Widgets must accept null as a valid value. By convention, setting a
widget to null clears its value, calling getValue() on a cleared widget
returns null. Widgets that cannot be cleared (e.g. {...@link CheckBox})
must find another valid meaning for null input.

http://gwt-code-reviews.appspot.com/831803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-07 Thread nchalko


http://gwt-code-reviews.appspot.com/845801/diff/5001/6008
File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right):

http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24
user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private
final Class? clazz;
On 2010/09/07 15:04:35, bobv wrote:

Could you change this to a JType or JClassType instead?  It's kind of

weird for

generator models to use the class objects, since it may be the case

that there

is no compiled version of the type available to the generator.


Done.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6009
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/845801/diff/5001/6009#newcode92
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:92:
// HashSetConstraintViolationT();
On 2010/09/07 15:04:35, bobv wrote:

+1 to example comments.

:-)

http://gwt-code-reviews.appspot.com/845801/diff/5001/6011
File user/src/com/google/gwt/validation/rebind/ValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/845801/diff/5001/6011#newcode46
user/src/com/google/gwt/validation/rebind/ValidatorCreator.java:46:
private static final WeakHashMapTypeOracle, MapString, BeanHelper
helpers = new WeakHashMapTypeOracle, MapString, BeanHelper();
On 2010/09/07 15:04:35, bobv wrote:

There's some ongoing work on the compiler-side of things to figure out

the best

way to cache this kind of data.  The current approach for data whose

lifetime is

bounded by the TypeOracle is to stash the map in a ThreadLocal, since

each GWT

module lives in its own thread in DevMode.


Done.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6011#newcode56
user/src/com/google/gwt/validation/rebind/ValidatorCreator.java:56:
private final MapString, BeanHelper beansToValidate = new
HashMapString, BeanHelper();
On 2010/09/07 15:04:35, bobv wrote:

You might want to use the StringKey utility class to make the generic

signature

more informative.


Done.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6013
File user/test/com/google/gwt/validation/example/client/AuthorTest.java
(right):

http://gwt-code-reviews.appspot.com/845801/diff/5001/6013#newcode37
user/test/com/google/gwt/validation/example/client/AuthorTest.java:37:
// @Override
On 2010/09/07 15:04:35, bobv wrote:

Old code?


Done.

http://gwt-code-reviews.appspot.com/845801/diff/5001/6013#newcode47
user/test/com/google/gwt/validation/example/client/AuthorTest.java:47:
// expected
On 2010/09/07 15:04:35, bobv wrote:

Style: You can name the variable expected and eliminate the comment.


Done.

http://gwt-code-reviews.appspot.com/845801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-07 Thread nchalko

http://gwt-code-reviews.appspot.com/845801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors