Re: CellTable disapears when a row click occurs and a RichTextArea widget is present
It looks fine to me, can you send the code where you play with the cellList and the RichTextArea? On Fri, Jun 7, 2013 at 12:03 AM, Luis Costa luferco...@gmail.com wrote: Here it is a simple case (see attachment) Quinta-feira, 6 de Junho de 2013 19:58:56 UTC+1, Luis Costa escreveu: Hi all, I'm using GWT 2.5.1 and GWTP. Something very strange is happening, I've a RichTextArea widget and a cellTable. If I try to select a row all cellTable disappears! But if I remove RichTextArea widget or replace the cellTable for a DataGrid and select a row (clicking in the cellTable/ DataGrid row) it works fine; Is this a known problem? Many thanks, Luis Costa -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- El precio es lo que pagas. El valor es lo que recibes. Warren Buffet -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: javascript call to java method doesn´t work in developing mode - but when code is compiled (GWT 2.51)
Works now, I guess it has something todo with these issues Playing araound with the parameters I run into other issues which look a little bit like these ones http://code.google.com/p/google-web-toolkit/issues/detail?id=4941 and http://code.google.com/p/google-web-toolkit/issues/detail?id=4996 But then it was fine in dev mode too -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
GWT-RPC call is throwing JavaScriptException for huge number of records
Hi, My GWT-RPC call is working fine for some number records (around 600). But the same RPC call is throwing JavaScript Error for huge number of records. My server side call is returning/transferring ArrayofObject(MapItem[]) which contains around 20 attributes to client side. Error: com.google.gwt.core.client.JavaScriptException:(SyntaxError);Expected ')' description: Expected ')' number: -2146827282 I have verified below things. But everything looks fine. 1. Any invalid character in the data. But the Data looks fine 2. JDBC timeout – There is no timeout while fetching the huge records. Server side code is returning the records successfully. 3. RPC Request Timeout – It is not throwing any timeout exception. 4. WriteResponse was successful in RemoteServiceServlet. So I just want to know is there any limit in the RPC call? If so is there any alternative way which I can use for huge data? I am using GWT 2.3, java 1.5 and weblogic 10.2. Thanks in advance for you help.. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: No source code is available for type com.google.gwt.autobean.shared.AutoBean
thanks. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Acitivities and places:problem in using eventBus
Hi everyBody,
I want to transfer an object from an activity to another one, for that i
used the event bus:
1. i created an event AddSoumissionEvent and handler
AddSoumissionHandler
2.intialise the eventbus of the first activity with the eventBus offered in
the start Function
public void start(AcceptsOneWidget containerWidget, EventBus eventBus) {
this.eventBus=eventBus;
...
}
3.i fire event in the first activity
public void createSoumission(DynamicForm form) {
//create soumission
Soumission soumission=new Soumission();
//initialize values
//fire event
eventBus.fireEvent(new AddSoumissionEvent(soumission));
}
4. the second activity receive the event ,i created the handler in in start
funtion
public void start(AcceptsOneWidget container, EventBus eventBus) {
eventBus.addHandler(AddSoumissionEvent.TYPE, new AddSoumissionHandler(){
public void onAddSoumissionHandler(AddSoumissionEvent event)
{
System.out.println( event received youp);
onAddSoum();
}
});
}
the problem is the second activity doesn't receive the event :( i can't see
where is the mistake .
can anyone here tell me where is the mistake or give me a link for an
example who shows how to use the eventBus with activities and places
Thank you,
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: javascript call to java method doesn´t work in developing mode - but when code is compiled (GWT 2.51)
On Thursday, June 6, 2013 7:50:09 PM UTC+2, Olaf Raether wrote:
If have a Class that looks similar like this:
public class MyClass extends Widget {
public MyClass() {
declareMethod(this);
}
//Method which declares non-static method in javascript
public native void declareMethod(MyClass this) /*-{
var _this = this;
$wnd.doSomething = function(someString) {
_this.@com.example.MyClass::doSomething(Ljava/lang/String;)(someString);
}
}-*/;}
Calling something 'this' is a really bad idea. 'this' is a keyword, and I'm
surprised this even compiles (though maybe it's allowed in Java, I haven't
checked). That said, in this case, both the argument and 'this' should be
the same value so it shouldn't be a problem.
This code is missing a call to $entry() though:
$wnd.doSomething = $entry(function(someString) {
_this.@com.example.MyClass::doSomething(Ljava/lang/String;)(someString);
});
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Acitivities and places:problem in using eventBus
Can you show the code of the AddSoumissionEvent?
On Friday, June 7, 2013 1:10:17 PM UTC+2, Sahli Sabrina wrote:
Hi everyBody,
I want to transfer an object from an activity to another one, for that i
used the event bus:
1. i created an event AddSoumissionEvent and handler
AddSoumissionHandler
2.intialise the eventbus of the first activity with the eventBus offered
in the start Function
public void start(AcceptsOneWidget containerWidget, EventBus eventBus) {
this.eventBus=eventBus;
...
}
3.i fire event in the first activity
public void createSoumission(DynamicForm form) {
//create soumission
Soumission soumission=new Soumission();
//initialize values
//fire event
eventBus.fireEvent(new AddSoumissionEvent(soumission));
}
4. the second activity receive the event ,i created the handler in in
start funtion
public void start(AcceptsOneWidget container, EventBus eventBus) {
eventBus.addHandler(AddSoumissionEvent.TYPE, new AddSoumissionHandler(){
public void onAddSoumissionHandler(AddSoumissionEvent
event) {
System.out.println( event received youp);
onAddSoum();
}
});
}
the problem is the second activity doesn't receive the event :( i can't
see where is the mistake .
can anyone here tell me where is the mistake or give me a link for an
example who shows how to use the eventBus with activities and places
Thank you,
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
TabLayoutPanel get index of tab which added a special widget
Hi, I'm struggling getting the index of a tab in a TabLayoutPanel. I am working on legacy code so no big chance changing panel types and stuff. Code looks like this: TabLayoutPanel tabLayoutPanel = new TabLayoutPanel(); MyView myView = new MyView(); tabLayoutPanel.add(myView , Tab name); Later I need to select the right tab. tabPanel.selectTab(3); At the moment the tab containing myView is the fourth which is added but I want to avoid magic numbers. Is there an appropriate way to get the tab's index which contains myView? I tried searching by widget but without success. May be not a big question but till now my attempts failed. Today is not my day. Thanks in advance. Best regards Jochen -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Acitivities and places:problem in using eventBus
thank you for the reply here is the code
public class AddSoumissionEvent extends GwtEventAddSoumissionHandler{
public static TypeAddSoumissionHandlerTYPE= new
TypeAddSoumissionHandler();
private Soumission soumission;
public AddSoumissionEvent(Soumission soumission) {
this.soumission=soumission;
}
public Soumission getSoumission() {
return soumission;
}
public void setSoumission(Soumission soumission) {
this.soumission = soumission;
}
@Override
protected void dispatch(AddSoumissionHandler handler) {
handler.onAddSoumissionHandler(this);
}
@Override
public com.google.gwt.event.shared.GwtEvent.TypeAddSoumissionHandler
getAssociatedType() {
// TODO Auto-generated method stub
return TYPE;
}
}
Le vendredi 7 juin 2013 13:21:27 UTC+2, Thomas Broyer a écrit :
Can you show the code of the AddSoumissionEvent?
On Friday, June 7, 2013 1:10:17 PM UTC+2, Sahli Sabrina wrote:
Hi everyBody,
I want to transfer an object from an activity to another one, for that i
used the event bus:
1. i created an event AddSoumissionEvent and handler
AddSoumissionHandler
2.intialise the eventbus of the first activity with the eventBus offered
in the start Function
public void start(AcceptsOneWidget containerWidget, EventBus eventBus) {
this.eventBus=eventBus;
...
}
3.i fire event in the first activity
public void createSoumission(DynamicForm form) {
//create soumission
Soumission soumission=new Soumission();
//initialize values
//fire event
eventBus.fireEvent(new AddSoumissionEvent(soumission));
}
4. the second activity receive the event ,i created the handler in in
start funtion
public void start(AcceptsOneWidget container, EventBus eventBus) {
eventBus.addHandler(AddSoumissionEvent.TYPE, new AddSoumissionHandler(){
public void onAddSoumissionHandler(AddSoumissionEvent
event) {
System.out.println( event received youp);
onAddSoum();
}
});
}
the problem is the second activity doesn't receive the event :( i can't
see where is the mistake .
can anyone here tell me where is the mistake or give me a link for an
example who shows how to use the eventBus with activities and places
Thank you,
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Acitivities and places:problem in using eventBus
Ah, sorry, no idea (except you should use
com.google.web.bindery.event.shared.Event instead of
com.google.gwt.event.shared.GwtEvent, but that shouldn't change anything to
your problem)
On Friday, June 7, 2013 1:37:41 PM UTC+2, Sahli Sabrina wrote:
thank you for the reply here is the code
public class AddSoumissionEvent extends GwtEventAddSoumissionHandler{
public static TypeAddSoumissionHandlerTYPE= new
TypeAddSoumissionHandler();
private Soumission soumission;
public AddSoumissionEvent(Soumission soumission) {
this.soumission=soumission;
}
public Soumission getSoumission() {
return soumission;
}
public void setSoumission(Soumission soumission) {
this.soumission = soumission;
}
@Override
protected void dispatch(AddSoumissionHandler handler) {
handler.onAddSoumissionHandler(this);
}
@Override
public
com.google.gwt.event.shared.GwtEvent.TypeAddSoumissionHandler
getAssociatedType() {
// TODO Auto-generated method stub
return TYPE;
}
}
Le vendredi 7 juin 2013 13:21:27 UTC+2, Thomas Broyer a écrit :
Can you show the code of the AddSoumissionEvent?
On Friday, June 7, 2013 1:10:17 PM UTC+2, Sahli Sabrina wrote:
Hi everyBody,
I want to transfer an object from an activity to another one, for that i
used the event bus:
1. i created an event AddSoumissionEvent and handler
AddSoumissionHandler
2.intialise the eventbus of the first activity with the eventBus offered
in the start Function
public void start(AcceptsOneWidget containerWidget, EventBus eventBus) {
this.eventBus=eventBus;
...
}
3.i fire event in the first activity
public void createSoumission(DynamicForm form) {
//create soumission
Soumission soumission=new Soumission();
//initialize values
//fire event
eventBus.fireEvent(new AddSoumissionEvent(soumission));
}
4. the second activity receive the event ,i created the handler in in
start funtion
public void start(AcceptsOneWidget container, EventBus eventBus) {
eventBus.addHandler(AddSoumissionEvent.TYPE, new AddSoumissionHandler(){
public void onAddSoumissionHandler(AddSoumissionEvent
event) {
System.out.println( event received youp);
onAddSoum();
}
});
}
the problem is the second activity doesn't receive the event :( i can't
see where is the mistake .
can anyone here tell me where is the mistake or give me a link for an
example who shows how to use the eventBus with activities and places
Thank you,
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Acitivities and places:problem in using eventBus
ok thank you a lot for the reply :) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: TabLayoutPanel get index of tab which added a special widget
Hello Jochen, The index of a tab in a TabPanel is same as its corresponding widget in widgetContainer. Thus, Tab name index is same as 'myView' index. Using the view, you get its index from tabPanel.getWidgetIndex(myView) , which is same as the tab index, then you can proceed to select it. Regards, On Fri, Jun 7, 2013 at 2:33 PM, Jochen Schnaidt jochen.schna...@gmail.comwrote: Hi, I'm struggling getting the index of a tab in a TabLayoutPanel. I am working on legacy code so no big chance changing panel types and stuff. Code looks like this: TabLayoutPanel tabLayoutPanel = new TabLayoutPanel(); MyView myView = new MyView(); tabLayoutPanel.add(myView , Tab name); Later I need to select the right tab. tabPanel.selectTab(3); At the moment the tab containing myView is the fourth which is added but I want to avoid magic numbers. Is there an appropriate way to get the tab's index which contains myView? I tried searching by widget but without success. May be not a big question but till now my attempts failed. Today is not my day. Thanks in advance. Best regards Jochen -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- Donald Mteka +255653105004 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Acitivities and places:problem in using eventBus
Is the second Activity ever started before you fire the event from first Activity? Just check that you didn't fire the event before the second Activity had the chance to start (hence register a handler).. Another possibility would be different 'instances' of EventBus objects, which is hardly the case as the bus was offered from PlaceHistoryHandler. HTH. On Fri, Jun 7, 2013 at 2:57 PM, Sahli Sabrina sahli.sabr...@gmail.comwrote: ok thank you a lot for the reply :) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- Donald Mteka +255653105004 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Acitivities and places:problem in using eventBus
yes, the second activity started after the event is fired . Actually when i click in the button next in the first view, it called two functions in the first activity : 1.createSoumission() who fire the event 2.and goto (Place SecondPlace) i fixed the problem by switching the calls 1. i call the goto (secondPlace) 2.createSoumission() thank you a lot for you help, you saved my day Le vendredi 7 juin 2013 14:39:37 UTC+2, Donald Mteka a écrit : Is the second Activity ever started before you fire the event from first Activity? Just check that you didn't fire the event before the second Activity had the chance to start (hence register a handler).. Another possibility would be different 'instances' of EventBus objects, which is hardly the case as the bus was offered from PlaceHistoryHandler. HTH. On Fri, Jun 7, 2013 at 2:57 PM, Sahli Sabrina sahli@gmail.comjavascript: wrote: ok thank you a lot for the reply :) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com javascript:. To post to this group, send email to google-we...@googlegroups.comjavascript: . Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- Donald Mteka +255653105004 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
GWT HTML5 DnD
I figured out a way for users to DnD into GWT's RichTextArea from either
inside the GWT application and for us even more importantly from another
website/page. We had to use JSNI as the standard GWT drop listeners are
never fired, I assume it's because it uses an iFrame. I thought I'd post
it here as perhaps others will find it useful. Also if you see some
potential problems let me know as I'd like to improve it.
One question I have is should I be adding the listener to the iframe too or
just to iframe.contentWindow?
Also things works really well with Firefox I need to determine if any
changes are needed for IE8/9/10 and Chrome.
public class GwtRichTextArea extends RichTextArea {
private Object dragenterFunction = null;
private Object dragoverFunction = null;
private Object dropFunction = null;
public GwtRichTextArea () {
}
@Override
protected void onAttach() {
super.onAttach();
IFrameElement iFrame = IFrameElement.as(getElement());
iFrame.setName(UUID.uuid());
addDragOverHandler(iFrame);
addDropHandler(iFrame);
}
@Override
protected void onDetach() {
IFrameElement iFrame = IFrameElement.as(getElement());
removeDragOverHandler(iFrame);
removeDropHandler(iFrame);
super.onDetach();
}
private native void addDragEnterHandler(IFrameElement iframe)
/*-{
if (iframe == null)
return;
var _this = this;
var dragenterFunction = function (e) {
// todo: add some css style here
}
_th...@com.gwtcommon.gwt.user.client.ui.GwtRichTextArea::dragenterFunction
= dragenterFunction;
iframe.addEventListener('dragenter', dragenterFunction, true);
iframe.contentWindow.addEventListener('dragenter', dragenterFunction,
true);
}-*/;
private native void addDragOverHandler(IFrameElement iframe)
/*-{
if (iframe != null) {
var _this = this;
var dragoverFunction = function (e) {
if (e.preventDefault) {
e.preventDefault();
}
e.dataTransfer.dropEffect = 'copy';
return false;
}
_th...@com.gwtcommon.gwt.user.client.ui.GwtRichTextArea::dragoverFunction =
dragoverFunction;
iframe.addEventListener('dragover', dragoverFunction, true);
iframe.contentWindow.addEventListener('dragover', dragoverFunction,
true);
}
}-*/;
private native void addDropHandler(IFrameElement iframe)
/*-{
if (iframe == null) {
return;
}
var _this = this;
var dropFunction = function (event) {
// Handle the drop. We attach to the body element...
iframe.contentWindow.document.body.appendChild(newElement);
return false;
}
_th...@com.gwtcommon.gwt.user.client.ui.GWTRichTextArea::dropFunction =
dropFunction;
iframe.addEventListener('drop', dropFunction, true);
iframe.contentWindow.addEventListener('drop', dropFunction, true);
}-*/;
private native void removeDragOverHandler(IFrameElement iframe)
/*-{
if (iframe != null) {
var _this = this;
var dragoverFunction =
_th...@com.gwtcommon.gwt.user.client.ui.GWTRichTextArea::dragoverFunction;
iframe.removeEventListener('dragover', dragoverFunction, true);
iframe.contentWindow.removeEventListener('dragover',
dragoverFunction, true);
}
}-*/;
private native void removeDropHandler(IFrameElement iframe)
/*-{
if (iframe != null) {
var _this = this;
var dropFunction =
_th...@com.gwtcommon.gwt.user.client.ui.GWTRichTextArea::dropFunction;
iframe.removeEventListener('drop', dropFunction, true);
iframe.contentWindow.removeEventListener('drop', dropFunction,
true);
}
}-*/;
private native void removeTextPasteHandler(IFrameElement iframe)
/*-{
if (iframe != null) {
var _this = this;
var pasteFunction =
_th...@com.gwtcommon.gwt.user.client.ui.WebTASRichTextArea::pasteFunction;
iframe.removeEventListener('paste', pasteFunction, true);
iframe.contentWindow.removeEventListener('paste', pasteFunction,
true);
}
}-*/;
}
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
unwanted .junit_symbolMaps in war compiled by GWT
Hi Everyone, we are generating one war for our application by using GWT. But the war contains a folder called .junit_symbolMaps . I need to know how and why this folder generated, then i can stop in generation phase. And i don't want to delete this folder before war created. I want to reduce the compilation time. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: unwanted .junit_symbolMaps in war compiled by GWT
On Friday, June 7, 2013 3:15:56 PM UTC+2, anilva...@gmail.com wrote: Hi Everyone, we are generating one war for our application by using GWT. But the war contains a folder called .junit_symbolMaps . I need to know how and why this folder generated, then i can stop in generation phase. And i don't want to delete this folder before war created. I want to reduce the compilation time. You must be compiling a module that has an inherits name=com.google.gwt.junit.JUnit/ , there's no single reason to ever inherit the JUnit module. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Fast implementation of Design displays with GWT?
I like to know how people realize the design (Photoshop or other files) in GWT and what would be the best way? I still find it take too long to implement styles and stuff like that (not only a GWT issue), so I like to optimize this implementation/realization process: from the moment you receive the design till GWT realization. Thinks going through my mind: how to set up the GWT dev environment to let others concern about css issues?... But how ?.. Maybe do some templating stuff ? Or receive html/css snippets from the design party and implement them in GWT, but how ??. Note: I make fully use of ClientBundles and CssResources (with @Import)... PS: this is one of these things that I would love to see gwt dev team member blogging about ;).. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
ListEditor and persisting changes to the server
Hi, my goal is to get a kind of 'auto-persist' feature of my editors. I have - a class 'A' defining a ListEditor that creates a list of class 'B' editors - a class B that implements ValueAwareEditor with a CheckBox attribute - the ValueChangeHandler of the CheckBox calls driver.flush() - communication uses RequestFactoryEditorDriver Always if the value of some CheckBox has changed, I want the ListEditors parent class 'A' to call a persist service to immediately persist any changes in a sub-editor on the server.. An example with a 'Save' button in the class 'A' is already working. I can only find examples that require user input. A guess is that calling a (static) method A.persist() in the ValueChangeHandler of a CheckBox is not the right way. Probably you see that I'm very new to RequestFactory and Editors. Thanks in advance. Holger -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Fast implementation of Design displays with GWT?
Have you looked at Errai UI? http://vimeo.com/44141164 (I just watched the video, never tried it; but if you want something fast, it's looks impressive). As many things from Errai though (correct me if I'm wrong), it seems mostly designed towards developer productivity rather not application performance (how is the CSS shared? is it minified? optimized?) On Friday, June 7, 2013 3:39:58 PM UTC+2, Ed wrote: I like to know how people realize the design (Photoshop or other files) in GWT and what would be the best way? I still find it take too long to implement styles and stuff like that (not only a GWT issue), so I like to optimize this implementation/realization process: from the moment you receive the design till GWT realization. Thinks going through my mind: how to set up the GWT dev environment to let others concern about css issues?... But how ?.. Maybe do some templating stuff ? Or receive html/css snippets from the design party and implement them in GWT, but how ??. Note: I make fully use of ClientBundles and CssResources (with @Import)... PS: this is one of these things that I would love to see gwt dev team member blogging about ;).. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
determine if running on client or server OR synchronize time on server/client?
Hi,
my chess application should trust only the server time.
However, I have a shared class that is used both on server and client.
Within this class I determine the current time by creating a new Date
object.
When running on the server, this object represents the correct time. When
running on the client, I would like to synchronize it with the server
before using it.
But how can I tell if I am running on the server or the client?
Below is a short pseudo code for illustration.
Thanks
Magnus
-
class ChessClock
{
...
private int offset; // delta between server and client time
...
private Date getCurrentTime ()
{
Date d = new Date ();
if (!runningOnServer ())
{
long ms = d.getTime () + offset;
d = new Date (ms);
}
}
private boolean runningOnServer ()
{
// how to determine???
}
}
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Fast implementation of Design displays with GWT?
Agree with Thomas. You can use the UiBinder stuff as well. Saying to your designer Implements the style tag of the files which end in ui.xml :D. If you designer knows something about programming, he/she can do the resources as well, and let the rest to the programmers. Also other option is integrate a powerful CMS such us Magnolia with your GWT app. I have done a couple of simple examples and it works really well. My 2 cents, Adolfo. On Fri, Jun 7, 2013 at 4:31 PM, Thomas Broyer t.bro...@gmail.com wrote: Have you looked at Errai UI? http://vimeo.com/44141164 (I just watched the video, never tried it; but if you want something fast, it's looks impressive). As many things from Errai though (correct me if I'm wrong), it seems mostly designed towards developer productivity rather not application performance (how is the CSS shared? is it minified? optimized?) On Friday, June 7, 2013 3:39:58 PM UTC+2, Ed wrote: I like to know how people realize the design (Photoshop or other files) in GWT and what would be the best way? I still find it take too long to implement styles and stuff like that (not only a GWT issue), so I like to optimize this implementation/realization process: from the moment you receive the design till GWT realization. Thinks going through my mind: how to set up the GWT dev environment to let others concern about css issues?... But how ?.. Maybe do some templating stuff ? Or receive html/css snippets from the design party and implement them in GWT, but how ??. Note: I make fully use of ClientBundles and CssResources (with @Import)... PS: this is one of these things that I would love to see gwt dev team member blogging about ;).. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- El precio es lo que pagas. El valor es lo que recibes. Warren Buffet -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT2.4 RequestFactory and Hibernate validator 4.2 problem
Hi Thomas Thanks for the link!! Cheers Chris On Thursday, 6 June 2013 01:42:01 UTC+1, Thomas Broyer wrote: You might be interested by https://code.google.com/p/google-web-toolkit/issues/detail?id=7661 On Wednesday, June 5, 2013 11:07:51 PM UTC+2, CM wrote: HI thank you for your post, this fixed it for me. Cheers Chris On Tuesday, 20 December 2011 20:48:05 UTC, Jesus Urenda wrote: I was able to fix this issue in my environment but I'm not 100% sure why. Basically all I did was to remove the hibernate jar out of the WEB-INF/lib but made sure it was still part of the projects build path. Contents of WEB-INF/lib appengine-api-1.0-sdk-1.6.0.jar appengine-api-labs-1.6.0.jar appengine-jsr107cache-1.6.0.jar apps-marketplace.jar datanucleus-appengine-1.0.10.final.jar datanucleus-core-1.1.5.jar datanucleus-jpa-1.1.5.jar geronimo-jpa_3.0_spec-1.1.1.jar geronimo-jta_1.1_spec-1.1.1.jar gwt-servlet-deps.jar gwt-servlet.jar jdo2-api-2.3-eb.jar jsr107cache-1.1.jar objectify-3.1.jar requestfactory-apt.jar requestfactory-server.jar slf4j-api-1.6.1.jar slf4j-log4j12-1.6.1.jar validation-api-1.0.0.GA.jar I hope this helps. On Dec 10, 9:39 am, Ruben Leal rusol...@gmail.com wrote: Hello guys, I'm trying to test gwt2.4 RequestFactory technology with Hibernate validator 4.2. After adding libs to my WEB-INF/lib I have this exception when I try to call persist of a simple object in the client side. I have this exception executing in local mode: java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z Deploying to app engine servers I have this exception: java.lang.IllegalAccessError: tried to access field org.slf4j.impl.StaticLoggerBinder.SINGLETON from class org.slf4j.LoggerFactory I search on google about similar errors and people speak about slf4j library versions. I tried to use different old versions with same hibernate validator version and same errors. Please some solution to my problem? this is the list of files in my WEB-INF/lib folder: /identidad/war/WEB-INF/lib/appengine-api-1.0-sdk-1.6.0.jar /identidad/war/WEB-INF/lib/appengine-api-labs-1.6.0.jar /identidad/war/WEB-INF/lib/appengine-jsr107cache-1.6.0.jar /identidad/war/WEB-INF/lib/apps-marketplace.jar /identidad/war/WEB-INF/lib/datanucleus-appengine-1.0.10.final.jar /identidad/war/WEB-INF/lib/datanucleus-core-1.1.5.jar /identidad/war/WEB-INF/lib/datanucleus-jpa-1.1.5.jar /identidad/war/WEB-INF/lib/geronimo-jpa_3.0_spec-1.1.1.jar /identidad/war/WEB-INF/lib/geronimo-jta_1.1_spec-1.1.1.jar /identidad/war/WEB-INF/lib/gwt-servlet-deps.jar /identidad/war/WEB-INF/lib/gwt-servlet.jar /identidad/war/WEB-INF/lib/hibernate-validator-4.2.0.Final.jar /identidad/war/WEB-INF/lib/jdo2-api-2.3-eb.jar /identidad/war/WEB-INF/lib/joda-time-1.6.jar /identidad/war/WEB-INF/lib/jsoup-1.5.2.jar /identidad/war/WEB-INF/lib/jsr107cache-1.1.jar /identidad/war/WEB-INF/lib/log4j-1.2.16.jar /identidad/war/WEB-INF/lib/requestfactory-server.jar /identidad/war/WEB-INF/lib/slf4j-api-1.6.1.jar /identidad/war/WEB-INF/lib/slf4j-log4j12-1.6.1.jar /identidad/war/WEB-INF/lib/validation-api-1.0.0.GA.jar -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: determine if running on client or server OR synchronize time on server/client?
Use com.google.gwt.core.shared.GWT.isClient()
Paul
On 07/06/13 15:34, Magnus wrote:
Hi,
my chess application should trust only the server time.
However, I have a shared class that is used both on server and client.
Within this class I determine the current time by creating a new Date object.
When running on the server, this object represents the correct time. When
running on the client, I would like to synchronize it with the server before
using it.
But how can I tell if I am running on the server or the client?
Below is a short pseudo code for illustration.
Thanks
Magnus
-
class ChessClock
{
...
private int offset; // delta between server and client time
...
private Date getCurrentTime ()
{
Date d = new Date ();
if (!runningOnServer ())
{
long ms = d.getTime () + offset;
d = new Date (ms);
}
}
private boolean runningOnServer ()
{
// how to determine???
}
}
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an
email to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Fast implementation of Design displays with GWT?
Have you looked at Errai UI? http://vimeo.com/44141164 I did some time ago, through a webinar. I will have a look again, see if I can get some inspiration. Thanks for the tip.. (how is the CSS shared? is it minified? optimized?) Every component/widget has his own Resource stuff (ClientBundle/CssResource). So, yes, it's minified... Just a tought that is going around in my head: The gwt dev developer roughly implements the styles, shows/gives it to the designer and the designer uses some kind of tool/browser-plugin to make changes and report the changes back to the developer... But how ??... You can use the UiBinder stuff as well. Yes, but UiBinder is such a static thing. Used it a lot in the beginning (still use it), but every time use it less, as I require more dynamic behavior Also other option is integrate a powerful CMS such us Magnolia with your GWT app. Could you give some more details on this? BTW: I work cms agnostic: the cms publish files that are cached infinitive (just like the GWT files) and picked up by the gwt app in the split points when needed. When new cms files are published, a cms build id is incremented in the index.html file such that a new url is used to load the cms files such that they are refreshed... Still searching for the half-silver bullet ;) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: javascript call to java method doesn´t work in developing mode - but when code is compiled (GWT 2.51)
Agreed ! - but it´s just a typing error for this post.
Thank´s for the comment.
On Friday, June 7, 2013 1:16:24 PM UTC+2, Thomas Broyer wrote:
On Thursday, June 6, 2013 7:50:09 PM UTC+2, Olaf Raether wrote:
If have a Class that looks similar like this:
public class MyClass extends Widget {
public MyClass() {
declareMethod(this);
}
//Method which declares non-static method in javascript
public native void declareMethod(MyClass this) /*-{
var _this = this;
$wnd.doSomething = function(someString) {
_this.@com.example.MyClass::doSomething(Ljava/lang/String;)(someString);
}
}-*/;}
Calling something 'this' is a really bad idea. 'this' is a keyword, and
I'm surprised this even compiles (though maybe it's allowed in Java, I
haven't checked). That said, in this case, both the argument and 'this'
should be the same value so it shouldn't be a problem.
This code is missing a call to $entry() though:
$wnd.doSomething = $entry(function(someString) {
_this.@com.example.MyClass::doSomething(Ljava/lang/String;)(someString);
});
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
GWT frontend, non java backend
I've read a few different sources about how to create projects with a GWT front and a non-java backend. Well how about hosting, how do you host a GWT front end? We've been primarily developing GWT/GXT applications for the past 5 or 6 years until we got bought out recently and their forcing us to use Ruby on Rails for the back end. I'm in the process of researching how we could use GWT as the front end. Any tips, links, tutorials, anything to help me figure this process out would be greatly appreciated. Thank you -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CellTable disapears when a row click occurs and a RichTextArea widget is present
I cant replicate this problem that was occuring yesterday. thank your for your help but for now this problem seems to be resolved. Quinta-feira, 6 de Junho de 2013 19:58:56 UTC+1, Luis Costa escreveu: Hi all, I'm using GWT 2.5.1 and GWTP. Something very strange is happening, I've a RichTextArea widget and a cellTable. If I try to select a row all cellTable disappears! But if I remove RichTextArea widget or replace the cellTable for a DataGrid and select a row (clicking in the cellTable/ DataGrid row) it works fine; Is this a known problem? Many thanks, Luis Costa -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Fast implementation of Design displays with GWT?
(how is the CSS shared? is it minified? optimized?) Every component/widget has his own Resource stuff (ClientBundle/CssResource). So, yes, it's minified... Sorry about the strange answer, wasn't reading well, bit sleepy ;) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: GWT RPC not working if GWT application is started from file ...
Daniel Kurka has posted comments on this change. Change subject: GWT RPC not working if GWT application is started from file system ISSUE 7436 .. Patch Set 5: Hi Thomas, the change is not about @RemoteServiceRelativePath. This is about making GWT RPC work when loaded from file system. Because moduleBaseURL is final in RemoteServiceProxy there is no way of setting this at runtime today, it alway defaults to moduleBase and this is somewhat file:// for phonegap applications. (same for chrome extension) While GWT RPC is really bad for applications where you are not in control of the update cycle it is still widely used with gwt-phonegap and there we use JSNI trickery to make it work. I would much rather see a straight forward way directly in GWT. -- To view, visit https://gwt-review.googlesource.com/1652 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I294b53c705ff82e572cd4b17c60a0e89c1b294de Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] widget interfaces
FYI: the IsElement interfaces corresponds to issue 7497: http://code.google.com/p/google-web-toolkit/issues/detail?id=7497 On Fri, Jun 7, 2013 at 5:03 AM, Stephen Haberman step...@exigencecorp.comwrote: If nobody else has any other concerns, I recommend you to start with an example interface to get early feedback and iterate from there. So, I was going to start with just one, but copy/pasting them over and changing the package name was pretty easy, so: https://gwt-review.googlesource.com/#/c/3231/ I only changed a few of the widgets to implement their IsXxx counterpart (Button, ComplexPanel, AbsolutePanel)--all pretty trivial. I didn't realize this before, but I ended up slipping IsElement in here because it's part of the extended IsWidget interface. There are some other IsElement related things, like having IsElement extend HasStyle and HasText that I'm flexible on, but are handy IMO. Very much request for comment sort of state. Anyone feel free to respond here or in the code review. - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to a topic in the Google Groups GWT Contributors group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/odoaoi1s7N0/unsubscribe?hl=en-US . To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add support for 'ImageResource' to @url substitution in css....
Daniel Kurka has posted comments on this change. Change subject: Add support for 'ImageResource' to @url substitution in css. Only 'DataResource' used to be supported. .. Patch Set 1: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/3290 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6ae9fe0ace59eb682a77a761fe252bf46cafa9f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Emmanuel Pellereau emmanu...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#8). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Use JSON.parse() instead of eval() to deserialize rpc callback payload IE9 is currently leaking memory on every RPC call you make. The root cause is that eval() on IE9 is designed to keep everyting evaled in memory until the browser session dies (see http://support.microsoft.com/kb/2572253). To work around this issue this patch instead of using eval() on the RPC callback payload uses JSON.parse which does not have these problems. Since JSON does not support the special values NaN, Infinity and -Infinity they are now converted into strings and later converted back with Number(x) on the client side. The default RPC version still remains as 7 and this patch introduces a new system variable gwt.rpc.version which can be set to 8 to resolve the memory leak. Special cases where hacks have been applied to circumvent browser limitations (string literal size limitation, array size limitation) will still be applied in version 8 and will still be evaled instead of JSON.parsed on the client side. Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f --- M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java M user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/RPC.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java M user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/test/com/google/gwt/user/RPCSuite.java A user/test/com/google/gwt/user/client/rpc/impl/WebModeClientSerializationStreamReaderTest.java 9 files changed, 189 insertions(+), 30 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
John Ahlroos has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 7: (2 comments) File user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java Line 328: if (getVersion() SERIALIZATION_STREAM_MIN_VERSION There a a couple of places where the min version is explicitly used (ServerSerializationStreamWriter.writeLong() for instance). If we bump the min version then this code would then be obsolete and should either be removed or taken into consideration in version 7. I would rather do that in another changeset so those cases can be discussed separatly. File user/src/com/google/gwt/user/server/rpc/RPC.java Line 602: : AbstractSerializationStream.SERIALIZATION_STREAM_VERSION; Yes, that would be a good idea. AFAIK Integer.getInteger() does not throw but returns null. At least according to the oracle docs http://docs.oracle.com/javase/6/docs/api/java/lang/Integer.html#getInteger%28java.lang.String%29 -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#9). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Use JSON.parse() instead of eval() to deserialize rpc callback payload IE9 is currently leaking memory on every RPC call you make. The root cause is that eval() on IE9 is designed to keep everyting evaled in memory until the browser session dies (see http://support.microsoft.com/kb/2572253). To work around this issue this patch instead of using eval() on the RPC callback payload uses JSON.parse which does not have these problems. Since JSON does not support the special values NaN, Infinity and -Infinity they are now converted into strings and later converted back with Number(x) on the client side. The default RPC version still remains as 7 and this patch introduces a new system variable gwt.rpc.version which can be set to 8 to resolve the memory leak. Special cases where hacks have been applied to circumvent browser limitations (string literal size limitation, array size limitation) will still be applied in version 8 and will still be evaled instead of JSON.parsed on the client side. Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f --- M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java M user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/RPC.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java M user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/test/com/google/gwt/user/RPCSuite.java A user/test/com/google/gwt/user/client/rpc/impl/WebModeClientSerializationStreamReaderTest.java 9 files changed, 187 insertions(+), 28 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...
Thomas Broyer has posted comments on this change.
Change subject: FileUpload: extending FocusWidget instead of Widget so as
it exposes many features which already are in the file-input element:
click(), focus(), mouseevents, keyevents, etc.
..
Patch Set 2: Code-Review+1
(3 comments)
File user/src/com/google/gwt/dom/client/DOMImplMozilla.java
Line 75: if (isGecko19()) {
Maybe we can take this opportunity to rewrite isGecko19 as a static
non-JSNI method like the other isGecko*OrBefore methods?
But I actually wonder what version(s) of Firefox we really do want to
continue supporting. I'd be in favor of only supporting the last ESR (or
maybe the last two ESR) version and every version after that. We could then
remove all those isGecko hacks.
That can be punt to another patch though.
File user/src/com/google/gwt/user/client/ui/FileUpload.java
Line 198:* Programmatic equivalent of the user clicking the button.
Should we add a note about browser support here? (similar to what you have
in the commit message; maybe add something about click() not working when
the widget is {@link #isVisible() hidden} in some browsers?)
File user/test/com/google/gwt/user/client/ui/ButtonTest.java
Line 39: // protected because it is used in FileUploadTest
I think we should just duplicate it there.
--
To view, visit https://gwt-review.googlesource.com/3211
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Manuel Carrasco Moñino manuel.carrasc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Make PopupPanel#setAnimationType public (issue1893803)
If you still care about it, could you please move the patch over to Gerrit? http://www.gwtproject.org/makinggwtbetter.html http://gwt-code-reviews.appspot.com/1893803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...
Manuel Carrasco Moñino has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. .. Patch Set 2: (2 comments) File user/src/com/google/gwt/user/client/ui/FileUpload.java Line 198:* Programmatic equivalent of the user clicking the button. Yes, I'll update the javadoc to add a note with supported browsers. Related with setVisible, isVisible, I have planned a different patch so as we can use a different implementation per browser so as user has not to worry about which hack use to hide the file input. File user/test/com/google/gwt/user/client/ui/ButtonTest.java Line 39: // protected because it is used in FileUploadTest They are in the same package, and does the same so just a way to not duplicate code. I dont think a future change in the handler could break the product since they are tests and the second test would fail, but if you think it's better to duplicate, its ok. -- To view, visit https://gwt-review.googlesource.com/3211 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#10). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Use JSON.parse() instead of eval() to deserialize rpc callback payload IE9 is currently leaking memory on every RPC call you make. The root cause is that eval() on IE9 is designed to keep everyting evaled in memory until the browser session dies (see http://support.microsoft.com/kb/2572253). To work around this issue this patch instead of using eval() on the RPC callback payload uses JSON.parse which does not have these problems. Since JSON does not support the special values NaN, Infinity and -Infinity they are now converted into strings and later converted back with Number(x) on the client side. The default RPC version still remains as 7 and this patch introduces a new system variable gwt.rpc.version which can be set to 8 to resolve the memory leak. Special cases where hacks have been applied to circumvent browser limitations (string literal size limitation, array size limitation) will still be applied in version 8 and will still be evaled instead of JSON.parsed on the client side. Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f --- M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java M user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/RPC.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java M user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/test/com/google/gwt/user/RPCSuite.java A user/test/com/google/gwt/user/client/rpc/impl/WebModeClientSerializationStreamReaderTest.java 9 files changed, 187 insertions(+), 28 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
John Ahlroos has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 10: Leeroy seems to be in a bad mood today :) -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add support for the newer bindery HandlerRegistration Bug:...
Julien Dramaix has posted comments on this change. Change subject: Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 .. Patch Set 6: Thomas I created the issue https://code.google.com/p/google-web-toolkit/issues/detail?id=8182 for the full support c.g.web.bindery.event in UiBinder. I will try to propose a patch in few days. -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#11). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Use JSON.parse() instead of eval() to deserialize rpc callback payload IE9 is currently leaking memory on every RPC call you make. The root cause is that eval() on IE9 is designed to keep everyting evaled in memory until the browser session dies (see http://support.microsoft.com/kb/2572253). To work around this issue this patch instead of using eval() on the RPC callback payload uses JSON.parse which does not have these problems. Since JSON does not support the special values NaN, Infinity and -Infinity they are now converted into strings and later converted back with Number(x) on the client side. The default RPC version still remains as 7 and this patch introduces a new system variable gwt.rpc.version which can be set to 8 to resolve the memory leak. Special cases where hacks have been applied to circumvent browser limitations (string literal size limitation, array size limitation) will still be applied in version 8 and will still be evaled instead of JSON.parsed on the client side. Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f --- M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java M user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/RPC.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java M user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/test/com/google/gwt/user/RPCSuite.java A user/test/com/google/gwt/user/client/rpc/impl/WebModeClientSerializationStreamReaderTest.java M user/test/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriterTest.java 10 files changed, 217 insertions(+), 27 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...
Patrick Tucker has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. .. Patch Set 2: (1 comment) File user/src/com/google/gwt/dom/client/DOMImplMozilla.java Line 195: - (elem.getScrollWidth() - elem.getClientWidth()); Having 4 spaces in front of this line was correct. See the style guide. -- To view, visit https://gwt-review.googlesource.com/3211 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] widget interfaces
Hi Ed, FYI: the IsElement interfaces corresponds to issue 7497: http://code.google.com/p/google-web-toolkit/issues/detail?id=7497 Oh, right, I forgot about that...well, maybe it will go in after all. :-) - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Enable EntityProxyId as an RequestFactory service method arg...
Daniel Kurka has posted comments on this change.
Change subject: Enable EntityProxyId as an RequestFactory service method
argument.
..
Patch Set 1:
(5 comments)
File
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
Line 1496: public void onSuccess(SimpleFooProxy foo) {
nit: trailing whitespace
Line 1508:
nit:trailing whitespace
Line 1523:
nit:trailing whitespace
File
user/test/com/google/web/bindery/requestfactory/shared/SimpleFooRequest.java
Line 127:
nit:trailing whitespace
Line 129:
nit:trailing whitespace
--
To view, visit https://gwt-review.googlesource.com/3091
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0427c3c6614abef71cd0dcc08acdff4d28bc9a5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Sam Hough sal...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...
Manuel Carrasco Moñino has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. .. Patch Set 2: (1 comment) File user/src/com/google/gwt/dom/client/DOMImplMozilla.java Line 195: - (elem.getScrollWidth() - elem.getClientWidth()); right, it seems that my IDE removed it when saving. -- To view, visit https://gwt-review.googlesource.com/3211 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
John Stalcup has uploaded a new change for review.
https://gwt-review.googlesource.com/3300
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's various constructors.
..
The job of defineSeed is to mark the existence of a class and associate its
castMap with the class's various constructors.
FragmentExtractor chooses whether and what part of a defineSeed call to
include in a fragment.
Previously this logic would only include a defineSeed function in a
fragment if the fragment was known to make the particular type in
question live.
In this usage live means that if you have ALL other fragments loaded then
you can not instantiate this type but the moment you additionally load
this fragment you become able to instantiate this type.
But it is possible that when you have ALL other fragments loaded you can
already instantiate this type and so when you load this fragment you do not
expand the liveness of this type but you DO suddenly make certain of its
constructors accessible that were not previously accessible. In this
situation previously logic would still not have included any defineSeed
function at all and as a consequence these newly live constructors were
never
getting their associated castMaps which led to runtime errors when casting
an instance that had been created by one of these broken constructors.
This CL relaxes the defineSeed inclusion restriction to include fragments
that are expanding a type's constructors liveness and not just fragments
that expand a type's liveness.
Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699
---
M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
M dev/core/src/com/google/gwt/dev/js/ast/JsName.java
M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java
A dev/core/test/com/google/gwt/dev/jjs/impl/FragmentExtractorTest.java
4 files changed, 332 insertions(+), 80 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
index 8d75fc9..d77b7d2 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
@@ -15,6 +15,7 @@
*/
package com.google.gwt.dev.jjs.impl;
+import com.google.gwt.core.client.impl.AsyncFragmentLoader;
import com.google.gwt.dev.jjs.SourceInfo;
import com.google.gwt.dev.jjs.ast.JClassType;
import com.google.gwt.dev.jjs.ast.JConstructor;
@@ -48,10 +49,25 @@
import java.util.Set;
/**
- * A class that extracts a fragment of code based on a supplied liveness
- * condition.
+ * Extracts multiple JS statements (called a fragment) out of the complete
JS program based on
+ * supplied type/method/field/string liveness conditions.
+ *
+ * p
+ * bLiveness as defined here is not an intuitive concept./b A type or
method (note that
+ * constructors are methods) is considered live for the current fragment
when that type can only be
+ * instantiated or method executed when the current fragment has already
been loaded. That does not
+ * always mean that it was caused by direct execution of the current
fragment. It may instead mean
+ * that direction execution of some other fragment has been affected by
the loading of the current
+ * fragment in a way that results in the instantiation of the type or
execution of the method. It is
+ * this second case that can lead to seemingly contradictory but valid
situations like having a type
+ * which is not currently live but which has a currently live constructor.
For example it might be
+ * possible to instantiate type Foo even with fragment Bar being loaded
(i.e. Foo is not live for
+ * Bar) but the loading of fragment Bar might be required to reach a
particular one of Bar's
+ * multiple constructor (i.e. that constructor is live for Bar).
+ * /p
*/
public class FragmentExtractor {
+
/**
* A {@link LivenessPredicate} that bases liveness on a single
* {@link ControlFlowAnalyzer}.
@@ -63,23 +79,28 @@
this.cfa = cfa;
}
+@Override
public boolean isLive(JDeclaredType type) {
return cfa.getInstantiatedTypes().contains(type);
}
+@Override
public boolean isLive(JField field) {
return cfa.getLiveFieldsAndMethods().contains(field)
|| cfa.getFieldsWritten().contains(field);
}
+@Override
public boolean isLive(JMethod method) {
return cfa.getLiveFieldsAndMethods().contains(method);
}
+@Override
public boolean isLive(String string) {
return cfa.getLiveStrings().contains(string);
}
+@Override
public boolean miscellaneousStatementsAreLive() {
return true;
}
@@ -132,38 +153,99 @@
* A {@link LivenessPredicate} where nothing is alive.
*/
public static class NothingAlivePredicate
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3300 to look at the new patch set (#2). Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. FragmentExtractor chooses whether and what part of a defineSeed call to include in a fragment. Previously this logic would only include a defineSeed function in a fragment if the fragment was known to make the particular type in question live. In this usage live means that if you have ALL other fragments loaded then you can not instantiate this type but the moment you additionally load this fragment you become able to instantiate this type. But it is possible that when you have ALL other fragments loaded you can already instantiate this type and so when you load this fragment you do not expand the liveness of this type but you DO suddenly make certain of its constructors accessible that were not previously accessible. In this situation previously logic would still not have included any defineSeed function at all and as a consequence these newly live constructors were never getting their associated castMaps which led to runtime errors when casting an instance that had been created by one of these broken constructors. This CL relaxes the defineSeed inclusion restriction to include fragments that are expanding a type's constructors liveness and not just fragments that expand a type's liveness. Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Review-Link: https://gwt-review.googlesource.com/#/c/3300/ --- M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java M dev/core/src/com/google/gwt/dev/js/ast/JsName.java M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java A dev/core/test/com/google/gwt/dev/jjs/impl/FragmentExtractorTest.java 4 files changed, 331 insertions(+), 80 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a module to revert GWT.runAsync to do immediate callbac...
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3310
Change subject: Adds a module to revert GWT.runAsync to do immediate
callbacks in consecutive calls.
..
Adds a module to revert GWT.runAsync to do immediate callbacks in
consecutive calls.
This is for backward compatibility until a major release. It introduces a
module
that can be inherited by user module to revert back GWT.runAsync to old
behavior.
Change-Id: If3a54663d6d857ca294c99a1a99084328748996d
---
A user/src/com/google/gwt/core/SynchronousFragmentLoadCallback.gwt.xml
M user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
A user/src/com/google/gwt/core/client/impl/OnSuccessExecutor.java
A user/src/com/google/gwt/core/client/impl/SynchronousOnSuccessExecutor.java
M user/test/com/google/gwt/core/client/impl/AsyncFragmentLoaderTest.java
5 files changed, 114 insertions(+), 30 deletions(-)
diff --git
a/user/src/com/google/gwt/core/SynchronousFragmentLoadCallback.gwt.xml
b/user/src/com/google/gwt/core/SynchronousFragmentLoadCallback.gwt.xml
new file mode 100644
index 000..1a37fb2
--- /dev/null
+++ b/user/src/com/google/gwt/core/SynchronousFragmentLoadCallback.gwt.xml
@@ -0,0 +1,24 @@
+!--
--
+!-- Copyright 2013 Google
Inc. --
+!-- Licensed under the Apache License, Version 2.0 (the License);
you--
+!-- may not use this file except in compliance with the License. You
may --
+!-- may obtain a copy of the License
at--
+!--
--
+!--
http://www.apache.org/licenses/LICENSE-2.0 --
+!--
--
+!-- Unless required by applicable law or agreed to in writing,
software--
+!-- distributed under the License is distributed on an AS IS
BASIS, --
+!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
or--
+!-- implied. License for the specific language governing permissions
and --
+!-- limitations under the
License. --
+
+!-- Inheriting this module makes callback executed immediately
if --
+!-- GWT.runAsync is called against already loaded
fragment.--
+
+!-- TODO(goktug): remove after 2.6 is
released --
+
+module
+ replace-with
class=com.google.gwt.core.client.impl.SynchronousOnSuccessExecutor
+when-type-is
class=com.google.gwt.core.client.impl.OnSuccessExecutor/
+ /replace-with
+/module
\ No newline at end of file
diff --git
a/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
b/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
index 77ab67f..d6ac682 100644
--- a/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
+++ b/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
@@ -18,8 +18,6 @@
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.JavaScriptObject;
import com.google.gwt.core.client.RunAsyncCallback;
-import com.google.gwt.core.client.Scheduler;
-import com.google.gwt.core.client.Scheduler.ScheduledCommand;
/**
* p
@@ -57,7 +55,7 @@
* been installed, so that {@link AsyncFragmentLoader} can distinguish
* successful from unsuccessful downloads.
*/
- public static interface LoadTerminatedHandler {
+ public interface LoadTerminatedHandler {
void loadTerminated(Throwable reason);
}
@@ -297,12 +295,15 @@
*/
private static AsyncFragmentLoader makeBrowserLoader(int numFragments,
int initialLoad[]) {
if (GWT.isClient()) {
- return new AsyncFragmentLoader(numFragments, initialLoad,
(LoadingStrategy) GWT
- .create(LoadingStrategy.class), (Logger)
GWT.create(Logger.class));
+ return new AsyncFragmentLoader(numFragments, initialLoad,
+ (LoadingStrategy) GWT.create(LoadingStrategy.class), (Logger)
GWT.create(Logger.class),
+ (OnSuccessExecutor) GWT.create(OnSuccessExecutor.class));
} else {
return null;
}
}
+
+ private final OnSuccessExecutor onSuccessExecutor;
/**
* Callbacks indexed by fragment number.
@@ -371,11 +372,12 @@
private final BoundedIntQueue requestedExclusives;
public AsyncFragmentLoader(int numEntries, int[] initialLoadSequence,
- LoadingStrategy loadingStrategy, Logger logger) {
+ LoadingStrategy loadingStrategy, Logger logger, OnSuccessExecutor
executor) {
this.numEntries = numEntries;
this.initialLoadSequence = initialLoadSequence;
this.loadingStrategy = loadingStrategy;
this.logger = logger;
+this.onSuccessExecutor = executor;
int numEntriesPlusOne = numEntries + 1;
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
Ray Cromwell has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 2: Is there a bug filed this is related to? It's not really the just the cast maps, defineSeed() wires up the constructor.prototype, and so calling new Foo without Foo.prototype being assigned to seed.prototype would mean all the methods and fields would be missing as well. -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
John Stalcup has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 2: yes this is in response to https://code.google.com/p/google-web-toolkit/issues/detail?id=7392 -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
Brian Slesinsky has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 2: (1 comment) This is too deep for me to review so I'll leave it to Ray and Roberto. A surface comment: Commit Message Line 7: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. The first line of a commit should be a short summary line that makes sense to people not familiar with GWT internals (Fix a bug in the codesplitter) Then say when the bug could happen (The bug occurs when a class has multiple constructors...) and link to the issue. Then go into the detailed explanation of how you fixed it. -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...
John Stalcup has uploaded a new change for review.
https://gwt-review.googlesource.com/3320
Change subject: fixes a compiler crash when parsing illegal runAsync
definitions
..
fixes a compiler crash when parsing illegal runAsync definitions
Change-Id: I3d3feb378a9595e1c3be091b2adf033df9ccae39
---
M dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
M
dev/core/test/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncsErrorMessagesTest.java
2 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
index 2e9222a..983c972 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
@@ -112,7 +112,10 @@
} else {
callbackMethod =
program.getIndexedMethod(RunAsyncCallback.onSuccess);
}
-assert callbackMethod != null;
+if (callbackMethod == null) {
+ error(x.getSourceInfo(), Only a RunAsyncCallback with a defined
onSuccess() can
+ + be passed to runAsync().);
+}
JMethodCall onSuccessCall = new JMethodCall(info, asyncCallback,
callbackMethod);
JRunAsync runAsyncNode = new JRunAsync(info, splitPoint, name,
runAsyncCall, onSuccessCall);
diff --git
a/dev/core/test/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncsErrorMessagesTest.java
b/dev/core/test/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncsErrorMessagesTest.java
index 68044bc..af77749 100644
---
a/dev/core/test/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncsErrorMessagesTest.java
+++
b/dev/core/test/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncsErrorMessagesTest.java
@@ -52,18 +52,48 @@
});
addSnippetImport(test.SplitPoint3);
+expectError(Errors in 'test/EntryPoint.java');
expectError(Line 8: Multiple runAsync calls are named
test.SplitPoint1);
expectError(One call is at 'test/SplitPoint1.java:5');
expectError(One call is at 'test/SplitPoint3.java:5');
testSnippet(RunAsyncCode.runAsyncCode(SplitPoint1.class););
}
+ public void testMissingOnSuccess() {
+sourceOracle.addOrReplace(new MockJavaResource(test.SplitPoint4) {
+@Override
+ public CharSequence getContent() {
+StringBuffer code = new StringBuffer();
+code.append(package test;\n);
+code.append(import com.google.gwt.core.client.GWT;\n);
+code.append(import
com.google.gwt.core.client.RunAsyncCallback;\n);
+code.append(public class SplitPoint4 {\n);
+code.append(
+ public abstract class AbstractRunAsyncCallback implements
RunAsyncCallback {\n);
+code.append(public void run() {\n);
+code.append( GWT.runAsync(this);\n);
+code.append(}\n);
+code.append( }\n);
+code.append(}\n);
+return code;
+ }
+});
+
+addSnippetImport(test.SplitPoint4);
+expectError(Errors in 'test/SplitPoint4.java');
+expectError(Line 7: Only a RunAsyncCallback with a defined
onSuccess() can
++ be passed to runAsync().);
+testSnippet(new SplitPoint4(););
+ }
+
public void testNonClassLiteral() {
+expectError(Errors in 'test/EntryPoint.java');
expectError(Line 7: Only a class literal may be passed to
runAsyncCode);
testSnippet(RunAsyncCode.runAsyncCode(new
SplitPoint1().getClass()););
}
public void testNonExistentSplitPoint() {
+expectError(Errors in 'test/EntryPoint.java');
expectError(Line 7: No runAsync call is named java.lang.String);
testSnippet(RunAsyncCode.runAsyncCode(String.class););
}
@@ -111,7 +141,6 @@
private void initializeTestLoggerBuilder() {
testLoggerBuilder = new UnitTestTreeLogger.Builder();
testLoggerBuilder.setLowestLogLevel(TreeLogger.ERROR);
-expectError(Errors in 'test/EntryPoint.java');
}
private void testSnippet(String codeSnippet) {
--
To view, visit https://gwt-review.googlesource.com/3320
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d3feb378a9595e1c3be091b2adf033df9ccae39
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup stal...@google.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...
John Stalcup has posted comments on this change. Change subject: fixes a compiler crash when parsing illegal runAsync definitions .. Patch Set 1: see https://code.google.com/p/google-web-toolkit/issues/detail?id=6739 -- To view, visit https://gwt-review.googlesource.com/3320 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3feb378a9595e1c3be091b2adf033df9ccae39 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3321
Change subject: Adds Timer#isRunning().
..
Adds Timer#isRunning().
This patch uses Integer instead of int to keep track of the running status.
As now, running state is kept, cancel is no longer called for timers that
are not scheduled.
Bug: issue 3935
Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56
---
M user/src/com/google/gwt/user/client/Timer.java
M user/test/com/google/gwt/user/MiscSuite.java
D user/test/com/google/gwt/user/client/TimerCancelTest.java
A user/test/com/google/gwt/user/client/TimerTest.java
4 files changed, 171 insertions(+), 139 deletions(-)
diff --git a/user/src/com/google/gwt/user/client/Timer.java
b/user/src/com/google/gwt/user/client/Timer.java
index f95a5a7..ae2dccf 100644
--- a/user/src/com/google/gwt/user/client/Timer.java
+++ b/user/src/com/google/gwt/user/client/Timer.java
@@ -15,7 +15,6 @@
*/
package com.google.gwt.user.client;
-
/**
* A simplified, browser-safe timer class. This class serves the same
purpose as
* java.util.Timer, but is simplified because of the single-threaded
@@ -61,7 +60,7 @@
private boolean isRepeating;
- private int timerId;
+ private Integer timerId = null;
/**
* Workaround for broken clearTimeout in IE. Keeps track of whether
cancel has been called since
@@ -70,15 +69,28 @@
private int cancelCounter = 0;
/**
- * Cancels this timer.
+ * Returns {@code true} if the timer is running. Timer is running if and
only if it is scheduled
+ * but it is not expired or cancelled.
+ */
+ public final boolean isRunning() {
+return timerId != null;
+ }
+
+ /**
+ * Cancels this timer. If the timer is not running, this is a no-op.
*/
public void cancel() {
+if (!isRunning()) {
+ return;
+}
+
cancelCounter++;
if (isRepeating) {
clearInterval(timerId);
} else {
clearTimeout(timerId);
}
+timerId = null;
}
/**
@@ -88,31 +100,36 @@
public abstract void run();
/**
- * Schedules a timer to elapse in the future.
- *
- * @param delayMillis how long to wait before the timer elapses, in
- * milliseconds
+ * Schedules a timer to elapse in the future. If the timer is already
running then it will be
+ * first canceled before re-scheduling.
+ *
+ * @param delayMillis how long to wait before the timer elapses, in
milliseconds
*/
public void schedule(int delayMillis) {
if (delayMillis 0) {
throw new IllegalArgumentException(must be non-negative);
}
-cancel();
+if (isRunning()) {
+ cancel();
+}
isRepeating = false;
timerId = createTimeout(this, delayMillis, cancelCounter);
}
/**
- * Schedules a timer that elapses repeatedly.
- *
- * @param periodMillis how long to wait before the timer elapses, in
- * milliseconds, between each repetition
+ * Schedules a timer that elapses repeatedly. If the timer is already
running then it will be
+ * first canceled before re-scheduling.
+ *
+ * @param periodMillis how long to wait before the timer elapses, in
milliseconds, between each
+ *repetition
*/
public void scheduleRepeating(int periodMillis) {
if (periodMillis = 0) {
throw new IllegalArgumentException(must be positive);
}
-cancel();
+if (isRunning()) {
+ cancel();
+}
isRepeating = true;
timerId = createInterval(this, periodMillis, cancelCounter);
}
@@ -123,10 +140,15 @@
* Only call run() if cancelCounter has not changed since the timer was
scheduled.
*/
final void fire(int scheduleCancelCounter) {
+// Workaround for broken clearTimeout in IE.
if (scheduleCancelCounter != cancelCounter) {
return;
}
+if (!isRepeating) {
+ timerId = null;
+}
+
// Run the timer's code.
run();
}
diff --git a/user/test/com/google/gwt/user/MiscSuite.java
b/user/test/com/google/gwt/user/MiscSuite.java
index 63eba39..1ad8318 100644
--- a/user/test/com/google/gwt/user/MiscSuite.java
+++ b/user/test/com/google/gwt/user/MiscSuite.java
@@ -25,7 +25,7 @@
import com.google.gwt.user.client.EventTest;
import com.google.gwt.user.client.GestureEventSinkTest;
import com.google.gwt.user.client.HistoryDisabledTest;
-import com.google.gwt.user.client.TimerCancelTest;
+import com.google.gwt.user.client.TimerTest;
import com.google.gwt.user.client.TouchEventSinkTest;
import com.google.gwt.user.client.WindowTest;
import com.google.gwt.user.datepicker.client.CalendarUtilTest;
@@ -54,7 +54,7 @@
suite.addTestSuite(HistoryDisabledTest.class);
suite.addTestSuite(ImageBundleGeneratorTest.class);
suite.addTestSuite(LayoutTest.class);
-suite.addTestSuite(TimerCancelTest.class);
+suite.addTestSuite(TimerTest.class);
[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().
Goktug Gokdogan has uploaded a new patch set (#2). Change subject: Adds Timer#isRunning(). .. Adds Timer#isRunning(). This patch uses Integer instead of int to keep track of the running status. As now, running state is kept, cancel is no longer called for timers that are not scheduled. Bug: issue 462, issue 3935 Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56 Review-Link: https://gwt-review.googlesource.com/#/c/3321/ --- M user/src/com/google/gwt/user/client/Timer.java M user/test/com/google/gwt/user/MiscSuite.java D user/test/com/google/gwt/user/client/TimerCancelTest.java A user/test/com/google/gwt/user/client/TimerTest.java 4 files changed, 171 insertions(+), 139 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3321 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3231 to look at the new patch set (#2). Change subject: Add interfaces for widgets. .. Add interfaces for widgets. Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9 --- M user/src/com/google/gwt/dom/client/Element.java A user/src/com/google/gwt/dom/client/HasStyle.java A user/src/com/google/gwt/dom/client/IsElement.java A user/src/com/google/gwt/dom/client/IsStyle.java M user/src/com/google/gwt/dom/client/Style.java M user/src/com/google/gwt/user/client/Element.java M user/src/com/google/gwt/user/client/ui/AbsolutePanel.java M user/src/com/google/gwt/user/client/ui/Anchor.java M user/src/com/google/gwt/user/client/ui/Button.java M user/src/com/google/gwt/user/client/ui/ButtonBase.java M user/src/com/google/gwt/user/client/ui/CellPanel.java M user/src/com/google/gwt/user/client/ui/CheckBox.java M user/src/com/google/gwt/user/client/ui/ComplexPanel.java M user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java M user/src/com/google/gwt/user/client/ui/FileUpload.java M user/src/com/google/gwt/user/client/ui/FlowPanel.java M user/src/com/google/gwt/user/client/ui/FocusPanel.java M user/src/com/google/gwt/user/client/ui/FocusWidget.java M user/src/com/google/gwt/user/client/ui/FormPanel.java M user/src/com/google/gwt/user/client/ui/Frame.java M user/src/com/google/gwt/user/client/ui/HTML.java M user/src/com/google/gwt/user/client/ui/HTMLPanel.java M user/src/com/google/gwt/user/client/ui/HasWidgets.java M user/src/com/google/gwt/user/client/ui/HorizontalPanel.java M user/src/com/google/gwt/user/client/ui/Hyperlink.java M user/src/com/google/gwt/user/client/ui/Image.java M user/src/com/google/gwt/user/client/ui/IndexedPanel.java M user/src/com/google/gwt/user/client/ui/InlineHTML.java M user/src/com/google/gwt/user/client/ui/InlineHyperlink.java M user/src/com/google/gwt/user/client/ui/InlineLabel.java A user/src/com/google/gwt/user/client/ui/IsAbsolutePanel.java A user/src/com/google/gwt/user/client/ui/IsAnchor.java A user/src/com/google/gwt/user/client/ui/IsButton.java A user/src/com/google/gwt/user/client/ui/IsButtonBase.java A user/src/com/google/gwt/user/client/ui/IsCellPanel.java A user/src/com/google/gwt/user/client/ui/IsCheckBox.java A user/src/com/google/gwt/user/client/ui/IsColumnsPanel.java A user/src/com/google/gwt/user/client/ui/IsComplexPanel.java A user/src/com/google/gwt/user/client/ui/IsDatePicker.java A user/src/com/google/gwt/user/client/ui/IsDialogBox.java A user/src/com/google/gwt/user/client/ui/IsDockLayoutPanel.java A user/src/com/google/gwt/user/client/ui/IsFileUpload.java A user/src/com/google/gwt/user/client/ui/IsFlowPanel.java A user/src/com/google/gwt/user/client/ui/IsFocusPanel.java A user/src/com/google/gwt/user/client/ui/IsFocusWidget.java A user/src/com/google/gwt/user/client/ui/IsFormPanel.java A user/src/com/google/gwt/user/client/ui/IsFrame.java A user/src/com/google/gwt/user/client/ui/IsHTML.java A user/src/com/google/gwt/user/client/ui/IsHTMLPanel.java A user/src/com/google/gwt/user/client/ui/IsHorizontalPanel.java A user/src/com/google/gwt/user/client/ui/IsHyperlink.java A user/src/com/google/gwt/user/client/ui/IsImage.java A user/src/com/google/gwt/user/client/ui/IsInlineHTML.java A user/src/com/google/gwt/user/client/ui/IsInlineHyperlink.java A user/src/com/google/gwt/user/client/ui/IsInlineLabel.java A user/src/com/google/gwt/user/client/ui/IsLabel.java A user/src/com/google/gwt/user/client/ui/IsListBox.java A user/src/com/google/gwt/user/client/ui/IsPanel.java A user/src/com/google/gwt/user/client/ui/IsPasswordTextBox.java A user/src/com/google/gwt/user/client/ui/IsPopupPanel.java A user/src/com/google/gwt/user/client/ui/IsPushButton.java A user/src/com/google/gwt/user/client/ui/IsRadioButton.java A user/src/com/google/gwt/user/client/ui/IsResetButton.java A user/src/com/google/gwt/user/client/ui/IsResizeLayoutPanel.java A user/src/com/google/gwt/user/client/ui/IsScrollPanel.java A user/src/com/google/gwt/user/client/ui/IsSimpleCheckBox.java A user/src/com/google/gwt/user/client/ui/IsSimplePanel.java A user/src/com/google/gwt/user/client/ui/IsSimpleRadioButton.java A user/src/com/google/gwt/user/client/ui/IsSubmitButton.java A user/src/com/google/gwt/user/client/ui/IsSuggestBox.java A user/src/com/google/gwt/user/client/ui/IsTabLayoutPanel.java A user/src/com/google/gwt/user/client/ui/IsTextArea.java A user/src/com/google/gwt/user/client/ui/IsTextBox.java A user/src/com/google/gwt/user/client/ui/IsTextBoxBase.java A user/src/com/google/gwt/user/client/ui/IsValueBoxBase.java A user/src/com/google/gwt/user/client/ui/IsValueListBox.java A user/src/com/google/gwt/user/client/ui/IsVerticalPanel.java A user/src/com/google/gwt/user/client/ui/IsWidget2.java A user/src/com/google/gwt/user/client/ui/IsWidgetIteratorAdaptor.java M user/src/com/google/gwt/user/client/ui/Label.java M
