[gwt-contrib] Re: Improving event handling, as initiated in 1.6
I don't suppose you could bump the wave Thomas? I seem to not have access to do anything but add blank replies... On May 31, 5:48 am, Brendan Kenny bcke...@gmail.com wrote: Rob -- You might have already seen this, but Thomas created a wave on the topic to get things movinghttps://wave.google.com/wave/#restored:wave:googlewave.com!w%252Bux7z... post I/O seems to be the general timeframe, but I know I'm eager to help create a more extensible system as well. Many more event types than I know where to put these days. On May 29, 1:01 pm, Robert Hanson iamroberthan...@gmail.com wrote: I was trying to implement the File API using GWT's events, and I came across this post and others. There is also an issue for this, which was accepted, but the last comment is from 2008 (http:// code.google.com/p/google-web-toolkit/issues/detail?id=2562). Just wondering if this is in the works (maybe already in the trunk), or if this is on the back-burner. Thanks. Rob -- Forwarded message -- From: Thomas Broyer t.bro...@gmail.com Date: Dec 21 2009, 8:01 pm Subject: Improving event handling, as initiated in 1.6 To: Google Web Toolkit Contributors Hi Googlers, GWT 1.6 introduced the new event handling, which is really great. It however suffers from some limitations, the one bugging me the most being the difficulty/impossibility to support new DomEvents, such as D'n'D events, ononline/onoffline, onstorage, or browser-specific events (those that can be emulated in other browsers: mouseenter/ mouseleave, focusin/focusout; and those that cannot: onhelp, onselect/ onselectionchange/onselectstart, onmozorientationchange, ongesturestart/change/end, ontouchstart/end/move/cancel, onorientation, etc.) This is because event's sinking is done byDOMImplusing a field of bits, instead of being baked intoDomEvent(using an Impl class with deferred binding by browser). How about, for instance, building it intoDomEvent::Type, so that addDomHandler could call type.sinkEvent (xxx)? Other improvements that I'd like to see happening re. events: - finally accurate (not necessarily 100%-identical cross-browser- wise) support for key/keyboard events (issues 72, 1061, 1529, and 3753, and issue 3640) see alsohttp://groups.google.fr/group/Google-Web-Toolkit-Contributors/t/e7059... - onfocus/onblur on Window (issue 68) - focus/blur event preview (issue 1431) - unsink events when there all handlers have been removed (issue 3619) - allow listening to events in the capture phase instead of only being able to listen to the bubble phase This last issue (3619) cannot be solved without either (as I proposed in comment #3 on the issue): - changing Widget::addDomHandler wrap the HandlerRegistration so that removeHandler() queues a finally command to eventually unsink the event - baking this in HandlerManager, eventually by introducing a DomHandlerManager extends HandlerManager to be used by widgets See alsohttp://groups.google.fr/group/google-web-toolkit-contributors/msg/cd4... I volunteer to provide patches, but I need to know what you, GWT team, want and want-not. I'd happily work on sorting those key/ keyboard events out, followed by rework of theDomEvent'ssinking extensibility and issue 3619. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Improving event handling, as initiated in 1.6
On Thu, Jun 10, 2010 at 11:59 PM, Dan ddum...@gmail.com wrote: I don't suppose you could bump the wave Thomas? I seem to not have access to do anything but add blank replies... I've added you to the wave. Don't know what happened as you're a member of GWT-Contrib, which has full access to the wave... -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: RR : Support reserved class names in CssResource (issue600801)
LGTM
http://gwt-code-reviews.appspot.com/600801/diff/2001/3001
File user/src/com/google/gwt/resources/Resources.gwt.xml (right):
http://gwt-code-reviews.appspot.com/600801/diff/2001/3001#newcode77
user/src/com/google/gwt/resources/Resources.gwt.xml:77:
extend-configuration-property name=CssResource.reservedClassPrefixes
value=gwt- /
Is there an existing gwt test you can extend to ensure this stays
defined?
http://gwt-code-reviews.appspot.com/600801/diff/2001/3002
File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/600801/diff/2001/3002#newcode778
user/src/com/google/gwt/resources/rg/CssResourceGenerator.java:778: for
(String value : prop.getValues()) {
value = value.trim() ?
http://gwt-code-reviews.appspot.com/600801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix implementation of Math.sinh and Math.tanh (external issue 4991) (issue602801)
Reviewers: jat,
Description:
Fix implementation of Math.sinh and Math.tanh (external issue 4991)
Please review this at http://gwt-code-reviews.appspot.com/602801/show
Affected files:
M user/super/com/google/gwt/emul/java/lang/Math.java
M user/test/com/google/gwt/emultest/java/lang/MathTest.java
Index: user/super/com/google/gwt/emul/java/lang/Math.java
===
--- user/super/com/google/gwt/emul/java/lang/Math.java (revision 8240)
+++ user/super/com/google/gwt/emul/java/lang/Math.java (working copy)
@@ -27,10 +27,12 @@
private static final double PI_UNDER_180 = 180.0 / PI;
public static double abs(double x) {
+//return (x = 0.0) ? 0.0 - x : x;
return x 0 ? -x : x;
}
public static float abs(float x) {
+// return (x = 0.0) ? 0.0 - x : x;
return x 0 ? -x : x;
}
@@ -253,7 +255,7 @@
}-*/;
public static native double sinh(double x) /*-{
-return Math.sinh(x);
+return (Math.exp(x) - Math.exp(-x)) / 2.0;
}-*/;
public static native double sqrt(double x) /*-{
@@ -265,7 +267,8 @@
}-*/;
public static native double tanh(double x) /*-{
-return Math.tanh(x);
+var e2x = Math.exp(2.0 * x);
+return (e2x - 1) / (e2x + 1);
}-*/;
public static double toDegrees(double x) {
Index: user/test/com/google/gwt/emultest/java/lang/MathTest.java
===
--- user/test/com/google/gwt/emultest/java/lang/MathTest.java (revision
8240)
+++ user/test/com/google/gwt/emultest/java/lang/MathTest.java (working copy)
@@ -30,6 +30,17 @@
return com.google.gwt.emultest.EmulSuite;
}
+ public void testAbs() {
+double v = Math.abs(-1.0);
+assertEquals(1.0, v);
+v = Math.abs(1.0);
+assertEquals(1.0, v);
+v = Math.abs(-1.0 / Double.POSITIVE_INFINITY); // -0.0
+assertEquals(0.0, v);
+v = Math.abs(0.0);
+assertEquals(0.0, v);
+ }
+
public void testCbrt() {
double v = Math.cbrt(1000.0);
assertEquals(10.0, v, 1e-7);
@@ -44,6 +55,15 @@
assertEquals(-1.0, v, 1e-7);
v = Math.cos(Math.PI * 1.5);
assertEquals(0.0, v, 1e-7);
+ }
+
+ public void testCosh() {
+double v = Math.cosh(0.0);
+assertEquals(1.0, v, 1e-7);
+v = Math.cosh(1.0);
+assertEquals(1.5430806348, v, 1e-7);
+v = Math.cosh(-1.0);
+assertEquals(1.5430806348, v, 1e-7);
}
public void testLog() {
@@ -66,4 +86,22 @@
v = Math.sin(Math.PI * 1.5);
assertEquals(-1.0, v, 1e-7);
}
+
+ public void testSinh() {
+double v = Math.sinh(0.0);
+assertEquals(0.0, v, 1e-7);
+v = Math.sinh(1.0);
+assertEquals(1.175201193, v, 1e-7);
+v = Math.sinh(-1.0);
+assertEquals(-1.175201193, v, 1e-7);
+ }
+
+ public void testTanh() {
+double v = Math.tanh(0.0);
+assertEquals(0.0, v, 1e-7);
+v = Math.tanh(1.0);
+assertEquals(0.761594155, v, 1e-7);
+v = Math.tanh(-1.0);
+assertEquals(-0.761594155, v, 1e-7);
+ }
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix behavior of Double.compare and Double.compareTo (external issue 4935) (issue603801)
Reviewers: jat,
Description:
Fix behavior of Double.compare and Double.compareTo (external issue
4935)
Please review this at http://gwt-code-reviews.appspot.com/603801/show
Affected files:
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/test/com/google/gwt/emultest/java/lang/DoubleTest.java
Index: user/super/com/google/gwt/emul/java/lang/Double.java
===
--- user/super/com/google/gwt/emul/java/lang/Double.java(revision 8240)
+++ user/super/com/google/gwt/emul/java/lang/Double.java(working copy)
@@ -33,6 +33,16 @@
public static final int SIZE = 64;
public static int compare(double x, double y) {
+if (isNaN(x)) {
+ if (isNaN(y)) {
+return 0;
+ } else {
+return 1;
+ }
+} else if (isNaN(y)) {
+ return -1;
+}
+
if (x y) {
return -1;
} else if (x y) {
@@ -89,13 +99,7 @@
}
public int compareTo(Double b) {
-if (value b.value) {
- return -1;
-} else if (value b.value) {
- return 1;
-} else {
- return 0;
-}
+return compare(this.value, b.value);
}
@Override
Index: user/test/com/google/gwt/emultest/java/lang/DoubleTest.java
===
--- user/test/com/google/gwt/emultest/java/lang/DoubleTest.java (revision
8240)
+++ user/test/com/google/gwt/emultest/java/lang/DoubleTest.java (working
copy)
@@ -77,6 +77,34 @@
// Expected behavior
}
}
+
+ public void testCompare() {
+assertTrue(Double.compare(Double.NaN, Double.NaN) == 0);
+assertTrue(Double.compare(0.0, Double.NaN) 0);
+assertTrue(Double.compare(Double.NaN, Double.POSITIVE_INFINITY) 0);
+assertTrue(Double.compare(Double.NaN, 0.0) 0);
+assertTrue(Double.compare(Double.POSITIVE_INFINITY, Double.NaN) 0);
+assertTrue(Double.compare(3.0, 500.0) 0);
+assertTrue(Double.compare(500.0, 3.0) 0);
+assertTrue(Double.compare(500.0, 500.0) == 0);
+ }
+
+ public void testCompareTo() {
+Double zero = new Double(0.0);
+Double three = new Double(3.0);
+Double fiveHundred = new Double(500.0);
+Double infinity = new Double(Double.POSITIVE_INFINITY);
+Double nan = new Double(Double.NaN);
+
+assertTrue(nan.compareTo(nan) == 0);
+assertTrue(zero.compareTo(nan) 0);
+assertTrue(nan.compareTo(infinity) 0);
+assertTrue(nan.compareTo(zero) 0);
+assertTrue(infinity.compareTo(nan) 0);
+assertTrue(three.compareTo(fiveHundred) 0);
+assertTrue(fiveHundred.compareTo(three) 0);
+assertTrue(fiveHundred.compareTo(fiveHundred) == 0);
+ }
public void testDoubleConstants() {
assertTrue(Double.isNaN(Double.NaN));
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Restore deleted public method (issue604801)
Reviewers: Lex,
Description:
Restore deleted public method
Please review this at http://gwt-code-reviews.appspot.com/604801/show
Affected files:
M
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java
Index:
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java
===
---
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java
(revision 8240)
+++
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java
(working copy)
@@ -44,6 +44,11 @@
public static double[] getAsDoubleArray(long value) {
int lowBits = (int) (value 0x);
int highBits = (int) (value 32);
+return makeLongComponents(lowBits, highBits);
+ }
+
+ // Equivalent to getAsDoubleArray((long) highBits 32 | lowBits);
+ protected static double[] makeLongComponents(int lowBits, int highBits) {
double high = highBits * TWO_PWR_32_DBL;
double low = lowBits;
if (lowBits 0) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Restore deleted public method (issue604801)
Since the underlying implementation is so different, maybe we should break any users of this and instead introduce something that is less fragile, like a class using only translatable primitives that can serialize/deserialize itself. http://gwt-code-reviews.appspot.com/604801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix behavior of Double.compare and Double.compareTo (external issue 4935) (issue603801)
LGTM http://gwt-code-reviews.appspot.com/603801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Restore deleted public method (issue604801)
Right now, the standard RPC format hasn't changed (although deRPC has, since the whole point if to be able to eval the payload into the client). So anyone who has a custom RPC system needs a way to generate a double[2] from a long. Longer term, I'd like to transmit longs as an int[3] instead, in which case I would agree that it would be good to insulate subclassers from the details of the wire format. Dan On Fri, Jun 11, 2010 at 3:02 PM, j...@google.com wrote: Since the underlying implementation is so different, maybe we should break any users of this and instead introduce something that is less fragile, like a class using only translatable primitives that can serialize/deserialize itself. http://gwt-code-reviews.appspot.com/604801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Restore deleted public method (issue604801)
On Fri, Jun 11, 2010 at 3:07 PM, Daniel Rice (דניאל רייס) r...@google.comwrote: Right now, the standard RPC format hasn't changed (although deRPC has, since the whole point if to be able to eval the payload into the client). So anyone who has a custom RPC system needs a way to generate a double[2] from a long. Ok. Longer term, I'd like to transmit longs as an int[3] instead, in which case I would agree that it would be good to insulate subclassers from the details of the wire format. Since it is actually going to be transmitted as ASCII characters anyway, I am not sure it is better than just sending the string representation of the long and processing it normally rather than parsing multiple values. Especially currently where the work to parse two doubles and convert them to 3 ints seems far more than just doing the straight parse anyway, and it also makes the server-side much simpler. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Implemented Array and descendants as overlay types. Simplified Assertion convenience methods. Fi... (issue605801)
Reviewers: Dan Rice, Description: Implemented Array and descendants as overlay types. Simplified Assertion convenience methods. Fixed code style issues. Review by: r...@google.com Please review this at http://gwt-code-reviews.appspot.com/605801/show Affected files: M /bikeshed/src/com/google/gwt/collections/Assertions.java M /bikeshed/src/com/google/gwt/collections/ImmutableArrayEmptyImpl.java M /bikeshed/src/com/google/gwt/collections/ImmutableArrayImpl.java M /bikeshed/src/com/google/gwt/collections/MutableArray.java A /bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/Array.java A /bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/CollectionFactory.java A /bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/ImmutableArray.java A /bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/ImmutableArrayEmptyImpl.java M /bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/ImmutableArrayImpl.java M /bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/MutableArray.java M /bikeshed/test-super/com/google/gwt/collections/super/com/google/gwt/collections/MutableArrayInternalTest.java M /bikeshed/test/com/google/gwt/collections/CollectionsServerSideTestSuite.java A /bikeshed/test/com/google/gwt/collections/ImmutableArrayInternalTest.java M /bikeshed/test/com/google/gwt/collections/ImmutableArrayTest.java M /bikeshed/test/com/google/gwt/collections/MutableArrayTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Implemented Array and descendants as overlay types. Simplified Assertion convenience methods. Fi... (issue500801)
I've reposted this patch based on the branch at https://google-web-toolkit.googlecode.com/branches/lwc-gwt-migration, please review there On 2010/05/10 18:38:14, rchandia wrote: http://gwt-code-reviews.appspot.com/500801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix implementation of Math.sinh and Math.tanh (external issue 4991) (issue602801)
LGTM if the extra comments are removed and the JRE compatibility question is checked. http://gwt-code-reviews.appspot.com/602801/diff/1/2 File user/super/com/google/gwt/emul/java/lang/Math.java (right): http://gwt-code-reviews.appspot.com/602801/diff/1/2#newcode30 user/super/com/google/gwt/emul/java/lang/Math.java:30: //return (x = 0.0) ? 0.0 - x : x; Why are these comments being added? http://gwt-code-reviews.appspot.com/602801/diff/1/2#newcode258 user/super/com/google/gwt/emul/java/lang/Math.java:258: return (Math.exp(x) - Math.exp(-x)) / 2.0; On these, do we need to do anything special with NaNs/infinity to get JRE-compatible behavior? http://gwt-code-reviews.appspot.com/602801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Implemented Array and descendants as overlay types. Simplified Assertion convenience methods. Fi... (issue500801)
(I pressed send too soon) I've reposted this patch based on the branch at https://google-web-toolkit.googlecode.com/branches/lwc-gwt-migration, please review now at http://gwt-code-reviews.appspot.com/605801 On 2010/05/10 18:38:14, rchandia wrote: http://gwt-code-reviews.appspot.com/500801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add new LongLib test case (issue607801)
Reviewers: jat, Description: Add new LongLib test case Please review this at http://gwt-code-reviews.appspot.com/607801/show Affected files: M dev/core/super/com/google/gwt/lang/LongLibBase.java A dev/core/test/com/google/gwt/lang/LongLibTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix implementation of Math.sinh and Math.tanh (external issue 4991) (issue602801)
http://gwt-code-reviews.appspot.com/602801/diff/1/2 File user/super/com/google/gwt/emul/java/lang/Math.java (right): http://gwt-code-reviews.appspot.com/602801/diff/1/2#newcode30 user/super/com/google/gwt/emul/java/lang/Math.java:30: //return (x = 0.0) ? 0.0 - x : x; Oops, I meant to test the behavior for -0 (if such a thing actually exists in JS). In Java, doing 'return x 0 ? -x : x' for x = -0 will return -0 instead of 0 as it should. On 2010/06/11 19:21:31, jat wrote: Why are these comments being added? http://gwt-code-reviews.appspot.com/602801/diff/1/2#newcode258 user/super/com/google/gwt/emul/java/lang/Math.java:258: return (Math.exp(x) - Math.exp(-x)) / 2.0; I've added a test case and made one needed fix. On 2010/06/11 19:21:31, jat wrote: On these, do we need to do anything special with NaNs/infinity to get JRE-compatible behavior? http://gwt-code-reviews.appspot.com/602801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8241 committed - Fix behavior of Double.compare and Double.compareTo (external issue 49...
Revision: 8241
Author: r...@google.com
Date: Fri Jun 11 10:06:45 2010
Log: Fix behavior of Double.compare and Double.compareTo (external issue
4935)
Review at http://gwt-code-reviews.appspot.com/603801
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8241
Modified:
/trunk/user/super/com/google/gwt/emul/java/lang/Double.java
/trunk/user/test/com/google/gwt/emultest/java/lang/DoubleTest.java
===
--- /trunk/user/super/com/google/gwt/emul/java/lang/Double.java Thu Apr 10
23:17:07 2008
+++ /trunk/user/super/com/google/gwt/emul/java/lang/Double.java Fri Jun 11
10:06:45 2010
@@ -33,6 +33,16 @@
public static final int SIZE = 64;
public static int compare(double x, double y) {
+if (isNaN(x)) {
+ if (isNaN(y)) {
+return 0;
+ } else {
+return 1;
+ }
+} else if (isNaN(y)) {
+ return -1;
+}
+
if (x y) {
return -1;
} else if (x y) {
@@ -89,13 +99,7 @@
}
public int compareTo(Double b) {
-if (value b.value) {
- return -1;
-} else if (value b.value) {
- return 1;
-} else {
- return 0;
-}
+return compare(this.value, b.value);
}
@Override
===
--- /trunk/user/test/com/google/gwt/emultest/java/lang/DoubleTest.java Thu
Mar 25 14:04:46 2010
+++ /trunk/user/test/com/google/gwt/emultest/java/lang/DoubleTest.java Fri
Jun 11 10:06:45 2010
@@ -77,6 +77,34 @@
// Expected behavior
}
}
+
+ public void testCompare() {
+assertTrue(Double.compare(Double.NaN, Double.NaN) == 0);
+assertTrue(Double.compare(0.0, Double.NaN) 0);
+assertTrue(Double.compare(Double.NaN, Double.POSITIVE_INFINITY) 0);
+assertTrue(Double.compare(Double.NaN, 0.0) 0);
+assertTrue(Double.compare(Double.POSITIVE_INFINITY, Double.NaN) 0);
+assertTrue(Double.compare(3.0, 500.0) 0);
+assertTrue(Double.compare(500.0, 3.0) 0);
+assertTrue(Double.compare(500.0, 500.0) == 0);
+ }
+
+ public void testCompareTo() {
+Double zero = new Double(0.0);
+Double three = new Double(3.0);
+Double fiveHundred = new Double(500.0);
+Double infinity = new Double(Double.POSITIVE_INFINITY);
+Double nan = new Double(Double.NaN);
+
+assertTrue(nan.compareTo(nan) == 0);
+assertTrue(zero.compareTo(nan) 0);
+assertTrue(nan.compareTo(infinity) 0);
+assertTrue(nan.compareTo(zero) 0);
+assertTrue(infinity.compareTo(nan) 0);
+assertTrue(three.compareTo(fiveHundred) 0);
+assertTrue(fiveHundred.compareTo(three) 0);
+assertTrue(fiveHundred.compareTo(fiveHundred) == 0);
+ }
public void testDoubleConstants() {
assertTrue(Double.isNaN(Double.NaN));
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix implementation of Math.sinh and Math.tanh (external issue 4991) (issue602801)
http://gwt-code-reviews.appspot.com/602801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Implemented Array and descendants as overlay types. Simplified Assertion convenience methods. Fi... (issue605801)
LGTM with nits
http://gwt-code-reviews.appspot.com/605801/diff/1/2
File /bikeshed/src/com/google/gwt/collections/Assertions.java (right):
http://gwt-code-reviews.appspot.com/605801/diff/1/2#newcode24
/bikeshed/src/com/google/gwt/collections/Assertions.java:24: *
Needs comment
http://gwt-code-reviews.appspot.com/605801/diff/1/5
File /bikeshed/src/com/google/gwt/collections/MutableArray.java (right):
http://gwt-code-reviews.appspot.com/605801/diff/1/5#newcode25
/bikeshed/src/com/google/gwt/collections/MutableArray.java:25: public
class MutableArrayE extends ArrayE {
Would it make more sense to declare the whole class final?
http://gwt-code-reviews.appspot.com/605801/diff/1/5#newcode52
/bikeshed/src/com/google/gwt/collections/MutableArray.java:52: * Creates
an immutable array based on this one. Also marks this object as
read-only.
line wrap
http://gwt-code-reviews.appspot.com/605801/diff/1/7
File
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/CollectionFactory.java
(right):
http://gwt-code-reviews.appspot.com/605801/diff/1/7#newcode21
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/CollectionFactory.java:21:
* Made to be switched out using super source even while Collections
itself isn't.
line wrap
http://gwt-code-reviews.appspot.com/605801/diff/1/7#newcode24
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/CollectionFactory.java:24:
doc
http://gwt-code-reviews.appspot.com/605801/diff/1/7#newcode28
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/CollectionFactory.java:28:
doc
http://gwt-code-reviews.appspot.com/605801/diff/1/7#newcode34
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/CollectionFactory.java:34:
doc
http://gwt-code-reviews.appspot.com/605801/diff/1/11
File
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/MutableArray.java
(right):
http://gwt-code-reviews.appspot.com/605801/diff/1/11#newcode24
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/MutableArray.java:24:
public class MutableArrayE extends ArrayE {
Mark class as final rather than each method?
http://gwt-code-reviews.appspot.com/605801/diff/1/11#newcode46
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/MutableArray.java:46:
* read-only. After calling {...@code freeze()}, only use methods from
Something is wrong with the text here, looks like different pieces got
pasted together ungrammatically.
http://gwt-code-reviews.appspot.com/605801/diff/1/11#newcode56
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/MutableArray.java:56:
* Inserts {...@code element} before the element residing at {...@code index}.
element - elem
http://gwt-code-reviews.appspot.com/605801/diff/1/11#newcode174
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/MutableArray.java:174:
var fillStart;
fillstart is unused, remove
http://gwt-code-reviews.appspot.com/605801/diff/1/11#newcode175
/bikeshed/super/com/google/gwt/collections/super/com/google/gwt/collections/MutableArray.java:175:
var i;
Declare 'i' where it is used ('for (var i...')
http://gwt-code-reviews.appspot.com/605801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: A new model for external types (issue589801)
I haven't been keeping up on the design of this, but the code-gen
discussion got my interest. Now that it can model classes and
interfaces, do you see this as being adaptable to supporting an
exported type mechanism? That is, if a given type could be tagged
external via some annotation (@Export), alter code-gen for that type
to implement exported semantics? (visible methods have non-obfuscated,
non-pruned, non-staticified siblings visible to separate compiled
code/hand written JS) ?
e.g.
@Export
class Foo {
public String getBar() { return this.bar; }
}
- Foo is an external type implicitly, @Export annotation available for query
code-gen produces
_ = FooSeed.prototype =
_.getBar = _.xG = function() { return this.bar; }
On Fri, Jun 11, 2010 at 6:00 PM, sco...@google.com wrote:
Ping. Is everyone happy with this change?
http://gwt-code-reviews.appspot.com/589801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
