Re: [gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)
Thanks for reply. This is in line with my schedule. I'll be watching your progress with great interest. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Warn users of JRE 1.5 that their days are numbered (issue1328802)
LGTM On 2011/01/27 04:48:37, bobv wrote: LGTM http://gwt-code-reviews.appspot.com/1328802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)
Reviewers: pdr, Description: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT app. Also fixing a style bug in VerticalSplitPanel that causes the splitter to be too wide. Author: josht (styles), jlabanca Please review this at http://gwt-code-reviews.appspot.com/1330801/show Affected files: M samples/showcase/src/com/google/gwt/sample/showcase/Showcase.gwt.xml M samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java M samples/showcase/src/com/google/gwt/sample/showcase/client/Showcase.java M samples/showcase/src/com/google/gwt/sample/showcase/client/content/panels/CwHorizontalSplitPanel.java M samples/showcase/src/com/google/gwt/sample/showcase/client/content/panels/CwVerticalSplitPanel.java M samples/showcase/src/com/google/gwt/sample/showcase/generator/ShowcaseGenerator.java M user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css M user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome_rtl.css A user/src/com/google/gwt/user/theme/clean/Clean.gwt.xml A user/src/com/google/gwt/user/theme/clean/CleanRTL.gwt.xml A user/src/com/google/gwt/user/theme/clean/CleanResources.gwt.xml A user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css A user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css M user/src/com/google/gwt/user/theme/dark/public/gwt/dark/dark.css M user/src/com/google/gwt/user/theme/dark/public/gwt/dark/dark_rtl.css M user/src/com/google/gwt/user/theme/standard/public/gwt/standard/standard.css M user/src/com/google/gwt/user/theme/standard/public/gwt/standard/standard_rtl.css M user/src/com/google/gwt/user/tools/Module.gwt.xmlsrc -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)
Few nits about the styles: button image is off by 1px in showcase button example, and a few blue border elements remain. http://gwt-code-reviews.appspot.com/1330801/diff/1/8 File user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/8#newcode233 user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css:233: line-height: 0px; This seems like a breaking change. Why not just put it in clean.css to avoid breaking existing implementations? (Here, below, in chrome_rtl.css, standards*.css, and dark*.css) http://gwt-code-reviews.appspot.com/1330801/diff/1/13 File user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode52 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:52: Nit: Be consistent in newlines after }'s. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode549 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:549: filter: alpha(opacity=40); Why not opacity=50, since the standards version is .5? http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode573 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:573: filter: alpha(opacity=40); Why not opacity=50, since the standards version is .5? http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1044 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1044: filter: alpha(opacity=40); Why not opacity=50, since the standards version is .5? http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1123 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1123: background: url(images/hborder2.png) repeat-x 0px -30px;; extra ; at the end. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1148 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1148: background: url(images/hborder2.png) repeat-x 0px -30px;; extra ; at the end. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1158 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1158: vertical-align: center; center isn't valid for vertical-align, did you mean middle? http://gwt-code-reviews.appspot.com/1330801/diff/1/14 File user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode549 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:549: filter: alpha(opacity=40); Why not opacity=50, since the standards version is .5? http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode573 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:573: filter: alpha(opacity=40); Why not opacity=50, since the standards version is .5? http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1018 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1018: filter: alpha(opacity=40); Why not opacity=50, since the standards version is .5? http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1044 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1044: filter: alpha(opacity=40); Why not opacity=50, since the standards version is .5? http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1124 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1124: background: url(images/hborder2.png) repeat-x 0px -30px;; Extra ; http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1149 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1149: background: url(images/hborder2.png) repeat-x 0px -30px;; Extra ; http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1159 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1159: vertical-align: center; center isn't valid for vertical-align, did you mean middle? http://gwt-code-reviews.appspot.com/1330801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9634 committed - Add link to Issue 5946 GraphNavigationGwtTest
Revision: 9634 Author: ncha...@google.com Date: Thu Jan 27 07:01:18 2011 Log: Add link to Issue 5946 GraphNavigationGwtTest http://code.google.com/p/google-web-toolkit/source/detail?r=9634 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Thu Jan 13 08:23:15 2011 +++ /wiki/BeanValidation.wiki Thu Jan 27 07:01:18 2011 @@ -74,8 +74,8 @@ [http://code.google.com/p/google-web-toolkit/issues/list?can=2q=label%3Ajsr303 Open issues labeled jsr303] == Critical Bugs == - * Message Interpolation can recurse forever. - * Object Graph Validation can recurse forever + * Message Interpolation can recurse forever. + * Object Graph Validation can recurse forever [http://code.google.com/p/google-web-toolkit/issues/detail?id=5946 Issue 5946 GraphNavigationGwtTest]. == Other Issues == * Calling the correct !ConstraintValidator based on bean type (class) per the spec. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)
http://gwt-code-reviews.appspot.com/1330801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)
http://gwt-code-reviews.appspot.com/1330801/diff/1/8 File user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/8#newcode233 user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css:233: line-height: 0px; This is fixing an existing bug in VerticalSplitPanel where the splitter to too tall. I added it to HorizontalSplitPanel for consistency and in case the panel is very small. Since you can't put text in the splitter, its very unlikely to break anyone. You can see the bug here: http://gwt.google.com/samples/Showcase/Showcase.html#!CwVerticalSplitPanel http://gwt-code-reviews.appspot.com/1330801/diff/1/13 File user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode52 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:52: I think we are. Line breaks are used between widgets, but not between styles that apply to the same widget. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode549 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:549: filter: alpha(opacity=40); There are subtle differences in the way IE renders opacity versus other browsers. Using slightly different numbers makes the buttons look more similar. I switched to use 45 in IE, which looks closer to .5 in other browsers. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode573 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:573: filter: alpha(opacity=40); see above http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1044 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1044: filter: alpha(opacity=40); see above http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1148 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1148: background: url(images/hborder2.png) repeat-x 0px -30px;; On 2011/01/27 14:35:27, pdr wrote: extra ; at the end. Done. http://gwt-code-reviews.appspot.com/1330801/diff/1/13#newcode1158 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean.css:1158: vertical-align: center; On 2011/01/27 14:35:27, pdr wrote: center isn't valid for vertical-align, did you mean middle? Done. http://gwt-code-reviews.appspot.com/1330801/diff/1/14 File user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode549 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:549: filter: alpha(opacity=40); see comment in clean.css http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode573 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:573: filter: alpha(opacity=40); see comment in clean.css http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1018 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1018: filter: alpha(opacity=40); see comment in clean.css http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1044 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1044: filter: alpha(opacity=40); see comment in clean.css http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1124 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1124: background: url(images/hborder2.png) repeat-x 0px -30px;; On 2011/01/27 14:35:27, pdr wrote: Extra ; Done. http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1149 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1149: background: url(images/hborder2.png) repeat-x 0px -30px;; On 2011/01/27 14:35:27, pdr wrote: Extra ; Done. http://gwt-code-reviews.appspot.com/1330801/diff/1/14#newcode1159 user/src/com/google/gwt/user/theme/clean/public/gwt/clean/clean_rtl.css:1159: vertical-align: center; On 2011/01/27 14:35:27, pdr wrote: center isn't valid for vertical-align, did you mean middle? Done. http://gwt-code-reviews.appspot.com/1330801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: AbstractPlaceHistoryMapper doesn't process tokens correctly wrt empty prefixes (issue1316801)
r9635 http://gwt-code-reviews.appspot.com/1316801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9635 committed - In r8817, we landed a patch that allows @Prefix(), i.e. a...
Revision: 9635
Author: t.bro...@gmail.com
Date: Thu Jan 27 07:38:01 2011
Log: In r8817, we landed a patch that allows @Prefix(), i.e. a
non-prefixed PlaceTokenizer, and produces a separator-less history
token as a result. The token parsing however wasn't updated, and such
a token would always go the fallback route to the default place,
without ever being parsed.
See also: http://code.google.com/p/google-web-toolkit/issues/detail?id=5899
Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9635
Added:
/trunk/user/test/com/google/gwt/place/testplaces/Place6.java
Modified:
/trunk/user/src/com/google/gwt/place/impl/AbstractPlaceHistoryMapper.java
/trunk/user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java
/trunk/user/test/com/google/gwt/place/rebind/PlaceHistoryGeneratorContextTest.java
/trunk/user/test/com/google/gwt/place/testplacemappers/NoFactory.java
/trunk/user/test/com/google/gwt/place/testplacemappers/WithFactory.java
===
--- /dev/null
+++ /trunk/user/test/com/google/gwt/place/testplaces/Place6.java Thu Jan 27
07:38:01 2011
@@ -0,0 +1,45 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.place.testplaces;
+
+import com.google.gwt.place.shared.Place;
+import com.google.gwt.place.shared.PlaceTokenizer;
+import com.google.gwt.place.shared.Prefix;
+
+/**
+ * Used by tests of {@link
com.google.gwt.place.rebind.PlaceHistoryMapperGenerator}.
+ */
+public class Place6 extends Place {
+ public final String content;
+
+ public Place6(String token) {
+this.content = token;
+ }
+
+ /**
+ * Tokenizer.
+ */
+ @Prefix()
+ public static class Tokenizer implements PlaceTokenizerPlace6 {
+public Place6 getPlace(String token) {
+ return new Place6(token);
+}
+
+public String getToken(Place6 place) {
+ return place.content;
+}
+ }
+}
===
---
/trunk/user/src/com/google/gwt/place/impl/AbstractPlaceHistoryMapper.java
Tue Oct 5 17:59:14 2010
+++
/trunk/user/src/com/google/gwt/place/impl/AbstractPlaceHistoryMapper.java
Thu Jan 27 07:38:01 2011
@@ -51,13 +51,18 @@
public Place getPlace(String token) {
int colonAt = token.indexOf(':');
-if (colonAt 0) {
- String initial = token.substring(0, colonAt);
- String rest = token.substring(colonAt + 1);
- PlaceTokenizer? tokenizer = getTokenizer(initial);
- if (tokenizer != null) {
-return tokenizer.getPlace(rest);
- }
+String initial;
+String rest;
+if (colonAt = 0) {
+ initial = token.substring(0, colonAt);
+ rest = token.substring(colonAt + 1);
+} else {
+ initial = ;
+ rest = token;
+}
+PlaceTokenizer? tokenizer = getTokenizer(initial);
+if (tokenizer != null) {
+ return tokenizer.getPlace(rest);
}
return null;
}
===
---
/trunk/user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java
Mon Jan 24 15:45:54 2011
+++
/trunk/user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java
Thu Jan 27 07:38:01 2011
@@ -28,6 +28,7 @@
import com.google.gwt.place.testplaces.Place3;
import com.google.gwt.place.testplaces.Place4;
import com.google.gwt.place.testplaces.Place5;
+import com.google.gwt.place.testplaces.Place6;
import com.google.gwt.place.testplaces.Tokenizer2;
import com.google.gwt.place.testplaces.Tokenizer3;
import com.google.gwt.place.testplaces.Tokenizer4;
@@ -39,11 +40,11 @@
public class PlaceHistoryMapperGeneratorTest extends GWTTestCase {
@WithTokenizers({
Place1.Tokenizer.class, Tokenizer2.class, Tokenizer3.class,
- Tokenizer4.class})
+ Tokenizer4.class, Place6.Tokenizer.class})
interface LocalNoFactory extends PlaceHistoryMapper {
};
- @WithTokenizers(Tokenizer4.class)
+ @WithTokenizers({Tokenizer4.class, Place6.Tokenizer.class})
interface LocalWithFactory extends
PlaceHistoryMapperWithFactoryTokenizerFactory {
};
@@ -71,6 +72,7 @@
Place3 place3 = new Place3(charlie);
Place4 place4 = new Place4(delta);
Place5 place5 = new Place5(echo);
+ Place6 place6 = new Place6(foxtrot);
public void testTopLevelWithoutFactory() {
AbstractPlaceHistoryMapper? subject = GWT.create(NoFactory.class);
@@ -148,6 +150,12 @@
[gwt-contrib] Resolve gwt-servlet 2.1.0 issue 5918 (issue1331801)
Reviewers: rjrjr,
Description:
Explicitly add gwt-servlet current version as a dependency to
gwt-maven-plugin
Please review this at http://gwt-code-reviews.appspot.com/1331801/show
Affected files:
samples/expenses/pom.xml
Index: samples/expenses/pom.xml
===
--- samples/expenses/pom.xml(revision 9628)
+++ samples/expenses/pom.xml(working copy)
@@ -623,6 +623,11 @@
artifactIdgwt-dev/artifactId
version${gwt.version}/version
/dependency
+ dependency
+groupIdcom.google.gwt/groupId
+artifactIdgwt-servlet/artifactId
+version${gwt.version}/version
+ /dependency
/dependencies
configuration
logLevelINFO/logLevel
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Resolve gwt-servlet 2.1.0 issue 5918 (issue1331801)
I submitted this yesterday r9630. Can you look and confirm I did it right? rhttp://code.google.com/p/google-web-toolkit/source/detail?r=9630 http://gwt-code-reviews.appspot.com/1331801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9636 committed - Warn users of JRE 1.5 that their days are numbered...
Revision: 9636
Author: rj...@google.com
Date: Thu Jan 27 05:31:37 2011
Log: Warn users of JRE 1.5 that their days are numbered
Addresses http://code.google.com/p/google-web-toolkit/issues/detail?id=5884
Review at http://gwt-code-reviews.appspot.com/1328802
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9636
Modified:
/trunk/dev/core/src/com/google/gwt/util/tools/ToolBase.java
===
--- /trunk/dev/core/src/com/google/gwt/util/tools/ToolBase.java Mon Jun 7
12:20:31 2010
+++ /trunk/dev/core/src/com/google/gwt/util/tools/ToolBase.java Thu Jan 27
05:31:37 2011
@@ -62,6 +62,17 @@
* Use a linked hash map to preserve the declaration order.
*/
private final MapString, ArgHandler argHandlers = new
LinkedHashMapString, ArgHandler();
+
+ /**
+ * Log deprecation warning on old JREs.
+ */
+ protected void checkJdkVersion() {
+// JDK 1.6 is 50
+double classVersion =
Double.valueOf(System.getProperty(java.class.version,0.0));
+if (classVersion 50) {
+ System.err.println(WARNING: Use on a JRE prior to version 1.6 is
deprecated);
+}
+ }
protected String getDescription() {
return null;
@@ -180,6 +191,8 @@
}
protected boolean processArgs(String... args) {
+checkJdkVersion();
+
if (args.length 0) {
boolean help = false;
if (-help.equalsIgnoreCase(args[0])) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Resolve gwt-servlet 2.1.0 issue 5918 (issue1331801)
yep, r9630 is good. I'll close this out. http://gwt-code-reviews.appspot.com/1331801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9637 committed - Change GWT History to work when multiple applications are loaded withi...
Revision: 9637
Author: jhollenb...@google.com
Date: Thu Jan 27 07:30:25 2011
Log: Change GWT History to work when multiple applications are loaded
within the same page.
Patch by: jhollenbach
Review by: jat, jgw
Review at http://gwt-code-reviews.appspot.com/1322801
http://code.google.com/p/google-web-toolkit/source/detail?r=9637
Modified:
/trunk/user/src/com/google/gwt/user/client/impl/HistoryImpl.java
/trunk/user/src/com/google/gwt/user/client/impl/HistoryImplIE6.java
/trunk/user/src/com/google/gwt/user/client/impl/HistoryImplTimer.java
===
--- /trunk/user/src/com/google/gwt/user/client/impl/HistoryImpl.java Mon
Oct 26 14:02:26 2009
+++ /trunk/user/src/com/google/gwt/user/client/impl/HistoryImpl.java Thu
Jan 27 07:30:25 2011
@@ -35,9 +35,11 @@
*/
public class HistoryImpl implements HasValueChangeHandlersString,
HasHandlers {
- public static native String getToken() /*-{
-return $wnd.__gwt_historyToken || ;
- }-*/;
+ private static String token = ;
+
+ public static String getToken() {
+return (token == null) ? : token;
+ }
/**
* Sets whether the IE6 history implementation will update the URL hash
when
@@ -53,9 +55,9 @@
public static void setUpdateHashOnIE6(boolean updateHash) {
}
- protected static native void setToken(String token) /*-{
-$wnd.__gwt_historyToken = token;
- }-*/;
+ protected static void setToken(String token) {
+HistoryImpl.token = token;
+ }
private HandlerManager handlers = new HandlerManager(null);
@@ -97,6 +99,9 @@
@com.google.gwt.user.client.impl.HistoryImpl::setToken(Ljava/lang/String;)(token);
var historyImpl = this;
+
+var oldHandler = $wnd.onhashchange;
+
$wnd.onhashchange = $entry(function() {
var token = '', hash = $wnd.location.hash;
if (hash.length 0) {
@@ -104,6 +109,10 @@
}
historyim...@com.google.gwt.user.client.impl.HistoryImpl::newItemOnEvent(Ljava/lang/String;)(token);
+
+ if (oldHandler) {
+oldHandler();
+ }
});
return true;
===
--- /trunk/user/src/com/google/gwt/user/client/impl/HistoryImplIE6.java Fri
Oct 16 14:48:33 2009
+++ /trunk/user/src/com/google/gwt/user/client/impl/HistoryImplIE6.java Thu
Jan 27 07:30:25 2011
@@ -179,9 +179,14 @@
private native void injectGlobalHandler() /*-{
var historyImplRef = this;
+var oldOnLoad = $wnd.__gwt_onHistoryLoad;
$wnd.__gwt_onHistoryLoad = $entry(function(token) {
historyimplr...@com.google.gwt.user.client.impl.HistoryImpl::newItemOnEvent(Ljava/lang/String;)(token);
+
+ if (oldOnLoad) {
+oldOnLoad(token);
+ }
});
}-*/;
===
--- /trunk/user/src/com/google/gwt/user/client/impl/HistoryImplTimer.java
Wed Oct 28 09:10:53 2009
+++ /trunk/user/src/com/google/gwt/user/client/impl/HistoryImplTimer.java
Thu Jan 27 07:30:25 2011
@@ -35,9 +35,8 @@
// Create the timer that checks the browser's url hash every 1/4 s.
var historyImpl = this;
-$wnd.__checkHistory = $entry(function() {
- $wnd.setTimeout($wnd.__checkHistory, 250);
-
+
+var checkHistory = $entry(function() {
var token = '', hash = $wnd.location.hash;
if (hash.length 0) {
token =
historyim...@com.google.gwt.user.client.impl.HistoryImpl::decodeFragment(Ljava/lang/String;)(hash.substring(1));
@@ -46,8 +45,13 @@
historyim...@com.google.gwt.user.client.impl.HistoryImpl::newItemOnEvent(Ljava/lang/String;)(token);
});
+var checkHistoryCycle = function() {
+ $wnd.setTimeout(checkHistoryCycle, 250);
+ checkHistory();
+}
+
// Kick off the timer.
-$wnd.__checkHistory();
+checkHistoryCycle();
return true;
}-*/;
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9639 committed - Cherry picking r9636 into releases/2.2, jre 1.5 deprecation warning
Revision: 9639
Author: rj...@google.com
Date: Thu Jan 27 08:11:12 2011
Log: Cherry picking r9636 into releases/2.2, jre 1.5 deprecation warning
http://code.google.com/p/google-web-toolkit/source/detail?r=9639
Modified:
/releases/2.2/dev/core/src/com/google/gwt/util/tools/ToolBase.java
===
--- /releases/2.2/dev/core/src/com/google/gwt/util/tools/ToolBase.java Mon
Jun 7 12:20:31 2010
+++ /releases/2.2/dev/core/src/com/google/gwt/util/tools/ToolBase.java Thu
Jan 27 08:11:12 2011
@@ -62,6 +62,17 @@
* Use a linked hash map to preserve the declaration order.
*/
private final MapString, ArgHandler argHandlers = new
LinkedHashMapString, ArgHandler();
+
+ /**
+ * Log deprecation warning on old JREs.
+ */
+ protected void checkJdkVersion() {
+// JDK 1.6 is 50
+double classVersion =
Double.valueOf(System.getProperty(java.class.version,0.0));
+if (classVersion 50) {
+ System.err.println(WARNING: Use on a JRE prior to version 1.6 is
deprecated);
+}
+ }
protected String getDescription() {
return null;
@@ -180,6 +191,8 @@
}
protected boolean processArgs(String... args) {
+checkJdkVersion();
+
if (args.length 0) {
boolean help = false;
if (-help.equalsIgnoreCase(args[0])) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix the mac build for leopard users of the npapi/xpcom plugins. (issue1323802)
Reviewers: jat, fabiomfv,
Description:
Fix the mac build for leopard users of the npapi/xpcom plugins.
Please review this at http://gwt-code-reviews.appspot.com/1323802/show
Affected files:
M plugins/config.mk
M plugins/npapi/Makefile
M plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
M plugins/xpcom/Makefile
Index: plugins/config.mk
===
--- plugins/config.mk (revision 9618)
+++ plugins/config.mk (working copy)
@@ -80,7 +80,7 @@
endif
ifeq ($(shell uname),Darwin)
OS=mac
-BASECFLAGS= -g -O2 -fPIC $(INC) -D__mac
+BASECFLAGS= -g -O2 -fPIC $(INC) -D__mac -mmacosx-version-min=10.5
ARCHCFLAGS=-arch $(MARCH)
ALLARCHCFLAGS=-arch i386 -arch ppc -arch x86_64
AR=libtool
Index: plugins/npapi/Makefile
===
--- plugins/npapi/Makefile (revision 9618)
+++ plugins/npapi/Makefile (working copy)
@@ -17,7 +17,7 @@
ifeq ($(OS),mac)
RUN_PATH_FLAG = -executable_path
DLL_SUFFIX = .dylib
-DLLFLAGS = -bundle $(ARCHCFLAGS)
+DLLFLAGS = -bundle $(ARCHCFLAGS) -mmacosx-version-min=10.5
CFLAGS += -DXP_MACOSX $(ARCHCFLAGS)
CXXFLAGS += -DXP_MACOSX $(ARCHCFLAGS)
# Mac puts multiple architectures into the same files
Index: plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
===
--- plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (revision 9618)
+++ plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (working copy)
@@ -1,6 +1,6 @@
{
name: GWT Developer Plugin,
- version: 1.0.9614,
+ version: 1.0.9639,
description: A plugin to enable debugging with GWT's Development
Mode,
update_url: https://dl-ssl.google.com/gwt/plugins/chrome/updates.xml;,
icons: {
Index: plugins/xpcom/Makefile
===
--- plugins/xpcom/Makefile (revision 9618)
+++ plugins/xpcom/Makefile (working copy)
@@ -24,7 +24,7 @@
DEFAULT_FIREFOX_LIBS ?= /Applications/Firefox.app/Contents/MacOS
RUN_PATH_FLAG = -executable_path
DLL_SUFFIX = .dylib
-DLLFLAGS += -bundle $(ALLARCHCFLAGS)
+DLLFLAGS += -bundle $(ALLARCHCFLAGS) -mmacosx-version-min=10.5
CFLAGS += $(ALLARCHCFLAGS)
CXXFLAGS += $(ALLARCHCFLAGS)
TARGET_PLATFORM = Darwin-gcc3
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix the mac build for leopard users of the npapi/xpcom plugins. (issue1323802)
I have no way to test it, but LGTM http://gwt-code-reviews.appspot.com/1323802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix the mac build for leopard users of the npapi/xpcom plugins. (issue1323802)
LTGM http://gwt-code-reviews.appspot.com/1323802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Initial version of HTML5 Audio and Video (issue1318803)
Reviewers: rice, jlabanca, Description: Initial version of HTML5 Audio and Video Original patch by rice, updated by pdr. Please review this at http://gwt-code-reviews.appspot.com/1318803/show Affected files: A user/src/com/google/gwt/dom/client/AudioElement.java M user/src/com/google/gwt/dom/client/DOMImplMozilla.java M user/src/com/google/gwt/dom/client/Document.java A user/src/com/google/gwt/dom/client/MediaElement.java A user/src/com/google/gwt/dom/client/VideoElement.java A user/src/com/google/gwt/media/Media.gwt.xml A user/src/com/google/gwt/media/client/Audio.java A user/src/com/google/gwt/media/client/Video.java A user/src/com/google/gwt/media/client/package-info.java A user/src/com/google/gwt/media/dom/DOM.gwt.xml A user/src/com/google/gwt/media/dom/client/MediaError.java A user/src/com/google/gwt/media/dom/client/TimeRanges.java A user/src/com/google/gwt/media/dom/client/package-info.java M user/src/com/google/gwt/user/User.gwt.xml A user/test/com/google/gwt/media/MediaSuite.java A user/test/com/google/gwt/media/MediaTest.gwt.xml A user/test/com/google/gwt/media/client/AudioTest.java A user/test/com/google/gwt/media/client/MediaTest.java A user/test/com/google/gwt/media/client/VideoTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add mnemonics for DevMode swing UI. (issue1328801)
On 2011/01/26 21:57:09, jat wrote: LGTM http://gwt-code-reviews.appspot.com/1328801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit
Comment by javierfe...@gmail.com: Any update on this? Thanks For more information: http://code.google.com/p/google-web-toolkit/wiki/LightweightCollections -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9640 committed - Public: (by t.bro...@gmail.com):
Revision: 9640
Author: rj...@google.com
Date: Thu Jan 27 09:39:02 2011
Log: Public: (by t.bro...@gmail.com):
http://code.google.com/p/google-web-toolkit/source/detail?r=9640
Modified:
/trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.java
/trunk/user/test/com/google/gwt/dom/client/SelectTests.java
===
--- /trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.java Wed Dec 1
10:08:22 2010
+++ /trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.java Thu Jan 27
09:39:02 2011
@@ -276,36 +276,6 @@
return false;
}-*/;
- /*
- * The 'options' array cannot be used due to a bug in the version of
WebKit
- * that ships with GWT (http://bugs.webkit.org/show_bug.cgi?id=10472).
The
- * 'children' array, which is common for all DOM elements in Safari,
does not
- * suffer from the same problem. Ideally, the 'children' array should be
used
- * in all of the traversal methods in the DOM classes. Unfortunately,
due to a
- * bug in Safari 2 (http://bugs.webkit.org/show_bug.cgi?id=3330), this
will
- * not work. However, this bug does not cause problems in the case of
SELECT
- * elements, because their descendent elements are only one level deep.
- */
- @Override
- public void selectClear(SelectElement select) {
-select.setInnerText();
- }
-
- @Override
- public native int selectGetLength(SelectElement select) /*-{
-return select.children.length;
- }-*/;
-
- @Override
- public native NodeListOptionElement selectGetOptions(SelectElement
select) /*-{
-return select.children;
- }-*/;
-
- @Override
- public native void selectRemoveOption(SelectElement select, int index)
/*-{
-select.removeChild(select.children[index]);
- }-*/;
-
@Override
public void setScrollLeft(Document doc, int left) {
// Safari always applies document scrolling to the body element, even
in
===
--- /trunk/user/test/com/google/gwt/dom/client/SelectTests.java Sun Jul 19
11:17:55 2009
+++ /trunk/user/test/com/google/gwt/dom/client/SelectTests.java Thu Jan 27
09:39:02 2011
@@ -15,6 +15,8 @@
*/
package com.google.gwt.dom.client;
+import com.google.gwt.junit.DoNotRunWith;
+import com.google.gwt.junit.Platform;
import com.google.gwt.junit.client.GWTTestCase;
/**
@@ -127,4 +129,45 @@
assertTrue(opt1.isSelected());
assertTrue(opt2.isSelected());
}
-}
+
+ /**
+ * optgroups
+ *
+ * @see a
href=http://code.google.com/p/google-web-toolkit/issues/detail?id=4916;Issue
4916/a
+ */
+ @DoNotRunWith(Platform.HtmlUnitBug)
+ public void testOptGroups() {
+Document doc = Document.get();
+SelectElement select = doc.createSelectElement();
+doc.getBody().appendChild(select);
+
+OptionElement opt0 = doc.createOptionElement();
+OptionElement opt1 = doc.createOptionElement();
+OptionElement opt2 = doc.createOptionElement();
+OptGroupElement group1 = doc.createOptGroupElement();
+opt0.setText(foo);
+opt1.setText(bar);
+opt2.setText(baz);
+opt0.setValue(0);
+opt1.setValue(1);
+opt2.setValue(2);
+group1.setLabel(group1);
+
+select.appendChild(opt0);
+select.appendChild(group1);
+group1.appendChild(opt1);
+select.appendChild(opt2);
+
+assertEquals(3 options expected, 3, select.getOptions().getLength());
+assertEquals([0] == opt0, opt0, select.getOptions().getItem(0));
+assertEquals([1] == opt1, opt1, select.getOptions().getItem(1));
+assertEquals([2] == opt2, opt2, select.getOptions().getItem(2));
+
+select.remove(1);
+assertNull(null parent expected when removed,
opt1.getParentElement());
+
+select.add(opt1, opt0);
+assertEquals([0] == opt1, opt1, select.getOptions().getItem(0));
+assertEquals([1] == opt0, opt0, select.getOptions().getItem(1));
+}
+}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9641 committed - Fix the mac build for leopard users of the npapi/xpcom plugins....
Revision: 9641
Author: con...@google.com
Date: Thu Jan 27 09:50:46 2011
Log: Fix the mac build for leopard users of the npapi/xpcom plugins.
Review at http://gwt-code-reviews.appspot.com/1323802
http://code.google.com/p/google-web-toolkit/source/detail?r=9641
Modified:
/trunk/plugins/config.mk
/trunk/plugins/npapi/Makefile
/trunk/plugins/npapi/prebuilt/gwt-dev-plugin/Darwin-gcc3/gwtDev.plugin/Contents/MacOS/libGwtDevPlugin.dylib
/trunk/plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
/trunk/plugins/npapi/prebuilt/gwt-dev-plugin.crx
/trunk/plugins/xpcom/Makefile
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_dev_ff3.dylib
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff35/libgwt_dev_ff35.dylib
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff36/libgwt_dev_ff36.dylib
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff40/libgwt_dev_ff40.dylib
/trunk/plugins/xpcom/prebuilt/gwt-dev-plugin.xpi
===
--- /trunk/plugins/config.mkMon Jan 24 04:30:43 2011
+++ /trunk/plugins/config.mkThu Jan 27 09:50:46 2011
@@ -80,7 +80,7 @@
endif
ifeq ($(shell uname),Darwin)
OS=mac
-BASECFLAGS= -g -O2 -fPIC $(INC) -D__mac
+BASECFLAGS= -g -O2 -fPIC $(INC) -D__mac -mmacosx-version-min=10.5
ARCHCFLAGS=-arch $(MARCH)
ALLARCHCFLAGS=-arch i386 -arch ppc -arch x86_64
AR=libtool
===
--- /trunk/plugins/npapi/Makefile Tue Nov 23 05:51:12 2010
+++ /trunk/plugins/npapi/Makefile Thu Jan 27 09:50:46 2011
@@ -17,7 +17,7 @@
ifeq ($(OS),mac)
RUN_PATH_FLAG = -executable_path
DLL_SUFFIX = .dylib
-DLLFLAGS = -bundle $(ARCHCFLAGS)
+DLLFLAGS = -bundle $(ARCHCFLAGS) -mmacosx-version-min=10.5
CFLAGS += -DXP_MACOSX $(ARCHCFLAGS)
CXXFLAGS += -DXP_MACOSX $(ARCHCFLAGS)
# Mac puts multiple architectures into the same files
===
---
/trunk/plugins/npapi/prebuilt/gwt-dev-plugin/Darwin-gcc3/gwtDev.plugin/Contents/MacOS/libGwtDevPlugin.dylib
Tue Jan 25 12:47:44 2011
+++
/trunk/plugins/npapi/prebuilt/gwt-dev-plugin/Darwin-gcc3/gwtDev.plugin/Contents/MacOS/libGwtDevPlugin.dylib
Thu Jan 27 09:50:46 2011
Binary file, no diff available.
===
--- /trunk/plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json Thu Jan 27
07:52:14 2011
+++ /trunk/plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json Thu Jan 27
09:50:46 2011
@@ -1,6 +1,6 @@
{
name: GWT Developer Plugin,
- version: 1.0.9636,
+ version: 1.0.9639,
description: A plugin to enable debugging with GWT's Development
Mode,
update_url: https://dl-ssl.google.com/gwt/plugins/chrome/updates.xml;,
icons: {
===
--- /trunk/plugins/npapi/prebuilt/gwt-dev-plugin.crx Thu Jan 27 07:52:14
2011
+++ /trunk/plugins/npapi/prebuilt/gwt-dev-plugin.crx Thu Jan 27 09:50:46
2011
Binary file, no diff available.
===
--- /trunk/plugins/xpcom/Makefile Mon Jan 24 04:30:43 2011
+++ /trunk/plugins/xpcom/Makefile Thu Jan 27 09:50:46 2011
@@ -24,7 +24,7 @@
DEFAULT_FIREFOX_LIBS ?= /Applications/Firefox.app/Contents/MacOS
RUN_PATH_FLAG = -executable_path
DLL_SUFFIX = .dylib
-DLLFLAGS += -bundle $(ALLARCHCFLAGS)
+DLLFLAGS += -bundle $(ALLARCHCFLAGS) -mmacosx-version-min=10.5
CFLAGS += $(ALLARCHCFLAGS)
CXXFLAGS += $(ALLARCHCFLAGS)
TARGET_PLATFORM = Darwin-gcc3
===
---
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_dev_ff3.dylib
Mon Jan 24 04:30:43 2011
+++
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_dev_ff3.dylib
Thu Jan 27 09:50:46 2011
Binary file, no diff available.
===
---
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff35/libgwt_dev_ff35.dylib
Mon Jan 24 04:30:43 2011
+++
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff35/libgwt_dev_ff35.dylib
Thu Jan 27 09:50:46 2011
Binary file, no diff available.
===
---
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff36/libgwt_dev_ff36.dylib
Mon Jan 24 04:30:43 2011
+++
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff36/libgwt_dev_ff36.dylib
Thu Jan 27 09:50:46 2011
Binary file, no diff available.
===
---
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff40/libgwt_dev_ff40.dylib
Mon Jan 24 04:30:43 2011
+++
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff40/libgwt_dev_ff40.dylib
Thu Jan 27 09:50:46 2011
Binary file, no diff available.
===
--- /trunk/plugins/xpcom/prebuilt/gwt-dev-plugin.xpi Tue Jan 25 13:06:43
2011
+++ /trunk/plugins/xpcom/prebuilt/gwt-dev-plugin.xpi Thu Jan 27 09:50:46
2011
File is too large to display a diff.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Use 'boolean' instead of 'Z' for JSNI primitive type qualifiers. (issue1295805)
Reviewers: bobv, Message: This patch is transitional, we will continue to support the only style for now. Please review this at http://gwt-code-reviews.appspot.com/1295805/show Affected files: M dev/core/src/com/google/gwt/dev/javac/JsniChecker.java M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java M dev/core/test/com/google/gwt/dev/javac/JsniCheckerTest.java M user/src/com/google/gwt/rpc/rebind/RpcProxyCreator.java M user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add test org.hibernate.jsr303.tck.tests.validation.graphnavigation.GraphNavigationGwtTest (issue1332801)
LGTM On 2011/01/27 20:44:18, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1332801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] [google-web-toolkit] r9640 committed - Public: (by t.bro...@gmail.com):
The real log message (now correct in svn) for this change is:
Public (t.bro...@gmail.com):
Addresses http://code.google.com/p/google-web-toolkit/issues/detail?id=5563
For GIN friendliness, make the PlaceHistoryMapperGenerator return null
when it encounters a concrete implementation. (Returning null from
a code generator results in a new Foo() call.)
On Thu, Jan 27, 2011 at 6:25 PM, codesite-nore...@google.com wrote:
Revision: 9640
Author: rj...@google.com
Date: Thu Jan 27 09:39:02 2011
Log: Public: (by t.bro...@gmail.com):
http://code.google.com/p/google-web-toolkit/source/detail?r=9640
Modified:
/trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.java
/trunk/user/test/com/google/gwt/dom/client/SelectTests.java
===
--- /trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.javaWed
Dec 1 10:08:22 2010
+++ /trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.javaThu
Jan 27 09:39:02 2011
@@ -276,36 +276,6 @@
return false;
}-*/;
- /*
- * The 'options' array cannot be used due to a bug in the version of
WebKit
- * that ships with GWT (http://bugs.webkit.org/show_bug.cgi?id=10472).
The
- * 'children' array, which is common for all DOM elements in Safari,
does not
- * suffer from the same problem. Ideally, the 'children' array should be
used
- * in all of the traversal methods in the DOM classes. Unfortunately,
due to a
- * bug in Safari 2 (http://bugs.webkit.org/show_bug.cgi?id=3330), this
will
- * not work. However, this bug does not cause problems in the case of
SELECT
- * elements, because their descendent elements are only one level deep.
- */
- @Override
- public void selectClear(SelectElement select) {
-select.setInnerText();
- }
-
- @Override
- public native int selectGetLength(SelectElement select) /*-{
-return select.children.length;
- }-*/;
-
- @Override
- public native NodeListOptionElement selectGetOptions(SelectElement
select) /*-{
-return select.children;
- }-*/;
-
- @Override
- public native void selectRemoveOption(SelectElement select, int index)
/*-{
-select.removeChild(select.children[index]);
- }-*/;
-
@Override
public void setScrollLeft(Document doc, int left) {
// Safari always applies document scrolling to the body element, even
in
===
--- /trunk/user/test/com/google/gwt/dom/client/SelectTests.java Sun Jul 19
11:17:55 2009
+++ /trunk/user/test/com/google/gwt/dom/client/SelectTests.java Thu Jan 27
09:39:02 2011
@@ -15,6 +15,8 @@
*/
package com.google.gwt.dom.client;
+import com.google.gwt.junit.DoNotRunWith;
+import com.google.gwt.junit.Platform;
import com.google.gwt.junit.client.GWTTestCase;
/**
@@ -127,4 +129,45 @@
assertTrue(opt1.isSelected());
assertTrue(opt2.isSelected());
}
-}
+
+ /**
+ * optgroups
+ *
+ * @see a href=
http://code.google.com/p/google-web-toolkit/issues/detail?id=4916;Issue
4916/a
+ */
+ @DoNotRunWith(Platform.HtmlUnitBug)
+ public void testOptGroups() {
+Document doc = Document.get();
+SelectElement select = doc.createSelectElement();
+doc.getBody().appendChild(select);
+
+OptionElement opt0 = doc.createOptionElement();
+OptionElement opt1 = doc.createOptionElement();
+OptionElement opt2 = doc.createOptionElement();
+OptGroupElement group1 = doc.createOptGroupElement();
+opt0.setText(foo);
+opt1.setText(bar);
+opt2.setText(baz);
+opt0.setValue(0);
+opt1.setValue(1);
+opt2.setValue(2);
+group1.setLabel(group1);
+
+select.appendChild(opt0);
+select.appendChild(group1);
+group1.appendChild(opt1);
+select.appendChild(opt2);
+
+assertEquals(3 options expected, 3,
select.getOptions().getLength());
+assertEquals([0] == opt0, opt0, select.getOptions().getItem(0));
+assertEquals([1] == opt1, opt1, select.getOptions().getItem(1));
+assertEquals([2] == opt2, opt2, select.getOptions().getItem(2));
+
+select.remove(1);
+assertNull(null parent expected when removed,
opt1.getParentElement());
+
+select.add(opt1, opt0);
+assertEquals([0] == opt1, opt1, select.getOptions().getItem(0));
+assertEquals([1] == opt0, opt0, select.getOptions().getItem(1));
+}
+}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] [google-web-toolkit] r9640 committed - Public: (by t.bro...@gmail.com):
correction
Public (by t.bro...@gmail.com):
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=4916
http://www.google.com/url?sa=Dq=http%3A//code.google.com/p/google-web-toolkit/issues/detail%3Fid%3D4916
Remove old workaround code from DOMImplSafari for something that's been
fixed in Safari for a while makes it hard to work with optgroups in
select elements.
Reviewed by rj...@google.com
http://gwt-code-reviews.appspot.com/1313801/show
http://www.google.com/url?sa=Dq=http%3A//gwt-code-reviews.appspot.com/1313801/show
is the right description
The GIN friendliness change is r9603.
On Thu, Jan 27, 2011 at 6:56 PM, Chris Conroy con...@google.com wrote:
The real log message (now correct in svn) for this change is:
Public (t.bro...@gmail.com):
Addresses http://code.google.com/p/google-web-toolkit/issues/detail?id=5563
For GIN friendliness, make the PlaceHistoryMapperGenerator return null
when it encounters a concrete implementation. (Returning null from
a code generator results in a new Foo() call.)
On Thu, Jan 27, 2011 at 6:25 PM, codesite-nore...@google.com wrote:
Revision: 9640
Author: rj...@google.com
Date: Thu Jan 27 09:39:02 2011
Log: Public: (by t.bro...@gmail.com):
http://code.google.com/p/google-web-toolkit/source/detail?r=9640
Modified:
/trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.java
/trunk/user/test/com/google/gwt/dom/client/SelectTests.java
===
--- /trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.java
Wed Dec 1 10:08:22 2010
+++ /trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.java
Thu Jan 27 09:39:02 2011
@@ -276,36 +276,6 @@
return false;
}-*/;
- /*
- * The 'options' array cannot be used due to a bug in the version of
WebKit
- * that ships with GWT (http://bugs.webkit.org/show_bug.cgi?id=10472).
The
- * 'children' array, which is common for all DOM elements in Safari,
does not
- * suffer from the same problem. Ideally, the 'children' array should
be used
- * in all of the traversal methods in the DOM classes. Unfortunately,
due to a
- * bug in Safari 2 (http://bugs.webkit.org/show_bug.cgi?id=3330), this
will
- * not work. However, this bug does not cause problems in the case of
SELECT
- * elements, because their descendent elements are only one level deep.
- */
- @Override
- public void selectClear(SelectElement select) {
-select.setInnerText();
- }
-
- @Override
- public native int selectGetLength(SelectElement select) /*-{
-return select.children.length;
- }-*/;
-
- @Override
- public native NodeListOptionElement selectGetOptions(SelectElement
select) /*-{
-return select.children;
- }-*/;
-
- @Override
- public native void selectRemoveOption(SelectElement select, int index)
/*-{
-select.removeChild(select.children[index]);
- }-*/;
-
@Override
public void setScrollLeft(Document doc, int left) {
// Safari always applies document scrolling to the body element, even
in
===
--- /trunk/user/test/com/google/gwt/dom/client/SelectTests.java Sun Jul 19
11:17:55 2009
+++ /trunk/user/test/com/google/gwt/dom/client/SelectTests.java Thu Jan 27
09:39:02 2011
@@ -15,6 +15,8 @@
*/
package com.google.gwt.dom.client;
+import com.google.gwt.junit.DoNotRunWith;
+import com.google.gwt.junit.Platform;
import com.google.gwt.junit.client.GWTTestCase;
/**
@@ -127,4 +129,45 @@
assertTrue(opt1.isSelected());
assertTrue(opt2.isSelected());
}
-}
+
+ /**
+ * optgroups
+ *
+ * @see a href=
http://code.google.com/p/google-web-toolkit/issues/detail?id=4916;Issue
4916/a
+ */
+ @DoNotRunWith(Platform.HtmlUnitBug)
+ public void testOptGroups() {
+Document doc = Document.get();
+SelectElement select = doc.createSelectElement();
+doc.getBody().appendChild(select);
+
+OptionElement opt0 = doc.createOptionElement();
+OptionElement opt1 = doc.createOptionElement();
+OptionElement opt2 = doc.createOptionElement();
+OptGroupElement group1 = doc.createOptGroupElement();
+opt0.setText(foo);
+opt1.setText(bar);
+opt2.setText(baz);
+opt0.setValue(0);
+opt1.setValue(1);
+opt2.setValue(2);
+group1.setLabel(group1);
+
+select.appendChild(opt0);
+select.appendChild(group1);
+group1.appendChild(opt1);
+select.appendChild(opt2);
+
+assertEquals(3 options expected, 3,
select.getOptions().getLength());
+assertEquals([0] == opt0, opt0, select.getOptions().getItem(0));
+assertEquals([1] == opt1, opt1, select.getOptions().getItem(1));
+assertEquals([2] == opt2, opt2, select.getOptions().getItem(2));
+
+select.remove(1);
+assertNull(null parent expected when removed,
opt1.getParentElement());
+
+select.add(opt1, opt0);
+assertEquals([0] == opt1,
[gwt-contrib] [google-web-toolkit] r9642 committed - Sort format some files....
Revision: 9642
Author: sco...@google.com
Date: Thu Jan 27 12:46:16 2011
Log: Sort format some files.
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9642
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
/trunk/dev/core/src/com/google/gwt/dev/javac/JsniChecker.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
/trunk/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
===
---
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
Thu Sep 23 06:33:21 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
Thu Jan 27 12:46:16 2011
@@ -83,17 +83,14 @@
MethodArgNamesLookup methodArgs =
MethodParamCollector.collect(cud);
StringInterner interner = StringInterner.get();
-String packageName = interner.intern(
-Shared.getPackageName(builder.getTypeName()));
+String packageName =
interner.intern(Shared.getPackageName(builder.getTypeName()));
ListString unresolvedQualified = new ArrayListString();
ListString unresolvedSimple = new ArrayListString();
for (char[] simpleRef :
cud.compilationResult().simpleNameReferences) {
unresolvedSimple.add(interner.intern(String.valueOf(simpleRef)));
}
-for (char[][] qualifiedRef :
-cud.compilationResult().qualifiedReferences) {
- unresolvedQualified.add(
- interner.intern(CharOperation.toString(qualifiedRef)));
+for (char[][] qualifiedRef :
cud.compilationResult().qualifiedReferences) {
+
unresolvedQualified.add(interner.intern(CharOperation.toString(qualifiedRef)));
}
for (String jsniDep : jsniDeps) {
unresolvedQualified.add(interner.intern(jsniDep));
@@ -148,11 +145,10 @@
public CompileMoreLater(AdditionalTypeProviderDelegate delegate) {
compiler.setAdditionalTypeProviderDelegate(delegate);
}
-
+
public CollectionCompilationUnit addGeneratedTypes(TreeLogger logger,
CollectionGeneratedUnit generatedUnits) {
- Event compilationStateBuilderProcess =
-
SpeedTracerLogger.start(DevModeEventType.COMPILATION_STATE_BUILDER_PROCESS);
+ Event compilationStateBuilderProcess =
SpeedTracerLogger.start(DevModeEventType.COMPILATION_STATE_BUILDER_PROCESS);
try {
return doBuildGeneratedTypes(logger, generatedUnits, this);
} finally {
@@ -269,19 +265,17 @@
public static CompilationState buildFrom(TreeLogger logger,
SetResource resources) {
-Event compilationStateBuilderProcessEvent =
-
SpeedTracerLogger.start(DevModeEventType.COMPILATION_STATE_BUILDER_PROCESS);
- try {
- return instance.doBuildFrom(logger, resources, null);
- } finally {
- compilationStateBuilderProcessEvent.end();
- }
+Event compilationStateBuilderProcessEvent =
SpeedTracerLogger.start(DevModeEventType.COMPILATION_STATE_BUILDER_PROCESS);
+try {
+ return instance.doBuildFrom(logger, resources, null);
+} finally {
+ compilationStateBuilderProcessEvent.end();
+}
}
public static CompilationState buildFrom(TreeLogger logger,
SetResource resources, AdditionalTypeProviderDelegate delegate) {
-Event compilationStateBuilderProcessEvent =
-
SpeedTracerLogger.start(DevModeEventType.COMPILATION_STATE_BUILDER_PROCESS);
+Event compilationStateBuilderProcessEvent =
SpeedTracerLogger.start(DevModeEventType.COMPILATION_STATE_BUILDER_PROCESS);
try {
return instance.doBuildFrom(logger, resources, delegate);
} finally {
@@ -342,22 +336,20 @@
/**
* Build a new compilation state from a source oracle.
*/
- public CompilationState doBuildFrom(TreeLogger logger,
- SetResource resources) {
+ public CompilationState doBuildFrom(TreeLogger logger, SetResource
resources) {
return doBuildFrom(logger, resources, null);
}
/**
- * Build a new compilation state from a source oracle. Allow the caller
to specify
- * a compiler delegate that will handle undefined names.
+ * Build a new compilation state from a source oracle. Allow the caller
to
+ * specify a compiler delegate that will handle undefined names.
*
* TODO: maybe use a finer brush than to synchronize the whole thing.
*/
public synchronized CompilationState doBuildFrom(TreeLogger logger,
SetResource resources, AdditionalTypeProviderDelegate
compilerDelegate) {
-Event compilationStateBuilderProcess =
-
SpeedTracerLogger.start(DevModeEventType.COMPILATION_STATE_BUILDER_PROCESS);
-
+Event compilationStateBuilderProcess =
SpeedTracerLogger.start(DevModeEventType.COMPILATION_STATE_BUILDER_PROCESS);
+
try {
// Units we definitely
[gwt-contrib] [google-web-toolkit] r9643 committed - At application startup, assert that the specified user.agent selection...
Revision: 9643
Author: fre...@google.com
Date: Thu Jan 27 13:56:33 2011
Log: At application startup, assert that the specified user.agent selection
property value indeed matches the expected value for the executing browser
/ user agent, thus avoid long hours debugging strange error messages when a
single user agent compile, typically created for testing purposes, ends up
being executed in the wrong browser. In other words, this patches saves you
from pulling your hair out.
Fixes isuess: 5861
Review at http://gwt-code-reviews.appspot.com/1278801
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9643
Added:
/trunk/user/src/com/google/gwt/user/client/UserAgentAsserter.java
/trunk/user/src/com/google/gwt/user/rebind/UserAgentGenerator.java
/trunk/user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
Modified:
/trunk/user/src/com/google/gwt/dom/client/DOMImplIE8.java
/trunk/user/src/com/google/gwt/user/UserAgent.gwt.xml
/trunk/user/src/com/google/gwt/user/client/ui/impl/PopupImplMozilla.java
/trunk/user/test/com/google/gwt/dom/client/ElementTest.java
/trunk/user/test/com/google/gwt/resources/client/DataResourceDoNotEmbedTest.java
/trunk/user/test/com/google/gwt/user/client/ui/HistoryTest.java
===
--- /dev/null
+++ /trunk/user/src/com/google/gwt/user/client/UserAgentAsserter.java Thu
Jan 27 13:56:33 2011
@@ -0,0 +1,64 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package com.google.gwt.user.client;
+
+import com.google.gwt.core.client.EntryPoint;
+import com.google.gwt.core.client.GWT;
+
+/**
+ * Helper class, which, during startup, asserts that the specified
user.agent
+ * selection property value indeed matches the expected value for this
browser /
+ * user agent, thus avoid long hours debugging strange error messages when
a
+ * single user agent compile, typically created for testing purposes, ends
up
+ * being executed in the wrong browser.
+ */
+public class UserAgentAsserter implements EntryPoint {
+
+ /**
+ * Interface to provide both the compile time and runtime
+ * codeuser.agent/code selection property value.
+ */
+ interface UserAgentProperty {
+String getCompileTimeValue();
+
+String getRuntimeValue();
+ }
+
+ @Override
+ public void onModuleLoad() {
+UserAgentProperty impl = GWT.create(UserAgentProperty.class);
+String compileTimeValue = impl.getCompileTimeValue();
+String runtimeValue = impl.getRuntimeValue();
+
+if (!compileTimeValue.equals(runtimeValue)) {
+ displayMismatchWarning(runtimeValue, compileTimeValue);
+}
+ }
+
+ /**
+ * Implemented as a JSNI method to avoid potentially using any user agent
+ * specific deferred binding code, since this method is called precisely
when
+ * we're somehow executing code from the wrong user.agent permutation.
+ */
+ private native void displayMismatchWarning(String runtimeValue,
+ String compileTimeValue) /*-{
+$wnd.alert(ERROR: Possible problem with your *.gwt.xml module file.
++ \nThe compile time user.agent value ( + compileTimeValue
++ ) does not match the runtime user.agent value ( + runtimeValue
++ ). Expect more errors.\n);
+ }-*/;
+}
===
--- /dev/null
+++ /trunk/user/src/com/google/gwt/user/rebind/UserAgentGenerator.java Thu
Jan 27 13:56:33 2011
@@ -0,0 +1,110 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package com.google.gwt.user.rebind;
+
+import com.google.gwt.core.ext.BadPropertyValueException;
+import com.google.gwt.core.ext.Generator;
+import com.google.gwt.core.ext.GeneratorContext;
+import com.google.gwt.core.ext.PropertyOracle;
+import com.google.gwt.core.ext.SelectionProperty;
+import com.google.gwt.core.ext.TreeLogger;
+import
[gwt-contrib] [google-web-toolkit] r9644 committed - Fixes a javadoc typo in the app generated by WebAppCreator.
Revision: 9644 Author: rj...@google.com Date: Thu Jan 27 14:03:30 2011 Log: Fixes a javadoc typo in the app generated by WebAppCreator. http://code.google.com/p/google-web-toolkit/source/detail?r=9644 Modified: /trunk/user/src/com/google/gwt/user/tools/SharedClassTemplate.javasrc === --- /trunk/user/src/com/google/gwt/user/tools/SharedClassTemplate.javasrc Thu Sep 23 11:21:29 2010 +++ /trunk/user/src/com/google/gwt/user/tools/SharedClassTemplate.javasrc Thu Jan 27 14:03:30 2011 @@ -15,7 +15,7 @@ * p * When creating a class that is used on both the client and the server, be sure * that all code is translatable and does not use native JavaScript. Code that - * is note translatable (such as code that interacts with a database or the file + * is not translatable (such as code that interacts with a database or the file * system) cannot be compiled into client side JavaScript. Code that uses native * JavaScript (such as Widgets) cannot be run on the server. * /p -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter (issue1334801)
Reviewers: fredsa,
Description:
Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter
patch. We only just deprecated 1.5, need to be friendly for one more
relese.
Please review this at http://gwt-code-reviews.appspot.com/1334801/show
Affected files:
M user/src/com/google/gwt/user/client/UserAgentAsserter.java
M user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
Index: user/src/com/google/gwt/user/client/UserAgentAsserter.java
===
--- user/src/com/google/gwt/user/client/UserAgentAsserter.java (revision
9644)
+++ user/src/com/google/gwt/user/client/UserAgentAsserter.java (working
copy)
@@ -34,11 +34,10 @@
*/
interface UserAgentProperty {
String getCompileTimeValue();
-
+
String getRuntimeValue();
}
-
- @Override
+
public void onModuleLoad() {
UserAgentProperty impl = GWT.create(UserAgentProperty.class);
String compileTimeValue = impl.getCompileTimeValue();
Index: user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
===
--- user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
(revision 9644)
+++ user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
(working copy)
@@ -92,7 +92,6 @@
body.println(return 'unknown';);
}
- @Override
public String generate(TreeLogger logger, SortedSetString
possibleValues,
String fallback, SortedSetConfigurationProperty configProperties) {
for (String value : possibleValues) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9645 committed - Add test org.hibernate.jsr303.tck.tests.validation.graphnavigation.Gra...
Revision: 9645
Author: ncha...@google.com
Date: Thu Jan 27 14:17:20 2011
Log: Add test
org.hibernate.jsr303.tck.tests.validation.graphnavigation.GraphNavigationGwtTest
[JSR 303 TCK Result] 91 of 257 (35.41%) Pass with 33 Failures and 16 Errors.
Review at http://gwt-code-reviews.appspot.com/1332801
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9645
Added:
/trunk/user/test/com/google/gwt/validation/tck/GraphNavigationGwtSuite.java
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationGwtTest.java
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/TckTest.gwt.xml
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/TckTestValidatorFactory.java
===
--- /dev/null
+++
/trunk/user/test/com/google/gwt/validation/tck/GraphNavigationGwtSuite.java
Thu Jan 27 14:17:20 2011
@@ -0,0 +1,33 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.validation.tck;
+
+import junit.framework.Test;
+
+import
org.hibernate.jsr303.tck.tests.validation.graphnavigation.GraphNavigationGwtTest;
+import org.hibernate.jsr303.tck.util.TckTestSuiteWrapper;
+
+/**
+ * Tck Tests for the {@code validation graphnavigation} package.
+ */
+public class GraphNavigationGwtSuite {
+ public static Test suite() {
+TckTestSuiteWrapper suite = new TckTestSuiteWrapper(
+TCK for GWT Validation, validation graphnavigation package);
+suite.addTestSuite(GraphNavigationGwtTest.class);
+return suite;
+ }
+}
===
--- /dev/null
+++
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/GraphNavigationGwtTest.java
Thu Jan 27 14:17:20 2011
@@ -0,0 +1,77 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.hibernate.jsr303.tck.tests.validation.graphnavigation;
+
+import com.google.gwt.junit.client.GWTTestCase;
+
+import org.hibernate.jsr303.tck.util.client.Failing;
+
+/**
+ * Test wrapper for {@link ValidationTest}.
+ */
+public class GraphNavigationGwtTest extends GWTTestCase {
+
+ private final GraphNavigationTest delegate = new GraphNavigationTest();
+
+ @Override
+ public String getModuleName() {
+
return org.hibernate.jsr303.tck.tests.validation.graphnavigation.TckTest;
+ }
+
+ @Failing(issue = 5946)
+ public void testContainedIterable() {
+delegate.testContainedIterable();
+ }
+
+ @Failing(issue = 5946)
+ public void testContainedMap() {
+delegate.testContainedMap();
+ }
+
+ @Failing(issue = 5946)
+ public void testContainedSet() {
+delegate.testContainedSet();
+ }
+
+ @Failing(issue = 5946)
+ public void testFullGraphValidationBeforeNextGroupInSequence() {
+delegate.testFullGraphValidationBeforeNextGroupInSequence();
+ }
+
+ @Failing(issue = 5946)
+ public void testGraphNavigationDeterminism() {
+delegate.testGraphNavigationDeterminism();
+ }
+
+ @Failing(issue = 5946)
+ public void testNoEndlessLoop() {
+delegate.testNoEndlessLoop();
+ }
+
+ public void testNullReferencesGetIgnored() {
+delegate.testNullReferencesGetIgnored();
+ }
+
+ @Failing(issue = 5946)
+ public void testTypeOfContainedValueIsDeterminedAtRuntime() {
+delegate.testTypeOfContainedValueIsDeterminedAtRuntime();
+ }
+
+ @Failing(issue = 5946)
+ public void testTypeOfContainedValuesIsDeterminedAtRuntime() {
+delegate.testTypeOfContainedValuesIsDeterminedAtRuntime();
+ }
+}
===
--- /dev/null
+++
/trunk/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/TckTest.gwt.xml
Thu Jan 27 14:17:20 2011
@@ -0,0 +1,26 @@
+?xml version=1.0 encoding=UTF-8?
+!DOCTYPE module PUBLIC -//Google
[gwt-contrib] Improvements to JsniChecker. (issue1333801)
Reviewers: bobv, Description: - JsniChecker now implements ALL of the JSNI checks that were being done in GenerateJavaAST. - JsniCheckerTest tests them all. - JsniChecker reports the resolved refs it collected. - Tighter type on jsni method map. Please review this at http://gwt-code-reviews.appspot.com/1333801/show Affected files: M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java M dev/core/src/com/google/gwt/dev/javac/JsniChecker.java M dev/core/src/com/google/gwt/dev/javac/JsniCollector.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java M dev/core/test/com/google/gwt/dev/javac/JsniCheckerTest.java M dev/core/test/com/google/gwt/dev/javac/JsniCollectorTest.java M dev/core/test/com/google/gwt/dev/javac/impl/JavaResourceBase.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9646 committed - Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter...
Revision: 9646
Author: rj...@google.com
Date: Thu Jan 27 16:01:17 2011
Log: Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter
patch. We only just deprecated 1.5, need to be friendly for one more
relese.
Review at http://gwt-code-reviews.appspot.com/1334801
Review by: fre...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9646
Modified:
/trunk/user/src/com/google/gwt/user/client/UserAgentAsserter.java
/trunk/user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
===
--- /trunk/user/src/com/google/gwt/user/client/UserAgentAsserter.java Thu
Jan 27 13:56:33 2011
+++ /trunk/user/src/com/google/gwt/user/client/UserAgentAsserter.java Thu
Jan 27 16:01:17 2011
@@ -34,11 +34,10 @@
*/
interface UserAgentProperty {
String getCompileTimeValue();
-
+
String getRuntimeValue();
}
-
- @Override
+
public void onModuleLoad() {
UserAgentProperty impl = GWT.create(UserAgentProperty.class);
String compileTimeValue = impl.getCompileTimeValue();
===
---
/trunk/user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
Thu Jan 27 13:56:33 2011
+++
/trunk/user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
Thu Jan 27 16:01:17 2011
@@ -92,7 +92,6 @@
body.println(return 'unknown';);
}
- @Override
public String generate(TreeLogger logger, SortedSetString
possibleValues,
String fallback, SortedSetConfigurationProperty configProperties) {
for (String value : possibleValues) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
