[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
On 2012/06/14 01:20:58, skybrian wrote: To fix the compiler and close issue 7397, we only need to add json (of any version) to gwt-dev.jar. So I think I'm going to commit a tiny change that just does that. We can defer the other stuff until we have a better plan. OK let's do that. Baby steps. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
On Wed, Jun 13, 2012 at 11:23 PM, Rajeev Dayal rda...@google.com wrote: On Wed, Jun 13, 2012 at 5:04 PM, Brian Slesinsky skybr...@google.com wrote: I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790 https://groups.google.com/forum/#!msg/google-web-toolkit/fATw0rL8lSE/xbxX5Hf8ozUJ I'm totally fine with dropping support for 1.5 altogether. +1. I think support was dropped in GWT 2.4. Whose responsible for the Developer Guide? It seems like it still mentions 1.5: https://groups.google.com/d/msg/google-web-toolkit/wgDAHJoqqPg/3C3uGa67GKUJ (even though we've been supporting the 1.6 syntax for long: @Overrides on methods implementing interfaces, and emulated String#isEmpty()) -- Thomas Broyer /tɔ.ma.bʁwa.je/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
I've removed the changes concerning javax.validation, so it's still distributed as a separate JAR. org.json is now bundled in gwt-dev, no longer bundled into requestfactory-* JARs, and distributed as a separate JAR in the SDK (so that requestfactory users have the choice to user gwt-servlet-deps.jar with both org.json and javax.validation, or either one or both the separate JARs; Android users can just pick the javax.validation JAR, as org.json is provided by the platform). I've also updated JSON to use the original, Java-1.6-compiled, JAR, as GWT now requires Java6 anyway. That way, the JAR in the SDK is named json.jar I've kept the json-1.5.jar in gwt-servlet-deps.jar though, in case people are still using Java 1.5 on the server-side. That means that for those people using Java 1.5 on their server, if they didn't use gwt-servlet-deps.jar but relied on the org.json bundled into requestfactory-server.jar, they'll have to download the json-1.5.jar (either from the GWT SVN or elsewhere), or switch to using gwt-serlvet-deps.jar. Given that Java 1.5 has reached EOL, I don't really mind giving them a bit more work (IFF they update GWT!) I'm open to reverting to json-1.5.jar though. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790 https://groups.google.com/forum/#!msg/google-web-toolkit/fATw0rL8lSE/xbxX5Hf8ozUJ I'm totally fine with dropping support for 1.5 altogether. - Brian On Wed, Jun 13, 2012 at 9:47 AM, t.bro...@gmail.com wrote: I've removed the changes concerning javax.validation, so it's still distributed as a separate JAR. org.json is now bundled in gwt-dev, no longer bundled into requestfactory-* JARs, and distributed as a separate JAR in the SDK (so that requestfactory users have the choice to user gwt-servlet-deps.jar with both org.json and javax.validation, or either one or both the separate JARs; Android users can just pick the javax.validation JAR, as org.json is provided by the platform). I've also updated JSON to use the original, Java-1.6-compiled, JAR, as GWT now requires Java6 anyway. That way, the JAR in the SDK is named json.jar I've kept the json-1.5.jar in gwt-servlet-deps.jar though, in case people are still using Java 1.5 on the server-side. That means that for those people using Java 1.5 on their server, if they didn't use gwt-servlet-deps.jar but relied on the org.json bundled into requestfactory-server.jar, they'll have to download the json-1.5.jar (either from the GWT SVN or elsewhere), or switch to using gwt-serlvet-deps.jar. Given that Java 1.5 has reached EOL, I don't really mind giving them a bit more work (IFF they update GWT!) I'm open to reverting to json-1.5.jar though. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
On Wed, Jun 13, 2012 at 5:04 PM, Brian Slesinsky skybr...@google.comwrote: I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790 https://groups.google.com/forum/#!msg/google-web-toolkit/fATw0rL8lSE/xbxX5Hf8ozUJ I'm totally fine with dropping support for 1.5 altogether. +1. I think support was dropped in GWT 2.4. - Brian On Wed, Jun 13, 2012 at 9:47 AM, t.bro...@gmail.com wrote: I've removed the changes concerning javax.validation, so it's still distributed as a separate JAR. org.json is now bundled in gwt-dev, no longer bundled into requestfactory-* JARs, and distributed as a separate JAR in the SDK (so that requestfactory users have the choice to user gwt-servlet-deps.jar with both org.json and javax.validation, or either one or both the separate JARs; Android users can just pick the javax.validation JAR, as org.json is provided by the platform). I've also updated JSON to use the original, Java-1.6-compiled, JAR, as GWT now requires Java6 anyway. That way, the JAR in the SDK is named json.jar I've kept the json-1.5.jar in gwt-servlet-deps.jar though, in case people are still using Java 1.5 on the server-side. That means that for those people using Java 1.5 on their server, if they didn't use gwt-servlet-deps.jar but relied on the org.json bundled into requestfactory-server.jar, they'll have to download the json-1.5.jar (either from the GWT SVN or elsewhere), or switch to using gwt-serlvet-deps.jar. Given that Java 1.5 has reached EOL, I don't really mind giving them a bit more work (IFF they update GWT!) I'm open to reverting to json-1.5.jar though. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
Okay, seems fine for now. I'm going to commit this. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
On 2012/06/13 21:45:00, skybrian wrote: Okay, seems fine for now. I'm going to commit this. FYI, I just removed all occurrences of json-1.5.jar, so we consistently use json.jar everywhere. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
I'm getting failing tests because JSON is gone from gwt-user.jar and the requestfactory jars. I could add the dependency internal to google, but I think we might still be trying to do too much at once - this is looking more like churn than an actual improvement. To fix the compiler and close issue 7397, we only need to add json (of any version) to gwt-dev.jar. So I think I'm going to commit a tiny change that just does that. We can defer the other stuff until we have a better plan. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
Moving org.json into gwt-dev makes sense because the compiler actually
uses it. I'd like to see it repackaged, but perhaps we can wait until
someone complains?
I'm not sure about validation. Many people don't use it and I sorta
think GWT's validation support ought to be split out of gwt-user into a
separate jar. If there's no actual bug than I'm inclined to leave it
alone for now.
But I wasn't around when these decisions were made, so I could use some
historical context.
https://gwt-code-reviews.appspot.com/1731804/diff/1/dev/build.xml
File dev/build.xml (right):
https://gwt-code-reviews.appspot.com/1731804/diff/1/dev/build.xml#newcode116
dev/build.xml:116: fileset dir=${gwt.tools.redist}
Do you know what the difference is between gwt.tools.lib and
gwt.tools.redist? If we're going to include JSON here, I'm wondering if
we should move the jar to lib.
https://gwt-code-reviews.appspot.com/1731804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
I'm not sure about validation. Many people don't use it and I sorta
think GWT's validation support ought to be split out of gwt-user into a
separate jar. If there's no actual bug than I'm inclined to leave it
alone for now.
This would absolutely kill compatibility with gwt-validation. (
https://code.google.com/p/gwt-validation/)
That would make it almost impossible to get gwt-validation to work with
future versions of GWT because of the multiple classpath issues that would
be introduced. Further: most people don't use the javax.validation package
included with GWT. There are also a fair few people, around 100 I'd
estimate, that use gwt-validation and would have to investigate something
else if this change was made.
v/r
Chris
On Friday, June 8, 2012 2:02:44 PM UTC-4, Brian Slesinsky wrote:
Moving org.json into gwt-dev makes sense because the compiler actually
uses it. I'd like to see it repackaged, but perhaps we can wait until
someone complains?
I'm not sure about validation. Many people don't use it and I sorta
think GWT's validation support ought to be split out of gwt-user into a
separate jar. If there's no actual bug than I'm inclined to leave it
alone for now.
But I wasn't around when these decisions were made, so I could use some
historical context.
https://gwt-code-reviews.appspot.com/1731804/diff/1/dev/build.xml
File dev/build.xml (right):
https://gwt-code-reviews.appspot.com/1731804/diff/1/dev/build.xml#newcode116
dev/build.xml:116https://gwt-code-reviews.appspot.com/1731804/diff/1/dev/build.xml#newcode116dev/build.xml:116:
fileset dir=${gwt.tools.redist}
Do you know what the difference is between gwt.tools.lib and
gwt.tools.redist? If we're going to include JSON here, I'm wondering if
we should move the jar to lib.
https://gwt-code-reviews.appspot.com/1731804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
think GWT's validation support ought to be split out of gwt-user into a separate jar. This would absolutely kill compatibility with gwt-validation I know very little about gwt-validation and GWT's javax validation, but wouldn't having GWT's validation in a separate jar make it easier for users to provide their own validation logic, like gwt-validation? Or do you have dependencies on GWT's javax validation, and if so, couldn't your users also depend on the hypothetical separate jar? - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
On 2012/06/08 18:02:44, skybrian wrote:
Moving org.json into gwt-dev makes sense because the compiler actually
uses it.
I'd like to see it repackaged, but perhaps we can wait until someone
complains?
I'm not sure about validation. Many people don't use it and I sorta
think GWT's
validation support ought to be split out of gwt-user into a separate
jar. If
there's no actual bug than I'm inclined to leave it alone for now.
validation is needed by RF (Receiver#onConstraintViolations) and Editors
(EditorDriver#setConstraintViolations); not to mention RF on the server
side validating the domain objects (ReflectiveServiceLayer), but there's
gwt-servlet-deps.jar for that, that bundles json and validation.
But I wasn't around when these decisions were made, so I could use
some
historical context.
Looking at the commit logs, I found
http://code.google.com/p/google-web-toolkit/issues/detail?id=5950
The reviews discuss the bundling vs. no bundling options; it looks like
the no-bundling option was chosen as being more Maven friendly (which
is a false problem, as we're not publishing the same JARs as the ones
from the SDK), and not forcing everyone to use the version of
javax.validation that we bundle.
Given that there's a single javax.validation version to date, and I
expect we'll switch to a more modular build (using Maven) soon; before
1.1 comes out (see http://beanvalidation.org/ )
https://gwt-code-reviews.appspot.com/1731804/diff/1/dev/build.xml
File dev/build.xml (right):
https://gwt-code-reviews.appspot.com/1731804/diff/1/dev/build.xml#newcode116
dev/build.xml:116: fileset dir=${gwt.tools.redist}
On 2012/06/08 18:02:44, skybrian wrote:
Do you know what the difference is between gwt.tools.lib and
gwt.tools.redist?
Absolutely no idea. I suppose JSON was put there by mistake.
If we're going to include JSON here, I'm wondering if we should move
the jar to
lib.
Maybe. On the other hand, we're aiming at switching to Maven and we'd
then grab org.json:json from Central.
I'm going to spend my summer working on this (hoping it'll take way less
time than the summer ;-) )
https://gwt-code-reviews.appspot.com/1731804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
Chris, I'm not sure what you mean by This. Do you mean the patch as it stands or something I've been speculating about? On Fri, Jun 8, 2012 at 11:43 AM, Chris Ruffalo chris.ruff...@gmail.com wrote: This would absolutely kill compatibility with gwt-validation. (https://code.google.com/p/gwt-validation/) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
I guess I didn't make myself clear, I was agreeing. GWT's validation should *always* be in a separate module from gwt-user. What I should have said Otherwise, this would completely kill... I don't think that moving javax.validation into gwt-user would be a good idea. Especially if it comes with the built in GwtValidation module. I guess it might be okay as a standalone but not that many people use javax.validation if everything I've read is to be believed. Maybe I jumped on this one a little hard. Sorry for not being 100% clear, Chris On Fri, Jun 8, 2012 at 2:50 PM, Stephen Haberman step...@exigencecorp.comwrote: think GWT's validation support ought to be split out of gwt-user into a separate jar. This would absolutely kill compatibility with gwt-validation I know very little about gwt-validation and GWT's javax validation, but wouldn't having GWT's validation in a separate jar make it easier for users to provide their own validation logic, like gwt-validation? Or do you have dependencies on GWT's javax validation, and if so, couldn't your users also depend on the hypothetical separate jar? - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
Okay, I think we should just fix JSON in this patch and figure out validation as a separate patch. - Brian On Fri, Jun 8, 2012 at 12:04 PM, Chris Ruffalo chris.ruff...@gmail.com wrote: I guess I didn't make myself clear, I was agreeing. GWT's validation should *always* be in a separate module from gwt-user. What I should have said Otherwise, this would completely kill... I don't think that moving javax.validation into gwt-user would be a good idea. Especially if it comes with the built in GwtValidation module. I guess it might be okay as a standalone but not that many people use javax.validation if everything I've read is to be believed. Maybe I jumped on this one a little hard. Sorry for not being 100% clear, Chris On Fri, Jun 8, 2012 at 2:50 PM, Stephen Haberman step...@exigencecorp.com wrote: think GWT's validation support ought to be split out of gwt-user into a separate jar. This would absolutely kill compatibility with gwt-validation I know very little about gwt-validation and GWT's javax validation, but wouldn't having GWT's validation in a separate jar make it easier for users to provide their own validation logic, like gwt-validation? Or do you have dependencies on GWT's javax validation, and if so, couldn't your users also depend on the hypothetical separate jar? - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)
On Fri, Jun 8, 2012 at 8:43 PM, Chris Ruffalo chris.ruff...@gmail.com wrote: I'm not sure about validation. Many people don't use it and I sorta think GWT's validation support ought to be split out of gwt-user into a separate jar. If there's no actual bug than I'm inclined to leave it alone for now. This would absolutely kill compatibility with gwt-validation. (https://code.google.com/p/gwt-validation/) That would make it almost impossible to get gwt-validation to work with future versions of GWT because of the multiple classpath issues that would be introduced. Further: most people don't use the javax.validation package included with GWT. There are also a fair few people, around 100 I'd estimate, that use gwt-validation and would have to investigate something else if this change was made. I'm afraid I don't understand. Let me sum up: - gwt-user depends on javax.validation, which is currently in a validation-api.jar in the SDK (there's also validation-api-sources.jar). - gwt-validation depends on javax.validation, and instruct users to put it in the classpath So where's the problem with either solution? (bundling it within gwt-user, or letting it as a separate JAR as today, and as Brian suggests it stays) Also, note that the gwt-user in Maven won't bundle javax.validation but instead declares a dependency javax.validation:validation-api (as is already the case today). No problem either. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
