[gwt-contrib] Re: Make GWT.create/etc usable on server. (issue1677803)

2012-04-22 Thread cromwellian 

lgtm


http://gwt-code-reviews.appspot.com/1677803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make GWT.create/etc usable on server. (issue1677803)

2012-04-18 Thread cromwellian 

LGTM


http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java
File user/src/com/google/gwt/core/server/ServerGwtBridge.java (right):

http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java#newcode263
user/src/com/google/gwt/core/server/ServerGwtBridge.java:263: public
String getVersion() {
Too bad com.google.gwt.dev.About is part of the gwt-dev package and not
shared. :(

http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java#newcode273
user/src/com/google/gwt/core/server/ServerGwtBridge.java:273: public
void log(String message, Throwable e) {
Maybe Logger.getLogger(ServerGwtBridge.class).log() or allow the
ServerGwtBridge to be configured with some logger callback interface so
that ServletContext.log(), java.u.logging, or any other desired logger
can be used.

http://gwt-code-reviews.appspot.com/1677803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make GWT.create/etc usable on server. (issue1677803)

2012-04-18 Thread jat 

Thanks for the review.


http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java
File user/src/com/google/gwt/core/server/ServerGwtBridge.java (right):

http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java#newcode263
user/src/com/google/gwt/core/server/ServerGwtBridge.java:263: public
String getVersion() {
On 2012/04/18 21:45:01, cromwellian wrote:

Too bad com.google.gwt.dev.About is part of the gwt-dev package and

not shared.

:(


I thought about it, but we don't have an easy way to share classes
between gwt-dev and gwt-user.  Plus, it might be confusing for shared
code -- do we consider the client or the server?  I'm not sure this
should even really be here, but the API already had it.

http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java#newcode273
user/src/com/google/gwt/core/server/ServerGwtBridge.java:273: public
void log(String message, Throwable e) {
On 2012/04/18 21:45:01, cromwellian wrote:

Maybe Logger.getLogger(ServerGwtBridge.class).log() or allow the

ServerGwtBridge

to be configured with some logger callback interface so that
ServletContext.log(), java.u.logging, or any other desired logger can

be used.

I don't want to add a bunch, so I will just use j.u.logging.

http://gwt-code-reviews.appspot.com/1677803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make GWT.create/etc usable on server. (issue1677803)

2012-04-09 Thread jat 

@scottb - now that you are back, would you care to review this again?
Since you last looked at it, I changed the way server-side class
instantiators are registered, added a way to register property values,
and added a servlet testing the Localizable instantiator.

http://gwt-code-reviews.appspot.com/1677803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make GWT.create/etc usable on server. (issue1677803)

2012-04-08 Thread jat 

http://gwt-code-reviews.appspot.com/1677803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors