Re: New commiter

2020-05-01 Thread Eric Bavier

On 01.05.2020 10:23, Brice Waegeneire wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hello Guix,

You may have seen me around in the mailing lists or on IRC as bricewge. 
For
some months now I have been contributing to Guix on a regular basis. 
And it
seems I have been helpful in some ways since yesterday I was granted 
commit

access to the git repo. It's an honor to be on board, thank you all.


Welcome!  Nice to have you on board.

--
`~Eric



Re: branch master updated: gnu: gnuradio: Fix runtime python environment for plugins.

2020-05-01 Thread Ludovic Courtès
Hi Guillaume,

guix-comm...@gnu.org skribis:

>  (native-search-paths
> + ;; Variables required to find third-party plugins at runtime.
>   (list (search-path-specification
>  (variable "GRC_BLOCKS_PATH")
> -(files '("/share/gnuradio/grc/blocks")
> +(files '("share/gnuradio/grc/blocks")))
> +   (search-path-specification
> +(variable "PYTHONPATH")
> +(files (list (string-append "lib/python"
> +(version-major+minor
> + (package-version python))
> +"/site-packages"))
>  (synopsis "Toolkit for software-defined radios")

It’s not OK to have PYTHONPATH in here because that variable “belongs”
to Python, not to GNU Radio.

A profile containing both gnuradio and python will have PYTHONPATH
correctly set.  However, I guess you want to ensure that PYTHONPATH is
correct even when Python is not in the profile, right?

In that case, I’d recommend wrapping the gnuradio executables such that
PYTHONPATH is correct.

Does that make sense?

See also one of our oldest bugs: .

(Apologies if I missed a previous discussion!)

Thanks,
Ludo’.



Re: 13/36: services: Add hurd-console-service-type.

2020-05-01 Thread Jan Nieuwenhuizen
Jan Nieuwenhuizen writes:

> Now this
>
> guix system build --target=i586-pc-gnu gnu/system/examples/bare-hurd.tmpl

Oops the above works, I should have said:

Now this

 guix system vm-image --target=i586-pc-gnu 
gnu/system/examples/bare-hurd.tmpl

... etc

We can now, actually cross build using guix system build; but the
problem is in creating a VM with a cross-built system in it, as
described in that message.

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: M2-Planet v1.6.0 and mescc-tools v1.0.0 released

2020-05-01 Thread Joshua Branson
"Orians, Jeremiah (DTMB)"  writes:

> https://github.com/oriansj/M2-Planet
>
> https://savannah.nongnu.org/projects/mescc-tools
>
> A K+R C equivalent C compiler, assembler, linker, dwarf stub generator and 
> shell able to produce 
>
> fully standards compliant ELF binaries for Knight, x86, AMD64, armv7l and 
> aarch64
>
> and be bootstrapped from a sub 250byte hex0 hex assembler and a 737byte shell
>
> -Jeremiah
>

AWESOME!


-- 
Joshua Branson
Sent from Emacs and Gnus



M2-Planet v1.6.0 and mescc-tools v1.0.0 released

2020-05-01 Thread Orians, Jeremiah (DTMB)
https://github.com/oriansj/M2-Planet
https://savannah.nongnu.org/projects/mescc-tools

A K+R C equivalent C compiler, assembler, linker, dwarf stub generator and 
shell able to produce
fully standards compliant ELF binaries for Knight, x86, AMD64, armv7l and 
aarch64
and be bootstrapped from a sub 250byte hex0 hex assembler and a 737byte shell

-Jeremiah


New commiter

2020-05-01 Thread Brice Waegeneire

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hello Guix,

You may have seen me around in the mailing lists or on IRC as bricewge. 
For
some months now I have been contributing to Guix on a regular basis. And 
it
seems I have been helpful in some ways since yesterday I was granted 
commit

access to the git repo. It's an honor to be on board, thank you all.

I'll sign my commits with the GPG key
8929 BBC5 73CD 9206 3DDD  979D 3D36 CAA0 116F 0F99
which you can find on my Savannah profile[0]. I hope I'll be able to 
serve

well the GNU Guix project!

[0]: https://savannah.gnu.org/users/bricewge

See you around,
- - Brice
-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEHJvwBRoaakRSV1maqUkDoWahj64FAl6sPpAACgkQqUkDoWah
j646QBAAtVmF0TiWAR8PlMa4WepCat9B1ks5/TRMPNKs1Pp6cuqUHNK/vhVrWXgf
mGMCVM73GsOYLScXz4j7nvdaCP3SldnxrvpIzvzma67ehcCc46vvJEf2KVl5pI3+
pc5BTqiJcyjc1CSFj+SvzE0oMT8q/MLyzS8eTGw3/KxROeHVjU43TVfVbqzG5w/r
+UQAfLrAE4/I0VKz5hMzpZdliHcKy/pRNAeEZVOxxP8FWFMwp/hS0nETs2WajWwi
BkQXTXRdxyEMx5oB4L7eJ5w9jbZFA8ANlTHduOtaTv2WX2feiP8Yxx0bXbfWbO6e
Pv/MMC5ARfU1zdy5V+RhHHVgDIFH9o6KpYFC/hlJXmvYp/KzauLvBCf0uJ1b4O92
E8uJ1u1IXq2u7BvQ9xawU5Qkkca/jc0DXdfFQoVDLP89VhWmmzqXzbtyj6L6jLoT
uiPmXVhjruOy2p9qehYYH0+F+FqfAifTDY+tlheBkekVDk2P1iwR3vjf52EnT1YY
siCr3w79lrS0b2bsQrbprQv2P773aVUUlrEU7xyt7soLYcvJOQoloPFJHdu3MSyK
UT188Es7VdpFNJbwxovmgul/lri/53QwqZ/3OD5Om1Tp2PEekI7xXjMXvlKsCxMg
i+/IgxsfPzl3Aph2k1gBh/be6/RvOvVV7gBaziLQ8HMktB83Bts=
=d2eX
-END PGP SIGNATURE-



Re: 18/36: services: hurd: Add dummy loopback.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

> guix-comm...@gnu.org skribis:
>
>> +(define (hurd-loopback-shepherd-service _)
>> +  "Return the 'loopback' Shepherd service."
>> +
>> +  (list (shepherd-service
>> + (documentation "Dummy for bootstrapping (gnu services) on the 
>> Hurd.")
>> + (provision '(loopback))
>> + (requirement '())
>> + (start #~(const #t))
>> + (stop #~(const #t))
>> + (respawn? #f
>> +
>> +(define hurd-loopback-service-type
>> +  (service-type
>> +   (name 'loopback)
>> +   (extensions (list (service-extension shepherd-root-service-type
>> +hurd-loopback-shepherd-service)))
>> +   (compose concatenate)
>> +   (extend first-of-two)
>> +   (default-value '(loopback)) ;canary for hurd-service->shepherd-service
>> +   (description "Dummy service to bootstrap (gnu services) on the
>> +Hurd.")))
>
> I believe the code currently used in ‘static-networking-service’ to
> setup the loopback device on GNU/Linux should also work on GNU/Hurd: it
> uses the “traditional” ioctls provided by (guix build syscalls).
>
> So hopefully we don’t need a Hurd-specific variant.

Ah, great!  I rewrote this to use ...and it almost
works already.  I have added

(service static-networking-service-type
 (list (static-networking (interface "lo")
  (ip "127.0.0.1")
  (requirement '())
  (provision '(loopback)

and the VM builds, only it doesn't start

herd: exeception caught while executing 'start' on service 'loopback':
Value out of range 0 to 4294967295: -1

I have added new code for this as a squash! commit, that I then also
revert for now, until it works. :-(

Greetings,
janneke

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: 13/36: services: Add hurd-console-service-type.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

> guix-comm...@gnu.org skribis:
>
>> commit d7a217e67dcd3b14402d746f4428db8545ce83f2
>> Author: Jan (janneke) Nieuwenhuizen 
>> AuthorDate: Mon Apr 13 10:13:05 2020 +0200
>>
>> services: Add hurd-console-service-type.
>> 
>> * gnu/services/hurd.scm (): New variable.
>> (hurd-console-shepherd-service, hurd-console-service-type): New function.
>> (hurd-service->shepherd-service): Add entry.
>
> Now for the exciting stuff, neat!

\o/

>> -  #:export (hurd-service->shepherd-service))
>> +  #:export (hurd-console-service-type
>> +hurd-service->shepherd-service))
>>  
>>  ;;; Commentary:
>>  ;;;
>> @@ -38,9 +39,51 @@
>>  (define (hurd-service->shepherd-service service)
>>(let ((config (service-value service)))
>>  (match config
>> +  (($ ) (hurd-console-shepherd-service 
>> config))
>>(_ '()
>
> Hmm do we really need this ‘hurd-service->shepherd-service’ procedure?
> I haven’t read the rest, but it seems surprising at first sight.

We certainly don't need it.  The patch/hunk above is being cut very
unfortunately; it loses the one interesting comment just one line
earlier, which was introduced by the privous (mosttly empty) commit:

+;; XXX Gradually bootstrap (gnu services) framework.
+(define (hurd-service->shepherd-service service)

The "XXX" comment is my attempt at implicitly communicating a question
that I had trouble formulating, two weeks ago.  The code that I could
not imagine how to write now looks something like this:

  (define shepherd.conf
(with-parameters ((%current-target-system "i586-pc-gnu"))
  (shepherd-configuration-file
   (append-map list
   (service-value
   (fold-services (operating-system-services os)
  #:target-type
  shepherd-root-service-type))

...but this does not work.  The problem here is that I currestly faked
"file-systems", "syslogd", "user-processes".  Those are needed to "get
past" the missing dependency checks for "openssh" and "guix-daemon".  I
have no idea how to write those yet, so would like to postpone them for
a bit.

However

  (define shepherd.conf
(with-parameters ((%current-target-system "i586-pc-gnu"))
  (shepherd-configuration-file
   (filter
(lambda (value)
  ;; XXX Remove file-systems, loopback, syslogd, user-processes
  ;; those are fake/don't work yet on the Hurd
  (pk "prov" (memq (car (shepherd-service-provision value))
   '(console guix-daemon ssh-daemon ttys
 user-processes
(service-value
 (fold-services (operating-system-services os)
#:target-type
shepherd-root-service-type))

this also does not work, because again, I get

guix build: error: service 'user-processes' requires 'user-homes', which is 
not provided by any service

So...I just can't manage to bootstrap shepherd services into
"system/hurd.scm cross-hurd-image" without this intermediate
hurd-service->shepherd-service procedure.  Once we have working
implementations for all these services, hurd-service->shepherd-service
has become obsolete.

Now this

guix system build --target=i586-pc-gnu gnu/system/examples/bare-hurd.tmpl

has some cross-build problems, though.  Yesterday I finally managed to
pin-point the problem.  It lives between
expression->derivation-in-linux-vm

(define* (expression->derivation-in-linux-vm name exp
 #:key
 (system (%current-system)) target
 (linux linux-libre)
...

that is called by qemu-image.  So I have been playing with this hack

(define* (qemu-image #:key
 (name "qemu-image")
 (system (%current-system))
-(target (%current-target-system))
+(target (if (hurd-target?) #f (%current-target-system)))

Because when qemu-image has "target" set, then 
expression->derivation-in-linux-vm
will attempt to create a QEMU vm for that target and start in in
QEMU...but it needs a LINUX for that target and starts to cross-build
linux for i586-pc-gnu.  That build fails.

In our "guix build -f gnu/system/hurd.scm" setup ("hack"?) we call
qemu-image with target #f, build and run a VM-image using x86_64-linux
and manually cross-compile all packages that go inside.

I'll be trying to rewrite these services harder and use more of the
regular "guix system" way of handling services to plug that into
gnu/system/hurd.scm.

Meanwhile there is the vm-image question: can we somehow use
expression->derivation-in-linux-vm when running "guix system
... --target=i586-pc-gnu"?  Or do we want to create a
expression->derivation-in-hurd-vm?  Or do we leap onto the "explosive
mixture of wip-disk-image and wip-hurd-vm?  Once any of 

Re: 20/36: system: hurd: Add the Shepherd.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

Hi Ludo'!

>> commit bb17242a511014e1691d494b17152865db0580e0
>> Author: Jan (janneke) Nieuwenhuizen 
>> AuthorDate: Tue Apr 7 08:03:03 2020 +0200
>>
>> system: hurd: Add the Shepherd.

>> +  (define shepherd.conf
>> +(with-parameters ((%current-target-system "i586-pc-gnu"))
>> +  (shepherd-configuration-file (hurd-shepherd-services %hurd-os
>
> This looks like an intermediate before fully using the service/OS
> framework

TL;DR: Thanks a lot for your review and questions!  I will be using this
to rewrite the Shepherd/services introduction in a proper way, until
it can be merged.

> , but I wonder how much it helps.

Yes, that's exactly it!  This intermediate, is curerently the only way I
found that can produce a fully functional VM-image; i.e., one that
starts guix-daemon and openssh.  So it helps by being an intermediate.

> The way I see it, now that you’ve defined services for Hurd-specific
> things like the console client, you could very much write:
>
>   (operating-system
> ;; …
> (kernel gnumach)
> (hurd hurd)  ;<- we probably need this new field

(oh...prolly better than the (if hurd-target?) I've been sprinkling and
implicit adding of gnumach.  I'll have a go at this.

> (essential-services (hurd-essential-services this-operating-system))
> (services %base-hurd-services))
>
> (Eventually we can even arrange for ‘essential-services’ and ‘services’
> to pick the right default as a function of the chosen kernel.)
>
> and then do:
>
>   guix system build --target=i586-pc-gnu the-config-above.scm

> Assuming system cross-compilation works as advertised :-), it should
> cross-compile the whole system.

Yeah...is seems that the marketing department may have sold us something
that has yet to be delivered.  Either that, or I failed to read some
bits of the instruction manual ;-)

To get something to run, we need (near the top of wip-hurd-vm)

6302837257 HACK Don't fail on running host's localedef.
443e1b2176 gnu: hurd: Cross-build hack: Set target i586-pc-gnu if unset.
87b50146ee gnu: glibc/hurd-headers: Cross-build fix for the Hurd.

So, on a well-chosen version of wip-hurd-vm (for example: wip-hurd-vm24
on my gitlab), I can now finally run this

./pre-inst-env guix system build --target=i586-pc-gnu 
gnu/system/examples/bare-hurd.tmpl

...but (most of) the OS is not cross-compiled; /bin/bash is the
build host's bash.  Some things, like Grub, Gnumach, the Hurd are cross
compiled, so ...

> At that stage, you don’t need ‘cross-hurd-image’ any longer and you can
> instead run:
>
>   guix system vm-image --target=i586-pc-gnu the-config-above.scm
>
> to achieve the same result.

... indeed, running:

./pre-inst-env guix system vm-image --target=i586-pc-gnu 
gnu/system/examples/bare-hurd.tmpl

creates a bootable VM-image that drops into a bash-minimal shell,
because /bin/bash cannot be executed.

> But!  There’s one missing bit: a Hurdish grub.cfg.  I think that can be
> hacked in (gnu bootloader grub), by inheriting from ‘grub-bootloader’
> and providing a custom ‘configuration-file-generator’ field and maybe
> ‘installer’ as well.

I think I have that covered here

d6ec2c2543 * system: hurd: Add hurd-grub-configuration-file.
a9a6b716d9 * system: hurd: Add hurd-grub-minimal-bootloader.

possibly depending on these

4fd4296325 * system: Add hurd-operating-system-directory-base-entries.
f4f872a440 * services: hurd: Move hurd-default-essential-services.
5f7c73d83a * services: Add hurd-file-systems-service-type.
d7cd2f122d * services: hurd: Move hurd-etc-sevcices.

> Thus, (gnu system hurd) would be left with nothing but the definitions
> of ‘%base-services/hurd’, ‘%base-packages/hurd’, and so on.
> ‘hurd-essential-services’ could maybe go to (gnu services hurd).

Yes!

> But I wonder if I’m missing something, WDYT?

You're right...and this is what I am trying to work towards.  The reason
for me to introduce these intermediate steps is that they enable to run
intermediate tests.

Currently, "guix build -f gnu/system/hurd.scm" is the only way I have
that produces a functional VM.  We are pretty close t creating such a
thing with "guix system ...", but to do so we need a cross build that
works and a shepherd config generated...and that all needs to come
together.  So instead of attempting a giant leap, I'm trying to throw
some intermediate stepping stones in the pond :-)

We don't need to merge, or keep this history; but I don't see how to
walk this path without going round these extra curves; let alone getting
feedback or asking questions.  So I can imagine that these commits keep
being rewritten/removed on wip-hurd-vm until everything works.

> Thanks for the exciting developments again!  :-)

Thanks for your insights, we're getting there...  I have some more
specific, related questions/puzzles in response to your other mail about
services.

Greetings,
janneke

-- 
Jan Nieuwenhuizen  | GNU LilyPond 

Re: 02/36: gnu: guix: Use gnutls-3.6.13 when cross-compiling.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

Hello Ludo'!

> Time for random review comments on ‘wip-hurd-vm’.  :-)

\o/

> guix-comm...@gnu.org skribis:
>
>> commit af9b4d0ba3d55ef89e956f408853548451243e95
>> Author: Jan (janneke) Nieuwenhuizen 
>> AuthorDate: Fri Apr 10 09:54:02 2020 +0200
>>
>> gnu: guix: Use gnutls-3.6.13 when cross-compiling.
>> 
>> * gnu/packages/package-management.scm (guix)[propagated-inputs]: When
>> cross-compiling, use patched gnutls-3.6.13.
>
> [...]
>
>>(propagated-inputs
>> -   `(("gnutls" ,guile3.0-gnutls)
>> +   `(("gnutls" ,(if (%current-target-system)
>> +(@@ (gnu packages tls) gnutls-3.6.13)
>
> Please avoid @@ by making ‘gnutls-3.6.13’ public

Oh..."gnutls-3.6.13" is already public; I simply removed (@@ ..)

Hmm, I don't know how this happened...I either didn't look well before,
maybe I was using then non-exported "gnutls", changed to gnutls-3.6.13
and kept the @@), or possibly it got exported later.  I'll try to
remember to avoid @@ in such cases.

> (and making the package > itself hidden if necessary).

> Otherwise LGTM!

Great, pushed.

> Forgive brevity, sent from my Emacs under lockdown.
> :-)

*lol*

Reading in my GNU Emacs under lockdown, thanks for your brevity.

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: branch wip-hurd-vm created (now fdb35e3)

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

>>  new 330f3ab  gnu: guix: Cross-build fixup for wrap-program.
>>  new af9b4d0  gnu: guix: Use gnutls-3.6.13 when cross-compiling.

removed (@@ ...)

>>  new de41617  gnu: guix: Apply courage for the Hurd.
>>  new 309963e  gnu: guix: Update to de41617661.

re-created

>>  new ddb44df  vm: Make the device node procedure a parameter.

dropped

>>  new f3b1d64  gnu: hurd: Fix references to /bin/w.
>>  new 695e2b4  gnu: hurd: Use default Qemu guest ip: 10.0.2.15.

added comments

>>  new 2f5d2dc  gnu: hurd: Add NFS support.
>>  new 29ea4dc  gnu: Add libtirpc/hurd.
>>  new d01f38a  system: hurd: Add less, which to %base-packages/hurd.
>>  new df00a4a  system: hurd: Add /etc/group.

added

> With the feedback I gave, these 11 patches can go to ‘core-updates’
> IMO!

Great!  All pushed to core-updates.  Lovely progress by 4 committers:
Rene, Ricardo, Efraim, Janneke!

...No commits by Ludovic this round! (the silence before the storm?)...
and of course I'm joking here, thanks a lot for this review party
Ludovic!

Greetings,
janneke

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: 09/36: gnu: Add libtirpc/hurd.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

> guix-comm...@gnu.org skribis:
>
>> commit 29ea4dc2c1df0d4562f1add01501726a3f963b91
>> Author: Ricardo Wurmus 
>> AuthorDate: Sun Apr 12 23:04:49 2020 +0200
>>
>> gnu: Add libtirpc/hurd.
>> 
>> * gnu/packages/onc-rpc.scm (libtirpc/hurd): New variable.
>> * gnu/packages/patches/libtirpc-hurd-client.patch,
>> gnu/packages/patches/libtirpc-hurd.patch: New files.
>> * gnu/local.mk (dist_patch_DATA): Add them.
>
> LGTM!

Pushed to core-updates; thanks Ricardo!

> On the next ‘staging’ cycle, we should merge the two libtirpc’s.

I'll try to help remember; can we add helpful comment somewhere?

Greetings,
janneke

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: 08/36: gnu: hurd: Add NFS support.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

> guix-comm...@gnu.org skribis:
>
>> commit 2f5d2dc8240c22ea109c52c8ca957be9b155ff36
>> Author: Ricardo Wurmus 
>> AuthorDate: Sun Apr 12 23:06:30 2020 +0200
>>
>> gnu: hurd: Add NFS support.
>> 
>> * gnu/packages/hurd.scm (hurd)[inputs]: Add libtirpc/hurd.
>> [arguments]: Add configure flags to use libtirpc; add phase "find-tirpc" 
>> to
>> find the RPC headers; add phase "fix-rpc-headers" to include missing 
>> headers.
>
> LGTM!

Pushed to core-updates; thanks Ricardo!

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: 07/36: gnu: hurd: Use default Qemu guest ip: 10.0.2.15.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

>> but using this default allows us to use the widely advertised
>> 
>> -device rtl8139,netdev=net0 -netdev 
>> user,id=net0,hostfwd=tcp:127.0.0.1:2228-:22
>
> Oh!
>
>> * gnu/packages/hurd.scm (hurd-rc-script): Use 10.0.2.15.
>   ^
> You can also mention [hurd-directives] here.

Eh, this is in the RC script; I have changed it to

* gnu/packages/hurd.scm (hurd-rc-script): Used by (hurd)[inputs]: Use
10.0.2.15; the default QEMU guest IP.

>> -"--address" "10.0.2.77"
>> +"--address" "10.0.2.15"
>
> Perhaps add a margin comment saying this is the default QEMU guest IP.

Good idea; done.

> LGTM!

Thanks, pushed to core-updates with these changes.

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: 05/36: vm: Make the device node procedure a parameter.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

>> vm: Make the device node procedure a parameter.
>>#:bootcfg-drv grub.cfg
>>#:bootloader grub-bootloader
>>#:register-closures? #f
>> +  #:device-nodes 'hurd
>>#:extra-directives hurd-directives))
>
> On ‘core-updates’, there’s already #:device-nodes 'hurd, though not on
> the same line.
>
> I think we can drop this patch, no?

Oops, sure; dropped.

We may even want to move this (and "friends") into the qemu-image
declaration itself; in a much later patch on wip-hurd-vm I have

 (define* qemu-image #:key
[...]
- (file-system-type "ext4")
- (file-system-options '())
- (device-nodes 'linux)
+ (file-system-type (if (hurd-target?) "ext2" "ext4"))
+ (file-system-options
+  (if (hurd-target?) '("-o" "hurd") '()))
+ (device-nodes (if (hurd-target?) 'hurd 'linux))

Having linux-specific defaults in a generic function is kind of awkward;
we would need to change all callers, or ...

Well, that's for later to be sure!

Greetings,
janeke

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: 06/36: gnu: hurd: Fix references to /bin/w.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

>> commit f3b1d64cecdd964699a4e22a2b4b5b7fc53c
>> Author: Rene Saavedra 
>> AuthorDate: Sun Apr 12 22:33:08 2020 -0500
>>
>> gnu: hurd: Fix references to /bin/w.
>> 
>> * gnu/packages/hurd.scm (hurd): Use '/bin/w' from hurd package.
>
> OK!

Thanks; Pushed to core-updates.
janneke

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com