Re: [PR] MINOR: doc: Remove -Ds option in man page

2019-06-13 Thread William Lallemand
On Thu, Jun 13, 2019 at 09:23:04AM +, PR Bot wrote:
> Description:
>`-Ds` option should be removed from man page. It is no longer
>supported as this commit shows: https://github.com/haproxy/haproxy/com
>mit/095ba4c2428ec8bcccb134b3d24f07de2aabbdcd
>
>I noticed that
>the option has already gone when upgrading my haproxy from 1.7 to
>2.0-dev7. I have had the old and new haproxy running as a pod on my
>Kubernetes cluster, therefore, it is important for me to know what
>option is provided to keep the process in the foreground.
>After upgrading, I was able to make my haproxy running successfully by
>removing `-Ds` option and `daemon` global parameter in the config.
>Thank you.
> 

Good catch.

However this option was never meant to be used this way, it was supposed to be
used with the systemd wrapper binary, that's why it was removed when the
systemd wrapper was replaced by the master worker mode.

Depending on your usage, you probably want to use the master worker mode (-W),
which will allow multi-process mode in foreground.

Patch applied, thanks.

-- 
William Lallemand



[PR] MINOR: doc: Remove -Ds option in man page

2019-06-13 Thread PR Bot
Dear list!

Author: Kazuo Yagi 
Number of patches: 1

This is an automated relay of the Github pull request:
   MINOR: doc: Remove -Ds option in man page

Patch title(s): 
   MINOR: doc: Remove -Ds option in man page

Link:
   https://github.com/haproxy/haproxy/pull/120

Edit locally:
   wget https://github.com/haproxy/haproxy/pull/120.patch && vi 120.patch

Apply locally:
   curl https://github.com/haproxy/haproxy/pull/120.patch | git am -

Description:
   `-Ds` option should be removed from man page. It is no longer
   supported as this commit shows: https://github.com/haproxy/haproxy/com
   mit/095ba4c2428ec8bcccb134b3d24f07de2aabbdcd
   
   I noticed that
   the option has already gone when upgrading my haproxy from 1.7 to
   2.0-dev7. I have had the old and new haproxy running as a pod on my
   Kubernetes cluster, therefore, it is important for me to know what
   option is provided to keep the process in the foreground.
   After upgrading, I was able to make my haproxy running successfully by
   removing `-Ds` option and `daemon` global parameter in the config.
   Thank you.

Instructions:
   This github pull request will be closed automatically; patch should be
   reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is
   invited to comment, even the patch's author. Please keep the author and
   list CCed in replies. Please note that in absence of any response this
   pull request will be lost.