[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323842#comment-14323842 ] Hudson commented on HDFS-4265: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #97 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/97/]) HDFS-4265. BKJM doesn't take advantage of speculative reads. Contributed by Rakesh R. (aajisaka: rev 0d521e33262193e6cf709deaa69a54811a97ef6a) * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperSpeculativeRead.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Fix For: 2.7.0 Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321351#comment-14321351 ] Hudson commented on HDFS-4265: -- FAILURE: Integrated in Hadoop-Yarn-trunk #838 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/838/]) HDFS-4265. BKJM doesn't take advantage of speculative reads. Contributed by Rakesh R. (aajisaka: rev 0d521e33262193e6cf709deaa69a54811a97ef6a) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperSpeculativeRead.java * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Fix For: 2.7.0 Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321340#comment-14321340 ] Hudson commented on HDFS-4265: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #104 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/104/]) HDFS-4265. BKJM doesn't take advantage of speculative reads. Contributed by Rakesh R. (aajisaka: rev 0d521e33262193e6cf709deaa69a54811a97ef6a) * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperSpeculativeRead.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Fix For: 2.7.0 Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321505#comment-14321505 ] Hudson commented on HDFS-4265: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2055 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2055/]) HDFS-4265. BKJM doesn't take advantage of speculative reads. Contributed by Rakesh R. (aajisaka: rev 0d521e33262193e6cf709deaa69a54811a97ef6a) * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperSpeculativeRead.java * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Fix For: 2.7.0 Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321436#comment-14321436 ] Hudson commented on HDFS-4265: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2036 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2036/]) HDFS-4265. BKJM doesn't take advantage of speculative reads. Contributed by Rakesh R. (aajisaka: rev 0d521e33262193e6cf709deaa69a54811a97ef6a) * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperSpeculativeRead.java BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Fix For: 2.7.0 Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321481#comment-14321481 ] Hudson commented on HDFS-4265: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #105 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/105/]) HDFS-4265. BKJM doesn't take advantage of speculative reads. Contributed by Rakesh R. (aajisaka: rev 0d521e33262193e6cf709deaa69a54811a97ef6a) * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperSpeculativeRead.java * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Fix For: 2.7.0 Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320943#comment-14320943 ] Akira AJISAKA commented on HDFS-4265: - +1, committing this. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320976#comment-14320976 ] Hudson commented on HDFS-4265: -- FAILURE: Integrated in Hadoop-trunk-Commit #7110 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7110/]) HDFS-4265. BKJM doesn't take advantage of speculative reads. Contributed by Rakesh R. (aajisaka: rev 0d521e33262193e6cf709deaa69a54811a97ef6a) * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperSpeculativeRead.java * hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Fix For: 2.7.0 Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320971#comment-14320971 ] Akira AJISAKA commented on HDFS-4265: - and thanks [~ikelly] for help. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Fix For: 2.7.0 Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317563#comment-14317563 ] Rakesh R commented on HDFS-4265: Thanks a lot [~umamaheswararao], [~ajisakaa], [~ikelly] for the help. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317541#comment-14317541 ] Uma Maheswara Rao G commented on HDFS-4265: --- +1 for the patch. Thanks Rakesh. I will push this in later today. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310695#comment-14310695 ] Uma Maheswara Rao G commented on HDFS-4265: --- Thanks Rakesh!, Sorry, I could not look at this for your last request. Let me have a look now. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310571#comment-14310571 ] Rakesh R commented on HDFS-4265: Thanks [~ajisakaa] for the comments. Attached latest patch addressing the same. Kindly review! BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310585#comment-14310585 ] Rakesh R commented on HDFS-4265: Could someone help me to push this in. Thanks! BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310554#comment-14310554
]
Akira AJISAKA commented on HDFS-4265:
-
Here are some trivial comments:
* Some inserted lines are over 80 characters.
* There is a trailing whitespace.
{code}
+ * Sleep a bookie until I count down the latch
+ *
+ * @param latch
{code}
* Would you please remove the initial capacity of the list? It's a little
confusing.
{code}
+ private static ListBookieServer bks = new ArrayListBookieServer(4);
{code}
I'm +1 after these are addressed.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch,
0007-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch,
003-HDFS-4265.patch, 004-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310581#comment-14310581
]
Hadoop QA commented on HDFS-4265:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12697229/0009-HDFS-4265.patch
against trunk revision cfb829e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9487//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9487//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch,
0007-HDFS-4265.patch, 0009-HDFS-4265.patch, 001-HDFS-4265.patch,
002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14300178#comment-14300178 ] Rakesh R commented on HDFS-4265: Release audit warnings is unrelated. [~umamaheswararao] it seems there are few pending sub-tasks. Could you please push these in. Thanks! BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299746#comment-14299746
]
Hadoop QA commented on HDFS-4265:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12695744/0007-HDFS-4265.patch
against trunk revision 26c2de3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9391//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9391//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9391//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch,
0007-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch,
003-HDFS-4265.patch, 004-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298945#comment-14298945
]
Hadoop QA commented on HDFS-4265:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12695560/0006-HDFS-4265.patch
against trunk revision f2c9109.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9381//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9381//artifact/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9381//artifact/patchprocess/newPatchFindbugsWarningsbkjournal.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9381//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch,
001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch,
004-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297298#comment-14297298 ] Rakesh R commented on HDFS-4265: I've rebased the fix on trunk and attached new patch. There is no extra changes compare to the previous patch. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 0005-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297368#comment-14297368
]
Hadoop QA commented on HDFS-4265:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12695322/0005-HDFS-4265.patch
against trunk revision 342efa1.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9374//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9374//artifact/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9374//artifact/patchprocess/newPatchFindbugsWarningsbkjournal.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9374//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 0005-HDFS-4265.patch, 001-HDFS-4265.patch,
002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074250#comment-14074250 ] Rakesh R commented on HDFS-4265: Hi [~umamaheswararao] Could you please have a look at this when you get sometime. Thanks! HDFS-4265 HDFS-4266 are dependent patches. After committing the first one, second issue need to be rebased. I’ll update the second patch after seeing the first issue in. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064971#comment-14064971 ] Rakesh R commented on HDFS-4265: Thanks [~ikelly]. I have exposed 'readEntryTimeoutSec' configuration in BKJM inorder to set to a high value in BookKeeper client. By default its configured as 5 seconds which is same as BookKeeper's 'readEntryTimeoutSec' default value. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064972#comment-14064972 ] Ivan Kelly commented on HDFS-4265: -- lgtm +1 BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065000#comment-14065000
]
Hadoop QA commented on HDFS-4265:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12656277/004-HDFS-4265.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7372//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7372//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch,
003-HDFS-4265.patch, 004-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057646#comment-14057646 ] Ivan Kelly commented on HDFS-4265: -- I think the constant names need MS also, BKJM_BOOKKEEPER_SPECULATIVE_READ_TIMEOUT - BKJM_BOOKKEEPER_SPECULATIVE_READ_TIMEOUT_MS Where you set it in the code of the test, the unit is unclear, so it's better to be explicit in the constant. In the test, how does it verify that speculative reads are taking place? I think for this, you should set the bookkeeper client request timeout to 10 days or something. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056290#comment-14056290
]
Hadoop QA commented on HDFS-4265:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12654804/003-HDFS-4265.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7302//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch,
003-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056454#comment-14056454 ] Rakesh R commented on HDFS-4265: Attached new patch addressing [~ikelly]'s comments. Please review the patch. Thanks! It looks like jenkins report is not proper. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053820#comment-14053820 ] Ivan Kelly commented on HDFS-4265: -- Change looks good, but you should add units to the conf key. dfs.namenode.bookkeeperjournal.speculativeReadTimeout - dfs.namenode.bookkeeperjournal.speculativeReadTimeoutMs BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047522#comment-14047522
]
Hadoop QA commented on HDFS-4265:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12609843/002-HDFS-4265.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal:
org.apache.hadoop.contrib.bkjournal.TestBookKeeperEditLogStreams
org.apache.hadoop.contrib.bkjournal.TestBookKeeperJournalManager
org.apache.hadoop.contrib.bkjournal.TestBookKeeperAsHASharedDir
org.apache.hadoop.contrib.bkjournal.TestBookKeeperHACheckpoints
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7248//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7248//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802638#comment-13802638 ] Uma Maheswara Rao G commented on HDFS-4265: --- I will do this patch, but do you mind checking jenkins report? Once Jenkins report +1 I will push based on Ivan's +1. Sorry for taking long time in looking this patch. Thanks Rakesh for reminding me. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802829#comment-13802829
]
Hadoop QA commented on HDFS-4265:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12609843/002-HDFS-4265.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal:
org.apache.hadoop.contrib.bkjournal.TestBookKeeperEditLogStreams
org.apache.hadoop.contrib.bkjournal.TestBookKeeperAsHASharedDir
org.apache.hadoop.contrib.bkjournal.TestBookKeeperHACheckpoints
org.apache.hadoop.contrib.bkjournal.TestBookKeeperJournalManager
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5262//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/5262//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5262//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802615#comment-13802615 ] Rakesh R commented on HDFS-4265: Hi [~umamaheswararao], Could you please push this in after seeing the jenkins report. I've submitted it now. Thanks BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Affects Versions: 2.2.0 Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802616#comment-13802616
]
Hadoop QA commented on HDFS-4265:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12591958/001-HDFS-4265.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5259//console
This message is automatically generated.
BKJM doesn't take advantage of speculative reads
Key: HDFS-4265
URL: https://issues.apache.org/jira/browse/HDFS-4265
Project: Hadoop HDFS
Issue Type: Sub-task
Components: ha
Affects Versions: 2.2.0
Reporter: Ivan Kelly
Assignee: Rakesh R
Attachments: 001-HDFS-4265.patch
BookKeeperEditLogInputStream reads entry at a time, so it doesn't take
advantage of the speculative read mechanism introduced by BOOKKEEPER-336.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads
[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713827#comment-13713827 ] Ivan Kelly commented on HDFS-4265: -- +1 for the patch. BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type: Sub-task Components: ha Reporter: Ivan Kelly Assignee: Rakesh R Attachments: 001-HDFS-4265.patch BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
