[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=229954=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229954 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 18/Apr/19 23:53 Start Date: 18/Apr/19 23:53 Worklog Time Spent: 10m Work Description: xiaoyuyao commented on pull request #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 229954) Time Spent: 3h (was: 2h 50m) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=229952=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229952 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 18/Apr/19 23:50 Start Date: 18/Apr/19 23:50 Worklog Time Spent: 10m Work Description: xiaoyuyao commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-484725595 +1, I will merge/commit the patch shortly. I manually retested the failed tests and they don't repro on my box. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 229952) Time Spent: 2h 50m (was: 2h 40m) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 2h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=228776=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-228776 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 17/Apr/19 01:45 Start Date: 17/Apr/19 01:45 Worklog Time Spent: 10m Work Description: cjjnjust commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-483905287 @xiaoyuyao , I checked failed tests, it looks like not related to PR, it seems all errors are caused by `java.lang.RuntimeException: Fail to load schema file:/testptch/hadoop/hadoop-hdds/common/target/test-classes/networkTopologyTestFiles/good.xml, error:null`. while I didn't remove it in this pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 228776) Time Spent: 2h 40m (was: 2.5h) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 2h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=228699=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-228699 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 16/Apr/19 21:08 Start Date: 16/Apr/19 21:08 Worklog Time Spent: 10m Work Description: xiaoyuyao commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-483844270 Thanks @cjjnjust for the update. Some of the unit test failures seem related, can you check/fix them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 228699) Time Spent: 2.5h (was: 2h 20m) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=223055=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223055 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 04/Apr/19 15:47 Start Date: 04/Apr/19 15:47 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-479953422 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 25 | Docker mode activated. | ||| _ Prechecks _ | | 0 | yamllint | 0 | yamllint was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 5 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 989 | trunk passed | | +1 | compile | 69 | trunk passed | | +1 | checkstyle | 27 | trunk passed | | +1 | mvnsite | 75 | trunk passed | | +1 | shadedclient | 749 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 122 | trunk passed | | +1 | javadoc | 61 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 75 | the patch passed | | +1 | compile | 74 | the patch passed | | +1 | javac | 74 | the patch passed | | +1 | checkstyle | 23 | the patch passed | | +1 | mvnsite | 65 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 3 | The patch has no ill-formed XML file. | | +1 | shadedclient | 732 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 132 | the patch passed | | +1 | javadoc | 57 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 65 | common in the patch failed. | | -1 | unit | 72 | container-service in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 3501 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.net.TestNetworkTopologyImpl | | | hadoop.hdds.scm.net.TestNodeSchemaManager | | | hadoop.ozone.container.common.TestDatanodeStateMachine | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-661/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/661 | | JIRA Issue | HDDS-976 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle yamllint | | uname | Linux 730a4c61891b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 993f36e | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/8/artifact/out/patch-unit-hadoop-hdds_common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/8/artifact/out/patch-unit-hadoop-hdds_container-service.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/8/testReport/ | | Max. process+thread count | 446 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/8/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223055) Time Spent: 2h 20m (was: 2h 10m) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available >
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222973=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222973 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 04/Apr/19 13:20 Start Date: 04/Apr/19 13:20 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-479893771 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 26 | Docker mode activated. | ||| _ Prechecks _ | | 0 | yamllint | 0 | yamllint was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 5 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 1041 | trunk passed | | +1 | compile | 71 | trunk passed | | +1 | checkstyle | 29 | trunk passed | | -1 | mvnsite | 28 | container-service in trunk failed. | | +1 | shadedclient | 727 | branch has no errors when building and testing our client artifacts. | | -1 | findbugs | 24 | container-service in trunk failed. | | +1 | javadoc | 63 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 10 | Maven dependency ordering for patch | | -1 | mvninstall | 35 | container-service in the patch failed. | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | -0 | checkstyle | 24 | hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | mvnsite | 63 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 3 | The patch has no ill-formed XML file. | | +1 | shadedclient | 728 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 131 | the patch passed | | +1 | javadoc | 58 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 63 | common in the patch failed. | | -1 | unit | 70 | container-service in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 3484 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.net.TestNodeSchemaManager | | | hadoop.hdds.scm.net.TestNetworkTopologyImpl | | | hadoop.ozone.container.common.TestDatanodeStateMachine | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/661 | | JIRA Issue | HDDS-976 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle yamllint | | uname | Linux 4654c6113c21 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / d2637cb | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/artifact/out/branch-mvnsite-hadoop-hdds_container-service.txt | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/artifact/out/branch-findbugs-hadoop-hdds_container-service.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/artifact/out/patch-mvninstall-hadoop-hdds_container-service.txt | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/artifact/out/diff-checkstyle-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/artifact/out/patch-unit-hadoop-hdds_common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/artifact/out/patch-unit-hadoop-hdds_container-service.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/testReport/ | | Max. process+thread count | 453 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/6/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222961=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222961 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 04/Apr/19 12:53 Start Date: 04/Apr/19 12:53 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-479884572 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 27 | Docker mode activated. | ||| _ Prechecks _ | | 0 | yamllint | 0 | yamllint was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 5 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 24 | Maven dependency ordering for branch | | +1 | mvninstall | 1031 | trunk passed | | +1 | compile | 76 | trunk passed | | +1 | checkstyle | 33 | trunk passed | | +1 | mvnsite | 76 | trunk passed | | +1 | shadedclient | 749 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 120 | trunk passed | | +1 | javadoc | 69 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | -1 | mvninstall | 21 | container-service in the patch failed. | | -1 | compile | 51 | hadoop-hdds in the patch failed. | | -1 | javac | 51 | hadoop-hdds in the patch failed. | | +1 | checkstyle | 22 | the patch passed | | -1 | mvnsite | 24 | container-service in the patch failed. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 2 | The patch has no ill-formed XML file. | | +1 | shadedclient | 774 | patch has no errors when building and testing our client artifacts. | | -1 | findbugs | 23 | container-service in the patch failed. | | +1 | javadoc | 57 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 63 | common in the patch failed. | | -1 | unit | 24 | container-service in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 3500 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.net.TestNodeSchemaManager | | | hadoop.hdds.scm.net.TestNetworkTopologyImpl | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/661 | | JIRA Issue | HDDS-976 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle yamllint | | uname | Linux bf4f15e5091e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / d2637cb | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/artifact/out/patch-mvninstall-hadoop-hdds_container-service.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/artifact/out/patch-compile-hadoop-hdds.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/artifact/out/patch-compile-hadoop-hdds.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/artifact/out/patch-mvnsite-hadoop-hdds_container-service.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/artifact/out/patch-findbugs-hadoop-hdds_container-service.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/artifact/out/patch-unit-hadoop-hdds_common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/artifact/out/patch-unit-hadoop-hdds_container-service.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/testReport/ | | Max. process+thread count | 446 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/5/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222940=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222940 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 04/Apr/19 12:08 Start Date: 04/Apr/19 12:08 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-479870882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 27 | Docker mode activated. | ||| _ Prechecks _ | | 0 | yamllint | 0 | yamllint was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 5 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1141 | trunk passed | | +1 | compile | 50 | trunk passed | | +1 | checkstyle | 19 | trunk passed | | +1 | mvnsite | 40 | trunk passed | | +1 | shadedclient | 699 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 75 | trunk passed | | +1 | javadoc | 36 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 43 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | -0 | checkstyle | 14 | hadoop-hdds/common: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) | | +1 | mvnsite | 36 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedclient | 729 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 82 | the patch passed | | +1 | javadoc | 34 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 67 | common in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 3221 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.net.TestNodeSchemaManager | | | hadoop.hdds.scm.net.TestNetworkTopologyImpl | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-661/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/661 | | JIRA Issue | HDDS-976 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle yamllint | | uname | Linux 40077f97363b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / d2637cb | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/4/artifact/out/diff-checkstyle-hadoop-hdds_common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/4/artifact/out/patch-unit-hadoop-hdds_common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/4/testReport/ | | Max. process+thread count | 446 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common U: hadoop-hdds/common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/4/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 222940) Time Spent: 1h 50m (was: 1h 40m) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222931=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222931 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 04/Apr/19 11:23 Start Date: 04/Apr/19 11:23 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-479857939 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 28 | Docker mode activated. | ||| _ Prechecks _ | | 0 | yamllint | 0 | yamllint was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 5 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1096 | trunk passed | | +1 | compile | 37 | trunk passed | | +1 | checkstyle | 17 | trunk passed | | +1 | mvnsite | 37 | trunk passed | | +1 | shadedclient | 696 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 71 | trunk passed | | +1 | javadoc | 35 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 43 | the patch passed | | +1 | compile | 34 | the patch passed | | +1 | javac | 34 | the patch passed | | -0 | checkstyle | 14 | hadoop-hdds/common: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) | | +1 | mvnsite | 37 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedclient | 732 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 77 | the patch passed | | +1 | javadoc | 33 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 79 | common in the patch failed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 3169 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.net.TestNodeSchemaManager | | | hadoop.hdds.scm.net.TestNetworkTopologyImpl | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-661/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/661 | | JIRA Issue | HDDS-976 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle yamllint | | uname | Linux a3473c677382 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / a92806d | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/3/artifact/out/diff-checkstyle-hadoop-hdds_common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/3/artifact/out/patch-unit-hadoop-hdds_common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/3/testReport/ | | Max. process+thread count | 422 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common U: hadoop-hdds/common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/3/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 222931) Time Spent: 1h 40m (was: 1.5h) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222802=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222802 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 04/Apr/19 04:14 Start Date: 04/Apr/19 04:14 Worklog Time Spent: 10m Work Description: xiaoyuyao commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-479743474 Thanks @cjjnjust for working on this. Patch LGTM overall, just few minor issues commented inline. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 222802) Time Spent: 1.5h (was: 1h 20m) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[
https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222792=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222792
]
ASF GitHub Bot logged work on HDDS-976:
---
Author: ASF GitHub Bot
Created on: 04/Apr/19 04:01
Start Date: 04/Apr/19 04:01
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #661: HDDS-976:
Parse network topology from yaml file
URL: https://github.com/apache/hadoop/pull/661#discussion_r272010158
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeSchemaManager.java
##
@@ -59,13 +59,20 @@ public void init(Configuration conf) {
/**
* Load schemas from network topology schema configuration file
*/
+String schemaFileType = conf.get(
+ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE_TYPE);
+
String schemaFile = conf.get(
ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE,
ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE_DEFAULT);
NodeSchemaLoadResult result;
try {
- result = NodeSchemaLoader.getInstance().loadSchemaFromFile(schemaFile);
+ if (schemaFileType.compareTo("yaml") == 0) {
+result = NodeSchemaLoader.getInstance().loadSchemaFromYaml(schemaFile);
+ } else {
+result = NodeSchemaLoader.getInstance().loadSchemaFromFile(schemaFile);
Review comment:
Maybe change this to loadSchemaFromXml?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 222792)
Time Spent: 1h 20m (was: 1h 10m)
> Support YAML format network topology cluster definition
> ---
>
> Key: HDDS-976
> URL: https://issues.apache.org/jira/browse/HDDS-976
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Sammi Chen
>Assignee: Junjie Chen
>Priority: Major
> Labels: pull-request-available
> Attachments: NetworkTopologyDefault.yaml
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[
https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222791=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222791
]
ASF GitHub Bot logged work on HDDS-976:
---
Author: ASF GitHub Bot
Created on: 04/Apr/19 04:00
Start Date: 04/Apr/19 04:00
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #661: HDDS-976:
Parse network topology from yaml file
URL: https://github.com/apache/hadoop/pull/661#discussion_r272010041
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeSchemaManager.java
##
@@ -59,13 +59,20 @@ public void init(Configuration conf) {
/**
* Load schemas from network topology schema configuration file
*/
+String schemaFileType = conf.get(
+ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE_TYPE);
+
String schemaFile = conf.get(
ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE,
ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE_DEFAULT);
NodeSchemaLoadResult result;
try {
- result = NodeSchemaLoader.getInstance().loadSchemaFromFile(schemaFile);
+ if (schemaFileType.compareTo("yaml") == 0) {
Review comment:
Can we make the schema type string case insensitive?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 222791)
Time Spent: 1h 10m (was: 1h)
> Support YAML format network topology cluster definition
> ---
>
> Key: HDDS-976
> URL: https://issues.apache.org/jira/browse/HDDS-976
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Sammi Chen
>Assignee: Junjie Chen
>Priority: Major
> Labels: pull-request-available
> Attachments: NetworkTopologyDefault.yaml
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[
https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222787=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222787
]
ASF GitHub Bot logged work on HDDS-976:
---
Author: ASF GitHub Bot
Created on: 04/Apr/19 03:47
Start Date: 04/Apr/19 03:47
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #661: HDDS-976:
Parse network topology from yaml file
URL: https://github.com/apache/hadoop/pull/661#discussion_r272008319
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeSchemaLoader.java
##
@@ -165,6 +169,81 @@ private NodeSchemaLoadResult loadSchema(File schemaFile)
throws
return schemaList;
}
+ /**
+ * Load user defined network layer schemas from a YAML configuration file.
+ * @param schemaFilePath path of schema file
+ * @return all valid node schemas defined in schema file
+ */
+ public NodeSchemaLoadResult loadSchemaFromYaml(String schemaFilePath)
+ throws IllegalArgumentException {
+try {
+ File schemaFile = new File(schemaFilePath);
+ if (!schemaFile.exists()) {
+String msg = "Network topology layer schema file " + schemaFilePath +
+" is not found.";
+LOG.warn(msg);
+throw new IllegalArgumentException(msg);
+ }
+ return loadSchemaFromYaml(schemaFile);
+} catch (Exception e) {
+ throw new IllegalArgumentException("Fail to load network topology node"
+ + " schema file: " + schemaFilePath + " , error:" +
e.getMessage());
+}
+ }
+
+ /**
+ * Load network topology layer schemas from a YAML configuration file.
+ * @param schemaFile schema file
+ * @return all valid node schemas defined in schema file
+ * @throws ParserConfigurationException ParserConfigurationException happen
+ * @throws IOException no such schema file
+ * @throws SAXException xml file has some invalid elements
+ * @throws IllegalArgumentException xml file content is logically invalid
+ */
+ private NodeSchemaLoadResult loadSchemaFromYaml(File schemaFile) {
+LOG.info("Loading network topology layer schema file " + schemaFile);
+NodeSchemaLoadResult finalSchema;
+
+try {
+ FileInputStream fileInputStream = new FileInputStream(schemaFile);
Review comment:
Can we use try-with-resource to ensure the FileInputStream is closed
properly even Exception is thrown on line 210?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 222787)
Time Spent: 1h (was: 50m)
> Support YAML format network topology cluster definition
> ---
>
> Key: HDDS-976
> URL: https://issues.apache.org/jira/browse/HDDS-976
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Sammi Chen
>Assignee: Junjie Chen
>Priority: Major
> Labels: pull-request-available
> Attachments: NetworkTopologyDefault.yaml
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[
https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222786=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222786
]
ASF GitHub Bot logged work on HDDS-976:
---
Author: ASF GitHub Bot
Created on: 04/Apr/19 03:46
Start Date: 04/Apr/19 03:46
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #661: HDDS-976:
Parse network topology from yaml file
URL: https://github.com/apache/hadoop/pull/661#discussion_r272008319
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeSchemaLoader.java
##
@@ -165,6 +169,81 @@ private NodeSchemaLoadResult loadSchema(File schemaFile)
throws
return schemaList;
}
+ /**
+ * Load user defined network layer schemas from a YAML configuration file.
+ * @param schemaFilePath path of schema file
+ * @return all valid node schemas defined in schema file
+ */
+ public NodeSchemaLoadResult loadSchemaFromYaml(String schemaFilePath)
+ throws IllegalArgumentException {
+try {
+ File schemaFile = new File(schemaFilePath);
+ if (!schemaFile.exists()) {
+String msg = "Network topology layer schema file " + schemaFilePath +
+" is not found.";
+LOG.warn(msg);
+throw new IllegalArgumentException(msg);
+ }
+ return loadSchemaFromYaml(schemaFile);
+} catch (Exception e) {
+ throw new IllegalArgumentException("Fail to load network topology node"
+ + " schema file: " + schemaFilePath + " , error:" +
e.getMessage());
+}
+ }
+
+ /**
+ * Load network topology layer schemas from a YAML configuration file.
+ * @param schemaFile schema file
+ * @return all valid node schemas defined in schema file
+ * @throws ParserConfigurationException ParserConfigurationException happen
+ * @throws IOException no such schema file
+ * @throws SAXException xml file has some invalid elements
+ * @throws IllegalArgumentException xml file content is logically invalid
+ */
+ private NodeSchemaLoadResult loadSchemaFromYaml(File schemaFile) {
+LOG.info("Loading network topology layer schema file " + schemaFile);
+NodeSchemaLoadResult finalSchema;
+
+try {
+ FileInputStream fileInputStream = new FileInputStream(schemaFile);
Review comment:
Can we use try-with-resource to ensure the FileInputStream is closed
properly?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 222786)
Time Spent: 50m (was: 40m)
> Support YAML format network topology cluster definition
> ---
>
> Key: HDDS-976
> URL: https://issues.apache.org/jira/browse/HDDS-976
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Sammi Chen
>Assignee: Junjie Chen
>Priority: Major
> Labels: pull-request-available
> Attachments: NetworkTopologyDefault.yaml
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[
https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222785=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222785
]
ASF GitHub Bot logged work on HDDS-976:
---
Author: ASF GitHub Bot
Created on: 04/Apr/19 03:46
Start Date: 04/Apr/19 03:46
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #661: HDDS-976:
Parse network topology from yaml file
URL: https://github.com/apache/hadoop/pull/661#discussion_r272008223
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeSchemaLoader.java
##
@@ -165,6 +169,81 @@ private NodeSchemaLoadResult loadSchema(File schemaFile)
throws
return schemaList;
}
+ /**
+ * Load user defined network layer schemas from a YAML configuration file.
+ * @param schemaFilePath path of schema file
+ * @return all valid node schemas defined in schema file
+ */
+ public NodeSchemaLoadResult loadSchemaFromYaml(String schemaFilePath)
+ throws IllegalArgumentException {
+try {
+ File schemaFile = new File(schemaFilePath);
+ if (!schemaFile.exists()) {
+String msg = "Network topology layer schema file " + schemaFilePath +
+" is not found.";
+LOG.warn(msg);
+throw new IllegalArgumentException(msg);
+ }
+ return loadSchemaFromYaml(schemaFile);
+} catch (Exception e) {
+ throw new IllegalArgumentException("Fail to load network topology node"
+ + " schema file: " + schemaFilePath + " , error:" +
e.getMessage());
+}
+ }
+
+ /**
+ * Load network topology layer schemas from a YAML configuration file.
+ * @param schemaFile schema file
+ * @return all valid node schemas defined in schema file
+ * @throws ParserConfigurationException ParserConfigurationException happen
+ * @throws IOException no such schema file
+ * @throws SAXException xml file has some invalid elements
+ * @throws IllegalArgumentException xml file content is logically invalid
+ */
+ private NodeSchemaLoadResult loadSchemaFromYaml(File schemaFile) {
+LOG.info("Loading network topology layer schema file " + schemaFile);
Review comment:
NIT: can we use parameterized log4j like below
LOG.info("Loading network topology layer schema file {}", schemaFile);
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 222785)
Time Spent: 40m (was: 0.5h)
> Support YAML format network topology cluster definition
> ---
>
> Key: HDDS-976
> URL: https://issues.apache.org/jira/browse/HDDS-976
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Sammi Chen
>Assignee: Junjie Chen
>Priority: Major
> Labels: pull-request-available
> Attachments: NetworkTopologyDefault.yaml
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=220517=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220517 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 29/Mar/19 13:01 Start Date: 29/Mar/19 13:01 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-477989160 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | 0 | yamllint | 0 | yamllint was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1144 | trunk passed | | +1 | compile | 48 | trunk passed | | +1 | checkstyle | 21 | trunk passed | | +1 | mvnsite | 39 | trunk passed | | +1 | shadedclient | 767 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 74 | trunk passed | | +1 | javadoc | 41 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 44 | the patch passed | | +1 | compile | 32 | the patch passed | | +1 | javac | 32 | the patch passed | | -0 | checkstyle | 15 | hadoop-hdds/common: The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0) | | +1 | mvnsite | 36 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedclient | 782 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 76 | the patch passed | | +1 | javadoc | 36 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 75 | common in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 3382 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.net.TestNetworkTopologyImpl | | | hadoop.hdds.scm.net.TestNodeSchemaManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-661/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/661 | | JIRA Issue | HDDS-976 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle yamllint | | uname | Linux 143f4edd 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 82769ba | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/2/artifact/out/diff-checkstyle-hadoop-hdds_common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/2/artifact/out/patch-unit-hadoop-hdds_common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/2/testReport/ | | Max. process+thread count | 340 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common U: hadoop-hdds/common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 220517) Time Spent: 0.5h (was: 20m) > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=220482=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220482 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 29/Mar/19 10:40 Start Date: 29/Mar/19 10:40 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661#issuecomment-477951801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | 0 | yamllint | 0 | yamllint was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1237 | trunk passed | | +1 | compile | 59 | trunk passed | | +1 | checkstyle | 19 | trunk passed | | +1 | mvnsite | 40 | trunk passed | | +1 | shadedclient | 774 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 74 | trunk passed | | +1 | javadoc | 40 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 51 | the patch passed | | +1 | compile | 35 | the patch passed | | +1 | javac | 35 | the patch passed | | -0 | checkstyle | 16 | hadoop-hdds/common: The patch generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0) | | +1 | mvnsite | 42 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedclient | 820 | patch has no errors when building and testing our client artifacts. | | -1 | findbugs | 79 | hadoop-hdds/common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | javadoc | 35 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 79 | common in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 3547 | | | Reason | Tests | |---:|:--| | FindBugs | module:hadoop-hdds/common | | | org.apache.hadoop.hdds.scm.net.NodeSchemaLoader.loadSchemaFromYaml(File) may fail to clean up java.io.InputStream Obligation to clean up resource created at NodeSchemaLoader.java:up java.io.InputStream Obligation to clean up resource created at NodeSchemaLoader.java:[line 208] is not discharged | | Failed junit tests | hadoop.hdds.scm.net.TestNetworkTopologyImpl | | | hadoop.hdds.scm.net.TestNodeSchemaManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/661 | | JIRA Issue | HDDS-976 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle yamllint | | uname | Linux 6a50ad832710 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / f41f938 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/artifact/out/diff-checkstyle-hadoop-hdds_common.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/artifact/out/new-findbugs-hadoop-hdds_common.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/artifact/out/patch-unit-hadoop-hdds_common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/testReport/ | | Max. process+thread count | 304 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common U: hadoop-hdds/common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 220482) Time Spent: 20m (was: 10m) > Support YAML format network topology cluster definition > --- > >
[jira] [Work logged] (HDDS-976) Support YAML format network topology cluster definition
[ https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=220456=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220456 ] ASF GitHub Bot logged work on HDDS-976: --- Author: ASF GitHub Bot Created on: 29/Mar/19 09:39 Start Date: 29/Mar/19 09:39 Worklog Time Spent: 10m Work Description: cjjnjust commented on pull request #661: HDDS-976: Parse network topology from yaml file URL: https://github.com/apache/hadoop/pull/661 This is a early stage patch to support load HDFS schema from a YAML file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 220456) Time Spent: 10m Remaining Estimate: 0h > Support YAML format network topology cluster definition > --- > > Key: HDDS-976 > URL: https://issues.apache.org/jira/browse/HDDS-976 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Sammi Chen >Assignee: Junjie Chen >Priority: Major > Labels: pull-request-available > Attachments: NetworkTopologyDefault.yaml > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
