Re: Testing support for HttpClient.
On Tue, 2020-05-05 at 21:51 +0200, Paweł Adamski wrote: > Hi Oleg > > Thanks for your response. > I'm definitely interested in long term cooperation. I always wanted > to join > some open source project and I hope now I will have a chance for > that. > > Regarding the current testing support that you mentioned, I wanted to > play > with it but I couldn't find any manual for it. Do you know if > anything is > available? > Hi Paweł The idea of showing that bit of code was to give you an example how things can end up neglected even being a part of a large and active project. You do not have to look at it if you do not feel like it. Obviously the code never got documented or updated since its initial contribution. Please also consider downside of your project no longer being independent. It will have to share the same release cycle with HttpClient and conform to the project guidelines and requirements. You will no longer be able to release it whenever you like. You will not be able to break APIs whenever you feel like. You will have to co-exist with some unpleasant people like myself and tolerate their opinion. What might be a reasonable thing to do first is to subscribe to the dev list, start following the discussions on that list, review pull requests, participate in release votes and help resolve issues. If you think you are OK with all that you are welcome to contribute your entire project as a pull request at Github. You will have to port it to 5.0 APIs first though. There will be no new features in the 4.5.x code line. Oleg > Regards > Paweł Adamski > > > niedz., 3 maj 2020 o 17:42 Oleg Kalnichevski > napisał(a): > > > On Sun, 2020-05-03 at 16:39 +0200, Paweł Adamski wrote: > > > Hi > > > My name is Paweł. I'm an author of the library for easy mocking > > > HttpClient > > > ( https://github.com/PawelAdamski/HttpClientMock ). I would like > > > to > > > ask > > > about your opinion wherever it would be a good idea to include it > > > as > > > an > > > official library for testing code using HttpClient? > > > I see that a lot of other libraries and frameworks already do > > > that. > > > For > > > example, every Spring project has an additional component that > > > helps > > > to > > > write test code (e.g. @WebMvcTest, @DataJpaTest, > > > @SpringBootTest). > > > > > > My project has an API similar to the Mockito. First, you have to > > > set > > > up how > > > the HttpClient should behave, and then you can replay that > > > behavior. > > > There > > > is also a possibility to verify if calls have been really made. > > > > > > If you think it is worth making my project an official mocking > > > library for > > > HttpClient, I would appreciate all information about the next > > > steps I > > > should take to make it happen. > > > > > > I'm looking forward to hearing from you. > > > Regards > > > Paweł Adamski > > > > > > > Hi Paweł > > > > There is already some sort of testing support module in HttpCore > > and > > HttpClient which I imagine could host mocking and assert support > > classes as well. > > > > There is a problem however exemplified by the same testing module. > > It > > contains a testing framework contributed some while ago by an > > external > > contributor [1]. The original contributor lost any further interest > > in > > that code pretty much immediately after it had been accepted into > > the > > project and walked away. > > > > Now I have no idea what we ought to do about that testing code. I > > have > > no idea if there are any external projects using it. It appears to > > be > > dead weight for the project. > > > > My first question is quite simple. How likely you are going to > > stick > > around after having your library folded into HttpClient? > > > > Oleg > > > > [1] > > > > > > https://github.com/apache/httpcomponents-core/tree/master/httpcore5-testing/src/main/java/org/apache/hc/core5/testing/framework > > > > > > > > > > - > > > > To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org > > For additional commands, e-mail: > > httpclient-users-h...@hc.apache.org > > > > - To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org For additional commands, e-mail: httpclient-users-h...@hc.apache.org
Re: Testing support for HttpClient.
Hi Oleg Thanks for your response. I'm definitely interested in long term cooperation. I always wanted to join some open source project and I hope now I will have a chance for that. Regarding the current testing support that you mentioned, I wanted to play with it but I couldn't find any manual for it. Do you know if anything is available? Regards Paweł Adamski niedz., 3 maj 2020 o 17:42 Oleg Kalnichevski napisał(a): > On Sun, 2020-05-03 at 16:39 +0200, Paweł Adamski wrote: > > Hi > > My name is Paweł. I'm an author of the library for easy mocking > > HttpClient > > ( https://github.com/PawelAdamski/HttpClientMock ). I would like to > > ask > > about your opinion wherever it would be a good idea to include it as > > an > > official library for testing code using HttpClient? > > I see that a lot of other libraries and frameworks already do that. > > For > > example, every Spring project has an additional component that helps > > to > > write test code (e.g. @WebMvcTest, @DataJpaTest, @SpringBootTest). > > > > My project has an API similar to the Mockito. First, you have to set > > up how > > the HttpClient should behave, and then you can replay that behavior. > > There > > is also a possibility to verify if calls have been really made. > > > > If you think it is worth making my project an official mocking > > library for > > HttpClient, I would appreciate all information about the next steps I > > should take to make it happen. > > > > I'm looking forward to hearing from you. > > Regards > > Paweł Adamski > > > > Hi Paweł > > There is already some sort of testing support module in HttpCore and > HttpClient which I imagine could host mocking and assert support > classes as well. > > There is a problem however exemplified by the same testing module. It > contains a testing framework contributed some while ago by an external > contributor [1]. The original contributor lost any further interest in > that code pretty much immediately after it had been accepted into the > project and walked away. > > Now I have no idea what we ought to do about that testing code. I have > no idea if there are any external projects using it. It appears to be > dead weight for the project. > > My first question is quite simple. How likely you are going to stick > around after having your library folded into HttpClient? > > Oleg > > [1] > > > https://github.com/apache/httpcomponents-core/tree/master/httpcore5-testing/src/main/java/org/apache/hc/core5/testing/framework > > > > > - > To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org > For additional commands, e-mail: httpclient-users-h...@hc.apache.org > >
Re: Testing support for HttpClient.
On Sun, 2020-05-03 at 16:39 +0200, Paweł Adamski wrote: > Hi > My name is Paweł. I'm an author of the library for easy mocking > HttpClient > ( https://github.com/PawelAdamski/HttpClientMock ). I would like to > ask > about your opinion wherever it would be a good idea to include it as > an > official library for testing code using HttpClient? > I see that a lot of other libraries and frameworks already do that. > For > example, every Spring project has an additional component that helps > to > write test code (e.g. @WebMvcTest, @DataJpaTest, @SpringBootTest). > > My project has an API similar to the Mockito. First, you have to set > up how > the HttpClient should behave, and then you can replay that behavior. > There > is also a possibility to verify if calls have been really made. > > If you think it is worth making my project an official mocking > library for > HttpClient, I would appreciate all information about the next steps I > should take to make it happen. > > I'm looking forward to hearing from you. > Regards > Paweł Adamski > Hi Paweł There is already some sort of testing support module in HttpCore and HttpClient which I imagine could host mocking and assert support classes as well. There is a problem however exemplified by the same testing module. It contains a testing framework contributed some while ago by an external contributor [1]. The original contributor lost any further interest in that code pretty much immediately after it had been accepted into the project and walked away. Now I have no idea what we ought to do about that testing code. I have no idea if there are any external projects using it. It appears to be dead weight for the project. My first question is quite simple. How likely you are going to stick around after having your library folded into HttpClient? Oleg [1] https://github.com/apache/httpcomponents-core/tree/master/httpcore5-testing/src/main/java/org/apache/hc/core5/testing/framework - To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org For additional commands, e-mail: httpclient-users-h...@hc.apache.org
Testing support for HttpClient.
Hi My name is Paweł. I'm an author of the library for easy mocking HttpClient ( https://github.com/PawelAdamski/HttpClientMock ). I would like to ask about your opinion wherever it would be a good idea to include it as an official library for testing code using HttpClient? I see that a lot of other libraries and frameworks already do that. For example, every Spring project has an additional component that helps to write test code (e.g. @WebMvcTest, @DataJpaTest, @SpringBootTest). My project has an API similar to the Mockito. First, you have to set up how the HttpClient should behave, and then you can replay that behavior. There is also a possibility to verify if calls have been really made. If you think it is worth making my project an official mocking library for HttpClient, I would appreciate all information about the next steps I should take to make it happen. I'm looking forward to hearing from you. Regards Paweł Adamski Regards Paweł Adamski
