Re: [PHP-DEV] Windows PECL build machine died
i have a 40-core 128GB RAM server with 1 (and only 1) static ipv4 address that I intend to keep around until at least 27 november 2025 (but unsure after that), it has more RAM/CPU than i need, and i could set up a virtual machine on it and give VNC access to the VM in the form of > ssh -L :localhost:3389 user@ip then point a RDP/VNC client to localhost: i can dedicate individual TCP ports to it, but not any of 22, 80, 443, 5900, 5901, 8083, , 587, 2525 (after which i can recommend Teamviewer for a more comfortable access) but the server has several caveats: - it's un-raided, rolling just a single 1TB SSD, if that SSD was to die, everything on it would be lost, and it would probably take days to replace the drive. - it's located in a somewhat unstable environment, occasional power outage, it was out on 30 june, 23 june, 27 january, and in 2021 was down on 30 august. (it boots up and recovers automatically, but it has a reboot time of roughly 300 seconds until ssh responds again) - I can not offer a dedicated IP (but can offer some dedicated ports) - May be decommissioned after 27-11-2025 If that sounds like a good idea, I'll want a ssh public key. On Tue, 12 Jul 2022 at 15:38, Christoph M. Becker wrote: > On 11.07.2022 at 21:04, Hans Henrik Bergan wrote: > > > Any of you windows.php.net guys familiar with SSH? Can one be created? > > That would be possible (needed to be set-up by Alex Schoenmaker), but > while that could solve the upload issue, it wouldn't solve the other > issue I've mentioned, namely that we need to avoid dynamically linking > against incompatible versions of dependencies. And there is yet another > issue, namely security. I think these issues can only be solved by some > central place where the packages are build. > > > On Mon, 11 Jul 2022 at 19:52, Christoph M. Becker > wrote: > > > >> On 11.07.2022 at 18:53, Hans Henrik Bergan wrote: > >> > >>> Is there any SSH public key associated with the Windows php developers? > >> Or > >>> with CMB? > >> > >> No. At least not regarding windows.php.net. > >> > >>> On Mon, 11 Jul 2022 at 18:25, Christoph M. Becker > >> wrote: > >>> > On 11.07.2022 at 17:41, Hans Henrik Bergan wrote: > > > Do you mean it is unlikely that Github Actions will suffice? because > >> that > > would definitely be a great solution if it was possible/feasible . > > No. It is only unlikely that automated uploads to window.php.net > will > ever be possible using GH actions. > > > Anyway, with regards to "I don't think there are special requirements > > regarding the hardware", can you give a rough estimate on RAM/disk > >> space > > requirements? > > The old machine had something like 4 or 8 GB RAM, and a 128 GB hard > >> disk. > > >>> > >> > > > >
Re: [PHP-DEV] [RFC] [VOTE] Constants in traits
On Tue, Jul 5, 2022 at 3:39 PM shinji igarashi wrote: > > Hello internals, > > I've started the vote for the Constants in Traits RFC: > https://wiki.php.net/rfc/constants_in_traits > > The vote will end on 19. July 2022. > > Thanks! > > -- > Shinji Igarashi > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > I have changed my vote from No to Yes. I strongly dislike traits as they are designed and also dislike most of the usages of them I've encountered in the wild. This strongly dislike is why I originally voted No, as enhancing a bad thing can make the bad thing get used more, and that's not what I want. Despite this, I have opted to vote Yes anyway. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement
Hi On 7/12/22 18:04, Tim Düsterhus wrote: I also think that both '$string' and '$binary' are appropriate parameter names in this case, so particular preference from my side. Sorry for the follow-up, there's two mistakes in that sentence. It should read: I also think that both '$string' and **'$bytes'** are appropriate parameter names in this case, so **no** particular preference from my side. Best regards Tim Düsterhus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement
Hi On 7/12/22 14:26, Go Kudo wrote: Currently, the renaming of Randomizer::shuffleString() to Randomizer::shuffleBytes() seems acceptable. I forgot to note the change regarding arguments when I submitted this RFC. With this change, the argument was supposed to be changed from `string $string` to `string $bytes`. - https://github.com/php/php-src/pull/8094#discussion_r916630626 Is this change acceptable? Or should I keep `string $string`? I believe if the method name changes, then the parameter names are also open for adjustment. Especially in this case of a single parameter method where it is unlikely that named parameters are used by the developer. I also think that both '$string' and '$binary' are appropriate parameter names in this case, so particular preference from my side. Best regards Tim Düsterhus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [PHP8.2] Feature freeze in 2 weeks
Hi Rowan, Thanks for your email and sorry about that. We will have to check on how we can solve this issue in the flow so that authors can change the label themself. I changed it to "Waiting on Review" and will make sure to include this in 8.2beta1 which is planned next week. Pierrick Le mar. 12 juill. 2022, à 11 h 09, Rowan Tommins a écrit : > On 05/07/2022 19:08, Pierrick Charron wrote: > > This is yet another friendly reminder from your RMs that the PHP 8.2 > feature > > -freeze is in 2 weeks now [1]. All RFC targeting 8.2 should now be in the > > voting phase to respect the minimal period of 2 weeks. > > > > Also it would be appreciated if some of internal devs could start > reviewing > > PR labeled as "Waiting for review" [2] that are in their field of > expertise. > > > Hi all, > > Could somebody please merge / review this RFC implementation to make > sure it gets into the first beta: https://github.com/php/php-src/pull/8823 > > It's been manually tagged "Waiting on Author", but I have no way to > switch that back to "Waiting on Review" now that I've resolved the > comments. > > Thanks, > > -- > Rowan Tommins > [IMSoP] > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > >
Re: [PHP-DEV] [PHP8.2] Feature freeze in 2 weeks
On 05/07/2022 19:08, Pierrick Charron wrote: This is yet another friendly reminder from your RMs that the PHP 8.2 feature -freeze is in 2 weeks now [1]. All RFC targeting 8.2 should now be in the voting phase to respect the minimal period of 2 weeks. Also it would be appreciated if some of internal devs could start reviewing PR labeled as "Waiting for review" [2] that are in their field of expertise. Hi all, Could somebody please merge / review this RFC implementation to make sure it gets into the first beta: https://github.com/php/php-src/pull/8823 It's been manually tagged "Waiting on Author", but I have no way to switch that back to "Waiting on Review" now that I've resolved the comments. Thanks, -- Rowan Tommins [IMSoP] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement
> > https://wiki.php.net/rfc/random_extension_improvement > > Hi Internals. > > Currently, the renaming of Randomizer::shuffleString() to > Randomizer::shuffleBytes() seems acceptable. > > I forgot to note the change regarding arguments when I submitted this RFC. > With this change, the argument was supposed to be changed from `string > $string` to `string $bytes`. > > - https://github.com/php/php-src/pull/8094#discussion_r916630626 For reference, first was https://github.com/php/php-src/pull/8094/commits/32e83a71eae67fdd822fd12ded5a8c054024a4da#r916058794 > Is this change acceptable? Or should I keep `string $string`? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] Windows PECL build machine died
On 11.07.2022 at 21:04, Hans Henrik Bergan wrote: > Any of you windows.php.net guys familiar with SSH? Can one be created? That would be possible (needed to be set-up by Alex Schoenmaker), but while that could solve the upload issue, it wouldn't solve the other issue I've mentioned, namely that we need to avoid dynamically linking against incompatible versions of dependencies. And there is yet another issue, namely security. I think these issues can only be solved by some central place where the packages are build. > On Mon, 11 Jul 2022 at 19:52, Christoph M. Becker wrote: > >> On 11.07.2022 at 18:53, Hans Henrik Bergan wrote: >> >>> Is there any SSH public key associated with the Windows php developers? >> Or >>> with CMB? >> >> No. At least not regarding windows.php.net. >> >>> On Mon, 11 Jul 2022 at 18:25, Christoph M. Becker >> wrote: >>> On 11.07.2022 at 17:41, Hans Henrik Bergan wrote: > Do you mean it is unlikely that Github Actions will suffice? because >> that > would definitely be a great solution if it was possible/feasible . No. It is only unlikely that automated uploads to window.php.net will ever be possible using GH actions. > Anyway, with regards to "I don't think there are special requirements > regarding the hardware", can you give a rough estimate on RAM/disk >> space > requirements? The old machine had something like 4 or 8 GB RAM, and a 128 GB hard >> disk. >>> >> > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
[PHP-DEV] Re: [VOTE] Random Extension Improvement
2022年7月3日(日) 12:00 Go Kudo : > Hello internals. > > Voting began on 2022-07-02 03:00:00 (UTC) and will end on 2022-07-16 > 03:00:00 (UTC). > > https://wiki.php.net/rfc/random_extension_improvement > > Best Regards, > Go Kudo > Hi Internals. Currently, the renaming of Randomizer::shuffleString() to Randomizer::shuffleBytes() seems acceptable. I forgot to note the change regarding arguments when I submitted this RFC. With this change, the argument was supposed to be changed from `string $string` to `string $bytes`. - https://github.com/php/php-src/pull/8094#discussion_r916630626 Is this change acceptable? Or should I keep `string $string`? Regards, Go Kudo
Re: [PHP-DEV] [VOTE] Random Extension Improvement
2022年7月8日(金) 1:44 Tim Düsterhus : > Hi > > On 7/7/22 17:52, Go Kudo wrote: > > Implementation is now proceeding. > > It includes fixes to some of the issues that were pointed out previously. > > > > https://github.com/php/php-src/pull/8094 > > > > `Randomizer::arrayPickKeys()` is currently not implemented for now, since > > it is most likely to be rejected. > > (Of course, we are ready to revert to the other items if they are also > > rejected.) > > > > I want to see if it looks good to you. > > I've reviewed the current implementation of the engines with a specific > focus on the tests. > > 1. I have verified the Xoshiro256** tests against a pure PHP > implementation (which I verified against the C reference implementation > [1]). > > 2. I have verified the Pcg64OneseqXslRr64 pcgoneseq128xslrr64_value.phpt > test against the reference C implementation [2] with the attached > pcg-verification.c. > > 3. I have verified the Mt19937 mt_value.phpt test against the C++ > standard library implementation [3] with the attached mt-verification.cc. > > The three engines do what they are supposed to do. I'm not qualified to > review with regard to PHP Internals best practices. It would be good if > someone with the necessary expertise could proceed with that part of the > review. > > Best regards > Tim Düsterhus > > [1] https://prng.di.unimi.it/xoshiro256starstar.c > [2] https://www.pcg-random.org/download.html#c-implementation > [3] > https://en.cppreference.com/w/cpp/numeric/random/mersenne_twister_engine Hi Tim. Sorry for the late reply. Thanks for the verification. I changed the serialization format to hex string as you pointed out earlier. You should now be able to validate your PHP implementation. Regards, Go Kudo
