Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
At 07:20 PM 12/18/2003 +0100, Christian Schneider wrote: Derick Rethans wrote: It won't bork all scripts with a custom errorhandler if their default action is to ignore core and other errors but only handle the ones they should handle. I do agree that it should be mentioned in the changes file though. On the other hand you have to be very careful (another way of saying 'avoid') using custom error_handlers anyway because http://bugs.php.net/bug.php?id=25547 will break your application. Still there in PHP 5.0.0b3RC1 Yeah this is a known bug and will have to be fixed in RC1. It's not a showstopper for B3. In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? Anyway, I'm holding off with Beta 3 until we fix the --install-pear-packages problem. I'd call that a showstopper because it's something pretty basic. Has anyone managed to create a reproducing script or backtrace? Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? So you're suggesting to add another BC break here, without a really good reason? :) Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
At 10:24 PM 12/18/2003 +0100, Derick Rethans wrote: On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? So you're suggesting to add another BC break here, without a really good reason? :) What BC does it break? Some weirdo who logs all of his E_NOTICES? :) Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
On Thu, 18 Dec 2003, Andi Gutmans wrote: At 10:24 PM 12/18/2003 +0100, Derick Rethans wrote: On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? So you're suggesting to add another BC break here, without a really good reason? :) What BC does it break? Some weirdo who logs all of his E_NOTICES? :) Those can be the same weirdos which mix upper and lowercase function names ;-) Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
Andi Gutmans wrote: At 10:24 PM 12/18/2003 +0100, Derick Rethans wrote: On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? So you're suggesting to add another BC break here, without a really good reason? :) What BC does it break? Some weirdo who logs all of his E_NOTICES? :) Andi Look like I am an weirdo :) with an web farm of servers which log every NOTICE that appear. And even I think it was possible to catch a fatal error that happens in a required file with the way the error handler works now. Andrey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
On Thu, 2003-12-18 at 20:35, Andi Gutmans wrote: At 07:20 PM 12/18/2003 +0100, Christian Schneider wrote: Derick Rethans wrote: It won't bork all scripts with a custom errorhandler if their default action is to ignore core and other errors but only handle the ones they should handle. I do agree that it should be mentioned in the changes file though. On the other hand you have to be very careful (another way of saying 'avoid') using custom error_handlers anyway because http://bugs.php.net/bug.php?id=25547 will break your application. Still there in PHP 5.0.0b3RC1 Yeah this is a known bug and will have to be fixed in RC1. It's not a showstopper for B3. In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? Good question. Having an error handling function becomes really expensive if your code is not E_ALL-clean in a loop or something. IMHO the error_reporting mask should be applied before a user error handler is called. That's the solution with greatest flexibility. You can configure PHP to send all errors to the error handler if it's changed, but today it's impossible to prevent your handler from getting notices. I'm +1 on changing this. Anyway, I'm holding off with Beta 3 until we fix the --install-pear-packages problem. I'd call that a showstopper because it's something pretty basic. Has anyone managed to create a reproducing script or backtrace? It doesn't crash on my box :( Could someone with a crashing make install-pear-packages post the contents of their config.nice file and OS signature as well as gcc/libtool/autoconf versions? - Stig -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
On Thu, 2003-12-18 at 22:56, Andi Gutmans wrote: At 10:24 PM 12/18/2003 +0100, Derick Rethans wrote: On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? So you're suggesting to add another BC break here, without a really good reason? :) What BC does it break? Some weirdo who logs all of his E_NOTICES? :) Watch who you're calling a weirdo ;-) - Stig -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
Stig S. Bakken wrote: Good question. Having an error handling function becomes really expensive if your code is not E_ALL-clean in a loop or something. if you set a custom error handler you know what you are doing and probably don't have such places in the code :) IMHO the error_reporting mask should be applied before a user error handler is called. That's the solution with greatest flexibility. You can configure PHP to send all errors to the error handler if it's changed, but today it's impossible to prevent your handler from getting notices. I'm +1 on changing this. me too (as already stated) Andrey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated
On Thu, 18 Dec 2003, Stig S. Bakken wrote: Anyway, I'm holding off with Beta 3 until we fix the --install-pear-packages problem. I'd call that a showstopper because it's something pretty basic. Has anyone managed to create a reproducing script or backtrace? It doesn't crash on my box :( Neither does it forme, but it *does* give: [PEAR] HTTP - already installed: 1.2.1 /dat/dev/php/php-5.0dev/Zend/zend_hash.c(504) : ht=0x403592d0 is being destroyed regards, Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
