[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009498#comment-16009498
 ] 

ASF GitHub Bot commented on ARTEMIS-1163:
-

Github user klausboeing commented on the issue:

https://github.com/apache/activemq-artemis/pull/1269
  
@jbertram Exactly this point I would like to know. Thank you.


> Refactory connection factory client creation
> 
>
> Key: ARTEMIS-1163
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1163
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Klaus Boeing
>Priority: Minor
>
> The implementation of the ActiveMQJMSClient class currently has several 
> conditionals for creating a connecction factory according to the 
> JMSFactoryType.
> I think it is convenient to tailor the implementation so that the connection 
> factory creation logic is in the JMSFactoryType itself, simplifying the code 
> and making it easier to maintain.
> Follow the adjustment made 
> https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009486#comment-16009486
 ] 

ASF GitHub Bot commented on ARTEMIS-1163:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1269
  
@klausboeing, I'm not exactly sure what you're asking. Once the PR is 
merged I'll close the JIRA.

At this point you need to squash the two commits together into a single 
commit.


> Refactory connection factory client creation
> 
>
> Key: ARTEMIS-1163
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1163
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Klaus Boeing
>Priority: Minor
>
> The implementation of the ActiveMQJMSClient class currently has several 
> conditionals for creating a connecction factory according to the 
> JMSFactoryType.
> I think it is convenient to tailor the implementation so that the connection 
> factory creation logic is in the JMSFactoryType itself, simplifying the code 
> and making it easier to maintain.
> Follow the adjustment made 
> https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009479#comment-16009479
 ] 

ASF GitHub Bot commented on ARTEMIS-1163:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1269
  
Nice PR though.   Just need to make sure checkstyke is passing. 


> Refactory connection factory client creation
> 
>
> Key: ARTEMIS-1163
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1163
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Klaus Boeing
>Priority: Minor
>
> The implementation of the ActiveMQJMSClient class currently has several 
> conditionals for creating a connecction factory according to the 
> JMSFactoryType.
> I think it is convenient to tailor the implementation so that the connection 
> factory creation logic is in the JMSFactoryType itself, simplifying the code 
> and making it easier to maintain.
> Follow the adjustment made 
> https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009475#comment-16009475
 ] 

ASF GitHub Bot commented on ARTEMIS-1163:
-

Github user klausboeing commented on the issue:

https://github.com/apache/activemq-artemis/pull/1269
  
@jbertram I made the adjustments as needed.

How will the ARTEMIS-1163 ticket be processed?

Thanks for listening.


> Refactory connection factory client creation
> 
>
> Key: ARTEMIS-1163
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1163
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Klaus Boeing
>Priority: Minor
>
> The implementation of the ActiveMQJMSClient class currently has several 
> conditionals for creating a connecction factory according to the 
> JMSFactoryType.
> I think it is convenient to tailor the implementation so that the connection 
> factory creation logic is in the JMSFactoryType itself, simplifying the code 
> and making it easier to maintain.
> Follow the adjustment made 
> https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ARTEMIS-1163) Refactory connection factory client creation

[Klaus Boeing (JIRA)]

Klaus Boeing created ARTEMIS-1163:
-

 Summary: Refactory connection factory client creation
 Key: ARTEMIS-1163
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1163
 Project: ActiveMQ Artemis
  Issue Type: Improvement
  Components: Broker
Affects Versions: 2.2.0
Reporter: Klaus Boeing
Priority: Minor


The implementation of the ActiveMQJMSClient class currently has several 
conditionals for creating a connecction factory according to the JMSFactoryType.

I think it is convenient to tailor the implementation so that the connection 
factory creation logic is in the JMSFactoryType itself, simplifying the code 
and making it easier to maintain.

Follow the adjustment made 
https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009237#comment-16009237
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
@michaelandrepearce  I removed that update because I've noticed that 
writing on dev list using Gmail produce better images than using nabble to do 
the same :(


> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009227#comment-16009227
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
@michaelandrepearce I've updated the dev list post with the latest results 
on the new TimedBuffer vs old and with/without the IO limiter to let other devs 
to ask/propose/give advice about them if possible.
As you said, is always good to have more opinions :100: 


> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009218#comment-16009218
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1268


> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009217#comment-16009217
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
I agree with you, thanks for the comments :) it's always good to have the 
second opinions :). Let me re work it and I'll msg once ready for another 
review :)


> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009214#comment-16009214
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
For me is ok to have an enum, but I mean that it doesn't make sense to have 
2 TimedBuffer implementations.
You can have one with a flag in the constructor to disable the coalescing: 
this way the behaviours will be the same as before, but with off heap batch 
buffer + bulk copy too.
Then you can you an enum to set that flag or not: it is simpler to maintain 
IMHO.
It is different if you want to maintain the older things that wasn't good 
(heap buffers + no bulk copy)...this is what you're proposing?



> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009211#comment-16009211
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
"paeans" wow my iphone is doing its best today!

I meant parameters 


> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009210#comment-16009210
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
I actually started with a boolean flag option, but then thought about the 
other bits being added and before we know it we'd have quite a few flags which 
equate to lots of config options to be added in broker.xml

Where as having an enum from a user perspective means you simply define 
which timed buffer type you want, and is a little more plain English with what 
you're selecting.

Maybe I can see if I can make the enum for config so we don't explode the 
config paeans but re work the reintroduction of the old behaviour like you 
propose. 


> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009207#comment-16009207
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
@michaelandrepearce And about loosing some tests, it is not a big deal; the 
deleted ones has some issues, so it has no practical effect to have them 
deleted.
On 
https://github.com/franz1981/activemq-artemis/tree/timed_buffer_iops_test the 
[shouldNotFlusgUntilTimeout 
test](https://github.com/franz1981/activemq-artemis/blob/12c34475f16a73d669c3307999e6fa03601c6cb3/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/TimedBufferTest.java#L137-L137)
 shows that with the original implementation was possible to go out of IOPS too.




> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009203#comment-16009203
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
@michaelandrepearce Nope, no problem for me...but I'm not 100% sure is the 
best way to do it: changing the new one to be like the original one is a matter 
of 1 line change and a boolean flag to be put in the right spot.
Instead of having: 
```
if (checkpoint || currentPendingSyncs >= estimatedOptimalBatch) {
```
Need to be changed into:
```
if (checkpoint || (smartCoalescing && currentPendingSyncs >= 
estimatedOptimalBatch)) {
```
Finished.
Now you have one implementation that cover the 2 behaviours.
wdyt?




> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009197#comment-16009197
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1268
  
@franz1981 I hope you don't mind me doing this, just as the new timed 
buffer work you've done, whilst benchmarked we won't get any proper real use 
feedback till systems hit production, and just want to mitigate risks.

Also it will make less risky other changes, such as the IOLimiter.

Idea would be to add an extra timed buffer type enum, for your IOLimiter 
version also.



> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009194#comment-16009194
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1268

ARTEMIS-1162: Make new TimedBuffer Configurable

Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable.

Rename new version of TimedBuffer to AdaptingTimedBuffer (and tests)
Add back old version of TimedBuffer to FixedTimedBuffer (and tests)
Extract shared public interface
Add configuration option to toggle between which TimedBuffer to user, in 
broker.xml "journal-timed-buffer-type=[FIXED,ADAPTING]"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1162

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1268


commit cd7ca0a16bba97f87e422869f1818a6e86396189
Author: Michael Andre Pearce 
Date:   2017-05-13T07:25:39Z

ARTEMIS-1162: Make new Adapting TimedBuffer and old Fixed TimedBuffer 
configurable

Rename new version of TimedBuffer to AdaptingTimedBuffer (and tests)
Add back old version of TimedBuffer to FixedTimedBuffer (and tests)
Extract shared public interface
Add configuration option to toggle between which TimedBuffer to user, in 
broker.xml "journal-timed-buffer-type=[FIXED,ADAPTING]"




> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[Michael Andre Pearce (JIRA)]

Michael Andre Pearce created ARTEMIS-1162:
-

 Summary: Make new Adapting TimedBuffer and old Fixed TimedBuffer 
configurable
 Key: ARTEMIS-1162
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Affects Versions: 2.1.0
Reporter: Michael Andre Pearce
 Fix For: 2.2.0


New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
This could cause behaviour/performance change of journal IO (and hopefully for 
the better).

As this hasn't been run significantly in a real world production environment, 
to avoid causing any production deployment issues having unexpected behaviour 
changes, or to allow managed rollout and rollback.

We would like to add back the fixed timed buffer (default), and make it 
configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)