[jira] [Reopened] (AMQ-7277) Need to expose an api to extract localCertificates & PeerCertificates during the handshake
[ https://issues.apache.org/jira/browse/AMQ-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] rajiv devaraj reopened AMQ-7277: I have a scenario where , server maintain different self signed certificates for different clients , so while SSL handshake there are exchange of certificates will be different for different client , so this will not be achievable if i have multiple certificates present . If you take a look at SSLSocket they have an api addHandshakeCompletedListener , from where we can fetch both Local Certificates & Peer Certificates exchanged during the handshake . [https://docs.oracle.com/javase/7/docs/api/javax/net/ssl/SSLSocket.html] and from handshakecompleted event we can get both Local Certificate & Peer Certificate that got exchanged . [https://docs.oracle.com/javase/7/docs/api/javax/net/ssl/HandshakeCompletedEvent.html] Similarly i would you like to have information on getting both LocalCertificate & peerCertificate that got exchanged during the successful handshake > Need to expose an api to extract localCertificates & PeerCertificates during > the handshake > -- > > Key: AMQ-7277 > URL: https://issues.apache.org/jira/browse/AMQ-7277 > Project: ActiveMQ > Issue Type: New Feature >Affects Versions: 5.7.0 >Reporter: rajiv devaraj >Priority: Major > Fix For: 5.7.0, 5.15.8, 5.15.9, 5.15.11 > > > Like in 5.15.11 , where under Tranport > interface(org.apache.activemq.transport) there is a way to extract peer > certificate exchanged during the handshake , like wise i would need to know > the local certificate being exchanged during the handshake . so would require > an api to extract both localCerticate & peerCertificate being exchanged > during the communication > > attaching the stack overflow link for more reference : > [https://stackoverflow.com/questions/57507718/socket-where-we-have-api-to-fetch-local-certificates-peer-certificates-during?noredirect=1#comment101492217_57507718] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (AMQ-7277) Need to expose an api to extract localCertificates & PeerCertificates during the handshake
[ https://issues.apache.org/jira/browse/AMQ-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910995#comment-16910995 ] rajiv devaraj edited comment on AMQ-7277 at 8/20/19 4:28 AM: - I have a scenario where , server maintain multiple self signed certificates for different clients , so while SSL handshake there are exchange of certificates will be different for different client , so this will not be achievable if i have multiple certificates present . If you take a look at SSLSocket they have an api addHandshakeCompletedListener , from where we can fetch both Local Certificates & Peer Certificates exchanged during the handshake . [https://docs.oracle.com/javase/7/docs/api/javax/net/ssl/SSLSocket.html] and from handshakecompleted event we can get both Local Certificate & Peer Certificate that got exchanged . [https://docs.oracle.com/javase/7/docs/api/javax/net/ssl/HandshakeCompletedEvent.html] Similarly i would you like to have information on getting both LocalCertificate & peerCertificate that got exchanged during the successful handshake was (Author: rajivnitb): I have a scenario where , server maintain different self signed certificates for different clients , so while SSL handshake there are exchange of certificates will be different for different client , so this will not be achievable if i have multiple certificates present . If you take a look at SSLSocket they have an api addHandshakeCompletedListener , from where we can fetch both Local Certificates & Peer Certificates exchanged during the handshake . [https://docs.oracle.com/javase/7/docs/api/javax/net/ssl/SSLSocket.html] and from handshakecompleted event we can get both Local Certificate & Peer Certificate that got exchanged . [https://docs.oracle.com/javase/7/docs/api/javax/net/ssl/HandshakeCompletedEvent.html] Similarly i would you like to have information on getting both LocalCertificate & peerCertificate that got exchanged during the successful handshake > Need to expose an api to extract localCertificates & PeerCertificates during > the handshake > -- > > Key: AMQ-7277 > URL: https://issues.apache.org/jira/browse/AMQ-7277 > Project: ActiveMQ > Issue Type: New Feature >Affects Versions: 5.7.0 >Reporter: rajiv devaraj >Priority: Major > Fix For: 5.7.0, 5.15.8, 5.15.9, 5.15.11 > > > Like in 5.15.11 , where under Tranport > interface(org.apache.activemq.transport) there is a way to extract peer > certificate exchanged during the handshake , like wise i would need to know > the local certificate being exchanged during the handshake . so would require > an api to extract both localCerticate & peerCertificate being exchanged > during the communication > > attaching the stack overflow link for more reference : > [https://stackoverflow.com/questions/57507718/socket-where-we-have-api-to-fetch-local-certificates-peer-certificates-during?noredirect=1#comment101492217_57507718] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (AMQ-7201) shebang is missing in the admin script created by "activemq create"
[ https://issues.apache.org/jira/browse/AMQ-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-7201. --- Resolution: Fixed > shebang is missing in the admin script created by "activemq create" > --- > > Key: AMQ-7201 > URL: https://issues.apache.org/jira/browse/AMQ-7201 > Project: ActiveMQ > Issue Type: Bug > Components: Command Line Tools >Affects Versions: 5.15.9 >Reporter: VLADIMIR LYSYY >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: patch, usability > Fix For: 5.16.0, 5.15.10 > > Time Spent: 20m > Remaining Estimate: 0h > > SUBJ, when creating a broker instance with `activemq create` the generated > admin script bin/ is missing shebang line. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AMQ-7201) shebang is missing in the admin script created by "activemq create"
[ https://issues.apache.org/jira/browse/AMQ-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910602#comment-16910602 ] ASF subversion and git services commented on AMQ-7201: -- Commit 5e8f296300c80a9cf4a516286cd5dbce688481f9 in activemq's branch refs/heads/activemq-5.15.x from mrbald [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=5e8f296 ] AMQ-7201 added shebang to generated broker admin script > shebang is missing in the admin script created by "activemq create" > --- > > Key: AMQ-7201 > URL: https://issues.apache.org/jira/browse/AMQ-7201 > Project: ActiveMQ > Issue Type: Bug > Components: Command Line Tools >Affects Versions: 5.15.9 >Reporter: VLADIMIR LYSYY >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: patch, usability > Fix For: 5.16.0, 5.15.10 > > Time Spent: 20m > Remaining Estimate: 0h > > SUBJ, when creating a broker instance with `activemq create` the generated > admin script bin/ is missing shebang line. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AMQ-7201) shebang is missing in the admin script created by "activemq create"
[ https://issues.apache.org/jira/browse/AMQ-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910601#comment-16910601 ] ASF subversion and git services commented on AMQ-7201: -- Commit a2cdcfb652faf259081e9bced9a46009ffc81713 in activemq's branch refs/heads/revert-358-patch-1 from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=a2cdcfb ] Revert "AMQ-7201 added shebang to generated broker admin script" > shebang is missing in the admin script created by "activemq create" > --- > > Key: AMQ-7201 > URL: https://issues.apache.org/jira/browse/AMQ-7201 > Project: ActiveMQ > Issue Type: Bug > Components: Command Line Tools >Affects Versions: 5.15.9 >Reporter: VLADIMIR LYSYY >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: patch, usability > Fix For: 5.16.0, 5.15.10 > > Time Spent: 20m > Remaining Estimate: 0h > > SUBJ, when creating a broker instance with `activemq create` the generated > admin script bin/ is missing shebang line. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AMQ-7201) shebang is missing in the admin script created by "activemq create"
[ https://issues.apache.org/jira/browse/AMQ-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910600#comment-16910600 ] ASF subversion and git services commented on AMQ-7201: -- Commit 84cc95c7ac80b8f8754758e823c8816240bd31a1 in activemq's branch refs/heads/master from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=84cc95c ] Merge pull request #358 from mrbald/patch-1 AMQ-7201 added shebang to generated broker admin script > shebang is missing in the admin script created by "activemq create" > --- > > Key: AMQ-7201 > URL: https://issues.apache.org/jira/browse/AMQ-7201 > Project: ActiveMQ > Issue Type: Bug > Components: Command Line Tools >Affects Versions: 5.15.9 >Reporter: VLADIMIR LYSYY >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: patch, usability > Fix For: 5.16.0, 5.15.10 > > Time Spent: 20m > Remaining Estimate: 0h > > SUBJ, when creating a broker instance with `activemq create` the generated > admin script bin/ is missing shebang line. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (AMQ-7201) shebang is missing in the admin script created by "activemq create"
[ https://issues.apache.org/jira/browse/AMQ-7201?focusedWorklogId=297319=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297319 ] ASF GitHub Bot logged work on AMQ-7201: --- Author: ASF GitHub Bot Created on: 19/Aug/19 17:32 Start Date: 19/Aug/19 17:32 Worklog Time Spent: 10m Work Description: jbonofre commented on pull request #358: AMQ-7201 added shebang to generated broker admin script URL: https://github.com/apache/activemq/pull/358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297319) Time Spent: 20m (was: 10m) > shebang is missing in the admin script created by "activemq create" > --- > > Key: AMQ-7201 > URL: https://issues.apache.org/jira/browse/AMQ-7201 > Project: ActiveMQ > Issue Type: Bug > Components: Command Line Tools >Affects Versions: 5.15.9 >Reporter: VLADIMIR LYSYY >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: patch, usability > Fix For: 5.16.0, 5.15.10 > > Time Spent: 20m > Remaining Estimate: 0h > > SUBJ, when creating a broker instance with `activemq create` the generated > admin script bin/ is missing shebang line. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AMQ-7201) shebang is missing in the admin script created by "activemq create"
[ https://issues.apache.org/jira/browse/AMQ-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910599#comment-16910599 ] ASF subversion and git services commented on AMQ-7201: -- Commit b11b9aac7515ce897c216b472770bf3cf4734847 in activemq's branch refs/heads/master from mrbald [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=b11b9aa ] AMQ-7201 added shebang to generated broker admin script > shebang is missing in the admin script created by "activemq create" > --- > > Key: AMQ-7201 > URL: https://issues.apache.org/jira/browse/AMQ-7201 > Project: ActiveMQ > Issue Type: Bug > Components: Command Line Tools >Affects Versions: 5.15.9 >Reporter: VLADIMIR LYSYY >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: patch, usability > Fix For: 5.16.0, 5.15.10 > > Time Spent: 20m > Remaining Estimate: 0h > > SUBJ, when creating a broker instance with `activemq create` the generated > admin script bin/ is missing shebang line. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (AMQ-7201) shebang is missing in the admin script created by "activemq create"
[ https://issues.apache.org/jira/browse/AMQ-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-7201: - Assignee: Jean-Baptiste Onofré > shebang is missing in the admin script created by "activemq create" > --- > > Key: AMQ-7201 > URL: https://issues.apache.org/jira/browse/AMQ-7201 > Project: ActiveMQ > Issue Type: Bug > Components: Command Line Tools >Affects Versions: 5.15.9 >Reporter: VLADIMIR LYSYY >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: patch, usability > Time Spent: 10m > Remaining Estimate: 0h > > SUBJ, when creating a broker instance with `activemq create` the generated > admin script bin/ is missing shebang line. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (AMQ-7201) shebang is missing in the admin script created by "activemq create"
[ https://issues.apache.org/jira/browse/AMQ-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-7201: -- Fix Version/s: 5.15.10 5.16.0 > shebang is missing in the admin script created by "activemq create" > --- > > Key: AMQ-7201 > URL: https://issues.apache.org/jira/browse/AMQ-7201 > Project: ActiveMQ > Issue Type: Bug > Components: Command Line Tools >Affects Versions: 5.15.9 >Reporter: VLADIMIR LYSYY >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: patch, usability > Fix For: 5.16.0, 5.15.10 > > Time Spent: 10m > Remaining Estimate: 0h > > SUBJ, when creating a broker instance with `activemq create` the generated > admin script bin/ is missing shebang line. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910598#comment-16910598 ] ASF subversion and git services commented on AMQ-7199: -- Commit c346dbaf5c6065d4f64d355ee053b83a1d317595 in activemq's branch refs/heads/activemq-5.15.x from bd2019us [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=c346dba ] [AMQ-7199] Replace Math.Random with Random.nextDouble > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Fix For: 5.16.0, 5.15.10 > > Attachments: AMQ-7199.patch > > Time Spent: 20m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-7199. --- Resolution: Fixed > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Fix For: 5.16.0, 5.15.10 > > Attachments: AMQ-7199.patch > > Time Spent: 20m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910596#comment-16910596 ] ASF subversion and git services commented on AMQ-7199: -- Commit fb7d4e6c4d9b23e88cf672ab777fce36f48c60a9 in activemq's branch refs/heads/master from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=fb7d4e6 ] Merge pull request #357 from bd2019us/AMQ-7199 [AMQ-7199] Replace Math.Random with Random.nextDouble > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Fix For: 5.16.0, 5.15.10 > > Attachments: AMQ-7199.patch > > Time Spent: 20m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?focusedWorklogId=297317=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297317 ] ASF GitHub Bot logged work on AMQ-7199: --- Author: ASF GitHub Bot Created on: 19/Aug/19 17:29 Start Date: 19/Aug/19 17:29 Worklog Time Spent: 10m Work Description: jbonofre commented on pull request #357: [AMQ-7199] Replace Math.Random with Random.nextDouble URL: https://github.com/apache/activemq/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297317) Time Spent: 20m (was: 10m) > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Fix For: 5.16.0, 5.15.10 > > Attachments: AMQ-7199.patch > > Time Spent: 20m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910597#comment-16910597 ] ASF subversion and git services commented on AMQ-7199: -- Commit fb7d4e6c4d9b23e88cf672ab777fce36f48c60a9 in activemq's branch refs/heads/master from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=fb7d4e6 ] Merge pull request #357 from bd2019us/AMQ-7199 [AMQ-7199] Replace Math.Random with Random.nextDouble > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Fix For: 5.16.0, 5.15.10 > > Attachments: AMQ-7199.patch > > Time Spent: 20m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910595#comment-16910595 ] ASF subversion and git services commented on AMQ-7199: -- Commit ca77f9cfc9135c5cf7fbb91c0d4ccbf95ca44b59 in activemq's branch refs/heads/master from bd2019us [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=ca77f9c ] [AMQ-7199] Replace Math.Random with Random.nextDouble > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Fix For: 5.16.0, 5.15.10 > > Attachments: AMQ-7199.patch > > Time Spent: 20m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-7199: - Assignee: Jean-Baptiste Onofré > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Attachments: AMQ-7199.patch > > Time Spent: 10m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-7199: -- Component/s: Broker > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Attachments: AMQ-7199.patch > > Time Spent: 10m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (AMQ-7199) Replace Math.Random with Random.nextDouble
[ https://issues.apache.org/jira/browse/AMQ-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-7199: -- Fix Version/s: 5.15.10 5.16.0 > Replace Math.Random with Random.nextDouble > -- > > Key: AMQ-7199 > URL: https://issues.apache.org/jira/browse/AMQ-7199 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Reporter: bd2019us >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Fix For: 5.16.0, 5.15.10 > > Attachments: AMQ-7199.patch > > Time Spent: 10m > Remaining Estimate: 0h > > For better control over randomness and comparatively less performance > overhead, Random.nextDouble can be used instead of Math.random. Such a sample > instance is showed in the attached patch. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (AMQ-7249) Security Vulnerabilities in the ActiveMQ dependent jars.
[ https://issues.apache.org/jira/browse/AMQ-7249?focusedWorklogId=297294=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297294 ] ASF GitHub Bot logged work on AMQ-7249: --- Author: ASF GitHub Bot Created on: 19/Aug/19 17:08 Start Date: 19/Aug/19 17:08 Worklog Time Spent: 10m Work Description: jbonofre commented on issue #387: [AMQ-7249] Upgrade to Jetty 9.4.19.v20190610 URL: https://github.com/apache/activemq/pull/387#issuecomment-522668383 @coheigea I think I already have a fix. I gonna rebase, squash and push. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297294) Time Spent: 1h 40m (was: 1.5h) > Security Vulnerabilities in the ActiveMQ dependent jars. > > > Key: AMQ-7249 > URL: https://issues.apache.org/jira/browse/AMQ-7249 > Project: ActiveMQ > Issue Type: Bug > Components: activemq-camel >Affects Versions: 5.15.9 >Reporter: Harish Kumar >Assignee: Jean-Baptiste Onofré >Priority: Critical > Labels: Apache, camel-core > Fix For: 5.16.0, 5.15.10 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Latest version of ActiveMQ(5.15.9) which has dependent jars has Security > Vulnerabilities. > *Below are the jars with Security Vulnerabilities.* > > *1) camel-core-2.19.5.jar :* To be updated to latest > version(camel-core-2.24.1.jar or above). > *Reference* : CVE-2019-0188 > *Path :* org.apache.activemq-5.15.9_1/lib/camel/camel-core-2.19.5.jar > > *2) apache-jsp-9.2.25.v20180606.jar:* To be updated to latest version > (apache-jsp-9.4.19.v20190610.jar) > *Reference:* CVE-2018-8014 , CVE-2018-8034, CVE-2019-10241, > CVE-2019-10247,CVE-2017-6056 > > *Path:* org.apache.activemq-5.15.9_1/lib/web/apache-jsp-8.0.33.jar > : org.apache.activemq-5.15.9_1/lib/web/apache-jsp-9.2.25.v20180606.jar > > 3) *scala-library-2.11.0.jar:* To be updated to 2.13.0 version. ActiveMQ > library has dependency with scala-library.jar > *Path:* org.apache.activemq-5.15.9_1/lib/optional/scala-library-2.11.0.jar > *Reference:* [https://nvd.nist.gov/vuln/detail/CVE-2017-15288] > Need to upgrade the above jars to the the recommended version or provide an > alternative way to replace the existing jar version with the updated versions. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297257=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297257 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 16:18 Start Date: 19/Aug/19 16:18 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297257) Time Spent: 5h 20m (was: 5h 10m) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 5h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910524#comment-16910524 ] ASF subversion and git services commented on ARTEMIS-2450: -- Commit a644c498da088cf9a5a9d1d4c13aa0acbdcbd2dd in activemq-artemis's branch refs/heads/master from Wei Yang [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a644c49 ] ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297250=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297250 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 16:11 Start Date: 19/Aug/19 16:11 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315293725 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -1756,17 +1758,17 @@ private void parseClusterConnectionConfiguration(final Element e, final Configur double retryIntervalMultiplier = getDouble(e, "retry-interval-multiplier", ActiveMQDefaultConfiguration.getDefaultClusterRetryIntervalMultiplier(), Validators.GT_ZERO); - int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.GT_ZERO); + int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.POSITIVE_INT); Review comment: ignore i was wrong, i see the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297250) Time Spent: 4h 50m (was: 4h 40m) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297251=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297251
]
ASF GitHub Bot logged work on ARTEMIS-2450:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 16:11
Start Date: 19/Aug/19 16:11
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315293775
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/Validators.java
##
@@ -122,6 +122,30 @@ public void validate(final String name, final Object
value) {
}
};
+ public static final Validator POSITIVE_INT = new Validator() {
+ @Override
+ public void validate(final String name, final Object value) {
+ Number val = (Number) value;
+ if (val.longValue() > 0 && val.longValue() <= Integer.MAX_VALUE) {
+// OK
+ } else {
+throw ActiveMQMessageBundle.BUNDLE.inRangeOfPositiveInt(name, val);
+ }
+ }
+ };
+
+ public static final Validator MINUS_ONE_OR_POSITIVE_INT = new Validator() {
Review comment:
ignore i spotted, why finally, its because GB etc can be used in the string
type, and then converted as such cannot limit this in xsd.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297251)
Time Spent: 5h (was: 4h 50m)
> page-size-bytes should not be greater than Integer.MAX_VALUE
>
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297252=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297252 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 16:11 Start Date: 19/Aug/19 16:11 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315293926 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -597,11 +597,11 @@ public void parseMainConfig(final Element e, final Configuration config) throws config.setJournalSyncNonTransactional(getBoolean(e, "journal-sync-non-transactional", config.isJournalSyncNonTransactional())); - config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size", config.getJournalFileSize(), Validators.GT_ZERO)); + config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size", config.getJournalFileSize(), Validators.POSITIVE_INT)); Review comment: ignore i spotted why you need. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297252) Time Spent: 5h 10m (was: 5h) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297249=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297249
]
ASF GitHub Bot logged work on ARTEMIS-2450:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 16:10
Start Date: 19/Aug/19 16:10
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315293589
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/Validators.java
##
@@ -122,6 +122,30 @@ public void validate(final String name, final Object
value) {
}
};
+ public static final Validator POSITIVE_INT = new Validator() {
Review comment:
ignore i spotted, why finally, its because GB etc can be used in the string
type, and then converted as such cannot limit this in xsd.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297249)
Time Spent: 4h 40m (was: 4.5h)
> page-size-bytes should not be greater than Integer.MAX_VALUE
>
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297243=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297243 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 16:09 Start Date: 19/Aug/19 16:09 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315289774 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -597,11 +597,11 @@ public void parseMainConfig(final Element e, final Configuration config) throws config.setJournalSyncNonTransactional(getBoolean(e, "journal-sync-non-transactional", config.isJournalSyncNonTransactional())); - config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size", config.getJournalFileSize(), Validators.GT_ZERO)); + config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size", config.getJournalFileSize(), Validators.POSITIVE_INT)); int journalBufferTimeout = getInteger(e, "journal-buffer-timeout", config.getJournalType() == JournalType.ASYNCIO ? ArtemisConstants.DEFAULT_JOURNAL_BUFFER_TIMEOUT_AIO : ArtemisConstants.DEFAULT_JOURNAL_BUFFER_TIMEOUT_NIO, Validators.GE_ZERO); - int journalBufferSize = getTextBytesAsIntBytes(e, "journal-buffer-size", config.getJournalType() == JournalType.ASYNCIO ? ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_AIO : ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_NIO, Validators.GT_ZERO); + int journalBufferSize = getTextBytesAsIntBytes(e, "journal-buffer-size", config.getJournalType() == JournalType.ASYNCIO ? ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_AIO : ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_NIO, Validators.POSITIVE_INT); Review comment: change was not needed here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297243) Time Spent: 4h 10m (was: 4h) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297242=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297242
]
ASF GitHub Bot logged work on ARTEMIS-2450:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 16:09
Start Date: 19/Aug/19 16:09
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315289391
##
File path:
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java
##
@@ -364,7 +364,7 @@ public void testDefaults() {
assertEquals("a2.2",
conf.getAddressesSettings().get("a2").getExpiryAddress().toString());
assertEquals(5,
conf.getAddressesSettings().get("a2").getRedeliveryDelay());
assertEquals(932489234928324L,
conf.getAddressesSettings().get("a2").getMaxSizeBytes());
- assertEquals(7126716262626L,
conf.getAddressesSettings().get("a2").getPageSizeBytes());
+ assertEquals(712671626L,
conf.getAddressesSettings().get("a2").getPageSizeBytes());
Review comment:
should now be int, no need for L
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297242)
Time Spent: 4h (was: 3h 50m)
> page-size-bytes should not be greater than Integer.MAX_VALUE
>
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297246 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 16:09 Start Date: 19/Aug/19 16:09 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315288710 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -1756,17 +1758,17 @@ private void parseClusterConnectionConfiguration(final Element e, final Configur double retryIntervalMultiplier = getDouble(e, "retry-interval-multiplier", ActiveMQDefaultConfiguration.getDefaultClusterRetryIntervalMultiplier(), Validators.GT_ZERO); - int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.GT_ZERO); + int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.POSITIVE_INT); long maxRetryInterval = getLong(e, "max-retry-interval", ActiveMQDefaultConfiguration.getDefaultClusterMaxRetryInterval(), Validators.GT_ZERO); int initialConnectAttempts = getInteger(e, "initial-connect-attempts", ActiveMQDefaultConfiguration.getDefaultClusterInitialConnectAttempts(), Validators.MINUS_ONE_OR_GE_ZERO); int reconnectAttempts = getInteger(e, "reconnect-attempts", ActiveMQDefaultConfiguration.getDefaultClusterReconnectAttempts(), Validators.MINUS_ONE_OR_GE_ZERO); - int confirmationWindowSize = getTextBytesAsIntBytes(e, "confirmation-window-size", ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(), Validators.GT_ZERO); + int confirmationWindowSize = getTextBytesAsIntBytes(e, "confirmation-window-size", ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(), Validators.POSITIVE_INT); Review comment: revert not needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297246) Time Spent: 4.5h (was: 4h 20m) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297245=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297245 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 16:09 Start Date: 19/Aug/19 16:09 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315288862 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -1756,17 +1758,17 @@ private void parseClusterConnectionConfiguration(final Element e, final Configur double retryIntervalMultiplier = getDouble(e, "retry-interval-multiplier", ActiveMQDefaultConfiguration.getDefaultClusterRetryIntervalMultiplier(), Validators.GT_ZERO); - int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.GT_ZERO); + int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.POSITIVE_INT); long maxRetryInterval = getLong(e, "max-retry-interval", ActiveMQDefaultConfiguration.getDefaultClusterMaxRetryInterval(), Validators.GT_ZERO); int initialConnectAttempts = getInteger(e, "initial-connect-attempts", ActiveMQDefaultConfiguration.getDefaultClusterInitialConnectAttempts(), Validators.MINUS_ONE_OR_GE_ZERO); int reconnectAttempts = getInteger(e, "reconnect-attempts", ActiveMQDefaultConfiguration.getDefaultClusterReconnectAttempts(), Validators.MINUS_ONE_OR_GE_ZERO); - int confirmationWindowSize = getTextBytesAsIntBytes(e, "confirmation-window-size", ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(), Validators.GT_ZERO); + int confirmationWindowSize = getTextBytesAsIntBytes(e, "confirmation-window-size", ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(), Validators.POSITIVE_INT); - int producerWindowSize = getTextBytesAsIntBytes(e, "producer-window-size", ActiveMQDefaultConfiguration.getDefaultBridgeProducerWindowSize(), Validators.MINUS_ONE_OR_GT_ZERO); + int producerWindowSize = getTextBytesAsIntBytes(e, "producer-window-size", ActiveMQDefaultConfiguration.getDefaultBridgeProducerWindowSize(), Validators.MINUS_ONE_OR_POSITIVE_INT); Review comment: revert not needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297245) Time Spent: 4h 20m (was: 4h 10m) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 4h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297237=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297237
]
ASF GitHub Bot logged work on ARTEMIS-2450:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 16:03
Start Date: 19/Aug/19 16:03
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315288204
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/Validators.java
##
@@ -122,6 +122,30 @@ public void validate(final String name, final Object
value) {
}
};
+ public static final Validator POSITIVE_INT = new Validator() {
+ @Override
+ public void validate(final String name, final Object value) {
+ Number val = (Number) value;
+ if (val.longValue() > 0 && val.longValue() <= Integer.MAX_VALUE) {
+// OK
+ } else {
+throw ActiveMQMessageBundle.BUNDLE.inRangeOfPositiveInt(name, val);
+ }
+ }
+ };
+
+ public static final Validator MINUS_ONE_OR_POSITIVE_INT = new Validator() {
Review comment:
again not needed, if the xsd is corrected to correct type, as it would
ensure type size bound. also ensruing xsd is correct, allows end users to use
the xsd to pre validate.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297237)
Time Spent: 3h 50m (was: 3h 40m)
> page-size-bytes should not be greater than Integer.MAX_VALUE
>
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297235=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297235 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 16:02 Start Date: 19/Aug/19 16:02 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315290001 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -597,11 +597,11 @@ public void parseMainConfig(final Element e, final Configuration config) throws config.setJournalSyncNonTransactional(getBoolean(e, "journal-sync-non-transactional", config.isJournalSyncNonTransactional())); - config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size", config.getJournalFileSize(), Validators.GT_ZERO)); + config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size", config.getJournalFileSize(), Validators.POSITIVE_INT)); Review comment: change was not needed here, int range should all be validated by xsd type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297235) Time Spent: 3.5h (was: 3h 20m) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297236=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297236
]
ASF GitHub Bot logged work on ARTEMIS-2450:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 16:02
Start Date: 19/Aug/19 16:02
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315287789
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/Validators.java
##
@@ -122,6 +122,30 @@ public void validate(final String name, final Object
value) {
}
};
+ public static final Validator POSITIVE_INT = new Validator() {
Review comment:
This isnt needed, simply change the xsd defination to int and it would fail
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297236)
Time Spent: 3h 40m (was: 3.5h)
> page-size-bytes should not be greater than Integer.MAX_VALUE
>
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297234=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297234 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 16:01 Start Date: 19/Aug/19 16:01 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315289774 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -597,11 +597,11 @@ public void parseMainConfig(final Element e, final Configuration config) throws config.setJournalSyncNonTransactional(getBoolean(e, "journal-sync-non-transactional", config.isJournalSyncNonTransactional())); - config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size", config.getJournalFileSize(), Validators.GT_ZERO)); + config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size", config.getJournalFileSize(), Validators.POSITIVE_INT)); int journalBufferTimeout = getInteger(e, "journal-buffer-timeout", config.getJournalType() == JournalType.ASYNCIO ? ArtemisConstants.DEFAULT_JOURNAL_BUFFER_TIMEOUT_AIO : ArtemisConstants.DEFAULT_JOURNAL_BUFFER_TIMEOUT_NIO, Validators.GE_ZERO); - int journalBufferSize = getTextBytesAsIntBytes(e, "journal-buffer-size", config.getJournalType() == JournalType.ASYNCIO ? ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_AIO : ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_NIO, Validators.GT_ZERO); + int journalBufferSize = getTextBytesAsIntBytes(e, "journal-buffer-size", config.getJournalType() == JournalType.ASYNCIO ? ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_AIO : ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_NIO, Validators.POSITIVE_INT); Review comment: change was not needed here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297234) Time Spent: 3h 20m (was: 3h 10m) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297232=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297232
]
ASF GitHub Bot logged work on ARTEMIS-2450:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 16:01
Start Date: 19/Aug/19 16:01
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315289391
##
File path:
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java
##
@@ -364,7 +364,7 @@ public void testDefaults() {
assertEquals("a2.2",
conf.getAddressesSettings().get("a2").getExpiryAddress().toString());
assertEquals(5,
conf.getAddressesSettings().get("a2").getRedeliveryDelay());
assertEquals(932489234928324L,
conf.getAddressesSettings().get("a2").getMaxSizeBytes());
- assertEquals(7126716262626L,
conf.getAddressesSettings().get("a2").getPageSizeBytes());
+ assertEquals(712671626L,
conf.getAddressesSettings().get("a2").getPageSizeBytes());
Review comment:
should now be int, no need for L
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297232)
Time Spent: 3h 10m (was: 3h)
> page-size-bytes should not be greater than Integer.MAX_VALUE
>
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297231=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297231 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 15:59 Start Date: 19/Aug/19 15:59 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315288862 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -1756,17 +1758,17 @@ private void parseClusterConnectionConfiguration(final Element e, final Configur double retryIntervalMultiplier = getDouble(e, "retry-interval-multiplier", ActiveMQDefaultConfiguration.getDefaultClusterRetryIntervalMultiplier(), Validators.GT_ZERO); - int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.GT_ZERO); + int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.POSITIVE_INT); long maxRetryInterval = getLong(e, "max-retry-interval", ActiveMQDefaultConfiguration.getDefaultClusterMaxRetryInterval(), Validators.GT_ZERO); int initialConnectAttempts = getInteger(e, "initial-connect-attempts", ActiveMQDefaultConfiguration.getDefaultClusterInitialConnectAttempts(), Validators.MINUS_ONE_OR_GE_ZERO); int reconnectAttempts = getInteger(e, "reconnect-attempts", ActiveMQDefaultConfiguration.getDefaultClusterReconnectAttempts(), Validators.MINUS_ONE_OR_GE_ZERO); - int confirmationWindowSize = getTextBytesAsIntBytes(e, "confirmation-window-size", ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(), Validators.GT_ZERO); + int confirmationWindowSize = getTextBytesAsIntBytes(e, "confirmation-window-size", ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(), Validators.POSITIVE_INT); - int producerWindowSize = getTextBytesAsIntBytes(e, "producer-window-size", ActiveMQDefaultConfiguration.getDefaultBridgeProducerWindowSize(), Validators.MINUS_ONE_OR_GT_ZERO); + int producerWindowSize = getTextBytesAsIntBytes(e, "producer-window-size", ActiveMQDefaultConfiguration.getDefaultBridgeProducerWindowSize(), Validators.MINUS_ONE_OR_POSITIVE_INT); Review comment: revert not needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297231) Time Spent: 3h (was: 2h 50m) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297229=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297229 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 15:59 Start Date: 19/Aug/19 15:59 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315288606 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -1756,17 +1758,17 @@ private void parseClusterConnectionConfiguration(final Element e, final Configur double retryIntervalMultiplier = getDouble(e, "retry-interval-multiplier", ActiveMQDefaultConfiguration.getDefaultClusterRetryIntervalMultiplier(), Validators.GT_ZERO); - int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.GT_ZERO); + int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.POSITIVE_INT); Review comment: revert, not needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297229) Time Spent: 2h 40m (was: 2.5h) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297230=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297230 ] ASF GitHub Bot logged work on ARTEMIS-2450: --- Author: ASF GitHub Bot Created on: 19/Aug/19 15:59 Start Date: 19/Aug/19 15:59 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315288710 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -1756,17 +1758,17 @@ private void parseClusterConnectionConfiguration(final Element e, final Configur double retryIntervalMultiplier = getDouble(e, "retry-interval-multiplier", ActiveMQDefaultConfiguration.getDefaultClusterRetryIntervalMultiplier(), Validators.GT_ZERO); - int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.GT_ZERO); + int minLargeMessageSize = getTextBytesAsIntBytes(e, "min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE, Validators.POSITIVE_INT); long maxRetryInterval = getLong(e, "max-retry-interval", ActiveMQDefaultConfiguration.getDefaultClusterMaxRetryInterval(), Validators.GT_ZERO); int initialConnectAttempts = getInteger(e, "initial-connect-attempts", ActiveMQDefaultConfiguration.getDefaultClusterInitialConnectAttempts(), Validators.MINUS_ONE_OR_GE_ZERO); int reconnectAttempts = getInteger(e, "reconnect-attempts", ActiveMQDefaultConfiguration.getDefaultClusterReconnectAttempts(), Validators.MINUS_ONE_OR_GE_ZERO); - int confirmationWindowSize = getTextBytesAsIntBytes(e, "confirmation-window-size", ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(), Validators.GT_ZERO); + int confirmationWindowSize = getTextBytesAsIntBytes(e, "confirmation-window-size", ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(), Validators.POSITIVE_INT); Review comment: revert not needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297230) Time Spent: 2h 50m (was: 2h 40m) > page-size-bytes should not be greater than Integer.MAX_VALUE > > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297228=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297228
]
ASF GitHub Bot logged work on ARTEMIS-2450:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 15:58
Start Date: 19/Aug/19 15:58
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315288204
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/Validators.java
##
@@ -122,6 +122,30 @@ public void validate(final String name, final Object
value) {
}
};
+ public static final Validator POSITIVE_INT = new Validator() {
+ @Override
+ public void validate(final String name, final Object value) {
+ Number val = (Number) value;
+ if (val.longValue() > 0 && val.longValue() <= Integer.MAX_VALUE) {
+// OK
+ } else {
+throw ActiveMQMessageBundle.BUNDLE.inRangeOfPositiveInt(name, val);
+ }
+ }
+ };
+
+ public static final Validator MINUS_ONE_OR_POSITIVE_INT = new Validator() {
Review comment:
again not needed, if the xsd (schema is corrected)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297228)
Time Spent: 2.5h (was: 2h 20m)
> page-size-bytes should not be greater than Integer.MAX_VALUE
>
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE
[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297227=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297227
]
ASF GitHub Bot logged work on ARTEMIS-2450:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 15:57
Start Date: 19/Aug/19 15:57
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315287789
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/Validators.java
##
@@ -122,6 +122,30 @@ public void validate(final String name, final Object
value) {
}
};
+ public static final Validator POSITIVE_INT = new Validator() {
Review comment:
This isnt needed, simply change the xsd to int and it would fail
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297227)
Time Spent: 2h 20m (was: 2h 10m)
> page-size-bytes should not be greater than Integer.MAX_VALUE
>
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[
https://issues.apache.org/jira/browse/ARTEMIS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Bish updated ARTEMIS-2437:
--
Fix Version/s: 2.10.0
> AMQP message conversion fails if annotations contain values outwith simple
> property types
> -
>
> Key: ARTEMIS-2437
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2437
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.9.0
>Reporter: Jiri Daněk
>Assignee: Timothy Bish
>Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> {noformat}
> $ bin/artemis browser --destination example
> Consumer:: filter = null
> Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages
> [...]
> Consumer ActiveMQQueue[example], thread=0 browsing Alert!!!
> Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages
> Consumer ActiveMQQueue[example], thread=0 Browser thread finished
> {noformat}
> In fact, there is 5 messages in the queue, and probably when browsing last
> one, the following error is printed to broker stdout.
> {noformat}
> 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server]
> AMQ224046: Exception while browser handled from
> Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627,
> address=example, size=121, applicationProperties=null,
> properties=Properties{messageId=null, userId=null, to='null', subject='null',
> replyTo='null', correlationId=null, contentType=null, contentEncoding=null,
> absoluteExpiryTime=null, creationTime=null, groupId='null',
> groupSequence=null, replyToGroupId='null'}, extraProperties =
> TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class
> java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_212]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_212]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [artemis-commons-2.9.0.jar:2.9.0]
> Caused by:
> org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException:
> class java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1014)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1030)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:53)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.reader.MessageUtil.setObjectProperty(MessageUtil.java:262)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.protocol.amqp.converter.jms.ServerJMSMessage.setObjectProperty(ServerJMSMessage.java:345)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.protocol.amqp.converter.AmqpCoreConverter.setProperty(AmqpCoreConverter.java:441)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
>
[jira] [Resolved] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[
https://issues.apache.org/jira/browse/ARTEMIS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Bish resolved ARTEMIS-2437.
---
Resolution: Fixed
This should now be fixed on master
> AMQP message conversion fails if annotations contain values outwith simple
> property types
> -
>
> Key: ARTEMIS-2437
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2437
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.9.0
>Reporter: Jiri Daněk
>Assignee: Timothy Bish
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> {noformat}
> $ bin/artemis browser --destination example
> Consumer:: filter = null
> Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages
> [...]
> Consumer ActiveMQQueue[example], thread=0 browsing Alert!!!
> Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages
> Consumer ActiveMQQueue[example], thread=0 Browser thread finished
> {noformat}
> In fact, there is 5 messages in the queue, and probably when browsing last
> one, the following error is printed to broker stdout.
> {noformat}
> 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server]
> AMQ224046: Exception while browser handled from
> Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627,
> address=example, size=121, applicationProperties=null,
> properties=Properties{messageId=null, userId=null, to='null', subject='null',
> replyTo='null', correlationId=null, contentType=null, contentEncoding=null,
> absoluteExpiryTime=null, creationTime=null, groupId='null',
> groupSequence=null, replyToGroupId='null'}, extraProperties =
> TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class
> java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_212]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_212]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [artemis-commons-2.9.0.jar:2.9.0]
> Caused by:
> org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException:
> class java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1014)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1030)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:53)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.reader.MessageUtil.setObjectProperty(MessageUtil.java:262)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.protocol.amqp.converter.jms.ServerJMSMessage.setObjectProperty(ServerJMSMessage.java:345)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.protocol.amqp.converter.AmqpCoreConverter.setProperty(AmqpCoreConverter.java:441)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
>
[jira] [Commented] (ARTEMIS-2368) Fix races on closing consumer
[ https://issues.apache.org/jira/browse/ARTEMIS-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910501#comment-16910501 ] ASF subversion and git services commented on ARTEMIS-2368: -- Commit 448449c88e33bf189482df0c3b722ced4f0a9d31 in activemq-artemis's branch refs/heads/master from yang wei [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=448449c ] ARTEMIS-2368 Fix races on closing consumer > Fix races on closing consumer > - > > Key: ARTEMIS-2368 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2368 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: yangwei >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > There are some race conditions between closing consumer and session failover: > # When sending SessionConsumerCloseMessage timeout, conn::fail() is called > resulting in current consumer is recreated on server side again but removed > on client side. > # Between SessionConsumerCloseMessage sending and session::removeConsume(), > session failover happens resulting in consumer inconsistency. > # When an iteration over the consumers entrySet is made to recreate consumer > during session failover process, consumer::close() is called, maybe leading > to consumer inconsistency or ConcurrentModificationException thrown. > We traverse through the cloned consumers entrySet, add synchronized block and > check if consumer is closed while recreating consumer to fix the issue. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2368) Fix races on closing consumer
[ https://issues.apache.org/jira/browse/ARTEMIS-2368?focusedWorklogId=297225=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297225 ] ASF GitHub Bot logged work on ARTEMIS-2368: --- Author: ASF GitHub Bot Created on: 19/Aug/19 15:50 Start Date: 19/Aug/19 15:50 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2693: ARTEMIS-2368 Fix races on closing consumer URL: https://github.com/apache/activemq-artemis/pull/2693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297225) Time Spent: 20m (was: 10m) > Fix races on closing consumer > - > > Key: ARTEMIS-2368 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2368 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: yangwei >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > There are some race conditions between closing consumer and session failover: > # When sending SessionConsumerCloseMessage timeout, conn::fail() is called > resulting in current consumer is recreated on server side again but removed > on client side. > # Between SessionConsumerCloseMessage sending and session::removeConsume(), > session failover happens resulting in consumer inconsistency. > # When an iteration over the consumers entrySet is made to recreate consumer > during session failover process, consumer::close() is called, maybe leading > to consumer inconsistency or ConcurrentModificationException thrown. > We traverse through the cloned consumers entrySet, add synchronized block and > check if consumer is closed while recreating consumer to fix the issue. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (ARTEMIS-2407) Large message file not deleted if broker crashes between page deleted and pending large message written
[ https://issues.apache.org/jira/browse/ARTEMIS-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910498#comment-16910498 ] ASF subversion and git services commented on ARTEMIS-2407: -- Commit e537fbfde06a5a09ef369401e715970c4003bd32 in activemq-artemis's branch refs/heads/master from yang wei [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=e537fbf ] ARTEMIS-2407 Large message file not deleted if broker crashes between page deleted and pending large message written > Large message file not deleted if broker crashes between page deleted and > pending large message written > --- > > Key: ARTEMIS-2407 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2407 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: yangwei >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > In paging mode, when the broker crashes between page file is deleted and > pending large message is written into disk, the large message file would > never be deleted after startup. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2407) Large message file not deleted if broker crashes between page deleted and pending large message written
[ https://issues.apache.org/jira/browse/ARTEMIS-2407?focusedWorklogId=297223=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297223 ] ASF GitHub Bot logged work on ARTEMIS-2407: --- Author: ASF GitHub Bot Created on: 19/Aug/19 15:47 Start Date: 19/Aug/19 15:47 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2738: ARTEMIS-2407 Large message file not deleted if broker crashes between page deleted and pending large message written URL: https://github.com/apache/activemq-artemis/pull/2738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297223) Time Spent: 0.5h (was: 20m) > Large message file not deleted if broker crashes between page deleted and > pending large message written > --- > > Key: ARTEMIS-2407 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2407 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: yangwei >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > In paging mode, when the broker crashes between page file is deleted and > pending large message is written into disk, the large message file would > never be deleted after startup. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2399) Improve performance when there are a lot of subscribers
[ https://issues.apache.org/jira/browse/ARTEMIS-2399?focusedWorklogId=297222=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297222 ] ASF GitHub Bot logged work on ARTEMIS-2399: --- Author: ASF GitHub Bot Created on: 19/Aug/19 15:44 Start Date: 19/Aug/19 15:44 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297222) Time Spent: 18h 40m (was: 18.5h) > Improve performance when there are a lot of subscribers > --- > > Key: ARTEMIS-2399 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2399 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.9.0 > Environment: broker 2.9.0 > cpu: 4 cores, memory: 8G, disk: ssd 500G > broker.xml: > 60 > > 51Mb > 50Mb > 1 > PAGE > > -1 >Reporter: yangwei >Priority: Major > Time Spent: 18h 40m > Remaining Estimate: 0h > > We noticed that there was a significant drop in performance when entering > page mode in the case of multiple subscribers. > We created a topic and 100 queues bound to it. We ran our _GrinderRunner > test_ in our inner test infra cluster with 500 threads producing message and > 560 threads, each one picked a random queue to subscribe. The test showed > performance is bad: 13000 msg/s sent and 5000 msg/s received. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (ARTEMIS-2399) Improve performance when there are a lot of subscribers
[ https://issues.apache.org/jira/browse/ARTEMIS-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910494#comment-16910494 ] ASF subversion and git services commented on ARTEMIS-2399: -- Commit 76d420590fa73aefb41713a5589dcec22588c594 in activemq-artemis's branch refs/heads/master from yang wei [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=76d4205 ] ARTEMIS-2399 Improve performance when there are a lot of subscribers > Improve performance when there are a lot of subscribers > --- > > Key: ARTEMIS-2399 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2399 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.9.0 > Environment: broker 2.9.0 > cpu: 4 cores, memory: 8G, disk: ssd 500G > broker.xml: > 60 > > 51Mb > 50Mb > 1 > PAGE > > -1 >Reporter: yangwei >Priority: Major > Time Spent: 18.5h > Remaining Estimate: 0h > > We noticed that there was a significant drop in performance when entering > page mode in the case of multiple subscribers. > We created a topic and 100 queues bound to it. We ran our _GrinderRunner > test_ in our inner test infra cluster with 500 threads producing message and > 560 threads, each one picked a random queue to subscribe. The test showed > performance is bad: 13000 msg/s sent and 5000 msg/s received. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2442) throw ActiveMQResourceLimitException if session/queue limit is reached
[
https://issues.apache.org/jira/browse/ARTEMIS-2442?focusedWorklogId=297024=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297024
]
ASF GitHub Bot logged work on ARTEMIS-2442:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 06:07
Start Date: 19/Aug/19 06:07
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2785:
ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is
reached
URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r315049421
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQExceptionType.java
##
@@ -261,6 +261,12 @@ public ActiveMQException createException(String msg) {
public ActiveMQException createException(String msg) {
return new ActiveMQReplicationTimeooutException(msg);
}
+ },
+ RESOURCE_LIMIT_REACHED(221) {
Review comment:
Point here just because theyre catching the base doesnt mean everyone is
By changing the exception should try make it a extended of the current so
people dont get any shock changes in their error handling logic.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297024)
Time Spent: 1.5h (was: 1h 20m)
> throw ActiveMQResourceLimitException if session/queue limit is reached
> --
>
> Key: ARTEMIS-2442
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2442
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: yangwei
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Now ActiveMQSessionCreationException is thrown when session/queue limit is
> reached. ActiveMQSessionCreationException is used to indicate server is
> starting. It would cause session recreation retries all the time. Session
> creation should fail fast when limit is reached so client can try to connect
> other brokers in cluster.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
