[jira] [Work logged] (ARTEMIS-4731) Openwire failure detection leak with Windows Clients / Server won't cleanup openwork clients with Exception

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4731?focusedWorklogId=915439=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915439
 ]

ASF GitHub Bot logged work on ARTEMIS-4731:
---

Author: ASF GitHub Bot
Created on: 19/Apr/24 04:57
Start Date: 19/Apr/24 04:57
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4895:
URL: https://github.com/apache/activemq-artemis/pull/4895




Issue Time Tracking
---

Worklog Id: (was: 915439)
Time Spent: 20m  (was: 10m)

> Openwire failure detection leak with Windows Clients / Server won't cleanup 
> openwork clients with Exception
> ---
>
> Key: ARTEMIS-4731
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4731
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The OpenWireServerConnection won't deal properly with Exceptions raised by 
> Netty.
> Windows clients will send a different signal to the server causing the 
> connection to throw an exception rather than issue a disconnect, 
> As a result some objects are being left on the heap as transport.close() is 
> not being called.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ARTEMIS-4731) Openwire failure detection leak with Windows Clients / Server won't cleanup openwork clients with Exception

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838855#comment-17838855
 ] 

ASF subversion and git services commented on ARTEMIS-4731:
--

Commit 6fe53b813a0e958b73ea3e703bad7b0c892e6044 in activemq-artemis's branch 
refs/heads/main from Clebert Suconic
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=6fe53b813a ]

ARTEMIS-4731 OpenWireConnection exception listener should call 
transport.close();

this is causing a leak for server objects


> Openwire failure detection leak with Windows Clients / Server won't cleanup 
> openwork clients with Exception
> ---
>
> Key: ARTEMIS-4731
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4731
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The OpenWireServerConnection won't deal properly with Exceptions raised by 
> Netty.
> Windows clients will send a different signal to the server causing the 
> connection to throw an exception rather than issue a disconnect, 
> As a result some objects are being left on the heap as transport.close() is 
> not being called.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4731) Openwire failure detection leak with Windows Clients / Server won't cleanup openwork clients with Exception

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4731?focusedWorklogId=915413=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915413
 ]

ASF GitHub Bot logged work on ARTEMIS-4731:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 22:17
Start Date: 18/Apr/24 22:17
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4895:
URL: https://github.com/apache/activemq-artemis/pull/4895

   …ort.close();
   
   this is causing a leak for server objects




Issue Time Tracking
---

Worklog Id: (was: 915413)
Remaining Estimate: 0h
Time Spent: 10m

> Openwire failure detection leak with Windows Clients / Server won't cleanup 
> openwork clients with Exception
> ---
>
> Key: ARTEMIS-4731
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4731
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The OpenWireServerConnection won't deal properly with Exceptions raised by 
> Netty.
> Windows clients will send a different signal to the server causing the 
> connection to throw an exception rather than issue a disconnect, 
> As a result some objects are being left on the heap as transport.close() is 
> not being called.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (ARTEMIS-4731) Openwire failure detection leak with Windows Clients / Server won't cleanup openwork clients with Exception

[Clebert Suconic (Jira)]

Clebert Suconic created ARTEMIS-4731:


 Summary: Openwire failure detection leak with Windows Clients / 
Server won't cleanup openwork clients with Exception
 Key: ARTEMIS-4731
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4731
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 2.33.0
Reporter: Clebert Suconic
 Fix For: 2.34.0


The OpenWireServerConnection won't deal properly with Exceptions raised by 
Netty.

Windows clients will send a different signal to the server causing the 
connection to throw an exception rather than issue a disconnect, 

As a result some objects are being left on the heap as transport.close() is not 
being called.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ARTEMIS-4723) org.apache.activemq.artemis.utils.actors.Handler$Counter left on the ThreadLocal

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838770#comment-17838770
 ] 

ASF subversion and git services commented on ARTEMIS-4723:
--

Commit 69f68691574bb2d5f9c5b8f3fcf6ec4f1b0dc59d in activemq-artemis's branch 
refs/heads/openwire-fix from Clebert Suconic
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=69f6869157 ]

ARTEMIS-4723 Optimization on HandlerBase

No need to create a new instance every time the processor starts executing.
The instance of counter can be reused and stored in the Thread.


> org.apache.activemq.artemis.utils.actors.Handler$Counter left on the 
> ThreadLocal
> 
>
> Key: ARTEMIS-4723
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4723
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> org.apache.activemq.artemis.utils.actors.Handler$Counter is left on the 
> ThreadLocal.
> This is used to verify if the execution is InHander.
> The object could be removed after done. So it's not a growing leak (meaning 
> it will keep growing), but it's an unnecessary allocation that can be avoided.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915358=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915358
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 17:23
Start Date: 18/Apr/24 17:23
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1571109296


##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Apache ActiveMQ Artemis Console Plugin
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 

Review Comment:
   Name seems off



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Apache ActiveMQ Artemis Console Plugin
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project 'artemis-console-extension' can take time, so if 
you build it once and make no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploys the plugin WAR application. From the 
'artemis-console-war' directory run:
+
+```console
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 

+
+## Faster plugin development
+
+You could run `mvn install` or `mvn jetty:run` every time to incrementally 
develop the `activemq-artemis-console` 
+frontend project while checking its behaviour in the browser. But this is not 
suitable for running the fast development feedback cycle.
+
+As shown below, a faster development cycle can be achieved by directly running 
the `activemq-artemis-console-plugin` 

Review Comment:
   another plugin mention



##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,110 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (ARTEMIS-4730) Allow for custom slow consumer detection logic

[Josh Byster (Jira)]

Josh Byster created ARTEMIS-4730:


 Summary: Allow for custom slow consumer detection logic
 Key: ARTEMIS-4730
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4730
 Project: ActiveMQ Artemis
  Issue Type: New Feature
Reporter: Josh Byster


Currently, the slow consumer detection logic works well if there are producers 
and consumers sending messages at a rather consistent rate. It does not handle 
the case well when messages are sent infrequently and sporadically given that 
it does no amortization of consumption rates. 

Rather than trying to account for all cases in the single slow consumer 
detection algorithm, I propose a plugin-like approach that allows one to 
specify some form of a predicate to deem a consumer slow or not. This also 
allows us to dynamically start and stop slow consumer logic, which is nice if 
we want to only enable this behavior if the broker is nearing OOM. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Reopened] (ARTEMIS-137) Replace JBoss Logging by SLF4J

[Justin Bertram (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram reopened ARTEMIS-137:


> Replace JBoss Logging by SLF4J
> --
>
> Key: ARTEMIS-137
> URL: https://issues.apache.org/jira/browse/ARTEMIS-137
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>
> nice to support i18n



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (ARTEMIS-137) Replace JBoss Logging by SLF4J

[Justin Bertram (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram closed ARTEMIS-137.
--
Resolution: Duplicate

> Replace JBoss Logging by SLF4J
> --
>
> Key: ARTEMIS-137
> URL: https://issues.apache.org/jira/browse/ARTEMIS-137
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>
> nice to support i18n



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (ARTEMIS-3126) please do not force jboss-logmanager on users

[Justin Bertram (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-3126.
-
Resolution: Duplicate

> please do not force jboss-logmanager on users
> -
>
> Key: ARTEMIS-3126
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3126
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.14.0
>Reporter: Stuart Halloway
>Priority: Minor
>
> I have maintained a codebase using ActiveMQ since the HornetQ days. It has 
> been terrific for both stability and performance.
> Every once in a while I have to upgrade dependencies, mostly due to security 
> advisories. On the latest upgrade, I found that ActiveMQ now "sort of" 
> compels users to choose JBoss logging. In particular, the server dependency 
> on jboss-logmanager causes users of any other logging library to encounter 
> this [JBoss 
> error.|https://github.com/jboss-logging/jboss-logmanager/blob/master/core/src/main/java9/org/jboss/logmanager/JBossLoggerFinder.java#L68-L74]
>  This error is difficult to avoid, since it will happen the first time code 
> in any library tries to get a j.u.logger. 
> I do not want or need jboss logging, and I cannot force it on my users. 
> ActiveMQ doesn't seem to really need it either - if I maven exclude 
> jboss-logmanager from ActiveMQ my test suite passes, logging via slf4j. This 
> strongly suggests that jboss-logmanager is needed only in some contexts.
> Thanks for ActiveMQ!  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ARTEMIS-4420) User authentication leaks into non-Artemis servlets

[Doug Whitfield (Jira)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838682#comment-17838682
 ] 

Doug Whitfield commented on ARTEMIS-4420:
-

Hi Team,

This is still an issue in 2.31. Is there any additional information we should 
provide to help move this forward?

> User authentication leaks into non-Artemis servlets
> ---
>
> Key: ARTEMIS-4420
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4420
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.30.0
>Reporter: Dries Harnie
>Priority: Minor
>
> ActiveMQ Artemis supports audit logs, which log all administrative actions 
> that happen on the broker.
> These logs identify the "current user" for an administrative access [by one 
> of two 
> methods|https://github.com/apache/activemq-artemis/blob/main/artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AuditLogger.java#L67-L73]:
>  # The {{Subject}} associated with the current security manager context, or
>  # A {{{}ThreadLocal{}}}, which is set by JolokiaFilter as part of 
> interaction with the admin console.
> For a non-Artemis servlet such as [the metrics 
> plugin|https://github.com/rh-messaging/artemis-prometheus-metrics-plugin], 
> this {{ThreadLocal}} is set to whatever {{Subject}} made the previous request 
> on this thread. This leads to situations where metric accesses are logged as 
> being done by ghost users.
> To reproduce the issue:
>  # Set up Artemis with the default admin/admin user and [the metrics 
> plugin|https://github.com/rh-messaging/artemis-prometheus-metrics-plugin].
>  # Enable audit logging ({{{}logger.audit_base{}}} should be at {{INFO}} 
> level)
>  # Tail -f the audit log and start the server
>  # Log in to the admin console
>  # Observe that a lot of audit logs fly by for {*}admin(amq)@127.0.0.1{*}.
>  # Access the metrics with eg {{{}curl http://localhost:8161/metrics/{}}}.
>  # Observe that a lot of audit logs fly by for {*}admin(amq)@127.0.0.1{*}, 
> even though these requests are completely anonymous.
>  
> I think the solution involves a modification to 
> {{org.apache.activemq.artemis.component.JolokiaFilter}} but I do not 
> understand the purpose of the code after the {{doFilter}} invocation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915326=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915326
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 14:41
Start Date: 18/Apr/24 14:41
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570901599


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   Sounds good, that would be my preference also.





Issue Time Tracking
---

Worklog Id: (was: 915326)
Time Spent: 6h  (was: 5h 50m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 6h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-6135) ActiveMQ HTTP module should support Openwire serialisation

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6135?focusedWorklogId=915325=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915325
 ]

ASF GitHub Bot logged work on AMQ-6135:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 14:39
Start Date: 18/Apr/24 14:39
Worklog Time Spent: 10m 
  Work Description: mattrpav commented on PR #165:
URL: https://github.com/apache/activemq/pull/165#issuecomment-2064045896

   > ` http://0.0.0.0:1234?openwireSerializatrionEnabled=true; />`
   
   or perhaps a wireformat.type=[xstream | openwire], etc.
   
   I think it would be good to deprecate xstream and either update the openwire 
generator to include XML marshaling, or just favor openwire over http.




Issue Time Tracking
---

Worklog Id: (was: 915325)
Time Spent: 40m  (was: 0.5h)

> ActiveMQ HTTP module should support Openwire serialisation
> --
>
> Key: AMQ-6135
> URL: https://issues.apache.org/jira/browse/AMQ-6135
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>  Components: Transport
>Reporter: Przemek Bruski
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915319=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915319
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 14:21
Start Date: 18/Apr/24 14:21
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570867354


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   I will use artemis-console-extension as this is actually what it is. I think 
artemis-console-war is fine, starting at a 1.0.0 seems the right thing to do.





Issue Time Tracking
---

Worklog Id: (was: 915319)
Time Spent: 5h 50m  (was: 5h 40m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915297=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915297
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 12:18
Start Date: 18/Apr/24 12:18
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570614130


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   Renaming artemis-console-war to artemis-console would be less strange 
though, since both are wars people might referencebut again we would need 
to use a higher version than will ever be used for the existing war. Which then 
initially might have a broker-versioned number by coincidence and diverge later.





Issue Time Tracking
---

Worklog Id: (was: 915297)
Time Spent: 5.5h  (was: 5h 20m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915298=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915298
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 12:18
Start Date: 18/Apr/24 12:18
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570614130


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   Renaming `artemis-console-war` to `artemis-console` would be less strange 
though, since both are wars people might referencebut again we would need 
to use a higher version than will ever be used for the existing war. Which then 
initially might have a broker-versioned number by coincidence and diverge later.





Issue Time Tracking
---

Worklog Id: (was: 915298)
Time Spent: 5h 40m  (was: 5.5h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915294=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915294
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 12:12
Start Date: 18/Apr/24 12:12
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570604745


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   As before, we should probably avoid artemis-console, because it does clash, 
and though its only a pom it is still going to be published.
   
   We cant 'go backwards' for versions as it creates a significant reporting 
problem for bugs and CVEs around what is/isnt affected...there are also many 
newer broker-versioned released of an 'artemis-console' that already exist with 
a higher version, so we would never be able to use those versions and would 
have a right mess when that time came. The only way we can use artemis-console 
as a module would be to start this repo's releases at a version above the range 
that will ever be occupied by those still-ongoing releases of the existing 
artemis-console module.  
https://repo1.maven.org/maven2/org/apache/activemq/artemis-console/
   
   Since it is really a different artifact entirely, that is not actually 
having any jar etc deployed for it (unlike previously), and is being released 
independently of the broker going forward and so wont use matching 
broker-versions...just avoiding the already-used artemis-console name seems to 
make more sense than version foolery. Someone today might reference 
artemis-console as a module...it doesnt seem like anyone should want to in 
future., however they might be confused into by reuse of the module name for 
something different than before.
   
   My comment was that it doesnt really matter what we call it, as its just a 
pom for doing some local build, and not a module users will refer to...what 
about artemis-console-build? artemis-console-extension?





Issue Time Tracking
---

Worklog Id: (was: 915294)
Time Spent: 5h 10m  (was: 5h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915295=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915295
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 12:12
Start Date: 18/Apr/24 12:12
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570604745


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   As before, we should probably avoid `artemis-console`, because it does 
clash, and though its only a pom it is still going to be published.
   
   We cant 'go backwards' for versions as it creates a significant reporting 
problem for bugs and CVEs around what is/isnt affected...there are also many 
newer broker-versioned released of an '`artemis-console`' that already exist 
with a higher version, so we would never be able to use those versions and 
would have a right mess when that time came. The only way we can use 
`artemis-console` as a module would be to start this repo's releases at a 
version above the range that will ever be occupied by those still-ongoing 
releases of the existing `artemis-console` module.  
https://repo1.maven.org/maven2/org/apache/activemq/artemis-console/
   
   Since it is really a different artifact entirely, that is not actually 
having any jar etc deployed for it (unlike previously), and is being released 
independently of the broker going forward and so wont use matching 
broker-versions...just avoiding the already-used `artemis-console` name seems 
to make more sense than version foolery. Someone today might reference 
`artemis-console` as a module...it doesnt seem like anyone should want to in 
future., however they might be confused into by reuse of the module name for 
something different than before.
   
   My comment was that it doesnt really matter what we call it, as its just a 
pom for doing some local build, and not a module users will refer to...what 
about `artemis-console-build`? `artemis-console-extension`?





Issue Time Tracking
---

Worklog Id: (was: 915295)
Time Spent: 5h 20m  (was: 5h 10m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915288=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915288
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 11:26
Start Date: 18/Apr/24 11:26
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570522054


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   I have renamed it to artemis-console which makes more sense but will it 
still clash if we publish nothing or does the pom still get published? I could 
change it to artemis-console- hawtio, artemis-console-web or something similar. 
wdyt?





Issue Time Tracking
---

Worklog Id: (was: 915288)
Time Spent: 5h  (was: 4h 50m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915285=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915285
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 11:20
Start Date: 18/Apr/24 11:20
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570522054


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   I have renamed it to artemis-console which makes more sense but will it 
still clash if we publish nothing or does the pom still get published, I could 
change it to artemis-console- hawtio, artemis-console-web or something similar. 
wdyt?





Issue Time Tracking
---

Worklog Id: (was: 915285)
Time Spent: 4h 50m  (was: 4h 40m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915283=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915283
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 11:15
Start Date: 18/Apr/24 11:15
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570513459


##
artemis-console-war/src/main/resources/logback.xml:
##
@@ -0,0 +1,33 @@
+
+
+
+
+
+  
+  
+
+  
+
+  %d{HH:mm:ss} %level {%thread} %-30.30c{1} : %msg%n
+
+  
+
+  
+
+  
+

Review Comment:
   yes





Issue Time Tracking
---

Worklog Id: (was: 915283)
Time Spent: 4.5h  (was: 4h 20m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915284=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915284
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 11:15
Start Date: 18/Apr/24 11:15
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570513766


##
pom.xml:
##
@@ -0,0 +1,197 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+org.apache.activemq
+artemis-console-project
+pom
+1.0.0-SNAPSHOT
+
+
+org.apache
+apache
+31
+org.apache:apache
+
+
+
+artemis-console-plugin
+artemis-console-war
+artemis-console-distribution
+
+
+ActiveMQ Artemis Console Plugin
+https://activemq.apache.org/components/artemis/
+
+
+11
+11
+11
+4.0.0
+5.0.0
+2.0.11
+11.0.18
+v20.9.0
+v1.22.21
+1.15.0
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (ARTEMIS-1921) Setting client ID on core JMS should be reflected in broker RemotingConnection

[Robbie Gemmell (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved ARTEMIS-1921.
-
Fix Version/s: 2.34.0
   Resolution: Fixed

> Setting client ID on core JMS should be reflected in broker RemotingConnection
> --
>
> Key: ARTEMIS-1921
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1921
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.6.1
>Reporter: Johan Stenberg
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.34.0
>
> Attachments: Artemis1921_CoreJmsClient_SetClientId_Test.java
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As opposite to Qpid JMS Client over AMPQ1.0 or FuseSource StompJMS client 
> over STOMP, a clientID set on the JMS ConnectionFactory or the Connection in 
> the Artemis JMS Client is not available on the broker via 
> RemotingConnection#getClientID().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ARTEMIS-1921) Setting client ID on core JMS should be reflected in broker RemotingConnection

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838598#comment-17838598
 ] 

ASF subversion and git services commented on ARTEMIS-1921:
--

Commit 791630fa861f868beb3e2d778eb44f92117b0220 in activemq-artemis's branch 
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=791630fa86 ]

ARTEMIS-1921 setting client ID on core JMS should be reflected in broker 
RemotingConnection


> Setting client ID on core JMS should be reflected in broker RemotingConnection
> --
>
> Key: ARTEMIS-1921
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1921
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.6.1
>Reporter: Johan Stenberg
>Assignee: Justin Bertram
>Priority: Major
> Attachments: Artemis1921_CoreJmsClient_SetClientId_Test.java
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As opposite to Qpid JMS Client over AMPQ1.0 or FuseSource StompJMS client 
> over STOMP, a clientID set on the JMS ConnectionFactory or the Connection in 
> the Artemis JMS Client is not available on the broker via 
> RemotingConnection#getClientID().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-1921) Setting client ID on core JMS should be reflected in broker RemotingConnection

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1921?focusedWorklogId=915280=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915280
 ]

ASF GitHub Bot logged work on ARTEMIS-1921:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 10:46
Start Date: 18/Apr/24 10:46
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4887:
URL: https://github.com/apache/activemq-artemis/pull/4887




Issue Time Tracking
---

Worklog Id: (was: 915280)
Time Spent: 20m  (was: 10m)

> Setting client ID on core JMS should be reflected in broker RemotingConnection
> --
>
> Key: ARTEMIS-1921
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1921
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.6.1
>Reporter: Johan Stenberg
>Assignee: Justin Bertram
>Priority: Major
> Attachments: Artemis1921_CoreJmsClient_SetClientId_Test.java
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As opposite to Qpid JMS Client over AMPQ1.0 or FuseSource StompJMS client 
> over STOMP, a clientID set on the JMS ConnectionFactory or the Connection in 
> the Artemis JMS Client is not available on the broker via 
> RemotingConnection#getClientID().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ARTEMIS-1921) Setting client ID on core JMS should be reflected in broker RemotingConnection

[Robbie Gemmell (Jira)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838597#comment-17838597
 ] 

Robbie Gemmell commented on ARTEMIS-1921:
-

Yep, wasn't commenting on the change (hadn't looked yet) but just the earlier 
reply around why it didnt work (but doing one or the other probably did 
previously due to other oddness). Have looked at the new change now and looks 
good.

> Setting client ID on core JMS should be reflected in broker RemotingConnection
> --
>
> Key: ARTEMIS-1921
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1921
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.6.1
>Reporter: Johan Stenberg
>Assignee: Justin Bertram
>Priority: Major
> Attachments: Artemis1921_CoreJmsClient_SetClientId_Test.java
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> As opposite to Qpid JMS Client over AMPQ1.0 or FuseSource StompJMS client 
> over STOMP, a clientID set on the JMS ConnectionFactory or the Connection in 
> the Artemis JMS Client is not available on the broker via 
> RemotingConnection#getClientID().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915278=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915278
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 10:21
Start Date: 18/Apr/24 10:21
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570437951


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+   Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915277=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915277
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 10:17
Start Date: 18/Apr/24 10:17
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570432266


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+   Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915276=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915276
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 10:13
Start Date: 18/Apr/24 10:13
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570370040


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+   Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915270=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915270
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 09:34
Start Date: 18/Apr/24 09:34
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570367927


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   > > I do think we should rename the repo to 
activemq-[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console),
 how do we get that done?
   > 
   > First, discuss and agree it on the listthen if agreed, we could either 
create the new repo and then ask infra to delete this old one, or else ask if 
infra will rename this one. They might want a vote as assurance before the 
rename or delete.
   > 
   
   Ok, I will send out an email to discuss
   
   > > I did think about changing the 
[artemis-console-plugin](https://issues.apache.org/jira/browse/ARTEMIS-console-plugin)
 to [artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) 
but I thought that would clash with the 
[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) module 
currently in activemq-artemis at some point, wdyt?
   > 
   > Yeah we definitely need to avoid clashing with existing artemis module 
GAVs for anything published, which is most easily done by avoiding the same 
module name (we could play with increased versions, but...still messy when both 
are still around).
   > 
   > From what I see, it looks like the `artemis-console-plugin` module is just 
a pom that doesnt actually deploy anything except itself, and rather just 
builds stuff locally into a dir currently that other stuff then uses. So its 
name actually seems largely inconsequential, seems like noone is really likely 
to reference the deployed module itself currently (but rather, reference the 
war instead)? Or am I missing something?
   
   no you are correct
   
   





Issue Time Tracking
---

Worklog Id: (was: 915270)
Time Spent: 3h 40m  (was: 3.5h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915271=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915271
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 09:35
Start Date: 18/Apr/24 09:35
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570370040


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+   Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915269=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915269
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 09:31
Start Date: 18/Apr/24 09:31
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570361047


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   > I do think we should rename the repo to 
activemq-[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console),
 how do we get that done?
   > 
   
   First, discuss and agree it on the listthen if agreed, we could either 
create the new repo and then ask infra to delete this old one, or else ask if 
infra will rename this one. They might want a vote as assurance before the 
rename or delete.
   
   > I did think about changing the 
[artemis-console-plugin](https://issues.apache.org/jira/browse/ARTEMIS-console-plugin)
 to [artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) 
but I thought that would clash with the 
[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) module 
currently in activemq-artemis at some point, wdyt?
   
   Yeah we definitely need to avoid clashing with existing artemis module GAVs 
for anything published, which is most easily done by avoiding the same module 
name (we could play with increased versions, but...still messy when both are 
still around).
   
   From what I see, it looks like the `artemis-console-plugin` module is just a 
pom that doesnt actually deploy anything except itself, and rather just builds 
stuff locally into a dir currently that other stuff then uses. So its name 
actually seems largely inconsequential, seems like noone is really likely to 
reference the deployed module itself currently (but rather, reference the war 
instead)? Or am I missing something?
   





Issue Time Tracking
---

Worklog Id: (was: 915269)
Time Spent: 3.5h  (was: 3h 20m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915267=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915267
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 09:30
Start Date: 18/Apr/24 09:30
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570361047


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   > I do think we should rename the repo to 
activemq-[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console),
 how do we get that done?
   > 
   
   First, discuss and agree it on the listthen if agreed, we could either 
create the new repo and then ask infra to delete this old one, or else ask if 
infra will rename this one. They might want a vote as assurance before the 
rename or delete.
   
   > I did think about changing the 
[artemis-console-plugin](https://issues.apache.org/jira/browse/ARTEMIS-console-plugin)
 to [artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) 
but I thought that would clash with the 
[artemis-console](https://issues.apache.org/jira/browse/ARTEMIS-console) module 
currently in activemq-artemis at some point, wdyt?
   
   Yeah we definitely need to avoid clashing with existing artemis module GAVs 
for anything published, which is most easily done by avoiding the same module 
name (we could play with increased versions, but...still messy when both are 
still around).
   
   From what I see, it looks like the artemis-console-plugin module is just a 
pom that doesnt actually deploy anything except itself, and rather just builds 
stuff locally into a dir currently that other stuff then uses. So its name 
actually seems largely inconsequential, seems like noone is really likely to 
reference the deployed module itself currently (but rather, reference the war 
instead)? Or am I missing something?
   





Issue Time Tracking
---

Worklog Id: (was: 915267)
Time Spent: 3h 20m  (was: 3h 10m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915263=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915263
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 08:55
Start Date: 18/Apr/24 08:55
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570304328


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+   Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915254=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915254
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 08:13
Start Date: 18/Apr/24 08:13
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570229666


##
artemis-console-distribution/src/main/assembly/source-assembly.xml:
##
@@ -0,0 +1,137 @@
+
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
 http://maven.apache.org/xsd/assembly-1.1.2.xsd;>
+
+   source-release
+
+   
+  zip
+  tar.gz
+   
+
+   true
+
+   
+   Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=915253=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915253
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 18/Apr/24 07:56
Start Date: 18/Apr/24 07:56
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1570200077


##
artemis-console-distribution/pom.xml:
##
@@ -0,0 +1,86 @@
+

Review Comment:
   I do think we should rename the repo to activemq-artemis-console, how do we 
get that done?
   
   I did think about changing the artemis-console-plugin to artemis-console but 
I thought that would clash with the artemis-console module currently in 
activemq-artemis at some point, wdyt?





Issue Time Tracking
---

Worklog Id: (was: 915253)
Time Spent: 2h 50m  (was: 2h 40m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)