[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=865542=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865542 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 14/Jun/23 14:32 Start Date: 14/Jun/23 14:32 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1591339631 @SamTV12345 I had everything ready on my build locally, building the image for me would been a couple seconds... and this made everything from scratch, including downloading the entire maven artifacts somewhere. I wouldn't have a problem if this was an additional option to build the image, meaning if I want to use the "regular" way we could just do what we have been doing so far. in that sense if you could reuse the docker files as they are now, and just call the "multi-stage" build as an option.. then I would be ok... as long as it is well documented. Issue Time Tracking --- Worklog Id: (was: 865542) Time Spent: 12h 50m (was: 12h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 12h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=865359=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865359 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Jun/23 20:32 Start Date: 13/Jun/23 20:32 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1589982027 @ViliusS do you understand the advantage of multistage builds? @SamTV12345 I'm trying to understand the difference here? what's the issue with ./prepare.sh? again.. this seems moot by ./artemis-image ... did you look at it? Issue Time Tracking --- Worklog Id: (was: 865359) Time Spent: 11h 50m (was: 11h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 11h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=865369=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865369 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Jun/23 22:16 Start Date: 13/Jun/23 22:16 Worklog Time Spent: 10m Work Description: ViliusS commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1590127505 > @ViliusS do you understand the advantage of multistage builds? If you are asking in general, then yes. It's just a mechanism to separate build stage from the runtime. In this particular case I see no advantage, sorry. These dockerfiles previously were used just for runtime, by packing downloaded already built releases. So the separation was already there. Issue Time Tracking --- Worklog Id: (was: 865369) Time Spent: 12h 40m (was: 12.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 12h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=865365=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865365 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Jun/23 21:22 Start Date: 13/Jun/23 21:22 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1590043617 > it would be nice if we could chat somewhere? Slack at Apache? > > at the end of build it just hangs as it's running the brokers You can add my developer email samelus1...@outlook.de and we can go through the build process. Without any screenshots/output its hard to evaluate. Issue Time Tracking --- Worklog Id: (was: 865365) Time Spent: 12.5h (was: 12h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 12.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=865364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865364 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Jun/23 21:19 Start Date: 13/Jun/23 21:19 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1590041335 > is this making a docker official build any easier? is that the reason behind this? This turbocharges new builds. You can build all platforms in next to no time and push it to Dockerhub. It streamlines the build process. Before that you had to go through the steps in the ./prepare.sh. Then go to the sub directory, then start building dockerfiles one after the other. If I want to start the whole build that would mean 1 x prepare.sh, 5-6 times Dockerfiles with the right tags. Non parallel builds. With this approach I can build all 6 images in around 5 minutes with minimum resource usage of the maven repository. This docker compose also allows for non contributors/people new to the project build images with their known tooling docker and docker-compose. Last but not least you can simple select an image with docker composer service up. Issue Time Tracking --- Worklog Id: (was: 865364) Time Spent: 12h 20m (was: 12h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 12h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=865362=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865362 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Jun/23 21:02 Start Date: 13/Jun/23 21:02 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1590022204 it would be nice if we could chat somewhere? Slack at Apache? at the end of build it just hangs as it's running the brokers Issue Time Tracking --- Worklog Id: (was: 865362) Time Spent: 12h 10m (was: 12h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 12h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=865361=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865361 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Jun/23 20:54 Start Date: 13/Jun/23 20:54 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1590011857 is this making a docker official build any easier? is that the reason behind this? Issue Time Tracking --- Worklog Id: (was: 865361) Time Spent: 12h (was: 11h 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 12h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=865348=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865348 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Jun/23 19:35 Start Date: 13/Jun/23 19:35 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1589909137 @SamTV12345 @jbertram what is really the advantage of using this? just to avoid the prepare phase? This is doing a build all over again? The ./prepare.sh and build seemed a lot simpler to me. if you really wanted to have this committed, we could create a new folder ./artemis-distribution-multistage ... or move all the docker possibilities under a single directory. although it gets complicated with competing things.. we already have the ./artemis-image being a different OCI image by @gtully Issue Time Tracking --- Worklog Id: (was: 865348) Time Spent: 11h 40m (was: 11.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 11h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=864879=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-864879 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 12/Jun/23 05:38 Start Date: 12/Jun/23 05:38 Worklog Time Spent: 10m Work Description: ViliusS commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1586616294 > Well that should be possible without a problem. You do your changes in the jenkins pipeline first, then compile it on the machine with `mvn clean install` or a similar command and then simply copy it to ./artemis-docker/target/apache-artemis*-bin/*SNAPSHOT . After that just `docker-compose -f artemis-docker/docker-compose-final.yml up -d` and you are done. As I said multiple times before, we can't without modifying provided Dockerfile. For modification to happen tarball needs to be downloaded and extracted first. Issue Time Tracking --- Worklog Id: (was: 864879) Time Spent: 11.5h (was: 11h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 11.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=864861=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-864861 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 11/Jun/23 20:28 Start Date: 11/Jun/23 20:28 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1586327618 Well that should be possible without a problem. You do your changes in the jenkins pipeline first, then compile it on the machine with `mvn clean install` or a similar command and then simply copy it to ./artemis-docker/target/apache-artemis*-bin/*SNAPSHOT . After that just `docker-compose -f artemis-docker/docker-compose-final.yml up -d` and you are done. Issue Time Tracking --- Worklog Id: (was: 864861) Time Spent: 11h 20m (was: 11h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 11h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=864860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-864860 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 11/Jun/23 20:20 Start Date: 11/Jun/23 20:20 Worklog Time Spent: 10m Work Description: ViliusS commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1586326079 > What exactly is this step sh " our modifications and custom configuration goes here." and can't you simply do this before the jar is put into the container? The final build step is simply take the compiled jar with modifications if you like and put it into the various docker images. Modifications to web console for example. In the past this was also the place where we applied our own patches before building Artemis from source. Issue Time Tracking --- Worklog Id: (was: 864860) Time Spent: 11h 10m (was: 11h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 11h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=864852=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-864852 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 11/Jun/23 16:09 Start Date: 11/Jun/23 16:09 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1586233484 What exactly is this step sh " our modifications and custom configuration goes here." and can't you simply do this before the jar is put into the container? Issue Time Tracking --- Worklog Id: (was: 864852) Time Spent: 11h (was: 10h 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 11h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=864839=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-864839
]
ASF GitHub Bot logged work on ARTEMIS-3042:
---
Author: ASF GitHub Bot
Created on: 11/Jun/23 09:35
Start Date: 11/Jun/23 09:35
Worklog Time Spent: 10m
Work Description: ViliusS commented on PR #4307:
URL:
https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1586091960
I've went through couple of different YAML and bash solution iterations
today. I have also tested the solution provided in this PR. I still have to
conclude that at least for us multistage builds give more headache than it
solves.
My main concern, as mentioned previously, is that Artemis preparation
process will be integrated into Docker image which doesn't allow for easy
customization. For example previously we had such Jenkins CI pipeline:
```
stage('prepare configuration') {
steps {
sh "./prepare-docker.sh --from-release --artemis-version
$ARTEMIS_VERSION"
sh " our modifications and custom configuration goes
here."
}
}
stage('build image') {
steps {
script {
docker.withRegistry(env.DOCKER__REPOSITORY, env.DOCKER_LOGIN) {
sh '''
cd _TMP_/artemis/$ARTEMIS_VERSION
docker build -f ./docker/Dockerfile-ubuntu-17-jre -t
$BUILD_IMAGE $BUILD_DIR
docker push $BUILD_IMAGE
rm -rf _TMP_
'''
}
}
}
}
```
If this PR is ought to be accepted we won't be able to modify Artemis image
as easily anymore. We would need to download official docker file, modify it by
using "patch" or similar tools and only then build our image. This means we
would need to maintain our own Dockerfile which looses the purpose of having
official Docker file altogether. It also integrates preparation process into
build process which lowers visibility in Jenkins (or any other CI system) UI.
The final word will be on Artemis maintainers, by my proposal is to leave
current Docker files as their are. If building Artemis images for fast local
development is really a problem (which I don't think it is to run 2 commands
instead of 1), then have separate Docker files. Or better yet, have official
Docker image uploaded to Docker Hub for easy run with default settings. That
way Docker files can stay in the repo for those wanting to modify the image.
On a side note, what I would really want to see happening is proper
customization via environment variables or Docker entrypoint as mentioned in
[ARTEMIS-3042](https://issues.apache.org/jira/browse/ARTEMIS-3042).
Issue Time Tracking
---
Worklog Id: (was: 864839)
Time Spent: 10h 50m (was: 10h 40m)
> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
> Labels: docker,, dockerfile,, kubernetes
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to
> build or to setup Docker image that automatically builds the project from
> source, discards the build container and moves the necessary files over to
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at
> all.
>
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is very
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so
> complex, one will not be able to do this within one month without having gone
> through the whole documentation multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863592=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863592 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 02/Jun/23 22:29 Start Date: 02/Jun/23 22:29 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1574387883 > > The question is how minimal is the produced image? Could you create a docker-compose with a few steps that would satisfy the requirement for different base images? If we talk about a docker-compose yaml you also need suitable tooling in form of a docker compose cli plugin or v1 docker-compose. If you could easily switch between base images and select them by a build arg that would indeed be interesting. I am unfortunately currently pretty involved in other FOSS projects so if you could please go through creating said yaml I should be able to adapt the scripts and add the alpine image which was one of the reasons this pr exists. > > I didn't had much time lately, but I will try to come up with YAML file which does the same as this PR this week. > > Produced image won't change because this doesn't depend on a tooling. Compose plugin is installed by default with Docker Desktop, so it's not a problem either. It's implemented. It is now save to review and hopefully merge. Issue Time Tracking --- Worklog Id: (was: 863592) Time Spent: 10h 40m (was: 10.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 10h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863589=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863589 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 02/Jun/23 20:59 Start Date: 02/Jun/23 20:59 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1574308811 I removed the leftover tree command. I maybe can ditch all these sh files and build it with docker-compose. @ViliusS I'll try that today. Maybe I find a clever way to build that with docker-compose Issue Time Tracking --- Worklog Id: (was: 863589) Time Spent: 10.5h (was: 10h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 10.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863409=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863409
]
ASF GitHub Bot logged work on ARTEMIS-3042:
---
Author: ASF GitHub Bot
Created on: 02/Jun/23 08:57
Start Date: 02/Jun/23 08:57
Worklog Time Spent: 10m
Work Description: amarkevich commented on code in PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1214111564
##
artemis-docker/prepare-docker.sh:
##
@@ -181,10 +163,9 @@ if [ ! -d "${ARTEMIS_DIST_DIR}/docker" ]; then
mkdir "${ARTEMIS_DIST_DIR}/docker"
fi
-cp ./Dockerfile-* "$ARTEMIS_DIST_DIR/docker"
cp ./docker-run.sh "$ARTEMIS_DIST_DIR/docker"
echo "Docker file support files at:"
tree "$ARTEMIS_DIST_DIR/docker"
Review Comment:
'tree' command in L188 will cause build error since not available in build
stage. I propose to remove it like done in
https://github.com/apache/activemq-artemis/pull/4453/files#diff-09d0fd7b380274547af0cdaf1cb41c22b3990dfed9848b560e9d9f77b97fb204L188
or replace with 'ls -l'
Issue Time Tracking
---
Worklog Id: (was: 863409)
Time Spent: 10h 20m (was: 10h 10m)
> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
> Labels: docker,, dockerfile,, kubernetes
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to
> build or to setup Docker image that automatically builds the project from
> source, discards the build container and moves the necessary files over to
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at
> all.
>
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is very
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so
> complex, one will not be able to do this within one month without having gone
> through the whole documentation multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863352=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863352 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 02/Jun/23 05:39 Start Date: 02/Jun/23 05:39 Worklog Time Spent: 10m Work Description: ViliusS commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1573181473 > The question is how minimal is the produced image? Could you create a docker-compose with a few steps that would satisfy the requirement for different base images? If we talk about a docker-compose yaml you also need suitable tooling in form of a docker compose cli plugin or v1 docker-compose. If you could easily switch between base images and select them by a build arg that would indeed be interesting. I am unfortunately currently pretty involved in other FOSS projects so if you could please go through creating said yaml I should be able to adapt the scripts and add the alpine image which was one of the reasons this pr exists. I did had much time lately, but I will try to come up with YAML file which does the same as this PR this week. Produced image won't change because this doesn't depend on a tooling. Compose plugin is installed by default with Docker Desktop, so it's not a problem either. Issue Time Tracking --- Worklog Id: (was: 863352) Time Spent: 10h 10m (was: 10h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 10h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863351=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863351
]
ASF GitHub Bot logged work on ARTEMIS-3042:
---
Author: ASF GitHub Bot
Created on: 02/Jun/23 05:14
Start Date: 02/Jun/23 05:14
Worklog Time Spent: 10m
Work Description: SamTV12345 commented on code in PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1213930600
##
artemis-docker/prepare-docker.sh:
##
@@ -181,10 +163,9 @@ if [ ! -d "${ARTEMIS_DIST_DIR}/docker" ]; then
mkdir "${ARTEMIS_DIST_DIR}/docker"
fi
-cp ./Dockerfile-* "$ARTEMIS_DIST_DIR/docker"
cp ./docker-run.sh "$ARTEMIS_DIST_DIR/docker"
echo "Docker file support files at:"
tree "$ARTEMIS_DIST_DIR/docker"
Review Comment:
What exactly is still there? tree has been removed.
Issue Time Tracking
---
Worklog Id: (was: 863351)
Time Spent: 10h (was: 9h 50m)
> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
> Labels: docker,, dockerfile,, kubernetes
> Time Spent: 10h
> Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to
> build or to setup Docker image that automatically builds the project from
> source, discards the build container and moves the necessary files over to
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at
> all.
>
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is very
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so
> complex, one will not be able to do this within one month without having gone
> through the whole documentation multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863331=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863331
]
ASF GitHub Bot logged work on ARTEMIS-3042:
---
Author: ASF GitHub Bot
Created on: 01/Jun/23 22:22
Start Date: 01/Jun/23 22:22
Worklog Time Spent: 10m
Work Description: amarkevich commented on code in PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1213738138
##
artemis-docker/prepare-docker.sh:
##
@@ -181,10 +163,9 @@ if [ ! -d "${ARTEMIS_DIST_DIR}/docker" ]; then
mkdir "${ARTEMIS_DIST_DIR}/docker"
fi
-cp ./Dockerfile-* "$ARTEMIS_DIST_DIR/docker"
cp ./docker-run.sh "$ARTEMIS_DIST_DIR/docker"
echo "Docker file support files at:"
tree "$ARTEMIS_DIST_DIR/docker"
Review Comment:
its still there
Issue Time Tracking
---
Worklog Id: (was: 863331)
Time Spent: 9h 50m (was: 9h 40m)
> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
> Labels: docker,, dockerfile,, kubernetes
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to
> build or to setup Docker image that automatically builds the project from
> source, discards the build container and moves the necessary files over to
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at
> all.
>
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is very
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so
> complex, one will not be able to do this within one month without having gone
> through the whole documentation multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863324=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863324 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 01/Jun/23 21:08 Start Date: 01/Jun/23 21:08 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1572786478 > > command cached > > anyway 'tree' can be safely removed #4453 Removed. Issue Time Tracking --- Worklog Id: (was: 863324) Time Spent: 9h 40m (was: 9.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 9h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863207=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863207 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 01/Jun/23 09:24 Start Date: 01/Jun/23 09:24 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1571677805 > command cached anyway 'tree' can be safely removed https://github.com/apache/activemq-artemis/pull/4453 Issue Time Tracking --- Worklog Id: (was: 863207) Time Spent: 9.5h (was: 9h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 9.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863137=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863137 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/May/23 19:42 Start Date: 31/May/23 19:42 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1570835609 > Minor suggestion: > > > apt install tree curl -y > > can be replaced with existing tools: > > * tree -> ls -l (easy one) > * curl -> wget (more complex) This is performed in the builder section. This section is executed one time at the beginning of the pipeline. Any subsequent pipeline runs in the future will have this command cached and it will never be rerun as it is done just at the beginning. I tuned the Dockerfile to cache the things that are static like apt packages and add the dynamic parts of the app e.g. artemis at the end. Issue Time Tracking --- Worklog Id: (was: 863137) Time Spent: 9h 20m (was: 9h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 9h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863131 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/May/23 19:21 Start Date: 31/May/23 19:21 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1570801090 Minor suggestion: > apt install tree curl -y can be replaced with existing tools: - tree -> ls -l (easy one) - curl -> wget (more complex) Issue Time Tracking --- Worklog Id: (was: 863131) Time Spent: 9h 10m (was: 9h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 9h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=861586=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861586 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 11/May/23 16:38 Start Date: 11/May/23 16:38 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1191441472 ## artemis-image/pom.xml: ## @@ -0,0 +1,127 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + + org.apache.activemq + artemis-pom + 2.28.0-SNAPSHOT + + + artemis-image + Apache ActiveMQ Artemis Image + + Review Comment: there are some properties files and tests that are no harm deploy. the image tar won't ever get deployed Issue Time Tracking --- Worklog Id: (was: 861586) Time Spent: 9h (was: 8h 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 9h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=861585=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861585 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 11/May/23 16:37 Start Date: 11/May/23 16:37 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1191440293 ## pom.xml: ## @@ -68,6 +68,7 @@ artemis-features artemis-quorum-api artemis-quorum-ri + artemis-image Review Comment: I think it is ok now that the image build of the large tar is manual Issue Time Tracking --- Worklog Id: (was: 861585) Time Spent: 8h 50m (was: 8h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 8h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=861584=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861584 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 11/May/23 16:36 Start Date: 11/May/23 16:36 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1191439048 ## artemis-image/pom.xml: ## @@ -0,0 +1,127 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + + org.apache.activemq + artemis-pom + 2.28.0-SNAPSHOT + + + artemis-image + Apache ActiveMQ Artemis Image + + + Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 8h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=861583=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861583 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 11/May/23 16:35 Start Date: 11/May/23 16:35 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1191437953 ## artemis-image/README.md: ## @@ -0,0 +1,93 @@ +###What is in the image + +An _empty_, _open_ broker with a default acceptor on port 61616 + + - by empty: has no addresses or queues but will auto create on demand + - by open: has no security; authentication or authorization, users or roles + +###How will the image behave + + 1) the image will use or create `/app/data` for persistence of data + + 2) the image will use any [.properties files](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker_properties) from `/app/etc` to augment configuration + + 3) the image will use `/app/etc/broker.xml` if present, to bootstrap configuration, the 'bring your own config' use case + +###Build and Use + +First build an OCI image tar file from this artemis project using mvn: + + `$> mvn install` + +An OCI image is created as a tar file, that tar can be loaded into a registry, eg: + + `$> podman image load --input target/jib-image.tar` + +To run the image with host network access, localhost:61616 will be visible, use: + + `$> podman run --net=host localhost/target/activemq-artemis-image:<...>` Review Comment: I reverted to -p to port map 61616, dropping the net=host and podman will use a bridge network between the local host and the container. then we can inspect the container to find the IP and use that from our host. Podman needs permissions to create the network, hense will need sudo, but I think that is reasonable. Issue Time Tracking --- Worklog Id: (was: 861583) Time Spent: 8.5h (was: 8h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 8.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=861226=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861226 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 09/May/23 15:31 Start Date: 09/May/23 15:31 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1188786028 ## artemis-image/README.md: ## @@ -0,0 +1,97 @@ +###What is in the image + +An _empty_, _open_ broker with a default acceptor on port 61616 + + - by empty: has no addresses or queues but will auto create on demand + - by open: has no security; authentication or authorization, users or roles + +###How will the image behave + + 1) the image will use or create `/app/data` for persistence of data + + 2) the image will use any [.properties files](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker_properties) from `/app/etc` to augment configuration + + 3) the image will use `/app/etc/broker.xml` if present, to bootstrap configuration, the 'bring your own config' use case + +###Build and Use + +First build an OCI image tar file from this artemis project using mvn: + + `$> mvn install` + +An OCI image is created as a tar file. + +> *Note that any OCI compatible container runtime and registry can be used for the next steps, eg: docker, podman... I have used podman.* + +To load the image tar into a registry, use: + + `$> podman image load --input target/jib-image.tar` + +To run the image with host network access, localhost:61616 will be visible, use: + + `$> podman run --net=host localhost/target/activemq-artemis-image:<...>` + +Execute the artemis producer/consumer command line tools from a `local distribution` to validate: +Note: there is a `local distribution` in ../artemis-distribution/target/apache-artemis--bin/apache-artemis-/ Review Comment: agree, will remove the suggestion to use the local distro. ## artemis-image/README.md: ## @@ -0,0 +1,93 @@ +###What is in the image + +An _empty_, _open_ broker with a default acceptor on port 61616 + + - by empty: has no addresses or queues but will auto create on demand + - by open: has no security; authentication or authorization, users or roles + +###How will the image behave + + 1) the image will use or create `/app/data` for persistence of data + + 2) the image will use any [.properties files](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker_properties) from `/app/etc` to augment configuration + + 3) the image will use `/app/etc/broker.xml` if present, to bootstrap configuration, the 'bring your own config' use case + +###Build and Use + +First build an OCI image tar file from this artemis project using mvn: + + `$> mvn install` + +An OCI image is created as a tar file, that tar can be loaded into a registry, eg: + + `$> podman image load --input target/jib-image.tar` + +To run the image with host network access, localhost:61616 will be visible, use: + + `$> podman run --net=host localhost/target/activemq-artemis-image:<...>` + +Execute the artemis producer/consumer command line tools from a `local distribution` to validate: +Note: there is a `local distribution` in ../artemis-distribution/target/apache-artemis--bin/apache-artemis-/ + + `$> ./bin/artemis producer --url tcp://127.0.0.1:61616` + + `$> ./bin/artemis consumer --url tcp://127.0.0.1:61616` + +###Intent + +The intent is that this image is useful as is. If one can trust users, having no access control or limits can work fine. + +If not, then this image can be configured by mounting an `/app/etc` directory with property files that augment default configuration. +This image could also be the base for a derived jib image, by simply adding more property files to the `src/main/resources` directory. + +###Examples Review Comment: will sort. thanks Issue Time Tracking --- Worklog Id: (was: 861226) Time Spent: 8h 20m (was: 8h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 8h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=861225=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861225 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 09/May/23 15:30 Start Date: 09/May/23 15:30 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1188784971 ## artemis-image/README.md: ## @@ -0,0 +1,97 @@ +###What is in the image + +An _empty_, _open_ broker with a default acceptor on port 61616 Review Comment: I think it is simpler to utilise the sniffer and a single port. Issue Time Tracking --- Worklog Id: (was: 861225) Time Spent: 8h 10m (was: 8h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 8h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=861224=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861224 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 09/May/23 15:23 Start Date: 09/May/23 15:23 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1188775709 ## artemis-image/pom.xml: ## @@ -0,0 +1,127 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + + org.apache.activemq + artemis-pom + 2.28.0-SNAPSHOT + + + artemis-image + Apache ActiveMQ Artemis Image + + + Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 8h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=861223=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861223 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 09/May/23 15:22 Start Date: 09/May/23 15:22 Worklog Time Spent: 10m Work Description: gtully commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1188774969 ## artemis-image/pom.xml: ## @@ -0,0 +1,127 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + + org.apache.activemq + artemis-pom + 2.28.0-SNAPSHOT + + + artemis-image + Apache ActiveMQ Artemis Image + + + Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 7h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=860746=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860746 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 05/May/23 12:20 Start Date: 05/May/23 12:20 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1186022466 ## pom.xml: ## @@ -68,6 +68,7 @@ artemis-features artemis-quorum-api artemis-quorum-ri + artemis-image Review Comment: Probably wouldnt want this to be building on every build, so maybe shift to release profile (needs to be enabled then to update the versions) ## artemis-image/pom.xml: ## @@ -0,0 +1,127 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + + org.apache.activemq + artemis-pom + 2.28.0-SNAPSHOT + + + artemis-image + Apache ActiveMQ Artemis Image + + + Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 7h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=859416=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859416 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 27/Apr/23 14:39 Start Date: 27/Apr/23 14:39 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1525818660 The question is how minimal is the produced image? Could you create a docker-compose with a few steps that would satisfy the requirement for different base images? If we talk about a docker-compose yaml you also need suitable tooling in form of a docker compose cli plugin or v1 docker-compose. If you could easily switch between base images and select them by a build arg that would indeed be interesting. I am unfortunately currently pretty involved in other FOSS projects so if you could please go through creating said yaml I should be able to adapt the scripts and add the alpine image which was one of the reasons this pr exists. Issue Time Tracking --- Worklog Id: (was: 859416) Time Spent: 7.5h (was: 7h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 7.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=859390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859390 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 27/Apr/23 11:16 Start Date: 27/Apr/23 11:16 Worklog Time Spent: 10m Work Description: ViliusS commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1525509798 I gave this more thought today. In theory, if the requirement is to just conveniently allow users to build docker image and run it locally there is a docker-compose exactly for that purpose. All prepare/run steps can be automated via Docker Compose YAML file. It also allows for better build and runtime separation. Issue Time Tracking --- Worklog Id: (was: 859390) Time Spent: 7h 20m (was: 7h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 7h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=859321=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859321 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 27/Apr/23 06:19 Start Date: 27/Apr/23 06:19 Worklog Time Spent: 10m Work Description: ViliusS commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1524821751 > I think Docker multistage builds are great. I don't need to configure anything on the host machine and can simply press "build" in Jenkins. I don't argue that, but as I said, such images are great only for final deployment or local development. > Other than that you can still always customize the Dockerfile by cloning your own Dockerfile before docker build and replace the standard build with your own. I know that, however this PR changes the purpose of these Dockerfiles. Previously they contained only configuration needed for the runtime and served more as a tool to build your own custom images. Now they contain old the build flow inside, hence they now serve just as easier way to run Artemis. Issue Time Tracking --- Worklog Id: (was: 859321) Time Spent: 7h 10m (was: 7h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 7h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=859310=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859310 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 27/Apr/23 05:01 Start Date: 27/Apr/23 05:01 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1524703512 I think Docker multistage builds are great. I don't need to configure anything on the host machine and can simply press "build" in Jenkins. Other than that you can still always customize the Dockerfile by cloning your own Dockerfile before docker build and replace the standard build with your own. Issue Time Tracking --- Worklog Id: (was: 859310) Time Spent: 7h (was: 6h 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 7h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=859273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859273 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 26/Apr/23 22:26 Start Date: 26/Apr/23 22:26 Worklog Time Spent: 10m Work Description: ViliusS commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1524116640 I'm sorry, but I think this is a step back for CI workflows. Previously what you had to do to integrate Artemis docker builds into CI pipeline is just download provided Docker file + prepare/run.sh files in the pipeline from Artemis repository and run a few commands. This allowed us to add custom configuration or additional files to docker image itself. Now the preparation step is "hidden" inside docker file. So in order to customize the image we will need to customize provided Docker file which destroys the purpose of that file all together. Multistage docker builds are great for building the the software from source _for final deployment_, but they are not so great for processes which require customization. Issue Time Tracking --- Worklog Id: (was: 859273) Time Spent: 6h 50m (was: 6h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 6h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=858465=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858465 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 21/Apr/23 14:47 Start Date: 21/Apr/23 14:47 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1517948825 You're welcome :) Issue Time Tracking --- Worklog Id: (was: 858465) Time Spent: 6h 40m (was: 6.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 6h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=858454=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858454 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 21/Apr/23 14:35 Start Date: 21/Apr/23 14:35 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1517931191 @SamTV12345 thanks.. will merge before the release next week for sure Issue Time Tracking --- Worklog Id: (was: 858454) Time Spent: 6.5h (was: 6h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 6.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=844886=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844886 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 10/Feb/23 22:27 Start Date: 10/Feb/23 22:27 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1426421183 I am done including your feedback @clebertsuconic . You can now build images with Dockerfiles ending with build while the others can be used to build images regularly with the latest underlying image. cc @jbertram Issue Time Tracking --- Worklog Id: (was: 844886) Time Spent: 6h 20m (was: 6h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 6h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842850=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842850 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 01/Feb/23 12:04 Start Date: 01/Feb/23 12:04 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1411948204 I had the problem that it said Java heap space error because heap space was full. I then increased it with ENV MAVEN_OPTS="-Xmx3000m -XX:MaxPermSize=500m" to 3GB of heap space. Now it just states killed and an error code of 137. I still fail at the step mentioned in the screenshot. Issue Time Tracking --- Worklog Id: (was: 842850) Time Spent: 6h 10m (was: 6h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 6h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842777=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842777
]
ASF GitHub Bot logged work on ARTEMIS-3042:
---
Author: ASF GitHub Bot
Created on: 01/Feb/23 07:27
Start Date: 01/Feb/23 07:27
Worklog Time Spent: 10m
Work Description: SamTV12345 commented on PR #4307:
URL:
https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1411582053
Weird. Last time I waited 20 minutes and nothing changed. I am stuck at this
screen
https://user-images.githubusercontent.com/40429738/215977162-e8870da2-d03f-48a5-9696-12227864ea98.png;>
If you have time could you start this Dockerfile
yaml
ARG CURRENT_VERSION=2.17.0
FROM maven:3.8.7-eclipse-temurin-11 as builder
ARG CURRENT_VERSION
COPY settings.xml /.m2/settings.xml
ENV MAVEN_SETTINGS_PATH=/.m2/settings.xml
COPY . .
RUN mvn -ntp clean install -Prelease -DskipTests
-Dmaven.repo.local=/.m2/repository -s /.m2/settings.xml
FROM alpine:latest
ARG CURRENT_VERSION
ENV VERSION=$CURRENT_VERSION
RUN apk --no-cache add openjdk17-jre-headless bash libaio\
--repository=http://dl-cdn.alpinelinux.org/alpine/edge/community
LABEL maintainer="Apache ActiveMQ Team"
# Make sure pipes are considered to determine success, see:
https://github.com/hadolint/hadolint/wiki/DL4006
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
WORKDIR /opt
ENV ARTEMIS_USER artemis
ENV ARTEMIS_PASSWORD artemis
ENV ANONYMOUS_LOGIN false
ENV EXTRA_ARGS --http-host 0.0.0.0 --relax-jolokia
# add user and group for artemis
RUN addgroup -g 1001 artemis && adduser -u 1002 --ingroup artemis
--disabled-password artemis
USER artemis
COPY --from=builder /root/artemis-build/_TMP_/artemis/${VERSION}/
/opt/activemq-artemis
# Web Server
EXPOSE 8161 \
# JMX Exporter
9404 \
# Port for CORE,MQTT,AMQP,HORNETQ,STOMP,OPENWIRE
61616 \
# Port for HORNETQ,STOMP
5445 \
# Port for AMQP
5672 \
# Port for MQTT
1883 \
#Port for STOMP
61613
USER root
RUN mkdir /var/lib/artemis-instance && chown -R artemis.artemis
/var/lib/artemis-instance
COPY --from=builder
/root/artemis-build/_TMP_/artemis/${VERSION}/docker/docker-run.sh /
USER artemis
# Expose some outstanding folders
VOLUME ["/var/lib/artemis-instance"]
WORKDIR /var/lib/artemis-instance
ENTRYPOINT ["/docker-run.sh"]
CMD ["run"]
```
If you don't have a settings.xml defined you need to remove the instructions
COPY settings.xml /.m2/settings.xml, ENV MAVEN_SETTINGS_PATH=/.m2/settings.xml
and the part in the mvn clean install script starting with -Dnaveb.repo.local...
After copying the Dockerfile in artemis-docker, execute from the root of the
project execute `docker build -t test -f
./artemis-docker/Dockerfile-build-alpine .`
It is currently not working I just want to make sure that the build in the
Dockerfile is working
The specs of my proxmox test machine are:
i5 4570T and 16 Gigabyte RAM.
The alpine Linux LXC for building has all cores and 8 Gigabyte assigned.
Issue Time Tracking
---
Worklog Id: (was: 842777)
Time Spent: 6h (was: 5h 50m)
> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
> Labels: docker,, dockerfile,, kubernetes
> Time Spent: 6h
> Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to
> build or to setup Docker image that automatically builds the project from
> source, discards the build container and moves the necessary files over to
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at
> all.
>
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is very
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so
> complex, one will not be able to do this within one month without having gone
> through the whole documentation multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842727=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842727 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 23:56 Start Date: 31/Jan/23 23:56 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1411232814 Those numbers seem excessive to me. When I eliminate the time required to download artifacts by first using `mvn dependency:go-offline` and then run: ``` mvn -o clean install -Prelease -DskipTests ``` It finishes in half the time you're reporting: ``` [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 05:18 min [INFO] Finished at: 2023-01-31T17:32:56-06:00 [INFO] ``` Also the maximum heap usage is _barely_ over 2G:  I'm running this on a laptop that's not particularly fancy. Issue Time Tracking --- Worklog Id: (was: 842727) Time Spent: 5h 50m (was: 5h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 5h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842710=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842710 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 21:51 Start Date: 31/Jan/23 21:51 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-147192 Thanks for creating the pr. I will checkout your commit hopefully this week. It seems like the release profile really takes a long time. 4GB weren't enough for testing. So the question is how many times would somebody do that when it takes more than 10 minutes to compile. Issue Time Tracking --- Worklog Id: (was: 842710) Time Spent: 5h 40m (was: 5.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 5h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842705=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842705 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 21:30 Start Date: 31/Jan/23 21:30 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1411094791 I rarely (if ever) use Maven's offline mode as downloading dependencies isn't a problem for me, but I sent #4355 to support those who need it. Hope that helps! Issue Time Tracking --- Worklog Id: (was: 842705) Time Spent: 5.5h (was: 5h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 5.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842695=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842695 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 20:58 Start Date: 31/Jan/23 20:58 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1411061460 Looks like this can be fixed by adding this to the `` of the main `pom.xml`: ```xml Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 5h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842694=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842694 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 20:46 Start Date: 31/Jan/23 20:46 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1411047621 That should work without a problem. But you need to be aware that this will always download every dependency when you make a change in any file of the project. Issue Time Tracking --- Worklog Id: (was: 842694) Time Spent: 5h 10m (was: 5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 5h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842693=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842693 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 20:45 Start Date: 31/Jan/23 20:45 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1411046396 I reproduced the error by executing `mvn dependency:go-offline`. It's not clear to me whether the problem is in the ActiveMQ Artemis `pom.xml` or in one of Netty's. What happens if you just run `mvn -Prelease install -DskipTests`? Issue Time Tracking --- Worklog Id: (was: 842693) Time Spent: 5h (was: 4h 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842689=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842689 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 20:28 Start Date: 31/Jan/23 20:28 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1411021983 I executed `mvn dependency:resolve-plugins dependency:go-offline` on my branch to cache dependencies. Issue Time Tracking --- Worklog Id: (was: 842689) Time Spent: 4h 50m (was: 4h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 4h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842686=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842686 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 20:11 Start Date: 31/Jan/23 20:11 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1410999015 @SamTV12345, I'm not sure where that's coming from. Searching the code-base for `os.detected.classifier` turns up 0 results. What exact command did you execute and what branch are you on? Issue Time Tracking --- Worklog Id: (was: 842686) Time Spent: 4h 40m (was: 4.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 4h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842669=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842669
]
ASF GitHub Bot logged work on ARTEMIS-3042:
---
Author: ASF GitHub Bot
Created on: 31/Jan/23 19:15
Start Date: 31/Jan/23 19:15
Worklog Time Spent: 10m
Work Description: SamTV12345 commented on PR #4307:
URL:
https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1410931010
When I do a build I get this error:
io.netty:netty-tcnative:jar:${os.detected.classifier}:2.0.54.Final . @jbertram
Do you know where that comes from and are there more of these properties?
Issue Time Tracking
---
Worklog Id: (was: 842669)
Time Spent: 4.5h (was: 4h 20m)
> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
> Labels: docker,, dockerfile,, kubernetes
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to
> build or to setup Docker image that automatically builds the project from
> source, discards the build container and moves the necessary files over to
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at
> all.
>
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is very
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so
> complex, one will not be able to do this within one month without having gone
> through the whole documentation multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842643=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842643 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 17:25 Start Date: 31/Jan/23 17:25 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1410780986 @SamTV12345, FWIW instructions on how to build are in the ["Building" chapter of the Hacking Guide](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/en/building.md): > To build the full release with documentation, Javadocs, and the full web site: > > `$ mvn -Prelease package` > > To install it to your local maven repo: > > `$ mvn -Prelease install` I would add `-DskipTests` to speed up the build significantly. Issue Time Tracking --- Worklog Id: (was: 842643) Time Spent: 4h 20m (was: 4h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 4h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842547=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842547 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 11:54 Start Date: 31/Jan/23 11:54 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1410220084 This error seems to be correct. I currently download the jar from the apache downloads and copy it into the alpine/centos/ubuntu image. But if you use it for development I have two options: 1. Create a new Dockerfile for building the image. 2. Modify the existing Dockerfile. Which one do you prefer? Issue Time Tracking --- Worklog Id: (was: 842547) Time Spent: 4h 10m (was: 4h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 4h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=842517=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842517 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/Jan/23 10:59 Start Date: 31/Jan/23 10:59 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1410154189 This looks nice, although I was not able to build the distribution I am building itself. and I'm a bit confused on how I am supposed to use this. I just built it. Went to artemis-distribution/target/apache-artemis-2.28.0-SNAPSHOT-bin/apache-artemis-2.28.0-SNAPSHOT and typed: podman build -f ../../../../artemis-docker/Dockerfile-alpine -t clebert-alpine . I was not able to build it. got an error If I removed the . I would always build a 2.17 image I'm puzzled on how I'm supposed to use your change. I will defer this PR to next version (that shouldn't be long) Issue Time Tracking --- Worklog Id: (was: 842517) Time Spent: 4h (was: 3h 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 4h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=841634=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841634 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 25/Jan/23 20:25 Start Date: 25/Jan/23 20:25 Worklog Time Spent: 10m Work Description: tabish121 commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1087132563 ## artemis-image/README.md: ## @@ -0,0 +1,93 @@ +###What is in the image + +An _empty_, _open_ broker with a default acceptor on port 61616 + + - by empty: has no addresses or queues but will auto create on demand + - by open: has no security; authentication or authorization, users or roles + +###How will the image behave + + 1) the image will use or create `/app/data` for persistence of data + + 2) the image will use any [.properties files](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker_properties) from `/app/etc` to augment configuration + + 3) the image will use `/app/etc/broker.xml` if present, to bootstrap configuration, the 'bring your own config' use case + +###Build and Use + +First build an OCI image tar file from this artemis project using mvn: + + `$> mvn install` + +An OCI image is created as a tar file, that tar can be loaded into a registry, eg: + + `$> podman image load --input target/jib-image.tar` + +To run the image with host network access, localhost:61616 will be visible, use: + + `$> podman run --net=host localhost/target/activemq-artemis-image:<...>` Review Comment: I got stuck on this step so possibly more information needed here. When running this I get a couple connection refused errors when trying to pull image. Issue Time Tracking --- Worklog Id: (was: 841634) Time Spent: 3h 50m (was: 3h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 3h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=841574=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841574 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 25/Jan/23 16:05 Start Date: 25/Jan/23 16:05 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4297: URL: https://github.com/apache/activemq-artemis/pull/4297#discussion_r1086751779 ## artemis-image/README.md: ## @@ -0,0 +1,93 @@ +###What is in the image + +An _empty_, _open_ broker with a default acceptor on port 61616 + + - by empty: has no addresses or queues but will auto create on demand + - by open: has no security; authentication or authorization, users or roles + +###How will the image behave + + 1) the image will use or create `/app/data` for persistence of data + + 2) the image will use any [.properties files](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker_properties) from `/app/etc` to augment configuration + + 3) the image will use `/app/etc/broker.xml` if present, to bootstrap configuration, the 'bring your own config' use case + +###Build and Use + +First build an OCI image tar file from this artemis project using mvn: + + `$> mvn install` + +An OCI image is created as a tar file, that tar can be loaded into a registry, eg: + + `$> podman image load --input target/jib-image.tar` + +To run the image with host network access, localhost:61616 will be visible, use: + + `$> podman run --net=host localhost/target/activemq-artemis-image:<...>` Review Comment: Is there a "so" missing in ", localhost:61616 will be visible,"? Or why not just show mapping port(s) specifically, as most examples typically tend to? I see some issues suggesting --net=host doesnt work on all OS. Expanding/hinting on whats expected to be in the "\<...\>" might be useful to some folks... ## artemis-image/README.md: ## @@ -0,0 +1,93 @@ +###What is in the image + +An _empty_, _open_ broker with a default acceptor on port 61616 + + - by empty: has no addresses or queues but will auto create on demand + - by open: has no security; authentication or authorization, users or roles + +###How will the image behave + + 1) the image will use or create `/app/data` for persistence of data + + 2) the image will use any [.properties files](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker_properties) from `/app/etc` to augment configuration Review Comment: Should it be more specific? E.g what if you want to tweak the logging configuration .properties, where does that file go? Etc seems obvious.. ## artemis-image/README.md: ## @@ -0,0 +1,97 @@ +###What is in the image + +An _empty_, _open_ broker with a default acceptor on port 61616 Review Comment: Why not the usual default set, with other e.g IANA registered ports? ## artemis-image/pom.xml: ## @@ -0,0 +1,127 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + + org.apache.activemq + artemis-pom + 2.28.0-SNAPSHOT + + + artemis-image + Apache ActiveMQ Artemis Image + + + Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 3h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=833214=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-833214 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Dec/22 22:01 Start Date: 13/Dec/22 22:01 Worklog Time Spent: 10m Work Description: SamTV12345 commented on code in PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1047796359 ## artemis-docker/Dockerfile-ubuntu-11-jre: ## @@ -17,7 +17,30 @@ # ActiveMQ Artemis +ARG CURRENT_VERSION=2.17.0 + +FROM eclipse-temurin:11-jdk as builder +ARG CURRENT_VERSION + +ENV VERSION=$CURRENT_VERSION + +RUN apt update -y && apt upgrade -y && apt install tree curl -y + +ADD ./prepare-docker.sh /bin/prepareDocker +WORKDIR /root/artemis-build +COPY ./Dockerfile-alpine . Review Comment: It doesn't matter as I don't need the Dockerfile in my multistage build. So I removed the line in the prepareDocker script that checks if a Dockerfile* is available. It still works as expected. Issue Time Tracking --- Worklog Id: (was: 833214) Time Spent: 3.5h (was: 3h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 3.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=833212=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-833212 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Dec/22 21:59 Start Date: 13/Dec/22 21:59 Worklog Time Spent: 10m Work Description: SamTV12345 commented on code in PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1047795086 ## artemis-docker/readme.md: ## @@ -1,140 +1,62 @@ # Docker Image Example This is an example on how you could create your own Docker Image For Apache -ActiveMQ Artemis based on CentOS or Ubuntu (Eclipse Temurin JDK images). +ActiveMQ Artemis based on Alpine, CentOS or Ubuntu (Eclipse Temurin JDK images). -# Preparing +# Selecting the image -Use the script ./prepare-docker.sh as it will copy the docker files under the -binary distribution. +This folder contains four different images for hosting your ActiveMQ Artemis instance in docker -Below is shown the command to prepare the build of the Docker Image starting -from the local distribution (from the source codes of ActiveMQ Artemis) +- Alpine +- CentOS7 +- Ubuntu 11 with JDK +- Ubuntu 11 with JRE Review Comment: You're right. Issue Time Tracking --- Worklog Id: (was: 833212) Time Spent: 3h 20m (was: 3h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 3h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=833180=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-833180 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 13/Dec/22 19:43 Start Date: 13/Dec/22 19:43 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1047631946 ## artemis-docker/Dockerfile-centos7-11: ## @@ -17,12 +17,30 @@ # ActiveMQ Artemis +ARG CURRENT_VERSION=2.17.0 + +FROM eclipse-temurin:11-jdk as builder +ARG CURRENT_VERSION + +ENV VERSION=$CURRENT_VERSION + +RUN apt update -y && apt upgrade -y && apt install tree curl -y + +ADD ./prepare-docker.sh /bin/prepareDocker +WORKDIR /root/artemis-build +COPY ./Dockerfile-alpine . Review Comment: Shouldn't this be `COPY ./Dockerfile-centos7-11 .`? ## artemis-docker/readme.md: ## @@ -1,140 +1,62 @@ # Docker Image Example This is an example on how you could create your own Docker Image For Apache -ActiveMQ Artemis based on CentOS or Ubuntu (Eclipse Temurin JDK images). +ActiveMQ Artemis based on Alpine, CentOS or Ubuntu (Eclipse Temurin JDK images). -# Preparing +# Selecting the image -Use the script ./prepare-docker.sh as it will copy the docker files under the -binary distribution. +This folder contains four different images for hosting your ActiveMQ Artemis instance in docker -Below is shown the command to prepare the build of the Docker Image starting -from the local distribution (from the source codes of ActiveMQ Artemis) +- Alpine +- CentOS7 +- Ubuntu 11 with JDK +- Ubuntu 11 with JRE Review Comment: `11` isn't the version of Ubuntu. It is the version of _Java_. Therefore, the list should probably be: - Alpine (latest) with JRE 11 - CentOS 7 with JDK 11 - Ubuntu (latest LTS) with JDK 11 - Ubuntu (latest LTS) with JRE 11 ## artemis-docker/Dockerfile-ubuntu-11: ## @@ -17,8 +17,28 @@ # ActiveMQ Artemis +ARG CURRENT_VERSION=2.17.0 + +FROM eclipse-temurin:11-jdk as builder +ARG CURRENT_VERSION + +ENV VERSION=$CURRENT_VERSION + +RUN apt update -y && apt upgrade -y && apt install tree curl -y + +ADD ./prepare-docker.sh /bin/prepareDocker +WORKDIR /root/artemis-build +COPY ./Dockerfile-alpine . Review Comment: Shouldn't this be `COPY ./Dockerfile-ubuntu-11 .`? ## artemis-docker/Dockerfile-ubuntu-11-jre: ## @@ -17,7 +17,30 @@ # ActiveMQ Artemis +ARG CURRENT_VERSION=2.17.0 + +FROM eclipse-temurin:11-jdk as builder +ARG CURRENT_VERSION + +ENV VERSION=$CURRENT_VERSION + +RUN apt update -y && apt upgrade -y && apt install tree curl -y + +ADD ./prepare-docker.sh /bin/prepareDocker +WORKDIR /root/artemis-build +COPY ./Dockerfile-alpine . Review Comment: Shouldn't this be `COPY ./Dockerfile-ubuntu-11-jre .`? Issue Time Tracking --- Worklog Id: (was: 833180) Time Spent: 3h 10m (was: 3h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 3h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832848=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832848 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 12/Dec/22 18:55 Start Date: 12/Dec/22 18:55 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1347085745 > I'd like to get this pr merged as soon as possible so I can move on to the next ticket. Is this PR a dependency for another task you're working on? I think most folks work on tasks in parallel. Once they send a PR they move on to their next task knowing that the PR will be reviewed and merged asynchronously. > I guess it doesn't make much sense that I create a lot of pr's that don't get merged at the end. Have you created other PRs that haven't been merged? I looked through the list of open and closed PRs and I don't see any others from you. Perhaps you used a different account when you created those? Issue Time Tracking --- Worklog Id: (was: 832848) Time Spent: 3h (was: 2h 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 3h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832843=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832843 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 12/Dec/22 18:09 Start Date: 12/Dec/22 18:09 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1346977453 Thanks for reporting back. I'd like to get this pr merged as soon as possible so I can move on to the next ticket. I guess it doesn't make much sense that I create a lot of pr's that don't get merged at the end. But I can understand that you have other priorities. I'll wait till I hear back from you. Issue Time Tracking --- Worklog Id: (was: 832843) Time Spent: 2h 50m (was: 2h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 2h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832828=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832828 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 12/Dec/22 17:47 Start Date: 12/Dec/22 17:47 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1346947440 @clebertsuconic, can you take a look at this since I believe you originally created the Docker files. Issue Time Tracking --- Worklog Id: (was: 832828) Time Spent: 2h 40m (was: 2.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 2h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832826=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832826 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 12/Dec/22 17:46 Start Date: 12/Dec/22 17:46 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1346946939 I'm still in the process of testing all the changes locally. I have other priorities on my plate at the moment so progress has stopped at the moment. @SamTV12345, is there any particular rush to get this merged? If so, how come? Issue Time Tracking --- Worklog Id: (was: 832826) Time Spent: 2.5h (was: 2h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 2.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832823=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832823 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 12/Dec/22 17:41 Start Date: 12/Dec/22 17:41 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1346940618 I guess this pr can be merged. Issue Time Tracking --- Worklog Id: (was: 832823) Time Spent: 2h 20m (was: 2h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 2h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832482=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832482 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 09/Dec/22 22:51 Start Date: 09/Dec/22 22:51 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1344861530 I'm done. I adapted the README.md to reflect the changes in the build process and added the multistage capability to every Dockerfile. Issue Time Tracking --- Worklog Id: (was: 832482) Time Spent: 2h 10m (was: 2h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 2h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832458=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832458 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 09/Dec/22 21:04 Start Date: 09/Dec/22 21:04 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1344780981 At this point two main things are not clear in your commit: 1. How to use your new Docker file. 2. How your new Docker file fits with the other Docker files already available. To resolve #1 you should probably just add some documentation. You could do this, for example, in the `artemis-docker/readme.md`. To resolve #2 you might also just add documentation. However, if the approach you've taken in this new Docker file is superior to the approach offered by the existing Docker files then it may be worth updating those to use your new approach so that users don't need to run `prepare-docker.sh` manually but they still have the option of using CentOS & Ubuntu with JDK or JRE. Issue Time Tracking --- Worklog Id: (was: 832458) Time Spent: 2h (was: 1h 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 2h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832363 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 09/Dec/22 14:17 Start Date: 09/Dec/22 14:17 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1344363836 When will this be merged? Is there something to do from my side? Issue Time Tracking --- Worklog Id: (was: 832363) Time Spent: 1h 50m (was: 1h 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 1h 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=832087=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832087 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 08/Dec/22 14:02 Start Date: 08/Dec/22 14:02 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1342784850 Seems like the failing test is not the cause of my commit. The other pr is also failing. Issue Time Tracking --- Worklog Id: (was: 832087) Time Spent: 1h 40m (was: 1.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 1h 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831877=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831877 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 20:40 Start Date: 07/Dec/22 20:40 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1341567111 The other two files are solved. Seems Windows/IntelliJ doesn't add a newline to the file. Issue Time Tracking --- Worklog Id: (was: 831877) Time Spent: 1.5h (was: 1h 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 1.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831876=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831876 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 20:33 Start Date: 07/Dec/22 20:33 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1341558876 > It's not clear to me how your changes are directly related to https://issues.apache.org/jira/browse/ARTEMIS-3042 aside from just the wording. Your commit is just adding a new Dockerfile which is similar to the three other Dockerfiles which are already present. These three Dockerfiles were also already present when ARTEMIS-3042 was opened originally. The Jira description even says, "The current docker image build is not really user friendly or convenient at all." Therefore, adding another version of what already exists doesn't seem to help resolve the issue. Can you shed any light on this? A docker multistage build contains one or multiple steps of building an image and one final image that is used during runtime. A multistage build has the advantage that some components are only needed during build time leading to a smaller footprint. It also has the charm that I don't need to know anything about building this image. Everything is handled during build process. Before my pr you had to follow the guides, run the script, cd into the _TMP/artemis/version folder and start the build process. This can be teadious and result in user errors: At first I forgot to change to that directory I had to read through the proprietary instructions to this project. Now you can start directly with building. Just use the Dockerfile as you would with any other Dockerfile and execute ```docker build -t myartemis -f Dockerfile-alpine .``` You don't need to go through any instructions and have a standardized process of building images. If you agree I would remove the other Dockerfiles as they are not needed anymore and may confuse the end user. Issue Time Tracking --- Worklog Id: (was: 831876) Time Spent: 1h 20m (was: 1h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 1h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831870=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831870 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 19:47 Start Date: 07/Dec/22 19:47 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1042614403 ## artemis-docker/prepare-docker.sh: ## @@ -187,4 +187,4 @@ cp ./docker-run.sh "$ARTEMIS_DIST_DIR/docker" echo "Docker file support files at:" tree "$ARTEMIS_DIST_DIR/docker" -next_step +next_step Review Comment: This change also isn't necessary. Issue Time Tracking --- Worklog Id: (was: 831870) Time Spent: 1h 10m (was: 1h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 1h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831869=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831869 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 19:46 Start Date: 07/Dec/22 19:46 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1042613939 ## artemis-docker/docker-run.sh: ## @@ -44,6 +44,4 @@ else echo "broker already created, ignoring creation" fi -exec ./bin/artemis "$@" - - +exec ./bin/artemis "$@" Review Comment: This change isn't necessary. Issue Time Tracking --- Worklog Id: (was: 831869) Time Spent: 1h (was: 50m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 1h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831868=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831868 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 19:45 Start Date: 07/Dec/22 19:45 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1341501883 To be clear, I am happy to merge your commit eventually. I just want the Jira/commit association to be clear for posterity's sake. Issue Time Tracking --- Worklog Id: (was: 831868) Time Spent: 50m (was: 40m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 50m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831867=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831867 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 19:44 Start Date: 07/Dec/22 19:44 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1341500113 It's not clear to me how your changes are directly related to https://issues.apache.org/jira/browse/ARTEMIS-3042 aside from just the wording. Your commit is just adding a new Dockerfile which is similar to the three other Dockerfiles which are already present. These three Dockerfiles were also already present when ARTEMIS-3042 was opened originally. The Jira description even says, "The current docker image build is not really user friendly or convenient at all." Therefore, adding another version of what already exists doesn't seem to help resolve the issue. Can you shed any light on this? Issue Time Tracking --- Worklog Id: (was: 831867) Time Spent: 40m (was: 0.5h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 40m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831860 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 19:26 Start Date: 07/Dec/22 19:26 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1341481897 If there are any further questions I am more than welcome to answer them. Issue Time Tracking --- Worklog Id: (was: 831860) Time Spent: 0.5h (was: 20m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 0.5h > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831627=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831627 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 05:47 Start Date: 07/Dec/22 05:47 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1340403897 Thanks for the hint. I added a message according to your guidelines. This pr solves exactly that issue. Issue Time Tracking --- Worklog Id: (was: 831627) Time Spent: 20m (was: 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=828956=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828956 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 25/Nov/22 13:19 Start Date: 25/Nov/22 13:19 Worklog Time Spent: 10m Work Description: gtully opened a new pull request, #4297: URL: https://github.com/apache/activemq-artemis/pull/4297 This module builds an OCI image tar, based around a broker Main class, that can be configured with property files and/or xml. The intent is to be a simple as possible but still be useful. See the README.md for details. Issue Time Tracking --- Worklog Id: (was: 828956) Remaining Estimate: 0h Time Spent: 10m > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
